28398085302

Committed 29 Jun 2026 07:43PM UTC coverage: 50.067% (-2.2%) from 52.278%

Build # 28398085302

Build Type

Pull #83

github

Committed by

web-flow

Commit Message

Merge 9a615085e into 2efed6649

Pull Request Pull Request #83: refactor and improve code QoL

Coverage Stats

16342 of 44293 branches covered (36.9%)

Branch coverage included in aggregate %.

613 of 1132 new or added lines in 52 files covered. (54.15%)

687 existing lines in 116 files now uncovered.

21698 of 31685 relevant lines covered (68.48%)

12958.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.0

/src/dftracer/utils/core/utils/string.cpp

#include <dftracer/utils/core/utils/string.h>

namespace dftracer::utils {
namespace {
inline bool is_json_ws(char c) {
    return c == ' ' || c == '\t' || c == '\n' || c == '\r';
}

bool json_trim_impl(const char* data, std::size_t length, const char*& start,
                    std::size_t& trimmed_length, bool trim_trailing_comma) {
    start = data;
    const char* end = data + length - 1;

    while (start <= end && is_json_ws(*start)) {
        start++;
    }
    while (end >= start && is_json_ws(*end)) {
        end--;
    }

    // Trailing commas appear in the JSON array format.
    if (trim_trailing_comma && end >= start && *end == ',') {
        end--;
    }

    trimmed_length = (end >= start) ? (end - start + 1) : 0;

    if (trimmed_length == 0 ||
        (trimmed_length == 1 &&
         (*start == '[' || *start == '{' || *start == ']' || *start == '}')) ||
        (trimmed_length == 2 && start[0] == ']' && start[1] == '[')) {
        // Invalid/incomplete JSON or file boundary artifact
        return false;
    }

    return true;
}
}  // namespace

bool json_trim_and_validate(const char* data, std::size_t length,
                            const char*& start, std::size_t& trimmed_length) {
    return json_trim_impl(data, length, start, trimmed_length, false);
}

bool json_trim_and_validate_with_comma(const char* data, std::size_t length,
                                       const char*& start,
                                       std::size_t& trimmed_length) {
    return json_trim_impl(data, length, start, trimmed_length, true);
}
}  // namespace dftracer::utils

1	#include <dftracer/utils/core/utils/string.h>
2
3	namespace dftracer::utils {
4	namespace {
5	inline bool is_json_ws(char c) {	14,658✔
6	return c == ' ' \|\| c == '\t' \|\| c == '\n' \|\| c == '\r';	14,658!
7	}
8
9	bool json_trim_impl(const char* data, std::size_t length, const char*& start,	7,398✔
10	std::size_t& trimmed_length, bool trim_trailing_comma) {
11	start = data;	7,398✔
12	const char* end = data + length - 1;	7,398✔
13
14	while (start <= end && is_json_ws(*start)) {	7,398!
UNCOV 15	start++;	×
16	}
17	while (end >= start && is_json_ws(*end)) {	7,326!
UNCOV 18	end--;	×
19	}
20
21	// Trailing commas appear in the JSON array format.
22	if (trim_trailing_comma && end >= start && *end == ',') {	7,333!
23	end--;	2,028✔
24	}
25
26	trimmed_length = (end >= start) ? (end - start + 1) : 0;	7,333✔
27
28	if (trimmed_length == 0 \|\|	7,333!
29	(trimmed_length == 1 &&	7,339✔
30	(start == '[' \|\| start == '{' \|\| start == ']' \|\| start == '}')) \|\|	174!
31	(trimmed_length == 2 && start[0] == ']' && start[1] == '[')) {	7,165!
32	// Invalid/incomplete JSON or file boundary artifact
33	return false;	173✔
34	}
35
36	return true;	7,160✔
37	}
38	} // namespace
39
40	bool json_trim_and_validate(const char* data, std::size_t length,	1,740✔
41	const char*& start, std::size_t& trimmed_length) {
42	return json_trim_impl(data, length, start, trimmed_length, false);	1,740✔
43	}
44
45	bool json_trim_and_validate_with_comma(const char* data, std::size_t length,	5,652✔
46	const char*& start,
47	std::size_t& trimmed_length) {
48	return json_trim_impl(data, length, start, trimmed_length, true);	5,652✔
49	}
50	} // namespace dftracer::utils

llnl / dftracer-utils / 28398085302

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous