safe-global / safe-cli / 28366111867

push

github

Fix correctness bugs and clean up dead code across CLI (#638)

Found during a full-codebase review. Main fixes:

- tx-builder decoder: preserve tuple-array suffix (tuple[], tuple[N]) so the
  selector and ABI encoding match; require 0x prefix for hex ints; clear errors
  for missing/null contract input values; coerce tx value to int
- tx-service operator: return after "owner not loaded" guards to avoid a
  None-deref crash and posting empty signatures
- safe_operator: harden no-arg exception handling, make change_*/update_version*
  always return bool, reject threshold < 1, fix cached nonce with custom
  --safe-nonce, clearer empty-seed error
- main: respect empty SAFE_CLI_INTERACTIVE, route lowercase addresses to
  attended mode
- prompt_parser: use shlex.split so quoted args parse correctly
- ledger: fix exception-message match for USB write errors
- hd wallet: stop overriding a custom hd_path when index is set
- lexer/completer: fix address/tx-hash regex, fix argument coloring, drop dead
  entries

35 of 57 new or added lines in 9 files covered. (61.4%)

3007 of 3376 relevant lines covered (89.07%)

3.55 hits per line