28356348514

Committed 29 Jun 2026 07:40AM UTC coverage: 52.174% (-0.1%) from 52.278%

Build # 28356348514

Build Type

Pull #83

github

Committed by

web-flow

Commit Message

Merge 278203630 into 2efed6649

Pull Request Pull Request #83: refactor and improve code QoL

Coverage Stats

37276 of 92891 branches covered (40.13%)

Branch coverage included in aggregate %.

671 of 1173 new or added lines in 58 files covered. (57.2%)

66 existing lines in 30 files now uncovered.

33619 of 42991 relevant lines covered (78.2%)

20387.45 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

35.42

/src/dftracer/utils/python/py_runtime_mixin.h

#ifndef DFTRACER_UTILS_PYTHON_PY_RUNTIME_MIXIN_H
#define DFTRACER_UTILS_PYTHON_PY_RUNTIME_MIXIN_H

#include <Python.h>
#include <dftracer/utils/python/runtime.h>

#include <string>

// Shared implementation for utility objects whose layout is exactly:
//     typedef struct { PyObject_HEAD PyObject *runtime_obj; } XObject;
// Each binding kept re-rolling an identical runtime-resolution / tp_new /
// tp_dealloc / tp_init quartet; these templates single-source it.

// Resolve the backing Runtime: the explicitly-bound one, else the default.
template <typename T>
dftracer::utils::Runtime *resolve_runtime(T *self) {
    if (self->runtime_obj)
        return ((RuntimeObject *)self->runtime_obj)->runtime.get();
    return get_default_runtime();
}

template <typename T>
PyObject *runtime_backed_new(PyTypeObject *type, PyObject *, PyObject *) {
    T *self = (T *)type->tp_alloc(type, 0);
    if (self) self->runtime_obj = NULL;
    return (PyObject *)self;
}

template <typename T>
void runtime_backed_dealloc(T *self) {
    Py_XDECREF(self->runtime_obj);
    Py_TYPE(self)->tp_free((PyObject *)self);
}

// Parse an optional `runtime=` kwarg (a Runtime instance, an object exposing a
// `_native` Runtime, or None) and bind it into self->runtime_obj.
template <typename T>
int runtime_backed_init(T *self, PyObject *args, PyObject *kwds) {
    static const char *kwlist[] = {"runtime", NULL};
    PyObject *runtime_arg = NULL;
    if (!PyArg_ParseTupleAndKeywords(args, kwds, "|O", (char **)kwlist,
                                     &runtime_arg)) {
        return -1;
    }
    if (runtime_arg && runtime_arg != Py_None) {
        if (PyObject_TypeCheck(runtime_arg, &RuntimeType)) {
            Py_INCREF(runtime_arg);
            self->runtime_obj = runtime_arg;
        } else {
            PyObject *native = PyObject_GetAttrString(runtime_arg, "_native");
            if (native && PyObject_TypeCheck(native, &RuntimeType)) {
                self->runtime_obj = native;
            } else {
                Py_XDECREF(native);
                PyErr_SetString(PyExc_TypeError,
                                "runtime must be a Runtime instance or None");
                return -1;
            }
        }
    }
    return 0;
}

// Run a blocking C++ body with the GIL released, translating any C++ exception
// into a Python RuntimeError. Returns true on success; on failure the Python
// error is set and the caller should return its error sentinel (NULL or -1).
// The body must not touch Python objects (the GIL is not held while it runs).
template <typename F>
bool run_blocking(F &&body) {
    std::string error_msg;
    Py_BEGIN_ALLOW_THREADS try { body(); } catch (const std::exception &e) {
        error_msg = e.what();
    } catch (...) {
        error_msg = "unknown C++ exception";
    }
    Py_END_ALLOW_THREADS if (!error_msg.empty()) {
        PyErr_SetString(PyExc_RuntimeError, error_msg.c_str());
        return false;
    }
    return true;
}

#endif  // DFTRACER_UTILS_PYTHON_PY_RUNTIME_MIXIN_H

1	#ifndef DFTRACER_UTILS_PYTHON_PY_RUNTIME_MIXIN_H
2	#define DFTRACER_UTILS_PYTHON_PY_RUNTIME_MIXIN_H
3
4	#include <Python.h>
5	#include <dftracer/utils/python/runtime.h>
6
7	#include <string>
8
9	// Shared implementation for utility objects whose layout is exactly:
10	// typedef struct { PyObject_HEAD PyObject *runtime_obj; } XObject;
11	// Each binding kept re-rolling an identical runtime-resolution / tp_new /
12	// tp_dealloc / tp_init quartet; these templates single-source it.
13
14	// Resolve the backing Runtime: the explicitly-bound one, else the default.
15	template <typename T>
16	dftracer::utils::Runtime resolve_runtime(T self) {	120✔
17	if (self->runtime_obj)	120!
NEW 18	return ((RuntimeObject *)self->runtime_obj)->runtime.get();	×
19	return get_default_runtime();	120✔
20	}	60✔
21
22	template <typename T>
23	PyObject runtime_backed_new(PyTypeObject type, PyObject , PyObject ) {	120✔
24	T self = (T )type->tp_alloc(type, 0);	120✔
25	if (self) self->runtime_obj = NULL;	120✔
26	return (PyObject *)self;	120✔
27	}
28
29	template <typename T>
30	void runtime_backed_dealloc(T *self) {	120✔
31	Py_XDECREF(self->runtime_obj);	120✔
32	Py_TYPE(self)->tp_free((PyObject *)self);	120✔
33	}	120✔
34
35	// Parse an optional `runtime=` kwarg (a Runtime instance, an object exposing a
36	// `_native` Runtime, or None) and bind it into self->runtime_obj.
37	template <typename T>
38	int runtime_backed_init(T self, PyObject args, PyObject *kwds) {	120✔
39	static const char *kwlist[] = {"runtime", NULL};
40	PyObject *runtime_arg = NULL;	120✔
41	if (!PyArg_ParseTupleAndKeywords(args, kwds, "\|O", (char **)kwlist,	120!
42	&runtime_arg)) {
NEW 43	return -1;	×
44	}
45	if (runtime_arg && runtime_arg != Py_None) {	120!
NEW 46	if (PyObject_TypeCheck(runtime_arg, &RuntimeType)) {	×
NEW 47	Py_INCREF(runtime_arg);	×
NEW 48	self->runtime_obj = runtime_arg;	×
49	} else {
NEW 50	PyObject *native = PyObject_GetAttrString(runtime_arg, "_native");	×
NEW 51	if (native && PyObject_TypeCheck(native, &RuntimeType)) {	×
NEW 52	self->runtime_obj = native;	×
53	} else {
NEW 54	Py_XDECREF(native);	×
NEW 55	PyErr_SetString(PyExc_TypeError,	×
56	"runtime must be a Runtime instance or None");
NEW 57	return -1;	×
58	}
59	}
60	}
61	return 0;	120✔
62	}	60✔
63
64	// Run a blocking C++ body with the GIL released, translating any C++ exception
65	// into a Python RuntimeError. Returns true on success; on failure the Python
66	// error is set and the caller should return its error sentinel (NULL or -1).
67	// The body must not touch Python objects (the GIL is not held while it runs).
68	template <typename F>
69	bool run_blocking(F &&body) {	106✔
70	std::string error_msg;	106✔
71	Py_BEGIN_ALLOW_THREADS try { body(); } catch (const std::exception &e) {	106!
NEW 72	error_msg = e.what();	×
NEW 73	} catch (...) {	×
NEW 74	error_msg = "unknown C++ exception";	×
75	}	×
76	Py_END_ALLOW_THREADS if (!error_msg.empty()) {	106!
NEW 77	PyErr_SetString(PyExc_RuntimeError, error_msg.c_str());	×
NEW 78	return false;	×
79	}
80	return true;	106✔
81	}	106✔
82
83	#endif // DFTRACER_UTILS_PYTHON_PY_RUNTIME_MIXIN_H

llnl / dftracer-utils / 28356348514

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous