28356348514

Committed 29 Jun 2026 07:40AM UTC coverage: 52.174% (-0.1%) from 52.278%

Build # 28356348514

Build Type

Pull #83

github

Committed by

web-flow

Commit Message

Merge 278203630 into 2efed6649

Pull Request Pull Request #83: refactor and improve code QoL

Coverage Stats

37276 of 92891 branches covered (40.13%)

Branch coverage included in aggregate %.

671 of 1173 new or added lines in 58 files covered. (57.2%)

66 existing lines in 30 files now uncovered.

33619 of 42991 relevant lines covered (78.2%)

20387.45 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

82.86

/src/dftracer/utils/core/utils/string.cpp

#include <dftracer/utils/core/utils/string.h>

namespace dftracer::utils {
namespace {
inline bool is_json_ws(char c) {
    return c == ' ' || c == '\t' || c == '\n' || c == '\r';
}

bool json_trim_impl(const char* data, std::size_t length, const char*& start,
                    std::size_t& trimmed_length, bool trim_trailing_comma) {
    start = data;
    const char* end = data + length - 1;

    while (start <= end && is_json_ws(*start)) {
        start++;
    }
    while (end >= start && is_json_ws(*end)) {
        end--;
    }

    // Trailing commas appear in the JSON array format.
    if (trim_trailing_comma && end >= start && *end == ',') {
        end--;
    }

    trimmed_length = (end >= start) ? (end - start + 1) : 0;

    if (trimmed_length == 0 ||
        (trimmed_length == 1 &&
         (*start == '[' || *start == '{' || *start == ']' || *start == '}')) ||
        (trimmed_length == 2 && start[0] == ']' && start[1] == '[')) {
        // Invalid/incomplete JSON or file boundary artifact
        return false;
    }

    return true;
}
}  // namespace

bool json_trim_and_validate(const char* data, std::size_t length,
                            const char*& start, std::size_t& trimmed_length) {
    return json_trim_impl(data, length, start, trimmed_length, false);
}

bool json_trim_and_validate_with_comma(const char* data, std::size_t length,
                                       const char*& start,
                                       std::size_t& trimmed_length) {
    return json_trim_impl(data, length, start, trimmed_length, true);
}
}  // namespace dftracer::utils

1	#include <dftracer/utils/core/utils/string.h>
2
3	namespace dftracer::utils {
4	namespace {
5	inline bool is_json_ws(char c) {	29,438✔
6	return c == ' ' \|\| c == '\t' \|\| c == '\n' \|\| c == '\r';	29,438!
7	}
8
9	bool json_trim_impl(const char* data, std::size_t length, const char*& start,	14,770✔
10	std::size_t& trimmed_length, bool trim_trailing_comma) {
11	start = data;	14,770✔
12	const char* end = data + length - 1;	14,770✔
13
14	while (start <= end && is_json_ws(*start)) {	14,770!
UNCOV 15	start++;	×
16	}
17	while (end >= start && is_json_ws(*end)) {	14,729!
UNCOV 18	end--;	×
19	}
20
21	// Trailing commas appear in the JSON array format.
22	if (trim_trailing_comma && end >= start && *end == ',') {	14,740✔
23	end--;	4,056✔
24	}	2,028✔
25
26	trimmed_length = (end >= start) ? (end - start + 1) : 0;	14,742✔
27
28	if (trimmed_length == 0 \|\|	14,742✔
29	(trimmed_length == 1 &&	14,737✔
30	(start == '[' \|\| start == '{' \|\| start == ']' \|\| start == '}')) \|\|	347!
31	(trimmed_length == 2 && start[0] == ']' && start[1] == '[')) {	14,390!
32	// Invalid/incomplete JSON or file boundary artifact
33	return false;	351✔
34	}
35
36	return true;	14,399✔
37	}	7,402✔
38	} // namespace
39
40	bool json_trim_and_validate(const char* data, std::size_t length,	3,484✔
41	const char*& start, std::size_t& trimmed_length) {
42	return json_trim_impl(data, length, start, trimmed_length, false);	3,484✔
43	}
44
45	bool json_trim_and_validate_with_comma(const char* data, std::size_t length,	11,283✔
46	const char*& start,
47	std::size_t& trimmed_length) {
48	return json_trim_impl(data, length, start, trimmed_length, true);	11,283✔
49	}
50	} // namespace dftracer::utils

llnl / dftracer-utils / 28356348514

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous