wegamekinglc / Derivatives-Algorithms-Lib / 28287373833

Pull #152

github

Dedup math structural: unify AAD iterators, tape block loop, Sobol seek, mesher epilogue

- blocklist.hpp: collapse near-identical Iterator_ and ConstIterator_ into a
  single template IteratorImpl_<bool Const_> with two using aliases; removes
  the const-trampoline asymmetry the original ConstIterator_ lacked.
- tape.cpp (native backend): extract ForEachBlock(tape, fn) that walks the
  four sub-containers (adjointsMulti_ guarded by multi_), and reuse it from
  Clear/Mark/Rewind/RewindToMark so adding/removing a container is one edit.
- sobol.cpp: extract the Gray-code advance loop into Seek(state, iPath,
  directions), shared by SobolSet_::SkipTo and NewSobol.
- meshers: hoist the boundary-null dplus_.back()=dminus_.front()=Null_<double>()
  epilogue onto the base FDM1DMesher_ as protected FinalizeSpacings(); call it
  from Concentrating1dMesher_ and Uniform1DMesher_. Interior spacings stay
  byte-identical (uniform still uses constant dx; concentrating still derives
  from locations_).
- Add trailing newline to concentrating1dmesher.cpp and fdm1dmesher.hpp
  (pre-existing style violation surfaced during review).

Outputs are byte-identical. Verified on two AAD backends (native + XAD): full
dal_cpp_tests 752/752 on each; targeted *AAD*:*Matrix*:*Random*:*Sobol*:*PDE*:
*Mesher* 94/94 on each; no tolerance shifts.

18 of 20 new or added lines in 4 files covered. (90.0%)

6281 of 7802 relevant lines covered (80.5%)

3212945.51 hits per line