28272947092

Committed 26 Jun 2026 08:38PM UTC coverage: 72.893% (+0.2%) from 72.703%

Build # 28272947092

Build Type

push

github

Committed by

poettering

Commit Message

sysupdate: Address review feedback on CheckNew varlink scaffolding

Follow-up to #42422:

 - Rename process_image() to context_process_image(), since it now
   operates on a Context object.
 - Use IN_SET() in image_type_can_sysupdate() instead of a switch.
 - Name the return parameters of context_list_components() ret_xyz, per
   our coding style.
 - Drop a redundant "else" after a return in vl_method_check_new().

Coverage Stats

9 of 11 new or added lines in 1 file covered. (81.82%)

12567 existing lines in 144 files now uncovered.

341026 of 467845 relevant lines covered (72.89%)

1339355.33 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.75

/src/basic/uid-range.c

/* SPDX-License-Identifier: LGPL-2.1-or-later */

#include <sched.h>
#include <string.h>

#include "alloc-util.h"
#include "errno-util.h"
#include "fd-util.h"
#include "format-util.h"
#include "namespace-util.h"
#include "path-util.h"
#include "pidref.h"
#include "process-util.h"
#include "sort-util.h"
#include "stat-util.h"
#include "uid-range.h"
#include "user-util.h"

UIDRange *uid_range_free(UIDRange *range) {
        if (!range)
                return NULL;

        free(range->entries);
        return mfree(range);
}

static bool uid_range_entry_intersect(const UIDRangeEntry *a, const UIDRangeEntry *b) {
        assert(a);
        assert(b);

        return a->start <= b->start + b->nr && a->start + a->nr >= b->start;
}

static int uid_range_entry_compare(const UIDRangeEntry *a, const UIDRangeEntry *b) {
        int r;

        assert(a);
        assert(b);

        r = CMP(a->start, b->start);
        if (r != 0)
                return r;

        return CMP(a->nr, b->nr);
}

static void uid_range_coalesce(UIDRange *range) {
        assert(range);

        if (range->n_entries <= 0)
                return;

        typesafe_qsort(range->entries, range->n_entries, uid_range_entry_compare);

        for (size_t i = 0; i < range->n_entries; i++) {
                UIDRangeEntry *x = range->entries + i;

                for (size_t j = i + 1; j < range->n_entries; j++) {
                        UIDRangeEntry *y = range->entries + j;
                        uid_t begin, end;

                        if (!uid_range_entry_intersect(x, y))
                                break;

                        begin = MIN(x->start, y->start);

                        /* Silence static analyzers, overflow is prevented by uid_range_add_internal() */
                        assert(x->start <= UINT32_MAX - x->nr);
                        assert(y->start <= UINT32_MAX - y->nr);
                        end = MAX(x->start + x->nr, y->start + y->nr);

                        x->start = begin;
                        x->nr = end - begin;

                        if (range->n_entries > j + 1)
                                memmove(y, y + 1, sizeof(UIDRangeEntry) * (range->n_entries - j - 1));

                        /* Silence static analyzers, n_entries > 0 since j < n_entries holds in the loop condition */
                        assert(range->n_entries > 0);
                        range->n_entries--;

                        /* Silence static analyzers, j cannot be 0 here since it starts at i + 1, i.e. >= 1 */
                        assert(j > 0);
                        j--;
                }
        }
}

int uid_range_add_internal(UIDRange **range, uid_t start, uid_t nr, bool coalesce) {
        _cleanup_(uid_range_freep) UIDRange *range_new = NULL;
        UIDRange *p;

        assert(range);

        if (nr <= 0)
                return 0;

        if (start > UINT32_MAX - nr) /* overflow check */
                return -ERANGE;

        if (*range)
                p = *range;
        else {
                range_new = new0(UIDRange, 1);
                if (!range_new)
                        return -ENOMEM;

                p = range_new;
        }

        if (!GREEDY_REALLOC(p->entries, p->n_entries + 1))
                return -ENOMEM;

        p->entries[p->n_entries++] = (UIDRangeEntry) {
                .start = start,
                .nr = nr,
        };

        if (coalesce)
                uid_range_coalesce(p);

        TAKE_PTR(range_new);
        *range = p;

        return 0;
}

int uid_range_add_str_full(UIDRange **range, const char *s, bool coalesce) {
        uid_t start, end;
        int r;

        assert(range);
        assert(s);

        r = parse_uid_range(s, &start, &end);
        if (r < 0)
                return r;

        return uid_range_add_internal(range, start, end - start + 1, coalesce);
}

int uid_range_next_lower(const UIDRange *range, uid_t *uid) {
        uid_t closest = UID_INVALID, candidate;

        assert(range);
        assert(uid);

        if (*uid == 0)
                return -EBUSY;

        candidate = *uid - 1;

        for (size_t i = 0; i < range->n_entries; i++) {
                uid_t begin, end;

                begin = range->entries[i].start;
                end = range->entries[i].start + range->entries[i].nr - 1;

                if (candidate >= begin && candidate <= end) {
                        *uid = candidate;
                        return 1;
                }

                if (end < candidate)
                        closest = end;
        }

        if (closest == UID_INVALID)
                return -EBUSY;

        *uid = closest;
        return 1;
}

bool uid_range_covers(const UIDRange *range, uid_t start, uid_t nr) {
        if (nr == 0) /* empty range? always covered... */
                return true;

        if (start > UINT32_MAX - nr) /* range overflows? definitely not covered... */
                return false;

        if (!range)
                return false;

        FOREACH_ARRAY(i, range->entries, range->n_entries)
                if (start >= i->start &&
                    start + nr <= i->start + i->nr)
                        return true;

        return false;
}

int uid_map_read_one(FILE *f, uid_t *ret_base, uid_t *ret_shift, uid_t *ret_range) {
        uid_t uid_base, uid_shift, uid_range;
        int r;

        assert(f);

        errno = 0;
        r = fscanf(f, UID_FMT " " UID_FMT " " UID_FMT "\n", &uid_base, &uid_shift, &uid_range);
        if (r == EOF)
                return errno_or_else(ENOMSG);
        assert(r >= 0);
        if (r != 3)
                return -EBADMSG;
        if (uid_range <= 0)
                return -EBADMSG;

        if (ret_base)
                *ret_base = uid_base;
        if (ret_shift)
                *ret_shift = uid_shift;
        if (ret_range)
                *ret_range = uid_range;

        return 0;
}

unsigned uid_range_size(const UIDRange *range) {
        if (!range)
                return 0;

        unsigned n = 0;

        FOREACH_ARRAY(e, range->entries, range->n_entries)
                n += e->nr;

        return n;
}

bool uid_range_is_empty(const UIDRange *range) {

        if (!range)
                return true;

        FOREACH_ARRAY(e, range->entries, range->n_entries)
                if (e->nr > 0)
                        return false;

        return true;
}

int uid_range_load_userns_full(const char *path, UIDRangeUsernsMode mode, bool coalesce, UIDRange **ret) {
        _cleanup_(uid_range_freep) UIDRange *range = NULL;
        _cleanup_fclose_ FILE *f = NULL;
        int r;

        /* If 'path' is NULL loads the UID range of the userns namespace we run. Otherwise load the data from
         * the specified file (which can be either uid_map or gid_map, in case caller needs to deal with GID
         * maps).
         *
         * To simplify things this will modify the passed array in case of later failure. */

        assert(mode >= 0);
        assert(mode < _UID_RANGE_USERNS_MODE_MAX);
        assert(ret);

        if (!path)
                path = IN_SET(mode, UID_RANGE_USERNS_INSIDE, UID_RANGE_USERNS_OUTSIDE) ? "/proc/self/uid_map" : "/proc/self/gid_map";

        f = fopen(path, "re");
        if (!f) {
                r = -errno;

                if (r == -ENOENT && path_startswith(path, "/proc/"))
                        return proc_mounted() > 0 ? -EOPNOTSUPP : -ENOSYS;

                return r;
        }

        range = new0(UIDRange, 1);
        if (!range)
                return -ENOMEM;

        for (;;) {
                uid_t uid_base, uid_shift, uid_range;

                r = uid_map_read_one(f, &uid_base, &uid_shift, &uid_range);
                if (r == -ENOMSG)
                        break;
                if (r < 0)
                        return r;

                r = uid_range_add_internal(
                                &range,
                                IN_SET(mode, UID_RANGE_USERNS_INSIDE, GID_RANGE_USERNS_INSIDE) ? uid_base : uid_shift,
                                uid_range,
                                /* coalesce= */ false);
                if (r < 0)
                        return r;
        }

        if (coalesce)
                uid_range_coalesce(range);

        *ret = TAKE_PTR(range);
        return 0;
}

int uid_range_load_userns_by_fd_full(int userns_fd, UIDRangeUsernsMode mode, bool coalesce, UIDRange **ret) {
        _cleanup_(pidref_done_sigkill_wait) PidRef pidref = PIDREF_NULL;
        int r;

        assert(userns_fd >= 0);
        assert(mode >= 0);
        assert(mode < _UID_RANGE_USERNS_MODE_MAX);
        assert(ret);

        r = is_our_namespace(userns_fd, NAMESPACE_USER);
        if (r < 0)
                return r;
        if (r > 0)
                return uid_range_load_userns_full(/* path= */ NULL, mode, coalesce, ret);

        r = userns_enter_and_pin(userns_fd, &pidref);
        if (r < 0)
                return r;

        const char *p = procfs_file_alloca(
                        pidref.pid,
                        IN_SET(mode, UID_RANGE_USERNS_INSIDE, UID_RANGE_USERNS_OUTSIDE) ? "uid_map" : "gid_map");

        return uid_range_load_userns_full(p, mode, coalesce, ret);
}

bool uid_range_overlaps(const UIDRange *range, uid_t start, uid_t nr) {

        if (!range)
                return false;

        /* Avoid overflow */
        if (start > UINT32_MAX - nr)
                nr = UINT32_MAX - start;

        if (nr == 0)
                return false;

        FOREACH_ARRAY(entry, range->entries, range->n_entries)
                if (start < entry->start + entry->nr &&
                    start + nr >= entry->start)
                        return true;

        return false;
}

int uid_range_clip(UIDRange *range, uid_t min, uid_t max) {
        assert(range);

        if (min > max)
                return -EINVAL;

        size_t t = 0;
        FOREACH_ARRAY(e, range->entries, range->n_entries) {
                uid_t entry_end = e->start + e->nr; /* one past the last UID in entry */

                /* Skip entries completely outside [min, max] */
                if (entry_end <= min || e->start > max)
                        continue;

                /* Trim the entry to fit within [min, max] */
                uid_t new_start = MAX(e->start, min);
                /* entry_end is exclusive, avoid overflow when max == UINT32_MAX */
                uid_t new_end = entry_end <= max ? entry_end : max + 1;
                assert(new_end > new_start);

                range->entries[t++] = (UIDRangeEntry) {
                        .start = new_start,
                        .nr = new_end - new_start,
                };
        }

        range->n_entries = t;

        return 0;
}

int uid_range_partition(UIDRange *range, uid_t size) {
        assert(range);
        assert(size > 0);

        /* Partitions the UID range entries into buckets of the given size. Any entry larger than the given
         * size will be partitioned into multiple entries, each of the given size. Any leftover UIDs in the
         * entry are dropped. Any entries smaller than the given size are also dropped. */

        /* Count how many entries we'll need after partitioning */
        size_t n_new_entries = 0;
        FOREACH_ARRAY(e, range->entries, range->n_entries)
                n_new_entries += e->nr / size;

        if (n_new_entries == 0) {
                range->n_entries = 0;
                return 0;
        }

        if (n_new_entries > range->n_entries && !GREEDY_REALLOC(range->entries, n_new_entries))
                return -ENOMEM;

        /* Compact in place: drop entries that contribute zero partitions (nr < size). This forward pass
         * reads each entry once and only writes to lower-or-equal indices, so it cannot alias an unread
         * source entry. */
        size_t n_src = 0;
        for (size_t i = 0; i < range->n_entries; i++)
                if (range->entries[i].nr >= size)
                        range->entries[n_src++] = range->entries[i];

        /* Pre-compaction guarantees every surviving entry contributes at least one partition slot, so the
         * write cursor t stays ahead of the read index. */
        size_t t = n_new_entries;
        for (size_t i = n_src; i > 0; i--) {
                UIDRangeEntry *e = range->entries + i - 1;
                unsigned n_parts = e->nr / size;

                for (unsigned j = n_parts; j > 0; j--)
                        range->entries[--t] = (UIDRangeEntry) {
                                .start = e->start + (j - 1) * size,
                                .nr = size,
                        };
        }

        range->n_entries = n_new_entries;

        return 0;
}

int uid_range_copy(const UIDRange *range, UIDRange **ret) {
        assert(ret);

        if (!range) {
                *ret = NULL;
                return 0;
        }

        _cleanup_(uid_range_freep) UIDRange *copy = new0(UIDRange, 1);
        if (!copy)
                return -ENOMEM;

        if (range->n_entries > 0) {
                copy->entries = newdup(UIDRangeEntry, range->entries, range->n_entries);
                if (!copy->entries)
                        return -ENOMEM;

                copy->n_entries = range->n_entries;
        }

        *ret = TAKE_PTR(copy);
        return 0;
}

int uid_range_remove(UIDRange *range, uid_t start, uid_t size) {
        assert(range);

        if (size == 0)
                return 0;

        uid_t end = start + size; /* one past the last UID to remove */

        for (size_t i = 0; i < range->n_entries; i++) {
                UIDRangeEntry *e = range->entries + i;
                uid_t entry_end = e->start + e->nr;

                /* No overlap */
                if (entry_end <= start || e->start >= end)
                        continue;

                /* Check if this removal splits the entry into two parts */
                if (e->start < start && entry_end > end) {
                        /* Need to split: grow the array first */
                        if (!GREEDY_REALLOC(range->entries, range->n_entries + 1))
                                return -ENOMEM;

                        /* Re-fetch pointer after potential realloc */
                        e = range->entries + i;
                        entry_end = e->start + e->nr;

                        /* Shift everything after this entry to make room */
                        memmove(range->entries + i + 2, range->entries + i + 1,
                                (range->n_entries - i - 1) * sizeof(UIDRangeEntry));
                        range->n_entries++;

                        /* First part: before the removed range */
                        range->entries[i] = (UIDRangeEntry) {
                                .start = e->start,
                                .nr = start - e->start,
                        };

                        /* Second part: after the removed range */
                        range->entries[i + 1] = (UIDRangeEntry) {
                                .start = end,
                                .nr = entry_end - end,
                        };

                        /* Skip the newly inserted entry */
                        i++;
                        continue;
                }

                /* Removal covers the entire entry */
                if (start <= e->start && end >= entry_end) {
                        memmove(e, e + 1, (range->n_entries - i - 1) * sizeof(UIDRangeEntry));
                        range->n_entries--;
                        i--;
                        continue;
                }

                /* Removal trims the start of the entry */
                if (start <= e->start && end > e->start) {
                        e->nr = entry_end - end;
                        e->start = end;
                        continue;
                }

                /* Removal trims the end of the entry */
                if (start < entry_end && end >= entry_end) {
                        e->nr = start - e->start;
                        continue;
                }
        }

        return 0;
}

int uid_range_translate(const UIDRange *outside, const UIDRange *inside, uid_t uid, uid_t *ret) {
        assert(uid_range_entries(outside) == uid_range_entries(inside));
        assert(ret);

        /* Given two UID ranges that represent the outside UID range of a user namespace (the 2nd and 3rd
         * columns in /proc/xxx/uid_map) and the inside UID range of a user namespace (the 1st and 3rd
         * columns in /proc/xxx/uid_map), translates the given UID from the outside range to the inside
         * range. For example, given the following UID range:
         *
         * 0 1000 1
         *
         * calling uid_range_translate(outside, inside, 1000) will return 0 as the output UID. Alternatively,
         * calling uid_range_translate(inside, outside, 0) will return 1000 as the output UID.
         */

        for (size_t i = 0; i < uid_range_entries(outside); i++)
                assert(outside->entries[i].nr == inside->entries[i].nr);

        for (size_t i = 0; i < uid_range_entries(outside); i++) {
                const UIDRangeEntry *e = outside->entries + i;

                if (uid < e->start || uid >= e->start + e->nr)
                        continue;

                *ret = inside->entries[i].start + uid - e->start;
                return 0;
        }

        return -ESRCH;
}

int uid_range_translate_userns_fd(int userns_fd, UIDRangeUsernsMode mode, uid_t uid, uid_t *ret) {
        int r;

        assert(userns_fd >= 0);
        assert(IN_SET(mode, UID_RANGE_USERNS_OUTSIDE, GID_RANGE_USERNS_OUTSIDE));

        _cleanup_(uid_range_freep) UIDRange *outside_range = NULL;
        r = uid_range_load_userns_by_fd_full(userns_fd, mode, /* coalesce= */ false, &outside_range);
        if (r < 0)
                return r;

        mode = mode == UID_RANGE_USERNS_OUTSIDE ? UID_RANGE_USERNS_INSIDE : GID_RANGE_USERNS_INSIDE;

        _cleanup_(uid_range_freep) UIDRange *inside_range = NULL;
        r = uid_range_load_userns_by_fd_full(userns_fd, mode, /* coalesce= */ false, &inside_range);
        if (r < 0)
                return r;

        return uid_range_translate(outside_range, inside_range, uid, ret);
}

bool uid_range_equal(const UIDRange *a, const UIDRange *b) {
        if (a == b)
                return true;

        if (!a || !b)
                return false;

        if (a->n_entries != b->n_entries)
                return false;

        for (size_t i = 0; i < a->n_entries; i++) {
                if (a->entries[i].start != b->entries[i].start)
                        return false;
                if (a->entries[i].nr != b->entries[i].nr)
                        return false;
        }

        return true;
}

int uid_map_search_root(pid_t pid, UIDRangeUsernsMode mode, uid_t *ret) {
        int r;

        assert(pid_is_valid(pid));
        assert(IN_SET(mode, UID_RANGE_USERNS_OUTSIDE, GID_RANGE_USERNS_OUTSIDE));

        const char *p = procfs_file_alloca(pid, mode == UID_RANGE_USERNS_OUTSIDE ? "uid_map" : "gid_map");
        _cleanup_fclose_ FILE *f = fopen(p, "re");
        if (!f) {
                if (errno != ENOENT)
                        return -errno;

                r = proc_mounted();
                if (r < 0)
                        return -ENOENT; /* original error, if we can't determine /proc/ state */

                return r ? -ENOPKG : -ENOSYS;
        }

        for (;;) {
                uid_t uid_base = UID_INVALID, uid_shift = UID_INVALID;

                r = uid_map_read_one(f, &uid_base, &uid_shift, /* ret_range= */ NULL);
                if (r < 0)
                        return r;

                if (uid_base == 0) {
                        if (ret)
                                *ret = uid_shift;
                        return 0;
                }
        }
}

uid_t uid_range_base(const UIDRange *range) {
        /* Returns the lowest UID in the range (notw that elements are sorted, hence we just need to look at
         * the first one that is populated. */

        if (uid_range_is_empty(range))
                return UID_INVALID;

        FOREACH_ARRAY(e, range->entries, range->n_entries)
                if (e->nr > 0)
                        return e->start;

        return UID_INVALID;
}

1	/* SPDX-License-Identifier: LGPL-2.1-or-later */
2
3	#include <sched.h>
4	#include <string.h>
5
6	#include "alloc-util.h"
7	#include "errno-util.h"
8	#include "fd-util.h"
9	#include "format-util.h"
10	#include "namespace-util.h"
11	#include "path-util.h"
12	#include "pidref.h"
13	#include "process-util.h"
14	#include "sort-util.h"
15	#include "stat-util.h"
16	#include "uid-range.h"
17	#include "user-util.h"
18
19	UIDRange uid_range_free(UIDRange range) {	4,067✔
20	if (!range)	4,067✔
21	return NULL;
22
23	free(range->entries);	1,271✔
24	return mfree(range);	1,271✔
25	}
26
27	static bool uid_range_entry_intersect(const UIDRangeEntry a, const UIDRangeEntry b) {	117✔
28	assert(a);	117✔
29	assert(b);	117✔
30
31	return a->start <= b->start + b->nr && a->start + a->nr >= b->start;	117✔
32	}
33
34	static int uid_range_entry_compare(const UIDRangeEntry a, const UIDRangeEntry b) {	308✔
35	int r;	308✔
36
37	assert(a);	308✔
38	assert(b);	308✔
39
40	r = CMP(a->start, b->start);	308✔
41	if (r != 0)	141✔
42	return r;
43
44	return CMP(a->nr, b->nr);	20✔
45	}
46
47	static void uid_range_coalesce(UIDRange *range) {	812✔
48	assert(range);	812✔
49
50	if (range->n_entries <= 0)	812✔
51	return;
52
53	typesafe_qsort(range->entries, range->n_entries, uid_range_entry_compare);	442✔
54
55	for (size_t i = 0; i < range->n_entries; i++) {	1,355✔
56	UIDRangeEntry *x = range->entries + i;	471✔
57
58	for (size_t j = i + 1; j < range->n_entries; j++) {	559✔
59	UIDRangeEntry *y = range->entries + j;	117✔
60	uid_t begin, end;	117✔
61
62	if (!uid_range_entry_intersect(x, y))	117✔
63	break;
64
65	begin = MIN(x->start, y->start);	88✔
66
67	/* Silence static analyzers, overflow is prevented by uid_range_add_internal() */
68	assert(x->start <= UINT32_MAX - x->nr);	88✔
69	assert(y->start <= UINT32_MAX - y->nr);	88✔
70	end = MAX(x->start + x->nr, y->start + y->nr);	88✔
71
72	x->start = begin;	88✔
73	x->nr = end - begin;	88✔
74
75	if (range->n_entries > j + 1)	88✔
76	memmove(y, y + 1, sizeof(UIDRangeEntry) * (range->n_entries - j - 1));	81✔
77
78	/* Silence static analyzers, n_entries > 0 since j < n_entries holds in the loop condition */
79	assert(range->n_entries > 0);	88✔
80	range->n_entries--;	88✔
81
82	/* Silence static analyzers, j cannot be 0 here since it starts at i + 1, i.e. >= 1 */
83	assert(j > 0);	88✔
84	j--;
85	}
86	}
87	}
88
89	int uid_range_add_internal(UIDRange **range, uid_t start, uid_t nr, bool coalesce) {	920✔
90	_cleanup_(uid_range_freep) UIDRange *range_new = NULL;	920✔
91	UIDRange *p;	920✔
92
93	assert(range);	920✔
94
95	if (nr <= 0)	920✔
96	return 0;
97
98	if (start > UINT32_MAX - nr) /* overflow check */	920✔
99	return -ERANGE;
100
101	if (*range)	920✔
102	p = *range;
103	else {
104	range_new = new0(UIDRange, 1);	144✔
105	if (!range_new)	144✔
106	return -ENOMEM;
107
108	p = range_new;
109	}
110
111	if (!GREEDY_REALLOC(p->entries, p->n_entries + 1))	920✔
112	return -ENOMEM;
113
114	p->entries[p->n_entries++] = (UIDRangeEntry) {	920✔
115	.start = start,
116	.nr = nr,
117	};
118
119	if (coalesce)	920✔
120	uid_range_coalesce(p);	162✔
121
122	TAKE_PTR(range_new);	920✔
123	*range = p;	920✔
124
125	return 0;	920✔
126	}
127
128	int uid_range_add_str_full(UIDRange *range, const char s, bool coalesce) {	50✔
129	uid_t start, end;	50✔
130	int r;	50✔
131
132	assert(range);	50✔
133	assert(s);	50✔
134
135	r = parse_uid_range(s, &start, &end);	50✔
136	if (r < 0)	50✔
137	return r;	50✔
138
139	return uid_range_add_internal(range, start, end - start + 1, coalesce);	50✔
140	}
141
142	int uid_range_next_lower(const UIDRange range, uid_t uid) {	272✔
143	uid_t closest = UID_INVALID, candidate;	272✔
144
145	assert(range);	272✔
146	assert(uid);	272✔
147
148	if (*uid == 0)	272✔
149	return -EBUSY;
150
151	candidate = *uid - 1;	272✔
152
153	for (size_t i = 0; i < range->n_entries; i++) {	320✔
154	uid_t begin, end;	272✔
155
156	begin = range->entries[i].start;	272✔
157	end = range->entries[i].start + range->entries[i].nr - 1;	272✔
158
159	if (candidate >= begin && candidate <= end) {	272✔
160	*uid = candidate;	224✔
161	return 1;	224✔
162	}
163
164	if (end < candidate)	48✔
165	closest = end;	47✔
166	}
167
168	if (closest == UID_INVALID)	48✔
169	return -EBUSY;
170
171	*uid = closest;	47✔
172	return 1;	47✔
173	}
174
175	bool uid_range_covers(const UIDRange *range, uid_t start, uid_t nr) {	263✔
176	if (nr == 0) /* empty range? always covered... */	263✔
177	return true;
178
179	if (start > UINT32_MAX - nr) /* range overflows? definitely not covered... */	262✔
180	return false;
181
182	if (!range)	259✔
183	return false;
184
185	FOREACH_ARRAY(i, range->entries, range->n_entries)	275✔
186	if (start >= i->start &&	263✔
187	start + nr <= i->start + i->nr)	257✔
188	return true;
189
190	return false;
191	}
192
193	int uid_map_read_one(FILE f, uid_t ret_base, uid_t ret_shift, uid_t ret_range) {	1,967✔
194	uid_t uid_base, uid_shift, uid_range;	1,967✔
195	int r;	1,967✔
196
197	assert(f);	1,967✔
198
199	errno = 0;	1,967✔
200	r = fscanf(f, UID_FMT " " UID_FMT " " UID_FMT "\n", &uid_base, &uid_shift, &uid_range);	1,967✔
201	if (r == EOF)	1,967✔
202	return errno_or_else(ENOMSG);	1,101✔
203	assert(r >= 0);	866✔
204	if (r != 3)	866✔
205	return -EBADMSG;
206	if (uid_range <= 0)	866✔
207	return -EBADMSG;
208
209	if (ret_base)	866✔
210	*ret_base = uid_base;	866✔
211	if (ret_shift)	866✔
212	*ret_shift = uid_shift;	866✔
213	if (ret_range)	866✔
214	*ret_range = uid_range;	794✔
215
216	return 0;
217	}
218
219	unsigned uid_range_size(const UIDRange *range) {	7✔
220	if (!range)	7✔
221	return 0;
222
223	unsigned n = 0;	6✔
224
225	FOREACH_ARRAY(e, range->entries, range->n_entries)	16✔
226	n += e->nr;	10✔
227
228	return n;
229	}
230
231	bool uid_range_is_empty(const UIDRange *range) {	584✔
232
233	if (!range)	584✔
234	return true;
235
236	FOREACH_ARRAY(e, range->entries, range->n_entries)	582✔
237	if (e->nr > 0)	207✔
238	return false;
239
240	return true;
241	}
242
243	int uid_range_load_userns_full(const char path, UIDRangeUsernsMode mode, bool coalesce, UIDRange *ret) {	1,026✔
244	_cleanup_(uid_range_freep) UIDRange *range = NULL;	×
245	_cleanup_fclose_ FILE *f = NULL;	1,026✔
246	int r;	1,026✔
247
248	/* If 'path' is NULL loads the UID range of the userns namespace we run. Otherwise load the data from
249	* the specified file (which can be either uid_map or gid_map, in case caller needs to deal with GID
250	* maps).
251	*
252	* To simplify things this will modify the passed array in case of later failure. */
253
254	assert(mode >= 0);	1,026✔
255	assert(mode < _UID_RANGE_USERNS_MODE_MAX);	1,026✔
256	assert(ret);	1,026✔
257
258	if (!path)	1,026✔
259	path = IN_SET(mode, UID_RANGE_USERNS_INSIDE, UID_RANGE_USERNS_OUTSIDE) ? "/proc/self/uid_map" : "/proc/self/gid_map";	642✔
260
261	f = fopen(path, "re");	1,026✔
262	if (!f) {	1,026✔
263	r = -errno;	×
264
265	if (r == -ENOENT && path_startswith(path, "/proc/"))	×
266	return proc_mounted() > 0 ? -EOPNOTSUPP : -ENOSYS;	×
267
268	return r;
269	}
270
271	range = new0(UIDRange, 1);	1,026✔
272	if (!range)	1,026✔
273	return -ENOMEM;
274
275	for (;;) {	672✔
276	uid_t uid_base, uid_shift, uid_range;	1,698✔
277
278	r = uid_map_read_one(f, &uid_base, &uid_shift, &uid_range);	1,698✔
279	if (r == -ENOMSG)	1,698✔
280	break;
281	if (r < 0)	672✔
282	return r;	×
283
284	r = uid_range_add_internal(	672✔
285	&range,
286	IN_SET(mode, UID_RANGE_USERNS_INSIDE, GID_RANGE_USERNS_INSIDE) ? uid_base : uid_shift,	672✔
287	uid_range,
288	/* coalesce= */ false);
289	if (r < 0)	672✔
290	return r;
291	}
292
293	if (coalesce)	1,026✔
294	uid_range_coalesce(range);	650✔
295
296	*ret = TAKE_PTR(range);	1,026✔
297	return 0;	1,026✔
298	}
299
300	int uid_range_load_userns_by_fd_full(int userns_fd, UIDRangeUsernsMode mode, bool coalesce, UIDRange **ret) {	847✔
301	_cleanup_(pidref_done_sigkill_wait) PidRef pidref = PIDREF_NULL;	847✔
302	int r;	847✔
303
304	assert(userns_fd >= 0);	847✔
305	assert(mode >= 0);	847✔
306	assert(mode < _UID_RANGE_USERNS_MODE_MAX);	847✔
307	assert(ret);	847✔
308
309	r = is_our_namespace(userns_fd, NAMESPACE_USER);	847✔
310	if (r < 0)	847✔
311	return r;
312	if (r > 0)	847✔
313	return uid_range_load_userns_full(/* path= */ NULL, mode, coalesce, ret);	464✔
314
315	r = userns_enter_and_pin(userns_fd, &pidref);	383✔
316	if (r < 0)	383✔
317	return r;
318
319	const char *p = procfs_file_alloca(	383✔
320	pidref.pid,
321	IN_SET(mode, UID_RANGE_USERNS_INSIDE, UID_RANGE_USERNS_OUTSIDE) ? "uid_map" : "gid_map");
322
323	return uid_range_load_userns_full(p, mode, coalesce, ret);	383✔
324	}
325
326	bool uid_range_overlaps(const UIDRange *range, uid_t start, uid_t nr) {	×
327
328	if (!range)	×
329	return false;
330
331	/* Avoid overflow */
332	if (start > UINT32_MAX - nr)	×
333	nr = UINT32_MAX - start;	×
334
335	if (nr == 0)	×
336	return false;
337
338	FOREACH_ARRAY(entry, range->entries, range->n_entries)	×
339	if (start < entry->start + entry->nr &&	×
340	start + nr >= entry->start)	×
341	return true;
342
343	return false;
344	}
345
346	int uid_range_clip(UIDRange *range, uid_t min, uid_t max) {	105✔
347	assert(range);	105✔
348
349	if (min > max)	105✔
350	return -EINVAL;
351
352	size_t t = 0;	104✔
353	FOREACH_ARRAY(e, range->entries, range->n_entries) {	225✔
354	uid_t entry_end = e->start + e->nr; /* one past the last UID in entry */	121✔
355
356	/* Skip entries completely outside [min, max] */
357	if (entry_end <= min \|\| e->start > max)	121✔
358	continue;	6✔
359
360	/* Trim the entry to fit within [min, max] */
361	uid_t new_start = MAX(e->start, min);	115✔
362	/* entry_end is exclusive, avoid overflow when max == UINT32_MAX */
363	uid_t new_end = entry_end <= max ? entry_end : max + 1;	115✔
364	assert(new_end > new_start);	115✔
365
366	range->entries[t++] = (UIDRangeEntry) {	115✔
367	.start = new_start,
368	.nr = new_end - new_start,	115✔
369	};
370	}
371
372	range->n_entries = t;	104✔
373
374	return 0;	104✔
375	}
376
377	int uid_range_partition(UIDRange *range, uid_t size) {	107✔
378	assert(range);	107✔
379	assert(size > 0);	107✔
380
381	/* Partitions the UID range entries into buckets of the given size. Any entry larger than the given
382	* size will be partitioned into multiple entries, each of the given size. Any leftover UIDs in the
383	* entry are dropped. Any entries smaller than the given size are also dropped. */
384
385	/* Count how many entries we'll need after partitioning */
386	size_t n_new_entries = 0;	107✔
387	FOREACH_ARRAY(e, range->entries, range->n_entries)	230✔
388	n_new_entries += e->nr / size;	123✔
389
390	if (n_new_entries == 0) {	107✔
391	range->n_entries = 0;	1✔
392	return 0;	1✔
393	}
394
395	if (n_new_entries > range->n_entries && !GREEDY_REALLOC(range->entries, n_new_entries))	106✔
396	return -ENOMEM;
397
398	/* Compact in place: drop entries that contribute zero partitions (nr < size). This forward pass
399	* reads each entry once and only writes to lower-or-equal indices, so it cannot alias an unread
400	* source entry. */
401	size_t n_src = 0;	106✔
402	for (size_t i = 0; i < range->n_entries; i++)	228✔
403	if (range->entries[i].nr >= size)	122✔
404	range->entries[n_src++] = range->entries[i];	117✔
405
406	/* Pre-compaction guarantees every surviving entry contributes at least one partition slot, so the
407	* write cursor t stays ahead of the read index. */
408	size_t t = n_new_entries;
409	for (size_t i = n_src; i > 0; i--) {	223✔
410	UIDRangeEntry *e = range->entries + i - 1;	117✔
411	unsigned n_parts = e->nr / size;	117✔
412
413	for (unsigned j = n_parts; j > 0; j--)	2,723,127✔
414	range->entries[--t] = (UIDRangeEntry) {	2,723,010✔
415	.start = e->start + (j - 1) * size,	2,723,010✔
416	.nr = size,
417	};
418	}
419
420	range->n_entries = n_new_entries;	106✔
421
422	return 0;	106✔
423	}
424
425	int uid_range_copy(const UIDRange range, UIDRange *ret) {	101✔
426	assert(ret);	101✔
427
428	if (!range) {	101✔
429	*ret = NULL;	1✔
430	return 0;	101✔
431	}
432
433	_cleanup_(uid_range_freep) UIDRange *copy = new0(UIDRange, 1);	100✔
434	if (!copy)	100✔
435	return -ENOMEM;
436
437	if (range->n_entries > 0) {	100✔
438	copy->entries = newdup(UIDRangeEntry, range->entries, range->n_entries);	99✔
439	if (!copy->entries)	99✔
440	return -ENOMEM;
441
442	copy->n_entries = range->n_entries;	99✔
443	}
444
445	*ret = TAKE_PTR(copy);	100✔
446	return 0;	100✔
447	}
448
449	int uid_range_remove(UIDRange *range, uid_t start, uid_t size) {	107✔
450	assert(range);	107✔
451
452	if (size == 0)	107✔
453	return 0;
454
455	uid_t end = start + size; /* one past the last UID to remove */	106✔
456
457	for (size_t i = 0; i < range->n_entries; i++) {	226✔
458	UIDRangeEntry *e = range->entries + i;	120✔
459	uid_t entry_end = e->start + e->nr;	120✔
460
461	/* No overlap */
462	if (entry_end <= start \|\| e->start >= end)	120✔
463	continue;	14✔
464
465	/* Check if this removal splits the entry into two parts */
466	if (e->start < start && entry_end > end) {	106✔
467	/* Need to split: grow the array first */
468	if (!GREEDY_REALLOC(range->entries, range->n_entries + 1))	96✔
469	return -ENOMEM;
470
471	/* Re-fetch pointer after potential realloc */
472	e = range->entries + i;	96✔
473	entry_end = e->start + e->nr;	96✔
474
475	/* Shift everything after this entry to make room */
476	memmove(range->entries + i + 2, range->entries + i + 1,	96✔
477	(range->n_entries - i - 1) * sizeof(UIDRangeEntry));	96✔
478	range->n_entries++;	96✔
479
480	/* First part: before the removed range */
481	range->entries[i] = (UIDRangeEntry) {	96✔
482	.start = e->start,	96✔
483	.nr = start - e->start,	96✔
484	};
485
486	/* Second part: after the removed range */
487	range->entries[i + 1] = (UIDRangeEntry) {	96✔
488	.start = end,
489	.nr = entry_end - end,	96✔
490	};
491
492	/* Skip the newly inserted entry */
493	i++;	96✔
494	continue;	96✔
495	}
496
497	/* Removal covers the entire entry */
498	if (start <= e->start && end >= entry_end) {	10✔
499	memmove(e, e + 1, (range->n_entries - i - 1) * sizeof(UIDRangeEntry));	6✔
500	range->n_entries--;	6✔
501	i--;	6✔
502	continue;	6✔
503	}
504
505	/* Removal trims the start of the entry */
506	if (start <= e->start && end > e->start) {	4✔
507	e->nr = entry_end - end;	2✔
508	e->start = end;	2✔
509	continue;	2✔
510	}
511
512	/* Removal trims the end of the entry */
513	if (start < entry_end && end >= entry_end) {	2✔
514	e->nr = start - e->start;	2✔
515	continue;	2✔
516	}
517	}
518
519	return 0;
520	}
521
522	int uid_range_translate(const UIDRange outside, const UIDRange inside, uid_t uid, uid_t *ret) {	230✔
523	assert(uid_range_entries(outside) == uid_range_entries(inside));	690✔
524	assert(ret);	230✔
525
526	/* Given two UID ranges that represent the outside UID range of a user namespace (the 2nd and 3rd
527	* columns in /proc/xxx/uid_map) and the inside UID range of a user namespace (the 1st and 3rd
528	* columns in /proc/xxx/uid_map), translates the given UID from the outside range to the inside
529	* range. For example, given the following UID range:
530	*
531	* 0 1000 1
532	*
533	* calling uid_range_translate(outside, inside, 1000) will return 0 as the output UID. Alternatively,
534	* calling uid_range_translate(inside, outside, 0) will return 1000 as the output UID.
535	*/
536
537	for (size_t i = 0; i < uid_range_entries(outside); i++)	496✔
538	assert(outside->entries[i].nr == inside->entries[i].nr);	266✔
539
540	for (size_t i = 0; i < uid_range_entries(outside); i++) {	266✔
541	const UIDRangeEntry *e = outside->entries + i;	256✔
542
543	if (uid < e->start \|\| uid >= e->start + e->nr)	256✔
544	continue;	36✔
545
546	*ret = inside->entries[i].start + uid - e->start;	220✔
547	return 0;	220✔
548	}
549
550	return -ESRCH;
551	}
552
553	int uid_range_translate_userns_fd(int userns_fd, UIDRangeUsernsMode mode, uid_t uid, uid_t *ret) {	2✔
554	int r;	2✔
555
556	assert(userns_fd >= 0);	2✔
557	assert(IN_SET(mode, UID_RANGE_USERNS_OUTSIDE, GID_RANGE_USERNS_OUTSIDE));	2✔
558
559	_cleanup_(uid_range_freep) UIDRange *outside_range = NULL;	2✔
560	r = uid_range_load_userns_by_fd_full(userns_fd, mode, /* coalesce= */ false, &outside_range);	2✔
561	if (r < 0)	2✔
562	return r;
563
564	mode = mode == UID_RANGE_USERNS_OUTSIDE ? UID_RANGE_USERNS_INSIDE : GID_RANGE_USERNS_INSIDE;	2✔
565
566	_cleanup_(uid_range_freep) UIDRange *inside_range = NULL;	2✔
567	r = uid_range_load_userns_by_fd_full(userns_fd, mode, /* coalesce= */ false, &inside_range);	2✔
568	if (r < 0)	2✔
569	return r;
570
571	return uid_range_translate(outside_range, inside_range, uid, ret);	2✔
572	}
573
574	bool uid_range_equal(const UIDRange a, const UIDRange b) {	6✔
575	if (a == b)	6✔
576	return true;
577
578	if (!a \|\| !b)	6✔
579	return false;
580
581	if (a->n_entries != b->n_entries)	5✔
582	return false;
583
584	for (size_t i = 0; i < a->n_entries; i++) {	8✔
585	if (a->entries[i].start != b->entries[i].start)	5✔
586	return false;
587	if (a->entries[i].nr != b->entries[i].nr)	5✔
588	return false;
589	}
590
591	return true;
592	}
593
594	int uid_map_search_root(pid_t pid, UIDRangeUsernsMode mode, uid_t *ret) {	73✔
595	int r;	73✔
596
597	assert(pid_is_valid(pid));	73✔
598	assert(IN_SET(mode, UID_RANGE_USERNS_OUTSIDE, GID_RANGE_USERNS_OUTSIDE));	73✔
599
600	const char *p = procfs_file_alloca(pid, mode == UID_RANGE_USERNS_OUTSIDE ? "uid_map" : "gid_map");	73✔
601	_cleanup_fclose_ FILE *f = fopen(p, "re");	146✔
602	if (!f) {	73✔
UNCOV 603	if (errno != ENOENT)	×
604	return -errno;	×
605
UNCOV 606	r = proc_mounted();	×
UNCOV 607	if (r < 0)	×
608	return -ENOENT; /* original error, if we can't determine /proc/ state */
609
UNCOV 610	return r ? -ENOPKG : -ENOSYS;	×
611	}
612
UNCOV 613	for (;;) {	×
614	uid_t uid_base = UID_INVALID, uid_shift = UID_INVALID;	73✔
615
616	r = uid_map_read_one(f, &uid_base, &uid_shift, /* ret_range= */ NULL);	73✔
617	if (r < 0)	73✔
618	return r;	73✔
619
620	if (uid_base == 0) {	72✔
621	if (ret)	72✔
622	*ret = uid_shift;	72✔
623	return 0;
624	}
625	}
626	}
627
628	uid_t uid_range_base(const UIDRange *range) {	8✔
629	/* Returns the lowest UID in the range (notw that elements are sorted, hence we just need to look at
630	* the first one that is populated. */
631
632	if (uid_range_is_empty(range))	8✔
633	return UID_INVALID;
634
635	FOREACH_ARRAY(e, range->entries, range->n_entries)	8✔
636	if (e->nr > 0)	8✔
637	return e->start;	8✔
638
639	return UID_INVALID;
640	}

systemd / systemd / 28272947092

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous