28202373020

Committed 25 Jun 2026 09:43PM UTC coverage: 47.773% (-31.0%) from 78.818%

Build # 28202373020

Build Type

Pull #1178

github

Committed by

web-flow

Commit Message

Merge 220b559da into 02fe8e7c8

Pull Request Pull Request #1178: fix: cheaper header validator

Coverage Stats

3084 of 6988 branches covered (44.13%)

Branch coverage included in aggregate %.

49 of 50 new or added lines in 4 files covered. (98.0%)

3916 existing lines in 165 files now uncovered.

5999 of 12025 relevant lines covered (49.89%)

62.29 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

78.21

/src/http/plugins/xml.ts

import accepts from '@fastify/accepts'
import { ERRORS } from '@internal/errors'
import { FastifyInstance } from 'fastify'
import fastifyPlugin from 'fastify-plugin'
import xml from 'xml2js'

type XmlParserOptions = { disableContentParser?: boolean; parseAsArray?: string[] }
type RequestError = Error & { statusCode?: number }

function forcePathAsArray(node: unknown, pathSegments: string[]): void {
  if (pathSegments.length === 0 || node === null || node === undefined) {
    return
  }

  if (Array.isArray(node)) {
    node.forEach((item) => forcePathAsArray(item, pathSegments))
    return
  }

  if (typeof node !== 'object') {
    return
  }

  const [current, ...rest] = pathSegments
  const currentRecord = node as Record<string, unknown>

  if (!(current in currentRecord)) {
    return
  }

  if (rest.length === 0) {
    const value = currentRecord[current]
    if (value !== undefined && !Array.isArray(value)) {
      currentRecord[current] = [value]
    }
    return
  }

  forcePathAsArray(currentRecord[current], rest)
}

export const xmlParser = fastifyPlugin(
  async function (fastify: FastifyInstance, opts: XmlParserOptions) {
    fastify.register(accepts)

    if (!opts.disableContentParser) {
      fastify.addContentTypeParser(
        ['text/xml', 'application/xml'],
        { parseAs: 'string' },
        (_request, body, done) => {
          if (!body) {
            done(null, null)
            return
          }

          xml.parseString(
            body,
            {
              explicitArray: false,
              trim: true,
              valueProcessors: [xml.processors.parseNumbers, xml.processors.parseBooleans],
            },
            (err: Error | null, parsed: unknown) => {
              if (err) {
                const parseError: RequestError = ERRORS.InvalidRequest(
                  `Invalid XML payload: ${err.message}`
                )
                parseError.statusCode = 400
                done(parseError)
                return
              }

              if (parsed && opts.parseAsArray?.length) {
                opts.parseAsArray.forEach((path) => {
                  if (!path) {
                    return
                  }
                  forcePathAsArray(parsed, path.split('.'))
                })
              }

              done(null, parsed)
            }
          )
        }
      )
    }

    fastify.addHook('preSerialization', async (req, res, payload) => {
      const accept = req.accepts()

      const acceptedTypes = ['application/xml', 'text/html']

      if (acceptedTypes.some((allowed) => accept.types(acceptedTypes) === allowed)) {
        res.serializer((payload) => payload)

        const xmlBuilder = new xml.Builder({
          renderOpts: {
            pretty: false,
          },
        })
        const xmlPayload = xmlBuilder.buildObject(payload)
        res.type('application/xml')
        res.header('content-type', 'application/xml; charset=utf-8')
        return xmlPayload
      }

      return payload
    })
  },
  { name: 'xml-parser' }
)

1	import accepts from '@fastify/accepts'
2	import { ERRORS } from '@internal/errors'
3	import { FastifyInstance } from 'fastify'
4	import fastifyPlugin from 'fastify-plugin'
5	import xml from 'xml2js'
6
7	type XmlParserOptions = { disableContentParser?: boolean; parseAsArray?: string[] }
8	type RequestError = Error & { statusCode?: number }
9
10	function forcePathAsArray(node: unknown, pathSegments: string[]): void {
11	if (pathSegments.length === 0 \|\| node === null \|\| node === undefined) {	2!
12	return	×
13	}
14
15	if (Array.isArray(node)) {	2!
16	node.forEach((item) => forcePathAsArray(item, pathSegments))	×
17	return	×
18	}
19
20	if (typeof node !== 'object') {	2!
21	return	×
22	}
23
24	const [current, ...rest] = pathSegments	2✔
25	const currentRecord = node as Record<string, unknown>	2✔
26
27	if (!(current in currentRecord)) {	2!
28	return	×
29	}
30
31	if (rest.length === 0) {	2✔
32	const value = currentRecord[current]	1✔
33	if (value !== undefined && !Array.isArray(value)) {	1!
34	currentRecord[current] = [value]	1✔
35	}
36	return	1✔
37	}
38
39	forcePathAsArray(currentRecord[current], rest)	1✔
40	}
41
42	export const xmlParser = fastifyPlugin(	4✔
43	async function (fastify: FastifyInstance, opts: XmlParserOptions) {
44	fastify.register(accepts)	3✔
45
46	if (!opts.disableContentParser) {	3!
47	fastify.addContentTypeParser(	3✔
48	['text/xml', 'application/xml'],
49	{ parseAs: 'string' },
50	(_request, body, done) => {
51	if (!body) {	2!
UNCOV 52	done(null, null)	×
UNCOV 53	return	×
54	}
55
56	xml.parseString(	2✔
57	body,
58	{
59	explicitArray: false,
60	trim: true,
61	valueProcessors: [xml.processors.parseNumbers, xml.processors.parseBooleans],
62	},
63	(err: Error \| null, parsed: unknown) => {
64	if (err) {	2✔
65	const parseError: RequestError = ERRORS.InvalidRequest(	1✔
66	`Invalid XML payload: ${err.message}`
67	)
68	parseError.statusCode = 400	1✔
69	done(parseError)	1✔
70	return	1✔
71	}
72
73	if (parsed && opts.parseAsArray?.length) {	1!
74	opts.parseAsArray.forEach((path) => {	1✔
75	if (!path) {	1!
76	return	×
77	}
78	forcePathAsArray(parsed, path.split('.'))	1✔
79	})
80	}
81
82	done(null, parsed)	1✔
83	}
84	)
85	}
86	)
87	}
88
89	fastify.addHook('preSerialization', async (req, res, payload) => {	3✔
90	const accept = req.accepts()	2✔
91
92	const acceptedTypes = ['application/xml', 'text/html']	2✔
93
94	if (acceptedTypes.some((allowed) => accept.types(acceptedTypes) === allowed)) {	3✔
95	res.serializer((payload) => payload)	1✔
96
97	const xmlBuilder = new xml.Builder({	1✔
98	renderOpts: {
99	pretty: false,
100	},
101	})
102	const xmlPayload = xmlBuilder.buildObject(payload)	1✔
103	res.type('application/xml')	1✔
104	res.header('content-type', 'application/xml; charset=utf-8')	1✔
105	return xmlPayload	1✔
106	}
107
108	return payload	1✔
109	})
110	},
111	{ name: 'xml-parser' }
112	)

supabase / storage / 28202373020

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous