28158800507

Committed 25 Jun 2026 08:57AM UTC coverage: 61.644% (+0.06%) from 61.582%

Build # 28158800507

Build Type

push

github

Committed by

web-flow

Commit Message

MapFusionByDomain (#771)

 + New Map fusion caches data about iteration domain and map candidates
 + only matches up iteration domain exactly, per loop level.
 + Can support fusing non-leaf stacks of loops (stack ends where the shallower stack stops being perfectly nested & parallel)
 + new Element::replace for bulk replacements
 + New PatternMatcher visitor supports descending into replaced or modified nodes to allow for single-pass nested loop fusings
 + LoopAnalysis can now be kept up-to-date with changes done by Map-fusion
 + unit tests for the updating of LoopAnalysis
 * updated LoopAnalysis to be easier to keep up-to-date with changes. LoopTree is no longer ordered, if you want to iterate in pre-order, use the specific method for that
 + convenience StructuredSDFGBuilder.remove_from_parent()
 + RedundantLoadElim pass to skip reading from memory locations that have just been written (same block). Fusing no longer needs to do this
     RedundantLoadElimination does a simple check for other writes to the same structure. Can skip writes if redundant or not modify, if their are writes to different indices
* Updated verifiers to match new fusion
~ moved verifier checks behind correctness checks in npbench harness. Its more critical if we do not even get the expected results
* Added MapFusionByDomain also to loop-norm stage (currently inactive, causes more kernels that currently cannot be safely offloaded to CUDA.
---------

Co-authored-by: Lukas Truemper <lukas.truemper@outlook.de>

Coverage Stats

771 of 1186 new or added lines in 55 files covered. (65.01%)

6 existing lines in 6 files now uncovered.

38302 of 62134 relevant lines covered (61.64%)

987.24 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

28.3

/sdfg/src/data_flow/library_nodes/stdlib/alloca.cpp

#include "sdfg/data_flow/library_nodes/stdlib/alloca.h"

namespace sdfg {
namespace stdlib {

AllocaNode::AllocaNode(
    size_t element_id,
    const DebugInfo& debug_info,
    const graph::Vertex vertex,
    data_flow::DataFlowGraph& parent,
    const symbolic::Expression size
)
    : StdlibNode(
          element_id,
          debug_info,
          vertex,
          parent,
          LibraryNodeType_Alloca,
          {"_ret"},
          {},
          true,
          data_flow::ImplementationType_NONE
      ),
      size_(size) {}

const symbolic::Expression AllocaNode::size() const { return size_; }

void AllocaNode::validate(const Function& function) const { LibraryNode::validate(function); }

symbolic::SymbolSet AllocaNode::symbols() const { return symbolic::atoms(this->size_); }

std::unique_ptr<data_flow::DataFlowNode> AllocaNode::
    clone(size_t element_id, const graph::Vertex vertex, data_flow::DataFlowGraph& parent) const {
    return std::make_unique<AllocaNode>(element_id, debug_info_, vertex, parent, size_);
}

void AllocaNode::replace(const symbolic::Expression old_expression, const symbolic::Expression new_expression) {
    this->size_ = symbolic::subs(this->size_, old_expression, new_expression);
}

void AllocaNode::replace(const symbolic::ExpressionMapping& replacements) {
    this->size_ = symbolic::subs(this->size_, replacements);
}

nlohmann::json AllocaNodeSerializer::serialize(const data_flow::LibraryNode& library_node) {
    const AllocaNode& node = static_cast<const AllocaNode&>(library_node);

    nlohmann::json j;
    j["code"] = node.code().value();

    sdfg::serializer::JSONSerializer serializer;
    j["size"] = serializer.expression(node.size());

    return j;
}

data_flow::LibraryNode& AllocaNodeSerializer::deserialize(
    const nlohmann::json& j, builder::StructuredSDFGBuilder& builder, structured_control_flow::Block& parent
) {
    assert(j.contains("code"));
    assert(j.contains("debug_info"));
    assert(j.contains("size"));

    auto code = j["code"].get<std::string>();
    if (code != LibraryNodeType_Alloca.value()) {
        throw InvalidSDFGException("Invalid library node code");
    }

    sdfg::serializer::JSONSerializer serializer;
    DebugInfo debug_info = serializer.json_to_debug_info(j["debug_info"]);

    auto size = symbolic::parse(j.at("size"));

    return builder.add_library_node<AllocaNode>(parent, debug_info, size);
}

AllocaNodeDispatcher::AllocaNodeDispatcher(
    codegen::LanguageExtension& language_extension,
    const Function& function,
    const data_flow::DataFlowGraph& data_flow_graph,
    const AllocaNode& node
)
    : codegen::LibraryNodeDispatcher(language_extension, function, data_flow_graph, node) {}

void AllocaNodeDispatcher::dispatch_code(
    codegen::PrettyPrinter& stream,
    codegen::PrettyPrinter& globals_stream,
    codegen::CodeSnippetFactory& library_snippet_factory
) {
    auto& node = static_cast<const AllocaNode&>(node_);

    stream << node.outputs().at(0);
    stream << " = ";
    stream << "alloca(" << language_extension_.expression(node.size()) << ")" << ";";
    stream << std::endl;
}

} // namespace stdlib
} // namespace sdfg

1	#include "sdfg/data_flow/library_nodes/stdlib/alloca.h"
2
3	namespace sdfg {
4	namespace stdlib {
5
6	AllocaNode::AllocaNode(
7	size_t element_id,
8	const DebugInfo& debug_info,
9	const graph::Vertex vertex,
10	data_flow::DataFlowGraph& parent,
11	const symbolic::Expression size
12	)
13	: StdlibNode(	5✔
14	element_id,	5✔
15	debug_info,	5✔
16	vertex,	5✔
17	parent,	5✔
18	LibraryNodeType_Alloca,	5✔
19	{"_ret"},	5✔
20	{},	5✔
21	true,	5✔
22	data_flow::ImplementationType_NONE	5✔
23	),	5✔
24	size_(size) {}	5✔
25
26	const symbolic::Expression AllocaNode::size() const { return size_; }	4✔
27
28	void AllocaNode::validate(const Function& function) const { LibraryNode::validate(function); }	3✔
29
30	symbolic::SymbolSet AllocaNode::symbols() const { return symbolic::atoms(this->size_); }	2✔
31
32	std::unique_ptr<data_flow::DataFlowNode> AllocaNode::
33	clone(size_t element_id, const graph::Vertex vertex, data_flow::DataFlowGraph& parent) const {	×
34	return std::make_unique<AllocaNode>(element_id, debug_info_, vertex, parent, size_);	×
35	}	×
36
37	void AllocaNode::replace(const symbolic::Expression old_expression, const symbolic::Expression new_expression) {	×
38	this->size_ = symbolic::subs(this->size_, old_expression, new_expression);	×
39	}	×
40
NEW 41	void AllocaNode::replace(const symbolic::ExpressionMapping& replacements) {	×
NEW 42	this->size_ = symbolic::subs(this->size_, replacements);	×
NEW 43	}	×
44
45	nlohmann::json AllocaNodeSerializer::serialize(const data_flow::LibraryNode& library_node) {	×
46	const AllocaNode& node = static_cast<const AllocaNode&>(library_node);	×
47
48	nlohmann::json j;	×
49	j["code"] = node.code().value();	×
50
51	sdfg::serializer::JSONSerializer serializer;	×
52	j["size"] = serializer.expression(node.size());	×
53
54	return j;	×
55	}	×
56
57	data_flow::LibraryNode& AllocaNodeSerializer::deserialize(
58	const nlohmann::json& j, builder::StructuredSDFGBuilder& builder, structured_control_flow::Block& parent
59	) {	×
60	assert(j.contains("code"));	×
61	assert(j.contains("debug_info"));	×
62	assert(j.contains("size"));	×
63
64	auto code = j["code"].get<std::string>();	×
65	if (code != LibraryNodeType_Alloca.value()) {	×
66	throw InvalidSDFGException("Invalid library node code");	×
67	}	×
68
69	sdfg::serializer::JSONSerializer serializer;	×
70	DebugInfo debug_info = serializer.json_to_debug_info(j["debug_info"]);	×
71
72	auto size = symbolic::parse(j.at("size"));	×
73
74	return builder.add_library_node<AllocaNode>(parent, debug_info, size);	×
75	}	×
76
77	AllocaNodeDispatcher::AllocaNodeDispatcher(
78	codegen::LanguageExtension& language_extension,
79	const Function& function,
80	const data_flow::DataFlowGraph& data_flow_graph,
81	const AllocaNode& node
82	)
83	: codegen::LibraryNodeDispatcher(language_extension, function, data_flow_graph, node) {}	×
84
85	void AllocaNodeDispatcher::dispatch_code(
86	codegen::PrettyPrinter& stream,
87	codegen::PrettyPrinter& globals_stream,
88	codegen::CodeSnippetFactory& library_snippet_factory
89	) {	×
90	auto& node = static_cast<const AllocaNode&>(node_);	×
91
92	stream << node.outputs().at(0);	×
93	stream << " = ";	×
94	stream << "alloca(" << language_extension_.expression(node.size()) << ")" << ";";	×
95	stream << std::endl;	×
96	}	×
97
98	} // namespace stdlib
99	} // namespace sdfg

daisytuner / docc / 28158800507

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous