stacklok / toolhive / 28125934175

push

github

Remove dead vMCP discovery seam and default router (#5627)

The legacy server.New path (s.core == nil) became unreachable once Serve
always builds the core: every server now routes capability aggregation
and call admission through the core. The discovery middleware, its
context seam, the discovery.Manager, and the context-coupled
defaultRouter were only reachable on that dead path.

Delete the pkg/vmcp/discovery package and router.defaultRouter, drop the
discovery.Manager parameter from server.New (7 -> 6 params), and point
the CLI at an empty SessionRouter (core.New needs a non-nil router only
for workflow validation, which does not route). Update the affected
tests and the comments that referenced the removed code.

Part of #5621

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1 of 3 new or added lines in 2 files covered. (33.33%)

69398 of 103342 relevant lines covered (67.15%)

64.84 hits per line