#525521866

Committed 24 Jun 2026 10:33AM UTC coverage: 76.22% (+0.01%) from 76.207%

Build # #525521866

Build Type

push

github

Committed by

hurricup

Commit Message

IDEA-384854 removed leaky class references

There is a platform bug making such classes unreachable

Coverage Stats

14770 of 22542 branches covered (65.52%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

4 existing lines in 3 files now uncovered.

31101 of 37640 relevant lines covered (82.63%)

0.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

54.9

/plugin/backend/src/main/java/com/perl5/lang/perl/idea/actions/PerlMarkSourceRootAction.java

/*
 * Copyright 2015-2026 Alexandr Evstigneev
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package com.perl5.lang.perl.idea.actions;

import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.actionSystem.Presentation;
import com.intellij.openapi.application.ModalityState;
import com.intellij.openapi.application.ReadAction;
import com.intellij.openapi.module.Module;
import com.intellij.openapi.module.ModuleUtilCore;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.project.ProjectBundle;
import com.intellij.openapi.projectRoots.impl.PerlModuleExtension;
import com.intellij.openapi.roots.ui.configuration.ModuleSourceRootEditHandler;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.util.concurrency.AppExecutorUtil;
import com.perl5.lang.perl.idea.modules.PerlSourceRootType;
import com.perl5.lang.perl.idea.project.PerlProjectManager;
import com.perl5.lang.perl.util.PerlPluginUtil;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

import java.util.Arrays;
import java.util.List;
import java.util.Locale;

public abstract class PerlMarkSourceRootAction extends PerlSourceRootAction {
  private final @NotNull PerlSourceRootType myType;

  public PerlMarkSourceRootAction(@NotNull PerlSourceRootType type) {
    myType = type;
    ModuleSourceRootEditHandler<?> editHandler = type.getEditHandler();
    Presentation presentation = getTemplatePresentation();
    presentation.setText(editHandler.getMarkRootButtonText());
    presentation.setDescription(ProjectBundle.message("module.toggle.sources.action.description",
                                                      editHandler.getFullRootTypeName().toLowerCase(Locale.getDefault())));
    presentation.setIcon(editHandler.getRootIcon());
  }


  @Override
  protected boolean isEnabled(@NotNull List<? extends VirtualFile> files, @NotNull Module module) {
    if (files.isEmpty() || !PerlProjectManager.isPerlEnabled(module)) {
      return false;
    }
    return !myType.equals(PerlModuleExtension.getInstance(module).getRootType(files.getFirst()));
  }

  @Override
  protected final void modifyRoots(@NotNull AnActionEvent e, @NotNull Module module, VirtualFile @NotNull [] files) {
    markRoot(module, files);
  }

  public final void markRoot(@NotNull Project project, @Nullable VirtualFile virtualFile) {
    if (virtualFile == null) {
      return;
    }
    ReadAction.nonBlocking(() -> {
        if (!virtualFile.isValid()) {
          return null;
        }
        return ModuleUtilCore.findModuleForFile(virtualFile, project);
      }).finishOnUiThread(ModalityState.current(), (module) -> {
        if (module != null && PerlPluginUtil.isUnloaded(module.getProject())) {
          markRoot(module, virtualFile);
        }
      }).expireWith(PerlPluginUtil.getUnloadAwareDisposable(project))
      .coalesceBy(project, virtualFile)
      .submit(AppExecutorUtil.getAppExecutorService());
  }

  public final void markRoot(@NotNull Module module, @NotNull VirtualFile... files) {
    markRoot(module, Arrays.asList(files));
  }
  public final void markRoot(@NotNull Module module, @NotNull List<? extends VirtualFile> files) {
    PerlModuleExtension.modify(module, it -> {
      for (VirtualFile virtualFile : files) {
        it.setRoot(virtualFile, myType);
      }
    });
  }
}

1	/*
2	* Copyright 2015-2026 Alexandr Evstigneev
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16
17	package com.perl5.lang.perl.idea.actions;
18
19	import com.intellij.openapi.actionSystem.AnActionEvent;
20	import com.intellij.openapi.actionSystem.Presentation;
21	import com.intellij.openapi.application.ModalityState;
22	import com.intellij.openapi.application.ReadAction;
23	import com.intellij.openapi.module.Module;
24	import com.intellij.openapi.module.ModuleUtilCore;
25	import com.intellij.openapi.project.Project;
26	import com.intellij.openapi.project.ProjectBundle;
27	import com.intellij.openapi.projectRoots.impl.PerlModuleExtension;
28	import com.intellij.openapi.roots.ui.configuration.ModuleSourceRootEditHandler;
29	import com.intellij.openapi.vfs.VirtualFile;
30	import com.intellij.util.concurrency.AppExecutorUtil;
31	import com.perl5.lang.perl.idea.modules.PerlSourceRootType;
32	import com.perl5.lang.perl.idea.project.PerlProjectManager;
33	import com.perl5.lang.perl.util.PerlPluginUtil;
34	import org.jetbrains.annotations.NotNull;
35	import org.jetbrains.annotations.Nullable;
36
37	import java.util.Arrays;
38	import java.util.List;
39	import java.util.Locale;
40
41	public abstract class PerlMarkSourceRootAction extends PerlSourceRootAction {
42	private final @NotNull PerlSourceRootType myType;
43
44	public PerlMarkSourceRootAction(@NotNull PerlSourceRootType type) {	1✔
45	myType = type;	1✔
46	ModuleSourceRootEditHandler<?> editHandler = type.getEditHandler();	1✔
47	Presentation presentation = getTemplatePresentation();	1✔
48	presentation.setText(editHandler.getMarkRootButtonText());	1✔
49	presentation.setDescription(ProjectBundle.message("module.toggle.sources.action.description",	1✔
50	editHandler.getFullRootTypeName().toLowerCase(Locale.getDefault())));	1✔
51	presentation.setIcon(editHandler.getRootIcon());	1✔
52	}	1✔
53
54
55	@Override
56	protected boolean isEnabled(@NotNull List<? extends VirtualFile> files, @NotNull Module module) {
57	if (files.isEmpty() \|\| !PerlProjectManager.isPerlEnabled(module)) {	×
58	return false;	×
59	}
60	return !myType.equals(PerlModuleExtension.getInstance(module).getRootType(files.getFirst()));	×
61	}
62
63	@Override
64	protected final void modifyRoots(@NotNull AnActionEvent e, @NotNull Module module, VirtualFile @NotNull [] files) {
65	markRoot(module, files);	×
66	}	×
67
68	public final void markRoot(@NotNull Project project, @Nullable VirtualFile virtualFile) {
69	if (virtualFile == null) {	1!
70	return;	×
71	}
72	ReadAction.nonBlocking(() -> {	1✔
73	if (!virtualFile.isValid()) {	1!
74	return null;	×
75	}
76	return ModuleUtilCore.findModuleForFile(virtualFile, project);	1✔
77	}).finishOnUiThread(ModalityState.current(), (module) -> {	1✔
UNCOV 78	if (module != null && PerlPluginUtil.isUnloaded(module.getProject())) {	×
79	markRoot(module, virtualFile);	×
80	}
81	}).expireWith(PerlPluginUtil.getUnloadAwareDisposable(project))	1✔
82	.coalesceBy(project, virtualFile)	1✔
83	.submit(AppExecutorUtil.getAppExecutorService());	1✔
84	}	1✔
85
86	public final void markRoot(@NotNull Module module, @NotNull VirtualFile... files) {
87	markRoot(module, Arrays.asList(files));	×
88	}	×
89	public final void markRoot(@NotNull Module module, @NotNull List<? extends VirtualFile> files) {
90	PerlModuleExtension.modify(module, it -> {	1✔
91	for (VirtualFile virtualFile : files) {	1✔
92	it.setRoot(virtualFile, myType);	1✔
93	}	1✔
94	});	1✔
95	}	1✔
96	}

Camelcade / Perl5-IDEA / #525521866

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous