• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubeovn / kube-ovn / 27749107657

18 Jun 2026 09:10AM UTC coverage: 21.801% (+0.1%) from 21.689%
27749107657

Pull #6899

github

zhangzujian
fix: reconcile vpc bfd ha chassis on node changes

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Pull Request #6899: fix: reconcile VPC BFD HA chassis on node changes

34 of 62 new or added lines in 2 files covered. (54.84%)

1 existing line in 1 file now uncovered.

10990 of 50411 relevant lines covered (21.8%)

0.25 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.89
/pkg/controller/vpc.go
1
package controller
2

3
import (
4
        "context"
5
        "encoding/json"
6
        "errors"
7
        "fmt"
8
        "maps"
9
        "math"
10
        "net"
11
        "reflect"
12
        "slices"
13
        "sort"
14
        "strings"
15
        "time"
16

17
        v1 "k8s.io/api/core/v1"
18
        k8serrors "k8s.io/apimachinery/pkg/api/errors"
19
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
20
        "k8s.io/apimachinery/pkg/labels"
21
        "k8s.io/apimachinery/pkg/types"
22
        "k8s.io/client-go/tools/cache"
23
        "k8s.io/klog/v2"
24
        "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
25

26
        kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
27
        "github.com/kubeovn/kube-ovn/pkg/ovsdb/ovnnb"
28
        "github.com/kubeovn/kube-ovn/pkg/util"
29
)
30

31
func (c *Controller) enqueueAddVpc(obj any) {
×
32
        vpc := obj.(*kubeovnv1.Vpc)
×
33
        key := cache.MetaObjectToName(vpc).String()
×
34
        if _, ok := vpc.Labels[util.VpcExternalLabel]; !ok {
×
35
                klog.V(3).Infof("enqueue add vpc %s", key)
×
36
                c.addOrUpdateVpcQueue.Add(key)
×
37
        }
×
38
}
39

40
func vpcBFDPortChanged(oldObj, newObj *kubeovnv1.BFDPort) bool {
×
41
        if oldObj == nil && newObj == nil {
×
42
                return false
×
43
        }
×
44
        if oldObj == nil || newObj == nil {
×
45
                return true
×
46
        }
×
47
        return oldObj.Enabled != newObj.Enabled || oldObj.IP != newObj.IP || !reflect.DeepEqual(oldObj.NodeSelector, newObj.NodeSelector)
×
48
}
49

50
func (c *Controller) enqueueUpdateVpc(oldObj, newObj any) {
×
51
        oldVpc := oldObj.(*kubeovnv1.Vpc)
×
52
        newVpc := newObj.(*kubeovnv1.Vpc)
×
53

×
54
        if newVpc.Labels != nil && newVpc.Labels[util.VpcExternalLabel] == "true" {
×
55
                return
×
56
        }
×
57

58
        if !newVpc.DeletionTimestamp.IsZero() ||
×
59
                !slices.Equal(oldVpc.Spec.Namespaces, newVpc.Spec.Namespaces) ||
×
60
                !reflect.DeepEqual(oldVpc.Spec.StaticRoutes, newVpc.Spec.StaticRoutes) ||
×
61
                !reflect.DeepEqual(oldVpc.Spec.PolicyRoutes, newVpc.Spec.PolicyRoutes) ||
×
62
                !reflect.DeepEqual(oldVpc.Spec.VpcPeerings, newVpc.Spec.VpcPeerings) ||
×
63
                !maps.Equal(oldVpc.Annotations, newVpc.Annotations) ||
×
64
                !slices.Equal(oldVpc.Spec.ExtraExternalSubnets, newVpc.Spec.ExtraExternalSubnets) ||
×
65
                oldVpc.Spec.EnableExternal != newVpc.Spec.EnableExternal ||
×
66
                oldVpc.Spec.EnableBfd != newVpc.Spec.EnableBfd ||
×
67
                vpcBFDPortChanged(oldVpc.Spec.BFDPort, newVpc.Spec.BFDPort) ||
×
68
                oldVpc.Labels[util.VpcExternalLabel] != newVpc.Labels[util.VpcExternalLabel] ||
×
69
                !slices.Equal(oldVpc.Status.Subnets, newVpc.Status.Subnets) {
×
70
                // TODO:// label VpcExternalLabel replace with spec enable external
×
71

×
72
                // recode last policies
×
73
                c.vpcLastPoliciesMap.Store(newVpc.Name, convertPolicies(oldVpc.Spec.PolicyRoutes))
×
74

×
75
                key := cache.MetaObjectToName(newVpc).String()
×
76
                klog.Infof("enqueue update vpc %s", key)
×
77
                c.addOrUpdateVpcQueue.Add(key)
×
78
        }
×
79
}
80

81
func (c *Controller) enqueueDelVpc(obj any) {
×
82
        var vpc *kubeovnv1.Vpc
×
83
        switch t := obj.(type) {
×
84
        case *kubeovnv1.Vpc:
×
85
                vpc = t
×
86
        case cache.DeletedFinalStateUnknown:
×
87
                v, ok := t.Obj.(*kubeovnv1.Vpc)
×
88
                if !ok {
×
89
                        klog.Warningf("unexpected object type: %T", t.Obj)
×
90
                        return
×
91
                }
×
92
                vpc = v
×
93
        default:
×
94
                klog.Warningf("unexpected type: %T", obj)
×
95
                return
×
96
        }
97

98
        if _, ok := vpc.Labels[util.VpcExternalLabel]; !vpc.Status.Default || !ok {
×
99
                klog.V(3).Infof("enqueue delete vpc %s", vpc.Name)
×
100
                c.delVpcQueue.Add(vpc)
×
101
        }
×
102
}
103

104
func (c *Controller) handleDelVpc(vpc *kubeovnv1.Vpc) error {
×
105
        c.vpcKeyMutex.LockKey(vpc.Name)
×
106
        defer func() { _ = c.vpcKeyMutex.UnlockKey(vpc.Name) }()
×
107
        klog.Infof("handle delete vpc %s", vpc.Name)
×
108

×
109
        // should delete vpc subnets first
×
110
        var err error
×
111
        for _, subnet := range vpc.Status.Subnets {
×
112
                if _, err = c.subnetsLister.Get(subnet); err != nil {
×
113
                        if k8serrors.IsNotFound(err) {
×
114
                                continue
×
115
                        }
116
                        err = fmt.Errorf("failed to get subnet %s for vpc %s: %w", subnet, vpc.Name, err)
×
117
                } else {
×
118
                        err = fmt.Errorf("failed to delete vpc %s, please delete subnet %s first", vpc.Name, subnet)
×
119
                }
×
120
                klog.Error(err)
×
121
                return err
×
122
        }
123

124
        // clean up vpc last policies cached
125
        c.vpcLastPoliciesMap.Delete(vpc.Name)
×
126

×
127
        if err := c.deleteVpcLb(vpc); err != nil {
×
128
                klog.Error(err)
×
129
                return err
×
130
        }
×
131

132
        if err := c.handleDelVpcExternalSubnet(vpc.Name, c.config.ExternalGatewaySwitch); err != nil {
×
133
                klog.Errorf("failed to delete external connection for vpc %s, error %v", vpc.Name, err)
×
134
                return err
×
135
        }
×
136

137
        for _, subnet := range vpc.Status.ExtraExternalSubnets {
×
138
                klog.Infof("disconnect external network %s to vpc %s", subnet, vpc.Name)
×
139
                if err := c.handleDelVpcExternalSubnet(vpc.Name, subnet); err != nil {
×
140
                        klog.Error(err)
×
141
                        return err
×
142
                }
×
143
        }
144

145
        if err := c.deleteVpcRouter(vpc.Status.Router); err != nil {
×
146
                klog.Error(err)
×
147
                return err
×
148
        }
×
149

150
        return nil
×
151
}
152

153
func (c *Controller) handleUpdateVpcStatus(key string) error {
×
154
        c.vpcKeyMutex.LockKey(key)
×
155
        defer func() { _ = c.vpcKeyMutex.UnlockKey(key) }()
×
156
        klog.Infof("handle status update for vpc %s", key)
×
157

×
158
        cachedVpc, err := c.vpcsLister.Get(key)
×
159
        if err != nil {
×
160
                if k8serrors.IsNotFound(err) {
×
161
                        return nil
×
162
                }
×
163
                klog.Error(err)
×
164
                return err
×
165
        }
166
        vpc := cachedVpc.DeepCopy()
×
167

×
168
        subnets, defaultSubnet, err := c.getVpcSubnets(vpc)
×
169
        if err != nil {
×
170
                klog.Error(err)
×
171
                return err
×
172
        }
×
173

174
        change := vpc.Status.DefaultLogicalSwitch != defaultSubnet
×
175

×
176
        vpc.Status.DefaultLogicalSwitch = defaultSubnet
×
177
        vpc.Status.Subnets = subnets
×
178

×
179
        if !vpc.Spec.BFDPort.IsEnabled() && !vpc.Status.BFDPort.IsEmpty() {
×
180
                vpc.Status.BFDPort.Clear()
×
181
        }
×
182
        bytes, err := vpc.Status.Bytes()
×
183
        if err != nil {
×
184
                klog.Error(err)
×
185
                return err
×
186
        }
×
187

188
        vpc, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(), vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status")
×
189
        if err != nil {
×
190
                klog.Error(err)
×
191
                return err
×
192
        }
×
193

194
        if len(vpc.Status.Subnets) == 0 {
×
195
                klog.Infof("vpc %s has no subnets, add to queue", vpc.Name)
×
196
                c.addOrUpdateVpcQueue.AddAfter(vpc.Name, 5*time.Second)
×
197
        }
×
198

199
        if change {
×
200
                for _, ns := range vpc.Spec.Namespaces {
×
201
                        c.addNamespaceQueue.Add(ns)
×
202
                }
×
203
        }
204

205
        natGws, err := c.vpcNatGatewayLister.List(labels.Everything())
×
206
        if err != nil {
×
207
                klog.Error(err)
×
208
                return err
×
209
        }
×
210
        for _, gw := range natGws {
×
211
                if key == gw.Spec.Vpc {
×
212
                        c.updateVpcSubnetQueue.Add(gw.Name)
×
213
                }
×
214
        }
215
        return nil
×
216
}
217

218
type VpcLoadBalancer struct {
219
        TCPLoadBalancer      string
220
        TCPSessLoadBalancer  string
221
        UDPLoadBalancer      string
222
        UDPSessLoadBalancer  string
223
        SctpLoadBalancer     string
224
        SctpSessLoadBalancer string
225
}
226

227
func (c *Controller) GenVpcLoadBalancer(vpcKey string) *VpcLoadBalancer {
×
228
        if vpcKey == c.config.ClusterRouter || vpcKey == "" {
×
229
                return &VpcLoadBalancer{
×
230
                        TCPLoadBalancer:      c.config.ClusterTCPLoadBalancer,
×
231
                        TCPSessLoadBalancer:  c.config.ClusterTCPSessionLoadBalancer,
×
232
                        UDPLoadBalancer:      c.config.ClusterUDPLoadBalancer,
×
233
                        UDPSessLoadBalancer:  c.config.ClusterUDPSessionLoadBalancer,
×
234
                        SctpLoadBalancer:     c.config.ClusterSctpLoadBalancer,
×
235
                        SctpSessLoadBalancer: c.config.ClusterSctpSessionLoadBalancer,
×
236
                }
×
237
        }
×
238
        return &VpcLoadBalancer{
×
239
                TCPLoadBalancer:      fmt.Sprintf("vpc-%s-tcp-load", vpcKey),
×
240
                TCPSessLoadBalancer:  fmt.Sprintf("vpc-%s-tcp-sess-load", vpcKey),
×
241
                UDPLoadBalancer:      fmt.Sprintf("vpc-%s-udp-load", vpcKey),
×
242
                UDPSessLoadBalancer:  fmt.Sprintf("vpc-%s-udp-sess-load", vpcKey),
×
243
                SctpLoadBalancer:     fmt.Sprintf("vpc-%s-sctp-load", vpcKey),
×
244
                SctpSessLoadBalancer: fmt.Sprintf("vpc-%s-sctp-sess-load", vpcKey),
×
245
        }
×
246
}
247

248
func (c *Controller) addLoadBalancer(vpc string) (*VpcLoadBalancer, error) {
×
249
        vpcLbConfig := c.GenVpcLoadBalancer(vpc)
×
250
        if err := c.initLB(vpcLbConfig.TCPLoadBalancer, string(v1.ProtocolTCP), false); err != nil {
×
251
                return nil, err
×
252
        }
×
253
        if err := c.initLB(vpcLbConfig.TCPSessLoadBalancer, string(v1.ProtocolTCP), true); err != nil {
×
254
                return nil, err
×
255
        }
×
256
        if err := c.initLB(vpcLbConfig.UDPLoadBalancer, string(v1.ProtocolUDP), false); err != nil {
×
257
                return nil, err
×
258
        }
×
259
        if err := c.initLB(vpcLbConfig.UDPSessLoadBalancer, string(v1.ProtocolUDP), true); err != nil {
×
260
                return nil, err
×
261
        }
×
262
        if err := c.initLB(vpcLbConfig.SctpLoadBalancer, string(v1.ProtocolSCTP), false); err != nil {
×
263
                return nil, err
×
264
        }
×
265
        if err := c.initLB(vpcLbConfig.SctpSessLoadBalancer, string(v1.ProtocolSCTP), true); err != nil {
×
266
                return nil, err
×
267
        }
×
268

269
        return vpcLbConfig, nil
×
270
}
271

272
func (c *Controller) handleAddOrUpdateVpc(key string) error {
×
273
        c.vpcKeyMutex.LockKey(key)
×
274
        defer func() { _ = c.vpcKeyMutex.UnlockKey(key) }()
×
275
        klog.Infof("handle add/update vpc %s", key)
×
276

×
277
        cachedVpc, err := c.vpcsLister.Get(key)
×
278
        if err != nil {
×
279
                if k8serrors.IsNotFound(err) {
×
280
                        return nil
×
281
                }
×
282
                klog.Error(err)
×
283
                return err
×
284
        }
285

286
        vpc, err := c.formatVpc(cachedVpc.DeepCopy())
×
287
        if err != nil {
×
288
                klog.Errorf("failed to format vpc %s: %v", key, err)
×
289
                return err
×
290
        }
×
291

292
        learnFromARPRequest := vpc.Spec.EnableExternal
×
293
        if !learnFromARPRequest {
×
294
                for _, subnetName := range vpc.Status.Subnets {
×
295
                        subnet, err := c.subnetsLister.Get(subnetName)
×
296
                        if err != nil {
×
297
                                if k8serrors.IsNotFound(err) {
×
298
                                        continue
×
299
                                }
300
                                klog.Errorf("failed to get subnet %s for vpc %s: %v", subnetName, key, err)
×
301
                                return err
×
302
                        }
303
                        if subnet.Spec.Vlan != "" && subnet.Spec.U2OInterconnection {
×
304
                                learnFromARPRequest = true
×
305
                                break
×
306
                        }
307
                }
308
        }
309

310
        if err = c.createVpcRouter(key, learnFromARPRequest); err != nil {
×
311
                klog.Errorf("failed to create vpc router for vpc %s: %v", key, err)
×
312
                return err
×
313
        }
×
314

315
        var newPeers []string
×
316
        for _, peering := range vpc.Spec.VpcPeerings {
×
317
                if err = util.CheckCidrs(peering.LocalConnectIP); err != nil {
×
318
                        klog.Errorf("invalid cidr %s", peering.LocalConnectIP)
×
319
                        return err
×
320
                }
×
321

322
                newPeers = append(newPeers, peering.RemoteVpc)
×
323
                if err := c.OVNNbClient.CreatePeerRouterPort(vpc.Name, peering.RemoteVpc, peering.LocalConnectIP); err != nil {
×
324
                        klog.Errorf("create peer router port for vpc %s, %v", vpc.Name, err)
×
325
                        return err
×
326
                }
×
327
        }
328
        for _, oldPeer := range vpc.Status.VpcPeerings {
×
329
                if !slices.Contains(newPeers, oldPeer) {
×
330
                        if err = c.OVNNbClient.DeleteLogicalRouterPort(fmt.Sprintf("%s-%s", vpc.Name, oldPeer)); err != nil {
×
331
                                klog.Errorf("delete peer router port for vpc %s, %v", vpc.Name, err)
×
332
                                return err
×
333
                        }
×
334
                }
335
        }
336

337
        // handle static route
338
        var (
×
339
                staticExistedRoutes []*ovnnb.LogicalRouterStaticRoute
×
340
                staticTargetRoutes  []*kubeovnv1.StaticRoute
×
341
                staticRouteMapping  map[string][]*kubeovnv1.StaticRoute
×
342
        )
×
343

×
344
        staticExistedRoutes, err = c.OVNNbClient.ListLogicalRouterStaticRoutes(vpc.Name, nil, nil, "", nil)
×
345
        if err != nil {
×
346
                klog.Errorf("failed to get vpc %s static route list, %v", vpc.Name, err)
×
347
                return err
×
348
        }
×
349

350
        var externalSubnet *kubeovnv1.Subnet
×
351
        externalSubnetExist := false
×
352
        externalSubnetGW := ""
×
353
        if c.config.EnableEipSnat {
×
354
                externalSubnet, err = c.subnetsLister.Get(c.config.ExternalGatewaySwitch)
×
355
                if err != nil {
×
356
                        klog.Warningf("enable-eip-snat need external subnet %s to be exist: %v", c.config.ExternalGatewaySwitch, err)
×
357
                } else {
×
358
                        if !externalSubnet.Spec.LogicalGateway {
×
359
                                // logical gw external subnet can not access external
×
360
                                externalSubnetExist = true
×
361
                                externalSubnetGW = externalSubnet.Spec.Gateway
×
362
                        } else {
×
363
                                klog.Infof("default external subnet %s using logical gw", c.config.ExternalGatewaySwitch)
×
364
                        }
×
365
                }
366
        }
367

368
        staticRouteMapping = c.getRouteTablesByVpc(vpc)
×
369
        staticTargetRoutes = vpc.Spec.StaticRoutes
×
370
        if vpc.Name == c.config.ClusterRouter {
×
371
                if _, ok := staticRouteMapping[util.MainRouteTable]; !ok {
×
372
                        staticRouteMapping[util.MainRouteTable] = nil
×
373
                }
×
374

375
                joinSubnet, err := c.subnetsLister.Get(c.config.NodeSwitch)
×
376
                if err != nil {
×
377
                        if !k8serrors.IsNotFound(err) {
×
378
                                klog.Errorf("failed to get node switch subnet %s: %v", c.config.NodeSwitch, err)
×
379
                                return err
×
380
                        }
×
381
                        c.addOrUpdateVpcQueue.Add(vpc.Name)
×
382
                        return nil
×
383
                }
384
                gatewayV4, gatewayV6 := util.SplitStringIP(joinSubnet.Spec.Gateway)
×
385
                if gatewayV4 != "" {
×
386
                        for table := range staticRouteMapping {
×
387
                                staticTargetRoutes = append(
×
388
                                        staticTargetRoutes,
×
389
                                        &kubeovnv1.StaticRoute{
×
390
                                                Policy:     kubeovnv1.PolicyDst,
×
391
                                                CIDR:       "0.0.0.0/0",
×
392
                                                NextHopIP:  gatewayV4,
×
393
                                                RouteTable: table,
×
394
                                        },
×
395
                                )
×
396
                        }
×
397
                }
398
                if gatewayV6 != "" {
×
399
                        for table := range staticRouteMapping {
×
400
                                staticTargetRoutes = append(
×
401
                                        staticTargetRoutes,
×
402
                                        &kubeovnv1.StaticRoute{
×
403
                                                Policy:     kubeovnv1.PolicyDst,
×
404
                                                CIDR:       "::/0",
×
405
                                                NextHopIP:  gatewayV6,
×
406
                                                RouteTable: table,
×
407
                                        },
×
408
                                )
×
409
                        }
×
410
                }
411
                if c.config.EnableEipSnat {
×
412
                        cm, err := c.configMapsLister.ConfigMaps(c.config.ExternalGatewayConfigNS).Get(util.ExternalGatewayConfig)
×
413
                        if err == nil {
×
414
                                nextHop := cm.Data["external-gw-addr"]
×
415
                                if nextHop == "" {
×
416
                                        if !externalSubnetExist {
×
417
                                                err = fmt.Errorf("failed to get external subnet %s", c.config.ExternalGatewaySwitch)
×
418
                                                klog.Error(err)
×
419
                                                return err
×
420
                                        }
×
421
                                        nextHop = externalSubnet.Spec.Gateway
×
422
                                        if nextHop == "" {
×
423
                                                err := fmt.Errorf("subnet %s has no gateway configuration", externalSubnet.Name)
×
424
                                                klog.Error(err)
×
425
                                                return err
×
426
                                        }
×
427
                                }
428
                                if strings.Contains(nextHop, "/") {
×
429
                                        nextHop = strings.Split(nextHop, "/")[0]
×
430
                                }
×
431

432
                                lr, err := c.OVNNbClient.GetLogicalRouter(vpc.Name, false)
×
433
                                if err != nil {
×
434
                                        klog.Errorf("failed to get logical router %s: %v", vpc.Name, err)
×
435
                                        return err
×
436
                                }
×
437

438
                                for _, nat := range lr.Nat {
×
439
                                        info, err := c.OVNNbClient.GetNATByUUID(nat)
×
440
                                        if err != nil {
×
441
                                                klog.Errorf("failed to get nat ip info for vpc %s, %v", vpc.Name, err)
×
442
                                                return err
×
443
                                        }
×
444
                                        if info.LogicalIP != "" {
×
445
                                                for table := range staticRouteMapping {
×
446
                                                        staticTargetRoutes = append(
×
447
                                                                staticTargetRoutes,
×
448
                                                                &kubeovnv1.StaticRoute{
×
449
                                                                        Policy:     kubeovnv1.PolicySrc,
×
450
                                                                        CIDR:       info.LogicalIP,
×
451
                                                                        NextHopIP:  nextHop,
×
452
                                                                        RouteTable: table,
×
453
                                                                },
×
454
                                                        )
×
455
                                                }
×
456
                                        }
457
                                }
458
                        }
459
                }
460
        }
461

462
        routeNeedDel, routeNeedAdd, err := diffStaticRoute(staticExistedRoutes, staticTargetRoutes)
×
463
        if err != nil {
×
464
                klog.Errorf("failed to diff vpc %s static route, %v", vpc.Name, err)
×
465
                return err
×
466
        }
×
467

468
        for _, item := range routeNeedDel {
×
469
                klog.Infof("vpc %s del static route: %+v", vpc.Name, item)
×
470
                policy := convertPolicy(item.Policy)
×
471
                if err = c.OVNNbClient.DeleteLogicalRouterStaticRoute(vpc.Name, &item.RouteTable, &policy, item.CIDR, item.NextHopIP); err != nil {
×
472
                        klog.Errorf("del vpc %s static route failed, %v", vpc.Name, err)
×
473
                        return err
×
474
                }
×
475
        }
476

477
        for _, item := range routeNeedAdd {
×
478
                if item.BfdID != "" {
×
479
                        klog.Infof("vpc %s add static ecmp route: %+v", vpc.Name, item)
×
480
                        if err = c.OVNNbClient.AddLogicalRouterStaticRoute(
×
481
                                vpc.Name, item.RouteTable, convertPolicy(item.Policy), item.CIDR, &item.BfdID, nil, item.NextHopIP,
×
482
                        ); err != nil {
×
483
                                klog.Errorf("failed to add bfd static route to vpc %s , %v", vpc.Name, err)
×
484
                                return err
×
485
                        }
×
486
                } else {
×
487
                        klog.Infof("vpc %s add static route: %+v", vpc.Name, item)
×
488
                        if err = c.OVNNbClient.AddLogicalRouterStaticRoute(
×
489
                                vpc.Name, item.RouteTable, convertPolicy(item.Policy), item.CIDR, nil, nil, item.NextHopIP,
×
490
                        ); err != nil {
×
491
                                klog.Errorf("failed to add normal static route to vpc %s , %v", vpc.Name, err)
×
492
                                return err
×
493
                        }
×
494
                }
495
        }
496

497
        // handle policy route
498
        var (
×
499
                policyRouteExisted, policyRouteNeedDel, policyRouteNeedAdd []*kubeovnv1.PolicyRoute
×
500
                policyRouteLogical                                         []*ovnnb.LogicalRouterPolicy
×
501
                externalIDs                                                = map[string]string{"vendor": util.CniTypeName}
×
502
        )
×
503

×
504
        if vpc.Name == c.config.ClusterRouter {
×
505
                lastPolicies, _ := c.vpcLastPoliciesMap.Load(vpc.Name)
×
506
                policyRouteExisted = reversePolicies(lastPolicies)
×
507
                // diff list
×
508
                policyRouteNeedDel, policyRouteNeedAdd = diffPolicyRouteWithExisted(policyRouteExisted, vpc.Spec.PolicyRoutes)
×
509
        } else {
×
510
                if vpc.Spec.PolicyRoutes == nil {
×
511
                        // do not clean default vpc policy routes
×
512
                        if err = c.OVNNbClient.ClearLogicalRouterPolicy(vpc.Name); err != nil {
×
513
                                klog.Errorf("clean all vpc %s policy route failed, %v", vpc.Name, err)
×
514
                                return err
×
515
                        }
×
516
                } else {
×
517
                        policyRouteLogical, err = c.OVNNbClient.ListLogicalRouterPolicies(vpc.Name, -1, nil, true)
×
518
                        if err != nil {
×
519
                                klog.Errorf("failed to get vpc %s policy route list, %v", vpc.Name, err)
×
520
                                return err
×
521
                        }
×
522
                        // diff vpc policy route
523
                        policyRouteNeedDel, policyRouteNeedAdd = diffPolicyRouteWithLogical(policyRouteLogical, vpc.Spec.PolicyRoutes)
×
524
                }
525
        }
526
        // delete policies non-exist
527
        for _, item := range policyRouteNeedDel {
×
528
                klog.Infof("delete policy route for router: %s, priority: %d, match %s", vpc.Name, item.Priority, item.Match)
×
529
                if err = c.OVNNbClient.DeleteLogicalRouterPolicy(vpc.Name, item.Priority, item.Match); err != nil {
×
530
                        klog.Errorf("del vpc %s policy route failed, %v", vpc.Name, err)
×
531
                        return err
×
532
                }
×
533
        }
534
        // add new policies
535
        for _, item := range policyRouteNeedAdd {
×
536
                klog.Infof("add policy route for router: %s, match %s, action %s, nexthop %s, externalID %v", c.config.ClusterRouter, item.Match, string(item.Action), item.NextHopIP, externalIDs)
×
537
                if err = c.OVNNbClient.AddLogicalRouterPolicy(vpc.Name, item.Priority, item.Match, string(item.Action), []string{item.NextHopIP}, nil, externalIDs); err != nil {
×
538
                        klog.Errorf("add policy route to vpc %s failed, %v", vpc.Name, err)
×
539
                        return err
×
540
                }
×
541
        }
542

543
        vpcSubnets, defaultSubnet, err := c.getVpcSubnets(vpc)
×
544
        if err != nil {
×
545
                klog.Error(err)
×
546
                return err
×
547
        }
×
548

549
        vpc.Status.Subnets = vpcSubnets
×
550
        vpc.Status.DefaultLogicalSwitch = defaultSubnet
×
551
        vpc.Status.Router = key
×
552
        vpc.Status.Standby = true
×
553
        vpc.Status.VpcPeerings = newPeers
×
554
        if c.config.EnableLb {
×
555
                vpcLb, err := c.addLoadBalancer(key)
×
556
                if err != nil {
×
557
                        klog.Error(err)
×
558
                        return err
×
559
                }
×
560
                vpc.Status.TCPLoadBalancer = vpcLb.TCPLoadBalancer
×
561
                vpc.Status.TCPSessionLoadBalancer = vpcLb.TCPSessLoadBalancer
×
562
                vpc.Status.UDPLoadBalancer = vpcLb.UDPLoadBalancer
×
563
                vpc.Status.UDPSessionLoadBalancer = vpcLb.UDPSessLoadBalancer
×
564
                vpc.Status.SctpLoadBalancer = vpcLb.SctpLoadBalancer
×
565
                vpc.Status.SctpSessionLoadBalancer = vpcLb.SctpSessLoadBalancer
×
566
        }
567
        bytes, err := vpc.Status.Bytes()
×
568
        if err != nil {
×
569
                klog.Error(err)
×
570
                return err
×
571
        }
×
572
        vpc, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(), vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status")
×
573
        if err != nil {
×
574
                klog.Error(err)
×
575
                return err
×
576
        }
×
577

578
        if len(vpc.Annotations) != 0 && strings.ToLower(vpc.Annotations[util.VpcLbAnnotation]) == "on" {
×
579
                if err = c.createVpcLb(vpc); err != nil {
×
580
                        klog.Error(err)
×
581
                        return err
×
582
                }
×
583
        } else if err = c.deleteVpcLb(vpc); err != nil {
×
584
                klog.Error(err)
×
585
                return err
×
586
        }
×
587

588
        subnets, err := c.subnetsLister.List(labels.Everything())
×
589
        if err != nil {
×
590
                klog.Error(err)
×
591
                return err
×
592
        }
×
593
        custVpcEnableExternalEcmp := false
×
594
        for _, subnet := range subnets {
×
595
                if subnet.Spec.Vpc == key {
×
596
                        c.addOrUpdateSubnetQueue.Add(subnet.Name)
×
597
                        if vpc.Name != util.DefaultVpc && vpc.Spec.EnableBfd && subnet.Spec.EnableEcmp {
×
598
                                custVpcEnableExternalEcmp = true
×
599
                        }
×
600
                }
601
        }
602

603
        if vpc.Spec.EnableExternal || vpc.Status.EnableExternal {
×
604
                if err = c.handleUpdateVpcExternal(cachedVpc, custVpcEnableExternalEcmp, externalSubnetExist, externalSubnetGW); err != nil {
×
605
                        klog.Errorf("failed to handle update external subnet for vpc %s, %v", key, err)
×
606
                        return err
×
607
                }
×
608
        }
609

610
        bfdPortName, bfdPortNodes, err := c.reconcileVpcBfdLRP(vpc)
×
611
        if err != nil {
×
612
                klog.Error(err)
×
613
                return err
×
614
        }
×
615
        if vpc.Spec.BFDPort == nil || !vpc.Spec.BFDPort.Enabled {
×
616
                vpc.Status.BFDPort = kubeovnv1.BFDPortStatus{}
×
617
        } else {
×
618
                vpc.Status.BFDPort = kubeovnv1.BFDPortStatus{
×
619
                        Name:  bfdPortName,
×
620
                        IP:    vpc.Spec.BFDPort.IP,
×
621
                        Nodes: bfdPortNodes,
×
622
                }
×
623
        }
×
624
        if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().
×
625
                UpdateStatus(context.Background(), vpc, metav1.UpdateOptions{}); err != nil {
×
626
                klog.Error(err)
×
627
                return err
×
628
        }
×
629

630
        return nil
×
631
}
632

633
func (c *Controller) handleUpdateVpcExternal(vpc *kubeovnv1.Vpc, custVpcEnableExternalEcmp, defaultExternalSubnetExist bool, externalSubnetGW string) error {
×
634
        if c.config.EnableEipSnat && vpc.Name == util.DefaultVpc {
×
635
                klog.Infof("external_gw handle ovn default external gw %s", vpc.Name)
×
636
                return nil
×
637
        }
×
638

639
        if !vpc.Spec.EnableExternal && !vpc.Status.EnableExternal {
×
640
                // no need to handle external connection
×
641
                return nil
×
642
        }
×
643

644
        // handle any vpc external
645
        if vpc.Spec.EnableExternal && !defaultExternalSubnetExist && vpc.Spec.ExtraExternalSubnets == nil {
×
646
                // at least have a external subnet
×
647
                err := fmt.Errorf("failed to get external subnet for enable external vpc %s", vpc.Name)
×
648
                klog.Error(err)
×
649
                return err
×
650
        }
×
651

652
        if !vpc.Spec.EnableExternal && vpc.Status.EnableExternal {
×
653
                // just del all external subnets connection
×
654
                klog.Infof("disconnect default external subnet %s to vpc %s", c.config.ExternalGatewaySwitch, vpc.Name)
×
655
                if err := c.handleDelVpcExternalSubnet(vpc.Name, c.config.ExternalGatewaySwitch); err != nil {
×
656
                        klog.Errorf("failed to delete external subnet %s connection for vpc %s, error %v", c.config.ExternalGatewaySwitch, vpc.Name, err)
×
657
                        return err
×
658
                }
×
659
                for _, subnet := range vpc.Status.ExtraExternalSubnets {
×
660
                        klog.Infof("disconnect external subnet %s to vpc %s", subnet, vpc.Name)
×
661
                        if err := c.handleDelVpcExternalSubnet(vpc.Name, subnet); err != nil {
×
662
                                klog.Errorf("failed to delete external subnet %s connection for vpc %s, error %v", subnet, vpc.Name, err)
×
663
                                return err
×
664
                        }
×
665
                }
666
        }
667

668
        if vpc.Spec.EnableExternal {
×
669
                if !vpc.Status.EnableExternal {
×
670
                        // just add external connection
×
671
                        if vpc.Spec.ExtraExternalSubnets == nil && defaultExternalSubnetExist {
×
672
                                // only connect default external subnet
×
673
                                klog.Infof("connect default external subnet %s with vpc %s", c.config.ExternalGatewaySwitch, vpc.Name)
×
674
                                if err := c.handleAddVpcExternalSubnet(vpc.Name, c.config.ExternalGatewaySwitch); err != nil {
×
675
                                        klog.Errorf("failed to add external subnet %s connection for vpc %s, error %v", c.config.ExternalGatewaySwitch, vpc.Name, err)
×
676
                                        return err
×
677
                                }
×
678
                        }
679

680
                        // only connect provider network vlan external subnet
681
                        for _, subnet := range vpc.Spec.ExtraExternalSubnets {
×
682
                                klog.Infof("connect external subnet %s with vpc %s", subnet, vpc.Name)
×
683
                                if err := c.handleAddVpcExternalSubnet(vpc.Name, subnet); err != nil {
×
684
                                        klog.Errorf("failed to add external subnet %s connection for vpc %s, error %v", subnet, vpc.Name, err)
×
685
                                        return err
×
686
                                }
×
687
                        }
688
                }
689

690
                // diff to add
691
                for _, subnet := range vpc.Spec.ExtraExternalSubnets {
×
692
                        if !slices.Contains(vpc.Status.ExtraExternalSubnets, subnet) {
×
693
                                klog.Infof("connect external subnet %s with vpc %s", subnet, vpc.Name)
×
694
                                if err := c.handleAddVpcExternalSubnet(vpc.Name, subnet); err != nil {
×
695
                                        klog.Errorf("failed to add external subnet %s connection for vpc %s, error %v", subnet, vpc.Name, err)
×
696
                                        return err
×
697
                                }
×
698
                        }
699
                }
700

701
                // diff to del
702
                for _, subnet := range vpc.Status.ExtraExternalSubnets {
×
703
                        if !slices.Contains(vpc.Spec.ExtraExternalSubnets, subnet) {
×
704
                                klog.Infof("disconnect external subnet %s to vpc %s", subnet, vpc.Name)
×
705
                                if err := c.handleDelVpcExternalSubnet(vpc.Name, subnet); err != nil {
×
706
                                        klog.Errorf("failed to delete external subnet %s connection for vpc %s, error %v", subnet, vpc.Name, err)
×
707
                                        return err
×
708
                                }
×
709
                        }
710
                }
711
        }
712

713
        // custom vpc enable bfd
714
        if vpc.Spec.EnableBfd && vpc.Name != util.DefaultVpc && defaultExternalSubnetExist {
×
715
                // create bfd between lrp and physical switch gw
×
716
                // bfd status down means current lrp binding chassis node external nic lost external network connectivity
×
717
                // should switch lrp to another node
×
718
                lrpEipName := fmt.Sprintf("%s-%s", vpc.Name, c.config.ExternalGatewaySwitch)
×
719
                v4ExtGw, _ := util.SplitStringIP(externalSubnetGW)
×
720
                // TODO: dualstack
×
721
                if _, err := c.OVNNbClient.CreateBFD(lrpEipName, v4ExtGw, c.config.BfdMinRx, c.config.BfdMinTx, c.config.BfdDetectMult, nil); err != nil {
×
722
                        klog.Error(err)
×
723
                        return err
×
724
                }
×
725
                // TODO: support multi external nic
726
                if custVpcEnableExternalEcmp {
×
727
                        klog.Infof("remove normal static ecmp route for vpc %s", vpc.Name)
×
728
                        // auto remove normal type static route, if using ecmp based bfd
×
729
                        if err := c.reconcileCustomVpcDelNormalStaticRoute(vpc.Name); err != nil {
×
730
                                klog.Errorf("failed to reconcile del vpc %q normal static route", vpc.Name)
×
731
                                return err
×
732
                        }
×
733
                }
734
        }
735

736
        if !vpc.Spec.EnableBfd && vpc.Status.EnableBfd {
×
737
                lrpEipName := fmt.Sprintf("%s-%s", vpc.Name, c.config.ExternalGatewaySwitch)
×
738
                if err := c.OVNNbClient.DeleteBFDByDstIP(lrpEipName, ""); err != nil {
×
739
                        klog.Error(err)
×
740
                        return err
×
741
                }
×
742
                if err := c.handleDeleteVpcStaticRoute(vpc.Name); err != nil {
×
743
                        klog.Errorf("failed to delete bfd route for vpc %s, error %v", vpc.Name, err)
×
744
                        return err
×
745
                }
×
746
        }
747

748
        if err := c.updateVpcExternalStatus(vpc.Name, vpc.Spec.EnableExternal); err != nil {
×
749
                klog.Errorf("failed to update vpc external subnets status, %v", err)
×
750
                return err
×
751
        }
×
752
        return nil
×
753
}
754

755
func (c *Controller) reconcileVpcBfdLRP(vpc *kubeovnv1.Vpc) (string, []string, error) {
×
756
        portName := "bfd@" + vpc.Name
×
757
        if vpc.Spec.BFDPort == nil || !vpc.Spec.BFDPort.Enabled {
×
758
                if err := c.OVNNbClient.DeleteLogicalRouterPort(portName); err != nil {
×
759
                        err = fmt.Errorf("failed to delete BFD LRP %s: %w", portName, err)
×
760
                        klog.Error(err)
×
761
                        return portName, nil, err
×
762
                }
×
763
                if err := c.OVNNbClient.DeleteHAChassisGroup(portName); err != nil {
×
764
                        err = fmt.Errorf("failed to delete HA chassis group %s: %w", portName, err)
×
765
                        klog.Error(err)
×
766
                        return portName, nil, err
×
767
                }
×
768
                return portName, nil, nil
×
769
        }
770

771
        var err error
×
772
        chassisCount := 3
×
773
        selector := labels.Everything()
×
774
        if vpc.Spec.BFDPort.NodeSelector != nil {
×
775
                chassisCount = math.MaxInt
×
776
                if selector, err = metav1.LabelSelectorAsSelector(vpc.Spec.BFDPort.NodeSelector); err != nil {
×
777
                        err = fmt.Errorf("failed to parse node selector %q: %w", vpc.Spec.BFDPort.NodeSelector.String(), err)
×
778
                        klog.Error(err)
×
779
                        return portName, nil, err
×
780
                }
×
781
        }
782

783
        nodes, err := c.nodesLister.List(selector)
×
784
        if err != nil {
×
785
                err = fmt.Errorf("failed to list nodes with selector %q: %w", vpc.Spec.BFDPort.NodeSelector, err)
×
786
                klog.Error(err)
×
787
                return portName, nil, err
×
788
        }
×
789
        if len(nodes) == 0 {
×
NEW
790
                klog.Warningf("no nodes found by selector %q for BFD LRP %s, clearing HA chassis group", selector.String(), portName)
×
NEW
791
        }
×
NEW
792
        readyNodes := make([]*v1.Node, 0, len(nodes))
×
NEW
793
        for _, node := range nodes {
×
NEW
794
                if nodeReady(node) {
×
NEW
795
                        readyNodes = append(readyNodes, node)
×
NEW
796
                }
×
797
        }
NEW
798
        if len(nodes) != 0 && len(readyNodes) == 0 {
×
NEW
799
                klog.Warningf("no ready nodes found by selector %q for BFD LRP %s, clearing HA chassis group", selector.String(), portName)
×
UNCOV
800
        }
×
NEW
801
        sort.Slice(readyNodes, func(i, j int) bool {
×
NEW
802
                return readyNodes[i].Name < readyNodes[j].Name
×
NEW
803
        })
×
804

NEW
805
        nodeNames := make([]string, 0, len(readyNodes))
×
NEW
806
        chassisCount = min(chassisCount, len(readyNodes))
×
807
        chassisNames := make([]string, 0, chassisCount)
×
NEW
808
        for _, node := range readyNodes[:chassisCount] {
×
NEW
809
                chassis, err := c.OVNSbClient.GetChassisByHost(node.Name)
×
810
                if err != nil {
×
NEW
811
                        err = fmt.Errorf("failed to get chassis of node %s: %w", node.Name, err)
×
812
                        klog.Error(err)
×
813
                        return portName, nil, err
×
814
                }
×
815
                chassisNames = append(chassisNames, chassis.Name)
×
NEW
816
                nodeNames = append(nodeNames, node.Name)
×
817
        }
818

819
        networks := strings.Split(vpc.Spec.BFDPort.IP, ",")
×
820
        if err = c.OVNNbClient.CreateLogicalRouterPort(vpc.Name, portName, "", networks); err != nil {
×
821
                klog.Error(err)
×
822
                return portName, nil, err
×
823
        }
×
824
        if err = c.OVNNbClient.UpdateLogicalRouterPortNetworks(portName, networks); err != nil {
×
825
                klog.Error(err)
×
826
                return portName, nil, err
×
827
        }
×
828
        if err = c.OVNNbClient.UpdateLogicalRouterPortOptions(portName, map[string]string{"bfd-only": "true"}); err != nil {
×
829
                klog.Error(err)
×
830
                return portName, nil, err
×
831
        }
×
832
        if err = c.OVNNbClient.CreateHAChassisGroup(portName, chassisNames, map[string]string{"lrp": portName}); err != nil {
×
833
                klog.Error(err)
×
834
                return portName, nil, err
×
835
        }
×
836
        if err = c.OVNNbClient.SetLogicalRouterPortHAChassisGroup(portName, portName); err != nil {
×
837
                klog.Error(err)
×
838
                return portName, nil, err
×
839
        }
×
840

841
        return portName, nodeNames, nil
×
842
}
843

844
func (c *Controller) addPolicyRouteToVpc(vpcName string, policy *kubeovnv1.PolicyRoute, externalIDs map[string]string) error {
1✔
845
        var (
1✔
846
                nextHops []string
1✔
847
                err      error
1✔
848
        )
1✔
849

1✔
850
        if policy.NextHopIP != "" {
2✔
851
                nextHops = strings.Split(policy.NextHopIP, ",")
1✔
852
        }
1✔
853

854
        if err = c.OVNNbClient.AddLogicalRouterPolicy(vpcName, policy.Priority, policy.Match, string(policy.Action), nextHops, nil, externalIDs); err != nil {
1✔
855
                klog.Errorf("add policy route to vpc %s failed, %v", vpcName, err)
×
856
                return err
×
857
        }
×
858
        return nil
1✔
859
}
860

861
func buildExternalIDsMapKey(match, action string, priority int) string {
×
862
        return fmt.Sprintf("%s-%s-%d", match, action, priority)
×
863
}
×
864

865
func (c *Controller) batchAddPolicyRouteToVpc(name string, policies []*kubeovnv1.PolicyRoute, externalIDs map[string]map[string]string) error {
×
866
        if len(policies) == 0 {
×
867
                return nil
×
868
        }
×
869
        start := time.Now()
×
870
        routerPolicies := make([]*ovnnb.LogicalRouterPolicy, 0, len(policies))
×
871
        for _, policy := range policies {
×
872
                var nextHops []string
×
873
                if policy.NextHopIP != "" {
×
874
                        nextHops = strings.Split(policy.NextHopIP, ",")
×
875
                }
×
876
                routerPolicies = append(routerPolicies, &ovnnb.LogicalRouterPolicy{
×
877
                        Priority:    policy.Priority,
×
878
                        Nexthops:    nextHops,
×
879
                        Action:      string(policy.Action),
×
880
                        Match:       policy.Match,
×
881
                        ExternalIDs: externalIDs[buildExternalIDsMapKey(policy.Match, string(policy.Action), policy.Priority)],
×
882
                })
×
883
        }
884

885
        if err := c.OVNNbClient.BatchAddLogicalRouterPolicy(name, routerPolicies...); err != nil {
×
886
                klog.Errorf("batch add policy route to vpc %s failed, %v", name, err)
×
887
                return err
×
888
        }
×
889
        klog.Infof("take to %v batch add policy route to vpc %s policies %d", time.Since(start), name, len(policies))
×
890
        return nil
×
891
}
892

893
func (c *Controller) deletePolicyRouteFromVpc(vpcName string, priority int, match string) error {
×
894
        var (
×
895
                vpc, cachedVpc *kubeovnv1.Vpc
×
896
                err            error
×
897
        )
×
898

×
899
        if err = c.OVNNbClient.DeleteLogicalRouterPolicy(vpcName, priority, match); err != nil {
×
900
                klog.Error(err)
×
901
                return err
×
902
        }
×
903

904
        cachedVpc, err = c.vpcsLister.Get(vpcName)
×
905
        if err != nil {
×
906
                if k8serrors.IsNotFound(err) {
×
907
                        return nil
×
908
                }
×
909
                klog.Error(err)
×
910
                return err
×
911
        }
912
        vpc = cachedVpc.DeepCopy()
×
913
        // make sure custom policies not be deleted
×
914
        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
915
        if err != nil {
×
916
                klog.Error(err)
×
917
                return err
×
918
        }
×
919
        return nil
×
920
}
921

922
func (c *Controller) batchDeletePolicyRouteFromVpc(name string, policies []*kubeovnv1.PolicyRoute) error {
×
923
        var (
×
924
                vpc, cachedVpc *kubeovnv1.Vpc
×
925
                err            error
×
926
        )
×
927

×
928
        start := time.Now()
×
929
        routerPolicies := make([]*ovnnb.LogicalRouterPolicy, 0, len(policies))
×
930
        for _, policy := range policies {
×
931
                routerPolicies = append(routerPolicies, &ovnnb.LogicalRouterPolicy{
×
932
                        Priority: policy.Priority,
×
933
                        Match:    policy.Match,
×
934
                })
×
935
        }
×
936

937
        if err = c.OVNNbClient.BatchDeleteLogicalRouterPolicy(name, routerPolicies); err != nil {
×
938
                return err
×
939
        }
×
940
        klog.V(3).Infof("take to %v batch delete policy route from vpc %s policies %d", time.Since(start), name, len(policies))
×
941

×
942
        cachedVpc, err = c.vpcsLister.Get(name)
×
943
        if err != nil {
×
944
                if k8serrors.IsNotFound(err) {
×
945
                        return nil
×
946
                }
×
947
                klog.Error(err)
×
948
                return err
×
949
        }
950
        vpc = cachedVpc.DeepCopy()
×
951
        // make sure custom policies not be deleted
×
952
        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
953
        if err != nil {
×
954
                klog.Error(err)
×
955
                return err
×
956
        }
×
957
        return nil
×
958
}
959

960
func (c *Controller) addStaticRouteToVpc(name string, route *kubeovnv1.StaticRoute) error {
×
961
        if route.BfdID != "" {
×
962
                klog.Infof("vpc %s add static ecmp route: %+v", name, route)
×
963
                if err := c.OVNNbClient.AddLogicalRouterStaticRoute(
×
964
                        name, route.RouteTable, convertPolicy(route.Policy), route.CIDR, &route.BfdID, nil, route.NextHopIP,
×
965
                ); err != nil {
×
966
                        klog.Errorf("failed to add bfd static route to vpc %s , %v", name, err)
×
967
                        return err
×
968
                }
×
969
        } else {
×
970
                klog.Infof("vpc %s add static route: %+v", name, route)
×
971
                if err := c.OVNNbClient.AddLogicalRouterStaticRoute(
×
972
                        name, route.RouteTable, convertPolicy(route.Policy), route.CIDR, nil, nil, route.NextHopIP,
×
973
                ); err != nil {
×
974
                        klog.Errorf("failed to add normal static route to vpc %s , %v", name, err)
×
975
                        return err
×
976
                }
×
977
        }
978
        return nil
×
979
}
980

981
func (c *Controller) deleteStaticRouteFromVpc(name, table, cidr, nextHop string, policy kubeovnv1.RoutePolicy) error {
×
982
        var (
×
983
                policyStr string
×
984
                err       error
×
985
        )
×
986

×
987
        policyStr = convertPolicy(policy)
×
988
        if err = c.OVNNbClient.DeleteLogicalRouterStaticRoute(name, &table, &policyStr, cidr, nextHop); err != nil {
×
989
                klog.Errorf("del vpc %s static route failed, %v", name, err)
×
990
                return err
×
991
        }
×
992

993
        return nil
×
994
}
995

996
func (c *Controller) batchDeleteStaticRouteFromVpc(name string, staticRoutes []*kubeovnv1.StaticRoute) error {
×
997
        var (
×
998
                vpc, cachedVpc *kubeovnv1.Vpc
×
999
                err            error
×
1000
        )
×
1001
        start := time.Now()
×
1002
        routeCount := len(staticRoutes)
×
1003
        delRoutes := make([]*ovnnb.LogicalRouterStaticRoute, 0, routeCount)
×
1004
        for _, sr := range staticRoutes {
×
1005
                policyStr := convertPolicy(sr.Policy)
×
1006
                newRoute := &ovnnb.LogicalRouterStaticRoute{
×
1007
                        RouteTable: sr.RouteTable,
×
1008
                        Nexthop:    sr.NextHopIP,
×
1009
                        Policy:     &policyStr,
×
1010
                        IPPrefix:   sr.CIDR,
×
1011
                }
×
1012
                delRoutes = append(delRoutes, newRoute)
×
1013
        }
×
1014
        if err = c.OVNNbClient.BatchDeleteLogicalRouterStaticRoute(name, delRoutes); err != nil {
×
1015
                klog.Errorf("batch del vpc %s static route %d failed, %v", name, routeCount, err)
×
1016
                return err
×
1017
        }
×
1018
        klog.V(3).Infof("take to %v batch delete static route from vpc %s static routes %d", time.Since(start), name, len(delRoutes))
×
1019

×
1020
        cachedVpc, err = c.vpcsLister.Get(name)
×
1021
        if err != nil {
×
1022
                if k8serrors.IsNotFound(err) {
×
1023
                        return nil
×
1024
                }
×
1025
                klog.Error(err)
×
1026
                return err
×
1027
        }
1028
        vpc = cachedVpc.DeepCopy()
×
1029
        // make sure custom policies not be deleted
×
1030
        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
1031
        if err != nil {
×
1032
                klog.Error(err)
×
1033
                return err
×
1034
        }
×
1035
        return nil
×
1036
}
1037

1038
func diffPolicyRouteWithExisted(exists, target []*kubeovnv1.PolicyRoute) ([]*kubeovnv1.PolicyRoute, []*kubeovnv1.PolicyRoute) {
×
1039
        var (
×
1040
                dels, adds []*kubeovnv1.PolicyRoute
×
1041
                existsMap  map[string]*kubeovnv1.PolicyRoute
×
1042
                key        string
×
1043
                ok         bool
×
1044
        )
×
1045

×
1046
        existsMap = make(map[string]*kubeovnv1.PolicyRoute, len(exists))
×
1047
        for _, item := range exists {
×
1048
                existsMap[getPolicyRouteItemKey(item)] = item
×
1049
        }
×
1050
        // load policies to add
1051
        for _, item := range target {
×
1052
                key = getPolicyRouteItemKey(item)
×
1053

×
1054
                if _, ok = existsMap[key]; ok {
×
1055
                        delete(existsMap, key)
×
1056
                } else {
×
1057
                        adds = append(adds, item)
×
1058
                }
×
1059
        }
1060
        // load policies to delete
1061
        for _, item := range existsMap {
×
1062
                dels = append(dels, item)
×
1063
        }
×
1064
        return dels, adds
×
1065
}
1066

1067
func diffPolicyRouteWithLogical(exists []*ovnnb.LogicalRouterPolicy, target []*kubeovnv1.PolicyRoute) ([]*kubeovnv1.PolicyRoute, []*kubeovnv1.PolicyRoute) {
×
1068
        var (
×
1069
                dels, adds []*kubeovnv1.PolicyRoute
×
1070
                existsMap  map[string]*kubeovnv1.PolicyRoute
×
1071
                key        string
×
1072
                ok         bool
×
1073
        )
×
1074
        existsMap = make(map[string]*kubeovnv1.PolicyRoute, len(exists))
×
1075

×
1076
        for _, item := range exists {
×
1077
                policy := &kubeovnv1.PolicyRoute{
×
1078
                        Priority: item.Priority,
×
1079
                        Match:    item.Match,
×
1080
                        Action:   kubeovnv1.PolicyRouteAction(item.Action),
×
1081
                }
×
1082
                existsMap[getPolicyRouteItemKey(policy)] = policy
×
1083
        }
×
1084

1085
        for _, item := range target {
×
1086
                key = getPolicyRouteItemKey(item)
×
1087

×
1088
                if _, ok = existsMap[key]; ok {
×
1089
                        delete(existsMap, key)
×
1090
                } else {
×
1091
                        adds = append(adds, item)
×
1092
                }
×
1093
        }
1094

1095
        for _, item := range existsMap {
×
1096
                dels = append(dels, item)
×
1097
        }
×
1098
        return dels, adds
×
1099
}
1100

1101
func getPolicyRouteItemKey(item *kubeovnv1.PolicyRoute) (key string) {
×
1102
        return fmt.Sprintf("%d:%s:%s:%s", item.Priority, item.Match, item.Action, item.NextHopIP)
×
1103
}
×
1104

1105
func diffStaticRoute(exist []*ovnnb.LogicalRouterStaticRoute, target []*kubeovnv1.StaticRoute) (routeNeedDel, routeNeedAdd []*kubeovnv1.StaticRoute, err error) {
×
1106
        existRouteMap := make(map[string]*kubeovnv1.StaticRoute, len(exist))
×
1107
        for _, item := range exist {
×
1108
                policy := kubeovnv1.PolicyDst
×
1109
                if item.Policy != nil && *item.Policy == ovnnb.LogicalRouterStaticRoutePolicySrcIP {
×
1110
                        policy = kubeovnv1.PolicySrc
×
1111
                }
×
1112
                route := &kubeovnv1.StaticRoute{
×
1113
                        Policy:     policy,
×
1114
                        CIDR:       item.IPPrefix,
×
1115
                        NextHopIP:  item.Nexthop,
×
1116
                        RouteTable: item.RouteTable,
×
1117
                        ECMPMode:   util.StaticRouteBfdEcmp,
×
1118
                }
×
1119
                if item.BFD != nil {
×
1120
                        route.BfdID = *item.BFD
×
1121
                }
×
1122
                existRouteMap[getStaticRouteItemKey(route)] = route
×
1123
        }
1124

1125
        for _, item := range target {
×
1126
                key := getStaticRouteItemKey(item)
×
1127
                if _, ok := existRouteMap[key]; ok {
×
1128
                        delete(existRouteMap, key)
×
1129
                } else {
×
1130
                        routeNeedAdd = append(routeNeedAdd, item)
×
1131
                }
×
1132
        }
1133
        for _, item := range existRouteMap {
×
1134
                routeNeedDel = append(routeNeedDel, item)
×
1135
        }
×
1136
        return routeNeedDel, routeNeedAdd, err
×
1137
}
1138

1139
func getStaticRouteItemKey(item *kubeovnv1.StaticRoute) string {
×
1140
        var key string
×
1141
        if item.Policy == kubeovnv1.PolicyDst {
×
1142
                key = fmt.Sprintf("%s:dst:%s=>%s", item.RouteTable, item.CIDR, item.NextHopIP)
×
1143
        } else {
×
1144
                key = fmt.Sprintf("%s:src:%s=>%s", item.RouteTable, item.CIDR, item.NextHopIP)
×
1145
        }
×
1146
        return key
×
1147
}
1148

1149
func (c *Controller) formatVpc(vpc *kubeovnv1.Vpc) (*kubeovnv1.Vpc, error) {
×
1150
        var changed bool
×
1151
        for _, item := range vpc.Spec.StaticRoutes {
×
1152
                // check policy
×
1153
                if item.Policy == "" {
×
1154
                        item.Policy = kubeovnv1.PolicyDst
×
1155
                        changed = true
×
1156
                }
×
1157
                if item.Policy != kubeovnv1.PolicyDst && item.Policy != kubeovnv1.PolicySrc {
×
1158
                        return nil, fmt.Errorf("unknown policy type: %q", item.Policy)
×
1159
                }
×
1160
                // check cidr
1161
                if strings.Contains(item.CIDR, "/") {
×
1162
                        if _, _, err := net.ParseCIDR(item.CIDR); err != nil {
×
1163
                                return nil, fmt.Errorf("invalid cidr %q: %w", item.CIDR, err)
×
1164
                        }
×
1165
                } else if ip := net.ParseIP(item.CIDR); ip == nil {
×
1166
                        return nil, fmt.Errorf("invalid ip %q", item.CIDR)
×
1167
                }
×
1168
                // check next hop ip
1169
                if ip := net.ParseIP(item.NextHopIP); ip == nil {
×
1170
                        return nil, fmt.Errorf("invalid next hop ip %q", item.NextHopIP)
×
1171
                }
×
1172
        }
1173

1174
        for _, route := range vpc.Spec.PolicyRoutes {
×
1175
                if route.Action != kubeovnv1.PolicyRouteActionReroute {
×
1176
                        if route.NextHopIP != "" {
×
1177
                                route.NextHopIP = ""
×
1178
                                changed = true
×
1179
                        }
×
1180
                } else {
×
1181
                        // ecmp policy route may reroute to multiple next hop ips
×
1182
                        for ipStr := range strings.SplitSeq(route.NextHopIP, ",") {
×
1183
                                if ip := net.ParseIP(ipStr); ip == nil {
×
1184
                                        err := fmt.Errorf("invalid next hop ips: %s", route.NextHopIP)
×
1185
                                        klog.Error(err)
×
1186
                                        return nil, err
×
1187
                                }
×
1188
                        }
1189
                }
1190
        }
1191

1192
        if vpc.DeletionTimestamp.IsZero() && !slices.Contains(vpc.GetFinalizers(), util.KubeOVNControllerFinalizer) {
×
1193
                controllerutil.AddFinalizer(vpc, util.KubeOVNControllerFinalizer)
×
1194
                changed = true
×
1195
        }
×
1196

1197
        if !vpc.DeletionTimestamp.IsZero() && len(vpc.Status.Subnets) == 0 {
×
1198
                controllerutil.RemoveFinalizer(vpc, util.KubeOVNControllerFinalizer)
×
1199
                changed = true
×
1200
        }
×
1201

1202
        if changed {
×
1203
                newVpc, err := c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
1204
                if err != nil {
×
1205
                        klog.Errorf("failed to update vpc %s: %v", vpc.Name, err)
×
1206
                        return nil, err
×
1207
                }
×
1208
                return newVpc, nil
×
1209
        }
1210

1211
        return vpc, nil
×
1212
}
1213

1214
func convertPolicies(list []*kubeovnv1.PolicyRoute) string {
×
1215
        if list == nil {
×
1216
                return ""
×
1217
        }
×
1218

1219
        var (
×
1220
                res []byte
×
1221
                err error
×
1222
        )
×
1223

×
1224
        if res, err = json.Marshal(list); err != nil {
×
1225
                klog.Errorf("failed to serialize policy routes %v , reason : %v", list, err)
×
1226
                return ""
×
1227
        }
×
1228
        return string(res)
×
1229
}
1230

1231
func reversePolicies(origin string) []*kubeovnv1.PolicyRoute {
×
1232
        if origin == "" {
×
1233
                return nil
×
1234
        }
×
1235

1236
        var (
×
1237
                list []*kubeovnv1.PolicyRoute
×
1238
                err  error
×
1239
        )
×
1240

×
1241
        if err = json.Unmarshal([]byte(origin), &list); err != nil {
×
1242
                klog.Errorf("failed to deserialize policy routes %v , reason : %v", list, err)
×
1243
                return nil
×
1244
        }
×
1245
        return list
×
1246
}
1247

1248
func convertPolicy(origin kubeovnv1.RoutePolicy) string {
×
1249
        if origin == kubeovnv1.PolicyDst {
×
1250
                return ovnnb.LogicalRouterStaticRoutePolicyDstIP
×
1251
        }
×
1252
        return ovnnb.LogicalRouterStaticRoutePolicySrcIP
×
1253
}
1254

1255
func reversePolicy(origin ovnnb.LogicalRouterStaticRoutePolicy) kubeovnv1.RoutePolicy {
×
1256
        if origin == ovnnb.LogicalRouterStaticRoutePolicyDstIP {
×
1257
                return kubeovnv1.PolicyDst
×
1258
        }
×
1259
        return kubeovnv1.PolicySrc
×
1260
}
1261

1262
func (c *Controller) getVpcSubnets(vpc *kubeovnv1.Vpc) (subnets []string, defaultSubnet string, err error) {
×
1263
        subnets = []string{}
×
1264
        allSubnets, err := c.subnetsLister.List(labels.Everything())
×
1265
        if err != nil {
×
1266
                klog.Error(err)
×
1267
                return nil, "", err
×
1268
        }
×
1269

1270
        for _, subnet := range allSubnets {
×
1271
                if subnet.Spec.Vpc != vpc.Name || !subnet.DeletionTimestamp.IsZero() || !isOvnSubnet(subnet) {
×
1272
                        continue
×
1273
                }
1274

1275
                subnets = append(subnets, subnet.Name)
×
1276
                if subnet.Spec.Default {
×
1277
                        defaultSubnet = subnet.Name
×
1278
                }
×
1279

1280
                if vpc.Name != util.DefaultVpc && vpc.Spec.DefaultSubnet != "" && vpc.Spec.DefaultSubnet == subnet.Name {
×
1281
                        defaultSubnet = vpc.Spec.DefaultSubnet
×
1282
                }
×
1283
        }
1284
        sort.Strings(subnets)
×
1285
        return subnets, defaultSubnet, err
×
1286
}
1287

1288
// createVpcRouter create router to connect logical switches in vpc
1289
func (c *Controller) createVpcRouter(lr string, learnFromARPRequest bool) error {
×
1290
        if err := c.OVNNbClient.CreateLogicalRouter(lr); err != nil {
×
1291
                klog.Errorf("create logical router %s failed: %v", lr, err)
×
1292
                return err
×
1293
        }
×
1294

1295
        vpcRouter, err := c.OVNNbClient.GetLogicalRouter(lr, false)
×
1296
        if err != nil {
×
1297
                klog.Errorf("get logical router %s failed: %v", lr, err)
×
1298
                return err
×
1299
        }
×
1300

1301
        lrOptions := map[string]string{
×
1302
                "mac_binding_age_threshold": "300",
×
1303
                "dynamic_neigh_routers":     "true",
×
1304
        }
×
1305
        if !learnFromARPRequest {
×
1306
                lrOptions["always_learn_from_arp_request"] = "false"
×
1307
        }
×
1308
        if !maps.Equal(vpcRouter.Options, lrOptions) {
×
1309
                vpcRouter.Options = lrOptions
×
1310
                if err = c.OVNNbClient.UpdateLogicalRouter(vpcRouter, &vpcRouter.Options); err != nil {
×
1311
                        klog.Errorf("failed to update options of logical router %s: %v", lr, err)
×
1312
                        return err
×
1313
                }
×
1314
        }
1315

1316
        return nil
×
1317
}
1318

1319
// deleteVpcRouter delete router to connect logical switches in vpc
1320
func (c *Controller) deleteVpcRouter(lr string) error {
×
1321
        return c.OVNNbClient.DeleteLogicalRouter(lr)
×
1322
}
×
1323

1324
func (c *Controller) handleAddVpcExternalSubnet(key, subnet string) error {
×
1325
        cachedSubnet, err := c.subnetsLister.Get(subnet)
×
1326
        if err != nil {
×
1327
                klog.Error(err)
×
1328
                return err
×
1329
        }
×
1330
        lrpEipName := fmt.Sprintf("%s-%s", key, subnet)
×
1331
        cachedEip, err := c.ovnEipsLister.Get(lrpEipName)
×
1332
        var needCreateEip bool
×
1333
        if err != nil {
×
1334
                if !k8serrors.IsNotFound(err) {
×
1335
                        klog.Error(err)
×
1336
                        return err
×
1337
                }
×
1338
                needCreateEip = true
×
1339
        }
1340
        var v4ip, v6ip, mac string
×
1341
        klog.V(3).Infof("create vpc lrp eip %s", lrpEipName)
×
1342
        if needCreateEip {
×
1343
                if v4ip, v6ip, mac, err = c.acquireIPAddress(subnet, lrpEipName, lrpEipName); err != nil {
×
1344
                        klog.Errorf("failed to acquire ip address for lrp eip %s, %v", lrpEipName, err)
×
1345
                        return err
×
1346
                }
×
1347
                if err := c.createOrUpdateOvnEipCR(lrpEipName, subnet, v4ip, v6ip, mac, util.OvnEipTypeLRP); err != nil {
×
1348
                        klog.Errorf("failed to create ovn eip for lrp %s: %v", lrpEipName, err)
×
1349
                        return err
×
1350
                }
×
1351
        } else {
×
1352
                v4ip = cachedEip.Spec.V4Ip
×
1353
                mac = cachedEip.Spec.MacAddress
×
1354
        }
×
1355
        if v4ip == "" || mac == "" {
×
1356
                err := fmt.Errorf("lrp '%s' ip or mac should not be empty", lrpEipName)
×
1357
                klog.Error(err)
×
1358
                return err
×
1359
        }
×
1360
        // init lrp gw chassis group
1361
        chassises := []string{}
×
1362
        sel, _ := metav1.LabelSelectorAsSelector(&metav1.LabelSelector{MatchLabels: map[string]string{util.ExGatewayLabel: "true"}})
×
1363
        gwNodes, err := c.nodesLister.List(sel)
×
1364
        if err != nil {
×
1365
                klog.Errorf("failed to list external gw nodes, %v", err)
×
1366
                return err
×
1367
        }
×
1368
        for _, gwNode := range gwNodes {
×
1369
                annoChassisName := gwNode.Annotations[util.ChassisAnnotation]
×
1370
                if annoChassisName == "" {
×
1371
                        err := fmt.Errorf("node %s has no chassis annotation, kube-ovn-cni not ready", gwNode.Name)
×
1372
                        klog.Error(err)
×
1373
                        return err
×
1374
                }
×
1375
                klog.Infof("get node %s chassis: %s", gwNode.Name, annoChassisName)
×
1376
                chassis, err := c.OVNSbClient.GetChassis(annoChassisName, false)
×
1377
                if err != nil {
×
1378
                        klog.Errorf("failed to get node %s chassis: %s, %v", gwNode.Name, annoChassisName, err)
×
1379
                        return err
×
1380
                }
×
1381
                chassises = append(chassises, chassis.Name)
×
1382
        }
1383

1384
        if len(chassises) == 0 {
×
1385
                err := errors.New("no external gw nodes")
×
1386
                klog.Error(err)
×
1387
                return err
×
1388
        }
×
1389

1390
        v4ipCidr, err := util.GetIPAddrWithMask(v4ip, cachedSubnet.Spec.CIDRBlock)
×
1391
        if err != nil {
×
1392
                klog.Error(err)
×
1393
                return err
×
1394
        }
×
1395
        lspName := fmt.Sprintf("%s-%s", subnet, key)
×
1396
        lrpName := fmt.Sprintf("%s-%s", key, subnet)
×
1397

×
1398
        if err := c.OVNNbClient.CreateLogicalPatchPort(subnet, key, lspName, lrpName, v4ipCidr, mac, chassises...); err != nil {
×
1399
                klog.Errorf("failed to connect router '%s' to external: %v", key, err)
×
1400
                return err
×
1401
        }
×
1402
        return nil
×
1403
}
1404

1405
func (c *Controller) handleDeleteVpcStaticRoute(key string) error {
×
1406
        vpc, err := c.vpcsLister.Get(key)
×
1407
        if err != nil {
×
1408
                if k8serrors.IsNotFound(err) {
×
1409
                        return nil
×
1410
                }
×
1411
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1412
                return err
×
1413
        }
1414
        needUpdate := false
×
1415
        newStaticRoutes := make([]*kubeovnv1.StaticRoute, 0, len(vpc.Spec.StaticRoutes))
×
1416
        for _, route := range vpc.Spec.StaticRoutes {
×
1417
                if route.ECMPMode != util.StaticRouteBfdEcmp {
×
1418
                        newStaticRoutes = append(newStaticRoutes, route)
×
1419
                        needUpdate = true
×
1420
                }
×
1421
        }
1422
        // keep non ecmp bfd routes
1423
        vpc.Spec.StaticRoutes = newStaticRoutes
×
1424
        if needUpdate {
×
1425
                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{}); err != nil {
×
1426
                        klog.Errorf("failed to update vpc spec static route %s, %v", vpc.Name, err)
×
1427
                        return err
×
1428
                }
×
1429
        }
1430
        if err = c.patchVpcBfdStatus(vpc.Name); err != nil {
×
1431
                klog.Errorf("failed to patch vpc %s, %v", vpc.Name, err)
×
1432
                return err
×
1433
        }
×
1434
        return nil
×
1435
}
1436

1437
func (c *Controller) handleDelVpcExternalSubnet(key, subnet string) error {
×
1438
        lspName := fmt.Sprintf("%s-%s", subnet, key)
×
1439
        lrpName := fmt.Sprintf("%s-%s", key, subnet)
×
1440
        klog.Infof("delete vpc lrp %s", lrpName)
×
1441
        if err := c.OVNNbClient.RemoveLogicalPatchPort(lspName, lrpName); err != nil {
×
1442
                klog.Errorf("failed to disconnect router '%s' to external, %v", key, err)
×
1443
                return err
×
1444
        }
×
1445
        if err := c.config.KubeOvnClient.KubeovnV1().OvnEips().Delete(context.Background(), lrpName, metav1.DeleteOptions{}); err != nil {
×
1446
                if !k8serrors.IsNotFound(err) {
×
1447
                        klog.Errorf("failed to delete ovn eip %s, %v", lrpName, err)
×
1448
                        return err
×
1449
                }
×
1450
        }
1451
        if err := c.OVNNbClient.DeleteBFDByDstIP(lrpName, ""); err != nil {
×
1452
                klog.Error(err)
×
1453
                return err
×
1454
        }
×
1455
        return nil
×
1456
}
1457

1458
func (c *Controller) patchVpcBfdStatus(key string) error {
×
1459
        cachedVpc, err := c.vpcsLister.Get(key)
×
1460
        if err != nil {
×
1461
                if k8serrors.IsNotFound(err) {
×
1462
                        return nil
×
1463
                }
×
1464
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1465
                return err
×
1466
        }
1467

1468
        if cachedVpc.Status.EnableBfd != cachedVpc.Spec.EnableBfd {
×
1469
                status := cachedVpc.Status.DeepCopy()
×
1470
                status.EnableExternal = cachedVpc.Spec.EnableExternal
×
1471
                status.EnableBfd = cachedVpc.Spec.EnableBfd
×
1472
                bytes, err := status.Bytes()
×
1473
                if err != nil {
×
1474
                        klog.Errorf("failed to marshal vpc status: %v", err)
×
1475
                        return err
×
1476
                }
×
1477
                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),
×
1478
                        cachedVpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {
×
1479
                        klog.Error(err)
×
1480
                        return err
×
1481
                }
×
1482
        }
1483
        return nil
×
1484
}
1485

1486
func (c *Controller) getRouteTablesByVpc(vpc *kubeovnv1.Vpc) map[string][]*kubeovnv1.StaticRoute {
×
1487
        rtbs := make(map[string][]*kubeovnv1.StaticRoute)
×
1488
        for _, route := range vpc.Spec.StaticRoutes {
×
1489
                rtbs[route.RouteTable] = append(rtbs[route.RouteTable], route)
×
1490
        }
×
1491
        return rtbs
×
1492
}
1493

1494
func (c *Controller) updateVpcExternalStatus(key string, enableExternal bool) error {
×
1495
        cachedVpc, err := c.vpcsLister.Get(key)
×
1496
        if err != nil {
×
1497
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1498
                return err
×
1499
        }
×
1500
        vpc := cachedVpc.DeepCopy()
×
1501
        vpc.Status.EnableExternal = vpc.Spec.EnableExternal
×
1502
        vpc.Status.EnableBfd = vpc.Spec.EnableBfd
×
1503

×
1504
        if enableExternal {
×
1505
                sort.Strings(vpc.Spec.ExtraExternalSubnets)
×
1506
                vpc.Status.ExtraExternalSubnets = vpc.Spec.ExtraExternalSubnets
×
1507
        } else {
×
1508
                vpc.Status.ExtraExternalSubnets = nil
×
1509
        }
×
1510

1511
        bytes, err := vpc.Status.Bytes()
×
1512
        if err != nil {
×
1513
                klog.Errorf("failed to get vpc bytes, %v", err)
×
1514
                return err
×
1515
        }
×
1516
        if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),
×
1517
                vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {
×
1518
                klog.Errorf("failed to patch vpc %s, %v", key, err)
×
1519
                return err
×
1520
        }
×
1521

1522
        return nil
×
1523
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc