#5071

Committed 17 May 2026 01:15AM UTC coverage: 63.054% (-10.3%) from 73.326%

Build # #5071

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

feat (TDgpt): Dynamic Model Synchronization Enhancements (#35344)

* refactor: do some internal refactor.

* fix: fix multiprocess sync issue.

* feat: add dynamic anomaly detection and forecasting services

* fix: log error message for undeploying model in exception handling

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* fix: handle undeploy when model exists only on disk

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/286aafa0-c3ce-4c27-b803-2707571e9dc1

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* fix: guard dynamic registry concurrent access

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/5e4db858-6458-40f4-ac28-d1b1b7f97c18

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* fix: tighten service list locking scope

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/5e4db858-6458-40f4-ac28-d1b1b7f97c18

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* fix: restore prophet support and update tests per review feedback

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/92298ae1-7da6-4d07-b20e-101c7cd0b26b

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* fix: improve test name and move copy inside lock scope

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/92298ae1-7da6-4d07-b20e-101c7cd0b26b

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* Potential fix for pull request finding

Co-au... (continued)

Coverage Stats

238317 of 377957 relevant lines covered (63.05%)

130539817.12 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

25.4

/source/dnode/mnode/impl/src/mndSecurityPolicy.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "mndSecurityPolicy.h"
#include "mndCluster.h"
#include "mndMnode.h"
#include "mndPrivilege.h"
#include "mndRole.h"
#include "mndShow.h"
#include "mndTrans.h"
#include "mndUser.h"

// SDB raw format version.  Bump when adding new persistent fields.
#define SEC_POLICY_VER_NUMBE 1

static SSdbRaw *mndSecPolicyActionEncode(SSecurityPolicyObj *pObj);
static SSdbRow *mndSecPolicyActionDecode(SSdbRaw *pRaw);
static int32_t  mndSecPolicyActionInsert(SSdb *pSdb, SSecurityPolicyObj *pObj);
static int32_t  mndSecPolicyActionDelete(SSdb *pSdb, SSecurityPolicyObj *pObj);
static int32_t  mndSecPolicyActionUpdate(SSdb *pSdb, SSecurityPolicyObj *pOld, SSecurityPolicyObj *pNew);
static int32_t  mndCreateDefaultSecurityPolicy(SMnode *pMnode);
static int32_t  mndRetrieveSecurityPolicies(SRpcMsg *pMsg, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
static void     mndCancelGetNextSecurityPolicy(SMnode *pMnode, void *pIter);
static int32_t  mndProcessEnforceSodImpl(SMnode *pMnode);

int32_t mndInitSecurityPolicy(SMnode *pMnode) {
  SSdbTable table = {
      .sdbType = SDB_SECURITY_POLICY,
      .keyType = SDB_KEY_INT32,
      .deployFp = (SdbDeployFp)mndCreateDefaultSecurityPolicy,
      .encodeFp = (SdbEncodeFp)mndSecPolicyActionEncode,
      .decodeFp = (SdbDecodeFp)mndSecPolicyActionDecode,
      .insertFp = (SdbInsertFp)mndSecPolicyActionInsert,
      .updateFp = (SdbUpdateFp)mndSecPolicyActionUpdate,
      .deleteFp = (SdbDeleteFp)mndSecPolicyActionDelete,
  };

  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_SECURITY_POLICIES, mndRetrieveSecurityPolicies);
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_SECURITY_POLICIES, mndCancelGetNextSecurityPolicy);

  // Initialize MAC state cache — starts disabled, updated on successful activation
  pMnode->macActive = MAC_MODE_DISABLED;

  return sdbSetTable(pMnode->pSdb, table);
}

void mndCleanupSecurityPolicy(SMnode *pMnode) {}

// ---- SDB encode/decode ----

static SSdbRaw *mndSecPolicyActionEncode(SSecurityPolicyObj *pObj) {
  int32_t code = 0;
  int32_t lino = 0;
  terrno = TSDB_CODE_OUT_OF_MEMORY;

  SSdbRaw *pRaw = sdbAllocRaw(SDB_SECURITY_POLICY, SEC_POLICY_VER_NUMBE, sizeof(SSecurityPolicyObj));
  if (pRaw == NULL) goto _OVER;

  int32_t dataPos = 0;
  SDB_SET_INT32(pRaw, dataPos, pObj->type, _OVER)
  SDB_SET_INT64(pRaw, dataPos, pObj->createdTime, _OVER)
  SDB_SET_INT64(pRaw, dataPos, pObj->updateTime, _OVER)
  SDB_SET_INT64(pRaw, dataPos, pObj->activateTime, _OVER)
  SDB_SET_UINT8(pRaw, dataPos, pObj->status, _OVER)
  SDB_SET_BINARY(pRaw, dataPos, pObj->activator, TSDB_USER_LEN, _OVER)
  SDB_SET_BINARY(pRaw, dataPos, pObj->reserve, sizeof(pObj->reserve), _OVER)
  SDB_SET_DATALEN(pRaw, dataPos, _OVER);

  terrno = 0;

_OVER:
  if (terrno != 0) {
    mError("secpolicy:%d, failed to encode to raw:%p since %s", pObj->type, pRaw, terrstr());
    sdbFreeRaw(pRaw);
    return NULL;
  }

  mTrace("secpolicy:%d, encode to raw:%p, row:%p", pObj->type, pRaw, pObj);
  return pRaw;
}

static SSdbRow *mndSecPolicyActionDecode(SSdbRaw *pRaw) {
  int32_t code = 0;
  int32_t lino = 0;
  terrno = TSDB_CODE_OUT_OF_MEMORY;
  SSecurityPolicyObj *pObj = NULL;
  SSdbRow            *pRow = NULL;

  int8_t sver = 0;
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto _OVER;

  if (sver != SEC_POLICY_VER_NUMBE) {
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
    goto _OVER;
  }

  pRow = sdbAllocRow(sizeof(SSecurityPolicyObj));
  if (pRow == NULL) goto _OVER;

  pObj = sdbGetRowObj(pRow);
  if (pObj == NULL) goto _OVER;

  int32_t dataPos = 0;
  SDB_GET_INT32(pRaw, dataPos, &pObj->type, _OVER)
  SDB_GET_INT64(pRaw, dataPos, &pObj->createdTime, _OVER)
  SDB_GET_INT64(pRaw, dataPos, &pObj->updateTime, _OVER)
  SDB_GET_INT64(pRaw, dataPos, &pObj->activateTime, _OVER)
  SDB_GET_UINT8(pRaw, dataPos, &pObj->status, _OVER)
  SDB_GET_BINARY(pRaw, dataPos, pObj->activator, TSDB_USER_LEN, _OVER)
  SDB_GET_BINARY(pRaw, dataPos, pObj->reserve, sizeof(pObj->reserve), _OVER)

  terrno = 0;

_OVER:
  if (terrno != 0) {
    mError("secpolicy:%d, failed to decode from raw:%p since %s", pObj == NULL ? 0 : pObj->type, pRaw, terrstr());
    taosMemoryFreeClear(pRow);
    return NULL;
  }

  mTrace("secpolicy:%d, decode from raw:%p, row:%p", pObj->type, pRaw, pObj);
  return pRow;
}

static int32_t mndSecPolicyActionInsert(SSdb *pSdb, SSecurityPolicyObj *pObj) {
  mTrace("secpolicy:%d, perform insert action, row:%p", pObj->type, pObj);
  // Sync MAC state cache: fires on startup SDB replay, restoring persisted state
  if (pObj->type == TSDB_SECURITY_POLICY_MAC) {
    pSdb->pMnode->macActive = pObj->status;
  }
  return 0;
}

static int32_t mndSecPolicyActionDelete(SSdb *pSdb, SSecurityPolicyObj *pObj) {
  mTrace("secpolicy:%d, perform delete action, row:%p", pObj->type, pObj);
  return 0;
}

static int32_t mndSecPolicyActionUpdate(SSdb *pSdb, SSecurityPolicyObj *pOld, SSecurityPolicyObj *pNew) {
  mTrace("secpolicy:%d, perform update action, old row:%p new row:%p", pOld->type, pOld, pNew);
  pOld->updateTime = pNew->updateTime;
  pOld->activateTime = pNew->activateTime;
  pOld->status = pNew->status;
  tstrncpy(pOld->activator, pNew->activator, sizeof(pOld->activator));
  (void)memcpy(pOld->reserve, pNew->reserve, sizeof(pOld->reserve));
  // Sync MAC state cache: fires when Raft commit-log is applied — the true success point
  if (pOld->type == TSDB_SECURITY_POLICY_MAC) {
    pSdb->pMnode->macActive = pOld->status;
  }
  return 0;
}

// ---- Deploy helpers ----

// Append a single policy row as a commit-log entry in pTrans.
static int32_t mndAppendPolicyToTrans(STrans *pTrans, int32_t policyType) {
  SSecurityPolicyObj obj = {0};
  obj.type = policyType;
  obj.createdTime = taosGetTimestampMs();
  obj.updateTime = obj.createdTime;
  obj.activateTime = obj.createdTime;
  // status defaults to 0 (SEC_POLICY_STATUS_DEFAULT) for both SOD and MAC

  SSdbRaw *pRaw = mndSecPolicyActionEncode(&obj);
  if (pRaw == NULL) return terrno;

  int32_t code = sdbSetRawStatus(pRaw, SDB_STATUS_READY);
  if (code != 0) {
    sdbFreeRaw(pRaw);
    return code;
  }

  code = mndTransAppendCommitlog(pTrans, pRaw);
  if (code != 0) {
    // pRaw ownership transferred on success; free only on failure
    sdbFreeRaw(pRaw);
    return code;
  }

  // Second sdbSetRawStatus marks it ready-for-commit (matches cluster deploy pattern)
  return sdbSetRawStatus(pRaw, SDB_STATUS_READY);
}

static int32_t mndCreateDefaultSecurityPolicy(SMnode *pMnode) {
  // One transaction creates both SOD and MAC rows.
  // key = int32 policyType, no dependency on clusterId → deploy order safe.
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_NOTHING, NULL, "create-security-policy");
  if (pTrans == NULL) return terrno;

  int32_t code = 0;
  if ((code = mndAppendPolicyToTrans(pTrans, TSDB_SECURITY_POLICY_SOD)) != 0) goto _OVER;
  if ((code = mndAppendPolicyToTrans(pTrans, TSDB_SECURITY_POLICY_MAC)) != 0) goto _OVER;

  mInfo("trans:%d, used to create default security policies (SOD + MAC)", pTrans->id);

  if ((code = mndTransPrepare(pMnode, pTrans)) != 0) {
    mError("trans:%d, failed to prepare since %s", pTrans->id, tstrerror(code));
  }

_OVER:
  mndTransDrop(pTrans);
  return code;
}

// ---- SDB acquire/release helpers ----

static SSecurityPolicyObj *mndAcquireSecPolicy(SMnode *pMnode, int32_t policyType) {
  return (SSecurityPolicyObj *)sdbAcquire(pMnode->pSdb, SDB_SECURITY_POLICY, &policyType);
}

static void mndReleaseSecPolicy(SMnode *pMnode, SSecurityPolicyObj *pObj) { sdbRelease(pMnode->pSdb, pObj); }

// ---- Accessor functions ----

int32_t mndGetClusterSoDMode(SMnode *pMnode) {
  int32_t             sodMode = SOD_MODE_ENABLED;
  SSecurityPolicyObj *pObj = mndAcquireSecPolicy(pMnode, TSDB_SECURITY_POLICY_SOD);
  if (pObj != NULL) {
    sodMode = pObj->status;
    mndReleaseSecPolicy(pMnode, pObj);
  }
  return sodMode;
}

// ---- show security_policies ----

static const char *_SoDMandatoryInfo[3][2] = {
    {"mandatory", "system is operational, root disabled permanently"},
    {"mandatory(initial)", "Initial phase: mandatory roles missing, only account setup operations are allowed"},
    {"mandatory(enforcing)", "Enforce phase: transitioning mode, account destructive operations are blocked"},
};

static int32_t mndRetrieveSecurityPolicies(SRpcMsg *pMsg, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
  SMnode             *pMnode = pMsg->info.node;
  SSdb               *pSdb = pMnode->pSdb;
  int32_t             code = 0, lino = 0;
  int32_t             numOfRows = 0;
  SSecurityPolicyObj *pObj = NULL;
  char                buf[128 + VARSTR_HEADER_SIZE] = {0};

  while (numOfRows < rows) {
    pShow->pIter = sdbFetch(pSdb, SDB_SECURITY_POLICY, pShow->pIter, (void **)&pObj);
    if (pShow->pIter == NULL) break;

    int32_t cols = 0;

    if (pObj->type == TSDB_SECURITY_POLICY_SOD) {
      int32_t sodPhase = mndGetSoDPhase(pMnode);
      bool    sodEnabled = (pObj->status == SOD_MODE_ENABLED);

      STR_WITH_MAXSIZE_TO_VARSTR(buf, "SoD", pShow->pMeta->pSchemas[cols].bytes);
      SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
      COL_DATA_SET_VAL_GOTO(buf, false, pObj, pShow->pIter, _OVER);

      STR_WITH_MAXSIZE_TO_VARSTR(buf, sodEnabled ? "enabled" : _SoDMandatoryInfo[sodPhase][0],
                                 pShow->pMeta->pSchemas[cols].bytes);
      pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
      COL_DATA_SET_VAL_GOTO(buf, false, pObj, pShow->pIter, _OVER);

      STR_WITH_MAXSIZE_TO_VARSTR(buf, sodEnabled ? "SYSTEM" : pObj->activator, pShow->pMeta->pSchemas[cols].bytes);
      pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
      COL_DATA_SET_VAL_GOTO(buf, false, pObj, pShow->pIter, _OVER);

      pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
      COL_DATA_SET_VAL_GOTO((const char *)&pObj->updateTime, false, pObj, pShow->pIter, _OVER);

      STR_WITH_MAXSIZE_TO_VARSTR(buf, sodEnabled ? "non-mandatory, root not disabled" : _SoDMandatoryInfo[sodPhase][1],
                                 pShow->pMeta->pSchemas[cols].bytes);
      pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
      COL_DATA_SET_VAL_GOTO(buf, false, pObj, pShow->pIter, _OVER);

    } else if (pObj->type == TSDB_SECURITY_POLICY_MAC) {
      bool macActive = (pObj->status == MAC_MODE_MANDATORY);

      STR_WITH_MAXSIZE_TO_VARSTR(buf, "MAC", pShow->pMeta->pSchemas[cols].bytes);
      SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
      COL_DATA_SET_VAL_GOTO(buf, false, pObj, pShow->pIter, _OVER);

      STR_WITH_MAXSIZE_TO_VARSTR(buf, macActive ? "mandatory" : "disabled", pShow->pMeta->pSchemas[cols].bytes);
      pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
      COL_DATA_SET_VAL_GOTO(buf, false, pObj, pShow->pIter, _OVER);

      STR_WITH_MAXSIZE_TO_VARSTR(buf, macActive ? pObj->activator : "SYSTEM", pShow->pMeta->pSchemas[cols].bytes);
      pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
      COL_DATA_SET_VAL_GOTO(buf, false, pObj, pShow->pIter, _OVER);

      pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
      COL_DATA_SET_VAL_GOTO((const char *)&pObj->updateTime, false, pObj, pShow->pIter, _OVER);

      STR_WITH_MAXSIZE_TO_VARSTR(buf, macActive ? "security levels 0-4; activated, irreversible" : "not activated",
                                 pShow->pMeta->pSchemas[cols].bytes);
      pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
      COL_DATA_SET_VAL_GOTO(buf, false, pObj, pShow->pIter, _OVER);

    } else {
      // Unknown policy type — skip row silently
      sdbRelease(pSdb, pObj);
      continue;
    }

    sdbRelease(pSdb, pObj);
    ++numOfRows;
  }

  pShow->numOfRows += numOfRows;

_OVER:
  if (code != 0) {
    mError("failed to retrieve security policies at line %d since %s", lino, tstrerror(code));
    TAOS_RETURN(code);
  }
  return numOfRows;
}

static void mndCancelGetNextSecurityPolicy(SMnode *pMnode, void *pIter) {
  SSdb *pSdb = pMnode->pSdb;
  sdbCancelFetchByType(pSdb, pIter, SDB_SECURITY_POLICY);
}

// ---- SoD config handler ----

// #ifdef TD_ENTERPRISE
int32_t mndProcessConfigSoDReq(SMnode *pMnode, SRpcMsg *pReq, SMCfgClusterReq *pCfg) {
  int32_t code = 0, lino = 0;
#ifdef TD_ENTERPRISE
  SSecurityPolicyObj obj = {0};
  STrans            *pTrans = NULL;
  SUserObj          *pRootUser = NULL;
  SUserObj           newRootUser = {0};

  TAOS_CHECK_EXIT(mndCheckOperPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_CONFIG_SOD));

  if (taosStrncasecmp(pCfg->value, "mandatory", 10) != 0) {
    TAOS_CHECK_EXIT(TSDB_CODE_INVALID_CFG_VALUE);
  }

  SSecurityPolicyObj *pObj = mndAcquireSecPolicy(pMnode, TSDB_SECURITY_POLICY_SOD);
  if (!pObj) {
    TAOS_CHECK_EXIT(TSDB_CODE_APP_IS_STARTING);
  }

  if (pObj->status == SOD_MODE_MANDATORY) {
    mndReleaseSecPolicy(pMnode, pObj);
    TAOS_RETURN(0);
  }

  if ((code = mndCheckManagementRoleStatus(pMnode, NULL, 0))) {
    mndReleaseSecPolicy(pMnode, pObj);
    TAOS_CHECK_EXIT(code);
  }

  mInfo("update security policy SoD mode to mandatory by %s", RPC_MSG_USER(pReq));
  (void)memcpy(&obj, pObj, sizeof(SSecurityPolicyObj));
  obj.status = SOD_MODE_MANDATORY;
  obj.activateTime = taosGetTimestampMs();
  obj.updateTime = obj.activateTime;
  tstrncpy(obj.activator, RPC_MSG_USER(pReq), sizeof(obj.activator));
  mndReleaseSecPolicy(pMnode, pObj);

  TAOS_CHECK_EXIT(mndAcquireUser(pMnode, "root", &pRootUser));
  TAOS_CHECK_EXIT(mndUserDupObj(pRootUser, &newRootUser));
  newRootUser.enable = 0;

  pTrans = mndTransCreate(pMnode, TRN_POLICY_ROLLBACK, TRN_CONFLICT_ROLE, pReq, "update-sod-mode");
  if (pTrans == NULL) {
    TAOS_CHECK_EXIT(terrno);
  }

  SSdbRaw *pCommitRaw = mndSecPolicyActionEncode(&obj);
  if (pCommitRaw == NULL || mndTransAppendCommitlog(pTrans, pCommitRaw) != 0) {
    if (pCommitRaw) sdbFreeRaw(pCommitRaw);
    TAOS_CHECK_EXIT(terrno);
  }
  TAOS_CHECK_EXIT(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));

  SSdbRaw *pCommitRawRoot = mndUserActionEncode(&newRootUser);
  if (pCommitRawRoot == NULL || mndTransAppendCommitlog(pTrans, pCommitRawRoot) != 0) {
    if (pCommitRawRoot) sdbFreeRaw(pCommitRawRoot);
    TAOS_CHECK_EXIT(terrno);
  }
  TAOS_CHECK_EXIT(sdbSetRawStatus(pCommitRawRoot, SDB_STATUS_READY));

  mndSetSoDPhase(pMnode, TSDB_SOD_PHASE_ENFORCE);
  mndTransSetCb(pTrans, 0, TRANS_STOP_FUNC_SOD, NULL, 0);
  if ((code = mndTransPrepare(pMnode, pTrans)) != 0) {
    mndSetSoDPhase(pMnode, TSDB_SOD_PHASE_STABLE);
    TAOS_CHECK_EXIT(code);
  }

_exit:
  if (pRootUser) mndReleaseUser(pMnode, pRootUser);
  mndUserFreeObj(&newRootUser);
  mndTransDrop(pTrans);
  if (code < 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
    mError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
  }
#endif
  TAOS_RETURN(code);
}
// #endif

// ---- MAC config handler ----

// #ifdef TD_ENTERPRISE
int32_t mndProcessConfigMacReq(SMnode *pMnode, SRpcMsg *pReq, SMCfgClusterReq *pCfg) {
  int32_t            code = 0, lino = 0;
  SSecurityPolicyObj obj = {0};
  STrans            *pTrans = NULL;
  SUserObj          *pScanUser = NULL;
  void              *pScanIter = NULL;

  TAOS_CHECK_EXIT(mndCheckOperPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_CONFIG_MAC));

  if (taosStrncasecmp(pCfg->value, "mandatory", 10) != 0) {
    TAOS_CHECK_EXIT(TSDB_CODE_INVALID_CFG_VALUE);
  }

  SSecurityPolicyObj *pObj = mndAcquireSecPolicy(pMnode, TSDB_SECURITY_POLICY_MAC);
  if (!pObj) {
    TAOS_CHECK_EXIT(TSDB_CODE_APP_IS_STARTING);
  }

  if (pObj->status == MAC_MODE_MANDATORY) {
    mInfo("cluster MAC is already mandatory, ignoring repeated activation by %s", RPC_MSG_USER(pReq));
    mndReleaseSecPolicy(pMnode, pObj);
    TAOS_RETURN(0);
  }

  // Pre-activation check:
  // (A) Every user holding any system role (SYSSEC/SYSAUDIT/SYSAUDIT_LOG/SYSDBA) must have
  //     both minSecLevel and maxSecLevel satisfying the role's floor constraints:
  //       SYSSEC/SYSAUDIT/SYSAUDIT_LOG: min floor=4, max floor=4
  //       SYSDBA: min floor=0, max floor=3
  // (B) Any user directly holding PRIV_SECURITY_POLICY_ALTER (not via role) must have maxSecLevel=4.
  //     (No constraint on minSecLevel for this check.)
  // On the first failing user found, immediately abort and return its name in the error message.
  {
    SSdb *pSdb = pMnode->pSdb;

    while ((pScanIter = sdbFetch(pSdb, SDB_USER, pScanIter, (void **)&pScanUser)) != NULL) {
      if (pScanUser->superUser) {
        sdbRelease(pSdb, pScanUser);
        pScanUser = NULL;
        continue;
      }
      int8_t floorMaxLevel = mndGetUserRoleFloorMaxLevel(pScanUser->roles);
      int8_t floorMinLevel = mndGetUserRoleFloorMinLevel(pScanUser->roles);
      bool   hasDirectPriv = PRIV_HAS(&pScanUser->sysPrivs, PRIV_SECURITY_POLICY_ALTER);
      // Skip users with neither a system role nor direct PRIV_SECURITY_POLICY_ALTER
      if (floorMaxLevel == 0 && floorMinLevel == 0 && !hasDirectPriv) {
        sdbRelease(pSdb, pScanUser);
        pScanUser = NULL;
        continue;
      }
      char   reason[256] = {0};
      int8_t hintMin = 0, hintMax = 0;
      if (pScanUser->maxSecLevel < floorMaxLevel) {
        snprintf(reason, sizeof(reason), "maxSecLevel(%d) < required maxFloor(%d) (role constraint)",
                 (int32_t)pScanUser->maxSecLevel, (int32_t)floorMaxLevel);
        hintMin = floorMinLevel;
        hintMax = floorMaxLevel;
      } else if (pScanUser->minSecLevel < floorMinLevel) {
        snprintf(reason, sizeof(reason), "minSecLevel(%d) < required minFloor(%d) (role constraint)",
                 (int32_t)pScanUser->minSecLevel, (int32_t)floorMinLevel);
        hintMin = floorMinLevel;
        hintMax = floorMaxLevel;
      } else if (hasDirectPriv && pScanUser->maxSecLevel < TSDB_MAX_SECURITY_LEVEL) {
        // (B): direct PRIV_SECURITY_POLICY_ALTER holder must have maxSecLevel=4
        snprintf(reason, sizeof(reason),
                 "maxSecLevel(%d) < %d (direct PRIV_SECURITY_POLICY_ALTER holder must have maxSecLevel=%d)",
                 (int32_t)pScanUser->maxSecLevel, (int32_t)TSDB_MAX_SECURITY_LEVEL, (int32_t)TSDB_MAX_SECURITY_LEVEL);
        hintMin = pScanUser->minSecLevel;  // min is already acceptable; keep it
        hintMax = TSDB_MAX_SECURITY_LEVEL;
      }
      if (reason[0] != '\0') {
        mError("MAC preflight: user '%s' %s", pScanUser->user, reason);
        char detail[512];
        snprintf(detail, sizeof(detail),
                 "Cannot enable MAC: user '%s' %s. "
                 "Please ALTER USER %s SECURITY_LEVEL %d,%d to satisfy constraints first.",
                 pScanUser->user, reason, pScanUser->user, (int32_t)hintMin, (int32_t)hintMax);
        sdbRelease(pSdb, pScanUser);
        pScanUser = NULL;
        sdbCancelFetch(pSdb, pScanIter);
        pScanIter = NULL;

        int32_t detailLen = strlen(detail) + 1;
        void   *pRsp = rpcMallocCont(detailLen);
        if (pRsp != NULL) {
          memcpy(pRsp, detail, detailLen);
          pReq->info.rspLen = detailLen;
          pReq->info.rsp = pRsp;
        }
        mndReleaseSecPolicy(pMnode, pObj);
        code = TSDB_CODE_MAC_PRECHECK_FAILED;
        goto _exit;
      }
      sdbRelease(pSdb, pScanUser);
      pScanUser = NULL;
    }
    pScanIter = NULL;
  }

  mInfo("activating cluster MAC by %s", RPC_MSG_USER(pReq));
  (void)memcpy(&obj, pObj, sizeof(SSecurityPolicyObj));
  obj.status = MAC_MODE_MANDATORY;
  obj.activateTime = taosGetTimestampMs();
  obj.updateTime = obj.activateTime;
  tstrncpy(obj.activator, RPC_MSG_USER(pReq), sizeof(obj.activator));
  mndReleaseSecPolicy(pMnode, pObj);
  pObj = NULL;

  pTrans = mndTransCreate(pMnode, TRN_POLICY_ROLLBACK, TRN_CONFLICT_ROLE, pReq, "activate-mac");
  if (pTrans == NULL) {
    TAOS_CHECK_EXIT(terrno);
  }

  SSdbRaw *pCommitRaw = mndSecPolicyActionEncode(&obj);
  if (pCommitRaw == NULL || mndTransAppendCommitlog(pTrans, pCommitRaw) != 0) {
    if (pCommitRaw) sdbFreeRaw(pCommitRaw);
    TAOS_CHECK_EXIT(terrno);
  }
  TAOS_CHECK_EXIT(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));

  if ((code = mndTransPrepare(pMnode, pTrans)) != 0) {
    TAOS_CHECK_EXIT(code);
  }

_exit:
  if (pScanIter) sdbCancelFetch(pMnode->pSdb, pScanIter);
  if (pScanUser) sdbRelease(pMnode->pSdb, pScanUser);
  mndTransDrop(pTrans);
  if (code < 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
    mError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
  }
  TAOS_RETURN(code);
}
// #endif

// ---- SoD enforcement ----

void mndSodTransStop(SMnode *pMnode, void *param, int32_t paramLen) {
#ifdef TD_ENTERPRISE
  mInfo("SoD trans stop, set SoD phase to %d", TSDB_SOD_PHASE_STABLE);
  mndSetSoDPhase(pMnode, TSDB_SOD_PHASE_STABLE);
#endif
}

void mndSodGrantRoleStop(SMnode *pMnode, void *param, int32_t paramLen) {
#ifdef TD_ENTERPRISE
  if (mndGetSoDPhase(pMnode) != TSDB_SOD_PHASE_INITIAL) {
    return;
  }

  if (mndCheckManagementRoleStatus(pMnode, NULL, 0) == 0) {
    mInfo("SoD role check completed, all mandatory roles satisfied, trigger enforce SoD");
    (void)mndProcessEnforceSodImpl(pMnode);
  }
#endif
}

#ifdef TD_ENTERPRISE
static int32_t mndProcessEnforceSodImpl(SMnode *pMnode) {
  int32_t code = 0, lino = 0;
  int32_t contLen = 0;
  void   *pCont = NULL;

  SMCfgClusterReq cfgReq = {0};
  tsnprintf(cfgReq.config, sizeof(cfgReq.config), "SoD");
  tsnprintf(cfgReq.value, sizeof(cfgReq.value), "mandatory");
  contLen = tSerializeSMCfgClusterReq(NULL, 0, &cfgReq);
  TAOS_CHECK_EXIT(contLen);
  if (!(pCont = rpcMallocCont(contLen))) {
    TAOS_CHECK_EXIT(TSDB_CODE_OUT_OF_MEMORY);
  }

  if ((code = tSerializeSMCfgClusterReq(pCont, contLen, &cfgReq)) != contLen) {
    rpcFreeCont(pCont);
    TAOS_CHECK_EXIT(code);
  }

  SRpcMsg rpcMsg = {.pCont = pCont,
                    .contLen = contLen,
                    .msgType = TDMT_MND_CONFIG_CLUSTER,
                    .info.ahandle = 0,
                    .info.notFreeAhandle = 1};
  SEpSet  epSet = {0};
  mndGetMnodeEpSet(pMnode, &epSet);
  TAOS_CHECK_EXIT(tmsgSendReq(&epSet, &rpcMsg));
_exit:
  if (code < 0) {
    mError("failed at line %d to enforce SoD since %s", lino, tstrerror(code));
  }
  TAOS_RETURN(code);
}

int32_t mndProcessEnforceSod(SMnode *pMnode) {
  int32_t code = 0, lino = 0;

  SSecurityPolicyObj *pObj = mndAcquireSecPolicy(pMnode, TSDB_SECURITY_POLICY_SOD);
  if (pObj == NULL) {
    TAOS_CHECK_EXIT(terrno);
  }

  if (pObj->status == SOD_MODE_MANDATORY) {
    mInfo("cluster is already in SoD mandatory mode");
    mndReleaseSecPolicy(pMnode, pObj);
    TAOS_RETURN(0);
  }

  mndSetSoDPhase(pMnode, TSDB_SOD_PHASE_INITIAL);
  mInfo("start to enforce SoD from initial phase, secpolicy type:%d", pObj->type);
  if ((code = mndCheckManagementRoleStatus(pMnode, NULL, 0))) {
    mndReleaseSecPolicy(pMnode, pObj);
    TAOS_CHECK_EXIT(code);
  }
  mndReleaseSecPolicy(pMnode, pObj);

  TAOS_CHECK_EXIT(mndProcessEnforceSodImpl(pMnode));
  code = TSDB_CODE_ACTION_IN_PROGRESS;

_exit:
  if (code < 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
    mError("failed to enforce SoD at line %d since %s", lino, tstrerror(code));
  }
  TAOS_RETURN(code);
}
#endif

taosdata / TDengine / #5071

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous