• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #5071

17 May 2026 01:15AM UTC coverage: 63.054% (-10.3%) from 73.326%
#5071

push

travis-ci

web-flow
feat (TDgpt): Dynamic Model Synchronization Enhancements (#35344)

* refactor: do some internal refactor.

* fix: fix multiprocess sync issue.

* feat: add dynamic anomaly detection and forecasting services

* fix: log error message for undeploying model in exception handling

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* fix: handle undeploy when model exists only on disk

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/286aafa0-c3ce-4c27-b803-2707571e9dc1

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* fix: guard dynamic registry concurrent access

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/5e4db858-6458-40f4-ac28-d1b1b7f97c18

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* fix: tighten service list locking scope

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/5e4db858-6458-40f4-ac28-d1b1b7f97c18

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* fix: restore prophet support and update tests per review feedback

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/92298ae1-7da6-4d07-b20e-101c7cd0b26b

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* fix: improve test name and move copy inside lock scope

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/92298ae1-7da6-4d07-b20e-101c7cd0b26b

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* Potential fix for pull request finding

Co-au... (continued)

238317 of 377957 relevant lines covered (63.05%)

130539817.12 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

76.83
/source/dnode/mnode/impl/src/mndIndex.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "mndIndex.h"
18
#include "mndDb.h"
19
#include "mndDnode.h"
20
#include "mndIndexComm.h"
21
#include "mndInfoSchema.h"
22
#include "mndMnode.h"
23
#include "mndPrivilege.h"
24
#include "mndShow.h"
25
#include "mndStb.h"
26
#include "mndStream.h"
27
#include "mndTrans.h"
28
#include "mndUser.h"
29
#include "mndVgroup.h"
30
#include "parser.h"
31
#include "tname.h"
32

33
#define TSDB_IDX_VER_NUMBER   1
34
#define TSDB_IDX_RESERVE_SIZE 32
35

36
static SSdbRaw *mndIdxActionEncode(SIdxObj *pSma);
37
static SSdbRow *mndIdxActionDecode(SSdbRaw *pRaw);
38
static int32_t  mndIdxActionInsert(SSdb *pSdb, SIdxObj *pIdx);
39
static int32_t  mndIdxActionDelete(SSdb *pSdb, SIdxObj *pIdx);
40
static int32_t  mndIdxActionUpdate(SSdb *pSdb, SIdxObj *pOld, SIdxObj *pNew);
41
static int32_t  mndProcessCreateIdxReq(SRpcMsg *pReq);
42
// static int32_t  mndProcessDropIdxReq(SRpcMsg *pReq);
43
static int32_t mndProcessGetIdxReq(SRpcMsg *pReq);
44
static int32_t mndProcessGetTbIdxReq(SRpcMsg *pReq);
45
// static int32_t mndRetrieveIdx(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
46
//  static void    mndCancelGetNextIdx(SMnode *pMnode, void *pIter);
47
static void mndDestroyIdxObj(SIdxObj *pIdxObj);
48

49
static int32_t mndAddIndex(SMnode *pMnode, SRpcMsg *pReq, SCreateTagIndexReq *req, SDbObj *pDb, SStbObj *pStb,
50
                           SUserObj *pOp);
51

52
int32_t mndInitIdx(SMnode *pMnode) {
404,334✔
53
  SSdbTable table = {
404,334✔
54
      .sdbType = SDB_IDX,
55
      .keyType = SDB_KEY_BINARY,
56
      .encodeFp = (SdbEncodeFp)mndIdxActionEncode,
57
      .decodeFp = (SdbDecodeFp)mndIdxActionDecode,
58
      .insertFp = (SdbInsertFp)mndIdxActionInsert,
59
      .updateFp = (SdbUpdateFp)mndIdxActionUpdate,
60
      .deleteFp = (SdbDeleteFp)mndIdxActionDelete,
61
  };
62

63
  mndSetMsgHandle(pMnode, TDMT_MND_CREATE_INDEX, mndProcessCreateIdxReq);
404,334✔
64
  // mndSetMsgHandle(pMnode, TDMT_MND_DROP_INDEX, mndProcessDropIdxReq);
65

66
  mndSetMsgHandle(pMnode, TDMT_VND_CREATE_INDEX_RSP, mndTransProcessRsp);
404,334✔
67
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_INDEX_RSP, mndTransProcessRsp);
404,334✔
68

69
  // mndSetMsgHandle(pMnode, TDMT_MND_CREATE_SMA, mndProcessCreateIdxReq);
70
  // mndSetMsgHandle(pMnode, TDMT_MND_DROP_SMA, mndProcessDropIdxReq);
71
  // mndSetMsgHandle(pMnode, TDMT_VND_CREATE_SMA_RSP, mndTransProcessRsp);
72
  // mndSetMsgHandle(pMnode, TDMT_VND_DROP_SMA_RSP, mndTransProcessRsp);
73
  // mndSetMsgHandle(pMnode, TDMT_MND_GET_INDEX, mndProcessGetIdxReq);
74
  // mndSetMsgHandle(pMnode, TDMT_MND_GET_TABLE_INDEX, mndProcessGetTbIdxReq);
75

76
  // type same with sma
77
  // mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_INDEX, mndRetrieveIdx);
78
  // mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_INDEX, mndCancelGetNextIdx);
79
  return sdbSetTable(pMnode->pSdb, table);
404,334✔
80
}
81

82
static int32_t mndFindSuperTableTagId(const SStbObj *pStb, const char *tagName, int8_t *hasIdx) {
31,948✔
83
  for (int32_t tag = 0; tag < pStb->numOfTags; tag++) {
166,192✔
84
    if (taosStrcasecmp(pStb->pTags[tag].name, tagName) == 0) {
166,192✔
85
      if (IS_IDX_ON(&pStb->pTags[tag])) {
31,948✔
86
        *hasIdx = 1;
11,972✔
87
      }
88
      return tag;
31,948✔
89
    }
90
  }
91

92
  return TSDB_CODE_MND_TAG_NOT_EXIST;
×
93
}
94

95
int mndSetCreateIdxRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb, SIdxObj *pIdx) {
9,988✔
96
  int32_t code = 0;
9,988✔
97
  SSdb   *pSdb = pMnode->pSdb;
9,988✔
98
  SVgObj *pVgroup = NULL;
9,988✔
99
  void   *pIter = NULL;
9,988✔
100
  int32_t contLen;
9,988✔
101

102
  while (1) {
23,910✔
103
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
33,898✔
104
    if (pIter == NULL) break;
33,898✔
105
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
23,910✔
106
      sdbRelease(pSdb, pVgroup);
4,543✔
107
      continue;
4,543✔
108
    }
109

110
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
19,367✔
111
    if (pReq == NULL) {
19,367✔
112
      sdbCancelFetch(pSdb, pIter);
×
113
      sdbRelease(pSdb, pVgroup);
×
114
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
115
      if (terrno != 0) code = terrno;
×
116
      TAOS_RETURN(code);
×
117
    }
118
    STransAction action = {0};
19,367✔
119
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
19,367✔
120
    action.pCont = pReq;
19,367✔
121
    action.contLen = contLen;
19,367✔
122
    action.msgType = TDMT_VND_CREATE_INDEX;
19,367✔
123
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
19,367✔
124
      taosMemoryFree(pReq);
×
125
      sdbCancelFetch(pSdb, pIter);
×
126
      sdbRelease(pSdb, pVgroup);
×
127
      TAOS_RETURN(code);
×
128
    }
129
    sdbRelease(pSdb, pVgroup);
19,367✔
130
  }
131

132
  return 0;
9,988✔
133
}
134
static void *mndBuildDropIdxReq(SMnode *pMnode, SVgObj *pVgroup, SStbObj *pStbObj, SIdxObj *pIdx, int32_t *contLen) {
16,256✔
135
  int32_t len = 0;
16,256✔
136

137
  SDropIndexReq req = {0};
16,256✔
138
  memcpy(req.colName, pIdx->colName, sizeof(pIdx->colName));
16,256✔
139
  memcpy(req.stb, pIdx->stb, sizeof(pIdx->stb));
16,256✔
140
  req.dbUid = pIdx->dbUid;
16,256✔
141
  req.stbUid = pIdx->stbUid;
16,256✔
142

143
  mInfo("idx: %s start to build drop index req", pIdx->name);
16,256✔
144

145
  len = tSerializeSDropIdxReq(NULL, 0, &req);
16,256✔
146
  if (len < 0) {
16,256✔
147
    goto _err;
×
148
  }
149

150
  len += sizeof(SMsgHead);
16,256✔
151
  SMsgHead *pHead = taosMemoryCalloc(1, len);
16,256✔
152
  if (pHead == NULL) {
16,256✔
153
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
154
    goto _err;
×
155
  }
156

157
  pHead->contLen = htonl(len);
16,256✔
158
  pHead->vgId = htonl(pVgroup->vgId);
16,256✔
159

160
  void   *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
16,256✔
161
  int32_t ret = 0;
16,256✔
162
  if ((ret = tSerializeSDropIdxReq(pBuf, len - sizeof(SMsgHead), &req)) < 0) {
16,256✔
163
    terrno = ret;
×
164
    return NULL;
×
165
  }
166
  *contLen = len;
16,256✔
167
  return pHead;
16,256✔
168
_err:
×
169

170
  return NULL;
×
171
}
172
int mndSetDropIdxRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb, SIdxObj *pIdx) {
8,128✔
173
  int32_t code = 0;
8,128✔
174
  SSdb   *pSdb = pMnode->pSdb;
8,128✔
175
  SVgObj *pVgroup = NULL;
8,128✔
176
  void   *pIter = NULL;
8,128✔
177
  int32_t contLen;
178

179
  while (1) {
17,112✔
180
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
25,240✔
181
    if (pIter == NULL) break;
25,240✔
182
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
17,112✔
183
      sdbRelease(pSdb, pVgroup);
856✔
184
      continue;
856✔
185
    }
186

187
    int32_t len;
16,256✔
188
    void   *pReq = mndBuildDropIdxReq(pMnode, pVgroup, pStb, pIdx, &len);
16,256✔
189
    if (pReq == NULL) {
16,256✔
190
      sdbCancelFetch(pSdb, pIter);
×
191
      sdbRelease(pSdb, pVgroup);
×
192
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
193
      if (terrno != 0) code = terrno;
×
194
      return code;
×
195
    }
196
    STransAction action = {0};
16,256✔
197
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
16,256✔
198
    action.pCont = pReq;
16,256✔
199
    action.contLen = len;
16,256✔
200
    action.msgType = TDMT_VND_DROP_INDEX;
16,256✔
201
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
16,256✔
202
      taosMemoryFree(pReq);
×
203
      sdbCancelFetch(pSdb, pIter);
×
204
      sdbRelease(pSdb, pVgroup);
×
205
      return code;
×
206
    }
207
    sdbRelease(pSdb, pVgroup);
16,256✔
208
  }
209

210
  TAOS_RETURN(code);
8,128✔
211
}
212

213
void mndCleanupIdx(SMnode *pMnode) {
404,334✔
214
  // do nothing
215
  return;
404,334✔
216
}
217

218
static SSdbRaw *mndIdxActionEncode(SIdxObj *pIdx) {
4,059,520✔
219
  int32_t code = 0;
4,059,520✔
220
  int32_t lino = 0;
4,059,520✔
221
  terrno = TSDB_CODE_OUT_OF_MEMORY;
4,059,520✔
222

223
  // int32_t size =
224
  //     sizeof(SSmaObj) + pSma->exprLen + pSma->tagsFilterLen + pSma->sqlLen + pSma->astLen + TSDB_IDX_RESERVE_SIZE;
225
  int32_t size = sizeof(SIdxObj) + TSDB_IDX_RESERVE_SIZE;
4,059,520✔
226

227
  SSdbRaw *pRaw = sdbAllocRaw(SDB_IDX, TSDB_IDX_VER_NUMBER, size);
4,059,520✔
228
  if (pRaw == NULL) goto _OVER;
4,059,520✔
229

230
  int32_t dataPos = 0;
4,059,520✔
231
  SDB_SET_BINARY(pRaw, dataPos, pIdx->name, TSDB_TABLE_FNAME_LEN, _OVER)
4,059,520✔
232
  SDB_SET_BINARY(pRaw, dataPos, pIdx->stb, TSDB_TABLE_FNAME_LEN, _OVER)
4,059,520✔
233
  SDB_SET_BINARY(pRaw, dataPos, pIdx->db, TSDB_DB_FNAME_LEN, _OVER)
4,059,520✔
234
  SDB_SET_BINARY(pRaw, dataPos, pIdx->dstTbName, TSDB_DB_FNAME_LEN, _OVER)
4,059,520✔
235
  SDB_SET_BINARY(pRaw, dataPos, pIdx->colName, TSDB_COL_NAME_LEN, _OVER)
4,059,520✔
236
  SDB_SET_INT64(pRaw, dataPos, pIdx->createdTime, _OVER)
4,059,520✔
237
  SDB_SET_INT64(pRaw, dataPos, pIdx->uid, _OVER)
4,059,520✔
238
  SDB_SET_INT64(pRaw, dataPos, pIdx->stbUid, _OVER)
4,059,520✔
239
  SDB_SET_INT64(pRaw, dataPos, pIdx->dbUid, _OVER)
4,059,520✔
240

241
  SDB_SET_BINARY(pRaw, dataPos, pIdx->createUser, TSDB_USER_LEN, _OVER)
4,059,520✔
242
  SDB_SET_INT64(pRaw, dataPos, pIdx->ownerId, _OVER)
4,059,520✔
243
  SDB_SET_RESERVE(pRaw, dataPos, TSDB_IDX_RESERVE_SIZE, _OVER)
4,059,520✔
244
  SDB_SET_DATALEN(pRaw, dataPos, _OVER)
4,059,520✔
245

246
  terrno = 0;
4,059,520✔
247

248
_OVER:
4,059,520✔
249
  if (terrno != 0) {
4,059,520✔
250
    mError("idx:%s, failed to encode to raw:%p since %s", pIdx->name, pRaw, terrstr());
×
251
    sdbFreeRaw(pRaw);
×
252
    return NULL;
×
253
  }
254

255
  mTrace("idx:%s, encode to raw:%p, row:%p", pIdx->name, pRaw, pIdx);
4,059,520✔
256
  return pRaw;
4,059,520✔
257
}
258

259
static SSdbRow *mndIdxActionDecode(SSdbRaw *pRaw) {
3,056,702✔
260
  int32_t code = 0;
3,056,702✔
261
  int32_t lino = 0;
3,056,702✔
262
  terrno = TSDB_CODE_OUT_OF_MEMORY;
3,056,702✔
263
  SSdbRow *pRow = NULL;
3,056,702✔
264
  SIdxObj *pIdx = NULL;
3,056,702✔
265

266
  int8_t sver = 0;
3,056,702✔
267
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto _OVER;
3,056,702✔
268

269
  if (sver != TSDB_IDX_VER_NUMBER) {
3,056,702✔
270
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
271
    goto _OVER;
×
272
  }
273

274
  pRow = sdbAllocRow(sizeof(SIdxObj));
3,056,702✔
275
  if (pRow == NULL) goto _OVER;
3,056,702✔
276

277
  pIdx = sdbGetRowObj(pRow);
3,056,702✔
278
  if (pIdx == NULL) goto _OVER;
3,056,702✔
279

280
  int32_t dataPos = 0;
3,056,702✔
281

282
  SDB_GET_BINARY(pRaw, dataPos, pIdx->name, TSDB_TABLE_FNAME_LEN, _OVER)
3,056,702✔
283
  SDB_GET_BINARY(pRaw, dataPos, pIdx->stb, TSDB_TABLE_FNAME_LEN, _OVER)
3,056,702✔
284
  SDB_GET_BINARY(pRaw, dataPos, pIdx->db, TSDB_DB_FNAME_LEN, _OVER)
3,056,702✔
285
  SDB_GET_BINARY(pRaw, dataPos, pIdx->dstTbName, TSDB_DB_FNAME_LEN, _OVER)
3,056,702✔
286
  SDB_GET_BINARY(pRaw, dataPos, pIdx->colName, TSDB_COL_NAME_LEN, _OVER)
3,056,702✔
287
  SDB_GET_INT64(pRaw, dataPos, &pIdx->createdTime, _OVER)
3,056,702✔
288
  SDB_GET_INT64(pRaw, dataPos, &pIdx->uid, _OVER)
3,056,702✔
289
  SDB_GET_INT64(pRaw, dataPos, &pIdx->stbUid, _OVER)
3,056,702✔
290
  SDB_GET_INT64(pRaw, dataPos, &pIdx->dbUid, _OVER)
3,056,702✔
291
  SDB_GET_BINARY(pRaw, dataPos, pIdx->createUser, TSDB_USER_LEN, _OVER)
3,056,702✔
292
  SDB_GET_INT64(pRaw, dataPos, &pIdx->ownerId, _OVER)
3,056,702✔
293
  SDB_GET_RESERVE(pRaw, dataPos, TSDB_IDX_RESERVE_SIZE, _OVER)
3,056,702✔
294

295
  terrno = 0;
3,056,702✔
296

297
_OVER:
3,056,702✔
298
  if (terrno != 0) {
3,056,702✔
299
    taosMemoryFree(pRow);
×
300
    return NULL;
×
301
  }
302

303
  mTrace("idx:%s, decode from raw:%p, row:%p", pIdx->name, pRaw, pIdx);
3,056,702✔
304
  return pRow;
3,056,702✔
305
}
306

307
static int32_t mndIdxActionInsert(SSdb *pSdb, SIdxObj *pIdx) {
1,912,007✔
308
  mTrace("idx:%s, perform insert action, row:%p", pIdx->name, pIdx);
1,912,007✔
309
  return 0;
1,912,007✔
310
}
311

312
static int32_t mndIdxActionDelete(SSdb *pSdb, SIdxObj *pIdx) {
3,056,702✔
313
  mTrace("idx:%s, perform delete action, row:%p", pIdx->name, pIdx);
3,056,702✔
314
  return 0;
3,056,702✔
315
}
316

317
static int32_t mndIdxActionUpdate(SSdb *pSdb, SIdxObj *pOld, SIdxObj *pNew) {
52,851✔
318
  // lock no not
319
  if (strncmp(pOld->colName, pNew->colName, TSDB_COL_NAME_LEN) != 0) {
52,851✔
320
    memcpy(pOld->colName, pNew->colName, sizeof(pNew->colName));
15,006✔
321
  }
322
  pOld->ownerId = pNew->ownerId;
52,851✔
323
  mTrace("idx:%s, perform update action, old row:%p new row:%p", pOld->name, pOld, pNew);
52,851✔
324
  return 0;
52,851✔
325
}
326

327
SIdxObj *mndAcquireIdx(SMnode *pMnode, char *idxName) {
×
328
  SSdb    *pSdb = pMnode->pSdb;
×
329
  SIdxObj *pIdx = sdbAcquire(pSdb, SDB_IDX, idxName);
×
330
  if (pIdx == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
×
331
    terrno = TSDB_CODE_MND_TAG_INDEX_NOT_EXIST;
×
332
  }
333
  return pIdx;
×
334
}
335

336
void mndReleaseIdx(SMnode *pMnode, SIdxObj *pIdx) {
31,360✔
337
  SSdb *pSdb = pMnode->pSdb;
31,360✔
338
  sdbRelease(pSdb, pIdx);
31,360✔
339
}
31,360✔
340

341
SDbObj *mndAcquireDbByIdx(SMnode *pMnode, const char *idxName) {
8,128✔
342
  SName name = {0};
8,128✔
343
  if ((terrno = tNameFromString(&name, idxName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) < 0) return NULL;
8,128✔
344

345
  char db[TSDB_TABLE_FNAME_LEN] = {0};
8,128✔
346
  (void)tNameGetFullDbName(&name, db);
8,128✔
347

348
  return mndAcquireDb(pMnode, db);
8,128✔
349
}
350

351
int32_t mndSetCreateIdxPrepareLogs(SMnode *pMnode, STrans *pTrans, SIdxObj *pIdx) {
9,988✔
352
  int32_t  code = 0;
9,988✔
353
  SSdbRaw *pRedoRaw = mndIdxActionEncode(pIdx);
9,988✔
354
  if (pRedoRaw == NULL) {
9,988✔
355
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
356
    if (terrno != 0) code = terrno;
×
357
    return -1;
×
358
  }
359
  TAOS_CHECK_RETURN(mndTransAppendPrepareLog(pTrans, pRedoRaw));
9,988✔
360
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_CREATING));
9,988✔
361

362
  TAOS_RETURN(code);
9,988✔
363
}
364

365
int32_t mndSetCreateIdxCommitLogs(SMnode *pMnode, STrans *pTrans, SIdxObj *pIdx) {
1,769,145✔
366
  int32_t  code = 0;
1,769,145✔
367
  SSdbRaw *pCommitRaw = mndIdxActionEncode(pIdx);
1,769,145✔
368
  if (pCommitRaw == NULL) {
1,769,145✔
369
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
370
    if (terrno != 0) code = terrno;
×
371
    return -1;
×
372
  }
373
  mInfo("trans:%d, add create idx to commit log", pTrans->id);
1,769,145✔
374
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
1,769,145✔
375
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
1,769,145✔
376

377
  TAOS_RETURN(code);
1,769,145✔
378
}
379

380
int32_t mndSetAlterIdxPrepareLogs(SMnode *pMnode, STrans *pTrans, SIdxObj *pIdx) {
15,006✔
381
  int32_t  code = 0;
15,006✔
382
  SSdbRaw *pRedoRaw = mndIdxActionEncode(pIdx);
15,006✔
383
  if (pRedoRaw == NULL) {
15,006✔
384
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
385
    if (terrno != 0) code = terrno;
×
386
    return -1;
×
387
  }
388
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
15,006✔
389
    sdbFreeRaw(pRedoRaw);
×
390
    return -1;
×
391
  }
392
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_READY));
15,006✔
393

394
  TAOS_RETURN(code);
15,006✔
395
}
396

397
int32_t mndSetAlterIdxCommitLogs(SMnode *pMnode, STrans *pTrans, SIdxObj *pIdx) {
15,006✔
398
  int32_t  code = 0;
15,006✔
399
  SSdbRaw *pCommitRaw = mndIdxActionEncode(pIdx);
15,006✔
400
  if (pCommitRaw == NULL) {
15,006✔
401
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
402
    if (terrno != 0) code = terrno;
×
403
    TAOS_RETURN(code);
×
404
  }
405
  if ((code = mndTransAppendCommitlog(pTrans, pCommitRaw)) != 0) {
15,006✔
406
    sdbFreeRaw(pCommitRaw);
×
407
    TAOS_RETURN(code);
×
408
  }
409
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
15,006✔
410

411
  TAOS_RETURN(code);
15,006✔
412
}
413

414
static int32_t mndSetCreateIdxVgroupRedoLogs(SMnode *pMnode, STrans *pTrans, SVgObj *pVgroup) {
×
415
  int32_t  code = 0;
×
416
  SSdbRaw *pVgRaw = mndVgroupActionEncode(pVgroup);
×
417
  if (pVgRaw == NULL) {
×
418
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
419
    if (terrno != 0) code = terrno;
×
420
    TAOS_RETURN(code);
×
421
  }
422
  TAOS_CHECK_RETURN(mndTransAppendRedolog(pTrans, pVgRaw));
×
423
  TAOS_CHECK_RETURN(sdbSetRawStatus(pVgRaw, SDB_STATUS_CREATING));
×
424
  TAOS_RETURN(code);
×
425
}
426

427
static int32_t mndSetCreateIdxVgroupCommitLogs(SMnode *pMnode, STrans *pTrans, SVgObj *pVgroup) {
×
428
  int32_t  code = 0;
×
429
  SSdbRaw *pVgRaw = mndVgroupActionEncode(pVgroup);
×
430
  if (pVgRaw == NULL) {
×
431
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
432
    if (terrno != 0) code = terrno;
×
433
    TAOS_RETURN(code);
×
434
  }
435
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pVgRaw));
×
436
  TAOS_CHECK_RETURN(sdbSetRawStatus(pVgRaw, SDB_STATUS_READY));
×
437
  TAOS_RETURN(code);
×
438
}
439

440
// static int32_t mndSetUpdateIdxStbCommitLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pStb) {
441
//   SStbObj stbObj = {0};
442
//   taosRLockLatch(&pStb->lock);
443
//   memcpy(&stbObj, pStb, sizeof(SStbObj));
444
//   taosRUnLockLatch(&pStb->lock);
445
//   stbObj.numOfColumns = 0;
446
//   stbObj.pColumns = NULL;
447
//   stbObj.numOfTags = 0;
448
//  stbObj.pTags = NULL;
449
//   stbObj.numOfFuncs = 0;
450
//   stbObj.pFuncs = NULL;
451
//   stbObj.updateTime = taosGetTimestampMs();
452
//   stbObj.lock = 0;
453
//   stbObj.tagVer++;
454

455
// SSdbRaw *pCommitRaw = mndStbActionEncode(&stbObj);
456
// if (pCommitRaw == NULL) return -1;
457
// if (mndTransAppendCommitlog(pTrans, pCommitRaw) != 0) return -1;
458
// if (sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY) != 0) return -1;
459
//
460
// return 0;
461
//}
462

463
static void mndDestroyIdxObj(SIdxObj *pIdxObj) {
×
464
  if (pIdxObj) {
465
    // do nothing
466
  }
467
}
×
468

469
static int32_t mndProcessCreateIdxReq(SRpcMsg *pReq) {
16,816✔
470
  SMnode   *pMnode = pReq->info.node;
16,816✔
471
  int32_t   code = -1;
16,816✔
472
  SStbObj  *pStb = NULL;
16,816✔
473
  SIdxObj  *pIdx = NULL;
16,816✔
474
  SUserObj *pOperUser = NULL;
16,816✔
475

476
  SDbObj            *pDb = NULL;
16,816✔
477
  SCreateTagIndexReq createReq = {0};
16,816✔
478

479
  TAOS_CHECK_GOTO(tDeserializeSCreateTagIdxReq(pReq->pCont, pReq->contLen, &createReq), NULL, _OVER);
16,816✔
480

481
  mInfo("idx:%s start to create", createReq.idxName);
16,816✔
482
  // if (mndCheckCreateIdxReq(&createReq) != 0) {
483
  //   goto _OVER;
484
  // }
485

486
  pDb = mndAcquireDbByStb(pMnode, createReq.stbName);
16,816✔
487
  if (pDb == NULL) {
16,816✔
488
    code = TSDB_CODE_MND_DB_NOT_EXIST;
×
489
    if (terrno != 0) code = terrno;
×
490
    goto _OVER;
×
491
  }
492

493
  if (pDb->cfg.isMount) {
16,816✔
494
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
×
495
    goto _OVER;
×
496
  }
497

498
  pStb = mndAcquireStb(pMnode, createReq.stbName);
16,816✔
499
  if (pStb == NULL) {
16,816✔
500
    mError("idx:%s, failed to create since stb:%s not exist", createReq.idxName, createReq.stbName);
×
501
    code = TSDB_CODE_MND_DB_NOT_EXIST;
×
502
    if (terrno != 0) code = terrno;
×
503
    goto _OVER;
×
504
  }
505
  SSIdx idx = {0};
16,816✔
506
  if ((code = mndAcquireGlobalIdx(pMnode, createReq.idxName, SDB_IDX, &idx)) == 0) {
16,816✔
507
    pIdx = idx.pIdx;
16,816✔
508
  } else {
509
    goto _OVER;
×
510
  }
511
  if (pIdx != NULL) {
16,816✔
512
    code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
2,984✔
513
    goto _OVER;
2,984✔
514
  }
515

516
  TAOS_CHECK_GOTO(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser), NULL, _OVER);
13,832✔
517
  // already check select table/create index privileges in parser
518
  TAOS_CHECK_GOTO(mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB, pDb), NULL, _OVER);
13,832✔
519
  // TAOS_CHECK_GOTO(mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_WRITE_DB, pDb), NULL, _OVER);
520

521
  code = mndAddIndex(pMnode, pReq, &createReq, pDb, pStb, pOperUser);
13,832✔
522
  if (terrno == TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST || terrno == TSDB_CODE_MND_TAG_NOT_EXIST) {
13,832✔
523
    return terrno;
3,844✔
524
  } else {
525
    if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
9,988✔
526
  }
527

528
_OVER:
12,972✔
529
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
12,972✔
530
    mError("stb:%s, failed to create since %s", createReq.idxName, tstrerror(code));
2,984✔
531
  }
532

533
  mndReleaseStb(pMnode, pStb);
12,972✔
534
  mndReleaseIdx(pMnode, pIdx);
12,972✔
535
  mndReleaseDb(pMnode, pDb);
12,972✔
536
  mndReleaseUser(pMnode, pOperUser);
12,972✔
537

538
  TAOS_RETURN(code);
12,972✔
539
}
540

541
int32_t mndSetDropIdxPrepareLogs(SMnode *pMnode, STrans *pTrans, SIdxObj *pIdx) {
12,851✔
542
  int32_t  code = 0;
12,851✔
543
  SSdbRaw *pRedoRaw = mndIdxActionEncode(pIdx);
12,851✔
544
  if (pRedoRaw == NULL) {
12,851✔
545
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
546
    if (terrno != 0) code = terrno;
×
547
    TAOS_RETURN(code);
×
548
  }
549
  TAOS_CHECK_RETURN(mndTransAppendPrepareLog(pTrans, pRedoRaw));
12,851✔
550
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_DROPPING));
12,851✔
551

552
  TAOS_RETURN(code);
12,851✔
553
}
554

555
int32_t mndSetDropIdxCommitLogs(SMnode *pMnode, STrans *pTrans, SIdxObj *pIdx) {
1,086,451✔
556
  int32_t  code = 0;
1,086,451✔
557
  SSdbRaw *pCommitRaw = mndIdxActionEncode(pIdx);
1,086,451✔
558
  if (pCommitRaw == NULL) {
1,086,451✔
559
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
560
    if (terrno != 0) code = terrno;
×
561
    TAOS_RETURN(code);
×
562
  }
563
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
1,086,451✔
564
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
1,086,451✔
565

566
  TAOS_RETURN(code);
1,086,451✔
567
}
568

569
static int32_t mndProcessGetTbIdxReq(SRpcMsg *pReq) {
×
570
  //
571
  return 0;
×
572
}
573

574
int32_t mndRetrieveTagIdx(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
3,420✔
575
  SMnode   *pMnode = pReq->info.node;
3,420✔
576
  SSdb     *pSdb = pMnode->pSdb;
3,420✔
577
  int32_t   numOfRows = 0;
3,420✔
578
  SIdxObj  *pIdx = NULL;
3,420✔
579
  SUserObj *pOperUser = NULL;
3,420✔
580
  int32_t   cols = 0;
3,420✔
581
  int32_t   code = 0;
3,420✔
582
  int32_t   lino = 0;
3,420✔
583
  char      objFName[TSDB_OBJ_FNAME_LEN + 1] = {0};
3,420✔
584
  bool      showAll = false;
3,420✔
585

586
  SDbObj *pDb = NULL;
3,420✔
587
  if (strlen(pShow->db) > 0) {
3,420✔
588
    pDb = mndAcquireDb(pMnode, pShow->db);
1,284✔
589
    if (pDb == NULL) return 0;
1,284✔
590
  }
591

592
  TAOS_CHECK_GOTO(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser), &lino, _OVER);
3,420✔
593
  (void)snprintf(objFName, sizeof(objFName), "%d.*", pOperUser->acctId);
3,420✔
594
  int32_t objLevel = privObjGetLevel(PRIV_OBJ_IDX);
3,420✔
595
  showAll =
3,420✔
596
      (0 == mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_IDX, 0, pDb ? pDb->name : objFName,
3,420✔
597
                                     objLevel == 0 ? NULL : "*"));  // 1.*.*
598

599
  SSmaAndTagIter *pIter = pShow->pIter;
3,420✔
600
  while (numOfRows < rows) {
16,680✔
601
    pIter->pIdxIter = sdbFetch(pSdb, SDB_IDX, pIter->pIdxIter, (void **)&pIdx);
16,680✔
602
    if (pIter->pIdxIter == NULL) break;
16,680✔
603

604
    if (NULL != pDb && pIdx->dbUid != pDb->uid) {
13,260✔
605
      sdbRelease(pSdb, pIdx);
1,284✔
606
      continue;
1,284✔
607
    }
608

609
    if (!showAll) {
11,976✔
610
      SName idxName = {0};
×
611
      if ((code = tNameFromString(&idxName, pIdx->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
×
612
        sdbRelease(pSdb, pIdx);
×
613
        sdbCancelFetch(pSdb, pIter->pIdxIter);
×
614
        lino = __LINE__;
×
615
        goto _OVER;
×
616
      }
617
      if (mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_IDX, pIdx->ownerId, pIdx->db,
×
618
                                   objLevel == 0 ? NULL : idxName.tname)) {  // 1.db1.idx1
619
        sdbRelease(pSdb, pIdx);
×
620
        continue;
×
621
      }
622
    }
623

624
    cols = 0;
11,976✔
625

626
    SName idxName = {0};
11,976✔
627
    if ((code = tNameFromString(&idxName, pIdx->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
11,976✔
628
      sdbRelease(pSdb, pIdx);
×
629
      sdbCancelFetch(pSdb, pIter->pIdxIter);
×
630
      goto _OVER;
×
631
    }
632
    char n1[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
11,976✔
633

634
    STR_TO_VARSTR(n1, (char *)tNameGetTableName(&idxName));
11,976✔
635

636
    char n2[TSDB_DB_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
11,976✔
637
    STR_TO_VARSTR(n2, (char *)mndGetDbStr(pIdx->db));
11,976✔
638

639
    SName stbName = {0};
11,976✔
640
    if ((code = tNameFromString(&stbName, pIdx->stb, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
11,976✔
641
      sdbRelease(pSdb, pIdx);
×
642
      sdbCancelFetch(pSdb, pIter->pIdxIter);
×
643
      goto _OVER;
×
644
    }
645
    char n3[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
11,976✔
646
    STR_TO_VARSTR(n3, (char *)tNameGetTableName(&stbName));
11,976✔
647

648
    SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
11,976✔
649
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)n1, false), pIdx, &lino, _OVER);
11,976✔
650

651
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
11,976✔
652
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)n2, false), pIdx, &lino, _OVER);
11,976✔
653

654
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
11,976✔
655
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)n3, false), pIdx, &lino, _OVER);
11,976✔
656

657
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
11,976✔
658

659
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, NULL, true), pIdx, &lino, _OVER);
11,976✔
660

661
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
11,976✔
662
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pIdx->createdTime, false), pIdx, &lino,
11,976✔
663
                        _OVER);
664

665
    char col[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
11,976✔
666
    STR_TO_VARSTR(col, (char *)pIdx->colName);
11,976✔
667

668
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
11,976✔
669
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)col, false), pIdx, &lino, _OVER);
11,976✔
670

671
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
11,976✔
672

673
    char tag[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
11,976✔
674
    STR_TO_VARSTR(tag, (char *)"tag_index");
11,976✔
675
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)tag, false), pIdx, &lino, _OVER);
11,976✔
676

677
    numOfRows++;
11,976✔
678
    sdbRelease(pSdb, pIdx);
11,976✔
679
  }
680

681
_OVER:
3,420✔
682
  if (code != 0) mError("failed to retrieve at line:%d, since %s", lino, tstrerror(code));
3,420✔
683

684
  mndReleaseDb(pMnode, pDb);
3,420✔
685
  mndReleaseUser(pMnode, pOperUser);
3,420✔
686
  pShow->numOfRows += numOfRows;
3,420✔
687
  return numOfRows;
3,420✔
688
}
689

690
// static void mndCancelGetNextIdx(SMnode *pMnode, void *pIter) {
691
//   SSdb *pSdb = pMnode->pSdb;
692
//
693
//  sdbCancelFetch(pSdb, pIter);
694
//}
695
static int32_t mndCheckIndexReq(SCreateTagIndexReq *pReq) {
×
696
  // impl
697
  return TSDB_CODE_SUCCESS;
×
698
}
699

700
static int32_t mndSetUpdateIdxStbCommitLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pOld, SStbObj *pNew, char *tagName,
18,116✔
701
                                            int on) {
702
  int32_t code = 0;
18,116✔
703
  taosRLockLatch(&pOld->lock);
18,116✔
704
  memcpy(pNew, pOld, sizeof(SStbObj));
18,116✔
705
  taosRUnLockLatch(&pOld->lock);
18,116✔
706

707
  pNew->pTags = NULL;
18,116✔
708
  pNew->pColumns = NULL;
18,116✔
709
  pNew->pCmpr = NULL;
18,116✔
710
  pNew->pTags = NULL;
18,116✔
711
  pNew->pExtSchemas = NULL;
18,116✔
712
  pNew->updateTime = taosGetTimestampMs();
18,116✔
713
  pNew->lock = 0;
18,116✔
714

715
  int8_t  hasIdx = 0;
18,116✔
716
  int32_t tag = mndFindSuperTableTagId(pOld, tagName, &hasIdx);
18,116✔
717
  if (tag < 0) {
18,116✔
718
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
×
719
    TAOS_RETURN(code);
×
720
  }
721
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
18,116✔
722
  SSchema *pTag = pNew->pTags + tag;
18,116✔
723

724
  if (on == 1) {
18,116✔
725
    if (hasIdx && tag != 0) {
9,988✔
726
      code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
×
727
      TAOS_RETURN(code);
×
728
    } else {
729
      SSCHMEA_SET_IDX_ON(pTag);
9,988✔
730
    }
731
  } else {
732
    if (hasIdx == 0) {
8,128✔
733
      code = TSDB_CODE_MND_SMA_NOT_EXIST;
×
734
    } else {
735
      SSCHMEA_SET_IDX_OFF(pTag);
8,128✔
736
      pTag->flags = 0;
8,128✔
737
    }
738
  }
739
  pNew->tagVer++;
18,116✔
740

741
  SSdbRaw *pCommitRaw = mndStbActionEncode(pNew);
18,116✔
742
  if (pCommitRaw == NULL) {
18,116✔
743
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
744
    if (terrno != 0) code = terrno;
×
745
    TAOS_RETURN(code);
×
746
  }
747
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
18,116✔
748
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
18,116✔
749

750
  TAOS_RETURN(code);
18,116✔
751
}
752
int32_t mndAddIndexImpl(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, SIdxObj *pIdx) {
9,988✔
753
  // impl later
754
  int32_t code = -1;
9,988✔
755
  SStbObj newStb = {0};
9,988✔
756
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "create-stb-index");
9,988✔
757
  if (pTrans == NULL) goto _OVER;
9,988✔
758

759
  // mInfo("trans:%d, used to add index to stb:%s", pTrans->id, pStb->name);
760
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
9,988✔
761
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
9,988✔
762

763
  mndTransSetSerial(pTrans);
9,988✔
764

765
  TAOS_CHECK_GOTO(mndSetCreateIdxPrepareLogs(pMnode, pTrans, pIdx), NULL, _OVER);
9,988✔
766
  TAOS_CHECK_GOTO(mndSetCreateIdxCommitLogs(pMnode, pTrans, pIdx), NULL, _OVER);
9,988✔
767

768
  TAOS_CHECK_GOTO(mndSetUpdateIdxStbCommitLogs(pMnode, pTrans, pStb, &newStb, pIdx->colName, 1), NULL, _OVER);
9,988✔
769
  TAOS_CHECK_GOTO(mndSetCreateIdxRedoActions(pMnode, pTrans, pDb, &newStb, pIdx), NULL, _OVER);
9,988✔
770

771
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
9,988✔
772

773
  code = 0;
9,988✔
774

775
_OVER:
9,988✔
776
  // mndDestoryIdxObj(pIdx);
777
  if (newStb.pTags != NULL) {
9,988✔
778
    taosMemoryFree(newStb.pTags);
9,988✔
779
    taosMemoryFree(newStb.pColumns);
9,988✔
780
    taosMemoryFree(newStb.pCmpr);
9,988✔
781
    taosMemoryFreeClear(newStb.pExtSchemas);
9,988✔
782
  }
783
  mndTransDrop(pTrans);
9,988✔
784
  TAOS_RETURN(code);
9,988✔
785
}
786
int8_t mndCheckIndexNameByTagName(SMnode *pMnode, SIdxObj *pIdxObj) {
2,564✔
787
  // build index on first tag, and no index name;
788
  int8_t  exist = 0;
2,564✔
789
  SDbObj *pDb = NULL;
2,564✔
790
  if (strlen(pIdxObj->db) > 0) {
2,564✔
791
    pDb = mndAcquireDb(pMnode, pIdxObj->db);
2,564✔
792
    if (pDb == NULL) return 0;
2,564✔
793
  }
794
  SSmaAndTagIter *pIter = NULL;
2,564✔
795
  SIdxObj        *pIdx = NULL;
2,564✔
796
  SSdb           *pSdb = pMnode->pSdb;
2,564✔
797

798
  while (1) {
799
    pIter = sdbFetch(pSdb, SDB_IDX, pIter, (void **)&pIdx);
4,276✔
800
    if (pIter == NULL) break;
4,276✔
801

802
    if (NULL != pDb && pIdx->dbUid != pDb->uid) {
4,276✔
803
      sdbRelease(pSdb, pIdx);
×
804
      continue;
×
805
    }
806
    if (pIdxObj->stbUid != pIdx->stbUid) {
4,276✔
807
      sdbRelease(pSdb, pIdx);
×
808
      continue;
×
809
    }
810
    if (strncmp(pIdxObj->colName, pIdx->colName, TSDB_COL_NAME_LEN) == 0) {
4,276✔
811
      sdbCancelFetch(pSdb, pIter);
2,564✔
812
      sdbRelease(pSdb, pIdx);
2,564✔
813
      exist = 1;
2,564✔
814
      break;
2,564✔
815
    }
816
    sdbRelease(pSdb, pIdx);
1,712✔
817
  }
818

819
  mndReleaseDb(pMnode, pDb);
2,564✔
820
  return exist;
2,564✔
821
}
822
static int32_t mndAddIndex(SMnode *pMnode, SRpcMsg *pReq, SCreateTagIndexReq *req, SDbObj *pDb, SStbObj *pStb,
13,832✔
823
                           SUserObj *pOperUser) {
824
  int32_t code = -1;
13,832✔
825
  SIdxObj idxObj = {0};
13,832✔
826
  memcpy(idxObj.name, req->idxName, TSDB_INDEX_FNAME_LEN);
13,832✔
827
  memcpy(idxObj.stb, pStb->name, TSDB_TABLE_FNAME_LEN);
13,832✔
828
  memcpy(idxObj.db, pDb->name, TSDB_DB_FNAME_LEN);
13,832✔
829
  memcpy(idxObj.colName, req->colName, TSDB_COL_NAME_LEN);
13,832✔
830
  (void)snprintf(idxObj.createUser, TSDB_USER_LEN, "%s", pOperUser->name);
13,832✔
831
  idxObj.ownerId = pOperUser->uid;
13,832✔
832

833
  idxObj.createdTime = taosGetTimestampMs();
13,832✔
834
  idxObj.uid = mndGenerateUid(req->idxName, strlen(req->idxName));
13,832✔
835
  idxObj.stbUid = pStb->uid;
13,832✔
836
  idxObj.dbUid = pStb->dbUid;
13,832✔
837
  
838

839
  int8_t  hasIdx = 0;
13,832✔
840
  int32_t tag = mndFindSuperTableTagId(pStb, req->colName, &hasIdx);
13,832✔
841
  if (tag < 0) {
13,832✔
842
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
×
843
    TAOS_RETURN(code);
×
844
  }
845
  int8_t exist = 0;
13,832✔
846
  if (tag == 0 && hasIdx == 1) {
13,832✔
847
    exist = mndCheckIndexNameByTagName(pMnode, &idxObj);
2,564✔
848
    if (exist) {
2,564✔
849
      code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
2,564✔
850
      TAOS_RETURN(code);
2,564✔
851
    }
852
  } else if (hasIdx == 1) {
11,268✔
853
    code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
1,280✔
854
    TAOS_RETURN(code);
1,280✔
855
  }
856

857
  code = mndAddIndexImpl(pMnode, pReq, pDb, pStb, &idxObj);
9,988✔
858
  TAOS_RETURN(code);
9,988✔
859
}
860

861
static int32_t mndDropIdx(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SIdxObj *pIdx) {
8,128✔
862
  int32_t  code = -1;
8,128✔
863
  SStbObj *pStb = NULL;
8,128✔
864
  STrans  *pTrans = NULL;
8,128✔
865

866
  SStbObj newObj = {0};
8,128✔
867

868
  pStb = mndAcquireStb(pMnode, pIdx->stb);
8,128✔
869
  if (pStb == NULL) {
8,128✔
870
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
871
    if (terrno != 0) code = terrno;
×
872
    goto _OVER;
×
873
  }
874

875
  pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB, pReq, "drop-index");
8,128✔
876
  if (pTrans == NULL) {
8,128✔
877
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
878
    if (terrno != 0) code = terrno;
×
879
    goto _OVER;
×
880
  }
881

882
  mInfo("trans:%d, used to drop idx:%s", pTrans->id, pIdx->name);
8,128✔
883
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
8,128✔
884
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
8,128✔
885

886
  mndTransSetSerial(pTrans);
8,128✔
887
  TAOS_CHECK_GOTO(mndSetDropIdxPrepareLogs(pMnode, pTrans, pIdx), NULL, _OVER);
8,128✔
888
  TAOS_CHECK_GOTO(mndSetDropIdxCommitLogs(pMnode, pTrans, pIdx), NULL, _OVER);
8,128✔
889

890
  TAOS_CHECK_GOTO(mndSetUpdateIdxStbCommitLogs(pMnode, pTrans, pStb, &newObj, pIdx->colName, 0), NULL, _OVER);
8,128✔
891
  TAOS_CHECK_GOTO(mndSetDropIdxRedoActions(pMnode, pTrans, pDb, &newObj, pIdx), NULL, _OVER);
8,128✔
892
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
8,128✔
893

894
  code = 0;
8,128✔
895

896
_OVER:
8,128✔
897
  taosMemoryFree(newObj.pTags);
8,128✔
898
  taosMemoryFree(newObj.pColumns);
8,128✔
899
  taosMemoryFree(newObj.pCmpr);
8,128✔
900
  taosMemoryFreeClear(newObj.pExtSchemas);
8,128✔
901

902
  mndTransDrop(pTrans);
8,128✔
903
  mndReleaseStb(pMnode, pStb);
8,128✔
904
  TAOS_RETURN(code);
8,128✔
905
}
906
int32_t mndProcessDropTagIdxReq(SRpcMsg *pReq) {
10,260✔
907
  SMnode   *pMnode = pReq->info.node;
10,260✔
908
  int32_t   code = -1;
10,260✔
909
  SDbObj   *pDb = NULL;
10,260✔
910
  SIdxObj  *pIdx = NULL;
10,260✔
911
  SUserObj *pOperUser = NULL;
10,260✔
912

913
  SDropTagIndexReq req = {0};
10,260✔
914
  TAOS_CHECK_GOTO(tDeserializeSDropTagIdxReq(pReq->pCont, pReq->contLen, &req), NULL, _OVER);
10,260✔
915
  mInfo("idx:%s, start to drop", req.name);
10,260✔
916
  SSIdx idx = {0};
10,260✔
917
  if ((code = mndAcquireGlobalIdx(pMnode, req.name, SDB_IDX, &idx)) == 0) {
10,260✔
918
    pIdx = idx.pIdx;
10,260✔
919
  } else {
920
    goto _OVER;
×
921
  }
922
  if (pIdx == NULL) {
10,260✔
923
    if (req.igNotExists) {
2,132✔
924
      mInfo("idx:%s, not exist, ignore not exist is set", req.name);
×
925
      code = 0;
×
926
      goto _OVER;
×
927
    } else {
928
      code = TSDB_CODE_MND_TAG_INDEX_NOT_EXIST;
2,132✔
929
      goto _OVER;
2,132✔
930
    }
931
  }
932

933
  pDb = mndAcquireDbByIdx(pMnode, req.name);
8,128✔
934
  if (pDb == NULL) {
8,128✔
935
    terrno = TSDB_CODE_MND_DB_NOT_SELECTED;
×
936
    if (terrno != 0) code = terrno;
×
937
    goto _OVER;
×
938
  }
939

940
  if(pDb->cfg.isMount) {
8,128✔
941
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
×
942
    goto _OVER;
×
943
  }
944

945
  // TAOS_CHECK_GOTO(mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_WRITE_DB, pDb), NULL, _OVER);
946
  TAOS_CHECK_GOTO(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser), NULL, _OVER);
8,128✔
947
  TAOS_CHECK_GOTO(
8,128✔
948
      mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_DROP, PRIV_OBJ_IDX, pIdx->ownerId, pIdx->db, pIdx->name),
949
      NULL, _OVER);
950

951
  code = mndDropIdx(pMnode, pReq, pDb, pIdx);
8,128✔
952
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
8,128✔
953

954
_OVER:
10,260✔
955
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
10,260✔
956
    mError("idx:%s, failed to drop since %s", req.name, tstrerror(code));
2,132✔
957
  }
958
  mndReleaseIdx(pMnode, pIdx);
10,260✔
959
  mndReleaseDb(pMnode, pDb);
10,260✔
960
  mndReleaseUser(pMnode, pOperUser);
10,260✔
961
  TAOS_RETURN(code);
10,260✔
962
}
963
static int32_t mndProcessGetIdxReq(SRpcMsg *pReq) {
×
964
  // do nothing
965
  return 0;
×
966
}
967

968
int32_t mndDropIdxsByStb(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
479,094✔
969
  int32_t code = 0;
479,094✔
970
  SSdb   *pSdb = pMnode->pSdb;
479,094✔
971
  void   *pIter = NULL;
479,094✔
972

973
  while (1) {
4,064,833✔
974
    SIdxObj *pIdx = NULL;
4,543,927✔
975
    pIter = sdbFetch(pSdb, SDB_IDX, pIter, (void **)&pIdx);
4,543,927✔
976
    if (pIter == NULL) break;
4,543,927✔
977

978
    if (pIdx->stbUid == pStb->uid) {
4,064,833✔
979
      if ((code = mndSetDropIdxCommitLogs(pMnode, pTrans, pIdx)) != 0) {
479,094✔
980
        sdbCancelFetch(pSdb, pIter);
×
981
        sdbRelease(pSdb, pIdx);
×
982
        TAOS_RETURN(code);
×
983
      }
984
    }
985

986
    sdbRelease(pSdb, pIdx);
4,064,833✔
987
  }
988

989
  TAOS_RETURN(code);
479,094✔
990
}
991

992
int32_t mndGetIdxsByTagName(SMnode *pMnode, SStbObj *pStb, char *tagName, SIdxObj *idx) {
103,857✔
993
  SSdb *pSdb = pMnode->pSdb;
103,857✔
994
  void *pIter = NULL;
103,857✔
995

996
  while (1) {
558,889✔
997
    SIdxObj *pIdx = NULL;
662,746✔
998
    pIter = sdbFetch(pSdb, SDB_IDX, pIter, (void **)&pIdx);
662,746✔
999
    if (pIter == NULL) break;
662,746✔
1000

1001
    if (pIdx->stbUid == pStb->uid && taosStrcasecmp(pIdx->colName, tagName) == 0) {
578,618✔
1002
      memcpy((char *)idx, (char *)pIdx, sizeof(SIdxObj));
19,729✔
1003
      sdbRelease(pSdb, pIdx);
19,729✔
1004
      sdbCancelFetch(pSdb, pIter);
19,729✔
1005
      return 0;
19,729✔
1006
    }
1007

1008
    sdbRelease(pSdb, pIdx);
558,889✔
1009
  }
1010

1011
  return -1;
84,128✔
1012
}
1013
int32_t mndDropIdxsByDb(SMnode *pMnode, STrans *pTrans, SDbObj *pDb) {
703,664✔
1014
  int32_t code = 0;
703,664✔
1015
  SSdb   *pSdb = pMnode->pSdb;
703,664✔
1016
  void   *pIter = NULL;
703,664✔
1017

1018
  while (1) {
1,064,415✔
1019
    SIdxObj *pIdx = NULL;
1,768,079✔
1020
    pIter = sdbFetch(pSdb, SDB_IDX, pIter, (void **)&pIdx);
1,768,079✔
1021
    if (pIter == NULL) break;
1,768,079✔
1022

1023
    if (pIdx->dbUid == pDb->uid) {
1,064,415✔
1024
      if ((code = mndSetDropIdxCommitLogs(pMnode, pTrans, pIdx)) != 0) {
594,506✔
1025
        sdbRelease(pSdb, pIdx);
×
1026
        sdbCancelFetch(pSdb, pIter);
×
1027
        TAOS_RETURN(code);
×
1028
      }
1029
    }
1030

1031
    sdbRelease(pSdb, pIdx);
1,064,415✔
1032
  }
1033

1034
  TAOS_RETURN(code);
703,664✔
1035
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc