aelassas / servy / 27368225918

push

github

fix(notifications): Servy-Watermark.psm1 - ConvertFrom-ServyEventMessage emits LogText with a leading blank line when the first line is only '[ServiceName]' (#3170)
ci(scoop): scoop.yml - three "no changes" porcelain guards never fire ($null -ne '' is always true); empty-commit failures silently swallowed (#3146)
ci(choco): choco.yml - "No changes to commit" guard never fires ($null -eq '' is false); empty-commit failure is silently swallowed instead (#3143)
fix(core): ServiceDependenciesValidator.cs - dependency-name regex rejects spaces, blocking dependencies on legal SCM names (e.g. 'Bonjour Service') and on Servy's own space-containing service names (#3240)
ci(bump-versions): bump-version.yml - porcelain no-change guard is a no-op: $null -ne '' is always true, so a no-change run fails on empty commit instead of skipping (#3140)
fix(core): NativeMethods.cs - PROCESSENTRY32 is CharSet.Auto (Unicode) but Process32First/Next bind to the ANSI exports; szExeFile is silently read back as mojibake, breaking kill-by-name and name-based process protection (#3223)
ci(test): test.yml - failure-notify steps can never fire for upload failures: fail_ci_if_error/fail-on-error are false, so the upload actions' outcome is 'success' even when the upload fails (#3152)
fix(core): RotatingStreamWriter.cs - ShouldRotateByDate guards Daily against DST/backward-clock double rotation but leaves Weekly/Monthly unguarded (#3211)
fix(core): NativeMethods.cs - entire Job Object interop region plus CreateFile/GetStdHandle/SetStdHandle/GetTickCount64 declarations and constants have zero callers (#3224)
fix(service): ProcessLauncher.cs - synchronous timeout is double-logged, and the second log ignores LogErrorAsWarning (#3341)
fix(core): Strings.resx - Msg_InvalidServiceDependencyName omits the dollar sign ($) that the dependency-name regex/summary allow (#2600)
fix(core): SafeWinProcessHandle.cs - file named after one class but defines four public SafeHandle types, hiding SafeSc... (continued)

1893 of 2151 branches covered (88.01%)

Branch coverage included in aggregate %.

7 of 9 new or added lines in 4 files covered. (77.78%)

12906 of 15318 relevant lines covered (84.25%)

91.5 hits per line