aelassas / servy / 27089972580

push

github

test: Helper.cs - RunOnSTA has no Func<Task> overload, so async lambdas are never awaited (root cause of the unobserved-assertion test bugs) (#2485)
test(manager): MainViewModelTests.cs - entire test class discards RunOnSTA Tasks; all ~25 tests pass unconditionally (assertions unobserved) (#2401)
test(manager): LogsViewModelTests.cs - SearchCommand test discards the RunOnSTA Task; all assertions run unobserved and can never fail the test (#2399)
test(ui): MessageBoxServiceTests.cs - ShowInfoAsync_InvokesDispatcher passes an async lambda to RunInSTA(Action), creating an async void whose assertion is unobserved (#2512)
test(desktop): ServiceCommandsTests.cs (Servy.UnitTests) - UserCancels tests are 'void' and discard the async Task they invoke (fire-and-forget; assertion can race the continuation) (#2523)
test(cli): ImportServiceCommandTests.cs - GetTempFileName() + ".json" orphans a 0-byte .tmp file each run (#2417)
test(core): ServiceHelperTests.cs - CalculateStartTimeout's preLaunchRetryAttempts scaling (multiplier + backoff loop) is entirely untested (#2451)
test(core): ServiceManagerTests.cs - GetAllServices_ShouldFallbackToAutomatic_WhenStartTypeThrows: name, comment, and assertion disagree (Automatic vs Manual vs Unknown) (#2384)
test(core): LoggetTests.cs - AvoidsSurrogatePairSplitting assertion is vacuous; cannot detect a split surrogate pair (#2545)
test(desktop): ServiceCommandsTests.cs (Servy.UnitTests) - InstallService test writes a 'dummy' file to the real ServyUI service path and never cleans it up (#2522)
test(core): WindowsServiceApiIntegrationTests.cs - GetServices test name claims 'AndDisposesControllers' but disposal is never verified (#2431)

1888 of 2173 branches covered (86.88%)

Branch coverage included in aggregate %.

12574 of 15120 relevant lines covered (83.16%)

83.87 hits per line