aelassas / servy / 27089973813

push

github

test: Helper.cs - RunOnSTA has no Func<Task> overload, so async lambdas are never awaited (root cause of the unobserved-assertion test bugs)
test(manager): MainViewModelTests.cs - entire test class discards RunOnSTA Tasks; all ~25 tests pass unconditionally (assertions unobserved)
test(manager): LogsViewModelTests.cs - SearchCommand test discards the RunOnSTA Task; all assertions run unobserved and can never fail the test
test(ui): MessageBoxServiceTests.cs - ShowInfoAsync_InvokesDispatcher passes an async lambda to RunInSTA(Action), creating an async void whose assertion is unobserved
test(desktop): ServiceCommandsTests.cs (Servy.UnitTests) - UserCancels tests are 'void' and discard the async Task they invoke (fire-and-forget; assertion can race the continuation)
test(cli): ImportServiceCommandTests.cs - GetTempFileName() + ".json" orphans a 0-byte .tmp file each run
test(core): ServiceHelperTests.cs - CalculateStartTimeout's preLaunchRetryAttempts scaling (multiplier + backoff loop) is entirely untested
test(core): ServiceManagerTests.cs - GetAllServices_ShouldFallbackToAutomatic_WhenStartTypeThrows: name, comment, and assertion disagree (Automatic vs Manual vs Unknown)
test(core): LoggetTests.cs - AvoidsSurrogatePairSplitting assertion is vacuous; cannot detect a split surrogate pair
test(desktop): ServiceCommandsTests.cs (Servy.UnitTests) - InstallService test writes a 'dummy' file to the real ServyUI service path and never cleans it up
test(core): WindowsServiceApiIntegrationTests.cs - GetServices test name claims 'AndDisposesControllers' but disposal is never verified

1864 of 2135 branches covered (87.31%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 1 file covered. (100.0%)

12579 of 15126 relevant lines covered (83.16%)

91.56 hits per line