26978265319

Committed 04 Jun 2026 08:40PM UTC coverage: 86.893% (-0.02%) from 86.914%

Build # 26978265319

Build Type

push

github

Committed by

ClemRz

Commit Message

fix(document): map titleAndDescriptionLanguage for description creation

- Read titleAndDescriptionLanguage.id instead of mainLanguage for TDescription.language
- Read documentMainLanguage.id instead of mainLanguage for TDocument.languages
- Add 400 validation when titleAndDescriptionLanguage is missing
- Keep backward-compat fallback to mainLanguage for both fields
- Add service and route tests for new mapping and validation

Closes #1617

Coverage Stats

3546 of 4245 branches covered (83.53%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 3 files covered. (100.0%)

2 existing lines in 2 files now uncovered.

7088 of 7993 relevant lines covered (88.68%)

56.06 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.18

/api/controllers/v1/document/create.js

const ControllerService = require('../../../services/ControllerService');
const DocumentService = require('../../../services/DocumentService');
const { toDocument } = require('../../../services/mapping/converters');
const FileService = require('../../../services/FileService');
const {
  TYPES_ALLOWING_ISSUE,
} = require('../../../../config/constants/document');

module.exports = async (req, res) => {
  // Validate required language fields
  const hasDescriptionLanguage = Boolean(
    req.body.titleAndDescriptionLanguage?.id ?? req.body.mainLanguage
  );
  if (!hasDescriptionLanguage) {
    return res.badRequest(
      'Missing required field: titleAndDescriptionLanguage.'
    );
  }

  const documentData = await DocumentService.getConvertedDataFromClient(
    req.body
  );
  const descriptionData = DocumentService.getDescriptionDataFromClient(
    req.body,
    req.token.id
  );

  // Validate that the issue field is only set for types that support it
  if (
    documentData.issue != null &&
    !TYPES_ALLOWING_ISSUE.includes(documentData.type)
  ) {
    return res.badRequest(
      'The "issue" field is only allowed for documents of type Book or Issue. ' +
        'Articles should be linked to a parent document of type Issue instead.'
    );
  }

  const cleanedData = {
    ...documentData,
    author: req.token.id,
    dateInscription: new Date(),
  };

  const createdDocument = await DocumentService.createDocument(
    req,
    cleanedData,
    descriptionData
  );
  const errorFiles = [];
  if (req.files && req.files.files) {
    const { files } = req.files;
    try {
      await Promise.all(
        files.map(async (file) => {
          await FileService.document.create(file, createdDocument.id);
        })
      );
    } catch (err) {
      errorFiles.push({
        fileName: err.fileName,
        error: err.message,
      });
    }
  }

  const newDoc = await DocumentService.getPopulatedDocument(createdDocument.id);

  const out = {
    document: toDocument(newDoc),
    status:
      errorFiles.length > 0
        ? {
            errorCode: 'FileNotImported',
            errorString: 'Some files were not imported.',
            content: errorFiles,
          }
        : undefined,
  };

  return ControllerService.treat(
    req,
    null,
    out,
    { controllerMethod: 'DocumentController.create' },
    res
  );
};

1	const ControllerService = require('../../../services/ControllerService');	1✔
2	const DocumentService = require('../../../services/DocumentService');	1✔
3	const { toDocument } = require('../../../services/mapping/converters');	1✔
4	const FileService = require('../../../services/FileService');	1✔
5	const {
6	TYPES_ALLOWING_ISSUE,
7	} = require('../../../../config/constants/document');	1✔
8
9	module.exports = async (req, res) => {	1✔
10	// Validate required language fields
11	const hasDescriptionLanguage = Boolean(	7✔
12	req.body.titleAndDescriptionLanguage?.id ?? req.body.mainLanguage	10✔
13	);
14	if (!hasDescriptionLanguage) {	7✔
15	return res.badRequest(	2✔
16	'Missing required field: titleAndDescriptionLanguage.'
17	);
18	}
19
20	const documentData = await DocumentService.getConvertedDataFromClient(	5✔
21	req.body
22	);
23	const descriptionData = DocumentService.getDescriptionDataFromClient(	5✔
24	req.body,
25	req.token.id
26	);
27
28	// Validate that the issue field is only set for types that support it
29	if (	5!
30	documentData.issue != null &&	5!
31	!TYPES_ALLOWING_ISSUE.includes(documentData.type)
32	) {
UNCOV 33	return res.badRequest(	×
34	'The "issue" field is only allowed for documents of type Book or Issue. ' +
35	'Articles should be linked to a parent document of type Issue instead.'
36	);
37	}
38
39	const cleanedData = {	5✔
40	...documentData,
41	author: req.token.id,
42	dateInscription: new Date(),
43	};
44
45	const createdDocument = await DocumentService.createDocument(	5✔
46	req,
47	cleanedData,
48	descriptionData
49	);
50	const errorFiles = [];	5✔
51	if (req.files && req.files.files) {	5✔
52	const { files } = req.files;	1✔
53	try {	1✔
54	await Promise.all(	1✔
55	files.map(async (file) => {
56	await FileService.document.create(file, createdDocument.id);	1✔
57	})
58	);
59	} catch (err) {
60	errorFiles.push({	×
61	fileName: err.fileName,
62	error: err.message,
63	});
64	}
65	}
66
67	const newDoc = await DocumentService.getPopulatedDocument(createdDocument.id);	5✔
68
69	const out = {	5✔
70	document: toDocument(newDoc),
71	status:
72	errorFiles.length > 0	5!
73	? {
74	errorCode: 'FileNotImported',
75	errorString: 'Some files were not imported.',
76	content: errorFiles,
77	}
78	: undefined,
79	};
80
81	return ControllerService.treat(	5✔
82	req,
83	null,
84	out,
85	{ controllerMethod: 'DocumentController.create' },
86	res
87	);
88	};

GrottoCenter / grottocenter-api / 26978265319

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous