NVIDIA / nodewright / 26923701324

push

github

fix(operator): requeue when an owned ConfigMap sync is deferred (#266)

HandleConfigUpdates only writes the owned ConfigMap inside the
completedNodes == nodeCount gate. When the gate is closed on the reconcile
that observes the diff (e.g. a stale Status.ConfigUpdates entry matching a
new configInterrupt glob drives a spurious interrupt cycle), the write is
deferred and the only fallback is the 10m MaxInterval requeue. The CM can
stay diverged from spec for minutes while status reads complete, and the
config-skyhook glob-update chainsaw step flakes when the one race-prone
post-interrupt window is missed.

Surface a pendingSync signal from HandleConfigUpdates/UpsertConfigmaps and
shorten the otherwise idle requeue from MaxInterval to a 30s
configSyncRetryInterval so the deferred write retries promptly. pendingSync
deliberately does not short-circuit the reconcile: progression toward the
gate opening happens in processSkyhooksPerNode, so an early return would
deadlock. The interrupt semantics and Status.ConfigUpdates handling are
unchanged.

Closes #245

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

30 of 44 new or added lines in 1 file covered. (68.18%)

7729 of 9463 relevant lines covered (81.68%)

19.22 hits per line