aelassas / servy / 26903051046

push

github

fix(manager): CpuUsageConverter and RamUsageConverter - near-identical scaffolding can be extracted into a shared base or generic
fix(core): Domain/Service.cs - IsInstalled() and GetServiceStartupType() do not accept CancellationToken, breaking propagation from callers
fix(core): EventLogLogger.ScopedEventLogLogger.CreateScoped - nested-prefix bracket-balancing trick ("{Prefix}] [{prefix}") silently breaks when a prefix contains '[' or ']'
fix(core): EnvironmentVariablesValidator.Validate - short-circuits on first error, asymmetric with sibling ServiceDependenciesValidator which collects all errors
fix(core): ConfigParser.ParseBool - only accepts 'True'/'False', rejects common config-file boolean variants ('1', '0', 'yes', 'no', 'on', 'off')
fix(core): EventLogService.SearchAsync - comment claims 'records is a fully-materialized DTO sequence' but ReadEvents is a lazy yield-based iterator
fix(core): EventLogService.SearchAsync - IndexOf bracket check uses StringComparison.OrdinalIgnoreCase which is meaningless for '[' and ']'
fix(core): EnvironmentVariableParser.Parse - value trim-then-unescape is asymmetric with key unescape-then-trim, drops escaped trailing whitespace in values
fix(core): StringHelper.Escape / EscapedTokenizer.Unescape - round-trip is broken for \r and \n in env-var values
fix(core): StringHelper.FormatServiceDependencies - XML doc and nullable return type both promise null, but method never returns null

1632 of 2219 branches covered (73.55%)

Branch coverage included in aggregate %.

38 of 73 new or added lines in 9 files covered. (52.05%)

11341 of 16581 relevant lines covered (68.4%)

108.98 hits per line