aelassas / servy / 26842501163

push

github

fix(manager): LogTailer.RunFromPosition - per-line byte-offset estimation (incl. unused 'charCount' and per-line GetByteCount) is dead; lastPosition is always overwritten by fs.Position at EOF
fix(core): ConfigParser.ParseEnum(string) - Flags parity check rejects valid canonical comma-separated combinations (asymmetric with int overload)
fix(core): ProcessKiller.cs - reserved system-PID threshold '4' hardcoded inline at four guard sites instead of a named constant
fix(core): ServiceManager.GetServiceStartupType - inlines delayed-auto-start query that IsDelayedStart already encapsulates (DRY)
fix(service): Service.cs ExecuteRecoveryAction - attempt counter logged as '(0/unlimited)' on every recovery in unlimited mode
fix(core,service): EnableDebugLogs XML doc (Domain/Service.cs, StartOptions.cs) wrongly claims env vars/params go to the Windows Event Log - they go to the local log file only
fix(core): SecurityHelper.ApplySecurityRules - XML doc claims current user is skipped when in 'System or Admin groups' but code only excludes LocalSystem
fix(core): ProtectedKeyProvider.GetCachedOrGenerate - XML doc promises 'a clone' but the generate path returns the original array (only the fast path clones)
fix(core): RotatingStreamWriter.WriteInternal - lock-timeout log says 'drop current line' but the line is actually written
fix(manager): LogsViewModel.cs - ToDate setter raises redundant/spurious OnPropertyChanged(nameof(FromDateMaxDate))

1631 of 2216 branches covered (73.6%)

Branch coverage included in aggregate %.

11 of 14 new or added lines in 6 files covered. (78.57%)

11318 of 16541 relevant lines covered (68.42%)

75.93 hits per line