• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

opendefensecloud / artifact-conduit / 26758141958

01 Jun 2026 01:32PM UTC coverage: 83.944% (-0.6%) from 84.591%
26758141958

push

github

web-flow
chore(deps): update amazon/aws-cli docker tag to v2.34.56 (#388)

This PR contains the following updates:

| Package | Update | Change | Pending |
|---|---|---|---|
| amazon/aws-cli | patch | `2.34.53` → `2.34.56` | `2.34.57` |
|
[opendefensecloud/dev-kit](https://redirect.github.com/opendefensecloud/dev-kit)
| patch | `v1.0.7` → `v1.0.8` | |

---

### Release Notes

<details>
<summary>opendefensecloud/dev-kit (opendefensecloud/dev-kit)</summary>

###
[`v1.0.8`](https://redirect.github.com/opendefensecloud/dev-kit/releases/tag/v1.0.8)

[Compare
Source](https://redirect.github.com/opendefensecloud/dev-kit/compare/v1.0.7...v1.0.8)

#### Changes

- feat: updated common.mk to include setup and self-update
[@&#8203;rebEllieous](https://redirect.github.com/rebEllieous)
([#&#8203;15](https://redirect.github.com/opendefensecloud/dev-kit/issues/15))
- chore: inherit renovate config from shared renovate config repo
[@&#8203;yocaba](https://redirect.github.com/yocaba)
([#&#8203;16](https://redirect.github.com/opendefensecloud/dev-kit/issues/16))
- feat: pin GitHub Actions to SHA digests and add pin-check workflow
[@&#8203;rebEllieous](https://redirect.github.com/rebEllieous)
([#&#8203;14](https://redirect.github.com/opendefensecloud/dev-kit/issues/14))
- feat: add conventional commits and documentation to onboard new repos…
[@&#8203;trevex](https://redirect.github.com/trevex)
([#&#8203;12](https://redirect.github.com/opendefensecloud/dev-kit/issues/12))

#### What's Changed

- feat: add conventional commits and documentation to onboard new repos…
by [@&#8203;trevex](https://redirect.github.com/trevex) in
[#&#8203;12](https://redirect.github.com/opendefensecloud/dev-kit/pull/12)
- feat: pin GitHub Actions to SHA digests and add pin-check workflow by
[@&#8203;rebEllieous](https://redirect.github.com/rebEllieous) in
[#&#8203;14](https://redirect.github.com/opendefensecloud/dev-kit/pull/14)
- chore: inherit renovate config from shared renovate config repo by
[@&#820... (continued)

779 of 928 relevant lines covered (83.94%)

1118.37 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.18
/pkg/controller/workflow_handler.go
1
// Copyright 2025 BWI GmbH and Artifact Conduit contributors
2
// SPDX-License-Identifier: Apache-2.0
3

4
package controller
5

6
import (
7
        "context"
8
        "fmt"
9

10
        wfv1alpha1 "github.com/argoproj/argo-workflows/v4/pkg/apis/workflow/v1alpha1"
11
        "github.com/go-logr/logr"
12
        corev1 "k8s.io/api/core/v1"
13
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
14
        "sigs.k8s.io/controller-runtime/pkg/client"
15
        "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
16

17
        arcv1alpha1 "go.opendefense.cloud/arc/api/arc/v1alpha1"
18
)
19

20
type WorkflowHandler interface {
21
        DeleteArgoResources(ctx context.Context) error
22
        CreateArgoResources(ctx context.Context) error
23
        CheckArgoResources(ctx context.Context) error
24
}
25

26
var _ WorkflowHandler = &SingleWorkflowHandler{}
27

28
type SingleWorkflowHandler struct {
29
        *ArtifactWorkflowReconciler
30
        log logr.Logger
31
        aw  *arcv1alpha1.ArtifactWorkflow
32
}
33

34
func NewSingleWorkflowHandler(r *ArtifactWorkflowReconciler, log logr.Logger, aw *arcv1alpha1.ArtifactWorkflow) *SingleWorkflowHandler {
2,881✔
35
        return &SingleWorkflowHandler{r, log, aw}
2,881✔
36
}
2,881✔
37

38
func (h *SingleWorkflowHandler) DeleteArgoResources(ctx context.Context) error {
8✔
39
        wf := wfv1alpha1.Workflow{
8✔
40
                ObjectMeta: metav1.ObjectMeta{
8✔
41
                        Namespace: h.aw.Namespace,
8✔
42
                        Name:      h.aw.Name,
8✔
43
                },
8✔
44
        }
8✔
45
        if err := h.Delete(ctx, &wf); client.IgnoreNotFound(err) != nil {
8✔
46
                h.Recorder.Eventf(h.aw, nil, corev1.EventTypeWarning, "DeletionFailed", "Delete", fmt.Sprintf("Failed to delete associated workflow '%s': %v", h.aw.Name, err))
×
47
                return errLogAndWrap(h.log, err, "workflow deletion failed")
×
48
        }
×
49
        h.Recorder.Eventf(h.aw, nil, corev1.EventTypeNormal, "Deleted", "Delete", fmt.Sprintf("Deleted workflow '%s'", h.aw.Name))
8✔
50

8✔
51
        return nil
8✔
52
}
53

54
func (h *SingleWorkflowHandler) CreateArgoResources(ctx context.Context) error {
1,530✔
55
        srcSecret, dstSecret, err := h.retrieveSecrets(ctx, h.aw)
1,530✔
56
        if err != nil {
1,530✔
57
                return errLogAndWrap(h.log, err, "failed to fetch secrets for artifact workflow")
×
58
        }
×
59

60
        wf := hydrateArgoWorkflow(h.aw, srcSecret, dstSecret)
1,530✔
61

1,530✔
62
        if err := controllerutil.SetControllerReference(h.aw, wf, h.Scheme); err != nil {
1,530✔
63
                return errLogAndWrap(h.log, err, "failed to set controller reference")
×
64
        }
×
65

66
        if err := h.Create(ctx, wf); client.IgnoreAlreadyExists(err) != nil {
1,753✔
67
                h.Recorder.Eventf(h.aw, nil, corev1.EventTypeWarning, "CreationFailed", "Create", fmt.Sprintf("Failed to create workflow '%s': %v", wf.GetName(), err))
223✔
68
                return errLogAndWrap(h.log, err, "failed to create argo workflow")
223✔
69
        }
223✔
70
        h.Recorder.Eventf(h.aw, nil, corev1.EventTypeNormal, "Created", "Create", fmt.Sprintf("Created workflow '%s'", wf.GetName()))
1,307✔
71

1,307✔
72
        h.aw.Status.Phase = arcv1alpha1.WorkflowPending
1,307✔
73
        if err := h.Status().Update(ctx, h.aw); err != nil {
1,310✔
74
                return errLogAndWrap(h.log, err, "failed to update status")
3✔
75
        }
3✔
76

77
        return nil
1,304✔
78
}
79

80
func (h *SingleWorkflowHandler) CheckArgoResources(ctx context.Context) error {
1,308✔
81
        wf := wfv1alpha1.Workflow{}
1,308✔
82
        if err := h.Get(ctx, namespacedName(h.aw.Namespace, h.aw.Name), &wf); err != nil {
1,308✔
83
                return errLogAndWrap(h.log, err, "failed to get workflow")
×
84
        }
×
85

86
        if updated := h.setStatusFromWorkflow(ctx, h.log, h.aw, &wf); !updated {
1,312✔
87
                return nil // nothing updated
4✔
88
        }
4✔
89

90
        if err := h.Status().Update(ctx, h.aw); err != nil {
1,304✔
91
                return errLogAndWrap(h.log, err, "failed to update status")
×
92
        }
×
93

94
        return nil
1,304✔
95
}
96

97
var _ WorkflowHandler = &CronWorkflowHandler{}
98

99
type CronWorkflowHandler struct {
100
        *ArtifactWorkflowReconciler
101
        log logr.Logger
102
        aw  *arcv1alpha1.ArtifactWorkflow
103
}
104

105
func NewCronWorkflowHandler(r *ArtifactWorkflowReconciler, log logr.Logger, aw *arcv1alpha1.ArtifactWorkflow) *CronWorkflowHandler {
33✔
106
        return &CronWorkflowHandler{r, log, aw}
33✔
107
}
33✔
108

109
func (h *CronWorkflowHandler) DeleteArgoResources(ctx context.Context) error {
×
110
        cwf := wfv1alpha1.CronWorkflow{
×
111
                ObjectMeta: metav1.ObjectMeta{
×
112
                        Namespace: h.aw.Namespace,
×
113
                        Name:      h.aw.Name,
×
114
                },
×
115
        }
×
116
        if err := h.Delete(ctx, &cwf); client.IgnoreNotFound(err) != nil {
×
117
                h.Recorder.Eventf(h.aw, nil, corev1.EventTypeWarning, "DeletionFailed", "Delete", fmt.Sprintf("Failed to delete associated cron workflow '%s': %v", h.aw.Name, err))
×
118
                return errLogAndWrap(h.log, err, "cron workflow deletion failed")
×
119
        }
×
120
        h.Recorder.Eventf(h.aw, nil, corev1.EventTypeNormal, "Deleted", "Delete", fmt.Sprintf("Deleted cron workflow '%s'", h.aw.Name))
×
121

×
122
        return nil
×
123
}
124

125
func (h *CronWorkflowHandler) CreateArgoResources(ctx context.Context) error {
13✔
126
        srcSecret, dstSecret, err := h.retrieveSecrets(ctx, h.aw)
13✔
127
        if err != nil {
13✔
128
                return errLogAndWrap(h.log, err, "failed to fetch secrets for artifact workflow")
×
129
        }
×
130

131
        cwf := hydrateArgoCronWorkflow(h.aw, srcSecret, dstSecret)
13✔
132

13✔
133
        if err := controllerutil.SetControllerReference(h.aw, cwf, h.Scheme); err != nil {
13✔
134
                return errLogAndWrap(h.log, err, "failed to set controller reference")
×
135
        }
×
136

137
        if err := h.Create(ctx, cwf); err != nil {
25✔
138
                if client.IgnoreAlreadyExists(err) != nil {
24✔
139
                        h.Recorder.Eventf(h.aw, nil, corev1.EventTypeWarning, "CreationFailed", "Create", fmt.Sprintf("Failed to create cron workflow '%s': %v", cwf.GetName(), err))
12✔
140
                        return errLogAndWrap(h.log, err, "failed to create argo cron workflow")
12✔
141
                }
12✔
142
        } else {
1✔
143
                h.Recorder.Eventf(h.aw, nil, corev1.EventTypeNormal, "Created", "Create", fmt.Sprintf("Created cron workflow '%s'", cwf.GetName()))
1✔
144
        }
1✔
145

146
        h.aw.Status.Phase = arcv1alpha1.WorkflowPending
1✔
147
        if err := h.Status().Update(ctx, h.aw); err != nil {
1✔
148
                return errLogAndWrap(h.log, err, "failed to update status")
×
149
        }
×
150

151
        return nil
1✔
152
}
153

154
func (h *CronWorkflowHandler) CheckArgoResources(ctx context.Context) error {
18✔
155
        cwf := wfv1alpha1.CronWorkflow{}
18✔
156
        if err := h.Get(ctx, namespacedName(h.aw.Namespace, h.aw.Name), &cwf); err != nil {
18✔
157
                return errLogAndWrap(h.log, err, "failed to get cron workflow")
×
158
        }
×
159

160
        updated := false
18✔
161

18✔
162
        if !h.aw.Status.LastScheduled.Equal(cwf.Status.LastScheduledTime) {
20✔
163
                h.aw.Status.LastScheduled = cwf.Status.LastScheduledTime
2✔
164
                updated = true
2✔
165
        }
2✔
166
        if h.aw.Status.Failed != cwf.Status.Failed {
19✔
167
                h.aw.Status.Failed = cwf.Status.Failed
1✔
168
                updated = true
1✔
169
        }
1✔
170
        if h.aw.Status.Succeeded != cwf.Status.Succeeded {
19✔
171
                h.aw.Status.Succeeded = cwf.Status.Succeeded
1✔
172
                updated = true
1✔
173
        }
1✔
174

175
        // If the active workflow is not the same as the current one, update the reference
176
        if len(cwf.Status.Active) > 0 {
34✔
177
                // Should only contain a single element at most (expected to be in the same namespace!)
16✔
178
                ref := cwf.Status.Active[len(cwf.Status.Active)-1]
16✔
179

16✔
180
                if h.aw.Status.ActiveWorkflowRef.Name != ref.Name {
26✔
181
                        h.log.V(1).Info("Updating reference for cron workflow", "cronWorkflow", cwf.Name, "activeWorkflow", ref.Name)
10✔
182

10✔
183
                        // Get the active workflow
10✔
184
                        wf := wfv1alpha1.Workflow{}
10✔
185
                        if err := h.Get(ctx, namespacedName(h.aw.Namespace, ref.Name), &wf); err != nil {
11✔
186
                                return errLogAndWrap(h.log, err, "failed to fetch active workflow")
1✔
187
                        }
1✔
188

189
                        h.aw.Status.ActiveWorkflowRef = corev1.LocalObjectReference{
9✔
190
                                Name: wf.Name,
9✔
191
                        }
9✔
192
                        h.aw.Status.Message = ""
9✔
193
                        h.aw.Status.Phase = arcv1alpha1.WorkflowActive
9✔
194

9✔
195
                        updated = updated || h.setStatusFromWorkflow(ctx, h.log, h.aw, &wf)
9✔
196
                }
197
        }
198

199
        // If there is an active workflow, check its status
200
        if h.aw.Status.ActiveWorkflowRef.Name != "" {
32✔
201
                wf := wfv1alpha1.Workflow{}
15✔
202
                if err := h.Get(ctx, namespacedName(h.aw.Namespace, h.aw.Status.ActiveWorkflowRef.Name), &wf); err != nil {
15✔
203
                        return errLogAndWrap(h.log, err, "failed to fetch active workflow")
×
204
                }
×
205

206
                updated = updated || h.setStatusFromWorkflow(ctx, h.log, h.aw, &wf)
15✔
207

15✔
208
                if wf.Status.Phase.Completed() {
24✔
209
                        h.aw.Status.ActiveWorkflowRef.Name = ""
9✔
210
                        updated = true
9✔
211
                }
9✔
212
        }
213

214
        if !updated {
21✔
215
                return nil
4✔
216
        }
4✔
217

218
        h.log.V(1).Info("Updating status from active workflow", "cronWorkflow", cwf.Name)
13✔
219

13✔
220
        if err := h.Status().Update(ctx, h.aw); err != nil {
13✔
221
                return errLogAndWrap(h.log, err, "failed to update status")
×
222
        }
×
223

224
        return nil
13✔
225
}
226

227
func hydrateArgoWorkflowSpec(aw *arcv1alpha1.ArtifactWorkflow, srcSecret *corev1.Secret, dstSecret *corev1.Secret) wfv1alpha1.WorkflowSpec {
1,543✔
228
        srcVolume := corev1.Volume{
1,543✔
229
                Name: "src-secret-vol",
1,543✔
230
                VolumeSource: corev1.VolumeSource{
1,543✔
231
                        EmptyDir: &corev1.EmptyDirVolumeSource{},
1,543✔
232
                },
1,543✔
233
        }
1,543✔
234
        if srcSecret.Name != "" {
2,526✔
235
                srcVolume.VolumeSource = corev1.VolumeSource{
983✔
236
                        Secret: &corev1.SecretVolumeSource{
983✔
237
                                SecretName: srcSecret.Name,
983✔
238
                        },
983✔
239
                }
983✔
240
        }
983✔
241

242
        dstVolume := corev1.Volume{
1,543✔
243
                Name: "dst-secret-vol",
1,543✔
244
                VolumeSource: corev1.VolumeSource{
1,543✔
245
                        EmptyDir: &corev1.EmptyDirVolumeSource{},
1,543✔
246
                },
1,543✔
247
        }
1,543✔
248
        if dstSecret.Name != "" {
2,526✔
249
                dstVolume.VolumeSource = corev1.VolumeSource{
983✔
250
                        Secret: &corev1.SecretVolumeSource{
983✔
251
                                SecretName: dstSecret.Name,
983✔
252
                        },
983✔
253
                }
983✔
254
        }
983✔
255

256
        parameters := []wfv1alpha1.Parameter{}
1,543✔
257
        for _, p := range aw.Spec.Parameters {
9,916✔
258
                parameters = append(parameters, wfv1alpha1.Parameter{
8,373✔
259
                        Name:  p.Name,
8,373✔
260
                        Value: (*wfv1alpha1.AnyString)(&p.Value),
8,373✔
261
                })
8,373✔
262
        }
8,373✔
263

264
        return wfv1alpha1.WorkflowSpec{
1,543✔
265
                WorkflowTemplateRef: &wfv1alpha1.WorkflowTemplateRef{
1,543✔
266
                        Name:         aw.Spec.WorkflowTemplateRef.Name,
1,543✔
267
                        ClusterScope: aw.Spec.WorkflowTemplateRef.ClusterScope,
1,543✔
268
                },
1,543✔
269
                Volumes: []corev1.Volume{
1,543✔
270
                        srcVolume,
1,543✔
271
                        dstVolume,
1,543✔
272
                },
1,543✔
273
                Arguments: wfv1alpha1.Arguments{
1,543✔
274
                        Parameters: parameters,
1,543✔
275
                },
1,543✔
276
        }
1,543✔
277
}
278

279
func hydrateArgoWorkflow(aw *arcv1alpha1.ArtifactWorkflow, srcSecret *corev1.Secret, dstSecret *corev1.Secret) *wfv1alpha1.Workflow {
1,530✔
280
        return &wfv1alpha1.Workflow{
1,530✔
281
                ObjectMeta: workflowObjectMeta(aw),
1,530✔
282
                Spec:       hydrateArgoWorkflowSpec(aw, srcSecret, dstSecret),
1,530✔
283
        }
1,530✔
284
}
1,530✔
285

286
func hydrateArgoCronWorkflow(aw *arcv1alpha1.ArtifactWorkflow, srcSecret *corev1.Secret, dstSecret *corev1.Secret) *wfv1alpha1.CronWorkflow {
13✔
287
        om := workflowObjectMeta(aw)
13✔
288
        wf := &wfv1alpha1.CronWorkflow{
13✔
289
                ObjectMeta: om,
13✔
290
                Spec: wfv1alpha1.CronWorkflowSpec{
13✔
291
                        WorkflowSpec:               hydrateArgoWorkflowSpec(aw, srcSecret, dstSecret),
13✔
292
                        Schedules:                  aw.Spec.Cron.Schedules,
13✔
293
                        ConcurrencyPolicy:          wfv1alpha1.ReplaceConcurrent,
13✔
294
                        StartingDeadlineSeconds:    aw.Spec.Cron.StartingDeadlineSeconds,
13✔
295
                        Timezone:                   aw.Spec.Cron.Timezone,
13✔
296
                        When:                       aw.Spec.Cron.When,
13✔
297
                        SuccessfulJobsHistoryLimit: new(int32(1)),
13✔
298
                        FailedJobsHistoryLimit:     new(int32(1)),
13✔
299
                        WorkflowMetadata:           &om,
13✔
300
                },
13✔
301
        }
13✔
302

13✔
303
        return wf
13✔
304
}
13✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc