aelassas / servy / 26716191054

push

github

fix(manager): MonitoringViewModelBase / PerformanceViewModel / ConsoleViewModel - same Interlocked CTS-swap race as #2042 in shared base + two un-listed ViewModels (#2114)
fix(manager): ServiceSearchViewModelBase - same Interlocked CTS-swap race as #2042/#2114; concurrent SearchCommand vs. Dispose leaks the new CTS (#2127)
fix(manager): LogsViewModel.Search - oldCts.Cancel() / Dispose() lack try/catch and finally; inconsistent with Cleanup() and leaks the CTS if Cancel throws (#2103)
fix(notifications): ServyFailureEmail.ps1 - 'To' validation regex rejects multi-recipient configurations even though MailMessage.To.Add supports them (#2107)
fix(notifications): Write-ServyLog.ps1 - rotation TOCTOU and unlocked AppendAllText race when multiple processes share a log file (#2088)
fix(core): Helper.WriteFileAtomic / WriteFileAtomicCore - Flush() does not force a physical disk write, comment overstates the durability guarantee (#2066)
fix(service): Service.cs InitiateRecoveryAsync - gate stays closed forever if RestartService/RestartComputer throws, silently dropping all subsequent recovery (#2062)
fix(manager): ServiceCommands.GetServiceDomain - drops CancellationToken on the repository fetch, blocking cancel during DB I/O (#2028)
fix(core): RotatingStreamWriter.cs - Monitor.Wait inside WriteInternal has no timeout; a stuck rotation hangs all writers indefinitely (#1988)
fix(core): ServiceManager.cs - GetServiceDescription and GetServiceUser silently return null on Win32 errors other than ERROR_INSUFFICIENT_BUFFER (#1985)
fix(cli): UninstallServiceCommand.cs - repository DeleteAsync drops CancellationToken after SCM uninstall succeeds (#2077)
fix(core): IServiceManager - IsServiceInstalled and GetDependencies lack CancellationToken, asymmetric with sibling interface methods (#2176)
fix(core): ServiceManager.GetAllServices - LogOnAs defaults to LocalSystem before PopulateNativeDetails runs, so timed-out / faulted queries silently report the wrong account (#2072)

1617 of 2230 branches covered (72.51%)

Branch coverage included in aggregate %.

50 of 99 new or added lines in 17 files covered. (50.51%)

10980 of 15845 relevant lines covered (69.3%)

826.1 hits per line