aelassas / servy / 26686146987

push

github

fix(service): Service.cs ScheduleRecoveryAsync - SAFETY RESET writes _isRecovering outside _healthCheckSemaphore, racing with health-check evaluations (#2067)
fix(manager): ServiceCommands.Dispose - disposes SemaphoreSlim instances without guarding against concurrent in-flight operations (#2018)
fix(manager): ConsoleViewModel.cs - RequestScroll and RequestStatePreservation event delegates never unsubscribed on Dispose, retaining the View (#1998)
fix(core): ServiceDtoHelper.ApplyDefaultsAndResetIdentity silently discards UserAccount/Password from XML/JSON imports with no operator-visible warning (#2184)
fix(service): Service.cs ExecuteTeardown - finally-block disposal cascade is not exception-safe (sibling of #2109/#2136) (#2151)
fix(core): Helper.IsValidPath - uses Path.GetInvalidPathChars(), accepting filename-invalid chars like '<', '>', '|', '*', '?' that cause downstream open failures (#2106)
fix(infra): ServiceRepository.UpsertBatchAsync - does not preserve runtime state, clobbers Pid/ActiveStdoutPath/ActiveStderrPath/Password on batch import (#2051)
fix(service): ProcessWrapper.cs - Stop(timeoutMs) uses the same value for graceful timeout and post-kill wait (#1971)
fix(service): StartOptionsParser.SafeResolvePath - only catches InvalidOperationException/ArgumentException; SecurityException, NotSupportedException, PathTooLongException from Path.GetFullPath propagate and crash OnStart (#2188)
fix(manager): oldCts.Cancel()/Dispose() lack try/catch in 11 additional ViewModel sites (sibling of #2103) (#2137)
fix(manager): ConsoleViewModel.cs - RequestStatePreservation event raised but never subscribed by any view; the 'preserve UI selection during log updates' contract is silently broken (#2001)
fix(service): Service.cs - Dead null-conditional on readonly semaphore fields (#1963)
fix(desktop,manager): AppBootstrapper.cs - Dead null-conditional on readonly _appLifetimeCts field (#2007)
fix(restarter): Program.cs Main - finally block disposal cascade i... (continued)

1612 of 2226 branches covered (72.42%)

Branch coverage included in aggregate %.

78 of 126 new or added lines in 17 files covered. (61.9%)

10947 of 15797 relevant lines covered (69.3%)

827.5 hits per line