Azure / ARO-RP / 26576808106

push

github

Improve error messages for invalid identities (#4848)

* If we get a 401, 403, or 404 getting a MI, give the error to the user - otherwise return an internal server error

* Fix typo

* Appease CI

* PR feedback response - handle 429s

* PR feedback response - rename helper function to align with others

* PR feedback response - factor out some duplicated error type checking

* Remove original helper function to check for 4xx errors - it's unused now

24 of 32 new or added lines in 10 files covered. (75.0%)

29561 of 76834 relevant lines covered (38.47%)

0.44 hits per line