26558912126

Committed 28 May 2026 06:34AM UTC coverage: 95.936% (-0.01%) from 95.948%

Build Type

push

github

Committed by ahobeost

Commit Message

Refactoring to pass CI.

Coverage Stats

11 of 11 new or added lines in 2 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

1322 of 1378 relevant lines covered (95.94%)

1.92 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

99.37

/pytrnsys_process/plot/plotters.py

import typing as _tp
import warnings
from abc import abstractmethod
from dataclasses import dataclass

import numpy as _np
import pandas as _pd
import matplotlib.pyplot as _plt
from matplotlib import dates as _dates, ticker as _tick

from pytrnsys_process import config as conf

# TODO: provide A4 and half A4 plots to test sizes in latex # pylint: disable=fixme
# TODO: provide height as input for plot?  # pylint: disable=fixme
# TODO: deal with legends (curve names, fonts, colors, linestyles) # pylint: disable=fixme
# TODO: clean up old stuff by refactoring # pylint: disable=fixme
# TODO: make issue for docstrings of plotting # pylint: disable=fixme
# TODO: Add colormap support # pylint: disable=fixme


# TODO find a better place for this to live in # pylint : disable=fixme
plot_settings = conf.global_settings.plot
"Settings shared by all plots"


class ChartBase:
    cmap: str | None = None

    def plot(
        self,
        df: _pd.DataFrame,
        columns: list[str],
        **kwargs,
    ) -> tuple[_plt.Figure, _plt.Axes]:
        fig, ax = self._do_plot(df, columns, **kwargs)
        return fig, ax

    @abstractmethod
    def _do_plot(
        self,
        df: _pd.DataFrame,
        columns: list[str],
        use_legend: bool = True,
        size: tuple[float, float] = conf.PlotSizes.A4.value,
        **kwargs: _tp.Any,
    ) -> tuple[_plt.Figure, _plt.Axes]:
        """Implement actual plotting logic in subclasses"""

    def check_for_cmap(self, kwargs, plot_kwargs):
        if "cmap" not in kwargs and "colormap" not in kwargs:
            plot_kwargs["cmap"] = self.cmap
        return plot_kwargs

    def get_cmap(self, kwargs) -> str | None:
        if not kwargs:
            return self.cmap

        if "cmap" not in kwargs and "colormap" not in kwargs:
            return self.cmap

        if "cmap" in kwargs:
            return kwargs["cmap"]

        if "colormap" in kwargs:
            return kwargs["colormap"]

        raise ValueError  # pragma: no cover

    @staticmethod
    def get_fig_and_ax(kwargs, size):
        if "fig" not in kwargs and "ax" not in kwargs:
            fig, ax = _plt.subplots(
                figsize=size,
                layout="constrained",
            )
            kwargs["ax"] = ax
        else:
            fig = kwargs["fig"]
            ax = kwargs["ax"]
        return fig, ax

    def get_fig_and_multi_ax(self, kwargs, size):
        if (
            "fig" in kwargs
            or "lax" in kwargs
            or "rax" in kwargs
            or "ax" in kwargs
        ):
            warnings.warn(
                "get_fig_and_multi_ax does not pass the figure handle, nor the axis handles."
            )

        fig, lax, leg_ax = self.prep_subplots_for_legend_outside_of_plot(size)
        rax = lax.twinx()

        return fig, lax, rax, leg_ax

    @staticmethod
    def prep_subplots_for_legend_outside_of_plot(
        size,
    ) -> tuple[_plt.Figure, _plt.Axes, _plt.Axes]:
        # See: https://stackoverflow.com/questions/4700614/
        # how-to-put-the-legend-outside-the-plot
        # This is required to place the legend in a dedicated subplot
        fig, (ax, leg_ax) = _plt.subplots(
            layout="constrained",
            figsize=size,
            ncols=2,
            gridspec_kw={"width_ratios": [4, 1]},
        )
        return fig, ax, leg_ax


class StackedBarChart(ChartBase):
    cmap: str | None = "inferno_r"

    def _do_plot(
        self,
        df: _pd.DataFrame,
        columns: list[str],
        use_legend: bool = True,
        size: tuple[float, float] = conf.PlotSizes.A4.value,
        **kwargs: _tp.Any,
    ) -> tuple[_plt.Figure, _plt.Axes]:
        fig, ax = self.get_fig_and_ax(kwargs, size)

        plot_kwargs = {
            "stacked": True,
            "legend": use_legend,
            **kwargs,
        }
        self.check_for_cmap(kwargs, plot_kwargs)
        ax = df[columns].plot.bar(**plot_kwargs)
        ax.set_xticklabels(
            _pd.to_datetime(df.index).strftime(plot_settings.date_format)
        )

        return fig, ax


class EnergyBalanceChart(ChartBase):
    cmap: str | None = "inferno_r"

    def plot(  # type: ignore[override]
        self,
        df: _pd.DataFrame,
        columns: dict[_tp.Any, _tp.Any],  # type: ignore[arg-type]
        **kwargs,
    ) -> tuple[_plt.Figure, _plt.Axes, _plt.Axes]:
        fig, lax, rax = self._do_plot(df, columns, **kwargs)
        return fig, lax, rax

    # pylint: disable=too-many-locals, too-many-statements
    def _do_plot(  # typing: ignore[override]
        self,
        df: _pd.DataFrame,
        columns: dict[_tp.Any, _tp.Any],
        use_legend: bool = True,
        size: tuple[float, float] = conf.PlotSizes.A4.value,
        **kwargs: _tp.Any,
    ) -> tuple[_plt.Figure, _plt.Axes, _plt.Axes]:
        fig, lax, rax, leg_ax = self.get_fig_and_multi_ax(kwargs, size)

        # TODO: implement other kwargs?  # pylint: disable=fixme
        plot_kwargs = {
            **kwargs,
        }

        q_in_columns = columns["q_in_columns"]
        q_out_columns = columns["q_out_columns"]
        q_imb_column = columns["q_imb_column"]
        line_columns = columns["line_columns"]

        pos_bottom = _np.zeros(len(df))
        neg_bottom = _np.zeros(len(df))
        self.check_for_cmap(kwargs, plot_kwargs)
        n_colors = len(q_in_columns) + len(q_out_columns) + 1
        cmap = self.get_cmap(kwargs)
        cm = _plt.get_cmap(cmap, n_colors)

        date_time = _dates.date2num(df.index)

        data_frequency = get_frequency_of_data(df)

        bar_width = None
        if data_frequency == "step":
            bar_width = 0.0008
        elif data_frequency == "hourly":
            bar_width = 0.02
        elif data_frequency == "monthly":
            bar_width = 25

        # build positive stack
        i_color = 0
        for column in q_in_columns:
            values = df[column].clip(lower=0)
            lax.bar(
                date_time,
                values,
                bottom=pos_bottom,
                label=column,
                width=bar_width,
                color=cm(i_color),
            )
            pos_bottom += values
            i_color += 1

        # build negative stack
        for column in q_out_columns:
            values = df[column].clip(upper=0)
            lax.bar(
                date_time,
                values,
                bottom=neg_bottom,
                label=column,
                width=bar_width,
                color=cm(i_color),
            )
            neg_bottom += values
            i_color += 1

        values = df[q_imb_column]
        lax.bar(
            date_time,
            values.clip(lower=0),
            bottom=pos_bottom,
            label=q_imb_column,
            width=bar_width,
            color="black",
        )
        pos_bottom += values.clip(lower=0)  # used for legend location
        i_color += 1
        lax.bar(
            date_time,
            values.clip(upper=0),
            bottom=neg_bottom,
            width=bar_width,
            color="black",
        )
        neg_bottom += values.clip(upper=0)  # used for legend location

        lax.axhline(0, color="black")

        if line_columns is not None:
            for column in line_columns:
                rax.plot(date_time, df[column], label=f"{column}")

        format_date_time_twin_axis(lax, rax, data_frequency)

        if line_columns is None:
            y_min, y_max = lax.get_ylim()
            rax.set_ylim(y_min, y_max)

        self._maybe_add_legend(use_legend, line_columns, lax, rax, leg_ax)

        if "xlabel" in kwargs:
            lax.set_xlabel(kwargs["xlabel"])
        if "energy_balance_ylabel" in kwargs:
            lax.set_ylabel(kwargs["energy_balance_ylabel"])
        if "line_ylabel" in kwargs:
            rax.set_ylabel(kwargs["line_ylabel"])

        return fig, lax, rax

    @staticmethod
    def _maybe_add_legend(
        use_legend: bool,
        line_columns: _tp.Optional[list[str]],
        lax: _plt.Axes,
        rax: _plt.Axes,
        leg_ax: _plt.Axes,
    ):
        if use_legend:
            balance_handles, _ = lax.get_legend_handles_labels()
            line_handles, _ = rax.get_legend_handles_labels()
            if line_columns is not None:
                line_legend = leg_ax.legend(
                    handles=line_handles,
                    loc="upper left",
                    bbox_to_anchor=(0, 0, 1, 1),
                )
                leg_ax.add_artist(line_legend)
            leg_ax.legend(
                handles=balance_handles,
                loc="upper left",
                bbox_to_anchor=(0, 0, 1, 0.7),
            )
            leg_ax.axis("off")


class BarChart(ChartBase):
    cmap = None

    def _do_plot(
        self,
        df: _pd.DataFrame,
        columns: list[str],
        use_legend: bool = True,
        size: tuple[float, float] = conf.PlotSizes.A4.value,
        **kwargs: _tp.Any,
    ) -> tuple[_plt.Figure, _plt.Axes]:
        # TODO: deal with colors  # pylint: disable=fixme
        fig, ax = self.get_fig_and_ax(kwargs, size)

        x = _np.arange(len(df.index))
        width = 0.8 / len(columns)

        cmap = self.get_cmap(kwargs)
        if cmap:
            cm = _plt.get_cmap(cmap)
            colors = cm(_np.linspace(0, 1, len(columns)))
        else:
            colors = [None] * len(columns)

        for i, col in enumerate(columns):
            ax.bar(x + i * width, df[col], width, label=col, color=colors[i])

        if use_legend:
            ax.legend()

        ax.set_xticks(x + width * (len(columns) - 1) / 2)
        ax.set_xticklabels(
            _pd.to_datetime(df.index).strftime(plot_settings.date_format)
        )
        ax.tick_params(axis="x", labelrotation=90)
        return fig, ax


class LinePlot(ChartBase):
    cmap: str | None = None

    def _do_plot(
        self,
        df: _pd.DataFrame,
        columns: list[str],
        use_legend: bool = True,
        size: tuple[float, float] = conf.PlotSizes.A4.value,
        **kwargs: _tp.Any,
    ) -> tuple[_plt.Figure, _plt.Axes]:
        fig, ax = self.get_fig_and_ax(kwargs, size)

        plot_kwargs = {
            "legend": use_legend,
            **kwargs,
        }
        self.check_for_cmap(kwargs, plot_kwargs)

        df[columns].plot.line(**plot_kwargs)
        return fig, ax


@dataclass()
class Histogram(ChartBase):
    bins: int = 50

    def _do_plot(
        self,
        df: _pd.DataFrame,
        columns: list[str],
        use_legend: bool = True,
        size: tuple[float, float] = conf.PlotSizes.A4.value,
        **kwargs: _tp.Any,
    ) -> tuple[_plt.Figure, _plt.Axes]:
        fig, ax = self.get_fig_and_ax(kwargs, size)

        plot_kwargs = {
            "legend": use_legend,
            "bins": self.bins,
            **kwargs,
        }
        self.check_for_cmap(kwargs, plot_kwargs)
        df[columns].plot.hist(**plot_kwargs)
        return fig, ax


def _validate_inputs(
    current_class,
    columns: list[str],
) -> None:
    if len(columns) != 2:
        raise ValueError(
            f"\n{type(current_class).__name__} requires exactly 2 columns (x and y)"
        )


class ScatterPlot(ChartBase):
    cmap = "Paired"  # This is ignored when no categorical groupings are used.

    def _do_plot(
        self,
        df: _pd.DataFrame,
        columns: list[str],
        use_legend: bool = True,
        size: tuple[float, float] = conf.PlotSizes.A4.value,
        **kwargs: _tp.Any,
    ) -> tuple[_plt.Figure, _plt.Axes]:
        _validate_inputs(self, columns)
        x_column, y_column = columns

        fig, ax = self.get_fig_and_ax(kwargs, size)
        df.plot.scatter(x=x_column, y=y_column, **kwargs)

        return fig, ax


class ScalarComparePlot(ChartBase):
    """Handles comparative scatter plots with dual grouping by color and markers."""

    cmap = "Paired"  # This is ignored when no categorical groupings are used.

    # pylint: disable=too-many-arguments,too-many-locals, too-many-positional-arguments
    def _do_plot(  # type: ignore[override]
        self,
        df: _pd.DataFrame,
        columns: list[str],
        use_legend: bool = True,
        size: tuple[float, float] = conf.PlotSizes.A4.value,
        group_by_color: str | None = None,
        group_by_marker: str | None = None,
        line_kwargs: dict[str, _tp.Any] | None = None,
        scatter_kwargs: dict[str, _tp.Any] | None = None,
    ) -> tuple[_plt.Figure, _plt.Axes]:

        _validate_inputs(self, columns)
        x_column, y_column = columns

        # ===========================================
        # The following simplifies the code later on,
        # while being compatible with linting.
        if not line_kwargs:
            line_kwargs = {}
        if not scatter_kwargs:
            scatter_kwargs = {}
        # ===========================================

        if group_by_color and group_by_marker:
            fig, ax, lax = self.prep_subplots_for_legend_outside_of_plot(size)
            secondary_axis_used = True
        else:
            secondary_axis_used = False
            fig, ax = self.get_fig_and_ax({}, size)
            lax = ax

        df_grouped, group_values = self._prepare_grouping(
            df, group_by_color, group_by_marker
        )
        cmap = self.get_cmap(line_kwargs)
        color_map, marker_map = self._create_style_mappings(
            *group_values, cmap=cmap
        )

        self._plot_groups(
            df_grouped,
            x_column,
            y_column,
            color_map,
            marker_map,
            ax,
            line_kwargs,
            scatter_kwargs,
        )

        use_color_legend = False
        if group_by_color:
            use_color_legend = True

        if use_legend:
            self._create_legends(
                lax,
                color_map,
                marker_map,
                group_by_color,
                group_by_marker,
                use_color_legend=use_color_legend,
                secondary_axis_used=secondary_axis_used,
            )

        return fig, ax

    @staticmethod
    def _prepare_grouping(
        df: _pd.DataFrame,
        by_color: str | None,
        by_marker: str | None,
    ) -> tuple[
        _pd.core.groupby.generic.DataFrameGroupBy, tuple[list[str], list[str]]
    ]:
        group_by = []
        if by_color:
            group_by.append(by_color)
        if by_marker:
            group_by.append(by_marker)

        df_grouped = df.groupby(group_by)

        color_values = sorted(df[by_color].unique()) if by_color else []
        marker_values = sorted(df[by_marker].unique()) if by_marker else []

        return df_grouped, (color_values, marker_values)

    @staticmethod
    def _create_style_mappings(
        color_values: list[str],
        marker_values: list[str],
        cmap: str | None,
    ) -> tuple[dict[str, _tp.Any], dict[str, str]]:
        if color_values:
            cm = _plt.get_cmap(cmap, len(color_values))
            color_map = {val: cm(i) for i, val in enumerate(color_values)}
        else:
            cm = _plt.get_cmap(cmap, len(marker_values))
            color_map = {val: cm(i) for i, val in enumerate(marker_values)}
        if marker_values:
            marker_map = dict(zip(marker_values, plot_settings.markers))
        else:
            marker_map = {}

        return color_map, marker_map

    # pylint: disable=too-many-arguments
    @staticmethod
    def _plot_groups(
        df_grouped: _pd.core.groupby.generic.DataFrameGroupBy,
        x_column: str,
        y_column: str,
        color_map: dict[str, _tp.Any],
        marker_map: dict[str, str] | str,
        ax: _plt.Axes,
        line_kwargs: dict[str, _tp.Any],
        scatter_kwargs: dict[str, _tp.Any],
    ) -> None:
        ax.set_xlabel(x_column, fontsize=plot_settings.label_font_size)
        ax.set_ylabel(y_column, fontsize=plot_settings.label_font_size)
        for val, group in df_grouped:
            sorted_group = group.sort_values(x_column)
            x = sorted_group[x_column]
            y = sorted_group[y_column]

            plot_args = {"color": "black"}
            if color_map:
                plot_args["color"] = color_map[val[0]]

            for key, value in line_kwargs.items():
                if key not in ["cmap", "colormap"]:
                    plot_args[key] = value

            scatter_args = {"marker": "None", "color": "black", "alpha": 0.5}
            if marker_map:
                scatter_args["marker"] = marker_map[val[-1]]

            for key, value in scatter_kwargs.items():
                if key in ["marker"] and marker_map:
                    continue

                scatter_args[key] = value

            ax.plot(x, y, **plot_args)  # type: ignore
            ax.scatter(x, y, **scatter_args)  # type: ignore

    def _create_legends(
        self,
        lax: _plt.Axes,
        color_map: dict[str, _tp.Any],
        marker_map: dict[str, str],
        color_legend_title: str | None,
        marker_legend_title: str | None,
        use_color_legend: bool,
        secondary_axis_used: bool,
    ) -> None:

        if secondary_axis_used:
            # Secondary axis should be turned off.
            # Primary axis should stay the same.
            lax.axis("off")

        if use_color_legend:
            self._create_color_legend(
                lax,
                color_map,
                color_legend_title,
                bool(marker_map),
                secondary_axis_used,
            )
        if marker_map:
            self._create_marker_legend(
                lax,
                marker_map,
                marker_legend_title,
                bool(use_color_legend),
                secondary_axis_used,
            )

    @staticmethod
    def _create_color_legend(
        lax: _plt.Axes,
        color_map: dict[str, _tp.Any],
        color_legend_title: str | None,
        has_markers: bool,
        secondary_axis_used: bool,
    ) -> None:
        color_handles = [
            _plt.Line2D([], [], color=color, linestyle="-", label=label)
            for label, color in color_map.items()
        ]

        if secondary_axis_used:
            loc = "upper left"
            alignment = "left"
        else:
            loc = "best"
            alignment = "center"

        legend = lax.legend(
            handles=color_handles,
            title=color_legend_title,
            bbox_to_anchor=(0, 0, 1, 1),
            loc=loc,
            alignment=alignment,
            fontsize=plot_settings.legend_font_size,
            borderaxespad=0,
        )

        if has_markers:
            lax.add_artist(legend)

    @staticmethod
    def _create_marker_legend(
        lax: _plt.Axes,
        marker_map: dict[str, str],
        marker_legend_title: str | None,
        has_colors: bool,
        secondary_axis_used: bool,
    ) -> None:
        marker_position = 0.7 if has_colors else 1
        marker_handles = [
            _plt.Line2D(
                [],
                [],
                color="black",
                marker=marker,
                linestyle="None",
                label=label,
            )
            for label, marker in marker_map.items()
            if label is not None
        ]

        if secondary_axis_used:
            loc = "upper left"
            alignment = "left"
        else:
            loc = "best"
            alignment = "center"

        lax.legend(
            handles=marker_handles,
            title=marker_legend_title,
            bbox_to_anchor=(0, 0, 1, marker_position),
            loc=loc,
            alignment=alignment,
            fontsize=plot_settings.legend_font_size,
            borderaxespad=0,
        )


def get_date_time_axis_locator_and_formatter(
    data_frequency: _tp.Literal["step", "hourly", "monthly"],
) -> _tp.Tuple[_dates.AutoDateLocator, _dates.ConciseDateFormatter]:
    """
    Method to prepare an axis locator and a date time formattter to adjust the date time formatting.
    Can be used as follows:
    ax.xaxis.set_major_formatter(formatter)
    ax.xaxis.set_major_locator(date_locator)

    Parameters
    ----------
    data_frequency: str
        Size of the timestep. This can be 'step', 'hourly', and 'monthly'.
    """
    # TODO: rewrite the original energy balance function, to use the current implementation.

    if data_frequency == "step":
        date_locator = _dates.AutoDateLocator(minticks=4, maxticks=30)
        date_locator.intervald = {
            _dates.YEARLY: [],
            _dates.MONTHLY: [1],
            _dates.DAILY: [1],
            _dates.HOURLY: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9],
            _dates.MINUTELY: [0, 2, 4, 6, 8],  # disable
            _dates.SECONDLY: [60],  # disable
        }

        formatter = _dates.ConciseDateFormatter(date_locator)
        formatter.formats[3] = "%H"  # sub-hours
        formatter.zero_formats[3] = "%b %d %H"  # on the hour
        formatter.formats[4] = "%H:%M"  # sub-minutes
        formatter.zero_formats[4] = "%d %b %H:%M"  # on the hour

    elif data_frequency == "hourly":
        # hourly
        date_locator = _dates.AutoDateLocator(minticks=4, maxticks=36)
        date_locator.intervald = {
            _dates.YEARLY: [],
            _dates.MONTHLY: [1],
            _dates.DAILY: [1],
            _dates.HOURLY: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9],
            _dates.MINUTELY: [60],  # disable minutes completely
            _dates.SECONDLY: [3600],  # disable seconds completely
        }

        formatter = _dates.ConciseDateFormatter(date_locator)
        formatter.formats[3] = "%H"
        formatter.zero_formats[3] = "%b %d"

    elif data_frequency == "monthly":
        date_locator = _dates.AutoDateLocator(minticks=4, maxticks=36)
        date_locator.intervald = {
            _dates.YEARLY: [],
            _dates.MONTHLY: [1],
            _dates.DAILY: [31],  # disable
            _dates.HOURLY: [31 * 24],  # disable
            _dates.MINUTELY: [31 * 24 * 60],  # disable
            _dates.SECONDLY: [31 * 24 * 3600],  # disable
        }

        formatter = _dates.ConciseDateFormatter(date_locator)
        formatter.formats[1] = "%b"  # leave out year value
        formatter.zero_formats[1] = "%b"  # leave out year value
    else:
        raise ValueError(f"Incorrect data frequency: {data_frequency}")

    return date_locator, formatter


def get_frequency_of_data(
    df: _pd.DataFrame,
) -> _tp.Literal["step", "hourly", "monthly"]:
    """
    Method to identify the timestep size of the give dataframe.
    Can return 'step', 'hourly', and 'monthly'.
    """
    delta_time = df.index[1] - df.index[0]

    if delta_time < _pd.Timedelta(hours=1):
        data_frequency = "step"

    elif delta_time == _pd.Timedelta(hours=1):
        data_frequency = "hourly"

    elif delta_time >= _pd.Timedelta(days=28):
        data_frequency = "monthly"

    else:
        raise ValueError(
            f"Timesteps should be hourly, monthly, or less then hourly, recieved: {delta_time}"
        )

    return data_frequency  # type: ignore[return-value]


def format_date_time_twin_axis(
    lax: _plt.Axes,
    rax: _plt.Axes,
    data_frequency: _tp.Literal["step", "hourly", "monthly"],
):
    """Method to update dateTime formatting for twin axes.

    Parameters
    ----------
    lax: _plt.Axes
        left-axis handle

    rax: _plt.Axes
        right-axis handle

    data_frequency: str
        Size of the timestep. This can be 'step', 'hourly', and 'monthly'.
    """
    date_locator, formatter = get_date_time_axis_locator_and_formatter(
        data_frequency
    )
    lax.xaxis_date()
    lax.xaxis.set_major_formatter(formatter)
    lax.xaxis.set_major_locator(date_locator)
    rax.xaxis_date()
    rax.xaxis.set_major_formatter(formatter)
    rax.xaxis.set_major_locator(date_locator)
    lax.tick_params(axis="x", rotation=90)
    rax.xaxis.get_offset_text().set_visible(False)
    lax.xaxis.get_offset_text().set_visible(False)

SPF-OST / pytrnsys_process / 26558912126

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous