• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

MuellerSeb / nml-tools / 26510341483

27 May 2026 12:07PM UTC coverage: 83.53% (+2.5%) from 81.064%
26510341483

Pull #32

github

MuellerSeb
Reject non-string keys in derived Python mappings

Generate a shared derived-member validator for Python wrappers so scalar and array mappings reject non-string member names with deterministic ValueErrors before formatting unknown-key diagnostics.

Add executable generated-wrapper regressions for integer scalar keys and byte-string array keys, and refresh the derived-types example wrapper artifact.
Pull Request #32: Add One-Level Derived-Type Support For Generated Namelists

690 of 760 new or added lines in 7 files covered. (90.79%)

1 existing line in 1 file now uncovered.

3743 of 4481 relevant lines covered (83.53%)

0.84 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.93
/src/nml_tools/codegen_f2py.py
1
"""f2py and Python wrapper code generation."""
2

3
from __future__ import annotations
1✔
4

5
import hashlib
1✔
6
import keyword
1✔
7
import re
1✔
8
from dataclasses import dataclass
1✔
9
from pathlib import Path
1✔
10
from typing import Any, Iterable, cast
1✔
11

12
from jinja2 import Environment, FileSystemLoader, StrictUndefined
1✔
13

14
from ._utils import (
1✔
15
    normalize_constant_values,
16
    normalize_runtime_dimensions,
17
    reject_constant_dimension_overlap,
18
    strip_trailing_whitespace,
19
)
20
from .codegen_fortran import (
1✔
21
    FieldSpec,
22
    FieldTypeInfo,
23
    _build_context,
24
    _derived_schema,
25
    _derived_type_name,
26
    _field_type_info,
27
    _reject_runtime_dimension_lengths,
28
)
29

30
_TEMPLATE_ENV = Environment(
1✔
31
    loader=FileSystemLoader(Path(__file__).resolve().parent / "templates"),
32
    trim_blocks=True,
33
    lstrip_blocks=False,
34
    keep_trailing_newline=True,
35
    undefined=StrictUndefined,
36
)
37

38

39
@dataclass
1✔
40
class F2pyDerivedLeafSpec:
1✔
41
    """An intrinsic ABI leaf flattened from a derived Python argument."""
42

43
    name: str
1✔
44
    encoded_name: str
1✔
45
    has_name: str
1✔
46
    rank: int
1✔
47
    numpy_dtype: str | None
1✔
48
    dummy_value: str
1✔
49

50

51
@dataclass
1✔
52
class F2pyArgumentSpec:
1✔
53
    """Python wrapper argument metadata."""
54

55
    name: str
1✔
56
    title: str
1✔
57
    required: bool
1✔
58
    rank: int
1✔
59
    numpy_dtype: str | None
1✔
60
    dummy_value: str
1✔
61
    doc_type: str
1✔
62
    requirement: str
1✔
63
    has_flag: str | None = None
1✔
64
    fixed_shape: list[int] | None = None
1✔
65
    python_name: str | None = None
1✔
66
    derived_leaves: list[F2pyDerivedLeafSpec] | None = None
1✔
67
    derived_type_name: str | None = None
1✔
68

69

70
@dataclass
1✔
71
class F2pyArrayDimensionSpec:
1✔
72
    """Dimension arguments for a f2py-visible array dummy."""
73

74
    field_name: str
1✔
75
    names: list[str]
1✔
76

77

78
@dataclass
1✔
79
class F2pyNamelistSpec:
1✔
80
    """Metadata needed for f2py wrapper generation."""
81

82
    namelist_name: str
1✔
83
    brief: str
1✔
84
    details: str
1✔
85
    details_lines: list[str]
1✔
86
    module_name: str
1✔
87
    type_name: str
1✔
88
    helper_module: str
1✔
89
    kind_module: str
1✔
90
    kind_imports: list[str]
1✔
91
    f2py_module_name: str
1✔
92
    resolve_handle_name: str
1✔
93
    handle_ctype: str
1✔
94
    errmsg_len: int
1✔
95
    argument_list: list[str]
1✔
96
    argument_declarations: list[str]
1✔
97
    bridge_declarations: list[str]
1✔
98
    bridge_assignments: list[str]
1✔
99
    set_call_arguments: list[str]
1✔
100
    set_dims_argument_list: list[str]
1✔
101
    set_dims_argument_declarations: list[str]
1✔
102
    set_dims_bridge_declarations: list[str]
1✔
103
    set_dims_bridge_assignments: list[str]
1✔
104
    set_dims_call_arguments: list[str]
1✔
105
    set_dims_args: list[F2pyArgumentSpec]
1✔
106
    array_dimensions: list[F2pyArrayDimensionSpec]
1✔
107
    required_args: list[F2pyArgumentSpec]
1✔
108
    optional_args: list[F2pyArgumentSpec]
1✔
109
    all_args: list[F2pyArgumentSpec]
1✔
110
    derived_type_names: list[str]
1✔
111

112

113
@dataclass
1✔
114
class PythonWrapperSpec:
1✔
115
    """Metadata needed for Python wrapper generation."""
116

117
    class_name: str
1✔
118
    namelist_name: str
1✔
119
    brief: str
1✔
120
    f2py_module_name: str
1✔
121
    extension_module: str
1✔
122
    required_args: list[F2pyArgumentSpec]
1✔
123
    optional_args: list[F2pyArgumentSpec]
1✔
124
    all_args: list[F2pyArgumentSpec]
1✔
125
    set_dims_args: list[F2pyArgumentSpec]
1✔
126

127

128
@dataclass
1✔
129
class F2pyKindUsage:
1✔
130
    """Kind aliases used by f2py wrapper dummy arguments."""
131

132
    real: set[str]
1✔
133
    integer: set[str]
1✔
134

135

136
@dataclass
1✔
137
class F2pyCTypeMap:
1✔
138
    """Explicit C type mapping for f2py kinds."""
139

140
    real: dict[str, str]
1✔
141
    integer: dict[str, str]
1✔
142

143

144
def generate_f2py_wrappers(
1✔
145
    schemas: Iterable[dict[str, Any]],
146
    output: str | Path,
147
    *,
148
    helper_module: str = "nml_helper",
149
    kind_module: str | None = None,
150
    kind_map: dict[str, str] | None = None,
151
    kind_allowlist: Iterable[str] | None = None,
152
    constants: dict[str, int] | None = None,
153
    dimensions: dict[str, int] | None = None,
154
    errmsg_len: int = 1024,
155
) -> None:
156
    """Generate f2py-facing Fortran wrappers for *schemas* at *output*."""
157
    output_path = Path(output)
1✔
158
    rendered = render_f2py_wrappers(
1✔
159
        schemas,
160
        file_name=output_path.name,
161
        helper_module=helper_module,
162
        kind_module=kind_module,
163
        kind_map=kind_map,
164
        kind_allowlist=kind_allowlist,
165
        constants=constants,
166
        dimensions=dimensions,
167
        errmsg_len=errmsg_len,
168
    )
169
    output_path.parent.mkdir(parents=True, exist_ok=True)
1✔
170
    output_path.write_text(rendered, encoding="ascii")
1✔
171

172

173
def render_f2py_wrappers(
1✔
174
    schemas: Iterable[dict[str, Any]],
175
    *,
176
    file_name: str,
177
    helper_module: str = "nml_helper",
178
    kind_module: str | None = None,
179
    kind_map: dict[str, str] | None = None,
180
    kind_allowlist: Iterable[str] | None = None,
181
    constants: dict[str, int] | None = None,
182
    dimensions: dict[str, int] | None = None,
183
    errmsg_len: int = 1024,
184
) -> str:
185
    """Render f2py-facing Fortran wrappers for *schemas*."""
186
    specs = [
1✔
187
        build_f2py_namelist_spec(
188
            schema,
189
            helper_module=helper_module,
190
            kind_module=kind_module,
191
            kind_map=kind_map,
192
            kind_allowlist=kind_allowlist,
193
            constants=constants,
194
            dimensions=dimensions,
195
            errmsg_len=errmsg_len,
196
        )
197
        for schema in schemas
198
    ]
199
    rendered = _TEMPLATE_ENV.get_template("f2py_wrappers.f90.j2").render(
1✔
200
        {"file_name": file_name, "specs": specs}
201
    )
202
    return strip_trailing_whitespace(rendered)
1✔
203

204

205
def generate_python_wrappers(
1✔
206
    specs: Iterable[tuple[F2pyNamelistSpec, str]],
207
    output: str | Path,
208
    *,
209
    py_style: str = "numpy",
210
) -> None:
211
    """Generate Python wrapper classes for f2py namelist *specs* at *output*."""
212
    rendered = render_python_wrappers(specs, py_style=py_style)
1✔
213
    output_path = Path(output)
1✔
214
    output_path.parent.mkdir(parents=True, exist_ok=True)
1✔
215
    output_path.write_text(rendered, encoding="ascii")
1✔
216

217

218
def render_python_wrappers(
1✔
219
    specs: Iterable[tuple[F2pyNamelistSpec, str]],
220
    *,
221
    py_style: str = "numpy",
222
) -> str:
223
    """Render Python wrapper classes for f2py namelist *specs*."""
224
    if py_style not in {"numpy", "doxygen"}:
1✔
225
        raise ValueError("python documentation style must be 'numpy' or 'doxygen'")
1✔
226
    spec_entries = list(specs)
1✔
227
    extension_modules: set[str] = set()
1✔
228
    for _, extension_module in spec_entries:
1✔
229
        _validate_python_module_name(extension_module)
1✔
230
        extension_modules.add(extension_module)
1✔
231
    classes: list[PythonWrapperSpec] = []
1✔
232
    for spec, extension_module in spec_entries:
1✔
233
        classes.append(
1✔
234
            PythonWrapperSpec(
235
                class_name=_class_name(spec.namelist_name),
236
                namelist_name=spec.namelist_name,
237
                brief=spec.brief,
238
                f2py_module_name=spec.f2py_module_name,
239
                extension_module=extension_module,
240
                required_args=spec.required_args,
241
                optional_args=spec.optional_args,
242
                all_args=spec.all_args,
243
                set_dims_args=spec.set_dims_args,
244
            )
245
        )
246
    rendered = _TEMPLATE_ENV.get_template("python_wrappers.py.j2").render(
1✔
247
        {
248
            "imports": sorted(extension_modules),
249
            "classes": classes,
250
            "py_style": py_style,
251
            "uses_derived": any(
252
                arg.derived_leaves is not None
253
                for cls in classes
254
                for arg in cls.all_args
255
            ),
256
        }
257
    )
258
    return strip_trailing_whitespace(rendered)
1✔
259

260

261
def generate_f2cmap(
1✔
262
    output: str | Path,
263
    usage: F2pyKindUsage,
264
    c_types: F2pyCTypeMap,
265
) -> None:
266
    """Generate a .f2py_f2cmap file for the explicitly mapped *usage*."""
267
    rendered = render_f2cmap(usage, c_types)
1✔
268
    output_path = Path(output)
1✔
269
    output_path.parent.mkdir(parents=True, exist_ok=True)
1✔
270
    output_path.write_text(rendered, encoding="ascii")
1✔
271

272

273
def render_f2cmap(
1✔
274
    usage: F2pyKindUsage,
275
    c_types: F2pyCTypeMap,
276
) -> str:
277
    """Render a .f2py_f2cmap file for the explicitly mapped *usage*."""
278
    missing_real = sorted(usage.real - set(c_types.real))
1✔
279
    missing_integer = sorted(usage.integer - set(c_types.integer))
1✔
280
    if missing_real:
1✔
281
        raise ValueError("missing f2py real C type mappings: " + ", ".join(missing_real))
1✔
282
    if missing_integer:
1✔
283
        raise ValueError(
×
284
            "missing f2py integer C type mappings: " + ", ".join(missing_integer)
285
        )
286

287
    integer_map = dict(c_types.integer)
1✔
288
    integer_map.setdefault("c_intptr_t", "long_long")
1✔
289
    real_items = ", ".join(
1✔
290
        f"{name}={c_types.real[name]!r}" for name in sorted(usage.real)
291
    )
292
    integer_items = ", ".join(
1✔
293
        f"{name}={integer_map[name]!r}" for name in sorted(usage.integer | {"c_intptr_t"})
294
    )
295
    return f"dict(real=dict({real_items}), integer=dict({integer_items}))\n"
1✔
296

297

298
def collect_f2py_kind_usage(
1✔
299
    schemas: Iterable[dict[str, Any]],
300
    *,
301
    constants: dict[str, int] | None = None,
302
    dimensions: dict[str, int] | None = None,
303
) -> F2pyKindUsage:
304
    """Collect schema kind aliases used in f2py wrapper arguments."""
305
    usage = F2pyKindUsage(real=set(), integer=set())
1✔
306
    runtime_dimension_values = normalize_runtime_dimensions(dimensions)
1✔
307
    for schema in schemas:
1✔
308
        properties = _normalized_properties(schema)
1✔
309
        field_infos = _iter_field_type_infos(schema, constants, dimensions)
1✔
310
        expanded: list[FieldTypeInfo] = []
1✔
311
        for name, type_info in field_infos:
1✔
312
            derived = _derived_schema(properties[name])
1✔
313
            if derived is None:
1✔
314
                expanded.append(type_info)
1✔
315
                continue
1✔
316
            components = derived.get("properties")
1✔
317
            if not isinstance(components, dict):
1✔
NEW
318
                continue
×
319
            for component in components.values():
1✔
320
                if isinstance(component, dict):
1✔
321
                    _reject_runtime_dimension_lengths(component, runtime_dimension_values)
1✔
322
                    expanded.append(
1✔
323
                        _field_type_info(component, normalize_constant_values(constants))
324
                    )
325
        for type_info in expanded:
1✔
326
            category = (
1✔
327
                type_info.element_category
328
                if type_info.category == "array"
329
                else type_info.category
330
            )
331
            if type_info.kind is None:
1✔
332
                continue
1✔
333
            if category == "real":
1✔
334
                usage.real.add(type_info.kind)
1✔
335
            elif category == "integer":
1✔
336
                usage.integer.add(type_info.kind)
1✔
337
    return usage
1✔
338

339

340
def merge_f2py_kind_usage(usages: Iterable[F2pyKindUsage]) -> F2pyKindUsage:
1✔
341
    """Merge multiple f2py kind usage objects."""
342
    merged = F2pyKindUsage(real=set(), integer=set())
1✔
343
    for usage in usages:
1✔
344
        merged.real.update(usage.real)
1✔
345
        merged.integer.update(usage.integer)
1✔
346
    return merged
1✔
347

348

349
def build_f2py_namelist_spec(
1✔
350
    schema: dict[str, Any],
351
    *,
352
    helper_module: str = "nml_helper",
353
    kind_module: str | None = None,
354
    kind_map: dict[str, str] | None = None,
355
    kind_allowlist: Iterable[str] | None = None,
356
    constants: dict[str, int] | None = None,
357
    dimensions: dict[str, int] | None = None,
358
    errmsg_len: int = 1024,
359
) -> F2pyNamelistSpec:
360
    """Build f2py wrapper metadata for one namelist schema."""
361
    context = _build_context(
1✔
362
        schema,
363
        helper_module=helper_module,
364
        kind_module=kind_module,
365
        kind_map=kind_map,
366
        kind_allowlist=kind_allowlist,
367
        constants=constants,
368
        dimensions=dimensions,
369
        module_doc=None,
370
    )
371
    fields = cast("list[FieldSpec]", context["fields"])
1✔
372
    type_infos = {
1✔
373
        name: type_info
374
        for name, type_info in _iter_field_type_infos(schema, constants, dimensions)
375
    }
376
    required_args: list[F2pyArgumentSpec] = []
1✔
377
    optional_args: list[F2pyArgumentSpec] = []
1✔
378
    argument_list: list[str] = []
1✔
379
    argument_declarations: list[str] = []
1✔
380
    bridge_declarations: list[str] = []
1✔
381
    bridge_assignments: list[str] = []
1✔
382
    set_call_arguments: list[str] = []
1✔
383
    set_dims_argument_list: list[str] = []
1✔
384
    set_dims_argument_declarations: list[str] = []
1✔
385
    set_dims_bridge_declarations: list[str] = []
1✔
386
    set_dims_bridge_assignments: list[str] = []
1✔
387
    set_dims_call_arguments: list[str] = []
1✔
388
    set_dims_args: list[F2pyArgumentSpec] = []
1✔
389
    array_dimensions: list[F2pyArrayDimensionSpec] = []
1✔
390
    derived_type_names: list[str] = []
1✔
391

392
    field_argument_names: set[str] = {"handle", "status", "errmsg"}
1✔
393
    field_argument_names.update(field.name.lower() for field in fields)
1✔
394

395
    argument_names_in_use: set[str] = set(field_argument_names)
1✔
396
    bridge_names_in_use: set[str] = set(field_argument_names) | {
1✔
397
        "handle",
398
        "status",
399
        "errmsg",
400
        "this",
401
    }
402

403
    for field in fields:
1✔
404
        type_info = type_infos[field.name]
1✔
405
        rank = len(type_info.dimensions) if type_info.category == "array" else 0
1✔
406
        prop = _normalized_properties(schema)[field.name]
1✔
407
        derived = _derived_schema(prop)
1✔
408
        if derived is not None:
1✔
409
            dim_names: list[str] = []
1✔
410
            if rank:
1✔
411
                for dim_name in _array_dimension_argument_names(field.name, rank):
1✔
412
                    generated_dim_name = _unique_generated_name(dim_name, argument_names_in_use)
1✔
413
                    argument_names_in_use.add(generated_dim_name.lower())
1✔
414
                    dim_names.append(generated_dim_name)
1✔
415
            derived_type_name = _derived_type_name(derived)
1✔
416
            if derived_type_name.lower() not in {
1✔
417
                name.lower() for name in derived_type_names
418
            }:
419
                derived_type_names.append(derived_type_name)
1✔
420
            leaves = _f2py_derived_leaves(
1✔
421
                field.name,
422
                derived,
423
                type_info,
424
                constants,
425
                argument_names_in_use,
426
            )
427
            outer_has_flag: str | None = None
1✔
428
            if not field.required:
1✔
429
                outer_has_flag = _unique_generated_name(
1✔
430
                    f"has__{field.name}", argument_names_in_use
431
                )
432
                argument_names_in_use.add(outer_has_flag.lower())
1✔
433
                argument_list.append(outer_has_flag)
1✔
434
                argument_declarations.append(
1✔
435
                    f"logical, intent(in) :: {outer_has_flag} "
436
                    f"!< whether {field.name} was provided"
437
                )
438
            spec = F2pyArgumentSpec(
1✔
439
                name=field.name,
440
                title=_one_line(field.title),
441
                required=field.required,
442
                rank=rank,
443
                numpy_dtype=None,
444
                dummy_value="None",
445
                doc_type=("sequence of mappings" if rank else "mapping"),
446
                requirement="required" if field.required else "optional",
447
                has_flag=outer_has_flag,
448
                derived_leaves=leaves,
449
                derived_type_name=derived_type_name,
450
            )
451
            if field.required:
1✔
452
                required_args.append(spec)
1✔
453
            else:
454
                optional_args.append(spec)
1✔
455
            if rank:
1✔
456
                argument_list.extend(dim_names)
1✔
457
                argument_declarations.extend(
1✔
458
                    f"integer, intent(in) :: {dim_name} !< extent for {field.name}"
459
                    for dim_name in dim_names
460
                )
461
                array_dimensions.append(
1✔
462
                    F2pyArrayDimensionSpec(field_name=field.name, names=dim_names)
463
                )
464
            for leaf in leaves:
1✔
465
                argument_list.append(leaf.encoded_name)
1✔
466
                if rank:
1✔
467
                    dims = ", ".join(dim_names)
1✔
468
                    leaf_type = _field_type_info(
1✔
469
                        cast("dict[str, Any]", derived["properties"][leaf.name]),
470
                        normalize_constant_values(constants),
471
                    )
472
                    argument_declarations.append(
1✔
473
                        f"{leaf_type.arg_type_spec}, dimension({dims}), intent(in) :: "
474
                        f"{leaf.encoded_name} !< {field.name}%{leaf.name}"
475
                    )
476
                    argument_list.append(leaf.has_name)
1✔
477
                    argument_declarations.append(
1✔
478
                        f"logical, dimension({dims}), intent(in) :: {leaf.has_name} "
479
                        f"!< provided mask for {field.name}%{leaf.name}"
480
                    )
481
                else:
482
                    leaf_type = _field_type_info(
1✔
483
                        cast("dict[str, Any]", derived["properties"][leaf.name]),
484
                        normalize_constant_values(constants),
485
                    )
486
                    argument_declarations.append(
1✔
487
                        f"{leaf_type.arg_type_spec}, intent(in) :: {leaf.encoded_name} "
488
                        f"!< {field.name}%{leaf.name}"
489
                    )
490
                    argument_list.append(leaf.has_name)
1✔
491
                    argument_declarations.append(
1✔
492
                        f"logical, intent(in) :: {leaf.has_name} "
493
                        f"!< whether {field.name}%{leaf.name} was provided"
494
                    )
495
            bridge_names_in_use.update(argument_names_in_use)
1✔
496
            maybe_name = _unique_generated_name(
1✔
497
                _maybe_bridge_name(field.name), bridge_names_in_use
498
            )
499
            bridge_names_in_use.add(maybe_name.lower())
1✔
500
            bridge_declarations.extend(
1✔
501
                _derived_bridge_declarations(maybe_name, derived_type_name, rank, field.required)
502
            )
503
            bridge_assignments.extend(
1✔
504
                _derived_bridge_assignments(
505
                    field.name,
506
                    maybe_name,
507
                    leaves,
508
                    rank,
509
                    field.required,
510
                    outer_has_flag,
511
                    dim_names,
512
                )
513
            )
514
            set_call_arguments.append(f"{field.name}={maybe_name}")
1✔
515
            continue
1✔
516
        has_flag: str | None = None
1✔
517
        dim_names = []
1✔
518
        if rank:
1✔
519
            for dim_name in _array_dimension_argument_names(field.name, rank):
1✔
520
                generated_dim_name = _unique_generated_name(dim_name, argument_names_in_use)
1✔
521
                argument_names_in_use.add(generated_dim_name.lower())
1✔
522
                dim_names.append(generated_dim_name)
1✔
523
        if not field.required:
1✔
524
            has_base = f"has__{field.name}"
1✔
525
            has_flag = _unique_generated_name(has_base, argument_names_in_use)
1✔
526
            argument_names_in_use.add(has_flag.lower())
1✔
527
        spec = F2pyArgumentSpec(
1✔
528
            name=field.name,
529
            title=_one_line(field.title),
530
            required=field.required,
531
            rank=rank,
532
            numpy_dtype=_numpy_dtype(type_info),
533
            dummy_value=_python_dummy_value(type_info),
534
            doc_type=_python_doc_type(type_info),
535
            requirement="required" if field.required else "optional",
536
            has_flag=has_flag,
537
        )
538
        if field.required:
1✔
539
            required_args.append(spec)
1✔
540
        else:
541
            optional_args.append(spec)
1✔
542
        field_arguments, field_declarations = _f2py_field_arguments(
1✔
543
            field, type_info, dim_names=dim_names
544
        )
545
        argument_list.extend(field_arguments)
1✔
546
        argument_declarations.extend(field_declarations)
1✔
547
        if rank > 0:
1✔
548
            array_dimensions.append(
1✔
549
                F2pyArrayDimensionSpec(field_name=field.name, names=dim_names)
550
            )
551
        if has_flag is not None:
1✔
552
            argument_list.append(has_flag)
1✔
553
            argument_declarations.append(
1✔
554
                f"logical, intent(in) :: {has_flag} !< whether {field.name} was provided"
555
            )
556
            bridge_names_in_use.update(argument_names_in_use)
1✔
557
            maybe_base = _maybe_bridge_name(field.name)
1✔
558
            maybe_name = _unique_generated_name(maybe_base, bridge_names_in_use)
1✔
559
            bridge_names_in_use.add(maybe_name.lower())
1✔
560
            bridge_declarations.append(
1✔
561
                _optional_bridge_declaration(field.name, type_info, maybe_name)
562
            )
563
            bridge_assignments.append(
1✔
564
                _optional_bridge_assignment(field.name, type_info, has_flag, maybe_name)
565
            )
566
            set_call_arguments.append(f"{field.name}={maybe_name}")
1✔
567
        else:
568
            set_call_arguments.append(f"{field.name}={field.name}")
1✔
569

570
    runtime_dimension_args = cast("list[dict[str, str]]", context["set_dims_arguments"])
1✔
571
    set_dims_argument_names_in_use: set[str] = {
1✔
572
        str(entry["name"]).lower() for entry in runtime_dimension_args
573
    }
574
    set_dims_bridge_names_in_use: set[str] = set(set_dims_argument_names_in_use) | {
1✔
575
        "handle",
576
        "status",
577
        "errmsg",
578
        "this",
579
    }
580

581
    for entry in runtime_dimension_args:
1✔
582
        const_name = entry["name"]
1✔
583
        arg_name = entry["arg_name"]
1✔
584
        python_name = _python_parameter_name(const_name)
1✔
585
        has_base = f"has__{const_name}"
1✔
586
        has_flag = _unique_generated_name(has_base, set_dims_argument_names_in_use)
1✔
587
        set_dims_argument_names_in_use.add(has_flag.lower())
1✔
588
        set_dims_args.append(
1✔
589
            F2pyArgumentSpec(
590
                name=const_name,
591
                title=f"Runtime dimension override for {const_name}",
592
                required=False,
593
                rank=0,
594
                numpy_dtype="int",
595
                dummy_value="0",
596
                doc_type="int",
597
                requirement="optional",
598
                has_flag=has_flag,
599
                fixed_shape=None,
600
                python_name=python_name,
601
            )
602
        )
603
        set_dims_argument_list.append(const_name)
1✔
604
        set_dims_argument_declarations.append(
1✔
605
            f"integer, intent(in) :: {const_name} !< runtime dimension override for {const_name}"
606
        )
607
        set_dims_argument_list.append(has_flag)
1✔
608
        set_dims_argument_declarations.append(
1✔
609
            f"logical, intent(in) :: {has_flag} !< whether {const_name} was provided"
610
        )
611
        maybe_base = _maybe_bridge_name(const_name)
1✔
612
        maybe_name = _unique_generated_name(maybe_base, set_dims_bridge_names_in_use)
1✔
613
        set_dims_bridge_names_in_use.add(maybe_name.lower())
1✔
614
        set_dims_bridge_declarations.append(f"integer, allocatable :: {maybe_name}")
1✔
615
        set_dims_bridge_assignments.append(
1✔
616
            f"if ({has_flag}) then\n"
617
            f"  allocate({maybe_name})\n"
618
            f"  {maybe_name} = {const_name}\n"
619
            "end if"
620
        )
621
        set_dims_call_arguments.append(f"{arg_name}={maybe_name}")
1✔
622

623
    namelist_name = cast("str", context["namelist_name"])
1✔
624
    details = cast("str", context["details_text"])
1✔
625
    return F2pyNamelistSpec(
1✔
626
        namelist_name=namelist_name,
627
        brief=_one_line(cast("str", context["brief_text"])),
628
        details=details,
629
        details_lines=details.splitlines() or [details],
630
        module_name=cast("str", context["module_name"]),
631
        type_name=cast("str", context["type_name"]),
632
        helper_module=helper_module,
633
        kind_module=cast("str", context["kind_module"]),
634
        kind_imports=cast("list[str]", context["kind_imports"]),
635
        f2py_module_name=f"f2py_{namelist_name}",
636
        resolve_handle_name=f"{context['module_name']}_resolve_handle",
637
        handle_ctype="c_intptr_t",
638
        errmsg_len=errmsg_len,
639
        argument_list=argument_list,
640
        argument_declarations=argument_declarations,
641
        bridge_declarations=bridge_declarations,
642
        bridge_assignments=bridge_assignments,
643
        set_call_arguments=set_call_arguments,
644
        set_dims_argument_list=set_dims_argument_list,
645
        set_dims_argument_declarations=set_dims_argument_declarations,
646
        set_dims_bridge_declarations=set_dims_bridge_declarations,
647
        set_dims_bridge_assignments=set_dims_bridge_assignments,
648
        set_dims_call_arguments=set_dims_call_arguments,
649
        set_dims_args=set_dims_args,
650
        array_dimensions=array_dimensions,
651
        required_args=required_args,
652
        optional_args=optional_args,
653
        all_args=required_args + optional_args,
654
        derived_type_names=derived_type_names,
655
    )
656

657

658
def _iter_field_type_infos(
1✔
659
    schema: dict[str, Any],
660
    constants: dict[str, int] | None,
661
    dimensions: dict[str, int] | None = None,
662
) -> list[tuple[str, FieldTypeInfo]]:
663
    properties = _normalized_properties(schema)
1✔
664
    constants = normalize_constant_values(constants)
1✔
665
    runtime_dimension_values = normalize_runtime_dimensions(dimensions)
1✔
666
    reject_constant_dimension_overlap(constants, runtime_dimension_values)
1✔
667
    field_types: list[tuple[str, FieldTypeInfo]] = []
1✔
668
    for name, prop in properties.items():
1✔
669
        _reject_runtime_dimension_lengths(prop, runtime_dimension_values)
1✔
670
        field_types.append((name, _field_type_info(prop, constants)))
1✔
671
    return field_types
1✔
672

673

674
def _normalized_properties(schema: dict[str, Any]) -> dict[str, dict[str, Any]]:
1✔
675
    properties = schema.get("properties")
1✔
676
    if not isinstance(properties, dict):
1✔
677
        raise ValueError("schema must define object 'properties'")
×
678
    normalized: dict[str, dict[str, Any]] = {}
1✔
679
    seen: set[str] = set()
1✔
680
    for raw_name, prop in properties.items():
1✔
681
        if not isinstance(raw_name, str):
1✔
682
            raise ValueError("property names must be strings")
×
683
        if not isinstance(prop, dict):
1✔
684
            raise ValueError(f"property '{raw_name}' must be an object")
×
685
        name = raw_name.lower()
1✔
686
        if name in seen:
1✔
687
            raise ValueError(f"duplicate property '{raw_name}'")
×
688
        seen.add(name)
1✔
689
        normalized[name] = prop
1✔
690
    return normalized
1✔
691

692

693
def _class_name(namelist_name: str) -> str:
1✔
694
    parts = [part for part in re.split(r"[^0-9A-Za-z]+", namelist_name) if part]
1✔
695
    if not parts:
1✔
696
        return "Namelist"
×
697
    name = "".join(part[:1].upper() + part[1:] for part in parts)
1✔
698
    if name[0].isdigit():
1✔
699
        name = f"Namelist{name}"
×
700
    if keyword.iskeyword(name):
1✔
701
        name = f"{name}Namelist"
×
702
    return name
1✔
703

704

705
def _python_parameter_name(name: str) -> str:
1✔
706
    if not name.isidentifier():
1✔
707
        raise ValueError(f"name '{name}' is not a valid Python identifier")
×
708
    if keyword.iskeyword(name):
1✔
709
        return f"{name}_"
1✔
710
    return name
1✔
711

712

713
def _numpy_dtype(type_info: FieldTypeInfo) -> str | None:
1✔
714
    category = (
1✔
715
        type_info.element_category
716
        if type_info.category == "array"
717
        else type_info.category
718
    )
719
    if category == "real":
1✔
720
        return "float"
1✔
721
    if category == "integer":
1✔
722
        return "int"
1✔
723
    if category == "boolean":
1✔
724
        return "bool"
×
725
    if category == "string":
1✔
726
        return "str"
1✔
727
    return None
×
728

729

730
def _python_dummy_value(type_info: FieldTypeInfo) -> str:
1✔
731
    category = (
1✔
732
        type_info.element_category
733
        if type_info.category == "array"
734
        else type_info.category
735
    )
736
    if category == "real":
1✔
737
        return "0.0"
1✔
738
    if category == "integer":
1✔
739
        return "0"
1✔
740
    if category == "boolean":
1✔
741
        return "False"
×
742
    if category == "string":
1✔
743
        return '""'
1✔
744
    return "None"
×
745

746

747
def _python_doc_type(type_info: FieldTypeInfo) -> str:
1✔
748
    category = (
1✔
749
        type_info.element_category
750
        if type_info.category == "array"
751
        else type_info.category
752
    )
753
    if category == "real":
1✔
754
        type_name = "float"
1✔
755
    elif category == "integer":
1✔
756
        type_name = "int"
1✔
757
    elif category == "boolean":
1✔
758
        type_name = "bool"
×
759
    elif category == "string":
1✔
760
        type_name = "str"
1✔
761
    else:
762
        type_name = "Any"
×
763
    if type_info.category == "array":
1✔
764
        return f"array_like of {type_name}"
1✔
765
    return type_name
1✔
766

767

768
def _one_line(value: str) -> str:
1✔
769
    return " ".join(value.splitlines()).strip()
1✔
770

771

772
def _array_dimension_argument_names(name: str, rank: int) -> list[str]:
1✔
773
    return [f"{name}_n{idx}" for idx in range(1, rank + 1)]
1✔
774

775

776
def _unique_generated_name(base_name: str, taken_names: set[str]) -> str:
1✔
777
    candidate = _bounded_generated_name(base_name)
1✔
778
    if candidate.lower() not in taken_names:
1✔
779
        return candidate
1✔
780
    index = 1
1✔
781
    while True:
1✔
782
        candidate = _bounded_generated_name(f"{base_name}_{index}")
1✔
783
        if candidate.lower() not in taken_names:
1✔
784
            return candidate
1✔
785
        index += 1
×
786

787

788
def _bounded_generated_name(base_name: str) -> str:
1✔
789
    if len(base_name) <= 63:
1✔
790
        return base_name
1✔
791
    suffix = hashlib.sha1(base_name.encode("ascii")).hexdigest()[:10]
1✔
792
    return f"{base_name[:52]}_{suffix}"
1✔
793

794

795
def _maybe_bridge_name(name: str) -> str:
1✔
796
    return f"maybe_{name}"
1✔
797

798

799
def _f2py_field_arguments(
1✔
800
    field: FieldSpec,
801
    type_info: FieldTypeInfo,
802
    *,
803
    dim_names: list[str] | None = None,
804
) -> tuple[list[str], list[str]]:
805
    requirement = "required" if field.required else "optional"
1✔
806
    if type_info.category != "array":
1✔
807
        return [field.name], [
1✔
808
            f"{type_info.arg_type_spec}, intent(in) :: {field.name} "
809
            f"!< {_one_line(field.title)} ({requirement})"
810
        ]
811

812
    if dim_names is None:
1✔
NEW
813
        dim_names = _array_dimension_argument_names(field.name, len(type_info.dimensions))
×
814
    dims = ", ".join(dim_names)
1✔
815
    declarations = [
1✔
816
        f"integer, intent(in) :: {dim_name} !< extent for {field.name}"
817
        for dim_name in dim_names
818
    ]
819
    declarations.append(
1✔
820
        f"{type_info.arg_type_spec}, dimension({dims}), intent(in) :: {field.name} "
821
        f"!< {_one_line(field.title)} ({requirement})"
822
    )
823
    return [*dim_names, field.name], declarations
1✔
824

825

826
def _f2py_derived_leaves(
1✔
827
    field_name: str,
828
    derived: dict[str, Any],
829
    type_info: FieldTypeInfo,
830
    constants: dict[str, int] | None,
831
    argument_names_in_use: set[str],
832
) -> list[F2pyDerivedLeafSpec]:
833
    properties = derived.get("properties")
1✔
834
    if not isinstance(properties, dict):
1✔
NEW
835
        raise ValueError(f"derived property '{field_name}' must define properties")
×
836
    rank = len(type_info.dimensions) if type_info.category == "array" else 0
1✔
837
    static_constants = normalize_constant_values(constants)
1✔
838
    leaves: list[F2pyDerivedLeafSpec] = []
1✔
839
    for name, prop in properties.items():
1✔
840
        if not isinstance(name, str) or not isinstance(prop, dict):
1✔
NEW
841
            raise ValueError(f"derived property '{field_name}' components must be objects")
×
842
        leaf_info = _field_type_info(prop, static_constants)
1✔
843
        encoded_name = _unique_generated_name(f"{field_name}__{name}", argument_names_in_use)
1✔
844
        argument_names_in_use.add(encoded_name.lower())
1✔
845
        has_name = _unique_generated_name(f"has__{encoded_name}", argument_names_in_use)
1✔
846
        argument_names_in_use.add(has_name.lower())
1✔
847
        leaves.append(
1✔
848
            F2pyDerivedLeafSpec(
849
                name=name,
850
                encoded_name=encoded_name,
851
                has_name=has_name,
852
                rank=rank,
853
                numpy_dtype=_numpy_dtype(leaf_info),
854
                dummy_value=_python_dummy_value(leaf_info),
855
            )
856
        )
857
    return leaves
1✔
858

859

860
def _derived_bridge_declarations(
1✔
861
    maybe_name: str,
862
    type_name: str,
863
    rank: int,
864
    required: bool,
865
) -> list[str]:
866
    if rank:
1✔
867
        dims = ", ".join(":" for _ in range(rank))
1✔
868
        return [f"type({type_name}), dimension({dims}), allocatable :: {maybe_name}"]
1✔
869
    if required:
1✔
870
        return [f"type({type_name}) :: {maybe_name}"]
1✔
871
    return [f"type({type_name}), allocatable :: {maybe_name}"]
1✔
872

873

874
def _derived_bridge_assignments(
1✔
875
    name: str,
876
    maybe_name: str,
877
    leaves: list[F2pyDerivedLeafSpec],
878
    rank: int,
879
    required: bool,
880
    outer_has_flag: str | None,
881
    dim_names: list[str],
882
) -> list[str]:
883
    lines: list[str] = []
1✔
884
    gated = not required
1✔
885
    if gated:
1✔
886
        if outer_has_flag is None:
1✔
NEW
887
            raise ValueError(f"optional derived property '{name}' is missing presence metadata")
×
888
        lines.append(f"if ({outer_has_flag}) then")
1✔
889
        indent = "  "
1✔
890
        if rank == 0:
1✔
891
            lines.append(f"  allocate({maybe_name})")
1✔
892
    else:
893
        indent = ""
1✔
894
    lines.append(f"{indent}status = this%init_type({name}={maybe_name}, errmsg=errmsg)")
1✔
895
    lines.append(f"{indent}if (status /= NML_OK) return")
1✔
896
    if rank:
1✔
897
        bounds = ", ".join(f"1:{dim_name}" for dim_name in dim_names)
1✔
898
        for leaf in leaves:
1✔
899
            lines.append(f"{indent}where ({leaf.has_name})")
1✔
900
            lines.append(
1✔
901
                f"{indent}  {maybe_name}({bounds})%{leaf.name} = {leaf.encoded_name}"
902
            )
903
            lines.append(f"{indent}end where")
1✔
904
    else:
905
        for leaf in leaves:
1✔
906
            lines.append(
1✔
907
                f"{indent}if ({leaf.has_name}) "
908
                f"{maybe_name}%{leaf.name} = {leaf.encoded_name}"
909
            )
910
    if gated:
1✔
911
        lines.append("end if")
1✔
912
    return ["\n".join(lines)]
1✔
913

914

915
def _optional_bridge_declaration(name: str, type_info: FieldTypeInfo, maybe_name: str) -> str:
1✔
916
    if type_info.category == "array":
1✔
917
        dims = ", ".join(":" for _ in type_info.dimensions)
1✔
918
        if type_info.element_category == "string":
1✔
919
            return f"character(len=:), dimension({dims}), allocatable :: {maybe_name}"
1✔
920
        return f"{type_info.arg_type_spec}, dimension({dims}), allocatable :: {maybe_name}"
1✔
921
    if type_info.category == "string":
1✔
922
        return f"character(len=:), allocatable :: {maybe_name}"
×
923
    return f"{type_info.arg_type_spec}, allocatable :: {maybe_name}"
1✔
924

925

926
def _optional_bridge_assignment(
1✔
927
    name: str,
928
    type_info: FieldTypeInfo,
929
    has_flag: str,
930
    maybe_name: str,
931
) -> str:
932
    if type_info.category == "array":
1✔
933
        dims = ", ".join(_array_dimension_argument_names(name, len(type_info.dimensions)))
1✔
934
        allocate_stmt = f"allocate({maybe_name}({dims}))"
1✔
935
        if type_info.element_category == "string":
1✔
936
            allocate_stmt = f"allocate(character(len=len({name})) :: {maybe_name}({dims}))"
1✔
937
        return (
1✔
938
            f"if ({has_flag}) then\n"
939
            f"  {allocate_stmt}\n"
940
            f"  {maybe_name} = {name}\n"
941
            "end if"
942
        )
943
    if type_info.category == "string":
1✔
944
        return (
×
945
            f"if ({has_flag}) then\n"
946
            f"  {maybe_name} = {name}\n"
947
            "end if"
948
        )
949
    return (
1✔
950
        f"if ({has_flag}) then\n"
951
        f"  allocate({maybe_name})\n"
952
        f"  {maybe_name} = {name}\n"
953
        "end if"
954
    )
955

956

957
def _validate_python_module_name(module_name: str) -> None:
1✔
958
    if not module_name.isidentifier() or keyword.iskeyword(module_name):
1✔
959
        raise ValueError(
×
960
            f"f2py extension module name '{module_name}' must be a valid Python identifier"
961
        )
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc