stacklok / toolhive / 26296798181

push

github

Restore ServerBuilder.WithMiddleware and WithRoute (#5369)

* Restore ServerBuilder.WithMiddleware and WithRoute

These two methods are the only public API available to ApplyServerExtensions
hooks (the enterprise overlay uses them to inject session-auth middleware
and mount an /enterprise sub-router). #5355 dropped them as unreachable
because the only callers live behind //go:build enterprise, which upstream
CI does not exercise.

Add a unit test that exercises both methods so future deadcode passes see
them as live, and add doc comments explaining the extension-point contract.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* Reword comments to describe the public extension contract

Reframe the doc comments and test rationale around the public extension
point itself ("ApplyServerExtensions consumers", "downstream repositories")
rather than the internal identity of any particular consumer. The behavior
of the methods is unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

8 of 8 new or added lines in 1 file covered. (100.0%)

65082 of 98896 relevant lines covered (65.81%)

63.18 hits per line