c8db7f44-c7fd-4a3e-8b98-d394b6031a7d

Committed 21 May 2026 06:16PM UTC coverage: 80.537% (-19.4%) from 99.963%

Build # c8db7f44-c7fd-4a3e-8b98-d394b6031a7d

Build Type

Pull #1697

circleci

Committed by

paulfalgout

Commit Message

fix(work): include program chain on action and flow fetches that honor it

Centralize ACTION_INCLUDE / FLOW_INCLUDE in the entity service and apply
them everywhere the backend actually reads the include parameter:

- /actions/{id} (fetchAction, fetchActionWithResponses, manage:add refetch)
- /flows/{id} (fetchFlow, manage:add refetch)
- /flows/{id}/relationships/actions (fetchActionsByFlow on the flow page)

The patient-relationship list endpoints
(/patients/{id}/relationships/actions, /patients/{id}/relationships/flows)
silently drop include today, so fetchActionsByPatient and
fetchFlowsByPatient keep their original data shape. Once the backend's
ListPatientActionsResponder / ListPatientFlowsResponder learn to honor
Includes::fromRequest, those call sites can pass ACTION_INCLUDE /
FLOW_INCLUDE the same way.

Pull Request Pull Request #1697: fix(work): include program relationships on action and flow fetches

Coverage Stats

1394 of 1875 branches covered (74.35%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 5 files covered. (100.0%)

1071 existing lines in 100 files now uncovered.

5028 of 6099 relevant lines covered (82.44%)

139.21 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.24

/src/js/apps/programs/program/flow/flow_app.js

import Radio from 'backbone.radio';

import SubRouterApp from 'js/base/subrouterapp';

import ActionApp from 'js/apps/programs/program/action/action_app';

import ProgramSidebarApp from 'js/apps/programs/sidebar/program-sidebar_app';
import FlowSidebarApp from 'js/apps/programs/sidebar/flow-sidebar_app';

import { LayoutView, ContextTrailView, HeaderView, AddActionView, ListView } from 'js/views/programs/program/flow/flow_views';
import { SidebarView } from 'js/views/programs/program/sidebar/sidebar-views';

export default SubRouterApp.extend({
  routerAppName: 'ProgramFlowApp',
  childApps: {
    action: ActionApp,
    programSidebar: ProgramSidebarApp,
    flowSidebar: FlowSidebarApp,
  },
  eventRoutes: {
    'programFlow:action': 'showActionSidebar',
    'programFlow:action:new': 'showActionSidebar',
  },
  onBeforeStart() {
    this.showView(new LayoutView());
  },
  beforeStart({ flowId }) {
    return [
      Radio.request('entities', 'fetch:programs:model:byProgramFlow', flowId),
      Radio.request('entities', 'fetch:programFlows:model', flowId),
      Radio.request('entities', 'fetch:programActions:collection:byProgramFlow', flowId),
    ];
  },
  onFail() {
    Radio.trigger('event-router', 'notFound');
    this.stop();
  },
  onStart({ currentRoute }, program, flow, actions) {
    this.program = program;
    this.flow = flow;
    this.actions = actions;

    this.maintainFlowActions();

    this.showChildView('contextTrail', new ContextTrailView({
      model: this.flow,
      program: this.program,
    }));

    this.showHeader();
    this.showAddAction();
    this.showActionList();
    this.showProgramSidebar();

    this.startRoute(currentRoute);
  },

  maintainFlowActions() {
    this.listenTo(this.actions, 'change:id destroy', () => {
      this.flow.setActions(this.actions);
    });
  },

  showHeader() {
    const headerView = new HeaderView({
      model: this.flow,
    });

    this.listenTo(headerView, {
      'edit': this.onEditFlow,
    });

    this.showChildView('header', headerView);
  },

  showAddAction() {
    const addActionView = new AddActionView();

    this.listenTo(addActionView, {
      'click:addAction': () => {
        Radio.trigger('event-router', 'programFlow:action:new', this.flow.id);
      },
    });

    this.showChildView('addAction', addActionView);
  },

  showActionList() {
    this.showChildView('actionList', new ListView({
      collection: this.actions,
    }));
  },

  showProgramSidebar() {
    const sidebarView = new SidebarView({ model: this.program });

    this.listenTo(sidebarView, {
      'edit': this.onEditProgram,
    });

    this.showChildView('sidebar', sidebarView);
  },

  showActionSidebar(flowId, actionId) {
    const actionApp = this.getChildApp('action');

    this.listenToOnce(actionApp, {
      'start'(options, action) {
        this.editAction(action);
      },
    });

    this.startChildApp('action', { actionId, flowId });
  },

  editAction(action) {
    if (action.isNew()) {
      action.set({ sequence: this.actions.length });
      this.actions.add(action);
      return;
    }

    action.trigger('editing', true);
  },

  onEditProgram() {
    const programSidebar = this.getChildApp('programSidebar');
    Radio.request('sidebar', 'start', programSidebar, { program: this.program });
  },

  onEditFlow() {
    const flowSidebar = this.getChildApp('flowSidebar');
    Radio.request('sidebar', 'start', flowSidebar, { flow: this.flow });
  },
});

1	import Radio from 'backbone.radio';
2
3	import SubRouterApp from 'js/base/subrouterapp';
4
5	import ActionApp from 'js/apps/programs/program/action/action_app';
6
7	import ProgramSidebarApp from 'js/apps/programs/sidebar/program-sidebar_app';
8	import FlowSidebarApp from 'js/apps/programs/sidebar/flow-sidebar_app';
9
10	import { LayoutView, ContextTrailView, HeaderView, AddActionView, ListView } from 'js/views/programs/program/flow/flow_views';
11	import { SidebarView } from 'js/views/programs/program/sidebar/sidebar-views';
12
13	export default SubRouterApp.extend({
14	routerAppName: 'ProgramFlowApp',
15	childApps: {
16	action: ActionApp,
17	programSidebar: ProgramSidebarApp,
18	flowSidebar: FlowSidebarApp,
19	},
20	eventRoutes: {
21	'programFlow:action': 'showActionSidebar',
22	'programFlow:action:new': 'showActionSidebar',
23	},
24	onBeforeStart() {
25	this.showView(new LayoutView());	13✔
26	},
27	beforeStart({ flowId }) {
28	return [	13✔
29	Radio.request('entities', 'fetch:programs:model:byProgramFlow', flowId),
30	Radio.request('entities', 'fetch:programFlows:model', flowId),
31	Radio.request('entities', 'fetch:programActions:collection:byProgramFlow', flowId),
32	];
33	},
34	onFail() {
35	Radio.trigger('event-router', 'notFound');	1✔
36	this.stop();	1✔
37	},
38	onStart({ currentRoute }, program, flow, actions) {
39	this.program = program;	12✔
40	this.flow = flow;	12✔
41	this.actions = actions;	12✔
42
43	this.maintainFlowActions();	12✔
44
45	this.showChildView('contextTrail', new ContextTrailView({	12✔
46	model: this.flow,
47	program: this.program,
48	}));
49
50	this.showHeader();	12✔
51	this.showAddAction();	12✔
52	this.showActionList();	12✔
53	this.showProgramSidebar();	12✔
54
55	this.startRoute(currentRoute);	12✔
56	},
57
58	maintainFlowActions() {
59	this.listenTo(this.actions, 'change:id destroy', () => {	12✔
60	this.flow.setActions(this.actions);	3✔
61	});
62	},
63
64	showHeader() {
65	const headerView = new HeaderView({	12✔
66	model: this.flow,
67	});
68
69	this.listenTo(headerView, {	12✔
70	'edit': this.onEditFlow,
71	});
72
73	this.showChildView('header', headerView);	12✔
74	},
75
76	showAddAction() {
77	const addActionView = new AddActionView();	12✔
78
79	this.listenTo(addActionView, {	12✔
80	'click:addAction': () => {
81	Radio.trigger('event-router', 'programFlow:action:new', this.flow.id);	1✔
82	},
83	});
84
85	this.showChildView('addAction', addActionView);	12✔
86	},
87
88	showActionList() {
89	this.showChildView('actionList', new ListView({	12✔
90	collection: this.actions,
91	}));
92	},
93
94	showProgramSidebar() {
95	const sidebarView = new SidebarView({ model: this.program });	12✔
96
97	this.listenTo(sidebarView, {	12✔
98	'edit': this.onEditProgram,
99	});
100
101	this.showChildView('sidebar', sidebarView);	12✔
102	},
103
104	showActionSidebar(flowId, actionId) {
105	const actionApp = this.getChildApp('action');	9✔
106
107	this.listenToOnce(actionApp, {	9✔
108	'start'(options, action) {
109	this.editAction(action);	9✔
110	},
111	});
112
113	this.startChildApp('action', { actionId, flowId });	9✔
114	},
115
116	editAction(action) {
117	if (action.isNew()) {	9✔
118	action.set({ sequence: this.actions.length });	2✔
119	this.actions.add(action);	2✔
120	return;	2✔
121	}
122
123	action.trigger('editing', true);	7✔
124	},
125
126	onEditProgram() {
127	const programSidebar = this.getChildApp('programSidebar');	1✔
128	Radio.request('sidebar', 'start', programSidebar, { program: this.program });	1✔
129	},
130
131	onEditFlow() {
UNCOV 132	const flowSidebar = this.getChildApp('flowSidebar');	×
UNCOV 133	Radio.request('sidebar', 'start', flowSidebar, { flow: this.flow });	×
134	},
135	});

RoundingWell / care-ops-frontend / c8db7f44-c7fd-4a3e-8b98-d394b6031a7d

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous