xapi-project / xen-api / 26209073536

push

github

CA-406020: parse dnf5 output in pool_update plugins (#7078)

dnf was upgraded to dnf5, which prints transaction errors in a new
format. The existing parsers in pool_update.precheck and
pool_update.apply were written against dnf4 and silently fell through to
a generic "unknown error" for every failure mode, hiding the real reason
from XAPI.

Tested and passed:
4648126 updatenegative.seq
4648212 supppackduringhostinstall.seq
4648128 supppackduringhostupgrade.seq

Also did manual tests for typical dnf5 transaction errors (conflict,
non-existent pacakge, missing provides)

91 of 99 new or added lines in 2 files covered. (91.92%)

3667 of 4642 relevant lines covered (79.0%)

0.79 hits per line