stacklok / toolhive / 26190207318

push

github

Honor --allow-private-ip on thv registry login --registry (#5353)

Honor --allow-private-ip when registering registry via thv registry login

`thv config set-registry --allow-private-ip <url>` lets an operator point
the CLI at a registry behind a private/corp IP. The same option was
missing from `thv registry login`, and even via the Go API the boolean
was hardcoded to false one layer down — so an operator using
`thv registry login --registry http://10.x.y.z/...` to register and
authenticate in one step always hit the private-IP rejection regardless
of intent.

- LoginOptions: add AllowPrivateIP.
- ensureRegistryURL: thread it into DetectRegistryType and the
  SetRegistryAPI / SetRegistryURL calls (which were `false` literals).
- registry_login.go: add -p/--allow-private-ip mirroring the flag on
  set-registry.

No behavior change for callers that leave the new field at its
zero value.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

5 of 12 new or added lines in 2 files covered. (41.67%)

64799 of 98937 relevant lines covered (65.5%)

62.8 hits per line