26127302554

Committed 19 May 2026 07:34PM UTC coverage: 92.635% (-0.4%) from 93.024%

Build # 26127302554

Build Type

push

github

Committed by

Castaglia

Commit Message

Make a flaky, racy mod_copy regression test more reliable.

Coverage Stats

47303 of 51064 relevant lines covered (92.63%)

241.07 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

98.08

/tests/api/ctrls.c

/*
 * ProFTPD - FTP server testsuite
 * Copyright (c) 2020-2026 The ProFTPD Project team
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, see <https://www.gnu.org/licenses/>.
 *
 * As a special exemption, The ProFTPD Project team and other respective
 * copyright holders give permission to link this program with OpenSSL, and
 * distribute the resulting executable, without including the source code for
 * OpenSSL in the source distribution.
 */

/* Controls API tests */

#include "tests.h"
#include "mod_ctrls.h"

#if defined(PR_USE_CTRLS)
static pool *p = NULL;

static const char *tmpfile_path = "/tmp/prt-ctrls.dat";

static void set_up(void) {
  (void) unlink(tmpfile_path);

  if (p == NULL) {
    p = permanent_pool = make_sub_pool(NULL);
  }

  if (getenv("TEST_VERBOSE") != NULL) {
    pr_trace_set_levels("ctrls", 1, 20);
    pr_trace_set_levels("json", 1, 20);
  }

  init_ctrls2("/tmp/test.sock");
}

static void tear_down(void) {
  if (getenv("TEST_VERBOSE") != NULL) {
    pr_trace_set_levels("ctrls", 0, 0);
    pr_trace_set_levels("json", 0, 0);
  }

  if (p != NULL) {
    destroy_pool(p);
    p = permanent_pool = NULL;
  }

  (void) unlink(tmpfile_path);
}

static int devnull_fd(void) {
  int fd;

  fd = open("/dev/null", O_RDWR);
  if (fd < 0) {
    fprintf(stderr, "Error opening /dev/null: %s\n", strerror(errno));
    return -1;
  }

  return fd;
}

static int tmpfile_fd(void) {
  int fd;

  fd = open(tmpfile_path, O_CREAT|O_RDWR, 0600);
  if (fd < 0) {
    fprintf(stderr, "Error opening %s: %s\n", tmpfile_path, strerror(errno));
    return -1;
  }

  (void) unlink(tmpfile_path);
  return fd;
}

static int reset_fd(int fd) {
  (void) close(fd);
  return tmpfile_fd();
}

static int rewind_fd(int fd) {
  if (lseek(fd, 0, SEEK_SET) == (off_t) -1) {
    return -1;
  }

  return 0;
}

/* Largely copied from mod_ctrls. */
static int listen_unix(const char *path) {
  int fd = -1, socklen = 0;
  struct sockaddr_un sock;
#if !defined(SO_PEERCRED) && !defined(HAVE_GETPEEREID) && \
    !defined(HAVE_GETPEERUCRED) && defined(LOCAL_CREDS)
  int opt = 1;
  socklen_t optlen = sizeof(opt);
#endif /* !LOCAL_CREDS */

  fd = socket(AF_UNIX, SOCK_STREAM, 0);
  if (fd < 0) {
    fprintf(stderr, "error creating local socket: %s\n", strerror(errno));
    return -1;
  }

  (void) unlink(path);
  memset(&sock, 0, sizeof(sock));
  sock.sun_family = AF_UNIX;
  sstrncpy(sock.sun_path, path, sizeof(sock.sun_path));

  socklen = sizeof(sock);
  if (bind(fd, (struct sockaddr *) &sock, socklen) < 0) {
    fprintf(stderr, "error binding local socket to path '%s': %s\n", path,
      strerror(errno));
    (void) close(fd);
    return -1;
  }

  if (listen(fd, 5) < 0) {
    fprintf(stderr, "error listening on local socket: %s\n", strerror(errno));
    (void) close(fd);
    return -1;
  }

#if !defined(SO_PEERCRED) && !defined(HAVE_GETPEEREID) && \
    !defined(HAVE_GETPEERUCRED) && defined(LOCAL_CREDS)
  /* Set the LOCAL_CREDS socket option. */
  if (setsockopt(fd, 0, LOCAL_CREDS, &opt, optlen) < 0) {
    fprintf(stderr, "error enabling LOCAL_CREDS: %s\n", strerror(errno));
  }
#endif /* !LOCAL_CREDS */

  return fd;
}

/* Tests */

START_TEST (ctrls_alloc_free_test) {
  int res;
  pr_ctrls_t *ctrl, *ctrl2, *ctrl3;

  mark_point();
  res = pr_ctrls_free(NULL);
  ck_assert_msg(res < 0, "Failed to handle null ctrl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  ctrl = pr_ctrls_alloc();
  ck_assert_msg(ctrl != NULL, "Failed to allocate ctrl: %s", strerror(errno));
  res = pr_ctrls_free(ctrl);
  ck_assert_msg(res == 0, "Failed to free ctrl: %s", strerror(errno));

  mark_point();
  ctrl = pr_ctrls_alloc();
  ck_assert_msg(ctrl != NULL, "Failed to allocate ctrl: %s", strerror(errno));
  res = pr_ctrls_free(ctrl);
  ck_assert_msg(res == 0, "Failed to free ctrl: %s", strerror(errno));

  /* LIFO order */
  mark_point();
  ctrl = pr_ctrls_alloc();
  ctrl2 = pr_ctrls_alloc();
  ck_assert_msg(ctrl2 != NULL, "Failed to allocate ctrl2: %s", strerror(errno));
  ctrl2->ctrls_tmp_pool = make_sub_pool(p);
  ctrl3 = pr_ctrls_alloc();
  ck_assert_msg(ctrl3 != NULL, "Failed to allocate ctrl3: %s", strerror(errno));
  ctrl3->ctrls_tmp_pool = make_sub_pool(p);

  res = pr_ctrls_free(ctrl3);
  ck_assert_msg(res == 0, "Failed to free ctrl3 %s", strerror(errno));
  res = pr_ctrls_free(ctrl2);
  ck_assert_msg(res == 0, "Failed to free ctrl2: %s", strerror(errno));
  res = pr_ctrls_free(ctrl);
  ck_assert_msg(res == 0, "Failed to free ctrl: %s", strerror(errno));

  /* FIFO order */
  mark_point();
  ctrl = pr_ctrls_alloc();
  ctrl2 = pr_ctrls_alloc();
  ck_assert_msg(ctrl2 != NULL, "Failed to allocate ctrl2: %s", strerror(errno));
  ctrl2->ctrls_tmp_pool = make_sub_pool(p);
  ctrl3 = pr_ctrls_alloc();
  ck_assert_msg(ctrl3 != NULL, "Failed to allocate ctrl3: %s", strerror(errno));
  ctrl3->ctrls_tmp_pool = make_sub_pool(p);

  res = pr_ctrls_free(ctrl);
  ck_assert_msg(res == 0, "Failed to free ctrl: %s", strerror(errno));
  res = pr_ctrls_free(ctrl2);
  ck_assert_msg(res == 0, "Failed to free ctrl2: %s", strerror(errno));
  res = pr_ctrls_free(ctrl3);
  ck_assert_msg(res == 0, "Failed to free ctrl3 %s", strerror(errno));
}
END_TEST

START_TEST (ctrls_unregister_test) {
  int res;

  mark_point();
  res = pr_ctrls_unregister(NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle lack of registered actions");
  ck_assert_msg(errno == ENOENT, "Expected ENOENT (%d), got %s (%d)", ENOENT,
    strerror(errno), errno);
}
END_TEST

static int ctrls_test_cb(pr_ctrls_t *ctrl, int reqargc, char **reqargv) {
  return 0;
}

static int ctrls_test2_cb(pr_ctrls_t *ctrl, int reqargc, char **reqargv) {
  return 0;
}

START_TEST (ctrls_register_test) {
  int res;
  const char *action = NULL, *desc = NULL;
  module m;

  mark_point();
  res = pr_ctrls_register(NULL, NULL, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null action");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  action = "test";
  res = pr_ctrls_register(NULL, action, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null desc");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  desc = "desc";
  res = pr_ctrls_register(NULL, action, desc, NULL);
  ck_assert_msg(res < 0, "Failed to handle null callback");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_register(NULL, action, desc, ctrls_test_cb);
  ck_assert_msg(res >= 0, "Failed to register ctrls action: %s", strerror(errno));

  mark_point();
  res = pr_ctrls_unregister(NULL, action);
  ck_assert_msg(res == 0, "Failed to unregister ctrls action: %s",
    strerror(errno));

  mark_point();
  res = pr_ctrls_register(NULL, action, desc, ctrls_test_cb);
  ck_assert_msg(res >= 0, "Failed to register ctrls action: %s", strerror(errno));

  m.name = "test";
  res = pr_ctrls_register(&m, action, desc, ctrls_test_cb);
  ck_assert_msg(res >= 0, "Failed to register ctrls action: %s", strerror(errno));

  mark_point();
  res = pr_ctrls_unregister(NULL, action);
  ck_assert_msg(res == 0, "Failed to unregister ctrls action: %s",
    strerror(errno));
}
END_TEST

START_TEST (ctrls_add_arg_test) {
  int res;
  pr_ctrls_t *ctrl;
  char buf[4];
  size_t buflen;

  mark_point();
  res = pr_ctrls_add_arg(NULL, NULL, 0);
  ck_assert_msg(res < 0, "Failed to handle null ctrl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  ctrl = pr_ctrls_alloc();
  res = pr_ctrls_add_arg(ctrl, NULL, 0);
  ck_assert_msg(res < 0, "Failed to handle null arg");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  ctrl = pr_ctrls_alloc();

  /* Provide an arg that uses unprintable ASCII. */
  buf[0] = 'a';
  buf[1] = 'b';
  buf[2] = -120;
  buflen = 3;

  res = pr_ctrls_add_arg(ctrl, buf, buflen);
  ck_assert_msg(res < 0, "Failed to handle bad arg");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);

  mark_point();
  buf[0] = 'a';
  buf[1] = 'B';
  buf[2] = '1';
  buflen = 3;

  res = pr_ctrls_add_arg(ctrl, buf, buflen);
  ck_assert_msg(res == 0, "Failed to add ctrl arg: %s", strerror(errno));
}
END_TEST

START_TEST (ctrls_add_response_test) {
  int res;
  pr_ctrls_t *ctrl;

  mark_point();
  res = pr_ctrls_add_response(NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null ctrl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  ctrl = pr_ctrls_alloc();
  res = pr_ctrls_add_response(ctrl, NULL);
  ck_assert_msg(res < 0, "Failed to handle null fmt");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_add_response(ctrl, "%s", "foo");
  ck_assert_msg(res == 0, "Failed to add ctrl response: %s", strerror(errno));
}
END_TEST

START_TEST (ctrls_copy_args_test) {
  int res;
  pr_ctrls_t *src_ctrl, *dst_ctrl;

  mark_point();
  res = pr_ctrls_copy_args(NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null src ctrl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  src_ctrl = pr_ctrls_alloc();
  res = pr_ctrls_copy_args(src_ctrl, NULL);
  ck_assert_msg(res < 0, "Failed to handle null dst ctrl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_copy_args(src_ctrl, src_ctrl);
  ck_assert_msg(res < 0, "Failed to handle same src/dst ctrl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  dst_ctrl = pr_ctrls_alloc();
  res = pr_ctrls_copy_args(src_ctrl, dst_ctrl);
  ck_assert_msg(res == 0, "Failed to copy ctrl args: %s", strerror(errno));

  mark_point();
  res = pr_ctrls_add_arg(src_ctrl, "foo", 3);
  ck_assert_msg(res == 0, "Failed to add src ctrl arg: %s", strerror(errno));

  res = pr_ctrls_add_arg(src_ctrl, "bar", 3);
  ck_assert_msg(res == 0, "Failed to add src ctrl arg: %s", strerror(errno));

  res = pr_ctrls_add_arg(src_ctrl, "baz", 3);
  ck_assert_msg(res == 0, "Failed to add src ctrl arg: %s", strerror(errno));

  res = pr_ctrls_copy_args(src_ctrl, dst_ctrl);
  ck_assert_msg(res == 0, "Failed to copy ctrl args: %s", strerror(errno));
}
END_TEST

START_TEST (ctrls_copy_resps_test) {
  int res;
  pr_ctrls_t *src_ctrl, *dst_ctrl;

  mark_point();
  res = pr_ctrls_copy_resps(NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null src ctrl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  src_ctrl = pr_ctrls_alloc();
  res = pr_ctrls_copy_resps(src_ctrl, NULL);
  ck_assert_msg(res < 0, "Failed to handle null dst ctrl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_copy_resps(src_ctrl, src_ctrl);
  ck_assert_msg(res < 0, "Failed to handle same src/dst ctrl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  dst_ctrl = pr_ctrls_alloc();
  res = pr_ctrls_copy_resps(src_ctrl, dst_ctrl);
  ck_assert_msg(res < 0, "Failed to handle src ctrl with no responses");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_add_response(src_ctrl, "%s", "foo");
  ck_assert_msg(res == 0, "Failed to add src ctrl response: %s", strerror(errno));

  res = pr_ctrls_add_response(dst_ctrl, "%s", "bar");
  ck_assert_msg(res == 0, "Failed to add dst ctrl response: %s", strerror(errno));

  res = pr_ctrls_copy_resps(src_ctrl, dst_ctrl);
  ck_assert_msg(res < 0, "Failed to handle dst ctrl with responses");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);

  mark_point();
  src_ctrl = pr_ctrls_alloc();
  res = pr_ctrls_add_response(src_ctrl, "%s", "foo");
  ck_assert_msg(res == 0, "Failed to add src ctrl response: %s", strerror(errno));

  dst_ctrl = pr_ctrls_alloc();
  res = pr_ctrls_copy_resps(src_ctrl, dst_ctrl);
  ck_assert_msg(res == 0, "Failed to copy ctrl responses: %s", strerror(errno));
}
END_TEST

START_TEST (ctrls_send_request_test) {
  int fd, res;
  char *action = "foo";
  unsigned int msgargc = 1;
  char *msgargv[] = { "bar", NULL };

  mark_point();
  res = pr_ctrls_send_request(NULL, -1, NULL, 0, NULL);
  ck_assert_msg(res < 0, "Failed to handle null pool");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_send_request(p, -1, NULL, 0, NULL);
  ck_assert_msg(res < 0, "Failed to handle invalid fd");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  fd = 7;
  res = pr_ctrls_send_request(p, fd, NULL, 0, NULL);
  ck_assert_msg(res < 0, "Failed to handle null action");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_send_request(p, fd, action, msgargc, NULL);
  ck_assert_msg(res < 0, "Failed to handle mismatched argc/argv");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  fd = 7777;
  res = pr_ctrls_send_request(p, fd, action, msgargc, msgargv);
  ck_assert_msg(res < 0, "Failed to handle invalid fd");
  ck_assert_msg(errno == EBADF, "Expected EBADF (%d), got %s (%d)", EBADF,
    strerror(errno), errno);

  fd = devnull_fd();
  if (fd < 0) {
    return;
  }

  mark_point();
  res = pr_ctrls_send_request(p, fd, action, msgargc, msgargv);
  ck_assert_msg(res == 0, "Failed to send ctrl message: %s", strerror(errno));

  (void) close(fd);
}
END_TEST

START_TEST (ctrls_send_response_test) {
  int fd, res, status;
  unsigned int msgargc = 1;
  char *msgargv[] = { "foo", NULL };

  mark_point();
  res = pr_ctrls_send_response(NULL, -1, 0, 0, NULL);
  ck_assert_msg(res < 0, "Failed to handle null pool");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_send_response(p, -1, 0, 0, NULL);
  ck_assert_msg(res < 0, "Failed to handle invalid fd");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  fd = devnull_fd();
  if (fd < 0) {
    return;
  }
  res = pr_ctrls_send_response(p, fd, 0, 0, NULL);
  ck_assert_msg(res == 0, "Failed to send zero ctrl messages: %s",
    strerror(errno));

  mark_point();
  res = pr_ctrls_send_response(p, fd, 0, msgargc, NULL);
  ck_assert_msg(res < 0, "Failed to handle missing argv");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);
  (void) close(fd);

  mark_point();
  fd = 7777;
  status = -24;
  res = pr_ctrls_send_response(p, fd, status, msgargc, msgargv);
  ck_assert_msg(res < 0, "Failed to handle invalid fd");
  ck_assert_msg(errno == EBADF, "Expected EBADF (%d), got %s (%d)", EBADF,
    strerror(errno), errno);

  fd = devnull_fd();
  if (fd < 0) {
    return;
  }

  mark_point();
  status = -24;
  res = pr_ctrls_send_response(p, fd, status, msgargc, msgargv);
  ck_assert_msg(res == 0, "Failed to send ctrl message: %s", strerror(errno));

  (void) close(fd);
}
END_TEST

START_TEST (ctrls_flush_response_test) {
  int res;
  pr_ctrls_t *ctrl;
  pr_ctrls_cl_t *cl;

  mark_point();
  res = pr_ctrls_flush_response(NULL);
  ck_assert_msg(res < 0, "Failed to handle null ctrl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  ctrl = pr_ctrls_alloc();
  res = pr_ctrls_flush_response(ctrl);
  ck_assert_msg(res == 0, "Failed to flush ctrl with no responses: %s",
    strerror(errno));

  mark_point();
  res = pr_ctrls_add_response(ctrl, "%s", "foo");
  ck_assert_msg(res == 0, "Failed to add ctrl response: %s", strerror(errno));
  res = pr_ctrls_flush_response(ctrl);
  ck_assert_msg(res < 0, "Failed to handle ctrl with no client");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);

  mark_point();
  cl = pcalloc(p, sizeof(pr_ctrls_cl_t));
  cl->cl_fd = devnull_fd();
  if (cl->cl_fd < 0) {
    return;
  }

  ctrl->ctrls_cl = cl;
  res = pr_ctrls_flush_response(ctrl);
  ck_assert_msg(res == 0, "Failed to flush ctrl responses: %s", strerror(errno));

  mark_point();
  (void) close(cl->cl_fd);
  res = pr_ctrls_flush_response(ctrl);
  ck_assert_msg(res < 0, "Failed to handle bad fd");
  ck_assert_msg(errno == EBADF, "Expected EBADF (%d), got %s (%d)", EBADF,
    strerror(errno), errno);
}
END_TEST

START_TEST (ctrls_recv_request_invalid_test) {
  int fd, res;
  uint32_t msglen;
  char *msg = NULL;
  pr_ctrls_cl_t *cl;

  mark_point();
  res = pr_ctrls_recv_request(NULL);
  ck_assert_msg(res < 0, "Failed to handle null client");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  cl = pcalloc(p, sizeof(pr_ctrls_cl_t));
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res < 0, "Failed to handle client without ctrls list");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  cl->cl_ctrls = make_array(p, 0, sizeof(pr_ctrls_t *));
  cl->cl_fd = -1;
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res < 0, "Failed to handle client without fd");
  ck_assert_msg(errno == EBADF, "Expected EBADF (%d), got %s (%d)", EBADF,
    strerror(errno), errno);

  mark_point();
  fd = tmpfile_fd();
  if (fd < 0) {
    return;
  }

  cl->cl_fd = fd;
  (void) close(cl->cl_fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res < 0, "Failed to handle client with bad fd");
  ck_assert_msg(errno == EBADF, "Expected EBADF (%d), got %s (%d)", EBADF,
    strerror(errno), errno);

  mark_point();
  fd = tmpfile_fd();
  if (fd < 0) {
    return;
  }

  cl->cl_fd = fd;
  (void) write(fd, "a", 1);
  rewind_fd(fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res < 0, "Failed to handle invalid msglen (too short)");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);

  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }
  cl->cl_fd = fd;

  mark_point();
  msglen = 2;
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, "a", 1);
  rewind_fd(fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res < 0, "Failed to handle invalid message (too short)");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);

  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }
  cl->cl_fd = fd;

  mark_point();
  msglen = 2;
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, "aa", 2);
  rewind_fd(fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res < 0, "Failed to handle invalid message (wrong format)");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }
  cl->cl_fd = fd;

  mark_point();
  msg = "{}";
  msglen = strlen(msg);
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, msg, msglen);
  rewind_fd(fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res < 0, "Failed to handle invalid message (missing 'action')");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }
  cl->cl_fd = fd;

  mark_point();
  msg = "{\"action\":\"foo\"}";
  msglen = strlen(msg);
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, msg, msglen);
  rewind_fd(fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res < 0, "Failed to handle invalid message (missing 'args')");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }
  cl->cl_fd = fd;

  mark_point();
  msg = "{\"action\":\"test\",\"args\":[1,2,3,4,5,6,7,8,9,10]}";
  msglen = strlen(msg);
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, msg, msglen);
  rewind_fd(fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res < 0, "Failed to handle unknown action");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  (void) close(fd);
}
END_TEST

START_TEST (ctrls_recv_request_too_large_test) {
  int fd, res;
  uint32_t msglen;
  pr_ctrls_cl_t *cl;

  cl = pcalloc(p, sizeof(pr_ctrls_cl_t));
  cl->cl_ctrls = make_array(p, 0, sizeof(pr_ctrls_t *));

  mark_point();
  fd = tmpfile_fd();
  if (fd < 0) {
    return;
  }

  cl->cl_fd = fd;

  mark_point();
  msglen = (uint32_t) -1;
  (void) write(fd, (const void *) &msglen, sizeof(msglen));
  rewind_fd(fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res < 0, "Failed to handle invalid msglen (too long)");
  ck_assert_msg(errno == E2BIG, "Expected E2BIG (%d), got %s (%d)", E2BIG,
    strerror(errno), errno);

  (void) close(fd);
}
END_TEST

START_TEST (ctrls_recv_request_valid_test) {
  int fd, res;
  uint32_t msglen = 0;
  char *msg = NULL;
  const char *action, *desc;
  pr_ctrls_cl_t *cl;
  pr_ctrls_t *ctrl;
  module m;

  mark_point();
  m.name = "test";
  action = "test";
  desc = "desc";
  res = pr_ctrls_register(&m, action, desc, ctrls_test_cb);
  ck_assert_msg(res >= 0, "Failed to register ctrls action: %s", strerror(errno));

  mark_point();
  fd = tmpfile_fd();
  if (fd < 0) {
    return;
  }

  cl = pcalloc(p, sizeof(pr_ctrls_cl_t));
  cl->cl_ctrls = make_array(p, 0, sizeof(pr_ctrls_t *));
  cl->cl_fd = fd;

  msg = "{\"action\":\"test\",\"args\":[]}";
  msglen = strlen(msg);
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, msg, msglen);
  rewind_fd(fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res == 0, "Failed to handle known action: %s", strerror(errno));
  ck_assert_msg(cl->cl_ctrls->nelts == 1, "Expected 1 ctrl, got %d",
    cl->cl_ctrls->nelts);
  ctrl = ((pr_ctrls_t **) cl->cl_ctrls->elts)[0];
  ck_assert_msg(ctrl->ctrls_flags & PR_CTRLS_FL_REQUESTED,
    "Expected PR_CTRLS_FL_REQUESTED flag, got %lu", ctrl->ctrls_flags);
  ck_assert_msg(ctrl->ctrls_cb_args == NULL,
    "Expected no callback args, got %p", ctrl->ctrls_cb_args);

  mark_point();
  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }
  clear_array(cl->cl_ctrls);
  cl->cl_fd = fd;

  msg = "{\"action\":\"test\",\"args\":[\"a\"]}";
  msglen = strlen(msg);
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, msg, msglen);
  rewind_fd(fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res == 0, "Failed to handle known action: %s", strerror(errno));
  ck_assert_msg(cl->cl_ctrls->nelts == 1, "Expected 1 ctrl, got %d",
    cl->cl_ctrls->nelts);
  ctrl = ((pr_ctrls_t **) cl->cl_ctrls->elts)[0];
  ck_assert_msg(ctrl->ctrls_flags & PR_CTRLS_FL_REQUESTED,
    "Expected PR_CTRLS_FL_REQUESTED flag, got %lu", ctrl->ctrls_flags);
  ck_assert_msg(ctrl->ctrls_cb_args != NULL,
    "Expected callback args, got %p", ctrl->ctrls_cb_args);

  mark_point();
  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }
  clear_array(cl->cl_ctrls);
  cl->cl_fd = fd;

  msg = "{\"action\":\"test\",\"args\":[\"next\"]}";
  msglen = strlen(msg);
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, msg, msglen);
  rewind_fd(fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res == 0, "Failed to handle valid request: %s",
    strerror(errno));
  ck_assert_msg(cl->cl_ctrls->nelts == 1, "Expected 1 ctrl, got %d",
    cl->cl_ctrls->nelts);
  ctrl = ((pr_ctrls_t **) cl->cl_ctrls->elts)[0];
  ck_assert_msg(ctrl->ctrls_flags & PR_CTRLS_FL_REQUESTED,
    "Expected PR_CTRLS_FL_REQUESTED flag, got %lu", ctrl->ctrls_flags);
  ck_assert_msg(ctrl->ctrls_cb_args != NULL, "Expected callback args, got NULL");
  ck_assert_msg(ctrl->ctrls_cb_args->nelts == 1,
    "Expected 1 callback arg, got %d", ctrl->ctrls_cb_args->nelts);

  /* next_action present */

  mark_point();
  res = pr_ctrls_register(&m, action, desc, ctrls_test2_cb);
  ck_assert_msg(res >= 0, "Failed to register ctrls action: %s", strerror(errno));

  mark_point();
  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }
  clear_array(cl->cl_ctrls);
  cl->cl_fd = fd;

  msg = "{\"action\":\"test\",\"args\":[\"next\"]}";
  msglen = strlen(msg);
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, msg, msglen);
  rewind_fd(fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res == 0, "Failed to handle valid request: %s",
    strerror(errno));
  ck_assert_msg(cl->cl_ctrls->nelts == 2, "Expected 2 ctrl, got %d",
    cl->cl_ctrls->nelts);

  ctrl = ((pr_ctrls_t **) cl->cl_ctrls->elts)[0];
  ck_assert_msg(ctrl->ctrls_flags & PR_CTRLS_FL_REQUESTED,
    "Expected PR_CTRLS_FL_REQUESTED flag, got %lu", ctrl->ctrls_flags);
  ck_assert_msg(ctrl->ctrls_cb_args != NULL, "Expected callback args, got NULL");
  ck_assert_msg(ctrl->ctrls_cb_args->nelts == 1,
    "Expected 1 callback arg, got %d", ctrl->ctrls_cb_args->nelts);

  ctrl = ((pr_ctrls_t **) cl->cl_ctrls->elts)[1];
  ck_assert_msg(ctrl->ctrls_flags & PR_CTRLS_FL_REQUESTED,
    "Expected PR_CTRLS_FL_REQUESTED flag, got %lu", ctrl->ctrls_flags);
  ck_assert_msg(ctrl->ctrls_cb_args != NULL, "Expected callback args, got NULL");
  ck_assert_msg(ctrl->ctrls_cb_args->nelts == 1,
    "Expected 1 callback arg, got %d", ctrl->ctrls_cb_args->nelts);

  (void) pr_ctrls_unregister(&m, action);
  (void) close(fd);
}
END_TEST

START_TEST (ctrls_recv_response_test) {
  int fd, res, status;
  uint32_t msglen;
  char *msg = NULL;

  mark_point();
  res = pr_ctrls_recv_response(NULL, -1, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null pool");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_recv_response(p, -1, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle invalid fd");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  fd = tmpfile_fd();
  if (fd < 0) {
    return;
  }

  res = pr_ctrls_recv_response(p, fd, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null status");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);
  (void) close(fd);

  mark_point();
  fd = tmpfile_fd();
  if (fd < 0) {
    return;
  }

  (void) write(fd, "a", 1);
  rewind_fd(fd);
  res = pr_ctrls_recv_response(p, fd, &status, NULL);
  ck_assert_msg(res < 0, "Failed to handle invalid msglen (too short)");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);

  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }

  mark_point();
  msglen = 2;
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, "a", 1);
  rewind_fd(fd);
  res = pr_ctrls_recv_response(p, fd, &status, NULL);
  ck_assert_msg(res < 0, "Failed to handle invalid message (too short)");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);

  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }

  mark_point();
  msglen = 2;
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, "aa", 2);
  rewind_fd(fd);
  res = pr_ctrls_recv_response(p, fd, &status, NULL);
  ck_assert_msg(res < 0, "Failed to handle invalid message (wrong format)");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }

  mark_point();
  msg = "{}";
  msglen = strlen(msg);
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, msg, msglen);
  rewind_fd(fd);
  res = pr_ctrls_recv_response(p, fd, &status, NULL);
  ck_assert_msg(res < 0, "Failed to handle invalid message (missing 'status')");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }

  mark_point();
  msg = "{\"status\":0}";
  msglen = strlen(msg);
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, msg, msglen);
  rewind_fd(fd);
  res = pr_ctrls_recv_response(p, fd, &status, NULL);
  ck_assert_msg(res < 0,
    "Failed to handle invalid message (missing 'responses')");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }

  mark_point();
  msg = "{\"status\":0,\"responses\":[1]}";
  msglen = strlen(msg);
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, msg, msglen);
  rewind_fd(fd);
  res = pr_ctrls_recv_response(p, fd, &status, NULL);
  ck_assert_msg(res < 0,
    "Failed to handle invalid message (non-text response)");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  fd = reset_fd(fd);
  if (fd < 0) {
    return;
  }

  mark_point();
  msg = "{\"status\":0,\"responses\":[\"ok\"]}";
  msglen = strlen(msg);
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, msg, msglen);
  rewind_fd(fd);
  res = pr_ctrls_recv_response(p, fd, &status, NULL);
  ck_assert_msg(res == 1, "Failed to handle valid response: %s",
    strerror(errno));

  (void) close(fd);
}
END_TEST

START_TEST (ctrls_recv_response_too_large_test) {
  int fd, res, status;
  uint32_t msglen;

  mark_point();
  fd = tmpfile_fd();
  if (fd < 0) {
    return;
  }

  mark_point();
  msglen = (uint32_t) -1;
  (void) write(fd, (const void *) &msglen, sizeof(msglen));
  rewind_fd(fd);
  res = pr_ctrls_recv_response(p, fd, &status, NULL);
  ck_assert_msg(res < 0, "Failed to handle invalid msglen (too long)");
  ck_assert_msg(errno == E2BIG, "Expected E2BIG (%d), got %s (%d)", E2BIG,
    strerror(errno), errno);

  (void) close(fd);
}
END_TEST

START_TEST (ctrls_issock_unix_test) {
  int res;
  mode_t mode;

  mark_point();
  mode = 0;
  res = pr_ctrls_issock_unix(mode);
  ck_assert_msg(res < 0, "Failed to handle invalid mode");
  ck_assert_msg(errno == ENOSYS, "Expected ENOSYS (%d), got %s (%d)", ENOSYS,
    strerror(errno), errno);

#if defined(S_ISFIFO)
  mark_point();
  mode = 0;
  mode |= S_IFIFO;
  res = pr_ctrls_issock_unix(mode);
  if (res < 0) {
    ck_assert_msg(errno == ENOSYS, "Did not expect ENOSYS (%d)", ENOSYS);
  }
#endif /* S_ISFIFO */

#if defined(S_ISSOCK)
  mark_point();
  mode = 0;
  mode |= S_IFSOCK;
  res = pr_ctrls_issock_unix(mode);
  if (res < 0) {
    ck_assert_msg(errno == ENOSYS, "Did not expect ENOSYS (%d)", ENOSYS);
  }
#endif /* S_ISSOCK */
}
END_TEST

START_TEST (ctrls_get_registered_actions_test) {
  int res;
  pr_ctrls_t *ctrl;
  const char *action, *desc;
  module m;

  mark_point();
  res = pr_get_registered_actions(NULL, 0);
  ck_assert_msg(res < 0, "Failed to handle null ctrl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  ctrl = pr_ctrls_alloc();
  res = pr_get_registered_actions(ctrl, 0);
  ck_assert_msg(res == 0, "Failed to handle lack of registered actions: %s",
    strerror(errno));

  mark_point();
  pr_block_ctrls();
  res = pr_get_registered_actions(ctrl, 0);
  ck_assert_msg(res < 0, "Failed to handle blocked actions");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);
  pr_unblock_ctrls();

  mark_point();
  action = "test";
  desc = "desc";
  res = pr_ctrls_register(NULL, action, desc, ctrls_test_cb);
  ck_assert_msg(res >= 0, "Failed to register ctrls action: %s", strerror(errno));

  m.name = "test";
  res = pr_ctrls_register(&m, action, desc, ctrls_test_cb);
  ck_assert_msg(res >= 0, "Failed to register ctrls action: %s", strerror(errno));

  mark_point();
  res = pr_get_registered_actions(ctrl, 0);
  ck_assert_msg(res == 0, "Failed to handle invalid flags: %s", strerror(errno));

  mark_point();
  res = pr_get_registered_actions(ctrl, CTRLS_GET_ACTION_ALL);
  ck_assert_msg(res == 2, "Failed to handle GET_ACTION_ALL flag: %s",
    strerror(errno));

  mark_point();
  res = pr_get_registered_actions(ctrl, CTRLS_GET_ACTION_ENABLED);
  ck_assert_msg(res == 2, "Failed to handle GET_ACTION_ENABLED flag: %s",
    strerror(errno));

  mark_point();
  res = pr_get_registered_actions(ctrl, CTRLS_GET_DESC);
  ck_assert_msg(res == 2, "Failed to handle GET_DESC flag: %s", strerror(errno));

  mark_point();
  res = pr_ctrls_unregister(NULL, action);
  ck_assert_msg(res == 0, "Failed to unregister ctrls action: %s",
    strerror(errno));
}
END_TEST

START_TEST (ctrls_set_registered_actions_test) {
  int res;
  const char *action, *desc;

  mark_point();
  res = pr_set_registered_actions(NULL, NULL, FALSE, 0);
  ck_assert_msg(res < 0, "Failed to handle no registered actions");
  ck_assert_msg(errno == ENOENT, "Expected ENOENT (%d), got %s (%d)", ENOENT,
    strerror(errno), errno);

  mark_point();
  res = pr_set_registered_actions(NULL, NULL, FALSE, 24);
  ck_assert_msg(res < 0, "Failed to handle invalid flag");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  action = "test";
  desc = "desc";
  res = pr_ctrls_register(NULL, action, desc, ctrls_test_cb);
  ck_assert_msg(res >= 0, "Failed to register ctrls action: %s", strerror(errno));

  mark_point();
  res = pr_set_registered_actions(NULL, NULL, FALSE, 0);
  ck_assert_msg(res == 0, "Failed to handle no registered actions: %s",
    strerror(errno));

  mark_point();
  pr_block_ctrls();
  res = pr_set_registered_actions(NULL, NULL, FALSE, 0);
  ck_assert_msg(res < 0, "Failed to handle blocked actions");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);
  pr_unblock_ctrls();

  mark_point();
  res = pr_set_registered_actions(NULL, action, FALSE, 0);
  ck_assert_msg(res == 0, "Failed to handle action '%s': %s", action,
    strerror(errno));

  mark_point();
  res = pr_set_registered_actions(NULL, "all", FALSE, 0);
  ck_assert_msg(res == 0, "Failed to handle action 'all': %s", strerror(errno));

  mark_point();
  res = pr_ctrls_unregister(NULL, action);
  ck_assert_msg(res == 0, "Failed to unregister ctrls action: %s",
    strerror(errno));
}
END_TEST

START_TEST (ctrls_check_actions_test) {
  int res;
  const char *action, *desc;

  mark_point();
  res = pr_ctrls_check_actions();
  ck_assert_msg(res == 0, "Failed to handle no registered actions: %s",
    strerror(errno));

  mark_point();
  action = "test";
  desc = "desc";
  res = pr_ctrls_register(NULL, action, desc, ctrls_test_cb);
  ck_assert_msg(res >= 0, "Failed to register ctrls action: %s", strerror(errno));

  mark_point();
  res = pr_ctrls_check_actions();
  ck_assert_msg(res == 0, "Failed to handle no registered actions: %s",
    strerror(errno));

  /* Register a duplicate action name, then check. */

  mark_point();
  res = pr_ctrls_register(NULL, action, desc, ctrls_test_cb);
  ck_assert_msg(res >= 0, "Failed to register ctrls action: %s", strerror(errno));

  mark_point();
  res = pr_ctrls_check_actions();
  ck_assert_msg(res == 0, "Failed to handle registered actions: %s",
    strerror(errno));

  mark_point();
  res = pr_set_registered_actions(NULL, action, FALSE, PR_CTRLS_ACT_SOLITARY);
  ck_assert_msg(res == 0, "Failed to set SOLITARY action flag: %s",
    strerror(errno));

  mark_point();
  res = pr_ctrls_check_actions();
  ck_assert_msg(res < 0, "Failed to handle duplicate SOLITARY actions");
  ck_assert_msg(errno == EEXIST, "Expected EEXIST (%d), got %s (%d)", EEXIST,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_unregister(NULL, action);
  ck_assert_msg(res == 0, "Failed to unregister ctrls action: %s",
    strerror(errno));
}
END_TEST

START_TEST (ctrls_run_ctrls_test) {
  int fd, res;
  uint32_t msglen = 0;
  char *msg = NULL;
  const char *action, *desc;
  pr_ctrls_cl_t *cl;
  pr_ctrls_t *ctrl;
  module m, m2;
  time_t now;

  mark_point();
  res = pr_run_ctrls(NULL, NULL);
  ck_assert_msg(res == 0, "Failed to run ctrls: %s", strerror(errno));

  mark_point();
  pr_block_ctrls();
  res = pr_run_ctrls(NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle blocked ctrls");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);
  pr_unblock_ctrls();

  mark_point();
  action = "test";
  desc = "desc";
  m.name = "test";
  m2.name = "test2";
  res = pr_ctrls_register(&m, action, desc, ctrls_test_cb);
  ck_assert_msg(res >= 0, "Failed to register ctrls action: %s", strerror(errno));

  mark_point();
  res = pr_run_ctrls(NULL, NULL);
  ck_assert_msg(res == 0, "Failed to run ctrls: %s", strerror(errno));

  mark_point();
  res = pr_run_ctrls(&m2, NULL);
  ck_assert_msg(res == 0, "Failed to run ctrls: %s", strerror(errno));

  mark_point();
  res = pr_run_ctrls(&m, NULL);
  ck_assert_msg(res == 0, "Failed to run ctrls: %s", strerror(errno));

  /* XXX TODO More test cases to fill in here. */
  /* Note that pr_run_ctrls() makes a lot of assumptions about recv_response,
   * recv_request having been called previously.  Not great.  How to deal
   * with that?
   */

  mark_point();
  fd = tmpfile_fd();
  if (fd < 0) {
    return;
  }

  cl = pcalloc(p, sizeof(pr_ctrls_cl_t));
  cl->cl_ctrls = make_array(p, 0, sizeof(pr_ctrls_t *));
  cl->cl_fd = fd;

  msg = "{\"action\":\"test\",\"args\":[\"FOO\"]}";
  msglen = strlen(msg);
  (void) write(fd, &msglen, sizeof(msglen));
  (void) write(fd, msg, msglen);
  rewind_fd(fd);
  res = pr_ctrls_recv_request(cl);
  ck_assert_msg(res == 0, "Failed to handle known action: %s", strerror(errno));
  ck_assert_msg(cl->cl_ctrls->nelts == 1, "Expected 1 ctrl, got %d",
    cl->cl_ctrls->nelts);
  ctrl = ((pr_ctrls_t **) cl->cl_ctrls->elts)[0];

  mark_point();
  res = pr_run_ctrls(&m2, NULL);
  ck_assert_msg(res == 0, "Failed to run ctrls: %s", strerror(errno));

  mark_point();
  res = pr_run_ctrls(&m, NULL);
  ck_assert_msg(res == 0, "Failed to run ctrls: %s", strerror(errno));

  mark_point();
  cl->cl_flags = PR_CTRLS_CL_HAVEREQ;
  ctrl->ctrls_flags |= PR_CTRLS_ACT_DISABLED;
  res = pr_run_ctrls(&m, NULL);
  ck_assert_msg(res == 0, "Failed to run ctrls: %s", strerror(errno));

  mark_point();
  cl->cl_flags = PR_CTRLS_CL_HAVEREQ;
  ctrl->ctrls_flags &= ~PR_CTRLS_ACT_DISABLED;
  ctrl->ctrls_flags &= ~PR_CTRLS_FL_REQUESTED;
  res = pr_run_ctrls(&m, NULL);
  ck_assert_msg(res == 0, "Failed to run ctrls: %s", strerror(errno));

  mark_point();
  cl->cl_flags = PR_CTRLS_CL_HAVEREQ;
  ctrl->ctrls_flags |= PR_CTRLS_FL_REQUESTED;
  now = time(NULL);
  ctrl->ctrls_when = now + 10;
  res = pr_run_ctrls(&m, NULL);
  ck_assert_msg(res == 0, "Failed to run ctrls: %s", strerror(errno));

  mark_point();
  cl->cl_flags = PR_CTRLS_CL_HAVEREQ;
  ctrl->ctrls_flags &= PR_CTRLS_FL_PENDING;
  ctrl->ctrls_flags |= PR_CTRLS_FL_REQUESTED;
  ctrl->ctrls_when = now - 10;
  res = pr_run_ctrls(&m, "test2");
  ck_assert_msg(res == 0, "Failed to run ctrls: %s", strerror(errno));

  mark_point();
  cl->cl_flags = PR_CTRLS_CL_HAVEREQ;
  ctrl->ctrls_flags |= PR_CTRLS_FL_REQUESTED;
  res = pr_run_ctrls(&m, "test");
  ck_assert_msg(res == 0, "Failed to run ctrls: %s", strerror(errno));

  mark_point();
  res = pr_ctrls_unregister(NULL, action);
  ck_assert_msg(res == 0, "Failed to unregister ctrls action: %s",
    strerror(errno));

  (void) close(fd);
}
END_TEST

START_TEST (ctrls_reset_ctrls_test) {
  int res;
  const char *action, *desc;

  mark_point();
  res = pr_ctrls_reset();
  ck_assert_msg(res == 0, "Failed to reset ctrls: %s", strerror(errno));

  mark_point();
  action = "test";
  desc = "desc";
  res = pr_ctrls_register(NULL, action, desc, ctrls_test_cb);
  ck_assert_msg(res >= 0, "Failed to register ctrls action: %s", strerror(errno));

  mark_point();
  res = pr_ctrls_reset();
  ck_assert_msg(res == 0, "Failed to reset ctrls: %s", strerror(errno));

  mark_point();
  res = pr_ctrls_unregister(NULL, action);
  ck_assert_msg(res == 0, "Failed to unregister ctrls action: %s",
    strerror(errno));
}
END_TEST

START_TEST (ctrls_accept_test) {
  int fd, res;

  mark_point();
  res = pr_ctrls_accept(-1, NULL, NULL, NULL, 0);
  ck_assert_msg(res < 0, "Failed to handle bad fd");
  ck_assert_msg(errno == EBADF, "Expected EBADF (%d), got %s (%d)", EBADF,
    strerror(errno), errno);

  mark_point();
  fd = devnull_fd();
  if (fd < 0) {
    return;
  }

  res = pr_ctrls_accept(fd, NULL, NULL, NULL, 5);
  ck_assert_msg(res < 0, "Failed to handle no clients");
  ck_assert_msg(errno = ENOENT, "Expected ENOENT (%d), got %s (%d)", ENOENT,
    strerror(errno), errno);

  (void) close(fd);
}
END_TEST

START_TEST (ctrls_connect_test) {
  int fd, res;
  const char *socket_path;

  mark_point();
  res = pr_ctrls_connect(NULL);
  ck_assert_msg(res < 0, "Failed to handle null path");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  socket_path = "/tmp/foo.sock";
  res = pr_ctrls_connect(socket_path);
  ck_assert_msg(res < 0, "Failed to handle nonexistent socket path");
  ck_assert_msg(errno == ECONNREFUSED || errno == ENOENT,
    "Expected ECONNREFUSED (%d) or ENOENT (%d), got %s (%d)", ECONNREFUSED,
    ENOENT, strerror(errno), errno);

  mark_point();
  fd = listen_unix(socket_path);
  if (fd < 0) {
    return;
  }

  res = pr_ctrls_connect(socket_path);
  ck_assert_msg(res >= 0, "Failed to connect to local socket: %s",
    strerror(errno));

  (void) close(res);
  (void) close(fd);
  (void) unlink(socket_path);
}
END_TEST

START_TEST (ctrls_check_group_acl_test) {
  int res;
  gid_t gid;
  ctrls_group_acl_t *group_acl;

  mark_point();
  res = pr_ctrls_check_group_acl(0, NULL);
  ck_assert_msg(res < 0, "Failed to handle null acl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  group_acl = pcalloc(p, sizeof(ctrls_group_acl_t));
  res = pr_ctrls_check_group_acl(0, group_acl);
  ck_assert_msg(res == TRUE, "Expected TRUE, got %d", res);

  mark_point();
  group_acl->allow = TRUE;
  res = pr_ctrls_check_group_acl(0, group_acl);
  ck_assert_msg(res == FALSE, "Expected FALSE, got %d", res);

  mark_point();
  group_acl->ngids = 1;
  res = pr_ctrls_check_group_acl(0, group_acl);
  ck_assert_msg(res == group_acl->allow, "Expected %d, got %d",
    group_acl->allow, res);

  group_acl->allow = FALSE;
  res = pr_ctrls_check_group_acl(0, group_acl);
  ck_assert_msg(res == group_acl->allow, "Expected %d, got %d",
    group_acl->allow, res);

  mark_point();
  gid = 1;
  group_acl->allow = TRUE;
  group_acl->gids = palloc(p, sizeof(gid_t) * 2);
  ((gid_t *) group_acl->gids)[0] = gid;
  res = pr_ctrls_check_group_acl(0, group_acl);
  ck_assert_msg(res == FALSE, "Expected FALSE, got %d", res);

  res = pr_ctrls_check_group_acl(gid, group_acl);
  ck_assert_msg(res == TRUE, "Expected TRUE, got %d", res);
}
END_TEST

START_TEST (ctrls_check_user_acl_test) {
  int res;
  uid_t uid;
  ctrls_user_acl_t *user_acl;

  mark_point();
  res = pr_ctrls_check_user_acl(0, NULL);
  ck_assert_msg(res < 0, "Failed to handle null acl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  user_acl = pcalloc(p, sizeof(ctrls_user_acl_t));
  res = pr_ctrls_check_user_acl(0, user_acl);
  ck_assert_msg(res == TRUE, "Expected TRUE, got %d", res);

  mark_point();
  user_acl->allow = TRUE;
  res = pr_ctrls_check_user_acl(0, user_acl);
  ck_assert_msg(res == FALSE, "Expected FALSE, got %d", res);

  mark_point();
  user_acl->nuids = 1;
  res = pr_ctrls_check_user_acl(0, user_acl);
  ck_assert_msg(res == user_acl->allow, "Expected %d, got %d",
    user_acl->allow, res);

  user_acl->allow = FALSE;
  res = pr_ctrls_check_user_acl(0, user_acl);
  ck_assert_msg(res == user_acl->allow, "Expected %d, got %d",
    user_acl->allow, res);

  mark_point();
  uid = 1;
  user_acl->allow = TRUE;
  user_acl->uids = palloc(p, sizeof(uid_t) * 2);
  ((uid_t *) user_acl->uids)[0] = uid;
  res = pr_ctrls_check_user_acl(0, user_acl);
  ck_assert_msg(res == FALSE, "Expected FALSE, got %d", res);

  res = pr_ctrls_check_user_acl(uid, user_acl);
  ck_assert_msg(res == TRUE, "Expected TRUE, got %d", res);
}
END_TEST

START_TEST (ctrls_init_acl_test) {
  int res;
  ctrls_acl_t *acl;

  mark_point();
  res = pr_ctrls_init_acl(NULL);
  ck_assert_msg(res < 0, "Failed to handle null acl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  acl = pcalloc(p, sizeof(ctrls_acl_t));
  res = pr_ctrls_init_acl(acl);
  ck_assert_msg(res == 0, "Failed to init acl: %s", strerror(errno));
}
END_TEST

static int test_action_cb(pr_ctrls_t *ctl, int reqargc, char **reqargv) {
  return 0;
}

START_TEST (ctrls_check_acl_test) {
  int res;
  pr_ctrls_t *ctrl;
  pr_ctrls_cl_t *cl;
  ctrls_acl_t *acl;
  const char *action;
  ctrls_acttab_t acttab[] = {
    { "test", "desc", NULL, test_action_cb },
    { NULL, NULL, NULL, NULL }
  };

  mark_point();
  res = pr_ctrls_check_acl(NULL, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null ctrl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  ctrl = pr_ctrls_alloc();
  res = pr_ctrls_check_acl(ctrl, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle ctrl without client");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  cl = pcalloc(p, sizeof(pr_ctrls_cl_t));
  cl->cl_uid = cl->cl_gid = 1;
  ctrl->ctrls_cl = cl;
  res = pr_ctrls_check_acl(ctrl, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null acttab");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_check_acl(ctrl, acttab, NULL);
  ck_assert_msg(res < 0, "Failed to handle null action");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  action = "foobar";
  res = pr_ctrls_check_acl(ctrl, acttab, action);
  ck_assert_msg(res == TRUE, "Expected TRUE, got %d", res);

  mark_point();
  action = "test";
  res = pr_ctrls_check_acl(ctrl, acttab, action);
  ck_assert_msg(res == FALSE, "Expected FALSE, got %d", res);

  mark_point();
  acl = pcalloc(p, sizeof(ctrls_acl_t));
  res = pr_ctrls_init_acl(acl);
  acttab[0].act_acl = acl;
  res = pr_ctrls_check_acl(ctrl, acttab, action);
  ck_assert_msg(res == FALSE, "Expected FALSE, got %d", res);

  mark_point();
  acl->acl_groups.ngids = 1;
  res = pr_ctrls_check_acl(ctrl, acttab, action);
  ck_assert_msg(res == TRUE, "Expected TRUE, got %d", res);

  acl->acl_users.nuids = 1;
  res = pr_ctrls_check_acl(ctrl, acttab, action);
  ck_assert_msg(res == TRUE, "Expected TRUE, got %d", res);
}
END_TEST

START_TEST (ctrls_parse_acl_test) {
  char **res;
  const char *names;

  mark_point();
  res = pr_ctrls_parse_acl(NULL, NULL);
  ck_assert_msg(res == NULL, "Failed to handle null pool");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_parse_acl(p, NULL);
  ck_assert_msg(res == NULL, "Failed to handle null ACL text");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  names = "foo";
  res = pr_ctrls_parse_acl(p, names);
  ck_assert_msg(res != NULL, "Failed to parse ACL '%s': %s", names,
    strerror(errno));
  ck_assert_msg(strcmp(res[0], "foo") == 0, "Expected 'foo', got '%s'", res[0]);
  ck_assert_msg(res[1] == NULL, "Expected NULL, got %p", res[1]);

  mark_point();
  names = "foo,'Bar',BAZ";
  res = pr_ctrls_parse_acl(p, names);
  ck_assert_msg(res != NULL, "Failed to parse ACL '%s': %s", names,
    strerror(errno));
  ck_assert_msg(strcmp(res[0], "foo") == 0, "Expected 'foo', got '%s'", res[0]);
  ck_assert_msg(strcmp(res[1], "'Bar'") == 0, "Expected 'Bar', got '%s'", res[1]);
  ck_assert_msg(strcmp(res[2], "BAZ") == 0, "Expected 'BAZ', got '%s'", res[2]);
  ck_assert_msg(res[3] == NULL, "Expected NULL, got %p", res[3]);
}
END_TEST

START_TEST (ctrls_set_group_acl_test) {
  int res;
  ctrls_group_acl_t *group_acl;
  const char *allow;
  char *grouplist;

  mark_point();
  res = pr_ctrls_set_group_acl(NULL, NULL, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null pool");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_set_group_acl(p, NULL, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null group_acl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  group_acl = pcalloc(p, sizeof(ctrls_group_acl_t));
  res = pr_ctrls_set_group_acl(p, group_acl, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null allow");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  allow = "allow";
  res = pr_ctrls_set_group_acl(p, group_acl, allow, NULL);
  ck_assert_msg(res < 0, "Failed to handle null grouplist");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  grouplist = "foo,bar,baz,wheel";
  res = pr_ctrls_set_group_acl(p, group_acl, allow, grouplist);
  ck_assert_msg(res == 0, "Failed to set group acl: %s", strerror(errno));
  ck_assert_msg(group_acl->allow == TRUE, "Expected TRUE, got %d",
    group_acl->allow);
  /* Note that we expect zero here, because of name/GID lookup failures. */
  ck_assert_msg(group_acl->ngids == 0, "Expected 0, got %d",
    group_acl->ngids);
  ck_assert_msg(group_acl->gids != NULL, "Got NULL unexpectedly");

  mark_point();
  group_acl = pcalloc(p, sizeof(ctrls_group_acl_t));
  allow = "deny";
  grouplist = "foo,*";
  res = pr_ctrls_set_group_acl(p, group_acl, allow, grouplist);
  ck_assert_msg(res == 0, "Failed to set group acl: %s", strerror(errno));
  ck_assert_msg(group_acl->allow == FALSE, "Expected FALSE, got %d",
    group_acl->allow);
  ck_assert_msg(group_acl->ngids == 1, "Expected 1, got %d",
    group_acl->ngids);
  ck_assert_msg(group_acl->gids == NULL, "Expected NULL, got %p",
    group_acl->gids);
}
END_TEST

START_TEST (ctrls_set_user_acl_test) {
  int res;
  ctrls_user_acl_t *user_acl;
  const char *allow;
  char *userlist;

  mark_point();
  res = pr_ctrls_set_user_acl(NULL, NULL, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null pool");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_set_user_acl(p, NULL, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null user_acl");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  user_acl = pcalloc(p, sizeof(ctrls_user_acl_t));
  res = pr_ctrls_set_user_acl(p, user_acl, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null allow");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  allow = "allow";
  res = pr_ctrls_set_user_acl(p, user_acl, allow, NULL);
  ck_assert_msg(res < 0, "Failed to handle null userlist");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  userlist = "foo,bar,baz,root";
  res = pr_ctrls_set_user_acl(p, user_acl, allow, userlist);
  ck_assert_msg(res == 0, "Failed to set user acl: %s", strerror(errno));
  ck_assert_msg(user_acl->allow == TRUE, "Expected TRUE, got %d",
    user_acl->allow);
  /* Note that we expect zero here, because of name/UID lookup failures. */
  ck_assert_msg(user_acl->nuids == 0, "Expected 0, got %d", user_acl->nuids);
  ck_assert_msg(user_acl->uids != NULL, "Got NULL unexpectedly");

  mark_point();
  user_acl = pcalloc(p, sizeof(ctrls_user_acl_t));
  allow = "deny";
  userlist = "foo,*";
  res = pr_ctrls_set_user_acl(p, user_acl, allow, userlist);
  ck_assert_msg(res == 0, "Failed to set user acl: %s", strerror(errno));
  ck_assert_msg(user_acl->allow == FALSE, "Expected FALSE, got %d",
    user_acl->allow);
  ck_assert_msg(user_acl->nuids == 1, "Expected 1, got %d", user_acl->nuids);
  ck_assert_msg(user_acl->uids == NULL, "Expected NULL, got %p",
    user_acl->uids);
}
END_TEST

START_TEST (ctrls_set_module_acls_test) {
  char *res, *list;
  const char *allow, *type;
  ctrls_acl_t *acl;
  char *good_actions[] = { "test", NULL };
  char *bad_actions[] = { "bar", "baz", NULL };
  char *all_actions[] = { "all", NULL };
  ctrls_acttab_t acttab[] = {
    { "test", "desc", NULL, test_action_cb },
    { NULL, NULL, NULL, NULL }
  };

  mark_point();
  res = pr_ctrls_set_module_acls(NULL, NULL, NULL, NULL, NULL, NULL);
  ck_assert_msg(res == NULL, "Failed to handle null acttab");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_set_module_acls(acttab, NULL, NULL, NULL, NULL, NULL);
  ck_assert_msg(res == NULL, "Failed to handle null acl_pool");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_set_module_acls(acttab, p, NULL, NULL, NULL, NULL);
  ck_assert_msg(res == NULL, "Failed to handle null actions");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_set_module_acls(acttab, p, good_actions, NULL, NULL, NULL);
  ck_assert_msg(res == NULL, "Failed to handle null allow");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  allow = "allow";
  res = pr_ctrls_set_module_acls(acttab, p, good_actions, allow, NULL, NULL);
  ck_assert_msg(res == NULL, "Failed to handle null type");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  type = "test";
  res = pr_ctrls_set_module_acls(acttab, p, good_actions, allow, type, NULL);
  ck_assert_msg(res == NULL, "Failed to handle null list");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  list = "foo,bar,baz";
  res = pr_ctrls_set_module_acls(acttab, p, bad_actions, allow, type, list);
  ck_assert_msg(res == NULL, "Failed to handle invalid type '%s'", type);
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  type = "user";
  res = pr_ctrls_set_module_acls(acttab, p, bad_actions, allow, type, list);
  ck_assert_msg(res != NULL, "Failed to handle invalid action");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);
  ck_assert_msg(strcmp(res, "bar") == 0, "Expected 'bar', got '%s'", res);

  mark_point();
  acl = pcalloc(p, sizeof(ctrls_acl_t));
  ck_assert_msg(pr_ctrls_init_acl(acl) == 0,
    "Failed to initialize acl: %s", strerror(errno));

  acttab[0].act_acl = acl;
  type = "group";
  res = pr_ctrls_set_module_acls(acttab, p, good_actions, allow, type, list);
  ck_assert_msg(res == NULL, "Failed to handle good action: %s", strerror(errno));

  mark_point();
  type = "user";
  res = pr_ctrls_set_module_acls(acttab, p, good_actions, allow, type, list);
  ck_assert_msg(res == NULL, "Failed to handle good action: %s", strerror(errno));

  mark_point();
  res = pr_ctrls_set_module_acls(acttab, p, all_actions, allow, type, list);
  ck_assert_msg(res == NULL, "Failed to handle all actions: %s", strerror(errno));
}
END_TEST

START_TEST (ctrls_set_module_acls2_test) {
  int res;
  char *list;
  const char *allow, *type, *bad_action = NULL;
  ctrls_acl_t *acl;
  char *good_actions[] = { "test", NULL };
  char *bad_actions[] = { "bar", "baz", NULL };
  char *all_actions[] = { "all", NULL };
  ctrls_acttab_t acttab[] = {
    { "test", "desc", NULL, test_action_cb },
    { NULL, NULL, NULL, NULL }
  };

  mark_point();
  res = pr_ctrls_set_module_acls2(NULL, NULL, NULL, NULL, NULL, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null acttab");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_set_module_acls2(acttab, NULL, NULL, NULL, NULL, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null acl_pool");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_set_module_acls2(acttab, p, NULL, NULL, NULL, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null actions");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_set_module_acls2(acttab, p, good_actions, NULL, NULL, NULL,
    NULL);
  ck_assert_msg(res < 0, "Failed to handle null allow");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  allow = "allow";
  res = pr_ctrls_set_module_acls2(acttab, p, good_actions, allow, NULL, NULL,
    NULL);
  ck_assert_msg(res < 0, "Failed to handle null type");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  type = "test";
  res = pr_ctrls_set_module_acls2(acttab, p, good_actions, allow, type, NULL,
    NULL);
  ck_assert_msg(res < 0, "Failed to handle null list");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  list = "foo,bar,baz";
  res = pr_ctrls_set_module_acls2(acttab, p, bad_actions, allow, type, list,
    NULL);
  ck_assert_msg(res < 0, "Failed to handle null bad_action");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_set_module_acls2(acttab, p, bad_actions, allow, type, list,
    &bad_action);
  ck_assert_msg(res < 0, "Failed to handle invalid type '%s'", type);
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  type = "user";
  res = pr_ctrls_set_module_acls2(acttab, p, bad_actions, allow, type, list,
    &bad_action);
  ck_assert_msg(res < 0, "Failed to handle invalid action");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);
  ck_assert_msg(strcmp(bad_action, "bar") == 0,
    "Expected 'bar', got '%s'", bad_action);

  mark_point();
  acl = pcalloc(p, sizeof(ctrls_acl_t));
  ck_assert_msg(pr_ctrls_init_acl(acl) == 0,
    "Failed to initialize acl: %s", strerror(errno));

  acttab[0].act_acl = acl;
  type = "group";
  res = pr_ctrls_set_module_acls2(acttab, p, good_actions, allow, type, list,
    &bad_action);
  ck_assert_msg(res == 0, "Failed to handle good action: %s", strerror(errno));

  mark_point();
  type = "user";
  res = pr_ctrls_set_module_acls2(acttab, p, good_actions, allow, type, list,
    &bad_action);
  ck_assert_msg(res == 0, "Failed to handle good action: %s", strerror(errno));

  mark_point();
  res = pr_ctrls_set_module_acls2(acttab, p, all_actions, allow, type, list,
    &bad_action);
  ck_assert_msg(res == 0, "Failed to handle all actions: %s", strerror(errno));
}
END_TEST

START_TEST (ctrls_unregister_module_actions_test) {
  char *res;
  char *good_actions[] = { "test", NULL };
  char *bad_actions[] = { "bar", "baz", NULL };
  ctrls_acl_t *acl;
  ctrls_acttab_t acttab[] = {
    { "test", "desc", NULL, test_action_cb },
    { NULL, NULL, NULL, NULL }
  };
  module m;

  mark_point();
  res = pr_ctrls_unregister_module_actions(NULL, NULL, NULL);
  ck_assert_msg(res == NULL, "Failed to handle null acttab");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_unregister_module_actions(acttab, NULL, NULL);
  ck_assert_msg(res == NULL, "Failed to handle null actions");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_unregister_module_actions(acttab, good_actions, NULL);
  ck_assert_msg(res == NULL, "Failed to handle null module");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  m.name = "test";
  res = pr_ctrls_unregister_module_actions(acttab, bad_actions, &m);
  ck_assert_msg(res != NULL, "Failed to handle invalid action");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);
  ck_assert_msg(strcmp(res, "bar") == 0, "Expected 'bar', got '%s'", res);

  mark_point();
  acl = pcalloc(p, sizeof(ctrls_acl_t));
  ck_assert_msg(pr_ctrls_init_acl(acl) == 0,
    "Failed to initialize acl: %s", strerror(errno));
  acttab[0].act_acl = acl;
  res = pr_ctrls_unregister_module_actions(acttab, good_actions, &m);
  ck_assert_msg(res == NULL, "Failed to handle valid action: %s",
    strerror(errno));
}
END_TEST

START_TEST (ctrls_unregister_module_actions2_test) {
  int res;
  const char *bad_action = NULL;
  char *good_actions[] = { "test", NULL };
  char *bad_actions[] = { "bar", "baz", NULL };
  ctrls_acl_t *acl;
  ctrls_acttab_t acttab[] = {
    { "test", "desc", NULL, test_action_cb },
    { NULL, NULL, NULL, NULL }
  };
  module m;

  mark_point();
  res = pr_ctrls_unregister_module_actions2(NULL, NULL, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null acttab");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_unregister_module_actions2(acttab, NULL, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null actions");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_unregister_module_actions2(acttab, good_actions, NULL, NULL);
  ck_assert_msg(res < 0, "Failed to handle null module");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  m.name = "test";
  res = pr_ctrls_unregister_module_actions2(acttab, bad_actions, &m, NULL);
  ck_assert_msg(res < 0, "Failed to handle null bad_action");
  ck_assert_msg(errno == EINVAL, "Expected EINVAL (%d), got %s (%d)", EINVAL,
    strerror(errno), errno);

  mark_point();
  res = pr_ctrls_unregister_module_actions2(acttab, bad_actions, &m,
    &bad_action);
  ck_assert_msg(res < 0, "Failed to handle invalid action");
  ck_assert_msg(errno == EPERM, "Expected EPERM (%d), got %s (%d)", EPERM,
    strerror(errno), errno);
  ck_assert_msg(bad_action != NULL, "Expected bad_action, got NULL");
  ck_assert_msg(strcmp(bad_action, "bar") == 0,
    "Expected 'bar', got '%s'", bad_action);

  mark_point();
  acl = pcalloc(p, sizeof(ctrls_acl_t));
  ck_assert_msg(pr_ctrls_init_acl(acl) == 0,
    "Failed to initialize acl: %s", strerror(errno));
  acttab[0].act_acl = acl;
  res = pr_ctrls_unregister_module_actions2(acttab, good_actions, &m,
    &bad_action);
  ck_assert_msg(res == 0, "Failed to handle valid action: %s", strerror(errno));
}
END_TEST

START_TEST (ctrls_set_logfd_test) {
  int fd, res;

  mark_point();
  fd = 0;
  res = pr_ctrls_set_logfd(fd);
  ck_assert_msg(res == 0, "Failed to set ctrls log fd %d: %s", fd,
     strerror(errno));

  mark_point();
  fd = -1;
  res = pr_ctrls_set_logfd(fd);
  ck_assert_msg(res == 0, "Failed to set ctrls log fd %d: %s", fd,
     strerror(errno));
}
END_TEST

START_TEST (ctrls_log_test) {
  int fd, res;

  mark_point();
  fd = -1;
  pr_ctrls_set_logfd(fd);
  res = pr_ctrls_log(NULL, NULL);
  ck_assert_msg(res == 0, "Failed to handle bad logfd: %s", strerror(errno));

  mark_point();
  fd = devnull_fd();
  if (fd < 0) {
    return;
  }

  pr_ctrls_set_logfd(fd);
  res = pr_ctrls_log(NULL, NULL);
  ck_assert_msg(res == 0, "Failed to handle bad module_version: %s",
    strerror(errno));

  mark_point();
  res = pr_ctrls_log("test", NULL);
  ck_assert_msg(res == 0, "Failed to handle null fmt: %s", strerror(errno));

  mark_point();
  res = pr_ctrls_log("test", "%s", "foo bar baz");
  ck_assert_msg(res == 0, "Failed to handle valid fmt: %s", strerror(errno));

  (void) close(fd);
}
END_TEST

#endif /* PR_USE_CTRLS */

Suite *tests_get_ctrls_suite(void) {
  Suite *suite;
  TCase *testcase;

  suite = suite_create("ctrls");
  testcase = tcase_create("base");

#if defined(PR_USE_CTRLS)
  tcase_add_checked_fixture(testcase, set_up, tear_down);

  tcase_add_test(testcase, ctrls_alloc_free_test);
  tcase_add_test(testcase, ctrls_unregister_test);
  tcase_add_test(testcase, ctrls_register_test);
  tcase_add_test(testcase, ctrls_add_arg_test);
  tcase_add_test(testcase, ctrls_add_response_test);
  tcase_add_test(testcase, ctrls_copy_args_test);
  tcase_add_test(testcase, ctrls_copy_resps_test);
  tcase_add_test(testcase, ctrls_send_request_test);
  tcase_add_test(testcase, ctrls_send_response_test);
  tcase_add_test(testcase, ctrls_flush_response_test);
  tcase_add_test(testcase, ctrls_recv_request_invalid_test);
  tcase_add_test(testcase, ctrls_recv_request_too_large_test);
  tcase_add_test(testcase, ctrls_recv_request_valid_test);
  tcase_add_test(testcase, ctrls_recv_response_test);
  tcase_add_test(testcase, ctrls_recv_response_too_large_test);

  tcase_add_test(testcase, ctrls_issock_unix_test);
  tcase_add_test(testcase, ctrls_get_registered_actions_test);
  tcase_add_test(testcase, ctrls_set_registered_actions_test);
  tcase_add_test(testcase, ctrls_check_actions_test);
  tcase_add_test(testcase, ctrls_run_ctrls_test);
  tcase_add_test(testcase, ctrls_reset_ctrls_test);
  tcase_add_test(testcase, ctrls_accept_test);
  tcase_add_test(testcase, ctrls_connect_test);

  /* mod_ctrls */
  tcase_add_test(testcase, ctrls_check_group_acl_test);
  tcase_add_test(testcase, ctrls_check_user_acl_test);
  tcase_add_test(testcase, ctrls_init_acl_test);
  tcase_add_test(testcase, ctrls_check_acl_test);
  tcase_add_test(testcase, ctrls_parse_acl_test);
  tcase_add_test(testcase, ctrls_set_group_acl_test);
  tcase_add_test(testcase, ctrls_set_user_acl_test);
  tcase_add_test(testcase, ctrls_set_module_acls_test);
  tcase_add_test(testcase, ctrls_set_module_acls2_test);
  tcase_add_test(testcase, ctrls_unregister_module_actions_test);
  tcase_add_test(testcase, ctrls_unregister_module_actions2_test);
  tcase_add_test(testcase, ctrls_set_logfd_test);
  tcase_add_test(testcase, ctrls_log_test);
#endif /* PR_USE_CTRLS */

  suite_add_tcase(suite, testcase);
  return suite;
}

proftpd / proftpd / 26127302554

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous