• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

randombit / botan / 26076563351

18 May 2026 04:08PM UTC coverage: 89.334% (+0.02%) from 89.316%
26076563351

push

github

web-flow
Merge pull request #5598 from randombit/jack/x509-nameconstraints-uri-email

Add URI and email name constraint processing

108478 of 121430 relevant lines covered (89.33%)

11163868.82 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.84
/src/tests/test_x509_path.cpp
1
/*
2
* (C) 2006,2011,2012,2014,2015 Jack Lloyd
3
* (C) 2022 René Meusel, Rohde & Schwarz Cybersecurity
4
*
5
* Botan is released under the Simplified BSD License (see license.txt)
6
*/
7

8
#include "tests.h"
9

10
#if defined(BOTAN_HAS_X509_CERTIFICATES)
11
   #include "test_arb_eq.h"
12
   #include <botan/assert.h>
13
   #include <botan/data_src.h>
14
   #include <botan/exceptn.h>
15
   #include <botan/pk_keys.h>
16
   #include <botan/pkcs10.h>
17
   #include <botan/rng.h>
18
   #include <botan/x509_crl.h>
19
   #include <botan/x509_ext.h>
20
   #include <botan/x509path.h>
21
   #include <botan/internal/calendar.h>
22
   #include <botan/internal/filesystem.h>
23
   #include <botan/internal/fmt.h>
24
   #include <botan/internal/parsing.h>
25

26
   #if defined(BOTAN_HAS_ECDSA)
27
      #include <botan/ec_group.h>
28
   #endif
29

30
   #include <algorithm>
31
   #include <fstream>
32
   #include <limits>
33
   #include <map>
34
   #include <string>
35
   #include <vector>
36
#endif
37

38
namespace Botan_Tests {
39

40
namespace {
41

42
#if defined(BOTAN_HAS_X509_CERTIFICATES) && defined(BOTAN_TARGET_OS_HAS_FILESYSTEM)
43

44
[[maybe_unused]] std::map<std::string, std::string> read_results(const std::string& results_file,
10✔
45
                                                                 const char delim = ':') {
46
   std::ifstream in(results_file);
10✔
47
   if(!in.good()) {
10✔
48
      throw Test_Error("Failed reading " + results_file);
×
49
   }
50

51
   std::map<std::string, std::string> m;
10✔
52
   std::string line;
10✔
53
   while(in.good()) {
622✔
54
      std::getline(in, line);
612✔
55
      if(line.empty()) {
612✔
56
         continue;
32✔
57
      }
58
      if(line[0] == '#') {
594✔
59
         continue;
14✔
60
      }
61

62
      std::vector<std::string> parts = Botan::split_on(line, delim);
580✔
63

64
      if(parts.size() != 2) {
580✔
65
         throw Test_Error("Invalid line " + line);
×
66
      }
67

68
      m[parts[0]] = parts[1];
580✔
69
   }
580✔
70

71
   return m;
20✔
72
}
10✔
73

74
   #if defined(BOTAN_HAS_RSA) && defined(BOTAN_HAS_EMSA_PKCS1)
75

76
std::vector<Botan::X509_Certificate> load_cert_file(const std::string& filename) {
80✔
77
   Botan::DataSource_Stream in(filename);
80✔
78

79
   std::vector<Botan::X509_Certificate> certs;
80✔
80
   while(!in.end_of_data()) {
508✔
81
      try {
348✔
82
         certs.emplace_back(in);
348✔
83
      } catch(Botan::Decoding_Error&) {}
80✔
84
   }
85

86
   return certs;
80✔
87
}
80✔
88

89
std::set<Botan::Certificate_Status_Code> flatten(const Botan::CertificatePathStatusCodes& codes) {
4✔
90
   std::set<Botan::Certificate_Status_Code> result;
4✔
91

92
   for(const auto& statuses : codes) {
16✔
93
      result.insert(statuses.begin(), statuses.end());
12✔
94
   }
95

96
   return result;
4✔
97
}
×
98

99
Botan::Path_Validation_Restrictions get_default_restrictions(bool req_revocation_info, bool ocsp_all_intermediates) {
5✔
100
   return Botan::Path_Validation_Restrictions(req_revocation_info, 80 /*some tests use SHA-1*/, ocsp_all_intermediates);
10✔
101
}
102

103
Botan::Path_Validation_Restrictions get_allow_non_self_signed_anchors_restrictions(bool req_revocation_info,
6✔
104
                                                                                   bool ocsp_all_intermediates) {
105
   return Botan::Path_Validation_Restrictions(req_revocation_info,
6✔
106
                                              80, /*some tests use SHA-1*/
107
                                              ocsp_all_intermediates,
108
                                              std::chrono::seconds::zero(),
109
                                              std::make_unique<Botan::Certificate_Store_In_Memory>(),
12✔
110
                                              false,
111
                                              false /* require_self_signed_trust_anchors */);
12✔
112
}
113

114
std::vector<Botan::Path_Validation_Restrictions> restrictions_to_test(bool req_revocation_info,
3✔
115
                                                                      bool ocsp_all_intermediates) {
116
   std::vector<Botan::Path_Validation_Restrictions> restrictions;
3✔
117
   restrictions.emplace_back(get_default_restrictions(req_revocation_info, ocsp_all_intermediates));
3✔
118
   restrictions.emplace_back(
3✔
119
      get_allow_non_self_signed_anchors_restrictions(req_revocation_info, ocsp_all_intermediates));
6✔
120
   return restrictions;
3✔
121
}
×
122

123
class X509test_Path_Validation_Tests final : public Test {
1✔
124
   public:
125
      std::vector<Test::Result> run() override {
1✔
126
         std::vector<Test::Result> results;
1✔
127
         for(const auto& restrictions : restrictions_to_test(false, false)) {
3✔
128
            auto partial_res = run_with_restrictions(restrictions);
2✔
129
            results.insert(results.end(), partial_res.begin(), partial_res.end());
2✔
130
         }
3✔
131
         return results;
1✔
132
      }
×
133

134
   private:
135
      std::vector<Test::Result> run_with_restrictions(const Botan::Path_Validation_Restrictions& restrictions) {
2✔
136
         std::vector<Test::Result> results;
2✔
137

138
         // Test certs generated by https://github.com/yymax/x509test
139
         const Botan::X509_Certificate root(Test::data_file("x509/x509test/root.pem"));
4✔
140
         Botan::Certificate_Store_In_Memory trusted;
2✔
141
         trusted.add_certificate(root);
2✔
142

143
         auto validation_time = Botan::calendar_point(2016, 10, 21, 4, 20, 0).to_std_timepoint();
2✔
144

145
         for(const auto& [filename, expected_result] : read_results(Test::data_file("x509/x509test/expected.txt"))) {
76✔
146
            Test::Result result("X509test path validation");
74✔
147
            result.start_timer();
74✔
148

149
            const std::vector<Botan::X509_Certificate> certs =
74✔
150
               load_cert_file(Test::data_file("x509/x509test/" + filename));
148✔
151

152
            if(certs.empty()) {
74✔
153
               throw Test_Error("Failed to read certs from " + filename);
×
154
            }
155

156
            Botan::Path_Validation_Result path_result = Botan::x509_path_validate(
74✔
157
               certs, restrictions, trusted, "www.tls.test", Botan::Usage_Type::TLS_SERVER_AUTH, validation_time);
74✔
158

159
            if(path_result.successful_validation() && path_result.trust_root() != root) {
74✔
160
               path_result = Botan::Path_Validation_Result(Botan::Certificate_Status_Code::CANNOT_ESTABLISH_TRUST);
×
161
            }
162

163
            result.test_str_eq("test " + filename, path_result.result_string(), expected_result);
148✔
164
            result.test_str_eq("test no warnings string", path_result.warnings_string(), "");
74✔
165
            result.test_is_true("test no warnings", path_result.no_warnings());
74✔
166
            result.end_timer();
74✔
167
            results.push_back(result);
74✔
168
         }
74✔
169

170
         // test softfail
171
         {
2✔
172
            Test::Result result("X509test path validation softfail");
2✔
173
            result.start_timer();
2✔
174

175
            // this certificate must not have a OCSP URL
176
            const std::string filename = "ValidAltName.pem";
2✔
177
            const std::vector<Botan::X509_Certificate> certs =
2✔
178
               load_cert_file(Test::data_file("x509/x509test/" + filename));
4✔
179
            if(certs.empty()) {
2✔
180
               throw Test_Error("Failed to read certs from " + filename);
×
181
            }
182

183
            Botan::Path_Validation_Result path_result =
2✔
184
               Botan::x509_path_validate(certs,
2✔
185
                                         restrictions,
186
                                         trusted,
187
                                         "www.tls.test",
188
                                         Botan::Usage_Type::TLS_SERVER_AUTH,
189
                                         validation_time,
190
                                         /* activate check_ocsp_online */ std::chrono::milliseconds(1000),
2✔
191
                                         {});
2✔
192

193
            if(path_result.successful_validation() && path_result.trust_root() != root) {
2✔
194
               path_result = Botan::Path_Validation_Result(Botan::Certificate_Status_Code::CANNOT_ESTABLISH_TRUST);
×
195
            }
196

197
            // certificate verification succeed even if no OCSP URL (softfail)
198
            result.test_is_true("test success", path_result.successful_validation());
2✔
199
            result.test_str_eq("test " + filename, path_result.result_string(), "Verified");
4✔
200
      #if defined(BOTAN_TARGET_OS_HAS_THREADS) && defined(BOTAN_HAS_HTTP_UTIL)
201
            // if softfail, there is warnings
202
            result.test_is_true("test warnings", !path_result.no_warnings());
2✔
203
            result.test_str_eq("test warnings string", path_result.warnings_string(), "[0] OCSP URL not available");
2✔
204
      #endif
205
            result.end_timer();
2✔
206
            results.push_back(result);
2✔
207
         }
2✔
208

209
         return results;
2✔
210
      }
2✔
211
};
212

213
BOTAN_REGISTER_TEST("x509", "x509_path_x509test", X509test_Path_Validation_Tests);
214

215
class NIST_Path_Validation_Tests final : public Test {
1✔
216
   public:
217
      std::vector<Test::Result> run() override;
218

219
   private:
220
      std::vector<Test::Result> run_with_restrictions(const Botan::Path_Validation_Restrictions& restrictions);
221
};
222

223
std::vector<Test::Result> NIST_Path_Validation_Tests::run() {
1✔
224
   std::vector<Test::Result> results;
1✔
225
   for(const auto& restrictions : restrictions_to_test(true, true)) {
3✔
226
      auto partial_res = run_with_restrictions(restrictions);
2✔
227
      results.insert(results.end(), partial_res.begin(), partial_res.end());
2✔
228
   }
3✔
229
   return results;
1✔
230
}
×
231

232
std::vector<Test::Result> NIST_Path_Validation_Tests::run_with_restrictions(
2✔
233
   const Botan::Path_Validation_Restrictions& restrictions) {
234
   if(Botan::has_filesystem_impl() == false) {
2✔
235
      return {Test::Result::Note("NIST path validation", "Skipping due to missing filesystem access")};
×
236
   }
237

238
   std::vector<Test::Result> results;
2✔
239

240
   /**
241
   * Code to run the X.509v3 processing tests described in "Conformance
242
   *  Testing of Relying Party Client Certificate Path Processing Logic",
243
   *  which is available on NIST's web site.
244
   *
245
   * https://csrc.nist.gov/projects/pki-testing/x-509-path-validation-test-suite
246
   *
247
   * Known Failures/Problems:
248
   *  - Policy extensions are not implemented, so we skip tests #34-#53.
249
   *  - Tests #75 and #76 are skipped as they make use of relatively
250
   *    obscure CRL extensions which are not supported.
251
   */
252
   const std::map<std::string, std::string> expected = read_results(Test::data_file("x509/nist/expected.txt"));
4✔
253

254
   const Botan::X509_Certificate root_cert(Test::data_file("x509/nist/root.crt"));
4✔
255
   const Botan::X509_CRL root_crl(Test::data_file("x509/nist/root.crl"));
4✔
256

257
   const auto validation_time = Botan::calendar_point(2018, 4, 1, 9, 30, 33).to_std_timepoint();
2✔
258

259
   for(const auto& [test_name, expected_result] : expected) {
154✔
260
      Test::Result result("NIST path validation");
152✔
261
      result.start_timer();
152✔
262

263
      try {
152✔
264
         const auto all_files = Test::files_in_data_dir("x509/nist/" + test_name);
152✔
265

266
         Botan::Certificate_Store_In_Memory store;
152✔
267
         store.add_certificate(root_cert);
152✔
268
         store.add_crl(root_crl);
152✔
269

270
         std::vector<Botan::X509_Certificate> end_certs = {
152✔
271
            Botan::X509_Certificate(Test::data_file("x509/nist/" + test_name + "/end.crt"))};
760✔
272

273
         for(const auto& file : all_files) {
798✔
274
            if(file.ends_with(".crt") && file != "end.crt") {
646✔
275
               end_certs.emplace_back(file);
400✔
276
            } else if(file.ends_with(".crl")) {
246✔
277
               Botan::DataSource_Stream in(file, true);
246✔
278
               const Botan::X509_CRL crl(in);
246✔
279
               store.add_crl(crl);
246✔
280
            }
246✔
281
         }
282

283
         const Botan::Path_Validation_Result validation_result = Botan::x509_path_validate(
152✔
284
            end_certs, restrictions, store, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
152✔
285

286
         result.test_str_eq(test_name + " path validation result", validation_result.result_string(), expected_result);
304✔
287
      } catch(std::exception& e) {
152✔
288
         result.test_failure(test_name, e.what());
×
289
      }
×
290

291
      result.end_timer();
152✔
292
      results.push_back(result);
152✔
293
   }
152✔
294

295
   return results;
2✔
296
}
154✔
297

298
BOTAN_REGISTER_TEST("x509", "x509_path_nist", NIST_Path_Validation_Tests);
299

300
class Extended_Path_Validation_Tests final : public Test {
1✔
301
   public:
302
      std::vector<Test::Result> run() override;
303
};
304

305
std::vector<Test::Result> Extended_Path_Validation_Tests::run() {
1✔
306
   if(Botan::has_filesystem_impl() == false) {
1✔
307
      return {Test::Result::Note("Extended x509 path validation", "Skipping due to missing filesystem access")};
×
308
   }
309

310
   std::vector<Test::Result> results;
1✔
311

312
   auto validation_time = Botan::calendar_point(2017, 9, 1, 9, 30, 33).to_std_timepoint();
1✔
313

314
   for(const auto& [test_name, expected_result] : read_results(Test::data_file("x509/extended/expected.txt"))) {
4✔
315
      Test::Result result("Extended X509 path validation");
3✔
316
      result.start_timer();
3✔
317

318
      const auto all_files = Test::files_in_data_dir("x509/extended/" + test_name);
3✔
319

320
      Botan::Certificate_Store_In_Memory store;
3✔
321

322
      for(const auto& file : all_files) {
13✔
323
         if(file.ends_with(".crt") && file != "end.crt") {
10✔
324
            store.add_certificate(Botan::X509_Certificate(file));
10✔
325
         }
326
      }
327

328
      const Botan::X509_Certificate end_user(Test::data_file("x509/extended/" + test_name + "/end.crt"));
9✔
329

330
      const Botan::Path_Validation_Restrictions restrictions;
6✔
331
      const Botan::Path_Validation_Result validation_result =
3✔
332
         Botan::x509_path_validate(end_user, restrictions, store, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
3✔
333

334
      result.test_str_eq(test_name + " path validation result", validation_result.result_string(), expected_result);
6✔
335

336
      result.end_timer();
3✔
337
      results.push_back(result);
3✔
338
   }
3✔
339

340
   return results;
1✔
341
}
1✔
342

343
BOTAN_REGISTER_TEST("x509", "x509_path_extended", Extended_Path_Validation_Tests);
344

345
      #if defined(BOTAN_HAS_PSS)
346

347
class PSS_Path_Validation_Tests : public Test {
1✔
348
   public:
349
      std::vector<Test::Result> run() override;
350
};
351

352
std::vector<Test::Result> PSS_Path_Validation_Tests::run() {
1✔
353
   if(Botan::has_filesystem_impl() == false) {
1✔
354
      return {Test::Result::Note("RSA-PSS X509 signature validation", "Skipping due to missing filesystem access")};
×
355
   }
356

357
   std::vector<Test::Result> results;
1✔
358

359
   const auto validation_times = read_results(Test::data_file("x509/pss_certs/validation_times.txt"));
2✔
360

361
   auto validation_times_iter = validation_times.begin();
1✔
362

363
   for(const auto& [test_name, expected_result] : read_results(Test::data_file("x509/pss_certs/expected.txt"))) {
119✔
364
      Test::Result result("RSA-PSS X509 signature validation");
118✔
365
      result.start_timer();
118✔
366

367
      const auto all_files = Test::files_in_data_dir("x509/pss_certs/" + test_name);
118✔
368

369
      std::optional<Botan::X509_CRL> crl;
118✔
370
      std::optional<Botan::X509_Certificate> end;
118✔
371
      std::optional<Botan::X509_Certificate> root;
118✔
372
      Botan::Certificate_Store_In_Memory store;
118✔
373
      std::optional<Botan::PKCS10_Request> csr;
118✔
374

375
      const auto validation_year = Botan::to_u32bit((validation_times_iter++)->second);
118✔
376

377
      const auto validation_time = Botan::calendar_point(validation_year, 0, 0, 0, 0, 0).to_std_timepoint();
118✔
378

379
      for(const auto& file : all_files) {
345✔
380
         if(file.find("end.crt") != std::string::npos) {
227✔
381
            end = Botan::X509_Certificate(file);
113✔
382
         } else if(file.find("root.crt") != std::string::npos) {
114✔
383
            root = Botan::X509_Certificate(file);
97✔
384
            store.add_certificate(*root);
97✔
385
         } else if(file.ends_with(".crl")) {
17✔
386
            crl = Botan::X509_CRL(file);
6✔
387
         } else if(file.ends_with(".csr")) {
11✔
388
            csr = Botan::PKCS10_Request(file);
5✔
389
         }
390
      }
391

392
      if(end && crl && root) {
118✔
393
         // CRL test
394
         const std::vector<Botan::X509_Certificate> cert_path = {*end, *root};
18✔
395
         const std::vector<std::optional<Botan::X509_CRL>> crls = {crl};
12✔
396
         auto crl_status = Botan::PKIX::check_crl(
6✔
397
            cert_path,
398
            crls,
399
            validation_time);  // alternatively we could just call crl.check_signature( root_pubkey )
6✔
400

401
         result.test_str_eq(test_name + " check_crl result",
6✔
402
                            Botan::Path_Validation_Result::status_string(Botan::PKIX::overall_status(crl_status)),
403
                            expected_result);
404
      } else if(end && root) {
118✔
405
         // CRT chain test
406

407
         const Botan::Path_Validation_Restrictions restrictions(false, 80);  // SHA-1 is used
182✔
408

409
         const Botan::Path_Validation_Result validation_result =
91✔
410
            Botan::x509_path_validate(*end, restrictions, store, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
91✔
411

412
         result.test_str_eq(test_name + " path validation result", validation_result.result_string(), expected_result);
182✔
413
      } else if(end && !root) {
112✔
414
         // CRT self signed test
415
         auto pubkey = end->subject_public_key();
16✔
416
         const bool accept = expected_result == "Verified";
16✔
417
         result.test_bool_eq(test_name + " verify signature", end->check_signature(*pubkey), accept);
32✔
418
      } else if(csr) {
21✔
419
         // PKCS#10 Request test
420
         auto pubkey = csr->subject_public_key();
5✔
421
         const bool accept = expected_result == "Verified";
5✔
422
         result.test_bool_eq(test_name + " verify signature", csr->check_signature(*pubkey), accept);
10✔
423
      }
5✔
424

425
      result.end_timer();
118✔
426
      results.push_back(result);
118✔
427
   }
334✔
428

429
   return results;
1✔
430
}
13✔
431

432
BOTAN_REGISTER_TEST("x509", "x509_path_rsa_pss", PSS_Path_Validation_Tests);
433

434
      #endif
435

436
class Validate_V1Cert_Test final : public Test {
1✔
437
   public:
438
      std::vector<Test::Result> run() override;
439
};
440

441
std::vector<Test::Result> Validate_V1Cert_Test::run() {
1✔
442
   if(Botan::has_filesystem_impl() == false) {
1✔
443
      return {Test::Result::Note("BSI path validation", "Skipping due to missing filesystem access")};
×
444
   }
445

446
   const std::vector<Test::Result> results;
1✔
447

448
   const std::string root_crt = Test::data_file("x509/misc/v1ca/root.pem");
1✔
449
   const std::string int_crt = Test::data_file("x509/misc/v1ca/int.pem");
1✔
450
   const std::string ee_crt = Test::data_file("x509/misc/v1ca/ee.pem");
1✔
451

452
   auto validation_time = Botan::calendar_point(2019, 4, 19, 23, 0, 0).to_std_timepoint();
1✔
453

454
   const Botan::X509_Certificate root(root_crt);
1✔
455
   const Botan::X509_Certificate intermediate(int_crt);
1✔
456
   const Botan::X509_Certificate ee_cert(ee_crt);
1✔
457

458
   Botan::Certificate_Store_In_Memory trusted;
1✔
459
   trusted.add_certificate(root);
1✔
460

461
   const std::vector<Botan::X509_Certificate> chain = {ee_cert, intermediate};
3✔
462

463
   const Botan::Path_Validation_Restrictions restrictions;
2✔
464
   const Botan::Path_Validation_Result validation_result =
1✔
465
      Botan::x509_path_validate(chain, restrictions, trusted, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
1✔
466

467
   Test::Result result("Verifying using v1 certificate");
1✔
468
   result.test_str_eq("Path validation result", validation_result.result_string(), "Verified");
1✔
469

470
   const Botan::Certificate_Store_In_Memory empty;
1✔
471

472
   const std::vector<Botan::X509_Certificate> new_chain = {ee_cert, intermediate, root};
4✔
473

474
   const Botan::Path_Validation_Result validation_result2 =
1✔
475
      Botan::x509_path_validate(new_chain, restrictions, empty, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
1✔
476

477
   result.test_str_eq("Path validation result", validation_result2.result_string(), "Cannot establish trust");
1✔
478

479
   return {result};
2✔
480
}
4✔
481

482
BOTAN_REGISTER_TEST("x509", "x509_v1_ca", Validate_V1Cert_Test);
483

484
class Validate_V2Uid_in_V1_Test final : public Test {
1✔
485
   public:
486
      std::vector<Test::Result> run() override;
487
};
488

489
std::vector<Test::Result> Validate_V2Uid_in_V1_Test::run() {
1✔
490
   if(Botan::has_filesystem_impl() == false) {
1✔
491
      return {Test::Result::Note("Path validation", "Skipping due to missing filesystem access")};
×
492
   }
493

494
   const std::vector<Test::Result> results;
1✔
495

496
   const std::string root_crt = Test::data_file("x509/v2-in-v1/root.pem");
1✔
497
   const std::string int_crt = Test::data_file("x509/v2-in-v1/int.pem");
1✔
498
   const std::string ee_crt = Test::data_file("x509/v2-in-v1/leaf.pem");
1✔
499

500
   auto validation_time = Botan::calendar_point(2020, 1, 1, 1, 0, 0).to_std_timepoint();
1✔
501

502
   const Botan::X509_Certificate root(root_crt);
1✔
503
   const Botan::X509_Certificate intermediate(int_crt);
1✔
504
   const Botan::X509_Certificate ee_cert(ee_crt);
1✔
505

506
   Botan::Certificate_Store_In_Memory trusted;
1✔
507
   trusted.add_certificate(root);
1✔
508

509
   const std::vector<Botan::X509_Certificate> chain = {ee_cert, intermediate};
3✔
510

511
   const Botan::Path_Validation_Restrictions restrictions;
2✔
512
   const Botan::Path_Validation_Result validation_result =
1✔
513
      Botan::x509_path_validate(chain, restrictions, trusted, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
1✔
514

515
   Test::Result result("Verifying v1 certificate using v2 uid fields");
1✔
516
   result.test_is_false("Path validation failed", validation_result.successful_validation());
1✔
517
   result.test_str_eq(
1✔
518
      "Path validation result", validation_result.result_string(), "Encountered v2 identifiers in v1 certificate");
1✔
519

520
   return {result};
2✔
521
}
3✔
522

523
BOTAN_REGISTER_TEST("x509", "x509_v2uid_in_v1", Validate_V2Uid_in_V1_Test);
524

525
class Validate_NoRevAvail_Test final : public Test {
1✔
526
   public:
527
      std::vector<Test::Result> run() override;
528
};
529

530
std::vector<Test::Result> Validate_NoRevAvail_Test::run() {
1✔
531
   if(Botan::has_filesystem_impl() == false) {
1✔
532
      return {Test::Result::Note("Path validation", "Skipping due to missing filesystem access")};
×
533
   }
534

535
   const std::string root_crt = Test::data_file("x509/short_lived/root.pem");
1✔
536
   const std::string int_crt = Test::data_file("x509/short_lived/int.pem");
1✔
537
   const std::string ee_crt = Test::data_file("x509/short_lived/leaf.pem");
1✔
538

539
   // Leaf is valid Mar 23 12:02:41 - Mar 24 12:02:40 2026 UTC
540
   auto validation_time = Botan::calendar_point(2026, 3, 23, 13, 0, 0).to_std_timepoint();
1✔
541

542
   const Botan::X509_Certificate root(root_crt);
1✔
543
   const Botan::X509_Certificate intermediate(int_crt);
1✔
544
   const Botan::X509_Certificate ee_cert(ee_crt);
1✔
545

546
   Botan::Certificate_Store_In_Memory trusted;
1✔
547
   trusted.add_certificate(root);
1✔
548

549
   const std::vector<Botan::X509_Certificate> chain = {ee_cert, intermediate};
3✔
550

551
   Test::Result result("RFC 9608 noRevAvail extension");
1✔
552

553
   const auto* nra = ee_cert.v3_extensions().get_extension_object_as<Botan::Cert_Extension::NoRevocationAvailable>();
2✔
554
   result.test_not_null("leaf cert has noRevAvail extension", nra);
1✔
555
   result.test_is_true(
3✔
556
      "noRevAvail is not critical",
557
      !ee_cert.v3_extensions().critical_extension_set(Botan::Cert_Extension::NoRevocationAvailable::static_oid()));
2✔
558

559
   const Botan::Path_Validation_Restrictions default_restrictions;
2✔
560
   const Botan::Path_Validation_Result default_result = Botan::x509_path_validate(
1✔
561
      chain, default_restrictions, trusted, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
1✔
562

563
   result.test_is_true("Default path validation succeeds", default_result.successful_validation());
1✔
564

565
   // require_revocation_information=true: still passes because noRevAvail says to skip the check
566
   const Botan::Path_Validation_Restrictions require_rev_restrictions(true);
2✔
567
   const Botan::Path_Validation_Result require_rev_result = Botan::x509_path_validate(
1✔
568
      chain, require_rev_restrictions, trusted, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
1✔
569

570
   result.test_is_true("Path validation skips revocation when noRevAvail present",
1✔
571
                       require_rev_result.successful_validation());
1✔
572
   result.test_str_eq("Path validation result", require_rev_result.result_string(), "Verified");
1✔
573

574
   return {result};
2✔
575
}
3✔
576

577
BOTAN_REGISTER_TEST("x509", "x509_no_rev_avail", Validate_NoRevAvail_Test);
578

579
class Validate_Name_Constraint_CaseInsensitive final : public Test {
1✔
580
   public:
581
      std::vector<Test::Result> run() override;
582
};
583

584
std::vector<Test::Result> Validate_Name_Constraint_CaseInsensitive::run() {
1✔
585
   if(Botan::has_filesystem_impl() == false) {
1✔
586
      return {Test::Result::Note("Path validation", "Skipping due to missing filesystem access")};
×
587
   }
588

589
   const std::vector<Test::Result> results;
1✔
590

591
   const std::string root_crt = Test::data_file("x509/misc/name_constraint_ci/root.pem");
1✔
592
   const std::string int_crt = Test::data_file("x509/misc/name_constraint_ci/int.pem");
1✔
593
   const std::string ee_crt = Test::data_file("x509/misc/name_constraint_ci/leaf.pem");
1✔
594

595
   auto validation_time = Botan::calendar_point(2021, 5, 8, 1, 0, 0).to_std_timepoint();
1✔
596

597
   const Botan::X509_Certificate root(root_crt);
1✔
598
   const Botan::X509_Certificate intermediate(int_crt);
1✔
599
   const Botan::X509_Certificate ee_cert(ee_crt);
1✔
600

601
   Botan::Certificate_Store_In_Memory trusted;
1✔
602
   trusted.add_certificate(root);
1✔
603

604
   const std::vector<Botan::X509_Certificate> chain = {ee_cert, intermediate};
3✔
605

606
   const Botan::Path_Validation_Restrictions restrictions;
2✔
607
   const Botan::Path_Validation_Result validation_result =
1✔
608
      Botan::x509_path_validate(chain, restrictions, trusted, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
1✔
609

610
   Test::Result result("DNS name constraints are case insensitive");
1✔
611
   result.test_is_true("Path validation succeeded", validation_result.successful_validation());
1✔
612

613
   return {result};
2✔
614
}
3✔
615

616
BOTAN_REGISTER_TEST("x509", "x509_name_constraint_ci", Validate_Name_Constraint_CaseInsensitive);
617

618
class Validate_Name_Constraint_NoCheckSelf final : public Test {
1✔
619
   public:
620
      std::vector<Test::Result> run() override;
621
};
622

623
std::vector<Test::Result> Validate_Name_Constraint_NoCheckSelf::run() {
1✔
624
   if(Botan::has_filesystem_impl() == false) {
1✔
625
      return {Test::Result::Note("Path validation", "Skipping due to missing filesystem access")};
×
626
   }
627

628
   const std::vector<Test::Result> results;
1✔
629

630
   const std::string root_crt = Test::data_file("x509/misc/nc_skip_self/root.pem");
1✔
631
   const std::string int_crt = Test::data_file("x509/misc/nc_skip_self/int.pem");
1✔
632
   const std::string ee_crt = Test::data_file("x509/misc/nc_skip_self/leaf.pem");
1✔
633

634
   auto validation_time = Botan::calendar_point(2021, 5, 8, 1, 0, 0).to_std_timepoint();
1✔
635

636
   const Botan::X509_Certificate root(root_crt);
1✔
637
   const Botan::X509_Certificate intermediate(int_crt);
1✔
638
   const Botan::X509_Certificate ee_cert(ee_crt);
1✔
639

640
   Botan::Certificate_Store_In_Memory trusted;
1✔
641
   trusted.add_certificate(root);
1✔
642

643
   const std::vector<Botan::X509_Certificate> chain = {ee_cert, intermediate};
3✔
644

645
   const Botan::Path_Validation_Restrictions restrictions;
2✔
646
   const Botan::Path_Validation_Result validation_result =
1✔
647
      Botan::x509_path_validate(chain, restrictions, trusted, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
1✔
648

649
   Test::Result result("Name constraints do not apply to the certificate which includes them");
1✔
650
   result.test_is_true("Path validation succeeded", validation_result.successful_validation());
1✔
651

652
   return {result};
2✔
653
}
3✔
654

655
BOTAN_REGISTER_TEST("x509", "x509_name_constraint_no_check_self", Validate_Name_Constraint_NoCheckSelf);
656

657
class Root_Cert_Time_Check_Test final : public Test {
1✔
658
   public:
659
      std::vector<Test::Result> run() override {
1✔
660
         if(Botan::has_filesystem_impl() == false) {
1✔
661
            return {Test::Result::Note("Path validation", "Skipping due to missing filesystem access")};
×
662
         }
663

664
         const std::string trusted_root_crt = Test::data_file("x509/misc/root_cert_time_check/root.crt");
1✔
665
         const std::string leaf_crt = Test::data_file("x509/misc/root_cert_time_check/leaf.crt");
1✔
666

667
         const Botan::X509_Certificate trusted_root_cert(trusted_root_crt);
1✔
668
         const Botan::X509_Certificate leaf_cert(leaf_crt);
1✔
669

670
         Botan::Certificate_Store_In_Memory trusted;
1✔
671
         trusted.add_certificate(trusted_root_cert);
1✔
672

673
         const std::vector<Botan::X509_Certificate> chain = {leaf_cert};
2✔
674

675
         Test::Result result("Root cert time check");
1✔
676

677
         auto assert_path_validation_result = [&](std::string_view descr,
11✔
678
                                                  bool ignore_trusted_root_time_range,
679
                                                  uint32_t year,
680
                                                  Botan::Certificate_Status_Code exp_status,
681
                                                  std::optional<Botan::Certificate_Status_Code> exp_warning =
682
                                                     std::nullopt) {
683
            const Botan::Path_Validation_Restrictions restrictions(
10✔
684
               false,
685
               110,
686
               false,
687
               std::chrono::seconds::zero(),
688
               std::make_unique<Botan::Certificate_Store_In_Memory>(),
20✔
689
               ignore_trusted_root_time_range);
20✔
690

691
            const Botan::Path_Validation_Result validation_result =
10✔
692
               Botan::x509_path_validate(chain,
10✔
693
                                         restrictions,
694
                                         trusted,
10✔
695
                                         "",
696
                                         Botan::Usage_Type::UNSPECIFIED,
697
                                         Botan::calendar_point(year, 1, 1, 1, 0, 0).to_std_timepoint());
10✔
698
            const std::string descr_str = Botan::fmt(
10✔
699
               "Root cert validity range {}: {}", ignore_trusted_root_time_range ? "ignored" : "checked", descr);
15✔
700

701
            result.test_enum_eq(descr_str, validation_result.result(), exp_status);
10✔
702
            const auto warnings = validation_result.warnings();
10✔
703
            BOTAN_ASSERT_NOMSG(warnings.size() == 2);
10✔
704
            result.test_is_true("No warning for leaf cert", warnings.at(0).empty());
10✔
705
            if(exp_warning) {
10✔
706
               result.test_is_true("Warning for root cert",
8✔
707
                                   warnings.at(1).size() == 1 && warnings.at(1).contains(*exp_warning));
8✔
708
            } else {
709
               result.test_is_true("No warning for root cert", warnings.at(1).empty());
6✔
710
            }
711
         };
10✔
712
         // (Trusted) root cert validity range: 2022-2028
713
         // Leaf cert validity range: 2020-2030
714

715
         // Trusted root time range is checked
716
         assert_path_validation_result(
1✔
717
            "Root and leaf certs in validity range", false, 2025, Botan::Certificate_Status_Code::OK);
718
         assert_path_validation_result(
1✔
719
            "Root and leaf certs are expired", false, 2031, Botan::Certificate_Status_Code::CERT_HAS_EXPIRED);
720
         assert_path_validation_result(
1✔
721
            "Root and leaf certs are not yet valid", false, 2019, Botan::Certificate_Status_Code::CERT_NOT_YET_VALID);
722
         assert_path_validation_result(
1✔
723
            "Root cert is expired, leaf cert not", false, 2029, Botan::Certificate_Status_Code::CERT_HAS_EXPIRED);
724
         assert_path_validation_result("Root cert is not yet valid, leaf cert is",
1✔
725
                                       false,
726
                                       2021,
727
                                       Botan::Certificate_Status_Code::CERT_NOT_YET_VALID);
728

729
         // Trusted root time range is ignored
730
         assert_path_validation_result(
1✔
731
            "Root and leaf certs in validity range", true, 2025, Botan::Certificate_Status_Code::OK);
732
         assert_path_validation_result("Root and leaf certs are expired",
2✔
733
                                       true,
734
                                       2031,
735
                                       Botan::Certificate_Status_Code::CERT_HAS_EXPIRED,
736
                                       Botan::Certificate_Status_Code::TRUSTED_CERT_HAS_EXPIRED);
1✔
737
         assert_path_validation_result("Root and leaf certs are not yet valid",
2✔
738
                                       true,
739
                                       2019,
740
                                       Botan::Certificate_Status_Code::CERT_NOT_YET_VALID,
741
                                       Botan::Certificate_Status_Code::TRUSTED_CERT_NOT_YET_VALID);
1✔
742
         assert_path_validation_result("Root cert is expired, leaf cert not",
2✔
743
                                       true,
744
                                       2029,
745
                                       Botan::Certificate_Status_Code::OK,
746
                                       Botan::Certificate_Status_Code::TRUSTED_CERT_HAS_EXPIRED);
1✔
747
         assert_path_validation_result("Root cert is not yet valid, leaf cert is",
2✔
748
                                       true,
749
                                       2021,
750
                                       Botan::Certificate_Status_Code::OK,
751
                                       Botan::Certificate_Status_Code::TRUSTED_CERT_NOT_YET_VALID);
1✔
752

753
         return {result};
2✔
754
      }
3✔
755
};
756

757
BOTAN_REGISTER_TEST("x509", "x509_root_cert_time_check", Root_Cert_Time_Check_Test);
758

759
class Non_Self_Signed_Trust_Anchors_Test final : public Test {
1✔
760
   private:
761
      using Cert_Path = std::vector<Botan::X509_Certificate>;
762

763
      std::vector<Botan::X509_Certificate> get_valid_cert_chain() {
4✔
764
         // Test certs generated by https://github.com/yymax/x509test
765
         const std::string valid_chain_pem = "x509/x509test/ValidChained.pem";
4✔
766
         auto certs = load_cert_file(Test::data_file(valid_chain_pem));
4✔
767
         if(certs.size() != 5) {
4✔
768
            throw Test_Error(Botan::fmt("Failed to read all certs from {}", valid_chain_pem));
×
769
         }
770
         return certs;
4✔
771
      }
4✔
772

773
      /// Time point fits for all certificates used in this class
774
      std::chrono::system_clock::time_point get_validation_time() {
8✔
775
         return Botan::calendar_point(2016, 10, 21, 4, 20, 0).to_std_timepoint();
16✔
776
      }
777

778
      Botan::X509_Certificate get_self_signed_ee_cert() {
1✔
779
         const std::string valid_chain_pem = "x509/misc/self-signed-end-entity.pem";
1✔
780
         return Botan::X509_Certificate(Test::data_file(valid_chain_pem));
2✔
781
      }
1✔
782

783
      std::vector<Test::Result> path_validate_test() {
1✔
784
         std::vector<Test::Result> results;
1✔
785

786
         const auto restrictions = get_allow_non_self_signed_anchors_restrictions(false, false);
1✔
787
         const auto certs = get_valid_cert_chain();
1✔
788
         const auto validation_time = get_validation_time();
1✔
789

790
         const std::vector<std::tuple<std::string_view, Cert_Path, Botan::X509_Certificate>>
1✔
791
            info_w_end_certs_w_trust_anchor{
792
               {"length 1", Cert_Path{certs.at(0)}, certs.at(0)},
4✔
793
               {"length 2", Cert_Path{certs.at(0), certs.at(1)}, certs.at(1)},
5✔
794
               {"length 3 (store not in chain)", Cert_Path{certs.at(0), certs.at(1)}, certs.at(2)},
5✔
795
               {"length 4 (shuffled)", Cert_Path{certs.at(0), certs.at(3), certs.at(2), certs.at(1)}, certs.at(3)},
7✔
796
               {"full", Cert_Path{certs.at(0), certs.at(1), certs.at(2), certs.at(3), certs.at(4)}, certs.at(4)},
8✔
797
            };
6✔
798

799
         for(const auto& [info, end_certs, trust_anchor] : info_w_end_certs_w_trust_anchor) {
6✔
800
            Test::Result result(
5✔
801
               Botan::fmt("Non-self-signed trust anchor without require_self_signed_trust_anchors ({})", info));
5✔
802

803
            const Botan::Certificate_Store_In_Memory trusted(trust_anchor);
5✔
804

805
            auto path_result = Botan::x509_path_validate(
5✔
806
               end_certs, restrictions, trusted, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
5✔
807

808
            if(path_result.successful_validation() && path_result.trust_root() != trust_anchor) {
5✔
809
               path_result = Botan::Path_Validation_Result(Botan::Certificate_Status_Code::CANNOT_ESTABLISH_TRUST);
×
810
            }
811

812
            result.test_str_eq(
5✔
813
               "path validation failed", path_result.result_string(), to_string(Botan::Certificate_Status_Code::OK));
5✔
814

815
            results.push_back(result);
5✔
816
         }
5✔
817
         return results;
1✔
818
      }
7✔
819

820
      std::vector<Test::Result> build_path_test() {
1✔
821
         std::vector<Test::Result> results;
1✔
822

823
         const auto restrictions = get_allow_non_self_signed_anchors_restrictions(false, false);
1✔
824
         const auto certs = get_valid_cert_chain();
1✔
825

826
         // Helper to create a cert path {certs[0],...,certs[last_cert]}
827
         const auto path_to = [&](size_t last_cert) -> Cert_Path {
20✔
828
            BOTAN_ASSERT_NOMSG(last_cert <= certs.size());
19✔
829
            return {certs.begin(), certs.begin() + last_cert + 1};
19✔
830
         };
1✔
831

832
         // Helper to create a cert store of all certificates in certs given by their indices
833
         const auto store_of = [&](auto... cert_indices) -> Botan::Certificate_Store_In_Memory {
6✔
834
            Botan::Certificate_Store_In_Memory cert_store;
5✔
835
            (cert_store.add_certificate(certs.at(cert_indices)), ...);
5✔
836
            return cert_store;
5✔
837
         };
1✔
838

839
         const std::vector<std::tuple<std::string, Botan::Certificate_Store_In_Memory, std::vector<Cert_Path>>>
1✔
840
            test_names_with_stores_with_expected_paths{
841
               {"root in store", store_of(4), std::vector<Cert_Path>{path_to(4)}},
4✔
842
               {"intermediate in store", store_of(2), std::vector<Cert_Path>{path_to(2)}},
3✔
843
               {"leaf in store", store_of(0), std::vector<Cert_Path>{path_to(0)}},
3✔
844
               {"leaf, intermediate, and root in store",
845
                store_of(0, 1, 4),
1✔
846
                std::vector<Cert_Path>{path_to(0), path_to(1), path_to(4)}},
5✔
847
               {"all in store",
848
                store_of(0, 1, 2, 3, 4),
1✔
849
                std::vector<Cert_Path>{path_to(0), path_to(1), path_to(2), path_to(3), path_to(4)}},
7✔
850
            };
6✔
851

852
         for(auto [test_name, cert_store, expected_paths] : test_names_with_stores_with_expected_paths) {
6✔
853
            Test::Result result(Botan::fmt("Build certificate paths ({})", test_name));
5✔
854

855
            std::vector<Cert_Path> cert_paths;
5✔
856
            const auto build_all_res =
5✔
857
               Botan::PKIX::build_all_certificate_paths(cert_paths, {&cert_store}, certs.at(0), certs);
5✔
858
            result.test_str_eq("build_all_certificate_paths result",
5✔
859
                               to_string(build_all_res),
860
                               to_string(Botan::Certificate_Status_Code::OK));
861
            test_arb_eq(result, "build_all_certificate_paths paths", cert_paths, expected_paths);
5✔
862

863
            Cert_Path cert_path;
5✔
864
            const auto build_path_res =
5✔
865
               Botan::PKIX::build_certificate_path(cert_path, {&cert_store}, certs.at(0), certs);
5✔
866
            result.test_str_eq("build_certificate_path result",
5✔
867
                               to_string(build_path_res),
868
                               to_string(Botan::Certificate_Status_Code::OK));
869

870
            if(std::ranges::find(cert_paths, path_to(4)) != cert_paths.end()) {
10✔
871
               test_arb_eq(result, "build_certificate_path (with self-signed anchor)", cert_path, path_to(4));
3✔
872
            } else {
873
               test_arb_eq(
2✔
874
                  result, "build_certificate_path (without self-signed anchor)", cert_path, expected_paths.at(0));
2✔
875
            }
876
            results.push_back(result);
5✔
877
         }
5✔
878

879
         return results;
1✔
880
      }
7✔
881

882
      std::vector<Test::Result> forbidden_self_signed_trust_anchors_test() {
1✔
883
         const auto restrictions = get_default_restrictions(false, false);  // non-self-signed anchors are forbidden
1✔
884
         const auto certs = get_valid_cert_chain();
1✔
885
         const auto validation_time = get_validation_time();
1✔
886

887
         Botan::Certificate_Store_In_Memory cert_store(certs.at(3));
1✔
888

889
         Test::Result result("Build certificate paths with only non-self-signed trust anchors (forbidden)");
1✔
890

891
         const auto path_result = Botan::x509_path_validate(
1✔
892
            certs, restrictions, {&cert_store}, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
2✔
893

894
         result.test_str_eq("unexpected path validation result",
1✔
895
                            path_result.result_string(),
1✔
896
                            to_string(Botan::Certificate_Status_Code::CANNOT_ESTABLISH_TRUST));
897

898
         const auto check_chain_result = Botan::PKIX::check_chain(
5✔
899
            {certs.at(0), certs.at(1), certs.at(2)}, validation_time, "", Botan::Usage_Type::UNSPECIFIED, restrictions);
4✔
900

901
         result.test_str_ne("unexpected check_chain result",
2✔
902
                            Botan::Path_Validation_Result(check_chain_result, {}).result_string(),
2✔
903
                            to_string(Botan::Certificate_Status_Code::OK));
904

905
         return {result};
3✔
906
      }
3✔
907

908
      Test::Result stand_alone_root_test(std::string_view test_name,
6✔
909
                                         const Botan::Path_Validation_Restrictions& restrictions,
910
                                         const Botan::X509_Certificate& standalone_cert,
911
                                         Botan::Certificate_Status_Code expected_result) {
912
         Test::Result result(test_name);
6✔
913

914
         const auto validation_time = get_validation_time();
6✔
915
         Botan::Certificate_Store_In_Memory cert_store(standalone_cert);
6✔
916

917
         const auto path_result = Botan::x509_path_validate(
6✔
918
            standalone_cert, restrictions, {&cert_store}, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
12✔
919

920
         if(path_result.result() == Botan::Certificate_Status_Code::CERT_PUBKEY_INVALID) {
6✔
921
            result.test_note("CERT_PUBKEY_INVALID encountered - was that key type disabled at build time?");
×
922
         } else {
923
            result.test_str_eq(
6✔
924
               "unexpected x509_path_validate result", path_result.result_string(), to_string(expected_result));
12✔
925
         }
926

927
         return result;
6✔
928
      }
6✔
929

930
      std::vector<Test::Result> stand_alone_root_tests() {
1✔
931
         const auto self_signed_trust_anchor_forbidden = get_default_restrictions(false, false);
1✔
932
         const auto self_signed_trust_anchor_allowed = get_allow_non_self_signed_anchors_restrictions(false, false);
1✔
933

934
         const auto cert_chain = get_valid_cert_chain();
1✔
935
         const auto& self_signed_root = cert_chain.at(4);
1✔
936
         const auto& ica = cert_chain.at(3);
1✔
937
         const auto& self_signed_ee = get_self_signed_ee_cert();
1✔
938

939
         return {
1✔
940
            stand_alone_root_test("Standalone self-signed root (non-self-signed trust anchors forbidden)",
941
                                  self_signed_trust_anchor_forbidden,
942
                                  self_signed_root,
943
                                  Botan::Certificate_Status_Code::OK),
944
            stand_alone_root_test("Standalone self-signed root (non-self-signed trust anchors allowed)",
945
                                  self_signed_trust_anchor_allowed,
946
                                  self_signed_root,
947
                                  Botan::Certificate_Status_Code::OK),
948

949
            stand_alone_root_test("Standalone self-signed end entity (non-self-signed trust anchors forbidden)",
950
                                  self_signed_trust_anchor_forbidden,
951
                                  self_signed_ee,
952
                                  Botan::Certificate_Status_Code::OK),
953
            stand_alone_root_test("Standalone self-signed end entity (non-self-signed trust anchors allowed)",
954
                                  self_signed_trust_anchor_allowed,
955
                                  self_signed_ee,
956
                                  Botan::Certificate_Status_Code::OK),
957

958
            stand_alone_root_test("Standalone intermediate certificate (non-self-signed trust anchors forbidden)",
959
                                  self_signed_trust_anchor_forbidden,
960
                                  ica,
961
                                  Botan::Certificate_Status_Code::CANNOT_ESTABLISH_TRUST),
962
            stand_alone_root_test("Standalone intermediate certificate (non-self-signed trust anchors allowed)",
963
                                  self_signed_trust_anchor_allowed,
964
                                  ica,
965
                                  Botan::Certificate_Status_Code::OK),
966
         };
8✔
967
      }
2✔
968

969
   public:
970
      std::vector<Test::Result> run() override {
1✔
971
         std::vector<Test::Result> results;
1✔
972

973
         auto res = path_validate_test();
1✔
974
         results.insert(results.end(), res.begin(), res.end());
1✔
975

976
         res = build_path_test();
1✔
977
         results.insert(results.end(), res.begin(), res.end());
1✔
978

979
         res = forbidden_self_signed_trust_anchors_test();
1✔
980
         results.insert(results.end(), res.begin(), res.end());
1✔
981

982
         res = stand_alone_root_tests();
1✔
983
         results.insert(results.end(), res.begin(), res.end());
1✔
984

985
         return results;
1✔
986
      }
1✔
987
};
988

989
BOTAN_REGISTER_TEST("x509", "x509_non_self_signed_trust_anchors", Non_Self_Signed_Trust_Anchors_Test);
990

991
class BSI_Path_Validation_Tests final : public Test
1✔
992

993
{
994
   public:
995
      std::vector<Test::Result> run() override;
996

997
   private:
998
      std::vector<Test::Result> run_with_restrictions(const Botan::Path_Validation_Restrictions& restrictions);
999
};
1000

1001
std::vector<Test::Result> BSI_Path_Validation_Tests::run() {
1✔
1002
   std::vector<Test::Result> results;
1✔
1003
   for(const auto& restrictions : restrictions_to_test(false, false)) {
3✔
1004
      auto partial_res = run_with_restrictions(restrictions);
2✔
1005
      results.insert(results.end(), partial_res.begin(), partial_res.end());
2✔
1006
   }
3✔
1007
   return results;
1✔
1008
}
×
1009

1010
std::vector<Test::Result> BSI_Path_Validation_Tests::run_with_restrictions(
2✔
1011
   const Botan::Path_Validation_Restrictions& restriction_template) {
1012
   if(Botan::has_filesystem_impl() == false) {
2✔
1013
      return {Test::Result::Note("BSI path validation", "Skipping due to missing filesystem access")};
×
1014
   }
1015

1016
   std::vector<Test::Result> results;
2✔
1017

1018
   for(const auto& [test_name, expected_result] : read_results(Test::data_file("x509/bsi/expected.txt"), '$')) {
110✔
1019
      Test::Result result("BSI path validation");
108✔
1020
      result.start_timer();
108✔
1021

1022
      const auto all_files = Test::files_in_data_dir("x509/bsi/" + test_name);
108✔
1023

1024
      Botan::Certificate_Store_In_Memory trusted;
108✔
1025
      std::vector<Botan::X509_Certificate> certs;
108✔
1026

1027
      #if defined(BOTAN_HAS_MD5)
1028
      const bool has_md5 = true;
108✔
1029
      #else
1030
      const bool has_md5 = false;
1031
      #endif
1032

1033
      auto validation_time = Botan::calendar_point(2017, 8, 19, 12, 0, 0).to_std_timepoint();
108✔
1034

1035
      // By convention: if CRL is a substring if the test name,
1036
      // we need to check the CRLs
1037
      bool use_crl = false;
108✔
1038
      if(test_name.find("CRL") != std::string::npos) {
108✔
1039
         use_crl = true;
32✔
1040
      }
1041

1042
      try {
108✔
1043
         for(const auto& file : all_files) {
878✔
1044
            // found a trust anchor
1045
            if(file.find("TA") != std::string::npos) {
780✔
1046
               trusted.add_certificate(Botan::X509_Certificate(file));
98✔
1047
            }
1048
            // found the target certificate. It needs to be at the front of certs
1049
            else if(file.find("TC") != std::string::npos) {
682✔
1050
               certs.insert(certs.begin(), Botan::X509_Certificate(file));
108✔
1051
            }
1052
            // found a certificate that might be part of a valid certificate chain to the trust anchor
1053
            else if(file.find(".crt") != std::string::npos) {
574✔
1054
               certs.push_back(Botan::X509_Certificate(file));
220✔
1055
            } else if(file.find(".crl") != std::string::npos) {
464✔
1056
               trusted.add_crl(Botan::X509_CRL(file));
64✔
1057
            }
1058
         }
1059

1060
         const Botan::Path_Validation_Restrictions restrictions(
98✔
1061
            use_crl,
1062
            restriction_template.minimum_key_strength(),
1063
            use_crl,
1064
            restriction_template.max_ocsp_age(),
1065
            std::make_unique<Botan::Certificate_Store_In_Memory>(),
206✔
1066
            restriction_template.ignore_trusted_root_time_range(),
98✔
1067
            restriction_template.require_self_signed_trust_anchors());
196✔
1068

1069
         /*
1070
          * Following the test document, the test are executed 16 times with
1071
          * randomly chosen order of the available certificates. However, the target
1072
          * certificate needs to stay in front.
1073
          * For certain test, the order in which the certificates are given to
1074
          * the validation function may be relevant, i.e. if issuer DNs are
1075
          * ambiguous.
1076
          */
1077
         class random_bit_generator {
98✔
1078
            public:
1079
               using result_type = size_t;
1080

1081
               static constexpr result_type min() { return 0; }
1082

1083
               static constexpr result_type max() { return std::numeric_limits<size_t>::max(); }
1084

1085
               result_type operator()() {
160✔
1086
                  size_t s = 0;
160✔
1087
                  m_rng.randomize(reinterpret_cast<uint8_t*>(&s), sizeof(s));
160✔
1088
                  return s;
160✔
1089
               }
1090

1091
               explicit random_bit_generator(Botan::RandomNumberGenerator& rng) : m_rng(rng) {}
98✔
1092

1093
            private:
1094
               Botan::RandomNumberGenerator& m_rng;
1095
         } rbg(this->rng());
98✔
1096

1097
         for(size_t r = 0; r < 16; r++) {
1,666✔
1098
            std::shuffle(++(certs.begin()), certs.end(), rbg);
1,568✔
1099

1100
            const Botan::Path_Validation_Result validation_result = Botan::x509_path_validate(
1,568✔
1101
               certs, restrictions, trusted, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
1,568✔
1102

1103
            // We expect to be warned
1104
            if(expected_result.starts_with("Warning: ")) {
1,568✔
1105
               const std::string stripped = expected_result.substr(std::string("Warning: ").size());
64✔
1106
               bool found_warning = false;
64✔
1107
               for(const auto& warning_set : validation_result.warnings()) {
256✔
1108
                  for(const auto& warning : warning_set) {
256✔
1109
                     const std::string warning_str(Botan::to_string(warning));
64✔
1110
                     if(stripped == warning_str) {
64✔
1111
                        result.test_str_eq(test_name + " path validation result", warning_str, stripped);
64✔
1112
                        found_warning = true;
64✔
1113
                     }
1114
                  }
64✔
1115
               }
64✔
1116
               if(!found_warning) {
64✔
1117
                  result.test_failure(test_name, "Did not receive the expected warning: " + stripped);
×
1118
               }
1119
            } else {
64✔
1120
               if(expected_result == "Hash function used is considered too weak for security" && has_md5 == false) {
1,504✔
1121
                  result.test_str_eq(test_name + " path validation result",
1122
                                     validation_result.result_string(),
1123
                                     "Certificate signed with unknown/unavailable algorithm");
1124
               } else {
1125
                  result.test_str_eq(
3,008✔
1126
                     test_name + " path validation result", validation_result.result_string(), expected_result);
3,008✔
1127
               }
1128
            }
1129
         }
1,568✔
1130
      }
98✔
1131

1132
      /* Some certificates are rejected when executing the X509_Certificate constructor
1133
       * by throwing a Decoding_Error exception.
1134
       */
1135
      catch(const Botan::Exception& e) {
10✔
1136
         if(e.error_type() == Botan::ErrorType::DecodingFailure) {
10✔
1137
            result.test_str_eq(test_name + " path validation result", e.what(), expected_result);
20✔
1138
         } else {
1139
            result.test_failure(test_name, e.what());
×
1140
         }
1141
      }
10✔
1142

1143
      result.end_timer();
108✔
1144
      results.push_back(result);
108✔
1145
   }
108✔
1146

1147
   return results;
2✔
1148
}
2✔
1149

1150
BOTAN_REGISTER_TEST("x509", "x509_path_bsi", BSI_Path_Validation_Tests);
1151

1152
class Path_Validation_With_OCSP_Tests final : public Test {
1✔
1153
   public:
1154
      static Botan::X509_Certificate load_test_X509_cert(const std::string& path) {
24✔
1155
         return Botan::X509_Certificate(Test::data_file(path));
48✔
1156
      }
1157

1158
      static std::optional<Botan::OCSP::Response> load_test_OCSP_resp(const std::string& path) {
12✔
1159
         return Botan::OCSP::Response(Test::read_binary_data_file(path));
36✔
1160
      }
1161

1162
      static Test::Result validate_with_ocsp_with_next_update_without_max_age() {
1✔
1163
         Test::Result result("path check with ocsp with next_update w/o max_age");
1✔
1164
         Botan::Certificate_Store_In_Memory trusted;
1✔
1165

1166
         auto restrictions = Botan::Path_Validation_Restrictions(false, 110, false);
2✔
1167

1168
         auto ee = load_test_X509_cert("x509/ocsp/randombit.pem");
1✔
1169
         auto ca = load_test_X509_cert("x509/ocsp/letsencrypt.pem");
1✔
1170
         auto trust_root = load_test_X509_cert("x509/ocsp/identrust.pem");
1✔
1171
         trusted.add_certificate(trust_root);
1✔
1172

1173
         const std::vector<Botan::X509_Certificate> cert_path = {ee, ca, trust_root};
4✔
1174

1175
         std::optional<const Botan::OCSP::Response> ocsp = load_test_OCSP_resp("x509/ocsp/randombit_ocsp.der");
3✔
1176

1177
         auto check_path = [&](const std::chrono::system_clock::time_point valid_time,
5✔
1178
                               const Botan::Certificate_Status_Code expected) {
1179
            const auto path_result = Botan::x509_path_validate(cert_path,
8✔
1180
                                                               restrictions,
1181
                                                               trusted,
4✔
1182
                                                               "",
1183
                                                               Botan::Usage_Type::UNSPECIFIED,
1184
                                                               valid_time,
1185
                                                               std::chrono::milliseconds(0),
4✔
1186
                                                               {ocsp});
8✔
1187

1188
            return result.test_is_true(std::string("Status: '") + Botan::to_string(expected) + "' should match '" +
24✔
1189
                                          Botan::to_string(path_result.result()) + "'",
8✔
1190
                                       path_result.result() == expected);
8✔
1191
         };
8✔
1192

1193
         check_path(Botan::calendar_point(2016, 11, 11, 12, 30, 0).to_std_timepoint(),
1✔
1194
                    Botan::Certificate_Status_Code::OCSP_NOT_YET_VALID);
1195
         check_path(Botan::calendar_point(2016, 11, 18, 12, 30, 0).to_std_timepoint(),
1✔
1196
                    Botan::Certificate_Status_Code::OK);
1197
         check_path(Botan::calendar_point(2016, 11, 20, 8, 30, 0).to_std_timepoint(),
1✔
1198
                    Botan::Certificate_Status_Code::OK);
1199
         check_path(Botan::calendar_point(2016, 11, 28, 8, 30, 0).to_std_timepoint(),
1✔
1200
                    Botan::Certificate_Status_Code::OCSP_HAS_EXPIRED);
1201

1202
         return result;
2✔
1203
      }
2✔
1204

1205
      static Test::Result validate_with_ocsp_with_next_update_with_max_age() {
1✔
1206
         Test::Result result("path check with ocsp with next_update with max_age");
1✔
1207
         Botan::Certificate_Store_In_Memory trusted;
1✔
1208

1209
         auto restrictions = Botan::Path_Validation_Restrictions(false, 110, false, std::chrono::minutes(59));
1✔
1210

1211
         auto ee = load_test_X509_cert("x509/ocsp/randombit.pem");
1✔
1212
         auto ca = load_test_X509_cert("x509/ocsp/letsencrypt.pem");
1✔
1213
         auto trust_root = load_test_X509_cert("x509/ocsp/identrust.pem");
1✔
1214
         trusted.add_certificate(trust_root);
1✔
1215

1216
         const std::vector<Botan::X509_Certificate> cert_path = {ee, ca, trust_root};
4✔
1217

1218
         auto ocsp = load_test_OCSP_resp("x509/ocsp/randombit_ocsp.der");
1✔
1219

1220
         auto check_path = [&](const std::chrono::system_clock::time_point valid_time,
5✔
1221
                               const Botan::Certificate_Status_Code expected) {
1222
            const auto path_result = Botan::x509_path_validate(cert_path,
8✔
1223
                                                               restrictions,
1224
                                                               trusted,
4✔
1225
                                                               "",
1226
                                                               Botan::Usage_Type::UNSPECIFIED,
1227
                                                               valid_time,
1228
                                                               std::chrono::milliseconds(0),
4✔
1229
                                                               {ocsp});
8✔
1230

1231
            return result.test_is_true(std::string("Status: '") + Botan::to_string(expected) + "' should match '" +
24✔
1232
                                          Botan::to_string(path_result.result()) + "'",
8✔
1233
                                       path_result.result() == expected);
8✔
1234
         };
12✔
1235

1236
         check_path(Botan::calendar_point(2016, 11, 11, 12, 30, 0).to_std_timepoint(),
1✔
1237
                    Botan::Certificate_Status_Code::OCSP_NOT_YET_VALID);
1238
         check_path(Botan::calendar_point(2016, 11, 18, 12, 30, 0).to_std_timepoint(),
1✔
1239
                    Botan::Certificate_Status_Code::OK);
1240
         check_path(Botan::calendar_point(2016, 11, 20, 8, 30, 0).to_std_timepoint(),
1✔
1241
                    Botan::Certificate_Status_Code::OK);
1242
         check_path(Botan::calendar_point(2016, 11, 28, 8, 30, 0).to_std_timepoint(),
1✔
1243
                    Botan::Certificate_Status_Code::OCSP_HAS_EXPIRED);
1244

1245
         return result;
2✔
1246
      }
2✔
1247

1248
      static Test::Result validate_with_ocsp_without_next_update_without_max_age() {
1✔
1249
         Test::Result result("path check with ocsp w/o next_update w/o max_age");
1✔
1250
         Botan::Certificate_Store_In_Memory trusted;
1✔
1251

1252
         auto restrictions = Botan::Path_Validation_Restrictions(false, 110, false);
2✔
1253

1254
         auto ee = load_test_X509_cert("x509/ocsp/patrickschmidt.pem");
1✔
1255
         auto ca = load_test_X509_cert("x509/ocsp/bdrive_encryption.pem");
1✔
1256
         auto trust_root = load_test_X509_cert("x509/ocsp/bdrive_root.pem");
1✔
1257

1258
         trusted.add_certificate(trust_root);
1✔
1259

1260
         const std::vector<Botan::X509_Certificate> cert_path = {ee, ca, trust_root};
4✔
1261

1262
         auto ocsp = load_test_OCSP_resp("x509/ocsp/patrickschmidt_ocsp.der");
1✔
1263

1264
         auto check_path = [&](const std::chrono::system_clock::time_point valid_time,
4✔
1265
                               const Botan::Certificate_Status_Code expected) {
1266
            const auto path_result = Botan::x509_path_validate(cert_path,
6✔
1267
                                                               restrictions,
1268
                                                               trusted,
3✔
1269
                                                               "",
1270
                                                               Botan::Usage_Type::UNSPECIFIED,
1271
                                                               valid_time,
1272
                                                               std::chrono::milliseconds(0),
3✔
1273
                                                               {ocsp});
6✔
1274

1275
            return result.test_is_true(std::string("Status: '") + Botan::to_string(expected) + "' should match '" +
18✔
1276
                                          Botan::to_string(path_result.result()) + "'",
6✔
1277
                                       path_result.result() == expected);
6✔
1278
         };
9✔
1279

1280
         check_path(Botan::calendar_point(2019, 5, 28, 7, 0, 0).to_std_timepoint(),
1✔
1281
                    Botan::Certificate_Status_Code::OCSP_NOT_YET_VALID);
1282
         check_path(Botan::calendar_point(2019, 5, 28, 7, 30, 0).to_std_timepoint(),
1✔
1283
                    Botan::Certificate_Status_Code::OK);
1284
         check_path(Botan::calendar_point(2019, 5, 28, 8, 0, 0).to_std_timepoint(), Botan::Certificate_Status_Code::OK);
1✔
1285

1286
         return result;
2✔
1287
      }
2✔
1288

1289
      static Test::Result validate_with_ocsp_without_next_update_with_max_age() {
1✔
1290
         Test::Result result("path check with ocsp w/o next_update with max_age");
1✔
1291
         Botan::Certificate_Store_In_Memory trusted;
1✔
1292

1293
         auto restrictions = Botan::Path_Validation_Restrictions(false, 110, false, std::chrono::minutes(59));
1✔
1294

1295
         auto ee = load_test_X509_cert("x509/ocsp/patrickschmidt.pem");
1✔
1296
         auto ca = load_test_X509_cert("x509/ocsp/bdrive_encryption.pem");
1✔
1297
         auto trust_root = load_test_X509_cert("x509/ocsp/bdrive_root.pem");
1✔
1298

1299
         trusted.add_certificate(trust_root);
1✔
1300

1301
         const std::vector<Botan::X509_Certificate> cert_path = {ee, ca, trust_root};
4✔
1302

1303
         auto ocsp = load_test_OCSP_resp("x509/ocsp/patrickschmidt_ocsp.der");
1✔
1304

1305
         auto check_path = [&](const std::chrono::system_clock::time_point valid_time,
4✔
1306
                               const Botan::Certificate_Status_Code expected) {
1307
            const auto path_result = Botan::x509_path_validate(cert_path,
6✔
1308
                                                               restrictions,
1309
                                                               trusted,
3✔
1310
                                                               "",
1311
                                                               Botan::Usage_Type::UNSPECIFIED,
1312
                                                               valid_time,
1313
                                                               std::chrono::milliseconds(0),
3✔
1314
                                                               {ocsp});
6✔
1315

1316
            return result.test_is_true(std::string("Status: '") + Botan::to_string(expected) + "' should match '" +
18✔
1317
                                          Botan::to_string(path_result.result()) + "'",
6✔
1318
                                       path_result.result() == expected);
6✔
1319
         };
9✔
1320

1321
         check_path(Botan::calendar_point(2019, 5, 28, 7, 0, 0).to_std_timepoint(),
1✔
1322
                    Botan::Certificate_Status_Code::OCSP_NOT_YET_VALID);
1323
         check_path(Botan::calendar_point(2019, 5, 28, 7, 30, 0).to_std_timepoint(),
1✔
1324
                    Botan::Certificate_Status_Code::OK);
1325
         check_path(Botan::calendar_point(2019, 5, 28, 8, 0, 0).to_std_timepoint(),
1✔
1326
                    Botan::Certificate_Status_Code::OCSP_IS_TOO_OLD);
1327

1328
         return result;
2✔
1329
      }
2✔
1330

1331
      static Test::Result validate_with_ocsp_with_authorized_responder() {
1✔
1332
         Test::Result result("path check with ocsp response from authorized responder certificate");
1✔
1333
         Botan::Certificate_Store_In_Memory trusted;
1✔
1334

1335
         auto restrictions = Botan::Path_Validation_Restrictions(true,   // require revocation info
1✔
1336
                                                                 110,    // minimum key strength
1337
                                                                 true);  // OCSP for all intermediates
2✔
1338

1339
         auto ee = load_test_X509_cert("x509/ocsp/bdr.pem");
1✔
1340
         auto ca = load_test_X509_cert("x509/ocsp/bdr-int.pem");
1✔
1341
         auto trust_root = load_test_X509_cert("x509/ocsp/bdr-root.pem");
1✔
1342

1343
         // These OCSP responses are signed by an authorized OCSP responder
1344
         // certificate issued by `ca` and `trust_root` respectively. Note that
1345
         // the responder certificates contain the "OCSP No Check" extension,
1346
         // meaning that they themselves do not need a revocation check via OCSP.
1347
         auto ocsp_ee = load_test_OCSP_resp("x509/ocsp/bdr-ocsp-resp.der");
1✔
1348
         auto ocsp_ca = load_test_OCSP_resp("x509/ocsp/bdr-int-ocsp-resp.der");
1✔
1349

1350
         trusted.add_certificate(trust_root);
1✔
1351
         const std::vector<Botan::X509_Certificate> cert_path = {ee, ca, trust_root};
4✔
1352

1353
         auto check_path = [&](const std::chrono::system_clock::time_point valid_time,
4✔
1354
                               const Botan::Certificate_Status_Code expected) {
1355
            const auto path_result = Botan::x509_path_validate(cert_path,
12✔
1356
                                                               restrictions,
1357
                                                               trusted,
3✔
1358
                                                               "",
1359
                                                               Botan::Usage_Type::UNSPECIFIED,
1360
                                                               valid_time,
1361
                                                               std::chrono::milliseconds(0),
3✔
1362
                                                               {ocsp_ee, ocsp_ca});
9✔
1363

1364
            return result.test_is_true(std::string("Status: '") + Botan::to_string(expected) + "' should match '" +
18✔
1365
                                          Botan::to_string(path_result.result()) + "'",
6✔
1366
                                       path_result.result() == expected);
6✔
1367
         };
12✔
1368

1369
         check_path(Botan::calendar_point(2022, 9, 18, 16, 30, 0).to_std_timepoint(),
1✔
1370
                    Botan::Certificate_Status_Code::OCSP_NOT_YET_VALID);
1371
         check_path(Botan::calendar_point(2022, 9, 19, 16, 30, 0).to_std_timepoint(),
1✔
1372
                    Botan::Certificate_Status_Code::OK);
1373
         check_path(Botan::calendar_point(2022, 9, 20, 16, 30, 0).to_std_timepoint(),
1✔
1374
                    Botan::Certificate_Status_Code::OCSP_HAS_EXPIRED);
1375

1376
         return result;
1✔
1377
      }
4✔
1378

1379
      static Test::Result validate_with_ocsp_with_authorized_responder_without_keyusage() {
1✔
1380
         Test::Result result(
1✔
1381
            "path check with ocsp response from authorized responder certificate (without sufficient key usage)");
1✔
1382
         Botan::Certificate_Store_In_Memory trusted;
1✔
1383

1384
         auto restrictions = Botan::Path_Validation_Restrictions(true,    // require revocation info
1✔
1385
                                                                 110,     // minimum key strength
1386
                                                                 false);  // OCSP for all intermediates
2✔
1387

1388
         // See `src/scripts/mychain_creater.sh` if you need to recreate those
1389
         auto ee = load_test_X509_cert("x509/ocsp/mychain_ee.pem");
1✔
1390
         auto ca = load_test_X509_cert("x509/ocsp/mychain_int.pem");
1✔
1391
         auto trust_root = load_test_X509_cert("x509/ocsp/mychain_root.pem");
1✔
1392

1393
         auto ocsp_ee_delegate = load_test_OCSP_resp("x509/ocsp/mychain_ocsp_for_ee_delegate_signed.der").value();
2✔
1394
         auto ocsp_ee_delegate_malformed =
1✔
1395
            load_test_OCSP_resp("x509/ocsp/mychain_ocsp_for_ee_delegate_signed_malformed.der").value();
2✔
1396

1397
         trusted.add_certificate(trust_root);
1✔
1398
         const std::vector<Botan::X509_Certificate> cert_path = {ee, ca, trust_root};
4✔
1399

1400
         auto check_path = [&](const std::chrono::system_clock::time_point valid_time,
4✔
1401
                               const Botan::OCSP::Response& ocsp_ee,
1402
                               const Botan::Certificate_Status_Code expected,
1403
                               const std::optional<Botan::Certificate_Status_Code> also_expected = std::nullopt) {
1404
            const auto path_result = Botan::x509_path_validate(cert_path,
6✔
1405
                                                               restrictions,
1406
                                                               trusted,
3✔
1407
                                                               "",
1408
                                                               Botan::Usage_Type::UNSPECIFIED,
1409
                                                               valid_time,
1410
                                                               std::chrono::milliseconds(0),
3✔
1411
                                                               {ocsp_ee});
6✔
1412

1413
            result.test_u32_eq("should result in expected validation status code",
3✔
1414
                               static_cast<uint32_t>(path_result.result()),
3✔
1415
                               static_cast<uint32_t>(expected));
1416
            if(also_expected) {
3✔
1417
               result.test_is_true("Secondary error is also present",
4✔
1418
                                   flatten(path_result.all_statuses()).contains(also_expected.value()));
6✔
1419
            }
1420
         };
6✔
1421

1422
         check_path(Botan::calendar_point(2022, 9, 22, 23, 30, 0).to_std_timepoint(),
1✔
1423
                    ocsp_ee_delegate,
1424
                    Botan::Certificate_Status_Code::VERIFIED);
1425
         check_path(Botan::calendar_point(2022, 10, 8, 23, 30, 0).to_std_timepoint(),
1✔
1426
                    ocsp_ee_delegate,
1427
                    Botan::Certificate_Status_Code::CERT_HAS_EXPIRED,
1428
                    Botan::Certificate_Status_Code::OCSP_ISSUER_NOT_TRUSTED);
1✔
1429
         check_path(Botan::calendar_point(2022, 9, 22, 23, 30, 0).to_std_timepoint(),
1✔
1430
                    ocsp_ee_delegate_malformed,
1431
                    Botan::Certificate_Status_Code::OCSP_RESPONSE_MISSING_KEYUSAGE,
1432
                    Botan::Certificate_Status_Code::OCSP_ISSUER_NOT_TRUSTED);
1✔
1433

1434
         return result;
1✔
1435
      }
2✔
1436

1437
      static Test::Result validate_with_forged_ocsp_using_self_signed_cert() {
1✔
1438
         Test::Result result("path check with forged ocsp using self-signed certificate");
1✔
1439
         Botan::Certificate_Store_In_Memory trusted;
1✔
1440

1441
         auto restrictions = Botan::Path_Validation_Restrictions(true,    // require revocation info
1✔
1442
                                                                 110,     // minimum key strength
1443
                                                                 false);  // OCSP for all intermediates
2✔
1444

1445
         auto ee = load_test_X509_cert("x509/ocsp/randombit.pem");
1✔
1446
         auto ca = load_test_X509_cert("x509/ocsp/letsencrypt.pem");
1✔
1447
         auto trust_root = load_test_X509_cert("x509/ocsp/identrust.pem");
1✔
1448
         trusted.add_certificate(trust_root);
1✔
1449

1450
         const std::vector<Botan::X509_Certificate> cert_path = {ee, ca, trust_root};
4✔
1451

1452
         auto check_path = [&](const std::string& forged_ocsp,
3✔
1453
                               const Botan::Certificate_Status_Code expected,
1454
                               const Botan::Certificate_Status_Code also_expected) {
1455
            auto ocsp = load_test_OCSP_resp(forged_ocsp);
2✔
1456
            const auto path_result =
2✔
1457
               Botan::x509_path_validate(cert_path,
4✔
1458
                                         restrictions,
1459
                                         trusted,
2✔
1460
                                         "",
1461
                                         Botan::Usage_Type::UNSPECIFIED,
1462
                                         Botan::calendar_point(2016, 11, 18, 12, 30, 0).to_std_timepoint(),
2✔
1463
                                         std::chrono::milliseconds(0),
2✔
1464
                                         {ocsp});
4✔
1465

1466
            result.test_enum_eq(
2✔
1467
               "Path validation with forged OCSP response should fail with", path_result.result(), expected);
2✔
1468
            result.test_is_true("Secondary error is also present",
4✔
1469
                                flatten(path_result.all_statuses()).contains(also_expected));
4✔
1470
            result.test_note("Validation result", Botan::to_string(path_result.result()));
2✔
1471
         };
8✔
1472

1473
         // In both cases the path validation should detect the forged OCSP
1474
         // response and generate an appropriate error. By no means it should
1475
         // follow the unauthentic OCSP response.
1476
         check_path("x509/ocsp/randombit_ocsp_forged_valid.der",
1✔
1477
                    Botan::Certificate_Status_Code::OCSP_ISSUER_NOT_TRUSTED,
1478
                    Botan::Certificate_Status_Code::OCSP_ISSUER_NOT_TRUSTED);
1479
         check_path("x509/ocsp/randombit_ocsp_forged_revoked.der",
1✔
1480
                    Botan::Certificate_Status_Code::OCSP_ISSUER_NOT_TRUSTED,
1481
                    Botan::Certificate_Status_Code::OCSP_ISSUER_NOT_TRUSTED);
1482

1483
         return result;
1✔
1484
      }
2✔
1485

1486
      static Test::Result validate_with_ocsp_self_signed_by_intermediate_cert() {
1✔
1487
         Test::Result result(
1✔
1488
            "path check with ocsp response for intermediate that is (maliciously) self-signed by the intermediate");
1✔
1489
         Botan::Certificate_Store_In_Memory trusted;
1✔
1490

1491
         auto restrictions = Botan::Path_Validation_Restrictions(true,   // require revocation info
1✔
1492
                                                                 110,    // minimum key strength
1493
                                                                 true);  // OCSP for all intermediates
2✔
1494

1495
         // See `src/scripts/mychain_creater.sh` if you need to recreate those
1496
         auto ee = load_test_X509_cert("x509/ocsp/mychain_ee.pem");
1✔
1497
         auto ca = load_test_X509_cert("x509/ocsp/mychain_int.pem");
1✔
1498
         auto trust_root = load_test_X509_cert("x509/ocsp/mychain_root.pem");
1✔
1499

1500
         // this OCSP response for EE is valid (signed by intermediate cert)
1501
         auto ocsp_ee = load_test_OCSP_resp("x509/ocsp/mychain_ocsp_for_ee.der");
1✔
1502

1503
         // this OCSP response for Intermediate is malicious (signed by intermediate itself)
1504
         auto ocsp_ca = load_test_OCSP_resp("x509/ocsp/mychain_ocsp_for_int_self_signed.der");
1✔
1505

1506
         trusted.add_certificate(trust_root);
1✔
1507
         const std::vector<Botan::X509_Certificate> cert_path = {ee, ca, trust_root};
4✔
1508

1509
         const auto path_result =
1✔
1510
            Botan::x509_path_validate(cert_path,
4✔
1511
                                      restrictions,
1512
                                      trusted,
1513
                                      "",
1514
                                      Botan::Usage_Type::UNSPECIFIED,
1515
                                      Botan::calendar_point(2022, 9, 22, 22, 30, 0).to_std_timepoint(),
1✔
1516
                                      std::chrono::milliseconds(0),
1✔
1517
                                      {ocsp_ee, ocsp_ca});
3✔
1518
         result.test_is_true("should reject intermediate OCSP response",
1✔
1519
                             path_result.result() == Botan::Certificate_Status_Code::OCSP_ISSUER_NOT_FOUND);
1✔
1520
         result.test_note("Validation result", Botan::to_string(path_result.result()));
1✔
1521

1522
         return result;
1✔
1523
      }
7✔
1524

1525
      std::vector<Test::Result> run() override {
1✔
1526
         return {validate_with_ocsp_with_next_update_without_max_age(),
1✔
1527
                 validate_with_ocsp_with_next_update_with_max_age(),
1528
                 validate_with_ocsp_without_next_update_without_max_age(),
1529
                 validate_with_ocsp_without_next_update_with_max_age(),
1530
                 validate_with_ocsp_with_authorized_responder(),
1531
                 validate_with_ocsp_with_authorized_responder_without_keyusage(),
1532
                 validate_with_forged_ocsp_using_self_signed_cert(),
1533
                 validate_with_ocsp_self_signed_by_intermediate_cert()};
9✔
1534
      }
1✔
1535
};
1536

1537
BOTAN_REGISTER_TEST("x509", "x509_path_with_ocsp", Path_Validation_With_OCSP_Tests);
1538

1539
   #endif
1540

1541
   #if defined(BOTAN_HAS_ECDSA)
1542

1543
class CVE_2020_0601_Tests final : public Test {
1✔
1544
   public:
1545
      std::vector<Test::Result> run() override {
1✔
1546
         Test::Result result("CVE-2020-0601");
1✔
1547

1548
         if(!Botan::EC_Group::supports_application_specific_group()) {
1✔
1549
            result.test_note("Skipping as application specific groups are not supported");
×
1550
            return {result};
×
1551
         }
1552

1553
         if(!Botan::EC_Group::supports_named_group("secp384r1")) {
1✔
1554
            result.test_note("Skipping as secp384r1 is not supported");
×
1555
            return {result};
×
1556
         }
1557

1558
         const auto& secp384r1 = Botan::EC_Group::from_name("secp384r1");
1✔
1559
         const Botan::OID curveball_oid("1.3.6.1.4.1.25258.4.2020.0601");
1✔
1560
         const Botan::EC_Group curveball(
1✔
1561
            curveball_oid,
1562
            secp384r1.get_p(),
1563
            secp384r1.get_a(),
1564
            secp384r1.get_b(),
1565
            BigInt(
2✔
1566
               "0xC711162A761D568EBEB96265D4C3CEB4F0C330EC8F6DD76E39BCC849ABABB8E34378D581065DEFC77D9FCED6B39075DE"),
1567
            BigInt(
2✔
1568
               "0x0CB090DE23BAC8D13E67E019A91B86311E5F342DEE17FD15FB7E278A32A1EAC98FC97E18CB2F3B2C487A7DA6F40107AC"),
1569
            secp384r1.get_order());
2✔
1570

1571
         auto ca_crt = Botan::X509_Certificate(Test::data_file("x509/cve-2020-0601/ca.pem"));
2✔
1572
         auto fake_ca_crt = Botan::X509_Certificate(Test::data_file("x509/cve-2020-0601/fake_ca.pem"));
2✔
1573
         auto ee_crt = Botan::X509_Certificate(Test::data_file("x509/cve-2020-0601/ee.pem"));
2✔
1574

1575
         Botan::Certificate_Store_In_Memory trusted;
1✔
1576
         trusted.add_certificate(ca_crt);
1✔
1577

1578
         const auto restrictions = Botan::Path_Validation_Restrictions(false, 80, false);
2✔
1579

1580
         const auto valid_time = Botan::calendar_point(2020, 1, 20, 0, 0, 0).to_std_timepoint();
1✔
1581

1582
         const auto path_result1 = Botan::x509_path_validate(std::vector<Botan::X509_Certificate>{ee_crt, fake_ca_crt},
5✔
1583
                                                             restrictions,
1584
                                                             trusted,
1585
                                                             "",
1586
                                                             Botan::Usage_Type::UNSPECIFIED,
1587
                                                             valid_time,
1588
                                                             std::chrono::milliseconds(0),
1✔
1589
                                                             {});
3✔
1590

1591
         result.test_is_true("Validation failed", !path_result1.successful_validation());
1✔
1592

1593
         result.test_is_true("Expected status",
1✔
1594
                             path_result1.result() == Botan::Certificate_Status_Code::CANNOT_ESTABLISH_TRUST);
1✔
1595

1596
         const auto path_result2 = Botan::x509_path_validate(std::vector<Botan::X509_Certificate>{ee_crt},
3✔
1597
                                                             restrictions,
1598
                                                             trusted,
1599
                                                             "",
1600
                                                             Botan::Usage_Type::UNSPECIFIED,
1601
                                                             valid_time,
1602
                                                             std::chrono::milliseconds(0),
1✔
1603
                                                             {});
3✔
1604

1605
         result.test_is_true("Validation failed", !path_result2.successful_validation());
1✔
1606

1607
         result.test_is_true("Expected status",
1✔
1608
                             path_result2.result() == Botan::Certificate_Status_Code::CERT_ISSUER_NOT_FOUND);
1✔
1609

1610
         // Verify the signature from the bad CA is actually correct
1611
         Botan::Certificate_Store_In_Memory frusted;
1✔
1612
         frusted.add_certificate(fake_ca_crt);
1✔
1613

1614
         const auto path_result3 = Botan::x509_path_validate(std::vector<Botan::X509_Certificate>{ee_crt},
3✔
1615
                                                             restrictions,
1616
                                                             frusted,
1617
                                                             "",
1618
                                                             Botan::Usage_Type::UNSPECIFIED,
1619
                                                             valid_time,
1620
                                                             std::chrono::milliseconds(0),
1✔
1621
                                                             {});
3✔
1622

1623
         result.test_is_true("Validation succeeded", path_result3.successful_validation());
1✔
1624

1625
         return {result};
2✔
1626
      }
5✔
1627
};
1628

1629
BOTAN_REGISTER_TEST("x509", "x509_cve_2020_0601", CVE_2020_0601_Tests);
1630

1631
class Path_Validation_With_Immortal_CRL final : public Test {
1✔
1632
   public:
1633
      std::vector<Test::Result> run() override {
1✔
1634
         // RFC 5280 defines the nextUpdate field as "optional" (in line with
1635
         // the original X.509 standard), but then requires all conforming CAs
1636
         // to always define it. For best compatibility we must deal with both.
1637
         Test::Result result("Using a CRL without a nextUpdate field");
1✔
1638

1639
         if(Botan::has_filesystem_impl() == false) {
1✔
1640
            result.test_note("Skipping due to missing filesystem access");
×
1641
            return {result};
×
1642
         }
1643

1644
         const Botan::X509_Certificate root(Test::data_file("x509/misc/crl_without_nextupdate/ca.pem"));
2✔
1645
         const Botan::X509_Certificate revoked_subject(Test::data_file("x509/misc/crl_without_nextupdate/01.pem"));
2✔
1646
         const Botan::X509_Certificate valid_subject(Test::data_file("x509/misc/crl_without_nextupdate/42.pem"));
2✔
1647

1648
         // Check that a CRL without nextUpdate is parsable
1649
         auto crl = Botan::X509_CRL(Test::data_file("x509/misc/crl_without_nextupdate/valid_forever.crl"));
2✔
1650
         result.test_is_true("this update is set", crl.this_update().time_is_set());
1✔
1651
         result.test_is_true("next update is not set", !crl.next_update().time_is_set());
1✔
1652
         result.test_is_true("CRL is not empty", !crl.get_revoked().empty());
1✔
1653

1654
         // Ensure that we support the used sig algo, otherwish stop here
1655
         if(!Botan::EC_Group::supports_named_group("brainpool512r1")) {
1✔
1656
            result.test_note("Cannot test path validation because signature algorithm is not support in this build");
×
1657
            return {result};
×
1658
         }
1659

1660
         Botan::Certificate_Store_In_Memory trusted;
1✔
1661
         trusted.add_certificate(root);
1✔
1662
         trusted.add_crl(crl);
1✔
1663

1664
         // Just before the CA and subject certificates expire
1665
         // (validity from 01 March 2025 to 24 February 2026)
1666
         auto valid_time = Botan::calendar_point(2026, 2, 23, 0, 0, 0).to_std_timepoint();
1✔
1667

1668
         const Botan::Path_Validation_Restrictions restrictions(true /* require revocation info */);
2✔
1669

1670
         // Validate a certificate that is not listed in the CRL
1671
         const auto valid = Botan::x509_path_validate(
1✔
1672
            valid_subject, restrictions, trusted, "", Botan::Usage_Type::UNSPECIFIED, valid_time);
1✔
1673
         if(!result.test_is_true("Valid certificate", valid.successful_validation())) {
1✔
1674
            result.test_note(valid.result_string());
×
1675
         }
1676

1677
         // Ensure that a certificate listed in the CRL is recognized as revoked
1678
         const auto revoked = Botan::x509_path_validate(
1✔
1679
            revoked_subject, restrictions, trusted, "", Botan::Usage_Type::UNSPECIFIED, valid_time);
1✔
1680
         if(!result.test_is_true("No valid certificate", !revoked.successful_validation())) {
1✔
1681
            result.test_note(revoked.result_string());
×
1682
         }
1683
         result.test_enum_eq(
2✔
1684
            "Certificate is revoked", revoked.result(), Botan::Certificate_Status_Code::CERT_IS_REVOKED);
1✔
1685

1686
         return {result};
2✔
1687
      }
2✔
1688
};
1689

1690
BOTAN_REGISTER_TEST("x509", "x509_path_immortal_crl", Path_Validation_With_Immortal_CRL);
1691

1692
   #endif
1693

1694
   #if defined(BOTAN_HAS_XMSS_RFC8391)
1695

1696
class XMSS_Path_Validation_Tests final : public Test {
1✔
1697
   public:
1698
      static Test::Result validate_self_signed(const std::string& name, const std::string& file) {
2✔
1699
         Test::Result result(name);
2✔
1700

1701
         const Botan::Path_Validation_Restrictions restrictions;
4✔
1702
         auto self_signed = Botan::X509_Certificate(Test::data_file("x509/xmss/" + file));
4✔
1703

1704
         auto cert_path = std::vector<Botan::X509_Certificate>{self_signed};
4✔
1705
         auto valid_time = Botan::calendar_point(2019, 10, 8, 4, 45, 0).to_std_timepoint();
2✔
1706

1707
         auto status = Botan::PKIX::overall_status(
2✔
1708
            Botan::PKIX::check_chain(cert_path, valid_time, "", Botan::Usage_Type::UNSPECIFIED, restrictions));
4✔
1709
         result.test_str_eq("Cert validation status", Botan::to_string(status), "Verified");
2✔
1710
         return result;
2✔
1711
      }
4✔
1712

1713
      std::vector<Test::Result> run() override {
1✔
1714
         if(Botan::has_filesystem_impl() == false) {
1✔
1715
            return {Test::Result::Note("XMSS path validation", "Skipping due to missing filesystem access")};
×
1716
         }
1717

1718
         return {
1✔
1719
            validate_self_signed("XMSS path validation with certificate created by ISARA corp", "xmss_isara_root.pem"),
1✔
1720
            validate_self_signed("XMSS path validation with certificate created by BouncyCastle",
1✔
1721
                                 "xmss_bouncycastle_sha256_10_root.pem")};
3✔
1722
      }
4✔
1723
};
1724

1725
BOTAN_REGISTER_TEST("x509", "x509_path_xmss", XMSS_Path_Validation_Tests);
1726

1727
   #endif
1728

1729
   #if defined(BOTAN_HAS_RSA) && defined(BOTAN_HAS_EMSA_PKCS1)
1730

1731
class CVE_2026_35580_Test final : public Test {
1✔
1732
   public:
1733
      std::vector<Test::Result> run() override {
1✔
1734
         Test::Result result("CVE-2026-35580");
1✔
1735

1736
         const Botan::Path_Validation_Restrictions restrictions;
2✔
1737

1738
         auto end_entity = Botan::X509_Certificate(Test::data_file("x509/cve_2026_35580/end_entity.pem"));
2✔
1739
         auto trusted_root = Botan::X509_Certificate(Test::data_file("x509/cve_2026_35580/root.pem"));
2✔
1740

1741
         auto validation_time = Botan::calendar_point(2026, 3, 29, 0, 0, 0).to_std_timepoint();
1✔
1742

1743
         Botan::Certificate_Store_In_Memory trusted;
1✔
1744
         trusted.add_certificate(trusted_root);
1✔
1745

1746
         const auto validation_result = Botan::x509_path_validate(
1✔
1747
            {end_entity}, restrictions, {&trusted}, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
2✔
1748

1749
         result.test_str_eq(
1✔
1750
            "Cert validation status", Botan::to_string(validation_result.result()), "Cannot establish trust");
1751

1752
         return {result};
3✔
1753
      }
2✔
1754
};
1755

1756
BOTAN_REGISTER_TEST("x509", "x509_cve_2026_35580", CVE_2026_35580_Test);
1757

1758
   #endif
1759

1760
   #if defined(BOTAN_HAS_ECDSA)
1761

1762
/**
1763
* Test that the certificate path building DFS correctly handles constructing
1764
* paths with many possible intermediates.
1765
*/
1766
class Path_Building_Tests final : public Test {
1✔
1767
   public:
1768
      std::vector<Test::Result> run() override {
1✔
1769
         if(Botan::has_filesystem_impl() == false) {
1✔
1770
            return {Test::Result::Note("X509 path building", "Skipping due to missing filesystem access")};
×
1771
         }
1772

1773
         const std::string base_dir = "x509/path_building";
1✔
1774
         auto validation_time = Botan::calendar_point(2026, 4, 1, 4, 20, 0).to_std_timepoint();
1✔
1775

1776
         // Load root into trust store
1777
         Botan::Certificate_Store_In_Memory trust_store;
1✔
1778
         trust_store.add_certificate(Botan::X509_Certificate(Test::data_file(base_dir + "/root.pem")));
1✔
1779

1780
         // Load the intermediates
1781
         std::vector<Botan::X509_Certificate> intermediates;
1✔
1782
         for(const auto& file : Test::files_in_data_dir(base_dir)) {
24✔
1783
            if(file.find("level1_") != std::string::npos || file.find("level2_") != std::string::npos) {
23✔
1784
               intermediates.emplace_back(file);
14✔
1785
            }
1786
         }
1✔
1787

1788
         Test::Result result("X509 path building DFS");
1✔
1789
         result.start_timer();
1✔
1790

1791
         const Botan::Path_Validation_Restrictions restrictions(false, 80, false);
2✔
1792

1793
         for(const auto& [test_name, expected_result] : read_results(Test::data_file(base_dir + "/expected.txt"))) {
8✔
1794
            const Botan::X509_Certificate end_entity(Test::data_file(Botan::fmt("{}/{}", base_dir, test_name)));
14✔
1795

1796
            std::vector<Botan::X509_Certificate> end_certs;
7✔
1797
            end_certs.push_back(end_entity);
7✔
1798
            end_certs.insert(end_certs.end(), intermediates.begin(), intermediates.end());
7✔
1799

1800
            const Botan::Path_Validation_Result validation_result = Botan::x509_path_validate(
7✔
1801
               end_certs, restrictions, {&trust_store}, "", Botan::Usage_Type::UNSPECIFIED, validation_time);
14✔
1802

1803
            result.test_str_eq(
14✔
1804
               test_name + " path validation result", validation_result.result_string(), expected_result);
14✔
1805
         }
7✔
1806

1807
         result.end_timer();
1✔
1808
         return {result};
2✔
1809
      }
2✔
1810
};
1811

1812
BOTAN_REGISTER_TEST("x509", "x509_path_building", Path_Building_Tests);
1813

1814
   #endif
1815

1816
#endif
1817

1818
}  // namespace
1819

1820
}  // namespace Botan_Tests
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc