• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #5055

17 May 2026 01:15AM UTC coverage: 73.355% (-0.003%) from 73.358%
#5055

push

travis-ci

web-flow
feat (TDgpt): Dynamic Model Synchronization Enhancements (#35344)

* refactor: do some internal refactor.

* fix: fix multiprocess sync issue.

* feat: add dynamic anomaly detection and forecasting services

* fix: log error message for undeploying model in exception handling

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* fix: handle undeploy when model exists only on disk

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/286aafa0-c3ce-4c27-b803-2707571e9dc1

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* fix: guard dynamic registry concurrent access

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/5e4db858-6458-40f4-ac28-d1b1b7f97c18

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* fix: tighten service list locking scope

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/5e4db858-6458-40f4-ac28-d1b1b7f97c18

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* fix: restore prophet support and update tests per review feedback

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/92298ae1-7da6-4d07-b20e-101c7cd0b26b

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* fix: improve test name and move copy inside lock scope

Agent-Logs-Url: https://github.com/taosdata/TDengine/sessions/92298ae1-7da6-4d07-b20e-101c7cd0b26b

Co-authored-by: hjxilinx <8252296+hjxilinx@users.noreply.github.com>

* Potential fix for pull request finding

Co-au... (continued)

281532 of 383795 relevant lines covered (73.35%)

135557734.7 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

77.99
/source/dnode/mnode/impl/src/mndStb.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "mndStb.h"
18
#include "audit.h"
19
#include "mndDb.h"
20
#include "mndDnode.h"
21
#include "mndIndex.h"
22
#include "mndIndexComm.h"
23
#include "mndInfoSchema.h"
24
#include "mndMnode.h"
25
#include "mndPerfSchema.h"
26
#include "mndPrivilege.h"
27
#include "mndRsma.h"
28
#include "mndSecurityPolicy.h"
29
#include "mndShow.h"
30
#include "mndSma.h"
31
#include "mndStream.h"
32
#include "mndTopic.h"
33
#include "mndTrans.h"
34
#include "mndUser.h"
35
#include "mndVgroup.h"
36
#include "tname.h"
37

38
#define STB_VER_SUPPORT_COMP    2
39
#define STB_VER_SUPPORT_VIRTUAL 3
40
#define STB_VER_SUPPORT_OWNER   4
41
#define STB_VER_NUMBER          STB_VER_SUPPORT_OWNER
42
#define STB_RESERVE_SIZE        51
43

44
static int32_t  mndStbActionInsert(SSdb *pSdb, SStbObj *pStb);
45
static int32_t  mndStbActionDelete(SSdb *pSdb, SStbObj *pStb);
46
static int32_t  mndStbActionUpdate(SSdb *pSdb, SStbObj *pOld, SStbObj *pNew);
47
static int32_t  mndProcessTtlTimer(SRpcMsg *pReq);
48
// static int32_t  mndProcessTrimDbTimer(SRpcMsg *pReq);
49
static int32_t  mndProcessCreateStbReq(SRpcMsg *pReq);
50
static int32_t  mndProcessAlterStbReq(SRpcMsg *pReq);
51
static int32_t  mndProcessDropStbReq(SRpcMsg *pReq);
52
static int32_t  mndProcessDropTtltbRsp(SRpcMsg *pReq);
53
static int32_t  mndProcessTrimDbRsp(SRpcMsg *pReq);
54
static int32_t  mndProcessTrimDbWalRsp(SRpcMsg *pReq);
55
static int32_t  mndProcessTableMetaReq(SRpcMsg *pReq);
56
static int32_t  mndRetrieveStb(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
57
static int32_t  mndRetrieveStbCol(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
58
static void     mndCancelGetNextStb(SMnode *pMnode, void *pIter);
59
static int32_t  mndProcessTableCfgReq(SRpcMsg *pReq);
60
static int32_t  mndAlterStbImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
61
                               void *alterOriData, int32_t alterOriDataLen);
62
static int32_t  mndAlterStbAndUpdateTagIdxImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
63
                                              void *alterOriData, int32_t alterOriDataLen, const SMAlterStbReq *pAlter);
64

65
static int32_t mndProcessCreateIndexReq(SRpcMsg *pReq);
66
static int32_t mndProcessDropIndexReq(SRpcMsg *pReq);
67

68
static int32_t mndProcessDropStbReqFromMNode(SRpcMsg *pReq);
69
static int32_t mndProcessDropTbWithTsma(SRpcMsg *pReq);
70
static int32_t mndProcessFetchTtlExpiredTbs(SRpcMsg *pReq);
71
static int32_t mndProcessAuditRecordRsp(SRpcMsg *pRsp);
72

73
int32_t mndInitStb(SMnode *pMnode) {
530,711✔
74
  SSdbTable table = {
530,711✔
75
      .sdbType = SDB_STB,
76
      .keyType = SDB_KEY_BINARY,
77
      .encodeFp = (SdbEncodeFp)mndStbActionEncode,
78
      .decodeFp = (SdbDecodeFp)mndStbActionDecode,
79
      .insertFp = (SdbInsertFp)mndStbActionInsert,
80
      .updateFp = (SdbUpdateFp)mndStbActionUpdate,
81
      .deleteFp = (SdbDeleteFp)mndStbActionDelete,
82
  };
83

84
  mndSetMsgHandle(pMnode, TDMT_MND_CREATE_STB, mndProcessCreateStbReq);
530,711✔
85
  mndSetMsgHandle(pMnode, TDMT_MND_ALTER_STB, mndProcessAlterStbReq);
530,711✔
86
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_STB, mndProcessDropStbReq);
530,711✔
87
  mndSetMsgHandle(pMnode, TDMT_VND_CREATE_STB_RSP, mndTransProcessRsp);
530,711✔
88
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_TTL_TABLE_RSP, mndProcessDropTtltbRsp);
530,711✔
89
  mndSetMsgHandle(pMnode, TDMT_VND_TRIM_RSP, mndTransProcessRsp);
530,711✔
90
  mndSetMsgHandle(pMnode, TDMT_VND_TRIM_WAL_RSP, mndProcessTrimDbWalRsp);
530,711✔
91
  mndSetMsgHandle(pMnode, TDMT_VND_ALTER_STB_RSP, mndTransProcessRsp);
530,711✔
92
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_STB_RSP, mndTransProcessRsp);
530,711✔
93
  mndSetMsgHandle(pMnode, TDMT_MND_TABLE_META, mndProcessTableMetaReq);
530,711✔
94
  mndSetMsgHandle(pMnode, TDMT_MND_TTL_TIMER, mndProcessTtlTimer);
530,711✔
95
  // mndSetMsgHandle(pMnode, TDMT_MND_TRIM_DB_TIMER, mndProcessTrimDbTimer);
96
  mndSetMsgHandle(pMnode, TDMT_MND_TABLE_CFG, mndProcessTableCfgReq);
530,711✔
97
  mndSetMsgHandle(pMnode, TDMT_MND_STB_DROP, mndProcessDropStbReqFromMNode);
530,711✔
98
  mndSetMsgHandle(pMnode, TDMT_MND_STB_DROP_RSP, mndTransProcessRsp);
530,711✔
99
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_TB_WITH_TSMA, mndProcessDropTbWithTsma);
530,711✔
100
  mndSetMsgHandle(pMnode, TDMT_VND_FETCH_TTL_EXPIRED_TBS_RSP, mndProcessFetchTtlExpiredTbs);
530,711✔
101
  mndSetMsgHandle(pMnode, TDMT_VND_DROP_TABLE_RSP, mndTransProcessRsp);
530,711✔
102
  mndSetMsgHandle(pMnode, TDMT_VND_CREATE_TABLE_RSP, mndTransProcessRsp);
530,711✔
103

104
  //  mndSetMsgHandle(pMnode, TDMT_MND_SYSTABLE_RETRIEVE, mndProcessRetrieveStbReq);
105

106
  // mndSetMsgHandle(pMnode, TDMT_MND_CREATE_INDEX, mndProcessCreateIndexReq);
107
  // mndSetMsgHandle(pMnode, TDMT_MND_DROP_INDEX, mndProcessDropIndexReq);
108
  // mndSetMsgHandle(pMnode, TDMT_VND_CREATE_INDEX_RSP, mndTransProcessRsp);
109
  // mndSetMsgHandle(pMnode, TDMT_VND_DROP_INDEX_RSP, mndTransProcessRsp);
110
  mndSetMsgHandle(pMnode, TDMT_VND_AUDIT_RECORD_RSP, mndProcessAuditRecordRsp);
530,711✔
111

112
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_STB, mndRetrieveStb);
530,711✔
113
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_STB, mndCancelGetNextStb);
530,711✔
114

115
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_COL, mndRetrieveStbCol);
530,711✔
116
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_COL, mndCancelGetNextStb);
530,711✔
117

118
  return sdbSetTable(pMnode->pSdb, table);
530,711✔
119
}
120

121
void mndCleanupStb(SMnode *pMnode) {}
530,648✔
122

123
SSdbRaw *mndStbActionEncode(SStbObj *pStb) {
17,837,127✔
124
  int32_t code = 0;
17,837,127✔
125
  int32_t lino = 0;
17,837,127✔
126
  bool    hasTypeMod = false;
17,837,127✔
127
  terrno = TSDB_CODE_OUT_OF_MEMORY;
17,837,127✔
128

129
  int32_t size = sizeof(SStbObj) + (pStb->numOfColumns + pStb->numOfTags) * sizeof(SSchema) + pStb->commentLen +
17,846,273✔
130
                 pStb->ast1Len + pStb->ast2Len + pStb->numOfColumns * sizeof(SColCmpr) + STB_RESERVE_SIZE +
17,846,273✔
131
                 taosArrayGetSize(pStb->pFuncs) * TSDB_FUNC_NAME_LEN + sizeof(int32_t) * pStb->numOfColumns;
17,837,127✔
132
  SSdbRaw *pRaw = sdbAllocRaw(SDB_STB, STB_VER_NUMBER, size);
17,837,127✔
133
  if (pRaw == NULL) goto _OVER;
17,837,127✔
134

135
  int32_t dataPos = 0;
17,837,127✔
136
  SDB_SET_BINARY(pRaw, dataPos, pStb->name, TSDB_TABLE_FNAME_LEN, _OVER)
17,837,127✔
137
  SDB_SET_BINARY(pRaw, dataPos, pStb->db, TSDB_DB_FNAME_LEN, _OVER)
17,837,127✔
138
  SDB_SET_INT64(pRaw, dataPos, pStb->createdTime, _OVER)
17,837,127✔
139
  SDB_SET_INT64(pRaw, dataPos, pStb->updateTime, _OVER)
17,837,127✔
140
  SDB_SET_INT64(pRaw, dataPos, pStb->uid, _OVER)
17,837,127✔
141
  SDB_SET_INT64(pRaw, dataPos, pStb->dbUid, _OVER)
17,837,127✔
142
  SDB_SET_INT32(pRaw, dataPos, pStb->tagVer, _OVER)
17,837,127✔
143
  SDB_SET_INT32(pRaw, dataPos, pStb->colVer, _OVER)
17,837,127✔
144
  SDB_SET_INT32(pRaw, dataPos, pStb->smaVer, _OVER)
17,837,127✔
145
  SDB_SET_INT32(pRaw, dataPos, pStb->nextColId, _OVER)
17,837,127✔
146
  SDB_SET_INT64(pRaw, dataPos, pStb->maxdelay[0], _OVER)
17,837,127✔
147
  SDB_SET_INT64(pRaw, dataPos, pStb->maxdelay[1], _OVER)
17,837,127✔
148
  SDB_SET_INT64(pRaw, dataPos, pStb->watermark[0], _OVER)
17,837,127✔
149
  SDB_SET_INT64(pRaw, dataPos, pStb->watermark[1], _OVER)
17,837,127✔
150
  SDB_SET_INT32(pRaw, dataPos, pStb->ttl, _OVER)
17,837,127✔
151
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfColumns, _OVER)
17,837,127✔
152
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfTags, _OVER)
17,837,127✔
153
  SDB_SET_INT32(pRaw, dataPos, pStb->numOfFuncs, _OVER)
17,837,127✔
154
  SDB_SET_INT32(pRaw, dataPos, pStb->commentLen, _OVER)
17,837,127✔
155
  SDB_SET_INT32(pRaw, dataPos, pStb->ast1Len, _OVER)
17,837,127✔
156
  SDB_SET_INT32(pRaw, dataPos, pStb->ast2Len, _OVER)
17,837,127✔
157

158
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
1,098,400,901✔
159
    SSchema *pSchema = &pStb->pColumns[i];
1,080,563,774✔
160
    SDB_SET_INT8(pRaw, dataPos, pSchema->type, _OVER)
1,080,563,774✔
161
    SDB_SET_INT8(pRaw, dataPos, pSchema->flags, _OVER)
1,080,563,774✔
162
    SDB_SET_INT16(pRaw, dataPos, pSchema->colId, _OVER)
1,080,563,774✔
163
    SDB_SET_INT32(pRaw, dataPos, pSchema->bytes, _OVER)
1,080,563,774✔
164
    SDB_SET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
1,080,563,774✔
165
    hasTypeMod = hasTypeMod || HAS_TYPE_MOD(pSchema);
1,080,563,774✔
166
  }
167

168
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
119,537,918✔
169
    SSchema *pSchema = &pStb->pTags[i];
101,700,791✔
170
    SDB_SET_INT8(pRaw, dataPos, pSchema->type, _OVER)
101,700,791✔
171
    SDB_SET_INT8(pRaw, dataPos, pSchema->flags, _OVER)
101,700,791✔
172
    SDB_SET_INT16(pRaw, dataPos, pSchema->colId, _OVER)
101,700,791✔
173
    SDB_SET_INT32(pRaw, dataPos, pSchema->bytes, _OVER)
101,700,791✔
174
    SDB_SET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
101,700,791✔
175
  }
176

177
  for (int32_t i = 0; i < pStb->numOfFuncs; ++i) {
17,837,127✔
178
    char *func = taosArrayGet(pStb->pFuncs, i);
×
179
    SDB_SET_BINARY(pRaw, dataPos, func, TSDB_FUNC_NAME_LEN, _OVER)
×
180
  }
181

182
  if (pStb->commentLen > 0) {
17,837,127✔
183
    SDB_SET_BINARY(pRaw, dataPos, pStb->comment, pStb->commentLen + 1, _OVER)
72,399✔
184
  }
185

186
  if (pStb->ast1Len > 0) {
17,837,127✔
187
    SDB_SET_BINARY(pRaw, dataPos, pStb->pAst1, pStb->ast1Len, _OVER)
×
188
  }
189

190
  if (pStb->ast2Len > 0) {
17,837,127✔
191
    SDB_SET_BINARY(pRaw, dataPos, pStb->pAst2, pStb->ast2Len, _OVER)
×
192
  }
193

194
  if (pStb->pCmpr != NULL) {
17,837,127✔
195
    for (int i = 0; i < pStb->numOfColumns; i++) {
1,098,400,901✔
196
      SColCmpr *p = &pStb->pCmpr[i];
1,080,563,774✔
197
      SDB_SET_INT16(pRaw, dataPos, p->id, _OVER)
1,080,563,774✔
198
      SDB_SET_INT32(pRaw, dataPos, p->alg, _OVER)
1,080,563,774✔
199
    }
200
  }
201
  SDB_SET_INT64(pRaw, dataPos, pStb->keep, _OVER)
17,837,127✔
202

203
  if (hasTypeMod) {
17,837,127✔
204
    for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
696,284,241✔
205
      SDB_SET_INT32(pRaw, dataPos, pStb->pExtSchemas[i].typeMod, _OVER);
690,519,935✔
206
    }
207
  }
208

209
  SDB_SET_INT8(pRaw, dataPos, pStb->virtualStb, _OVER)
17,837,127✔
210
  // since 3.4.0.0 - STB_VER_SUPPORT_OWNER
211
  SDB_SET_BINARY(pRaw, dataPos, pStb->createUser, TSDB_USER_LEN, _OVER)
17,837,127✔
212
  SDB_SET_INT64(pRaw, dataPos, pStb->ownerId, _OVER)
17,837,127✔
213
  SDB_SET_INT8(pRaw, dataPos, pStb->secureDelete, _OVER)
17,837,127✔
214
  SDB_SET_UINT32(pRaw, dataPos, pStb->flags, _OVER)
17,837,127✔
215
  SDB_SET_RESERVE(pRaw, dataPos, STB_RESERVE_SIZE, _OVER)
17,837,127✔
216
  SDB_SET_DATALEN(pRaw, dataPos, _OVER)
17,837,127✔
217

218
  terrno = 0;
17,837,127✔
219

220
_OVER:
17,837,127✔
221
  if (terrno != 0) {
17,837,127✔
222
    mError("stb:%s, failed to encode to raw:%p since %s", pStb->name, pRaw, terrstr());
×
223
    sdbFreeRaw(pRaw);
×
224
    return NULL;
×
225
  }
226

227
  mTrace("stb:%s, encode to raw:%p, row:%p", pStb->name, pRaw, pStb);
17,837,127✔
228
  return pRaw;
17,837,127✔
229
}
230

231
SSdbRow *mndStbActionDecode(SSdbRaw *pRaw) {
16,749,454✔
232
  int32_t code = 0;
16,749,454✔
233
  int32_t lino = 0;
16,749,454✔
234
  terrno = TSDB_CODE_OUT_OF_MEMORY;
16,749,454✔
235
  SSdbRow *pRow = NULL;
16,749,454✔
236
  SStbObj *pStb = NULL;
16,749,454✔
237
  bool     hasExtSchemas = false;
16,749,454✔
238

239
  int8_t sver = 0;
16,749,454✔
240
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto _OVER;
16,749,454✔
241

242
  if (sver > STB_VER_NUMBER) {
16,749,454✔
243
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
244
    goto _OVER;
×
245
  }
246

247
  pRow = sdbAllocRow(sizeof(SStbObj));
16,749,454✔
248
  if (pRow == NULL) goto _OVER;
16,749,454✔
249

250
  pStb = sdbGetRowObj(pRow);
16,749,454✔
251
  if (pStb == NULL) goto _OVER;
16,749,454✔
252

253
  int32_t dataPos = 0;
16,749,454✔
254
  SDB_GET_BINARY(pRaw, dataPos, pStb->name, TSDB_TABLE_FNAME_LEN, _OVER)
16,749,454✔
255
  SDB_GET_BINARY(pRaw, dataPos, pStb->db, TSDB_DB_FNAME_LEN, _OVER)
16,749,454✔
256
  SDB_GET_INT64(pRaw, dataPos, &pStb->createdTime, _OVER)
16,749,454✔
257
  SDB_GET_INT64(pRaw, dataPos, &pStb->updateTime, _OVER)
16,749,454✔
258
  SDB_GET_INT64(pRaw, dataPos, &pStb->uid, _OVER)
16,749,454✔
259
  SDB_GET_INT64(pRaw, dataPos, &pStb->dbUid, _OVER)
16,749,454✔
260
  SDB_GET_INT32(pRaw, dataPos, &pStb->tagVer, _OVER)
16,749,454✔
261
  SDB_GET_INT32(pRaw, dataPos, &pStb->colVer, _OVER)
16,749,454✔
262
  SDB_GET_INT32(pRaw, dataPos, &pStb->smaVer, _OVER)
16,749,454✔
263
  SDB_GET_INT32(pRaw, dataPos, &pStb->nextColId, _OVER)
16,749,454✔
264
  SDB_GET_INT64(pRaw, dataPos, &pStb->maxdelay[0], _OVER)
16,749,454✔
265
  SDB_GET_INT64(pRaw, dataPos, &pStb->maxdelay[1], _OVER)
16,749,454✔
266
  SDB_GET_INT64(pRaw, dataPos, &pStb->watermark[0], _OVER)
16,749,454✔
267
  SDB_GET_INT64(pRaw, dataPos, &pStb->watermark[1], _OVER)
16,749,454✔
268
  SDB_GET_INT32(pRaw, dataPos, &pStb->ttl, _OVER)
16,749,454✔
269
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfColumns, _OVER)
16,749,454✔
270
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfTags, _OVER)
16,749,454✔
271
  SDB_GET_INT32(pRaw, dataPos, &pStb->numOfFuncs, _OVER)
16,749,454✔
272
  SDB_GET_INT32(pRaw, dataPos, &pStb->commentLen, _OVER)
16,749,454✔
273
  SDB_GET_INT32(pRaw, dataPos, &pStb->ast1Len, _OVER)
16,749,454✔
274
  SDB_GET_INT32(pRaw, dataPos, &pStb->ast2Len, _OVER)
16,749,454✔
275

276
  pStb->pColumns = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchema));
16,749,454✔
277
  pStb->pTags = taosMemoryCalloc(pStb->numOfTags, sizeof(SSchema));
16,749,454✔
278
  pStb->pFuncs = taosArrayInit(pStb->numOfFuncs, TSDB_FUNC_NAME_LEN);
16,749,454✔
279
  if (pStb->pColumns == NULL || pStb->pTags == NULL || pStb->pFuncs == NULL) {
16,749,454✔
280
    goto _OVER;
×
281
  }
282

283
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
1,828,849,197✔
284
    SSchema *pSchema = &pStb->pColumns[i];
1,812,099,743✔
285
    SDB_GET_INT8(pRaw, dataPos, &pSchema->type, _OVER)
1,812,099,743✔
286
    SDB_GET_INT8(pRaw, dataPos, &pSchema->flags, _OVER)
1,812,099,743✔
287
    SDB_GET_INT16(pRaw, dataPos, &pSchema->colId, _OVER)
1,812,099,743✔
288
    SDB_GET_INT32(pRaw, dataPos, &pSchema->bytes, _OVER)
1,812,099,743✔
289
    SDB_GET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
1,812,099,743✔
290
    hasExtSchemas = hasExtSchemas || HAS_TYPE_MOD(pSchema);
1,812,099,743✔
291
  }
292

293
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
178,693,647✔
294
    SSchema *pSchema = &pStb->pTags[i];
161,944,193✔
295
    SDB_GET_INT8(pRaw, dataPos, &pSchema->type, _OVER)
161,944,193✔
296
    SDB_GET_INT8(pRaw, dataPos, &pSchema->flags, _OVER)
161,944,193✔
297
    SDB_GET_INT16(pRaw, dataPos, &pSchema->colId, _OVER)
161,944,193✔
298
    SDB_GET_INT32(pRaw, dataPos, &pSchema->bytes, _OVER)
161,944,193✔
299
    SDB_GET_BINARY(pRaw, dataPos, pSchema->name, TSDB_COL_NAME_LEN, _OVER)
161,944,193✔
300
  }
301

302
  for (int32_t i = 0; i < pStb->numOfFuncs; ++i) {
16,749,454✔
303
    char funcName[TSDB_FUNC_NAME_LEN] = {0};
×
304
    SDB_GET_BINARY(pRaw, dataPos, funcName, TSDB_FUNC_NAME_LEN, _OVER)
×
305
    if (taosArrayPush(pStb->pFuncs, funcName) == NULL) goto _OVER;
×
306
  }
307

308
  if (pStb->commentLen > 0) {
16,749,454✔
309
    pStb->comment = taosMemoryCalloc(pStb->commentLen + 1, 1);
69,064✔
310
    if (pStb->comment == NULL) goto _OVER;
69,064✔
311
    SDB_GET_BINARY(pRaw, dataPos, pStb->comment, pStb->commentLen + 1, _OVER)
69,064✔
312
  }
313

314
  if (pStb->ast1Len > 0) {
16,749,454✔
315
    pStb->pAst1 = taosMemoryCalloc(pStb->ast1Len, 1);
×
316
    if (pStb->pAst1 == NULL) goto _OVER;
×
317
    SDB_GET_BINARY(pRaw, dataPos, pStb->pAst1, pStb->ast1Len, _OVER)
×
318
  }
319

320
  if (pStb->ast2Len > 0) {
16,749,454✔
321
    pStb->pAst2 = taosMemoryCalloc(pStb->ast2Len, 1);
×
322
    if (pStb->pAst2 == NULL) goto _OVER;
×
323
    SDB_GET_BINARY(pRaw, dataPos, pStb->pAst2, pStb->ast2Len, _OVER)
×
324
  }
325

326
  pStb->pCmpr = taosMemoryCalloc(pStb->numOfColumns, sizeof(SColCmpr));
16,749,454✔
327
  if (sver < STB_VER_SUPPORT_COMP) {
16,749,454✔
328
    // compatible with old data, setup default compress value
329
    // impl later
330
    for (int i = 0; i < pStb->numOfColumns; i++) {
×
331
      SSchema  *pSchema = &pStb->pColumns[i];
×
332
      SColCmpr *pCmpr = &pStb->pCmpr[i];
×
333
      pCmpr->id = pSchema->colId;
×
334
      pCmpr->alg = createDefaultColCmprByType(pSchema->type);
×
335
    }
336
  } else {
337
    for (int i = 0; i < pStb->numOfColumns; i++) {
1,828,849,197✔
338
      SColCmpr *pCmpr = &pStb->pCmpr[i];
1,812,099,743✔
339
      SDB_GET_INT16(pRaw, dataPos, &pCmpr->id, _OVER)
1,812,099,743✔
340
      SDB_GET_INT32(pRaw, dataPos, (int32_t *)&pCmpr->alg, _OVER)  // compatible
1,812,099,743✔
341
    }
342
  }
343
  SDB_GET_INT64(pRaw, dataPos, &pStb->keep, _OVER)
16,749,454✔
344

345
  // type mod
346
  if (hasExtSchemas) {
16,749,454✔
347
    pStb->pExtSchemas = taosMemoryCalloc(pStb->numOfColumns, sizeof(SExtSchema));
7,339,666✔
348
    if (!pStb->pExtSchemas) goto _OVER;
7,339,666✔
349
    for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
1,523,062,853✔
350
      SSchema *pSchema = &pStb->pColumns[i];
1,515,723,187✔
351
      SDB_GET_INT32(pRaw, dataPos, &pStb->pExtSchemas[i].typeMod, _OVER)
1,515,723,187✔
352
    }
353
  }
354

355
  if (sver < STB_VER_SUPPORT_VIRTUAL) {
16,749,454✔
356
    pStb->virtualStb = 0;
×
357
  } else {
358
    SDB_GET_INT8(pRaw, dataPos, &pStb->virtualStb, _OVER)
16,749,454✔
359
  }
360

361
  if (sver < STB_VER_SUPPORT_OWNER) {
16,749,454✔
362
    pStb->createUser[0] = 0;
×
363
  } else {
364
    SDB_GET_BINARY(pRaw, dataPos, pStb->createUser, TSDB_USER_LEN, _OVER)
16,749,454✔
365
    SDB_GET_INT64(pRaw, dataPos, &pStb->ownerId, _OVER)
16,749,454✔
366
  }
367

368
  if (dataPos + sizeof(int8_t) <= pRaw->dataLen) {
16,749,454✔
369
    SDB_GET_INT8(pRaw, dataPos, &pStb->secureDelete, _OVER)
16,749,454✔
370
  } else {
371
    pStb->secureDelete = 0;
×
372
  }
373

374
  if (dataPos + sizeof(uint32_t) <= pRaw->dataLen) {
16,749,454✔
375
    SDB_GET_UINT32(pRaw, dataPos, &pStb->flags, _OVER)
16,749,454✔
376
  } else {
377
    pStb->flags = 0;
×
378
  }
379

380
  SDB_GET_RESERVE(pRaw, dataPos, STB_RESERVE_SIZE, _OVER)
16,749,454✔
381

382
  terrno = 0;
16,749,454✔
383

384
_OVER:
16,749,454✔
385
  if (terrno != 0) {
16,749,454✔
386
    mError("stb:%s, failed to decode from raw:%p since %s", pStb == NULL ? "null" : pStb->name, pRaw, terrstr());
×
387
    if (pStb != NULL) {
×
388
      taosMemoryFreeClear(pStb->pColumns);
×
389
      taosMemoryFreeClear(pStb->pTags);
×
390
      taosMemoryFreeClear(pStb->comment);
×
391
      taosMemoryFree(pStb->pCmpr);
×
392
      taosMemoryFreeClear(pStb->pExtSchemas);
×
393
    }
394
    taosMemoryFreeClear(pRow);
×
395
    return NULL;
×
396
  }
397

398
  mTrace("stb:%s, decode from raw:%p, row:%p", pStb->name, pRaw, pStb);
16,749,454✔
399
  return pRow;
16,749,454✔
400
}
401

402
void mndFreeStb(SStbObj *pStb) {
19,040,738✔
403
  taosArrayDestroy(pStb->pFuncs);
19,040,738✔
404
  taosMemoryFreeClear(pStb->pColumns);
19,040,738✔
405
  taosMemoryFreeClear(pStb->pTags);
19,040,738✔
406
  taosMemoryFreeClear(pStb->comment);
19,040,738✔
407
  taosMemoryFreeClear(pStb->pAst1);
19,040,738✔
408
  taosMemoryFreeClear(pStb->pAst2);
19,040,738✔
409
  taosMemoryFreeClear(pStb->pCmpr);
19,040,738✔
410
  taosMemoryFreeClear(pStb->pExtSchemas);
19,040,738✔
411
}
19,040,738✔
412

413
static int32_t mndStbActionInsert(SSdb *pSdb, SStbObj *pStb) {
2,909,503✔
414
  mTrace("stb:%s, perform insert action, row:%p", pStb->name, pStb);
2,909,503✔
415
  return 0;
2,909,503✔
416
}
417

418
static int32_t mndStbActionDelete(SSdb *pSdb, SStbObj *pStb) {
18,953,873✔
419
  mTrace("stb:%s, perform delete action, row:%p", pStb->name, pStb);
18,953,873✔
420
  mndFreeStb(pStb);
18,953,873✔
421
  return 0;
18,953,873✔
422
}
423

424
static int32_t mndStbActionUpdate(SSdb *pSdb, SStbObj *pOld, SStbObj *pNew) {
12,611,423✔
425
  terrno = 0;
12,611,423✔
426
  mTrace("stb:%s, perform update action, old row:%p new row:%p", pOld->name, pOld, pNew);
12,611,423✔
427

428
  taosWLockLatch(&pOld->lock);
12,611,423✔
429
  int32_t numOfColumns = pOld->numOfColumns;
12,611,423✔
430
  if (pOld->numOfColumns < pNew->numOfColumns) {
12,611,423✔
431
    void *pColumns = taosMemoryMalloc(pNew->numOfColumns * sizeof(SSchema));
2,953,768✔
432
    if (pColumns == NULL) {
2,953,768✔
433
      goto END;
×
434
    }
435
    taosMemoryFree(pOld->pColumns);
2,953,768✔
436
    pOld->pColumns = pColumns;
2,953,768✔
437
  }
438

439
  if (pOld->numOfTags < pNew->numOfTags) {
12,611,423✔
440
    void *pTags = taosMemoryMalloc(pNew->numOfTags * sizeof(SSchema));
328,094✔
441
    if (pTags == NULL) {
328,094✔
442
      goto END;
×
443
    }
444
    taosMemoryFree(pOld->pTags);
328,094✔
445
    pOld->pTags = pTags;
328,094✔
446
  }
447

448
  if (pOld->commentLen < pNew->commentLen && pNew->commentLen > 0) {
12,611,423✔
449
    void *comment = taosMemoryMalloc(pNew->commentLen + 1);
6,732✔
450
    if (comment == NULL) {
6,732✔
451
      goto END;
×
452
    }
453
    taosMemoryFree(pOld->comment);
6,732✔
454
    pOld->comment = comment;
6,732✔
455
  }
456
  pOld->commentLen = pNew->commentLen;
12,611,423✔
457

458
  if (pOld->ast1Len < pNew->ast1Len) {
12,611,423✔
459
    void *pAst1 = taosMemoryMalloc(pNew->ast1Len + 1);
×
460
    if (pAst1 == NULL) {
×
461
      goto END;
×
462
    }
463
    taosMemoryFree(pOld->pAst1);
×
464
    pOld->pAst1 = pAst1;
×
465
  }
466

467
  if (pOld->ast2Len < pNew->ast2Len) {
12,611,423✔
468
    void *pAst2 = taosMemoryMalloc(pNew->ast2Len + 1);
×
469
    if (pAst2 == NULL) {
×
470
      goto END;
×
471
    }
472
    taosMemoryFree(pOld->pAst2);
×
473
    pOld->pAst2 = pAst2;
×
474
  }
475

476
  pOld->updateTime = pNew->updateTime;
12,611,423✔
477
  pOld->tagVer = pNew->tagVer;
12,611,423✔
478
  pOld->colVer = pNew->colVer;
12,611,423✔
479
  pOld->smaVer = pNew->smaVer;
12,611,423✔
480
  pOld->nextColId = pNew->nextColId;
12,611,423✔
481
  pOld->ttl = pNew->ttl;
12,611,423✔
482
  pOld->keep = pNew->keep;
12,611,423✔
483
  pOld->ownerId = pNew->ownerId;
12,611,423✔
484
  pOld->secureDelete = pNew->secureDelete;
12,611,423✔
485
  pOld->flags = pNew->flags;
12,611,423✔
486

487
  if (pNew->numOfColumns > 0) {
12,611,423✔
488
    pOld->numOfColumns = pNew->numOfColumns;
12,611,423✔
489
    memcpy(pOld->pColumns, pNew->pColumns, pOld->numOfColumns * sizeof(SSchema));
12,611,423✔
490
  }
491
  if (pNew->numOfTags > 0) {
12,611,423✔
492
    pOld->numOfTags = pNew->numOfTags;
12,611,423✔
493
    memcpy(pOld->pTags, pNew->pTags, pOld->numOfTags * sizeof(SSchema));
12,611,423✔
494
  }
495
  if (pNew->commentLen > 0) {
12,611,423✔
496
    memcpy(pOld->comment, pNew->comment, pNew->commentLen + 1);
45,759✔
497
    pOld->commentLen = pNew->commentLen;
45,759✔
498
  }
499
  if (pNew->ast1Len != 0) {
12,611,423✔
500
    memcpy(pOld->pAst1, pNew->pAst1, pNew->ast1Len);
×
501
    pOld->ast1Len = pNew->ast1Len;
×
502
  }
503
  if (pNew->ast2Len != 0) {
12,611,423✔
504
    memcpy(pOld->pAst2, pNew->pAst2, pNew->ast2Len);
×
505
    pOld->ast2Len = pNew->ast2Len;
×
506
  }
507
  if (numOfColumns < pNew->numOfColumns) {
12,611,423✔
508
    taosMemoryFree(pOld->pCmpr);
2,953,768✔
509
    pOld->pCmpr = taosMemoryCalloc(pNew->numOfColumns, sizeof(SColCmpr));
2,953,768✔
510
    if (pOld->pCmpr == NULL){
2,953,768✔
511
      goto END;
×
512
    }
513
    memcpy(pOld->pCmpr, pNew->pCmpr, pNew->numOfColumns * sizeof(SColCmpr));
2,953,768✔
514
  } else {
515
    memcpy(pOld->pCmpr, pNew->pCmpr, pNew->numOfColumns * sizeof(SColCmpr));
9,657,655✔
516
  }
517

518
  if (pNew->pExtSchemas) {
12,611,423✔
519
    taosMemoryFreeClear(pOld->pExtSchemas);
7,268,231✔
520
    pOld->pExtSchemas = taosMemoryCalloc(pNew->numOfColumns, sizeof(SExtSchema));
7,268,231✔
521
    if (pOld->pExtSchemas == NULL){
7,268,231✔
522
      goto END;
×
523
    }
524
    memcpy(pOld->pExtSchemas, pNew->pExtSchemas, pNew->numOfColumns * sizeof(SExtSchema));
7,268,231✔
525
  }
526

527
END:
5,343,192✔
528
  taosWUnLockLatch(&pOld->lock);
12,611,423✔
529
  return terrno;
12,611,423✔
530
}
531

532
SStbObj *mndAcquireStb(SMnode *pMnode, char *stbName) {
40,098,956✔
533
  SSdb    *pSdb = pMnode->pSdb;
40,098,956✔
534
  SStbObj *pStb = sdbAcquire(pSdb, SDB_STB, stbName);
40,098,956✔
535
  if (pStb == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
40,098,956✔
536
    terrno = TSDB_CODE_MND_STB_NOT_EXIST;
3,634,239✔
537
  }
538
  return pStb;
40,098,956✔
539
}
540

541
void mndReleaseStb(SMnode *pMnode, SStbObj *pStb) {
39,270,642✔
542
  SSdb *pSdb = pMnode->pSdb;
39,270,642✔
543
  sdbRelease(pSdb, pStb);
39,270,642✔
544
}
39,270,642✔
545

546
SDbObj *mndAcquireDbByStb(SMnode *pMnode, const char *stbName) {
9,166,409✔
547
  SName name = {0};
9,166,409✔
548
  if ((terrno = tNameFromString(&name, stbName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) return NULL;
9,166,409✔
549

550
  char db[TSDB_TABLE_FNAME_LEN] = {0};
9,166,409✔
551
  if ((terrno = tNameGetFullDbName(&name, db)) != 0) return NULL;
9,166,409✔
552

553
  return mndAcquireDb(pMnode, db);
9,166,409✔
554
}
555

556
static FORCE_INLINE int32_t schemaExColIdCompare(const void *colId, const void *pSchema) {
557
  if (*(col_id_t *)colId < ((SSchema *)pSchema)->colId) {
558
    return -1;
559
  } else if (*(col_id_t *)colId > ((SSchema *)pSchema)->colId) {
560
    return 1;
561
  }
562
  return 0;
563
}
564

565
void *mndBuildVCreateStbReq(SMnode *pMnode, SVgObj *pVgroup, SStbObj *pStb, int32_t *pContLen, void *alterOriData,
12,362,105✔
566
                            int32_t alterOriDataLen) {
567
  SEncoder       encoder = {0};
12,362,105✔
568
  int32_t        contLen;
569
  SName          name = {0};
12,362,105✔
570
  SVCreateStbReq req = {0};
12,362,105✔
571

572
  if ((terrno = tNameFromString(&name, pStb->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
12,362,105✔
573
    goto _err;
×
574
  }
575
  char dbFName[TSDB_DB_FNAME_LEN] = {0};
12,362,105✔
576
  if ((terrno = tNameGetFullDbName(&name, dbFName)) != 0) {
12,362,105✔
577
    goto _err;
×
578
  };
579

580
  req.name = (char *)tNameGetTableName(&name);
12,362,105✔
581
  req.suid = pStb->uid;
12,362,105✔
582
  req.rollup = pStb->ast1Len > 0 ? 1 : 0;
12,362,105✔
583
  req.alterOriData = alterOriData;
12,362,105✔
584
  req.alterOriDataLen = alterOriDataLen;
12,362,105✔
585
  req.source = pStb->source;
12,362,105✔
586
  req.virtualStb = pStb->virtualStb;
12,362,105✔
587
  req.secureDelete = pStb->secureDelete;
12,362,105✔
588
  req.securityLevel = pStb->securityLevel;
12,362,105✔
589
  // todo
590
  req.schemaRow.nCols = pStb->numOfColumns;
12,362,105✔
591
  req.schemaRow.version = pStb->colVer;
12,362,105✔
592
  req.schemaRow.pSchema = pStb->pColumns;
12,362,105✔
593
  req.schemaTag.nCols = pStb->numOfTags;
12,362,105✔
594
  req.schemaTag.version = pStb->tagVer;
12,362,105✔
595
  req.schemaTag.pSchema = pStb->pTags;
12,362,105✔
596

597
  req.colCmpred = 1;
12,362,105✔
598
  SColCmprWrapper *pCmpr = &req.colCmpr;
12,362,105✔
599
  req.keep = pStb->keep;
12,362,105✔
600
  pCmpr->version = pStb->colVer;
12,362,105✔
601
  pCmpr->nCols = pStb->numOfColumns;
12,362,105✔
602

603
  req.colCmpr.pColCmpr = taosMemoryCalloc(pCmpr->nCols, sizeof(SColCmpr));
12,362,105✔
604
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
1,054,828,009✔
605
    SColCmpr *p = &pCmpr->pColCmpr[i];
1,042,465,904✔
606
    p->alg = pStb->pCmpr[i].alg;
1,042,465,904✔
607
    p->id = pStb->pCmpr[i].id;
1,042,465,904✔
608
  }
609

610
  req.pExtSchemas = pStb->pExtSchemas; // only reference to it.
12,362,105✔
611
  // get length
612
  int32_t ret = 0;
12,362,105✔
613
  tEncodeSize(tEncodeSVCreateStbReq, &req, contLen, ret);
12,362,105✔
614
  if (ret < 0) {
12,362,105✔
615
    goto _err;
×
616
  }
617

618
  contLen += sizeof(SMsgHead);
12,362,105✔
619

620
  SMsgHead *pHead = taosMemoryCalloc(1, contLen);
12,362,105✔
621
  if (pHead == NULL) {
12,362,105✔
622
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
623
    goto _err;
×
624
  }
625

626
  pHead->contLen = htonl(contLen);
12,362,105✔
627
  pHead->vgId = htonl(pVgroup->vgId);
12,362,105✔
628

629
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
12,362,105✔
630
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
12,362,105✔
631
  if (tEncodeSVCreateStbReq(&encoder, &req) < 0) {
12,362,105✔
632
    taosMemoryFreeClear(pHead);
×
633
    tEncoderClear(&encoder);
×
634
    goto _err;
×
635
  }
636
  tEncoderClear(&encoder);
12,362,105✔
637

638
  *pContLen = contLen;
12,362,105✔
639
  taosMemoryFreeClear(req.rsmaParam.name);
12,362,105✔
640
  taosMemoryFreeClear(req.rsmaParam.funcColIds);
12,362,105✔
641
  taosMemoryFreeClear(req.rsmaParam.funcIds);
12,362,105✔
642
  taosMemoryFreeClear(req.colCmpr.pColCmpr);
12,362,105✔
643
  return pHead;
12,362,105✔
644
_err:
×
645
  taosMemoryFreeClear(req.rsmaParam.name);
×
646
  taosMemoryFreeClear(req.rsmaParam.funcColIds);
×
647
  taosMemoryFreeClear(req.rsmaParam.funcIds);
×
648
  taosMemoryFreeClear(req.colCmpr.pColCmpr);
×
649
  return NULL;
×
650
}
651

652
static void *mndBuildVDropStbReq(SMnode *pMnode, SVgObj *pVgroup, SStbObj *pStb, int32_t *pContLen) {
6,127,047✔
653
  SName        name = {0};
6,127,047✔
654
  SVDropStbReq req = {0};
6,127,047✔
655
  int32_t      contLen = 0;
6,127,047✔
656
  int32_t      ret = 0;
6,127,047✔
657
  SMsgHead    *pHead = NULL;
6,127,047✔
658
  SEncoder     encoder = {0};
6,127,047✔
659

660
  if ((terrno = tNameFromString(&name, pStb->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
6,127,047✔
661
    return NULL;
×
662
  }
663

664
  req.name = (char *)tNameGetTableName(&name);
6,127,047✔
665
  req.suid = pStb->uid;
6,127,047✔
666

667
  tEncodeSize(tEncodeSVDropStbReq, &req, contLen, ret);
6,127,047✔
668
  if (ret < 0) return NULL;
6,127,047✔
669

670
  contLen += sizeof(SMsgHead);
6,127,047✔
671
  pHead = taosMemoryMalloc(contLen);
6,127,047✔
672
  if (pHead == NULL) {
6,127,047✔
673
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
674
    return NULL;
×
675
  }
676

677
  pHead->contLen = htonl(contLen);
6,127,047✔
678
  pHead->vgId = htonl(pVgroup->vgId);
6,127,047✔
679

680
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
6,127,047✔
681

682
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
6,127,047✔
683
  int32_t code = tEncodeSVDropStbReq(&encoder, &req);
6,127,047✔
684
  tEncoderClear(&encoder);
6,127,047✔
685
  if (code != 0) {
6,127,047✔
686
    terrno = code;
×
687
    return NULL;
×
688
  }
689

690
  *pContLen = contLen;
6,127,047✔
691
  return pHead;
6,127,047✔
692
}
693

694
int32_t mndCheckCreateStbReq(SMCreateStbReq *pCreate) {
2,351,353✔
695
  int32_t code = 0;
2,351,353✔
696
  if (pCreate->igExists < 0 || pCreate->igExists > 1) {
2,351,353✔
697
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
698
    TAOS_RETURN(code);
×
699
  }
700

701
  if (pCreate->virtualStb != 0 && pCreate->virtualStb != 1) {
2,351,353✔
702
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
703
    TAOS_RETURN(code);
×
704
  }
705

706
  int32_t maxColumns = pCreate->virtualStb ? TSDB_MAX_COLUMNS : TSDB_MAX_COLUMNS_NON_VIRTUAL;
2,351,353✔
707
  if (pCreate->numOfColumns < TSDB_MIN_COLUMNS || pCreate->numOfTags + pCreate->numOfColumns > maxColumns) {
2,351,353✔
708
    code = TSDB_CODE_PAR_INVALID_COLUMNS_NUM;
×
709
    TAOS_RETURN(code);
×
710
  }
711

712
  if (pCreate->numOfTags <= 0 || pCreate->numOfTags > TSDB_MAX_TAGS) {
2,351,353✔
713
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
714
    TAOS_RETURN(code);
×
715
  }
716

717
  SField *pField = taosArrayGet(pCreate->pColumns, 0);
2,351,353✔
718
  if (pField->type != TSDB_DATA_TYPE_TIMESTAMP) {
2,351,353✔
719
    code = TSDB_CODE_PAR_INVALID_FIRST_COLUMN;
×
720
    TAOS_RETURN(code);
×
721
  }
722

723
  for (int32_t i = 0; i < pCreate->numOfColumns; ++i) {
174,598,853✔
724
    SFieldWithOptions *pField1 = taosArrayGet(pCreate->pColumns, i);
172,247,500✔
725
    if (pField1->type >= TSDB_DATA_TYPE_MAX) {
172,247,500✔
726
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
727
      TAOS_RETURN(code);
×
728
    }
729
    if (pField1->bytes <= 0) {
172,247,500✔
730
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
731
      TAOS_RETURN(code);
×
732
    }
733
    if (pField1->name[0] == 0) {
172,247,500✔
734
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
735
      TAOS_RETURN(code);
×
736
    }
737
  }
738

739
  for (int32_t i = 0; i < pCreate->numOfTags; ++i) {
11,849,684✔
740
    SField *pField1 = taosArrayGet(pCreate->pTags, i);
9,498,331✔
741
    if (pField1->type >= TSDB_DATA_TYPE_MAX) {
9,498,331✔
742
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
743
      TAOS_RETURN(code);
×
744
    }
745
    if (pField1->bytes <= 0) {
9,498,331✔
746
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
747
      TAOS_RETURN(code);
×
748
    }
749
    if (pField1->name[0] == 0) {
9,498,331✔
750
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
751
      TAOS_RETURN(code);
×
752
    }
753
  }
754

755
  TAOS_RETURN(code);
2,351,353✔
756
}
757

758
static int32_t mndSetCreateStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
×
759
  int32_t  code = 0;
×
760
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
×
761
  if (pRedoRaw == NULL) {
×
762
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
763
    if (terrno != 0) code = terrno;
×
764
    TAOS_RETURN(code);
×
765
  }
766
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
×
767
    sdbFreeRaw(pRedoRaw);
×
768
    TAOS_RETURN(code);
×
769
  }
770
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_CREATING));
×
771

772
  TAOS_RETURN(code);
×
773
}
774

775
int32_t mndSetCreateStbCommitLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
2,280,863✔
776
  int32_t  code = 0;
2,280,863✔
777
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
2,280,863✔
778
  if (pCommitRaw == NULL) {
2,280,863✔
779
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
780
    if (terrno != 0) code = terrno;
×
781
    TAOS_RETURN(code);
×
782
  }
783
  mInfo("trans:%d, add stb to commit log", pTrans->id);
2,280,863✔
784
  if ((code = mndTransAppendCommitlog(pTrans, pCommitRaw)) != 0) {
2,280,863✔
785
    sdbFreeRaw(pCommitRaw);
×
786
    TAOS_RETURN(code);
×
787
  }
788
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
2,280,863✔
789

790
  TAOS_RETURN(code);
2,280,863✔
791
}
792

793
static int32_t mndSetCreateStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
2,278,358✔
794
  int32_t code = 0;
2,278,358✔
795
  SSdb   *pSdb = pMnode->pSdb;
2,278,358✔
796
  SVgObj *pVgroup = NULL;
2,278,358✔
797
  void   *pIter = NULL;
2,278,358✔
798
  int32_t contLen;
2,275,645✔
799

800
  while (1) {
10,198,466✔
801
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
12,476,824✔
802
    if (pIter == NULL) break;
12,476,824✔
803
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
10,198,466✔
804
      sdbRelease(pSdb, pVgroup);
5,112,732✔
805
      continue;
5,112,732✔
806
    }
807

808
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
5,085,734✔
809
    if (pReq == NULL) {
5,085,734✔
810
      sdbCancelFetch(pSdb, pIter);
×
811
      sdbRelease(pSdb, pVgroup);
×
812
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
813
      if (terrno != 0) code = terrno;
×
814
      TAOS_RETURN(code);
×
815
    }
816

817
    STransAction action = {0};
5,085,734✔
818
    action.mTraceId = pTrans->mTraceId;
5,085,734✔
819
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
5,085,734✔
820
    action.pCont = pReq;
5,085,734✔
821
    action.contLen = contLen;
5,085,734✔
822
    action.msgType = TDMT_VND_CREATE_STB;
5,085,734✔
823
    action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
5,085,734✔
824
    action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
5,085,734✔
825
    mInfo("trans:%d, add create stb to redo action", pTrans->id);
5,085,734✔
826
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
5,085,734✔
827
      taosMemoryFree(pReq);
×
828
      sdbCancelFetch(pSdb, pIter);
×
829
      sdbRelease(pSdb, pVgroup);
×
830
      TAOS_RETURN(code);
×
831
    }
832
    sdbRelease(pSdb, pVgroup);
5,085,734✔
833
  }
834

835
  TAOS_RETURN(code);
2,278,358✔
836
}
837

838
int32_t mndSetForceDropCreateStbRedoActions(SMnode *pMnode, STrans *pTrans, SVgObj *pVgroup, SStbObj *pStb) {
×
839
  int32_t code = 0;
×
840
  SSdb   *pSdb = pMnode->pSdb;
×
841
  int32_t contLen;
×
842

843
  void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
×
844
  if (pReq == NULL) {
×
845
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
846
    if (terrno != 0) code = terrno;
×
847
    TAOS_RETURN(code);
×
848
  }
849

850
  STransAction action = {0};
×
851
  action.mTraceId = pTrans->mTraceId;
×
852
  action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
×
853
  action.pCont = pReq;
×
854
  action.contLen = contLen;
×
855
  action.msgType = TDMT_VND_CREATE_STB;
×
856
  action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
×
857
  action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
×
858
  action.groupId = pVgroup->vgId;
×
859
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
×
860
    taosMemoryFree(pReq);
×
861
    TAOS_RETURN(code);
×
862
  }
863

864
  TAOS_RETURN(code);
×
865
}
866

867
static int32_t mndSetCreateStbUndoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
2,278,358✔
868
  int32_t code = 0;
2,278,358✔
869
  SSdb   *pSdb = pMnode->pSdb;
2,278,358✔
870
  SVgObj *pVgroup = NULL;
2,278,358✔
871
  void   *pIter = NULL;
2,278,358✔
872

873
  while (1) {
10,198,466✔
874
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
12,476,824✔
875
    if (pIter == NULL) break;
12,476,824✔
876
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
10,198,466✔
877
      sdbRelease(pSdb, pVgroup);
5,112,732✔
878
      continue;
5,112,732✔
879
    }
880

881
    int32_t contLen = 0;
5,085,734✔
882
    void   *pReq = mndBuildVDropStbReq(pMnode, pVgroup, pStb, &contLen);
5,085,734✔
883
    if (pReq == NULL) {
5,085,734✔
884
      sdbCancelFetch(pSdb, pIter);
×
885
      sdbRelease(pSdb, pVgroup);
×
886
      code = TSDB_CODE_OUT_OF_MEMORY;
×
887
      TAOS_RETURN(code);
×
888
    }
889

890
    STransAction action = {0};
5,085,734✔
891
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
5,085,734✔
892
    action.pCont = pReq;
5,085,734✔
893
    action.contLen = contLen;
5,085,734✔
894
    action.msgType = TDMT_VND_DROP_STB;
5,085,734✔
895
    action.acceptableCode = TSDB_CODE_TDB_STB_NOT_EXIST;
5,085,734✔
896
    mInfo("trans:%d, add drop stb to undo action", pTrans->id);
5,085,734✔
897
    if ((code = mndTransAppendUndoAction(pTrans, &action)) != 0) {
5,085,734✔
898
      taosMemoryFree(pReq);
×
899
      sdbCancelFetch(pSdb, pIter);
×
900
      sdbRelease(pSdb, pVgroup);
×
901
      TAOS_RETURN(code);
×
902
    }
903
    sdbRelease(pSdb, pVgroup);
5,085,734✔
904
  }
905

906
  TAOS_RETURN(code);
2,278,358✔
907
}
908

909
static SSchema *mndFindStbColumns(const SStbObj *pStb, const char *colName) {
×
910
  for (int32_t col = 0; col < pStb->numOfColumns; ++col) {
×
911
    SSchema *pSchema = &pStb->pColumns[col];
×
912
    if (taosStrncasecmp(pSchema->name, colName, TSDB_COL_NAME_LEN) == 0) {
×
913
      return pSchema;
×
914
    }
915
  }
916
  return NULL;
×
917
}
918

919
int32_t mndBuildStbFromReq(SMnode *pMnode, SStbObj *pDst, SMCreateStbReq *pCreate, SDbObj *pDb) {
2,288,779✔
920
  int32_t code = 0;
2,288,779✔
921
  bool    hasTypeMods = false;
2,288,779✔
922
  memcpy(pDst->name, pCreate->name, TSDB_TABLE_FNAME_LEN);
2,288,779✔
923
  memcpy(pDst->db, pDb->name, TSDB_DB_FNAME_LEN);
2,288,779✔
924
  pDst->createdTime = taosGetTimestampMs();
2,288,779✔
925
  pDst->updateTime = pDst->createdTime;
2,288,779✔
926
  pDst->uid = (pCreate->source == TD_REQ_FROM_TAOX_OLD || pCreate->source == TD_REQ_FROM_TAOX || pCreate->source == TD_REQ_FROM_SML)
6,860,911✔
927
                  ? pCreate->suid
928
                  : mndGenerateUid(pCreate->name, TSDB_TABLE_FNAME_LEN);
4,577,558✔
929
  pDst->dbUid = pDb->uid;
2,288,779✔
930
  pDst->tagVer = 1;
2,288,779✔
931
  pDst->colVer = 1;
2,288,779✔
932
  pDst->smaVer = 1;
2,288,779✔
933
  pDst->nextColId = 1;
2,288,779✔
934
  pDst->maxdelay[0] = pCreate->delay1;
2,288,779✔
935
  pDst->maxdelay[1] = pCreate->delay2;
2,288,779✔
936
  pDst->watermark[0] = pCreate->watermark1;
2,288,779✔
937
  pDst->watermark[1] = pCreate->watermark2;
2,288,779✔
938
  pDst->ttl = pCreate->ttl;
2,288,779✔
939
  pDst->numOfColumns = pCreate->numOfColumns;
2,288,779✔
940
  pDst->numOfTags = pCreate->numOfTags;
2,288,779✔
941
  pDst->numOfFuncs = pCreate->numOfFuncs;
2,288,779✔
942
  pDst->commentLen = pCreate->commentLen;
2,288,779✔
943
  pDst->pFuncs = pCreate->pFuncs;
2,288,779✔
944
  pDst->source = pCreate->source;
2,288,779✔
945
  pDst->keep = pCreate->keep;
2,288,779✔
946
  pDst->virtualStb = pCreate->virtualStb;
2,288,779✔
947
  pDst->secureDelete = pCreate->secureDelete;
2,288,779✔
948
  pCreate->pFuncs = NULL;
2,288,779✔
949

950
  if (pDst->commentLen > 0) {
2,288,779✔
951
    pDst->comment = taosMemoryCalloc(pDst->commentLen + 1, 1);
9,963✔
952
    if (pDst->comment == NULL) {
9,963✔
953
      code = terrno;
×
954
      TAOS_RETURN(code);
×
955
    }
956
    memcpy(pDst->comment, pCreate->pComment, pDst->commentLen + 1);
9,963✔
957
  }
958

959
  pDst->ast1Len = pCreate->ast1Len;
2,288,779✔
960
  if (pDst->ast1Len > 0) {
2,288,779✔
961
    pDst->pAst1 = taosMemoryCalloc(pDst->ast1Len, 1);
×
962
    if (pDst->pAst1 == NULL) {
×
963
      code = terrno;
×
964
      TAOS_RETURN(code);
×
965
    }
966
    memcpy(pDst->pAst1, pCreate->pAst1, pDst->ast1Len);
×
967
  }
968

969
  pDst->ast2Len = pCreate->ast2Len;
2,288,779✔
970
  if (pDst->ast2Len > 0) {
2,288,779✔
971
    pDst->pAst2 = taosMemoryCalloc(pDst->ast2Len, 1);
×
972
    if (pDst->pAst2 == NULL) {
×
973
      code = terrno;
×
974
      TAOS_RETURN(code);
×
975
    }
976
    memcpy(pDst->pAst2, pCreate->pAst2, pDst->ast2Len);
×
977
  }
978

979
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
2,288,779✔
980
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
2,288,779✔
981
  if (pDst->pColumns == NULL || pDst->pTags == NULL) {
2,288,779✔
982
    code = terrno;
×
983
    TAOS_RETURN(code);
×
984
  }
985

986
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
2,288,779✔
987
    code = TSDB_CODE_OUT_OF_RANGE;
1,234✔
988
    TAOS_RETURN(code);
1,234✔
989
  }
990

991
  for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
133,744,234✔
992
    SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
131,456,689✔
993
    SSchema           *pSchema = &pDst->pColumns[i];
131,456,689✔
994
    pSchema->type = pField->type;
131,456,689✔
995
    pSchema->bytes = pField->bytes;
131,456,689✔
996
    pSchema->flags = pField->flags;
131,456,689✔
997
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
131,456,689✔
998
    pSchema->colId = pDst->nextColId;
131,456,689✔
999
    pDst->nextColId++;
131,456,689✔
1000
    hasTypeMods = hasTypeMods || HAS_TYPE_MOD(pSchema);
131,456,689✔
1001
  }
1002

1003
  for (int32_t i = 0; i < pDst->numOfTags; ++i) {
11,482,855✔
1004
    SField  *pField = taosArrayGet(pCreate->pTags, i);
9,195,310✔
1005
    SSchema *pSchema = &pDst->pTags[i];
9,195,310✔
1006
    pSchema->type = pField->type;
9,195,310✔
1007
    pSchema->bytes = pField->bytes;
9,195,310✔
1008
    if (i == 0) {
9,195,310✔
1009
      SSCHMEA_SET_IDX_ON(pSchema);
2,287,545✔
1010
    }
1011
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
9,195,310✔
1012
    pSchema->colId = pDst->nextColId;
9,195,310✔
1013
    pDst->nextColId++;
9,195,310✔
1014
  }
1015
  // set col compress
1016
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SCmprObj));
2,287,545✔
1017
  for (int32_t i = 0; i < pDst->numOfColumns; i++) {
133,744,234✔
1018
    SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
131,456,689✔
1019
    SSchema           *pSchema = &pDst->pColumns[i];
131,456,689✔
1020

1021
    SColCmpr *pColCmpr = &pDst->pCmpr[i];
131,456,689✔
1022
    pColCmpr->id = pSchema->colId;
131,456,689✔
1023
    pColCmpr->alg = pField->compress;
131,456,689✔
1024
  }
1025

1026
  if (hasTypeMods) {
2,287,545✔
1027
    pDst->pExtSchemas = taosMemoryCalloc(pDst->numOfColumns, sizeof(SExtSchema));
29,419✔
1028
    if (!pDst->pExtSchemas) {
29,419✔
1029
      code = terrno;
×
1030
      TAOS_RETURN(code);
×
1031
    }
1032
    for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
396,422✔
1033
      SFieldWithOptions * pField = taosArrayGet(pCreate->pColumns, i);
367,003✔
1034
      pDst->pExtSchemas[i].typeMod = pField->typeMod;
367,003✔
1035
    }
1036
  }
1037
  TAOS_RETURN(code);
2,287,545✔
1038
}
1039
int32_t mndGenIdxNameForFirstTag(char *fullname, char *dbname, char *stbname, char *tagname) {
2,205,339✔
1040
  SName name = {0};
2,205,339✔
1041
  if ((terrno = tNameFromString(&name, stbname, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0) {
2,205,339✔
1042
    return -1;
×
1043
  }
1044
  return snprintf(fullname, TSDB_INDEX_FNAME_LEN, "%s.%s_%s", dbname, tagname, tNameGetTableName(&name));
2,205,339✔
1045
}
1046

1047
static int32_t mndCreateStb(SMnode *pMnode, SRpcMsg *pReq, SMCreateStbReq *pCreate, SDbObj *pDb, SUserObj *pOperUser) {
2,204,068✔
1048
  SStbObj stbObj = {0};
2,204,068✔
1049
  int32_t code = -1;
2,204,068✔
1050

1051
  char fullIdxName[TSDB_INDEX_FNAME_LEN * 2] = {0};
2,204,068✔
1052

1053
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_ROLLBACK, TRN_CONFLICT_DB_INSIDE, pReq, "create-stb");
2,204,068✔
1054
  if (pTrans == NULL) {
2,204,068✔
1055
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
1056
    if (terrno != 0) code = terrno;
×
1057
    goto _OVER;
×
1058
  }
1059

1060
  mInfo("trans:%d, used to create stb:%s", pTrans->id, pCreate->name);
2,204,068✔
1061
  TAOS_CHECK_GOTO(mndBuildStbFromReq(pMnode, &stbObj, pCreate, pDb), NULL, _OVER);
2,204,068✔
1062
  memcpy(stbObj.createUser, pOperUser->name, TSDB_USER_LEN);
2,202,834✔
1063
  stbObj.ownerId = pOperUser->uid;
2,202,834✔
1064

1065
#ifdef TD_ENTERPRISE
1066
  // MAC: reject CREATE STABLE if user.maxSecLevel < db.securityLevel (NRU: low-priv user
1067
  // should not create objects in high-level DBs; in practice, USE DB already blocks this)
1068
  // Only enforced when MAC is explicitly activated cluster-wide.
1069
  // Trusted subjects (PRIV_SECURITY_POLICY_ALTER, directly or via any role that carries that
1070
  // privilege; when MAC is mandatory the holder must have maxSecLevel=4) are exempt.
1071
  bool hasMacLabelPriv = mndUserHasMacLabelPriv(pMnode, pOperUser);
2,202,834✔
1072
  if (pMnode->macActive == MAC_MODE_MANDATORY && !hasMacLabelPriv && pOperUser->maxSecLevel < pDb->cfg.securityLevel) {
2,202,834✔
1073
    code = TSDB_CODE_MAC_INSUFFICIENT_LEVEL;
×
1074
    mError("stb:%s, failed to create, user %s maxSecLevel(%d) < db securityLevel(%d)",
×
1075
           pCreate->name, pOperUser->user, pOperUser->maxSecLevel, pDb->cfg.securityLevel);
1076
    goto _OVER;
×
1077
  }
1078

1079
  // MAC: STB default securityLevel = max(creator.maxSecLevel, db.securityLevel)
1080
  // If the CREATE request specifies a securityLevel AND user has PRIV_SECURITY_POLICY_ALTER, honor it.
1081
  // (check both direct priv and role inheritance: SYSSEC role carries PRIV_SECURITY_POLICY_ALTER)
1082
  // Per FS §4.2.1.4: specifying securityLevel > 0 without PRIV_SECURITY_POLICY_ALTER is rejected;
1083
  //                  securityLevel == 0 is always allowed (equivalent to default).
1084
  if (pCreate->securityLevel > 0 && !hasMacLabelPriv) {
2,202,834✔
1085
    code = TSDB_CODE_MND_NO_RIGHTS;
×
1086
    mError("stb:%s, failed to create, user %s lacks PRIV_SECURITY_POLICY_ALTER to set security_level > 0",
×
1087
           pCreate->name, pOperUser->user);
1088
    goto _OVER;
×
1089
  }
1090
  if (pCreate->securityLevel > 0 && hasMacLabelPriv) {
2,202,834✔
1091
    // MAC must be active to set stb security_level > 0; before activation only user levels can be set.
1092
    if (pMnode->macActive != MAC_MODE_MANDATORY) {
×
1093
      code = TSDB_CODE_MAC_INSUFFICIENT_LEVEL;
×
1094
      mError("stb:%s, failed to create, cannot set security_level > 0 before MAC is activated", pCreate->name);
×
1095
      goto _OVER;
×
1096
    }
1097
    if (pCreate->securityLevel < pDb->cfg.securityLevel) {
×
1098
      code = TSDB_CODE_MAC_INSUFFICIENT_LEVEL;
×
1099
      mError("stb:%s, failed to create, requested securityLevel(%d) < db securityLevel(%d)", pCreate->name,
×
1100
             pCreate->securityLevel, pDb->cfg.securityLevel);
1101
      goto _OVER;
×
1102
    }
1103
    stbObj.securityLevel = (uint8_t)pCreate->securityLevel;
×
1104
  } else if (pCreate->securityLevel == 0) {
2,202,834✔
1105
    // Explicitly specified as 0: no extra privilege or MAC precondition is required.
1106
    stbObj.securityLevel = 0;
406,106✔
1107
  } else if (pMnode->macActive == MAC_MODE_MANDATORY) {
1,796,728✔
1108
    // MAC active: STB inherits max(creator.maxSecLevel, db.securityLevel)
1109
    uint8_t userMax = pOperUser->maxSecLevel;
1,480✔
1110
    uint8_t dbLevel = pDb->cfg.securityLevel;
1,480✔
1111
    stbObj.securityLevel = (userMax > dbLevel) ? userMax : dbLevel;
1,480✔
1112
  } else {
1113
    // MAC not active: default security_level = 0
1114
    stbObj.securityLevel = 0;
1,795,248✔
1115
  }
1116
#endif
1117

1118
  SSchema *pSchema = &(stbObj.pTags[0]);
2,202,834✔
1119
  if (mndGenIdxNameForFirstTag(fullIdxName, pDb->name, stbObj.name, pSchema->name) < 0) {
2,202,834✔
1120
    code = terrno;
×
1121
    goto _OVER;
×
1122
  }
1123
  SSIdx idx = {0};
2,202,834✔
1124
  if (mndAcquireGlobalIdx(pMnode, fullIdxName, SDB_IDX, &idx) == 0 && idx.pIdx != NULL) {
2,202,834✔
1125
    code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
×
1126
    mndReleaseIdx(pMnode, idx.pIdx);
×
1127
    goto _OVER;
×
1128
  }
1129

1130
  SIdxObj idxObj = {0};
2,202,834✔
1131
  memcpy(idxObj.name, fullIdxName, TSDB_INDEX_FNAME_LEN);
2,202,834✔
1132
  memcpy(idxObj.stb, stbObj.name, TSDB_TABLE_FNAME_LEN);
2,202,834✔
1133
  memcpy(idxObj.db, stbObj.db, TSDB_DB_FNAME_LEN);
2,202,834✔
1134
  memcpy(idxObj.colName, pSchema->name, TSDB_COL_NAME_LEN);
2,202,834✔
1135
  memcpy(idxObj.createUser, pOperUser->name, TSDB_USER_LEN);
2,202,834✔
1136
  idxObj.ownerId = pOperUser->uid;
2,202,834✔
1137
  idxObj.createdTime = taosGetTimestampMs();
2,202,834✔
1138
  idxObj.uid = mndGenerateUid(fullIdxName, strlen(fullIdxName));
2,202,834✔
1139
  idxObj.stbUid = stbObj.uid;
2,202,834✔
1140
  idxObj.dbUid = stbObj.dbUid;
2,202,834✔
1141

1142
  TAOS_CHECK_GOTO(mndSetCreateIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
2,202,834✔
1143

1144
  TAOS_CHECK_GOTO(mndAddStbToTrans(pMnode, pTrans, pDb, &stbObj), NULL, _OVER);
2,202,834✔
1145
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
2,193,647✔
1146
  code = 0;
2,193,533✔
1147

1148
_OVER:
2,204,068✔
1149
  mndTransDrop(pTrans);
2,204,068✔
1150
  if (mndStbActionDelete(pMnode->pSdb, &stbObj) != 0) mError("failed to mndStbActionDelete");
2,204,068✔
1151
  TAOS_RETURN(code);
2,204,068✔
1152
}
1153

1154
typedef struct {
1155
  const char *name;
1156
  uint8_t     type;
1157
  int32_t     bytes;
1158
  uint32_t    alg;
1159
} AuditColumnDef;
1160

1161
// column is consistent with vnodePrepareRow process in vnodeSvr.c
1162
static const AuditColumnDef audit_columns[] = {
1163
    {"ts", TSDB_DATA_TYPE_TIMESTAMP, 8, 0x2000102},
1164
    {"details", TSDB_DATA_TYPE_VARCHAR, 50000 + VARSTR_HEADER_SIZE, 0xFF000302},
1165
    {"user_name", TSDB_DATA_TYPE_VARCHAR, 25 + VARSTR_HEADER_SIZE, 0xFF000302},
1166
    {"operation", TSDB_DATA_TYPE_VARCHAR, 20 + VARSTR_HEADER_SIZE, 0xFF000302},
1167
    {"db", TSDB_DATA_TYPE_VARCHAR, TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE, 0xFF000302},
1168
    {"resource", TSDB_DATA_TYPE_VARCHAR, TSDB_STREAM_NAME_LEN + VARSTR_HEADER_SIZE, 0xFF000302},
1169
    {"client_address", TSDB_DATA_TYPE_VARCHAR, AUDIT_CLIENT_ADD_LEN + VARSTR_HEADER_SIZE, 0xFF000302},
1170
    {"duration", TSDB_DATA_TYPE_DOUBLE, 8, 0x5000102},
1171
    {"affected_rows", TSDB_DATA_TYPE_UBIGINT, 8, 0x1000102}};
1172

1173
static int32_t mndBuildAuditStb(SMnode *pMnode, SStbObj *pDst, SDbObj *pDb) {
351✔
1174
  int32_t code = 0;
351✔
1175
  char   *name = AUDIT_STABLE_NAME;
351✔
1176
  (void)tsnprintf(pDst->name, TSDB_TABLE_FNAME_LEN, "%s.%s", pDb->name, name);
351✔
1177
  memcpy(pDst->db, pDb->name, TSDB_DB_FNAME_LEN);
351✔
1178
  pDst->createdTime = taosGetTimestampMs();
351✔
1179
  pDst->updateTime = pDst->createdTime;
351✔
1180
  pDst->uid = mndGenerateUid(pDst->name, strlen(pDst->name));
351✔
1181
  pDst->dbUid = pDb->uid;
351✔
1182
  pDst->tagVer = 1;
351✔
1183
  pDst->colVer = 1;
351✔
1184
  pDst->smaVer = 1;
351✔
1185
  pDst->nextColId = 1;
351✔
1186
  pDst->maxdelay[0] = -1;
351✔
1187
  pDst->maxdelay[1] = -1;
351✔
1188
  pDst->watermark[0] = 5000;
351✔
1189
  pDst->watermark[1] = 5000;
351✔
1190
  pDst->ttl = 0;
351✔
1191
  pDst->keep = -1;
351✔
1192
  pDst->source = 0;
351✔
1193
  pDst->virtualStb = 0;
351✔
1194
  pDst->numOfColumns = sizeof(audit_columns) / sizeof(AuditColumnDef);
351✔
1195
  pDst->numOfTags = 1;
351✔
1196
  pDst->numOfFuncs = 0;
351✔
1197
  pDst->commentLen = -1;
351✔
1198
  pDst->pFuncs = NULL;
351✔
1199

1200
  pDst->ast1Len = 0;
351✔
1201
  pDst->ast2Len = 0;
351✔
1202

1203
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
351✔
1204
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
351✔
1205
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SCmprObj));
351✔
1206
  if (pDst->pColumns == NULL || pDst->pTags == NULL || pDst->pCmpr == NULL) {
351✔
1207
    code = terrno;
×
1208
    TAOS_RETURN(code);
×
1209
  }
1210

1211
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
351✔
1212
    code = TSDB_CODE_OUT_OF_RANGE;
×
1213
    TAOS_RETURN(code);
×
1214
  }
1215

1216
  SSchema *pSchema = NULL;
351✔
1217
  for (int32_t i = 0; i < sizeof(audit_columns) / sizeof(AuditColumnDef); ++i) {
3,510✔
1218
    pSchema = &pDst->pColumns[pDst->nextColId - 1];
3,159✔
1219
    pSchema->type = audit_columns[i].type;
3,159✔
1220
    pSchema->bytes = audit_columns[i].bytes;
3,159✔
1221
    pSchema->flags = 1;
3,159✔
1222
    tstrncpy(pSchema->name, audit_columns[i].name, TSDB_COL_NAME_LEN);
3,159✔
1223
    pSchema->colId = pDst->nextColId;
3,159✔
1224
    // hasTypeMods = hasTypeMods || HAS_TYPE_MOD(pSchema);
1225
    SColCmpr *pColCmpr = &pDst->pCmpr[pDst->nextColId - 1];
3,159✔
1226
    pColCmpr->id = pSchema->colId;
3,159✔
1227
    pColCmpr->alg = audit_columns[i].alg;
3,159✔
1228
    pDst->nextColId++;
3,159✔
1229
  }
1230

1231
  // tag
1232
  pSchema = &pDst->pTags[0];
351✔
1233
  pSchema->type = TSDB_DATA_TYPE_VARCHAR;
351✔
1234
  pSchema->bytes = 64 + VARSTR_HEADER_SIZE;
351✔
1235
  SSCHMEA_SET_IDX_ON(pSchema);
351✔
1236
  tstrncpy(pSchema->name, "cluster_id", TSDB_COL_NAME_LEN);
351✔
1237
  pSchema->colId = pDst->nextColId;
351✔
1238
  pDst->nextColId++;
351✔
1239

1240
  /*
1241
    if (hasTypeMods) {
1242
      pDst->pExtSchemas = taosMemoryCalloc(pDst->numOfColumns, sizeof(SExtSchema));
1243
      if (!pDst->pExtSchemas) {
1244
        code = terrno;
1245
        TAOS_RETURN(code);
1246
      }
1247
      for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
1248
        SFieldWithOptions *pField = taosArrayGet(pCreate->pColumns, i);
1249
        pDst->pExtSchemas[i].typeMod = pField->typeMod;
1250
      }
1251
    }
1252
  */
1253
  TAOS_RETURN(code);
351✔
1254
}
1255

1256
static int32_t mndSetCreateAuditStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb,
351✔
1257
                                               SVgObj *pVgroup) {
1258
  int32_t code = 0;
351✔
1259
  SSdb   *pSdb = pMnode->pSdb;
351✔
1260

1261
  int32_t contLen;
351✔
1262

1263
  if (pVgroup == NULL) {
351✔
1264
    code = TSDB_CODE_INVALID_PARA;
×
1265
    TAOS_RETURN(code);
×
1266
  }
1267

1268
  void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, NULL, 0);
351✔
1269
  if (pReq == NULL) {
351✔
1270
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
1271
    if (terrno != 0) code = terrno;
×
1272
    TAOS_RETURN(code);
×
1273
  }
1274

1275
  STransAction action = {0};
351✔
1276
  action.mTraceId = pTrans->mTraceId;
351✔
1277
  action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
351✔
1278
  action.pCont = pReq;
351✔
1279
  action.contLen = contLen;
351✔
1280
  action.msgType = TDMT_VND_CREATE_STB;
351✔
1281
  action.acceptableCode = TSDB_CODE_TDB_STB_ALREADY_EXIST;
351✔
1282
  action.retryCode = TSDB_CODE_TDB_STB_NOT_EXIST;
351✔
1283
  mInfo("trans:%d, add create stb to redo action", pTrans->id);
351✔
1284
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
351✔
1285
    taosMemoryFree(pReq);
×
1286
    TAOS_RETURN(code);
×
1287
  }
1288

1289
  TAOS_RETURN(code);
351✔
1290
}
1291

1292
// Note: pVgroup is expected to point to the first element of a vgroup array (e.g. pVgroups at the call site).
1293
// Only the first element is used for creating the audit super table.
1294
int32_t mndCreateAuditStb(SMnode *pMnode, SDbObj *pDb, SUserObj *pOperUser, STrans *pTrans, SVgObj *pVgroup) {
351✔
1295
  SStbObj stbObj = {0};
351✔
1296
  int32_t code = -1;
351✔
1297

1298
  char fullIdxName[TSDB_INDEX_FNAME_LEN * 2] = {0};
351✔
1299

1300
  TAOS_CHECK_GOTO(mndBuildAuditStb(pMnode, &stbObj, pDb), NULL, _OVER);
351✔
1301
  memcpy(stbObj.createUser, pOperUser->name, TSDB_USER_LEN);
351✔
1302
  stbObj.ownerId = pOperUser->uid;
351✔
1303

1304
  SSchema *pSchema = &(stbObj.pTags[0]);
351✔
1305
  if (mndGenIdxNameForFirstTag(fullIdxName, pDb->name, stbObj.name, pSchema->name) < 0) {
351✔
1306
    code = terrno;
×
1307
    goto _OVER;
×
1308
  }
1309

1310
  SSIdx idx = {0};
351✔
1311
  if (mndAcquireGlobalIdx(pMnode, fullIdxName, SDB_IDX, &idx) == 0 && idx.pIdx != NULL) {
351✔
1312
    code = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
×
1313
    mndReleaseIdx(pMnode, idx.pIdx);
×
1314
    goto _OVER;
×
1315
  }
1316

1317
  SIdxObj idxObj = {0};
351✔
1318
  memcpy(idxObj.name, fullIdxName, TSDB_INDEX_FNAME_LEN);
351✔
1319
  memcpy(idxObj.stb, stbObj.name, TSDB_TABLE_FNAME_LEN);
351✔
1320
  memcpy(idxObj.db, stbObj.db, TSDB_DB_FNAME_LEN);
351✔
1321
  memcpy(idxObj.colName, pSchema->name, TSDB_COL_NAME_LEN);
351✔
1322
  memcpy(idxObj.createUser, pOperUser->name, TSDB_USER_LEN);
351✔
1323
  idxObj.ownerId = pOperUser->uid;
351✔
1324
  idxObj.createdTime = taosGetTimestampMs();
351✔
1325
  idxObj.uid = mndGenerateUid(fullIdxName, strlen(fullIdxName));
351✔
1326
  idxObj.stbUid = stbObj.uid;
351✔
1327
  idxObj.dbUid = stbObj.dbUid;
351✔
1328

1329
  mndTransSetDbName(pTrans, pDb->name, stbObj.name);
351✔
1330
  TAOS_CHECK_RETURN(mndTransCheckConflict(pMnode, pTrans));
351✔
1331
  TAOS_CHECK_GOTO(mndSetCreateIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
351✔
1332
  TAOS_CHECK_GOTO(mndSetCreateStbCommitLogs(pMnode, pTrans, pDb, &stbObj), NULL, _OVER);
351✔
1333
  TAOS_CHECK_GOTO(mndSetCreateAuditStbRedoActions(pMnode, pTrans, pDb, &stbObj, pVgroup), NULL, _OVER);
351✔
1334

1335
  code = 0;
351✔
1336

1337
_OVER:
351✔
1338
  if (mndStbActionDelete(pMnode->pSdb, &stbObj) != 0) mError("failed to mndStbActionDelete");
351✔
1339
  TAOS_RETURN(code);
351✔
1340
}
1341

1342
static int32_t mndProcessAuditRecordRsp(SRpcMsg *pRsp) {
688✔
1343
  int32_t code = 0;
688✔
1344

1345
  if (pRsp == NULL) {
688✔
1346
    mError("audit record rsp, null response message");
×
1347
    return -1;
×
1348
  }
1349

1350
  if (pRsp->code != 0) {
688✔
1351
    mError("audit record rsp failed, code:%d", pRsp->code);
×
1352
    return pRsp->code;
×
1353
  }
1354

1355
  SMnode *pMnode = pRsp->info.node;
688✔
1356
  SSdb   *pSdb = pMnode->pSdb;
688✔
1357
  (void)pMnode;  // currently unused, kept for potential future use
1358
  (void)pSdb;    // currently unused, kept for potential future use
1359

1360
  mDebug("audit record rsp succeeded, code:%d", pRsp->code);
688✔
1361

1362
  // no need to implement this rsp, since we do not care about the result of audit record insertion
1363

1364
  return code;
688✔
1365
}
1366

1367
int32_t mndAddStbToTrans(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
2,287,545✔
1368
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
2,287,545✔
1369
  TAOS_CHECK_RETURN(mndTransCheckConflict(pMnode, pTrans));
2,287,545✔
1370
  TAOS_CHECK_RETURN(mndSetCreateStbCommitLogs(pMnode, pTrans, pDb, pStb));
2,278,358✔
1371
  TAOS_CHECK_RETURN(mndSetCreateStbRedoActions(pMnode, pTrans, pDb, pStb));
2,278,358✔
1372
  TAOS_CHECK_RETURN(mndSetCreateStbUndoActions(pMnode, pTrans, pDb, pStb));
2,278,358✔
1373
  return 0;
2,278,358✔
1374
}
1375

1376
static int32_t mndProcessTtlTimer(SRpcMsg *pReq) {
3,802,127✔
1377
  SMnode           *pMnode = pReq->info.node;
3,802,127✔
1378
  SSdb             *pSdb = pMnode->pSdb;
3,802,127✔
1379
  SVgObj           *pVgroup = NULL;
3,802,127✔
1380
  void             *pIter = NULL;
3,802,127✔
1381
  SVDropTtlTableReq ttlReq = {
3,802,127✔
1382
      .timestampSec = taosGetTimestampSec(), .ttlDropMaxCount = tsTtlBatchDropNum, .nUids = 0, .pTbUids = NULL};
3,802,127✔
1383
  int32_t reqLen = tSerializeSVDropTtlTableReq(NULL, 0, &ttlReq);
3,802,127✔
1384
  int32_t contLen = reqLen + sizeof(SMsgHead);
3,802,127✔
1385

1386
  mDebug("start to process ttl timer");
3,802,127✔
1387

1388
  while (1) {
14,811,294✔
1389
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
18,613,421✔
1390
    if (pIter == NULL) break;
18,613,421✔
1391

1392
    if (pVgroup->mountVgId) {
14,811,294✔
1393
      sdbRelease(pSdb, pVgroup);
728✔
1394
      continue;
728✔
1395
    }
1396

1397
    int32_t   code = 0;
14,810,566✔
1398
    SMsgHead *pHead = rpcMallocCont(contLen);
14,810,566✔
1399
    if (pHead == NULL) {
14,810,566✔
1400
      sdbRelease(pSdb, pVgroup);
×
1401
      continue;
×
1402
    }
1403
    pHead->contLen = htonl(contLen);
14,810,566✔
1404
    pHead->vgId = htonl(pVgroup->vgId);
14,810,566✔
1405
    if ((code = tSerializeSVDropTtlTableReq((char *)pHead + sizeof(SMsgHead), reqLen, &ttlReq)) < 0) {
14,810,566✔
1406
      mError("vgId:%d, failed to serialize drop ttl table request since %s", pVgroup->vgId, tstrerror(code));
×
1407
      sdbRelease(pSdb, pVgroup);
×
1408
      continue;
×
1409
    }
1410

1411
    SRpcMsg rpcMsg = {
14,810,566✔
1412
        .msgType = TDMT_VND_FETCH_TTL_EXPIRED_TBS, .pCont = pHead, .contLen = contLen, .info = pReq->info};
1413
    SEpSet epSet = mndGetVgroupEpset(pMnode, pVgroup);
14,810,566✔
1414
    code = tmsgSendReq(&epSet, &rpcMsg);
14,810,566✔
1415
    if (code != 0) {
14,810,566✔
1416
      mError("vgId:%d, failed to send drop ttl table request to vnode since 0x%x", pVgroup->vgId, code);
39,388✔
1417
    } else {
1418
      mDebug("vgId:%d, send drop ttl table request to vnode, time:%" PRId32, pVgroup->vgId, ttlReq.timestampSec);
14,771,178✔
1419
    }
1420
    sdbRelease(pSdb, pVgroup);
14,810,566✔
1421
  }
1422

1423
  return 0;
3,802,127✔
1424
}
1425

1426
#if 0
1427
static int32_t mndProcessTrimDbTimer(SRpcMsg *pReq) {
1428
  SMnode     *pMnode = pReq->info.node;
1429
  SSdb       *pSdb = pMnode->pSdb;
1430
  SVgObj     *pVgroup = NULL;
1431
  void       *pIter = NULL;
1432
  SVTrimDbReq trimReq = {0};
1433
  trimReq.compactStartTime = taosGetTimestampMs();
1434
  trimReq.tw.skey = INT64_MIN;
1435
  trimReq.tw.ekey = trimReq.compactStartTime;
1436
  trimReq.compactId = 0;  // TODO: use the real value
1437
  trimReq.metaOnly = 0;
1438
  trimReq.triggerType = TSDB_TRIGGER_AUTO;
1439
  int32_t reqLen = tSerializeSVTrimDbReq(NULL, 0, &trimReq);
1440
  int32_t contLen = reqLen + sizeof(SMsgHead);
1441

1442
  while (1) {
1443
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
1444
    if (pIter == NULL) break;
1445
    if (pVgroup->mountVgId) {
1446
      sdbRelease(pSdb, pVgroup);
1447
      continue;
1448
    }
1449

1450
    int32_t code = 0;
1451

1452
    SMsgHead *pHead = rpcMallocCont(contLen);
1453
    if (pHead == NULL) {
1454
      sdbCancelFetch(pSdb, pVgroup);
1455
      sdbRelease(pSdb, pVgroup);
1456
      continue;
1457
    }
1458
    pHead->contLen = htonl(contLen);
1459
    pHead->vgId = htonl(pVgroup->vgId);
1460
    trimReq.dbUid = pVgroup->dbUid;
1461
    (void)snprintf(trimReq.db, sizeof(trimReq.db), "%s", pVgroup->dbName);
1462
    if ((code = tSerializeSVTrimDbReq((char *)pHead + sizeof(SMsgHead), reqLen, &trimReq)) < 0) {
1463
      mError("vgId:%d, failed to serialize trim db request since %s", pVgroup->vgId, tstrerror(code));
1464
    }
1465

1466
    SRpcMsg rpcMsg = {.msgType = TDMT_VND_TRIM, .pCont = pHead, .contLen = contLen};
1467
    SEpSet  epSet = mndGetVgroupEpset(pMnode, pVgroup);
1468
    code = tmsgSendReq(&epSet, &rpcMsg);
1469
    if (code != 0) {
1470
      mError("vgId:%d, timer failed to send vnode-trim request to vnode since 0x%x", pVgroup->vgId, code);
1471
    } else {
1472
      mInfo("vgId:%d, timer send vnode-trim request to vnode, time:%" PRIi64 " ms", pVgroup->vgId, trimReq.tw.ekey);
1473
    }
1474
    sdbRelease(pSdb, pVgroup);
1475
  }
1476

1477
  return 0;
1478
}
1479
#endif
1480

1481
static int32_t mndFindSuperTableTagIndex(const SStbObj *pStb, const char *tagName) {
4,049,400✔
1482
  for (int32_t tag = 0; tag < pStb->numOfTags; tag++) {
34,044,183✔
1483
    if (strcmp(pStb->pTags[tag].name, tagName) == 0) {
31,025,069✔
1484
      return tag;
1,030,286✔
1485
    }
1486
  }
1487

1488
  return -1;
3,019,114✔
1489
}
1490

1491
static int32_t mndFindSuperTableColumnIndex(const SStbObj *pStb, const char *colName) {
6,187,085✔
1492
  for (int32_t col = 0; col < pStb->numOfColumns; col++) {
370,902,272✔
1493
    if (strcmp(pStb->pColumns[col].name, colName) == 0) {
367,802,550✔
1494
      return col;
3,087,363✔
1495
    }
1496
  }
1497

1498
  return -1;
3,099,722✔
1499
}
1500

1501
static bool mndValidateSchema(SSchema *pSchemas, int32_t nSchema, SArray *pFields, int32_t maxLen) {
3,260,937✔
1502
  int32_t rowLen = 0;
3,260,937✔
1503
  for (int32_t i = 0; i < nSchema; ++i) {
235,142,920✔
1504
    rowLen += (pSchemas + i)->bytes;
231,881,983✔
1505
  }
1506

1507
  int32_t nField = taosArrayGetSize(pFields);
3,260,937✔
1508
  for (int32_t i = 0; i < nField; ++i) {
6,521,874✔
1509
    rowLen += ((SField *)TARRAY_GET_ELEM(pFields, i))->bytes;
3,260,937✔
1510
  }
1511

1512
  return rowLen <= maxLen;
3,260,937✔
1513
}
1514

1515
static int32_t mndBuildStbFromAlter(SStbObj *pStb, SStbObj *pDst, SMCreateStbReq *createReq) {
38,136✔
1516
  int32_t code = 0;
38,136✔
1517
  taosRLockLatch(&pStb->lock);
38,136✔
1518
  memcpy(pDst, pStb, sizeof(SStbObj));
38,136✔
1519
  taosRUnLockLatch(&pStb->lock);
38,136✔
1520

1521
  pDst->source = createReq->source;
38,136✔
1522
  pDst->updateTime = taosGetTimestampMs();
38,136✔
1523
  pDst->numOfColumns = createReq->numOfColumns;
38,136✔
1524
  pDst->numOfTags = createReq->numOfTags;
38,136✔
1525
  pDst->pColumns = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SSchema));
38,136✔
1526
  pDst->pTags = taosMemoryCalloc(1, pDst->numOfTags * sizeof(SSchema));
38,136✔
1527
  pDst->pCmpr = taosMemoryCalloc(1, pDst->numOfColumns * sizeof(SColCmpr));
38,136✔
1528
  pDst->pExtSchemas = taosMemoryCalloc(pDst->numOfColumns, sizeof(SExtSchema));
38,136✔
1529

1530
  if (pDst->pColumns == NULL || pDst->pTags == NULL || pDst->pCmpr == NULL || pDst->pExtSchemas == NULL) {
38,136✔
1531
    code = terrno;
×
1532
    TAOS_RETURN(code);
×
1533
  }
1534

1535
  if (pDst->nextColId < 0 || pDst->nextColId >= 0x7fff - pDst->numOfColumns - pDst->numOfTags) {
38,136✔
1536
    code = TSDB_CODE_OUT_OF_RANGE;
×
1537
    TAOS_RETURN(code);
×
1538
  }
1539

1540
  for (int32_t i = 0; i < pDst->numOfColumns; ++i) {
275,282✔
1541
    SFieldWithOptions *pField = taosArrayGet(createReq->pColumns, i);
237,146✔
1542
    SSchema           *pSchema = &pDst->pColumns[i];
237,146✔
1543
    pSchema->type = pField->type;
237,146✔
1544
    pSchema->bytes = pField->bytes;
237,146✔
1545
    pSchema->flags = pField->flags;
237,146✔
1546
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
237,146✔
1547
    int32_t cIndex = mndFindSuperTableColumnIndex(pStb, pField->name);
237,146✔
1548
    if (cIndex >= 0) {
237,146✔
1549
      pSchema->colId = pStb->pColumns[cIndex].colId;
219,396✔
1550
    } else {
1551
      pSchema->colId = pDst->nextColId++;
17,750✔
1552
    }
1553
  }
1554

1555
  for (int32_t i = 0; i < pDst->numOfTags; ++i) {
256,729✔
1556
    SField  *pField = taosArrayGet(createReq->pTags, i);
218,593✔
1557
    SSchema *pSchema = &pDst->pTags[i];
218,593✔
1558
    pSchema->type = pField->type;
218,593✔
1559
    pSchema->bytes = pField->bytes;
218,593✔
1560
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
218,593✔
1561
    int32_t cIndex = mndFindSuperTableTagIndex(pStb, pField->name);
218,593✔
1562
    if (cIndex >= 0) {
218,593✔
1563
      pSchema->colId = pStb->pTags[cIndex].colId;
206,484✔
1564
    } else {
1565
      pSchema->colId = pDst->nextColId++;
12,109✔
1566
    }
1567
  }
1568
  for (int32_t i = 0; i < pDst->numOfColumns; i++) {
275,282✔
1569
    SColCmpr          *p = pDst->pCmpr + i;
237,146✔
1570
    SFieldWithOptions *pField = taosArrayGet(createReq->pColumns, i);
237,146✔
1571
    SSchema           *pSchema = &pDst->pColumns[i];
237,146✔
1572
    p->id = pSchema->colId;
237,146✔
1573
    if (pField->compress == 0) {
237,146✔
1574
      p->alg = createDefaultColCmprByType(pSchema->type);
×
1575
    } else {
1576
      p->alg = pField->compress;
237,146✔
1577
    }
1578
    if (pField->flags & COL_HAS_TYPE_MOD) {
237,146✔
1579
      pDst->pExtSchemas[i].typeMod = pField->typeMod;
5,216✔
1580
    }
1581
  }
1582
  pDst->tagVer = createReq->tagVer;
38,136✔
1583
  pDst->colVer = createReq->colVer;
38,136✔
1584
  return TSDB_CODE_SUCCESS;
38,136✔
1585
}
1586

1587
// used for tmq_get_json_meta to build alter msg
1588
static void buildAlterMsg(SStbObj *pStb, SStbObj *pDst, void** pAlterBuf, int32_t* len){
38,136✔
1589
  SMAlterStbReq alterReq = {0};
38,136✔
1590
  alterReq.pFields = taosArrayInit(2, sizeof(SField));
38,136✔
1591
  if (NULL == alterReq.pFields) {
38,136✔
1592
    mError("failed to init alter fields array");
×
1593
    goto END;
×
1594
  }
1595
  tstrncpy(alterReq.name, pStb->name, TSDB_TABLE_FNAME_LEN);
38,136✔
1596
  for (int32_t i = 0; i < pDst->numOfColumns && taosArrayGetSize(alterReq.pFields) == 0; ++i) {
265,418✔
1597
    SSchema           *pSchema = &pDst->pColumns[i];
227,282✔
1598
    int32_t cIndex = mndFindSuperTableColumnIndex(pStb, pSchema->name);
227,282✔
1599
    if (cIndex >= 0 && pSchema->bytes == pStb->pColumns[cIndex].bytes) {
227,282✔
1600
      continue;
205,531✔
1601
    }
1602
    if (cIndex < 0) {
21,751✔
1603
      alterReq.alterType = TSDB_ALTER_TABLE_ADD_COLUMN;
17,750✔
1604
    } else if (pSchema->bytes > pStb->pColumns[cIndex].bytes){
4,001✔
1605
      alterReq.alterType = TSDB_ALTER_TABLE_UPDATE_COLUMN_BYTES;
4,001✔
1606
    }
1607
    SField *pAlterField = taosArrayReserve(alterReq.pFields, 1);
21,751✔
1608
    pAlterField->type = pSchema->type;
21,751✔
1609
    pAlterField->bytes = pSchema->bytes;
21,751✔
1610
    tstrncpy(pAlterField->name, pSchema->name, TSDB_COL_NAME_LEN);
21,751✔
1611
    mDebug("alter column name:%s, type:%d, bytes:%d", pAlterField->name, pAlterField->type, pAlterField->bytes);
21,751✔
1612
  }
1613

1614
  for (int32_t i = 0; i < pDst->numOfTags && taosArrayGetSize(alterReq.pFields) == 0; ++i) {
154,691✔
1615
    SSchema *pSchema = &pDst->pTags[i];
116,555✔
1616
    int32_t cIndex = mndFindSuperTableTagIndex(pStb, pSchema->name);
116,555✔
1617
    if (cIndex >= 0 && pSchema->bytes == pStb->pTags[cIndex].bytes) {
116,555✔
1618
      continue;
101,474✔
1619
    }
1620
    if (cIndex < 0) {
15,081✔
1621
      alterReq.alterType = TSDB_ALTER_TABLE_ADD_TAG;
12,109✔
1622
    } else if (pSchema->bytes > pStb->pTags[cIndex].bytes){
2,972✔
1623
      alterReq.alterType = TSDB_ALTER_TABLE_UPDATE_TAG_BYTES;
2,972✔
1624
    }
1625
    SField *pAlterField = taosArrayReserve(alterReq.pFields, 1);
15,081✔
1626
    pAlterField->type = pSchema->type;
15,081✔
1627
    pAlterField->bytes = pSchema->bytes;
15,081✔
1628
    tstrncpy(pAlterField->name, pSchema->name, TSDB_COL_NAME_LEN);
15,081✔
1629
    mDebug("alter tag name:%s, type:%d, bytes:%d", pAlterField->name, pAlterField->type, pAlterField->bytes);
15,081✔
1630
  }
1631
  alterReq.numOfFields = taosArrayGetSize(alterReq.pFields);
38,136✔
1632
  if (alterReq.numOfFields == 0) {
38,136✔
1633
    mError("no valid alter field found");
1,304✔
1634
    goto END;
1,304✔
1635
  }
1636

1637
  int32_t contLen = tSerializeSMAlterStbReq(NULL, 0, &alterReq);
36,832✔
1638
  if (contLen <= 0) {
36,832✔
1639
    mError("failed to get alter stb req len");
×
1640
    goto END;
×
1641
  }
1642
  void*   buf = taosMemoryMalloc(contLen);
36,832✔
1643
  if (buf == NULL) {
36,832✔
1644
    mError("failed to malloc alter stb req buf");
×
1645
    goto END;
×
1646
  }
1647
  int32_t code = tSerializeSMAlterStbReq(buf, contLen, &alterReq);
36,832✔
1648
  if (code <= TSDB_CODE_SUCCESS) {
36,832✔
1649
    mError("failed to serialize alter stb req %d", code);
×
1650
    taosMemoryFreeClear(buf);
×
1651
    goto END;
×
1652
  }
1653
  *pAlterBuf = buf;
36,832✔
1654
  *len = contLen;
36,832✔
1655
END:
38,136✔
1656
  taosArrayDestroy(alterReq.pFields);
38,136✔
1657
}
38,136✔
1658

1659
static int32_t mndProcessCreateStbReq(SRpcMsg *pReq) {
2,266,642✔
1660
  SMnode        *pMnode = pReq->info.node;
2,266,642✔
1661
  int32_t        code = -1;
2,266,642✔
1662
  SStbObj       *pStb = NULL;
2,266,642✔
1663
  SDbObj        *pDb = NULL;
2,266,642✔
1664
  SUserObj      *pOperUser = NULL;
2,266,642✔
1665
  SMCreateStbReq createReq = {0};
2,266,642✔
1666
  bool           isAlter = false;
2,266,642✔
1667
  SHashObj      *pHash = NULL;
2,266,642✔
1668
  int64_t        tss = taosGetTimestampMs();
2,266,642✔
1669

1670
  if (tDeserializeSMCreateStbReq(pReq->pCont, pReq->contLen, &createReq) != 0) {
2,266,642✔
1671
    code = TSDB_CODE_INVALID_MSG;
×
1672
    goto _OVER;
×
1673
  }
1674

1675
  mInfo("stb:%s, start to create", createReq.name);
2,266,642✔
1676
  if (mndCheckCreateStbReq(&createReq) != 0) {
2,266,642✔
1677
    code = TSDB_CODE_INVALID_MSG;
×
1678
    goto _OVER;
×
1679
  }
1680

1681
  pStb = mndAcquireStb(pMnode, createReq.name);
2,266,642✔
1682
  if (pStb != NULL) {
2,266,642✔
1683
    if (createReq.igExists) {
60,844✔
1684
      if (createReq.source == TD_REQ_FROM_APP) {
59,069✔
1685
        mInfo("stb:%s, already exist, ignore exist is set", createReq.name);
3,275✔
1686
        code = 0;
3,275✔
1687
        goto _OVER;
3,275✔
1688
      } else if (pStb->uid != createReq.suid) {
55,794✔
1689
        mInfo("stb:%s, alter table does not need to be done, because table is deleted", createReq.name);
×
1690
        code = 0;
×
1691
        goto _OVER;
×
1692
      } else if (createReq.tagVer > 0 || createReq.colVer > 0) {
93,930✔
1693
        int32_t tagDelta = createReq.tagVer - pStb->tagVer;
55,794✔
1694
        int32_t colDelta = createReq.colVer - pStb->colVer;
55,794✔
1695
        mInfo("stb:%s, already exist while create, input tagVer:%d colVer:%d, exist tagVer:%d colVer:%d",
55,794✔
1696
              createReq.name, createReq.tagVer, createReq.colVer, pStb->tagVer, pStb->colVer);
1697
        if (tagDelta <= 0 && colDelta <= 0) {
55,794✔
1698
          mInfo("stb:%s, schema version is not incremented and nothing needs to be done", createReq.name);
17,658✔
1699
          code = 0;
17,658✔
1700
          goto _OVER;
17,658✔
1701
        } else if ((tagDelta == 1 && colDelta == 0) || (tagDelta == 0 && colDelta == 1) ||
38,136✔
1702
                   (pStb->colVer == 1 && createReq.colVer > 1) || (pStb->tagVer == 1 && createReq.tagVer > 1)) {
×
1703
          isAlter = true;
38,136✔
1704
          mInfo("stb:%s, schema version is only increased by 1 number, do alter operation", createReq.name);
38,136✔
1705
        } else {
1706
          mError("stb:%s, schema version increase more than 1 number, error is returned", createReq.name);
×
1707
          code = TSDB_CODE_MND_INVALID_SCHEMA_VER;
×
1708
          goto _OVER;
×
1709
        }
1710
      } else {
1711
        mError("stb:%s, already exist while create, input tagVer:%d colVer:%d is invalid, origin tagVer:%d colVer:%d",
×
1712
               createReq.name, createReq.tagVer, createReq.colVer, pStb->tagVer, pStb->colVer);
1713
        code = TSDB_CODE_MND_INVALID_SCHEMA_VER;
×
1714
        goto _OVER;
×
1715
      }
1716
    } else {
1717
      code = TSDB_CODE_MND_STB_ALREADY_EXIST;
1,775✔
1718
      goto _OVER;
1,775✔
1719
    }
1720
  } else if (terrno != TSDB_CODE_MND_STB_NOT_EXIST) {
2,205,798✔
1721
    goto _OVER;
×
1722
  } else if ((createReq.source == TD_REQ_FROM_TAOX_OLD || createReq.source == TD_REQ_FROM_TAOX || createReq.source == TD_REQ_FROM_SML) &&
2,205,798✔
1723
             (createReq.tagVer != 1 || createReq.colVer != 1)) {
21,978✔
1724
    mInfo("stb:%s, alter table does not need to be done, because table is deleted", createReq.name);
1,630✔
1725
    code = 0;
1,630✔
1726
    goto _OVER;
1,630✔
1727
  }
1728

1729
  pHash = taosHashInit(createReq.numOfColumns + createReq.numOfTags, taosGetDefaultHashFunction(TSDB_DATA_TYPE_BINARY),
2,242,304✔
1730
                       false, HASH_NO_LOCK);
1731
  if (pHash == NULL) {
2,242,304✔
1732
    code = TSDB_CODE_OUT_OF_MEMORY;
×
1733
    goto _OVER;
×
1734
  }
1735

1736
  for (int32_t i = 0; i < createReq.numOfColumns; ++i) {
174,012,105✔
1737
    SFieldWithOptions *pField = taosArrayGet(createReq.pColumns, i);
171,769,801✔
1738
    if ((code = taosHashPut(pHash, pField->name, strlen(pField->name), NULL, 0)) != 0) {
171,769,801✔
1739
      if (code == TSDB_CODE_DUP_KEY) {
×
1740
        code = TSDB_CODE_TSC_DUP_COL_NAMES;
×
1741
      }
1742
      goto _OVER;
×
1743
    }
1744
  }
1745

1746
  for (int32_t i = 0; i < createReq.numOfTags; ++i) {
11,516,586✔
1747
    SField *pField = taosArrayGet(createReq.pTags, i);
9,274,382✔
1748
    if ((code = taosHashPut(pHash, pField->name, strlen(pField->name), NULL, 0)) != 0) {
9,274,382✔
1749
      if (code == TSDB_CODE_DUP_KEY) {
100✔
1750
        code = TSDB_CODE_TSC_DUP_COL_NAMES;
100✔
1751
      }
1752
      goto _OVER;
100✔
1753
    }
1754
  }
1755

1756
  pDb = mndAcquireDbByStb(pMnode, createReq.name);
2,242,204✔
1757
  if (pDb == NULL) {
2,242,204✔
1758
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
1759
    goto _OVER;
×
1760
  }
1761

1762
  if ((code = mndAcquireUser(pMnode, (RPC_MSG_USER(pReq)), &pOperUser))) {
2,242,204✔
1763
    goto _OVER;
×
1764
  }
1765

1766
  if ((code = mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB, pDb))) {
2,242,204✔
1767
    goto _OVER;
×
1768
  }
1769

1770
  if ((code =
2,242,204✔
1771
           mndCheckDbPrivilegeByNameRecF(pMnode, pOperUser, pDb->cfg.isAudit ? PRIV_AUDIT_TBL_CREATE : PRIV_TBL_CREATE,
2,242,204✔
1772
                                         pDb->cfg.isAudit ? PRIV_OBJ_CLUSTER : PRIV_OBJ_DB, pDb->name, NULL))) {
2,242,204✔
1773
    goto _OVER;
×
1774
  }
1775

1776
  if (pDb->cfg.isMount) {
2,242,204✔
1777
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
×
1778
    goto _OVER;
×
1779
  }
1780

1781
  int32_t numOfStbs = -1;
2,242,204✔
1782
  if ((code = mndGetNumOfStbs(pMnode, pDb->name, &numOfStbs)) != 0) {
2,242,204✔
1783
    goto _OVER;
×
1784
  }
1785

1786
  if (pDb->cfg.numOfStables == 1 && numOfStbs != 0) {
2,242,204✔
1787
    code = TSDB_CODE_MND_SINGLE_STB_MODE_DB;
×
1788
    goto _OVER;
×
1789
  }
1790

1791
  if ((code = grantCheck(TSDB_GRANT_STABLE)) < 0) {
2,242,204✔
1792
    goto _OVER;
×
1793
  }
1794

1795
  if (isAlter) {
2,242,204✔
1796
    bool    needRsp = false;
38,136✔
1797
    SStbObj pDst = {0};
38,136✔
1798
    if ((code = mndBuildStbFromAlter(pStb, &pDst, &createReq)) != 0) {
38,136✔
1799
      taosMemoryFreeClear(pDst.pTags);
×
1800
      taosMemoryFreeClear(pDst.pColumns);
×
1801
      taosMemoryFreeClear(pDst.pCmpr);
×
1802
      taosMemoryFreeClear(pDst.pExtSchemas);
×
1803
      goto _OVER;
×
1804
    }
1805
    void* buf = NULL;
38,136✔
1806
    int32_t contLen = 0;
38,136✔
1807
    buildAlterMsg(pStb, &pDst, &buf, &contLen);
38,136✔
1808
    code = mndAlterStbImp(pMnode, pReq, pDb, &pDst, needRsp, buf, contLen);
38,136✔
1809
    taosMemoryFree(buf);
38,136✔
1810
    taosMemoryFreeClear(pDst.pTags);
38,136✔
1811
    taosMemoryFreeClear(pDst.pColumns);
38,136✔
1812
    taosMemoryFreeClear(pDst.pCmpr);
38,136✔
1813
    taosMemoryFreeClear(pDst.pExtSchemas);
38,136✔
1814
  } else {
1815
    code = mndCreateStb(pMnode, pReq, &createReq, pDb, pOperUser);
2,204,068✔
1816
  }
1817
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
2,242,204✔
1818

1819
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
2,242,204✔
1820
    SName name = {0};
2,242,204✔
1821
    TAOS_CHECK_RETURN(tNameFromString(&name, createReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
2,242,204✔
1822

1823
    int64_t tse = taosGetTimestampMs();
2,242,204✔
1824
    double  duration = (double)(tse - tss);
2,242,204✔
1825
    duration = duration / 1000;
2,242,204✔
1826
    if (createReq.sql == NULL && createReq.sqlLen == 0) {
2,243,104✔
1827
      char detail[1000] = {0};
438,204✔
1828

1829
      (void)snprintf(detail, sizeof(detail), "dbname:%s, stable name:%s", name.dbname, name.tname);
438,204✔
1830

1831
      auditRecord(pReq, pMnode->clusterId, "createStb", name.dbname, name.tname, detail, strlen(detail), duration, 0);
438,204✔
1832
    } else {
1833
      auditRecord(pReq, pMnode->clusterId, "createStb", name.dbname, name.tname, createReq.sql, createReq.sqlLen,
1,804,000✔
1834
                  duration, 0);
1835
    }
1836
  }
1837
_OVER:
2,263,749✔
1838
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
2,266,642✔
1839
    mError("stb:%s, failed to create since %s", createReq.name, tstrerror(code));
12,410✔
1840
  }
1841

1842
  mndReleaseStb(pMnode, pStb);
2,266,642✔
1843
  mndReleaseDb(pMnode, pDb);
2,266,642✔
1844
  mndReleaseUser(pMnode, pOperUser);
2,266,642✔
1845
  tFreeSMCreateStbReq(&createReq);
2,266,642✔
1846

1847
  if (pHash != NULL) {
2,266,642✔
1848
    taosHashCleanup(pHash);
2,242,304✔
1849
  }
1850

1851
  TAOS_RETURN(code);
2,266,642✔
1852
}
1853

1854
static int32_t mndCheckAlterStbReq(SMAlterStbReq *pAlter) {
6,300,684✔
1855
  int32_t code = 0;
6,300,684✔
1856
  if (pAlter->commentLen >= 0) return 0;
6,300,684✔
1857
  if (pAlter->ttl != 0) return 0;
17,928✔
1858
  if (pAlter->keep != -1) return 0;
17,928✔
1859
  if (pAlter->secureDelete >= 0) return 0;
×
1860

1861
  if (pAlter->numOfFields < 1 || pAlter->numOfFields != (int32_t)taosArrayGetSize(pAlter->pFields)) {
×
1862
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
1863
    TAOS_RETURN(code);
×
1864
  }
1865

1866
  for (int32_t i = 0; i < pAlter->numOfFields; ++i) {
×
1867
    SField *pField = taosArrayGet(pAlter->pFields, i);
×
1868
    if (pField->name[0] == 0) {
×
1869
      code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
1870
      TAOS_RETURN(code);
×
1871
    }
1872
  }
1873

1874
  TAOS_RETURN(code);
×
1875
}
1876

1877
int32_t mndAllocStbSchemas(const SStbObj *pOld, SStbObj *pNew) {
6,018,539✔
1878
  pNew->pTags = taosMemoryCalloc(pNew->numOfTags, sizeof(SSchema));
6,018,539✔
1879
  pNew->pColumns = taosMemoryCalloc(pNew->numOfColumns, sizeof(SSchema));
6,018,539✔
1880
  pNew->pCmpr = taosMemoryCalloc(pNew->numOfColumns, sizeof(SColCmpr));
6,018,539✔
1881
  if (pNew->pTags == NULL || pNew->pColumns == NULL || pNew->pCmpr == NULL) {
6,018,539✔
1882
    TAOS_RETURN(terrno);
×
1883
  }
1884

1885
  memcpy(pNew->pColumns, pOld->pColumns, sizeof(SSchema) * pOld->numOfColumns);
6,018,539✔
1886
  memcpy(pNew->pTags, pOld->pTags, sizeof(SSchema) * pOld->numOfTags);
6,018,539✔
1887
  memcpy(pNew->pCmpr, pOld->pCmpr, sizeof(SColCmpr) * pOld->numOfColumns);
6,018,539✔
1888
  if (pOld->pExtSchemas) {
6,018,539✔
1889
    pNew->pExtSchemas = taosMemoryCalloc(pNew->numOfColumns, sizeof(SExtSchema));
4,798,425✔
1890
    if (pNew->pExtSchemas == NULL) {
4,798,425✔
1891
      TAOS_RETURN(terrno);
×
1892
    }
1893
    memcpy(pNew->pExtSchemas, pOld->pExtSchemas, sizeof(SExtSchema) * pOld->numOfColumns);
4,798,425✔
1894
  }
1895

1896
  TAOS_RETURN(0);
6,018,539✔
1897
}
1898

1899
static int32_t mndUpdateTableOptions(const SStbObj *pOld, SStbObj *pNew, char *pComment, int32_t commentLen,
29,652✔
1900
                                     int32_t ttl, int64_t keep, int8_t secureDelete, int8_t securityLevel) {
1901
  int32_t code = 0;
29,652✔
1902
  if (commentLen > 0) {
29,652✔
1903
    pNew->commentLen = commentLen;
6,732✔
1904
    pNew->comment = taosMemoryCalloc(1, commentLen + 1);
6,732✔
1905
    if (pNew->comment == NULL) {
6,732✔
1906
      terrno = TSDB_CODE_OUT_OF_MEMORY;
×
1907
      return -1;
×
1908
    }
1909
    memcpy(pNew->comment, pComment, commentLen + 1);
6,732✔
1910
  } else if (commentLen == 0) {
22,920✔
1911
    pNew->commentLen = 0;
5,187✔
1912
  } else {
1913
  }
1914

1915
  if (ttl >= 0) {
29,652✔
1916
    pNew->ttl = ttl;
29,652✔
1917
  }
1918

1919
  if (keep > 0) {
29,652✔
1920
    pNew->keep = keep;
14,675✔
1921
  }
1922

1923
  if (secureDelete >= 0) {
29,652✔
1924
    pNew->secureDelete = secureDelete;
643✔
1925
  }
1926

1927
  if (securityLevel >= 0 && (uint8_t)securityLevel != pOld->securityLevel) {
29,652✔
1928
    pNew->securityLevel = (uint8_t)securityLevel;
1,850✔
1929
    pNew->colVer++;  // bump version to invalidate client catalog cache only when changed
1,850✔
1930
  }
1931

1932
  if ((code = mndAllocStbSchemas(pOld, pNew)) != 0) {
29,652✔
1933
    TAOS_RETURN(code);
×
1934
  }
1935
  TAOS_RETURN(code);
29,652✔
1936
}
1937

1938
static int32_t mndAddSuperTableTag(const SStbObj *pOld, SStbObj *pNew, SArray *pFields, int32_t ntags) {
326,636✔
1939
  int32_t code = 0;
326,636✔
1940
  if (pOld->numOfTags + ntags > TSDB_MAX_TAGS) {
326,636✔
1941
    code = TSDB_CODE_MND_TOO_MANY_TAGS;
×
1942
    TAOS_RETURN(code);
×
1943
  }
1944

1945
  int32_t maxColumns = pOld->virtualStb ? TSDB_MAX_COLUMNS : TSDB_MAX_COLUMNS_NON_VIRTUAL;
326,636✔
1946
  if (pOld->numOfColumns + ntags + pOld->numOfTags > maxColumns) {
326,636✔
1947
    code = TSDB_CODE_MND_TOO_MANY_COLUMNS;
×
1948
    TAOS_RETURN(code);
×
1949
  }
1950

1951
  if (!mndValidateSchema(pOld->pTags, pOld->numOfTags, pFields, TSDB_MAX_TAGS_LEN)) {
326,636✔
1952
    code = TSDB_CODE_PAR_INVALID_TAGS_LENGTH;
24,990✔
1953
    TAOS_RETURN(code);
24,990✔
1954
  }
1955

1956
  pNew->numOfTags = pNew->numOfTags + ntags;
301,646✔
1957
  if ((code = mndAllocStbSchemas(pOld, pNew)) != 0) {
301,646✔
1958
    TAOS_RETURN(code);
×
1959
  }
1960

1961
  if (pNew->nextColId < 0 || pNew->nextColId >= 0x7fff - ntags) {
301,646✔
1962
    code = TSDB_CODE_OUT_OF_RANGE;
1,234✔
1963
    TAOS_RETURN(code);
1,234✔
1964
  }
1965

1966
  for (int32_t i = 0; i < ntags; i++) {
529,827✔
1967
    SField *pField = taosArrayGet(pFields, i);
300,412✔
1968
    if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
300,412✔
1969
      code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
2,308✔
1970
      TAOS_RETURN(code);
2,308✔
1971
    }
1972

1973
    if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
298,104✔
1974
      code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
68,689✔
1975
      TAOS_RETURN(code);
68,689✔
1976
    }
1977

1978
    SSchema *pSchema = &pNew->pTags[pOld->numOfTags + i];
229,415✔
1979
    pSchema->bytes = pField->bytes;
229,415✔
1980
    pSchema->type = pField->type;
229,415✔
1981
    memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
229,415✔
1982
    if (pNew->nextColId > INT16_MAX) {
229,415✔
1983
      code = TSDB_CODE_MND_EXCEED_MAX_COL_ID;
×
1984
      TAOS_RETURN(code);
×
1985
    }
1986
    pSchema->colId = pNew->nextColId;
229,415✔
1987
    pNew->nextColId++;
229,415✔
1988

1989
    mInfo("stb:%s, start to add tag %s", pNew->name, pSchema->name);
229,415✔
1990
  }
1991

1992
  pNew->tagVer++;
229,415✔
1993
  TAOS_RETURN(code);
229,415✔
1994
}
1995

1996
static int32_t mndCheckAlterColForTSma(SMnode *pMnode, const char *stbFullName, int64_t suid, col_id_t colId, bool isTag) {
2,849,853✔
1997
  int32_t code = 0;
2,849,853✔
1998
  SSdb   *pSdb = pMnode->pSdb;
2,849,853✔
1999
  void   *pIter = NULL;
2,849,853✔
2000
  while (1) {
×
2001
    SSmaObj *pSma = NULL;
2,849,853✔
2002
    pIter = sdbFetch(pSdb, SDB_SMA, pIter, (void **)&pSma);
2,849,853✔
2003
    if (pIter == NULL) break;
2,849,853✔
2004

2005
    mInfo("tsma:%s, check tag and column modifiable, stb:%s suid:%" PRId64 " colId:%d, sql:%s", pSma->name, stbFullName,
322✔
2006
          suid, colId, pSma->sql);
2007

2008
    if (isTag) {
322✔
2009
      code = TSDB_CODE_MND_FIELD_CONFLICT_WITH_TSMA;
322✔
2010
      mError("tsma:%s, check tag:%d conflicted", pSma->name, colId);
322✔
2011
      sdbRelease(pSdb, pSma);
322✔
2012
      sdbCancelFetch(pSdb, pIter);
322✔
2013
      TAOS_RETURN(code);
322✔
2014
    }
2015

2016
    SNode *pAst = NULL;
×
2017
    if (nodesStringToNode(pSma->ast, &pAst) != 0) {
×
2018
      code = TSDB_CODE_SDB_INVALID_DATA_CONTENT;
×
2019
      mError("tsma:%s, check tag and column modifiable, stb:%s suid:%" PRId64 " colId:%d failed since parse AST err",
×
2020
             pSma->name, stbFullName, suid, colId);
2021
      sdbCancelFetch(pSdb, pIter);
×
2022
      TAOS_RETURN(code);
×
2023
    }
2024

2025
    SNodeList *pNodeList = NULL;
×
2026
    if ((code = nodesCollectColumns((SSelectStmt *)pAst, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pNodeList)) !=
×
2027
        0) {
2028
      sdbCancelFetch(pSdb, pIter);
×
2029
      TAOS_RETURN(code);
×
2030
    }
2031
    SNode *pNode = NULL;
×
2032
    FOREACH(pNode, pNodeList) {
×
2033
      SColumnNode *pCol = (SColumnNode *)pNode;
×
2034
      mInfo("tsma:%s, check colId:%d tableId:%" PRId64, pSma->name, pCol->colId, pCol->tableId);
×
2035

2036
      if ((pCol->tableId != suid) && (pSma->stbUid != suid)) {
×
2037
        mInfo("tsma:%s, check colId:%d passed", pSma->name, pCol->colId);
×
2038
        goto NEXT;
×
2039
      }
2040
      if ((pCol->colId) > 0 && (pCol->colId == colId)) {
×
2041
        code = TSDB_CODE_MND_FIELD_CONFLICT_WITH_TSMA;
×
2042
        mError("tsma:%s, check colId:%d conflicted", pSma->name, pCol->colId);
×
2043
        nodesDestroyNode(pAst);
×
2044
        nodesDestroyList(pNodeList);
×
2045
        sdbRelease(pSdb, pSma);
×
2046
        sdbCancelFetch(pSdb, pIter);
×
2047
        TAOS_RETURN(code);
×
2048
      }
2049
      mInfo("tsma:%s, check colId:%d passed", pSma->name, pCol->colId);
×
2050
    }
2051

2052
  NEXT:
×
2053
    sdbRelease(pSdb, pSma);
×
2054
    nodesDestroyNode(pAst);
×
2055
    nodesDestroyList(pNodeList);
×
2056
  }
2057
  TAOS_RETURN(code);
2,849,531✔
2058
}
2059

2060
static int32_t mndDropSuperTableTag(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const char *tagName) {
124,348✔
2061
  int32_t code = 0;
124,348✔
2062
  int32_t tag = mndFindSuperTableTagIndex(pOld, tagName);
124,348✔
2063
  if (tag < 0) {
124,348✔
2064
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
100✔
2065
    TAOS_RETURN(code);
100✔
2066
  }
2067

2068
  col_id_t colId = pOld->pTags[tag].colId;
124,248✔
2069
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, true));
124,248✔
2070

2071
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
124,087✔
2072

2073
  memmove(pNew->pTags + tag, pNew->pTags + tag + 1, sizeof(SSchema) * (pNew->numOfTags - tag - 1));
124,087✔
2074
  pNew->numOfTags--;
124,087✔
2075

2076
  pNew->tagVer++;
124,087✔
2077

2078
  // if (mndDropIndexByTag(pMnode, pOld, tagName) != 0) {
2079
  //   return -1;
2080
  // }
2081
  mInfo("stb:%s, start to drop tag %s", pNew->name, tagName);
124,087✔
2082
  TAOS_RETURN(code);
124,087✔
2083
}
2084

2085
static int32_t mndAlterStbTagName(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, SArray *pFields) {
152,677✔
2086
  int32_t code = 0;
152,677✔
2087
  if ((int32_t)taosArrayGetSize(pFields) != 2) {
152,677✔
2088
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
×
2089
    TAOS_RETURN(code);
×
2090
  }
2091

2092
  SField *pField0 = taosArrayGet(pFields, 0);
152,677✔
2093
  SField *pField1 = taosArrayGet(pFields, 1);
152,677✔
2094

2095
  const char *oldTagName = pField0->name;
152,677✔
2096
  const char *newTagName = pField1->name;
152,677✔
2097

2098
  int32_t tag = mndFindSuperTableTagIndex(pOld, oldTagName);
152,677✔
2099
  if (tag < 0) {
152,677✔
2100
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
3,879✔
2101
    TAOS_RETURN(code);
3,879✔
2102
  }
2103

2104
  col_id_t colId = pOld->pTags[tag].colId;
148,798✔
2105
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, true));
148,798✔
2106

2107
  if (mndFindSuperTableTagIndex(pOld, newTagName) >= 0) {
148,637✔
2108
    code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
6,818✔
2109
    TAOS_RETURN(code);
6,818✔
2110
  }
2111

2112
  if (mndFindSuperTableColumnIndex(pOld, newTagName) >= 0) {
141,819✔
2113
    code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
100✔
2114
    TAOS_RETURN(code);
100✔
2115
  }
2116

2117
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
141,719✔
2118

2119
  SSchema *pSchema = (SSchema *)(pNew->pTags + tag);
141,719✔
2120
  memcpy(pSchema->name, newTagName, TSDB_COL_NAME_LEN);
141,719✔
2121

2122
  pNew->tagVer++;
141,719✔
2123
  mInfo("stb:%s, start to modify tag %s to %s", pNew->name, oldTagName, newTagName);
141,719✔
2124
  TAOS_RETURN(code);
141,719✔
2125
}
2126

2127
static int32_t mndAlterStbTagBytes(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const SField *pField) {
368,595✔
2128
  int32_t code = 0;
368,595✔
2129
  int32_t tag = mndFindSuperTableTagIndex(pOld, pField->name);
368,595✔
2130
  if (tag < 0) {
368,595✔
2131
    code = TSDB_CODE_MND_TAG_NOT_EXIST;
100✔
2132
    TAOS_RETURN(code);
100✔
2133
  }
2134

2135
  col_id_t colId = pOld->pTags[tag].colId;
368,495✔
2136
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, true));
368,495✔
2137

2138
  uint32_t nLen = 0;
368,495✔
2139
  for (int32_t i = 0; i < pOld->numOfTags; ++i) {
14,721,444✔
2140
    nLen += (pOld->pTags[i].colId == colId) ? pField->bytes : pOld->pTags[i].bytes;
14,352,949✔
2141
  }
2142

2143
  if (nLen > TSDB_MAX_TAGS_LEN) {
368,495✔
2144
    code = TSDB_CODE_PAR_INVALID_TAGS_LENGTH;
211,680✔
2145
    TAOS_RETURN(code);
211,680✔
2146
  }
2147

2148
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
156,815✔
2149

2150
  SSchema *pTag = pNew->pTags + tag;
156,815✔
2151

2152
  if (!(pTag->type == TSDB_DATA_TYPE_BINARY || pTag->type == TSDB_DATA_TYPE_VARBINARY ||
156,815✔
2153
        pTag->type == TSDB_DATA_TYPE_NCHAR || pTag->type == TSDB_DATA_TYPE_GEOMETRY)) {
150,184✔
2154
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
100✔
2155
    TAOS_RETURN(code);
100✔
2156
  }
2157

2158
  if (pField->bytes <= pTag->bytes) {
156,715✔
2159
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
59,635✔
2160
    TAOS_RETURN(code);
59,635✔
2161
  }
2162

2163
  pTag->bytes = pField->bytes;
97,080✔
2164
  pNew->tagVer++;
97,080✔
2165

2166
  mInfo("stb:%s, start to modify tag len %s to %d", pNew->name, pField->name, pField->bytes);
97,080✔
2167
  TAOS_RETURN(code);
97,080✔
2168
}
2169

2170
static int32_t mndUpdateSuperTableColumnCompress(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, SArray *pField,
103,072✔
2171
                                                 int32_t nCols) {
2172
  // if (pColCmpr == NULL || colName == NULL) return -1;
2173

2174
  if (taosArrayGetSize(pField) != nCols) return TSDB_CODE_FAILED;
103,072✔
2175
  TAOS_FIELD *p = taosArrayGet(pField, 0);
103,072✔
2176

2177
  int32_t code = 0;
103,072✔
2178
  int32_t idx = mndFindSuperTableColumnIndex(pOld, p->name);
103,072✔
2179
  if (idx == -1) {
103,072✔
2180
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
×
2181
    TAOS_RETURN(code);
×
2182
  }
2183
  SSchema *pTarget = &pOld->pColumns[idx];
103,072✔
2184
  col_id_t colId = pTarget->colId;
103,072✔
2185

2186
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
103,072✔
2187
  code = validColCmprByType(pTarget->type, p->bytes);
103,072✔
2188
  if (code != TSDB_CODE_SUCCESS) {
103,072✔
2189
    TAOS_RETURN(code);
2,468✔
2190
  }
2191

2192
  int8_t updated = 0;
100,604✔
2193
  for (int i = 0; i < pNew->numOfColumns; i++) {
853,080✔
2194
    SColCmpr *pCmpr = &pNew->pCmpr[i];
853,080✔
2195
    if (pCmpr->id == colId) {
853,080✔
2196
      uint32_t dst = 0;
100,604✔
2197
      updated = tUpdateCompress(pCmpr->alg, p->bytes, TSDB_COLVAL_COMPRESS_DISABLED, TSDB_COLVAL_LEVEL_DISABLED,
100,604✔
2198
                                TSDB_COLVAL_LEVEL_MEDIUM, &dst);
2199
      if (updated > 0) pCmpr->alg = dst;
100,604✔
2200
      break;
100,604✔
2201
    }
2202
  }
2203

2204
  if (updated == 0) {
100,604✔
2205
    code = TSDB_CODE_MND_COLUMN_COMPRESS_ALREADY_EXIST;
8,722✔
2206
    TAOS_RETURN(code);
8,722✔
2207
  } else if (updated == -1) {
91,882✔
2208
    code = TSDB_CODE_TSC_COMPRESS_LEVEL_ERROR;
×
2209
    TAOS_RETURN(code);
×
2210
  }
2211

2212
  pNew->colVer++;
91,882✔
2213

2214
  TAOS_RETURN(code);
91,882✔
2215
}
2216
static int32_t mndAddSuperTableColumn(const SStbObj *pOld, SStbObj *pNew, const SMAlterStbReq* pReq, int32_t ncols,
2,934,301✔
2217
                                      int8_t withCompress) {
2218
  int32_t code = 0;
2,934,301✔
2219
  int32_t maxColumns = pOld->virtualStb ? TSDB_MAX_COLUMNS : TSDB_MAX_COLUMNS_NON_VIRTUAL;
2,934,301✔
2220
  int32_t maxBytesPerRow = pOld->virtualStb ? TSDB_MAX_BYTES_PER_ROW_VIRTUAL : TSDB_MAX_BYTES_PER_ROW;
2,934,301✔
2221
  if (pOld->numOfColumns + ncols + pOld->numOfTags > maxColumns) {
2,934,301✔
2222
    code = TSDB_CODE_MND_TOO_MANY_COLUMNS;
×
2223
    TAOS_RETURN(code);
×
2224
  }
2225

2226
  if ((code = grantCheck(TSDB_GRANT_TIMESERIES)) != 0) {
2,934,301✔
2227
    TAOS_RETURN(code);
×
2228
  }
2229

2230
  if (!mndValidateSchema(pOld->pColumns, pOld->numOfColumns, pReq->pFields, maxBytesPerRow)) {
2,934,301✔
2231
    code = TSDB_CODE_PAR_INVALID_ROW_LENGTH;
×
2232
    TAOS_RETURN(code);
×
2233
  }
2234

2235
  pNew->numOfColumns = pNew->numOfColumns + ncols;
2,934,301✔
2236

2237
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
2,934,301✔
2238

2239
  if (pNew->nextColId < 0 || pNew->nextColId >= 0x7fff - ncols) {
2,934,301✔
2240
    code = TSDB_CODE_OUT_OF_RANGE;
1,234✔
2241
    TAOS_RETURN(code);
1,234✔
2242
  }
2243

2244
  for (int32_t i = 0; i < ncols; i++) {
5,552,650✔
2245
    if (withCompress) {
2,933,067✔
2246
      SFieldWithOptions *pField = taosArrayGet(pReq->pFields, i);
282,320✔
2247
      if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
282,320✔
2248
        code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
×
2249
        TAOS_RETURN(code);
×
2250
      }
2251

2252
      if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
282,320✔
2253
        code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
×
2254
        TAOS_RETURN(code);
×
2255
      }
2256

2257
      SSchema *pSchema = &pNew->pColumns[pOld->numOfColumns + i];
282,320✔
2258
      pSchema->bytes = pField->bytes;
282,320✔
2259
      pSchema->type = pField->type;
282,320✔
2260
      memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
282,320✔
2261
      if (pNew->nextColId > INT16_MAX) {
282,320✔
2262
        code = TSDB_CODE_MND_EXCEED_MAX_COL_ID;
×
2263
        TAOS_RETURN(code);
×
2264
      }
2265
      pSchema->colId = pNew->nextColId;
282,320✔
2266
      pNew->nextColId++;
282,320✔
2267

2268
      SColCmpr *pCmpr = &pNew->pCmpr[pOld->numOfColumns + i];
282,320✔
2269
      pCmpr->id = pSchema->colId;
282,320✔
2270
      pCmpr->alg = pField->compress;
282,320✔
2271
      mInfo("stb:%s, start to add column %s", pNew->name, pSchema->name);
282,320✔
2272
    } else {
2273
      SField *pField = taosArrayGet(pReq->pFields, i);
2,650,747✔
2274
      if (mndFindSuperTableColumnIndex(pOld, pField->name) >= 0) {
2,650,747✔
2275
        code = TSDB_CODE_MND_COLUMN_ALREADY_EXIST;
311,176✔
2276
        TAOS_RETURN(code);
311,176✔
2277
      }
2278

2279
      if (mndFindSuperTableTagIndex(pOld, pField->name) >= 0) {
2,339,571✔
2280
        code = TSDB_CODE_MND_TAG_ALREADY_EXIST;
2,308✔
2281
        TAOS_RETURN(code);
2,308✔
2282
      }
2283

2284
      SSchema *pSchema = &pNew->pColumns[pOld->numOfColumns + i];
2,337,263✔
2285
      pSchema->bytes = pField->bytes;
2,337,263✔
2286
      pSchema->type = pField->type;
2,337,263✔
2287
      memcpy(pSchema->name, pField->name, TSDB_COL_NAME_LEN);
2,337,263✔
2288
      if (pNew->nextColId > INT16_MAX) {
2,337,263✔
2289
        code = TSDB_CODE_MND_EXCEED_MAX_COL_ID;
×
2290
        TAOS_RETURN(code);
×
2291
      }
2292
      pSchema->colId = pNew->nextColId;
2,337,263✔
2293
      pNew->nextColId++;
2,337,263✔
2294

2295
      SColCmpr *pCmpr = &pNew->pCmpr[pOld->numOfColumns + i];
2,337,263✔
2296
      pCmpr->id = pSchema->colId;
2,337,263✔
2297
      pCmpr->alg = createDefaultColCmprByType(pSchema->type);
2,337,263✔
2298
      mInfo("stb:%s, start to add column %s", pNew->name, pSchema->name);
2,337,263✔
2299
    }
2300
  }
2301
  // 1. old schema already has extschemas
2302
  // 2. new schema has extschemas
2303
  if (pReq->pTypeMods || pOld->pExtSchemas) {
2,619,583✔
2304
    if (!pNew->pExtSchemas) {
2,619,383✔
2305
      // all ext schemas reset to zero
2306
      pNew->pExtSchemas = taosMemoryCalloc(pNew->numOfColumns, sizeof(SExtSchema));
37,432✔
2307
      if (!pNew->pExtSchemas) TAOS_RETURN(terrno);
37,432✔
2308
    }
2309
    if (pOld->pExtSchemas) {
2,619,383✔
2310
      memcpy(pNew->pExtSchemas, pOld->pExtSchemas, pOld->numOfColumns * sizeof(SExtSchema));
2,581,951✔
2311
    }
2312
    if (taosArrayGetSize(pReq->pTypeMods) > 0) {
2,619,383✔
2313
      // copy added column ext schema
2314
      for (int32_t i = 0; i < ncols; ++i) {
5,238,766✔
2315
        pNew->pColumns[pOld->numOfColumns + i].flags |= COL_HAS_TYPE_MOD;
2,619,383✔
2316
        pNew->pExtSchemas[pOld->numOfColumns + i].typeMod = *(STypeMod *)taosArrayGet(pReq->pTypeMods, i);
2,619,383✔
2317
      }
2318
    }
2319
  }
2320

2321
  pNew->colVer++;
2,619,583✔
2322
  TAOS_RETURN(code);
2,619,583✔
2323
}
2324

2325
static int32_t mndDropSuperTableColumn(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const char *colName) {
1,686,916✔
2326
  int32_t code = 0;
1,686,916✔
2327
  int32_t col = mndFindSuperTableColumnIndex(pOld, colName);
1,686,916✔
2328
  if (col < 0) {
1,686,916✔
2329
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
2,308✔
2330
    TAOS_RETURN(code);
2,308✔
2331
  }
2332

2333
  if (col == 0) {
1,684,608✔
2334
    code = TSDB_CODE_MND_INVALID_STB_ALTER_OPTION;
1,662✔
2335
    TAOS_RETURN(code);
1,662✔
2336
  }
2337

2338
  if (pOld->numOfColumns == 2) {
1,682,946✔
2339
    code = TSDB_CODE_PAR_INVALID_DROP_COL;
100✔
2340
    TAOS_RETURN(code);
100✔
2341
  }
2342

2343
  col_id_t colId = pOld->pColumns[col].colId;
1,682,846✔
2344
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, false));
1,682,846✔
2345

2346
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
1,682,846✔
2347

2348
  int32_t sz = pNew->numOfColumns - col - 1;
1,682,846✔
2349
  memmove(pNew->pColumns + col, pNew->pColumns + col + 1, sizeof(SSchema) * sz);
1,682,846✔
2350
  memmove(pNew->pCmpr + col, pNew->pCmpr + col + 1, sizeof(SColCmpr) * sz);
1,682,846✔
2351
  if (pOld->pExtSchemas) {
1,682,846✔
2352
    memmove(pNew->pExtSchemas + col, pNew->pExtSchemas + col + 1, sizeof(SExtSchema) * sz);
1,650,470✔
2353
  }
2354
  pNew->numOfColumns--;
1,682,846✔
2355

2356
  pNew->colVer++;
1,682,846✔
2357
  mInfo("stb:%s, start to drop col %s", pNew->name, colName);
1,682,846✔
2358
  TAOS_RETURN(code);
1,682,846✔
2359
}
2360

2361
static int32_t mndAlterStbColumnBytes(SMnode *pMnode, const SStbObj *pOld, SStbObj *pNew, const SField *pField) {
557,371✔
2362
  int32_t code = 0;
557,371✔
2363
  int32_t col = mndFindSuperTableColumnIndex(pOld, pField->name);
557,371✔
2364
  if (col < 0) {
557,371✔
2365
    code = TSDB_CODE_MND_COLUMN_NOT_EXIST;
200✔
2366
    TAOS_RETURN(code);
200✔
2367
  }
2368

2369
  col_id_t colId = pOld->pColumns[col].colId;
557,171✔
2370

2371
  uint32_t nLen = 0;
557,171✔
2372
  int32_t  maxBytesPerRow = pOld->virtualStb ? TSDB_MAX_BYTES_PER_ROW_VIRTUAL : TSDB_MAX_BYTES_PER_ROW;
557,171✔
2373
  for (int32_t i = 0; i < pOld->numOfColumns; ++i) {
42,911,090✔
2374
    nLen += (pOld->pColumns[i].colId == colId) ? pField->bytes : pOld->pColumns[i].bytes;
42,353,919✔
2375
  }
2376

2377
  if (nLen > maxBytesPerRow) {
557,171✔
2378
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
31,705✔
2379
    TAOS_RETURN(code);
31,705✔
2380
  }
2381

2382
  TAOS_CHECK_RETURN(mndCheckAlterColForTSma(pMnode, pOld->name, pOld->uid, colId, false));
525,466✔
2383

2384
  TAOS_CHECK_RETURN(mndAllocStbSchemas(pOld, pNew));
525,466✔
2385

2386
  SSchema *pCol = pNew->pColumns + col;
525,466✔
2387
  if (!(pCol->type == TSDB_DATA_TYPE_BINARY || pCol->type == TSDB_DATA_TYPE_VARBINARY ||
525,466✔
2388
        pCol->type == TSDB_DATA_TYPE_NCHAR || pCol->type == TSDB_DATA_TYPE_GEOMETRY)) {
511,694✔
2389
    code = TSDB_CODE_MND_INVALID_STB_OPTION;
100✔
2390
    TAOS_RETURN(code);
100✔
2391
  }
2392

2393
  if (pField->bytes <= pCol->bytes) {
525,366✔
2394
    code = TSDB_CODE_MND_INVALID_ROW_BYTES;
202,225✔
2395
    TAOS_RETURN(code);
202,225✔
2396
  }
2397

2398
  pCol->bytes = pField->bytes;
323,141✔
2399
  pNew->colVer++;
323,141✔
2400

2401
  mInfo("stb:%s, start to modify col len %s to %d", pNew->name, pField->name, pField->bytes);
323,141✔
2402
  TAOS_RETURN(code);
323,141✔
2403
}
2404

2405
static int32_t mndSetAlterStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
5,206,836✔
2406
  int32_t  code = 0;
5,206,836✔
2407
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
5,206,836✔
2408
  if (pRedoRaw == NULL) {
5,206,836✔
2409
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2410
    if (terrno != 0) code = terrno;
×
2411
    TAOS_RETURN(code);
×
2412
  }
2413
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
5,206,836✔
2414
    sdbFreeRaw(pRedoRaw);
×
2415
    TAOS_RETURN(code);
×
2416
  }
2417
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_READY));
5,206,836✔
2418

2419
  TAOS_RETURN(code);
5,206,836✔
2420
}
2421

2422
static int32_t mndSetAlterStbCommitLogs(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
5,206,836✔
2423
  int32_t  code = 0;
5,206,836✔
2424
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
5,206,836✔
2425
  if (pCommitRaw == NULL) {
5,206,836✔
2426
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2427
    if (terrno != 0) code = terrno;
×
2428
    TAOS_RETURN(code);
×
2429
  }
2430
  if ((code = mndTransAppendCommitlog(pTrans, pCommitRaw)) != 0) {
5,206,836✔
2431
    sdbFreeRaw(pCommitRaw);
×
2432
    TAOS_RETURN(code);
×
2433
  }
2434
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
5,206,836✔
2435

2436
  TAOS_RETURN(code);
5,206,836✔
2437
}
2438

2439
static int32_t mndSetAlterStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb, void *alterOriData,
5,206,836✔
2440
                                         int32_t alterOriDataLen) {
2441
  int32_t code = 0;
5,206,836✔
2442
  SSdb   *pSdb = pMnode->pSdb;
5,206,836✔
2443
  SVgObj *pVgroup = NULL;
5,206,836✔
2444
  void   *pIter = NULL;
5,206,836✔
2445
  int32_t contLen;
5,205,556✔
2446

2447
  while (1) {
13,605,710✔
2448
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
18,812,546✔
2449
    if (pIter == NULL) break;
18,812,546✔
2450
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
13,605,710✔
2451
      sdbRelease(pSdb, pVgroup);
6,350,259✔
2452
      continue;
6,350,259✔
2453
    }
2454

2455
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, alterOriData, alterOriDataLen);
7,255,451✔
2456
    if (pReq == NULL) {
7,255,451✔
2457
      sdbCancelFetch(pSdb, pIter);
×
2458
      sdbRelease(pSdb, pVgroup);
×
2459
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2460
      if (terrno != 0) code = terrno;
×
2461
      TAOS_RETURN(code);
×
2462
    }
2463
    STransAction action = {0};
7,255,451✔
2464
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
7,255,451✔
2465
    action.pCont = pReq;
7,255,451✔
2466
    action.contLen = contLen;
7,255,451✔
2467
    action.msgType = TDMT_VND_ALTER_STB;
7,255,451✔
2468
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
7,255,451✔
2469
      taosMemoryFree(pReq);
×
2470
      sdbCancelFetch(pSdb, pIter);
×
2471
      sdbRelease(pSdb, pVgroup);
×
2472
      TAOS_RETURN(code);
×
2473
    }
2474
    sdbRelease(pSdb, pVgroup);
7,255,451✔
2475
  }
2476

2477
  TAOS_RETURN(code);
5,206,836✔
2478
}
2479

2480
static int32_t mndSetAlterStbRedoActions2(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb,
×
2481
                                          void *alterOriData, int32_t alterOriDataLen) {
2482
  int32_t code = 0;
×
2483
  SSdb   *pSdb = pMnode->pSdb;
×
2484
  SVgObj *pVgroup = NULL;
×
2485
  void   *pIter = NULL;
×
2486
  int32_t contLen;
×
2487

2488
  while (1) {
×
2489
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
×
2490
    if (pIter == NULL) break;
×
2491
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
×
2492
      sdbRelease(pSdb, pVgroup);
×
2493
      continue;
×
2494
    }
2495

2496
    void *pReq = mndBuildVCreateStbReq(pMnode, pVgroup, pStb, &contLen, alterOriData, alterOriDataLen);
×
2497
    if (pReq == NULL) {
×
2498
      sdbCancelFetch(pSdb, pIter);
×
2499
      sdbRelease(pSdb, pVgroup);
×
2500
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2501
      if (terrno != 0) code = terrno;
×
2502
      TAOS_RETURN(code);
×
2503
    }
2504
    STransAction action = {0};
×
2505
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
×
2506
    action.pCont = pReq;
×
2507
    action.contLen = contLen;
×
2508
    action.msgType = TDMT_VND_CREATE_INDEX;
×
2509
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
×
2510
      taosMemoryFree(pReq);
×
2511
      sdbCancelFetch(pSdb, pIter);
×
2512
      sdbRelease(pSdb, pVgroup);
×
2513
      TAOS_RETURN(code);
×
2514
    }
2515
    sdbRelease(pSdb, pVgroup);
×
2516
  }
2517

2518
  TAOS_RETURN(code);
×
2519
}
2520

2521
static int32_t mndBuildStbSchemaImp(SMnode *pMnode, SDbObj *pDb, SStbObj *pStb, const char *tbName, STableMetaRsp *pRsp, bool refByStm) {
24,659,610✔
2522
  int32_t code = 0;
24,659,610✔
2523
  taosRLockLatch(&pStb->lock);
24,659,610✔
2524

2525
  int32_t totalCols = pStb->numOfColumns + pStb->numOfTags;
24,659,610✔
2526
  pRsp->pSchemas = taosMemoryCalloc(totalCols, sizeof(SSchema));
24,659,610✔
2527
  if (pRsp->pSchemas == NULL) {
24,659,610✔
2528
    taosRUnLockLatch(&pStb->lock);
×
2529
    code = terrno;
×
2530
    TAOS_RETURN(code);
×
2531
  }
2532
  pRsp->pSchemaExt = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchemaExt));
24,659,610✔
2533
  if (pRsp->pSchemaExt == NULL) {
24,659,610✔
2534
    taosRUnLockLatch(&pStb->lock);
×
2535
    code = terrno;
×
2536
    TAOS_RETURN(code);
×
2537
  }
2538
  pRsp->numOfColRefs = 0;
24,659,610✔
2539
  pRsp->pColRefs = NULL;
24,659,610✔
2540
  tstrncpy(pRsp->dbFName, pStb->db, sizeof(pRsp->dbFName));
24,659,610✔
2541
  tstrncpy(pRsp->tbName, tbName, sizeof(pRsp->tbName));
24,659,610✔
2542
  tstrncpy(pRsp->stbName, tbName, sizeof(pRsp->stbName));
24,659,610✔
2543
  pRsp->dbId = pDb->uid;
24,659,610✔
2544
  pRsp->numOfTags = pStb->numOfTags;
24,659,610✔
2545
  pRsp->numOfColumns = pStb->numOfColumns;
24,659,610✔
2546
  pRsp->precision = pDb->cfg.precision;
24,659,610✔
2547
  pRsp->tableType = TSDB_SUPER_TABLE;
24,659,610✔
2548
  pRsp->sversion = pStb->colVer;
24,659,610✔
2549
  pRsp->tversion = pStb->tagVer;
24,659,610✔
2550
  pRsp->suid = pStb->uid;
24,659,610✔
2551
  pRsp->tuid = pStb->uid;
24,659,610✔
2552
  pRsp->virtualStb = pStb->virtualStb;
24,659,610✔
2553
  pRsp->ownerId = pStb->ownerId;
24,659,610✔
2554
  pRsp->isAudit = pDb->cfg.isAudit ? 1 : 0;
24,659,610✔
2555
  pRsp->secLvl = pStb->securityLevel;
24,659,610✔
2556
  pRsp->secureDelete = pStb->secureDelete;
24,659,610✔
2557

2558
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
712,208,357✔
2559
    SSchema *pSchema = &pRsp->pSchemas[i];
687,549,482✔
2560
    SSchema *pSrcSchema = &pStb->pColumns[i];
687,549,482✔
2561
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
687,550,217✔
2562
    pSchema->type = pSrcSchema->type;
687,553,157✔
2563
    pSchema->flags = pSrcSchema->flags;
687,547,277✔
2564
    pSchema->colId = pSrcSchema->colId;
687,548,012✔
2565
    pSchema->bytes = pSrcSchema->bytes;
687,548,747✔
2566
  }
2567
  
2568
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
116,592,625✔
2569
    SSchema *pSchema = &pRsp->pSchemas[i + pStb->numOfColumns];
91,934,485✔
2570
    SSchema *pSrcSchema = &pStb->pTags[i];
91,935,220✔
2571
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
91,935,955✔
2572
    pSchema->type = pSrcSchema->type;
91,939,630✔
2573
    pSchema->flags = pSrcSchema->flags;
91,927,870✔
2574
    pSchema->colId = pSrcSchema->colId;
91,933,015✔
2575
    pSchema->bytes = pSrcSchema->bytes;
91,933,015✔
2576
  }
2577

2578
  if (refByStm) {
24,658,875✔
2579
    mndStreamUpdateTagsRefFlag(pMnode, pStb->uid, &pRsp->pSchemas[pStb->numOfColumns], pStb->numOfTags);
17,258,725✔
2580
  }
2581

2582
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
712,213,073✔
2583
    SColCmpr   *pCmpr = &pStb->pCmpr[i];
687,553,463✔
2584
    SSchemaExt *pSchEx = &pRsp->pSchemaExt[i];
687,551,564✔
2585
    pSchEx->colId = pCmpr->id;
687,554,198✔
2586
    pSchEx->compress = pCmpr->alg;
687,553,463✔
2587
    if (pStb->pExtSchemas) {
687,553,157✔
2588
      pSchEx->typeMod = pStb->pExtSchemas[i].typeMod;
354,951,551✔
2589
    }
2590
  }
2591

2592
  taosRUnLockLatch(&pStb->lock);
24,659,610✔
2593
  TAOS_RETURN(code);
24,659,610✔
2594
}
2595

2596
static int32_t mndBuildStbCfgImp(SDbObj *pDb, SStbObj *pStb, const char *tbName, STableCfgRsp *pRsp) {
40,083✔
2597
  int32_t code = 0;
40,083✔
2598
  taosRLockLatch(&pStb->lock);
40,083✔
2599

2600
  int32_t totalCols = pStb->numOfColumns + pStb->numOfTags;
40,083✔
2601
  pRsp->pSchemas = taosMemoryCalloc(totalCols, sizeof(SSchema));
40,083✔
2602
  if (pRsp->pSchemas == NULL) {
40,083✔
2603
    taosRUnLockLatch(&pStb->lock);
×
2604
    code = terrno;
×
2605
    TAOS_RETURN(code);
×
2606
  }
2607

2608
  tstrncpy(pRsp->dbFName, pStb->db, sizeof(pRsp->dbFName));
40,083✔
2609
  tstrncpy(pRsp->tbName, tbName, sizeof(pRsp->tbName));
40,083✔
2610
  tstrncpy(pRsp->stbName, tbName, sizeof(pRsp->stbName));
40,083✔
2611
  pRsp->numOfTags = pStb->numOfTags;
40,083✔
2612
  pRsp->numOfColumns = pStb->numOfColumns;
40,083✔
2613
  pRsp->tableType = TSDB_SUPER_TABLE;
40,083✔
2614
  pRsp->delay1 = pStb->maxdelay[0];
40,083✔
2615
  pRsp->delay2 = pStb->maxdelay[1];
40,083✔
2616
  pRsp->watermark1 = pStb->watermark[0];
40,083✔
2617
  pRsp->watermark2 = pStb->watermark[1];
40,083✔
2618
  pRsp->ttl = pStb->ttl;
40,083✔
2619
  pRsp->keep = pStb->keep;
40,083✔
2620
  pRsp->commentLen = pStb->commentLen;
40,083✔
2621
  if (pStb->commentLen > 0) {
40,083✔
2622
    pRsp->pComment = taosStrdup(pStb->comment);
×
2623
  }
2624

2625
  for (int32_t i = 0; i < pStb->numOfColumns; ++i) {
234,349✔
2626
    SSchema *pSchema = &pRsp->pSchemas[i];
194,266✔
2627
    SSchema *pSrcSchema = &pStb->pColumns[i];
194,266✔
2628
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
194,266✔
2629
    pSchema->type = pSrcSchema->type;
194,266✔
2630
    pSchema->flags = pSrcSchema->flags;
194,266✔
2631
    pSchema->colId = pSrcSchema->colId;
194,266✔
2632
    pSchema->bytes = pSrcSchema->bytes;
194,266✔
2633
  }
2634

2635
  for (int32_t i = 0; i < pStb->numOfTags; ++i) {
133,189✔
2636
    SSchema *pSchema = &pRsp->pSchemas[i + pStb->numOfColumns];
93,106✔
2637
    SSchema *pSrcSchema = &pStb->pTags[i];
93,106✔
2638
    memcpy(pSchema->name, pSrcSchema->name, TSDB_COL_NAME_LEN);
93,106✔
2639
    pSchema->type = pSrcSchema->type;
93,106✔
2640
    pSchema->flags = pSrcSchema->flags;
93,106✔
2641
    pSchema->colId = pSrcSchema->colId;
93,106✔
2642
    pSchema->bytes = pSrcSchema->bytes;
93,106✔
2643
  }
2644

2645
  if (pStb->numOfFuncs > 0) {
40,083✔
2646
    pRsp->pFuncs = taosArrayDup(pStb->pFuncs, NULL);
×
2647
  }
2648

2649
  pRsp->pSchemaExt = taosMemoryCalloc(pStb->numOfColumns, sizeof(SSchemaExt));
40,083✔
2650
  for (int32_t i = 0; i < pStb->numOfColumns; i++) {
234,349✔
2651
    SColCmpr *pCmpr = &pStb->pCmpr[i];
194,266✔
2652

2653
    SSchemaExt *pSchExt = &pRsp->pSchemaExt[i];
194,266✔
2654
    pSchExt->colId = pCmpr->id;
194,266✔
2655
    pSchExt->compress = pCmpr->alg;
194,266✔
2656
    if (pStb->pExtSchemas) {
194,266✔
2657
      pSchExt->typeMod = pStb->pExtSchemas[i].typeMod;
33,137✔
2658
    }
2659
  }
2660
  pRsp->virtualStb = pStb->virtualStb;
40,083✔
2661
  pRsp->pColRefs = NULL;
40,083✔
2662
  pRsp->secureDelete = pStb->secureDelete;
40,083✔
2663
  pRsp->securityLevel = pStb->securityLevel;
40,083✔
2664

2665
  taosRUnLockLatch(&pStb->lock);
40,083✔
2666
  TAOS_RETURN(code);
40,083✔
2667
}
2668

2669
static int32_t mndValidateStbVersion(SMnode *pMnode, SSTableVersion *pStbVer, bool *schema, bool *sma) {
9,824,152✔
2670
  int32_t code = 0;
9,824,152✔
2671
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
9,824,152✔
2672
  snprintf(tbFName, sizeof(tbFName), "%s.%s", pStbVer->dbFName, pStbVer->stbName);
9,824,152✔
2673

2674
  SDbObj *pDb = mndAcquireDb(pMnode, pStbVer->dbFName);
9,824,152✔
2675
  if (pDb == NULL) {
9,824,152✔
2676
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
36,549✔
2677
    TAOS_RETURN(code);
36,549✔
2678
  }
2679

2680
  if (pDb->uid != pStbVer->dbId) {
9,787,603✔
2681
    mndReleaseDb(pMnode, pDb);
10,297✔
2682
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
10,297✔
2683
    TAOS_RETURN(code);
10,297✔
2684
  }
2685

2686
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
9,777,306✔
2687
  if (pStb == NULL) {
9,777,306✔
2688
    mndReleaseDb(pMnode, pDb);
6,624✔
2689
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
6,624✔
2690
    TAOS_RETURN(code);
6,624✔
2691
  }
2692

2693
  taosRLockLatch(&pStb->lock);
9,770,682✔
2694

2695
  if (pStbVer->sversion != pStb->colVer || pStbVer->tversion != pStb->tagVer) {
9,770,682✔
2696
    *schema = true;
21,290✔
2697
  } else {
2698
    *schema = false;
9,749,392✔
2699
  }
2700

2701
  if (pStbVer->smaVer && pStbVer->smaVer != pStb->smaVer) {
9,770,682✔
2702
    *sma = true;
×
2703
  } else {
2704
    *sma = false;
9,770,682✔
2705
  }
2706

2707
  taosRUnLockLatch(&pStb->lock);
9,770,682✔
2708

2709
  mndReleaseDb(pMnode, pDb);
9,770,682✔
2710
  mndReleaseStb(pMnode, pStb);
9,770,682✔
2711
  return TSDB_CODE_SUCCESS;
9,770,682✔
2712
}
2713

2714
static int32_t mndBuildStbSchema(SMnode *pMnode, const char *dbFName, const char *tbName, STableMetaRsp *pRsp, bool refByStm) {
18,091,926✔
2715
  int32_t code = 0;
18,091,926✔
2716
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
18,091,926✔
2717
  snprintf(tbFName, sizeof(tbFName), "%s.%s", dbFName, tbName);
18,091,926✔
2718

2719
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
18,091,926✔
2720
  if (pDb == NULL) {
18,091,926✔
2721
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
2722
    TAOS_RETURN(code);
×
2723
  }
2724

2725
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
18,091,926✔
2726
  if (pStb == NULL) {
18,091,926✔
2727
    mndReleaseDb(pMnode, pDb);
811,911✔
2728
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
811,911✔
2729
    TAOS_RETURN(code);
811,911✔
2730
  }
2731

2732
  code = mndBuildStbSchemaImp(pMnode, pDb, pStb, tbName, pRsp, refByStm);
17,280,015✔
2733
  mndReleaseDb(pMnode, pDb);
17,280,015✔
2734
  mndReleaseStb(pMnode, pStb);
17,280,015✔
2735
  TAOS_RETURN(code);
17,280,015✔
2736
}
2737

2738
static int32_t mndBuildStbCfg(SMnode *pMnode, const char *dbFName, const char *tbName, STableCfgRsp *pRsp) {
40,083✔
2739
  int32_t code = 0;
40,083✔
2740
  char    tbFName[TSDB_TABLE_FNAME_LEN] = {0};
40,083✔
2741
  snprintf(tbFName, sizeof(tbFName), "%s.%s", dbFName, tbName);
40,083✔
2742

2743
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
40,083✔
2744
  if (pDb == NULL) {
40,083✔
2745
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
2746
    TAOS_RETURN(code);
×
2747
  }
2748

2749
  SStbObj *pStb = mndAcquireStb(pMnode, tbFName);
40,083✔
2750
  if (pStb == NULL) {
40,083✔
2751
    mndReleaseDb(pMnode, pDb);
×
2752
    code = TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
2753
    TAOS_RETURN(code);
×
2754
  }
2755

2756
  code = mndBuildStbCfgImp(pDb, pStb, tbName, pRsp);
40,083✔
2757

2758
  mndReleaseDb(pMnode, pDb);
40,083✔
2759
  mndReleaseStb(pMnode, pStb);
40,083✔
2760
  TAOS_RETURN(code);
40,083✔
2761
}
2762

2763
static int32_t mndBuildSMAlterStbRsp(SDbObj *pDb, SStbObj *pObj, void **pCont, int32_t *pLen) {
5,139,233✔
2764
  int32_t       code = 0;
5,139,233✔
2765
  SEncoder      ec = {0};
5,139,233✔
2766
  uint32_t      contLen = 0;
5,139,233✔
2767
  SMAlterStbRsp alterRsp = {0};
5,139,233✔
2768
  SName         name = {0};
5,139,233✔
2769
  TAOS_CHECK_RETURN(tNameFromString(&name, pObj->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
5,139,233✔
2770

2771
  alterRsp.pMeta = taosMemoryCalloc(1, sizeof(STableMetaRsp));
5,139,233✔
2772
  if (NULL == alterRsp.pMeta) {
5,139,233✔
2773
    code = terrno;
×
2774
    TAOS_RETURN(code);
×
2775
  }
2776

2777
  code = mndBuildStbSchemaImp(NULL, pDb, pObj, name.tname, alterRsp.pMeta, false);
5,139,233✔
2778
  if (code) {
5,139,233✔
2779
    tFreeSMAlterStbRsp(&alterRsp);
×
2780
    return code;
×
2781
  }
2782

2783
  tEncodeSize(tEncodeSMAlterStbRsp, &alterRsp, contLen, code);
5,139,233✔
2784
  if (code) {
5,139,233✔
2785
    tFreeSMAlterStbRsp(&alterRsp);
×
2786
    return code;
×
2787
  }
2788

2789
  void *cont = taosMemoryMalloc(contLen);
5,139,233✔
2790
  if (NULL == cont) {
5,139,233✔
2791
    code = terrno;
×
2792
    tFreeSMAlterStbRsp(&alterRsp);
×
2793
    TAOS_RETURN(code);
×
2794
  }
2795
  tEncoderInit(&ec, cont, contLen);
5,139,233✔
2796
  code = tEncodeSMAlterStbRsp(&ec, &alterRsp);
5,139,233✔
2797
  tEncoderClear(&ec);
5,139,233✔
2798

2799
  tFreeSMAlterStbRsp(&alterRsp);
5,139,233✔
2800

2801
  if (code < 0) TAOS_RETURN(code);
5,139,233✔
2802

2803
  *pCont = cont;
5,139,233✔
2804
  *pLen = contLen;
5,139,233✔
2805

2806
  TAOS_RETURN(code);
5,139,233✔
2807
}
2808

2809
int32_t mndBuildSMCreateStbRsp(SMnode *pMnode, char *dbFName, char *stbFName, void **pCont, int32_t *pLen) {
2,242,022✔
2810
  int32_t code = -1;
2,242,022✔
2811
  SDbObj *pDb = mndAcquireDb(pMnode, dbFName);
2,242,022✔
2812
  if (NULL == pDb) {
2,242,022✔
2813
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2814
    if (terrno != 0) code = terrno;
×
2815
    TAOS_RETURN(code);
×
2816
  }
2817

2818
  SStbObj *pObj = mndAcquireStb(pMnode, stbFName);
2,242,022✔
2819
  if (NULL == pObj) {
2,242,022✔
2820
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
1,660✔
2821
    if (terrno != 0) code = terrno;
1,660✔
2822
    goto _OVER;
1,660✔
2823
  }
2824

2825
  SEncoder       ec = {0};
2,240,362✔
2826
  uint32_t       contLen = 0;
2,240,362✔
2827
  SMCreateStbRsp stbRsp = {0};
2,240,362✔
2828
  SName          name = {0};
2,240,362✔
2829
  TAOS_CHECK_GOTO(tNameFromString(&name, pObj->name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE), NULL, _OVER);
2,240,362✔
2830

2831
  stbRsp.pMeta = taosMemoryCalloc(1, sizeof(STableMetaRsp));
2,240,362✔
2832
  if (NULL == stbRsp.pMeta) {
2,240,362✔
2833
    code = terrno;
×
2834
    goto _OVER;
×
2835
  }
2836

2837
  code = mndBuildStbSchemaImp(NULL, pDb, pObj, name.tname, stbRsp.pMeta, false);
2,240,362✔
2838
  if (code) {
2,240,362✔
2839
    tFreeSMCreateStbRsp(&stbRsp);
×
2840
    goto _OVER;
×
2841
  }
2842

2843
  tEncodeSize(tEncodeSMCreateStbRsp, &stbRsp, contLen, code);
2,240,362✔
2844
  if (code) {
2,240,362✔
2845
    tFreeSMCreateStbRsp(&stbRsp);
×
2846
    goto _OVER;
×
2847
  }
2848

2849
  void *cont = taosMemoryMalloc(contLen);
2,240,362✔
2850
  if (NULL == cont) {
2,240,362✔
2851
    code = terrno;
×
2852
    tFreeSMCreateStbRsp(&stbRsp);
×
2853
    goto _OVER;
×
2854
  }
2855
  tEncoderInit(&ec, cont, contLen);
2,240,362✔
2856
  TAOS_CHECK_GOTO(tEncodeSMCreateStbRsp(&ec, &stbRsp), NULL, _OVER);
2,240,362✔
2857
  tEncoderClear(&ec);
2,240,362✔
2858

2859
  tFreeSMCreateStbRsp(&stbRsp);
2,240,362✔
2860

2861
  *pCont = cont;
2,240,362✔
2862
  *pLen = contLen;
2,240,362✔
2863

2864
  code = 0;
2,240,362✔
2865

2866
_OVER:
2,242,022✔
2867
  if (pObj) {
2,242,022✔
2868
    mndReleaseStb(pMnode, pObj);
2,240,362✔
2869
  }
2870

2871
  if (pDb) {
2,242,022✔
2872
    mndReleaseDb(pMnode, pDb);
2,242,022✔
2873
  }
2874

2875
  TAOS_RETURN(code);
2,242,022✔
2876
}
2877

2878
static int32_t mndAlterStbImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
5,111,550✔
2879
                              void *alterOriData, int32_t alterOriDataLen) {
2880
  int32_t code = -1;
5,111,550✔
2881
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "alter-stb");
5,111,550✔
2882
  if (pTrans == NULL) {
5,111,550✔
2883
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2884
    if (terrno != 0) code = terrno;
×
2885
    goto _OVER;
×
2886
  }
2887

2888
  mInfo("trans:%d, used to alter stb:%s, alterOriDataLen:%d", pTrans->id, pStb->name, alterOriDataLen);
5,111,550✔
2889
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
5,111,550✔
2890
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
5,111,550✔
2891

2892
  if (needRsp) {
4,941,030✔
2893
    void   *pCont = NULL;
4,873,427✔
2894
    int32_t contLen = 0;
4,873,427✔
2895
    TAOS_CHECK_GOTO(mndBuildSMAlterStbRsp(pDb, pStb, &pCont, &contLen), NULL, _OVER);
4,873,427✔
2896
    mndTransSetRpcRsp(pTrans, pCont, contLen);
4,873,427✔
2897
  }
2898

2899
  TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
4,941,030✔
2900
  TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
4,941,030✔
2901
  TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
4,941,030✔
2902
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
4,941,030✔
2903

2904
  code = 0;
4,941,030✔
2905

2906
_OVER:
5,111,550✔
2907
  mndTransDrop(pTrans);
5,111,550✔
2908
  TAOS_RETURN(code);
5,111,550✔
2909
}
2910

2911
static int32_t mndAlterStbAndUpdateTagIdxImp(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp,
265,806✔
2912
                                             void *alterOriData, int32_t alterOriDataLen, const SMAlterStbReq *pAlter) {
2913
  int32_t code = -1;
265,806✔
2914
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "alter-stb");
265,806✔
2915
  if (pTrans == NULL) {
265,806✔
2916
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
2917
    if (terrno != 0) code = terrno;
×
2918
    goto _OVER;
×
2919
  }
2920

2921
  mInfo("trans:%d, used to alter stb:%s", pTrans->id, pStb->name);
265,806✔
2922
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
265,806✔
2923

2924
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
265,806✔
2925

2926
  if (needRsp) {
265,806✔
2927
    void   *pCont = NULL;
265,806✔
2928
    int32_t contLen = 0;
265,806✔
2929
    TAOS_CHECK_GOTO(mndBuildSMAlterStbRsp(pDb, pStb, &pCont, &contLen), NULL, _OVER);
265,806✔
2930
    mndTransSetRpcRsp(pTrans, pCont, contLen);
265,806✔
2931
  }
2932

2933
  if (pAlter->alterType == TSDB_ALTER_TABLE_DROP_TAG) {
265,806✔
2934
    SIdxObj idxObj = {0};
124,087✔
2935
    SField *pField0 = taosArrayGet(pAlter->pFields, 0);
124,087✔
2936
    bool    exist = false;
124,087✔
2937
    if (mndGetIdxsByTagName(pMnode, pStb, pField0->name, &idxObj) == 0) {
124,087✔
2938
      exist = true;
5,453✔
2939
    }
2940
    TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
124,087✔
2941
    TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
124,087✔
2942

2943
    if (exist == true) {
124,087✔
2944
      TAOS_CHECK_GOTO(mndSetDropIdxPrepareLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
5,453✔
2945
      TAOS_CHECK_GOTO(mndSetDropIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
5,453✔
2946
    }
2947

2948
    TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
124,087✔
2949
    TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
124,087✔
2950

2951
  } else if (pAlter->alterType == TSDB_ALTER_TABLE_UPDATE_TAG_NAME) {
141,719✔
2952
    SIdxObj     idxObj = {0};
141,719✔
2953
    SField     *pField0 = taosArrayGet(pAlter->pFields, 0);
141,719✔
2954
    SField     *pField1 = taosArrayGet(pAlter->pFields, 1);
141,719✔
2955
    const char *oTagName = pField0->name;
141,719✔
2956
    const char *nTagName = pField1->name;
141,719✔
2957
    bool        exist = false;
141,719✔
2958

2959
    if (mndGetIdxsByTagName(pMnode, pStb, pField0->name, &idxObj) == 0) {
141,719✔
2960
      exist = true;
15,738✔
2961
    }
2962

2963
    TAOS_CHECK_GOTO(mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
141,719✔
2964
    TAOS_CHECK_GOTO(mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb), NULL, _OVER);
141,719✔
2965

2966
    if (exist == true) {
141,719✔
2967
      memcpy(idxObj.colName, nTagName, strlen(nTagName));
15,738✔
2968
      idxObj.colName[strlen(nTagName)] = 0;
15,738✔
2969
      TAOS_CHECK_GOTO(mndSetAlterIdxPrepareLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
15,738✔
2970
      TAOS_CHECK_GOTO(mndSetAlterIdxCommitLogs(pMnode, pTrans, &idxObj), NULL, _OVER);
15,738✔
2971
    }
2972

2973
    TAOS_CHECK_GOTO(mndSetAlterStbRedoActions(pMnode, pTrans, pDb, pStb, alterOriData, alterOriDataLen), NULL, _OVER);
141,719✔
2974
    TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
141,719✔
2975
  }
2976
  code = 0;
265,806✔
2977

2978
_OVER:
265,806✔
2979
  mndTransDrop(pTrans);
265,806✔
2980
  TAOS_RETURN(code);
265,806✔
2981
}
2982

2983
static int32_t mndAlterStb(SMnode *pMnode, SRpcMsg *pReq, const SMAlterStbReq *pAlter, SDbObj *pDb, SStbObj *pOld) {
6,283,568✔
2984
  bool    needRsp = true;
6,283,568✔
2985
  int32_t code = -1;
6,283,568✔
2986
  SField *pField0 = NULL;
6,283,568✔
2987

2988
  SStbObj stbObj = {0};
6,283,568✔
2989
  taosRLockLatch(&pOld->lock);
6,283,568✔
2990
  memcpy(&stbObj, pOld, sizeof(SStbObj));
6,283,568✔
2991
  taosRUnLockLatch(&pOld->lock);
6,283,568✔
2992
  stbObj.pColumns = NULL;
6,283,568✔
2993
  stbObj.pTags = NULL;
6,283,568✔
2994
  stbObj.pFuncs = NULL;
6,283,568✔
2995
  stbObj.pCmpr = NULL;
6,283,568✔
2996
  stbObj.pExtSchemas = NULL;
6,283,568✔
2997
  stbObj.updateTime = taosGetTimestampMs();
6,283,568✔
2998
  stbObj.lock = 0;
6,283,568✔
2999
  stbObj.virtualStb = pOld->virtualStb;
6,283,568✔
3000
  bool updateTagIndex = false;
6,283,568✔
3001
  switch (pAlter->alterType) {
6,283,568✔
3002
    case TSDB_ALTER_TABLE_ADD_TAG:
326,636✔
3003
      code = mndAddSuperTableTag(pOld, &stbObj, pAlter->pFields, pAlter->numOfFields);
326,636✔
3004
      break;
326,636✔
3005
    case TSDB_ALTER_TABLE_DROP_TAG:
124,348✔
3006
      pField0 = taosArrayGet(pAlter->pFields, 0);
124,348✔
3007
      code = mndDropSuperTableTag(pMnode, pOld, &stbObj, pField0->name);
124,348✔
3008
      updateTagIndex = true;
124,348✔
3009
      break;
124,348✔
3010
    case TSDB_ALTER_TABLE_UPDATE_TAG_NAME:
152,677✔
3011
      code = mndAlterStbTagName(pMnode, pOld, &stbObj, pAlter->pFields);
152,677✔
3012
      updateTagIndex = true;
152,677✔
3013
      break;
152,677✔
3014
    case TSDB_ALTER_TABLE_UPDATE_TAG_BYTES:
368,595✔
3015
      pField0 = taosArrayGet(pAlter->pFields, 0);
368,595✔
3016
      code = mndAlterStbTagBytes(pMnode, pOld, &stbObj, pField0);
368,595✔
3017
      break;
368,595✔
3018
    case TSDB_ALTER_TABLE_ADD_COLUMN:
2,651,981✔
3019
      code = mndAddSuperTableColumn(pOld, &stbObj, pAlter, pAlter->numOfFields, 0);
2,651,981✔
3020
      break;
2,651,981✔
3021
    case TSDB_ALTER_TABLE_DROP_COLUMN:
1,686,916✔
3022
      pField0 = taosArrayGet(pAlter->pFields, 0);
1,686,916✔
3023
      code = mndDropSuperTableColumn(pMnode, pOld, &stbObj, pField0->name);
1,686,916✔
3024
      break;
1,686,916✔
3025
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_BYTES:
557,371✔
3026
      pField0 = taosArrayGet(pAlter->pFields, 0);
557,371✔
3027
      code = mndAlterStbColumnBytes(pMnode, pOld, &stbObj, pField0);
557,371✔
3028
      break;
557,371✔
3029
    case TSDB_ALTER_TABLE_UPDATE_OPTIONS:
29,652✔
3030
      needRsp = false;
29,652✔
3031
      code = mndUpdateTableOptions(pOld, &stbObj, pAlter->comment, pAlter->commentLen, pAlter->ttl, pAlter->keep,
29,652✔
3032
                                   pAlter->secureDelete, pAlter->securityLevel);
29,652✔
3033
#ifdef TD_ENTERPRISE
3034
      // MAC: STB security_level must not be below DB security_level
3035
      if (code == 0 && pAlter->securityLevel >= 0 && (uint8_t)pAlter->securityLevel < pDb->cfg.securityLevel) {
29,652✔
3036
        mError("stb:%s, security_level %d below db security_level %d", pAlter->name, pAlter->securityLevel,
185✔
3037
               pDb->cfg.securityLevel);
3038
        code = TSDB_CODE_MAC_OBJ_LEVEL_BELOW_DB;
185✔
3039
      }
3040
#endif
3041
      break;
29,652✔
3042
    case TSDB_ALTER_TABLE_UPDATE_COLUMN_COMPRESS:
103,072✔
3043
      code = mndUpdateSuperTableColumnCompress(pMnode, pOld, &stbObj, pAlter->pFields, pAlter->numOfFields);
103,072✔
3044
      break;
103,072✔
3045
    case TSDB_ALTER_TABLE_ADD_COLUMN_WITH_COMPRESS_OPTION:
282,320✔
3046
      code = mndAddSuperTableColumn(pOld, &stbObj, pAlter, pAlter->numOfFields, 1);
282,320✔
3047
      break;
282,320✔
3048
    default:
×
3049
      needRsp = false;
×
3050
      terrno = TSDB_CODE_OPS_NOT_SUPPORT;
×
3051
      break;
×
3052
  }
3053

3054
  if (code != 0) goto _OVER;
6,283,568✔
3055
  if (updateTagIndex == false) {
5,339,220✔
3056
    code = mndAlterStbImp(pMnode, pReq, pDb, &stbObj, needRsp, pReq->pCont, pReq->contLen);
5,073,414✔
3057
  } else {
3058
    code = mndAlterStbAndUpdateTagIdxImp(pMnode, pReq, pDb, &stbObj, needRsp, pReq->pCont, pReq->contLen, pAlter);
265,806✔
3059
  }
3060

3061
_OVER:
6,283,568✔
3062
  taosMemoryFreeClear(stbObj.pTags);
6,283,568✔
3063
  taosMemoryFreeClear(stbObj.pColumns);
6,283,568✔
3064
  taosMemoryFreeClear(stbObj.pCmpr);
6,283,568✔
3065
  if (pAlter->commentLen > 0) {
6,283,568✔
3066
    taosMemoryFreeClear(stbObj.comment);
6,732✔
3067
  }
3068
  taosMemoryFreeClear(stbObj.pExtSchemas);
6,283,568✔
3069
  TAOS_RETURN(code);
6,283,568✔
3070
}
3071

3072
static int32_t mndProcessAlterStbReq(SRpcMsg *pReq) {
6,300,684✔
3073
  SMnode       *pMnode = pReq->info.node;
6,300,684✔
3074
  int32_t       code = -1;
6,300,684✔
3075
  SDbObj       *pDb = NULL;
6,300,684✔
3076
  SStbObj      *pStb = NULL;
6,300,684✔
3077
  SUserObj     *pOperUser = NULL;
6,300,684✔
3078
  SMAlterStbReq alterReq = {0};
6,300,684✔
3079
  int64_t       tss = taosGetTimestampMs();
6,300,684✔
3080

3081
  if (tDeserializeSMAlterStbReq(pReq->pCont, pReq->contLen, &alterReq) != 0) {
6,300,684✔
3082
    code = TSDB_CODE_INVALID_MSG;
×
3083
    goto _OVER;
×
3084
  }
3085

3086
  mInfo("stb:%s, start to alter", alterReq.name);
6,300,684✔
3087
  if (mndCheckAlterStbReq(&alterReq) != 0) goto _OVER;
6,300,684✔
3088

3089
  pDb = mndAcquireDbByStb(pMnode, alterReq.name);
6,300,684✔
3090
  if (pDb == NULL) {
6,300,684✔
3091
    code = TSDB_CODE_MND_DB_NOT_EXIST;
200✔
3092
    goto _OVER;
200✔
3093
  }
3094
  if (pDb->cfg.isMount) {
6,300,484✔
3095
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
351✔
3096
    goto _OVER;
351✔
3097
  }
3098

3099
  pStb = mndAcquireStb(pMnode, alterReq.name);
6,300,133✔
3100
  if (pStb == NULL) {
6,300,133✔
3101
    code = TSDB_CODE_MND_STB_NOT_EXIST;
16,370✔
3102
    goto _OVER;
16,370✔
3103
  }
3104

3105
  SName   name = {0};
6,283,763✔
3106
  int32_t ret = 0;
6,283,763✔
3107
  if ((ret = tNameFromString(&name, alterReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0)
6,283,763✔
3108
    mError("stb:%s, failed to tNameFromString since %s", alterReq.name, tstrerror(ret));
×
3109

3110
  // if ((code = mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_WRITE_DB, pDb)) != 0) {
3111
  //   goto _OVER;
3112
  // }
3113
  TAOS_CHECK_GOTO(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser), NULL, _OVER);
6,283,763✔
3114

3115
  // MAC: only superUser or user with PRIV_SECURITY_POLICY_ALTER can ALTER STABLE ... SECURITY_LEVEL
3116
  // Check BEFORE general privilege check (holder may not have explicit ALTER grant)
3117
  if (alterReq.securityLevel >= 0) {
6,283,763✔
3118
#ifdef TD_ENTERPRISE
3119
    // Virtual tables don't support security_level
3120
    if (pStb->virtualStb) {
2,610✔
3121
      mError("stb:%s, virtual table does not support ALTER SECURITY_LEVEL", alterReq.name);
×
3122
      code = TSDB_CODE_PAR_INVALID_ALTER_TABLE;
×
3123
      goto _OVER;
×
3124
    }
3125
    if (!mndUserHasMacLabelPriv(pMnode, pOperUser)) {
2,610✔
3126
      mError("stb:%s, failed to alter security_level, user %s lacks PRIV_SECURITY_POLICY_ALTER", alterReq.name,
×
3127
             pOperUser->user);
3128
      code = TSDB_CODE_MND_NO_RIGHTS;
×
3129
      goto _OVER;
×
3130
    }
3131
    // MAC must be active to set stb security_level > 0; before activation only user levels can be set.
3132
    if (alterReq.securityLevel > 0 && pMnode->macActive != MAC_MODE_MANDATORY) {
2,610✔
3133
      mError("stb:%s, failed to alter, cannot set security_level > 0 before MAC is activated", alterReq.name);
195✔
3134
      code = TSDB_CODE_MAC_INSUFFICIENT_LEVEL;
195✔
3135
      goto _OVER;
195✔
3136
    }
3137
#endif
3138
  } else {
3139
    // Non-security_level ALTER requires normal DAC privilege checks
3140
    TAOS_CHECK_GOTO(mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB, pDb), NULL,
6,281,153✔
3141
                    _OVER);
3142
    TAOS_CHECK_GOTO(
6,281,153✔
3143
        mndCheckDbPrivilegeByNameRecF(pMnode, pOperUser, PRIV_CM_ALTER, PRIV_OBJ_TBL, pDb->name, name.tname), NULL,
3144
        _OVER);
3145
  }
3146

3147
  // MAC clearance check: user.maxSecLevel must be >= stb.securityLevel to ALTER
3148
  // Skip for security_level ALTER (SYSSEC manages security levels regardless of own level)
3149
  if (alterReq.securityLevel < 0 && !pOperUser->superUser && pStb->securityLevel > 0 &&
6,283,568✔
3150
      pOperUser->maxSecLevel < pStb->securityLevel) {
370✔
3151
    mError("stb:%s, MAC access denied since user %s maxSecLevel(%d) < stb.securityLevel(%d) for ALTER",
×
3152
           alterReq.name, pOperUser->user, pOperUser->maxSecLevel, pStb->securityLevel);
3153
    code = TSDB_CODE_MAC_INSUFFICIENT_LEVEL;
×
3154
    goto _OVER;
×
3155
  }
3156

3157
  code = mndAlterStb(pMnode, pReq, &alterReq, pDb, pStb);
6,283,568✔
3158
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
6,283,568✔
3159

3160
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
6,283,568✔
3161
    int64_t tse = taosGetTimestampMs();
6,283,568✔
3162
    double  duration = (double)(tse - tss);
6,283,568✔
3163
    duration = duration / 1000;
6,283,568✔
3164
    auditRecord(pReq, pMnode->clusterId, "alterStb", name.dbname, name.tname, alterReq.sql, alterReq.sqlLen, duration,
6,283,568✔
3165
                0);
3166
  }
3167
_OVER:
6,296,904✔
3168
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
6,300,684✔
3169
    mError("stb:%s, failed to alter since %s", alterReq.name, tstrerror(code));
1,131,984✔
3170
  }
3171

3172
  mndReleaseStb(pMnode, pStb);
6,300,684✔
3173
  mndReleaseDb(pMnode, pDb);
6,300,684✔
3174
  mndReleaseUser(pMnode, pOperUser);
6,300,684✔
3175
  tFreeSMAltertbReq(&alterReq);
6,300,684✔
3176

3177
  TAOS_RETURN(code);
6,300,684✔
3178
}
3179

3180
static int32_t mndSetDropStbPrepareLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pStb) {
521,038✔
3181
  int32_t  code = 0;
521,038✔
3182
  SSdbRaw *pRedoRaw = mndStbActionEncode(pStb);
521,038✔
3183
  if (pRedoRaw == NULL) {
521,038✔
3184
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
3185
    if (terrno != 0) code = terrno;
×
3186
    TAOS_RETURN(code);
×
3187
  }
3188
  if ((code = mndTransAppendPrepareLog(pTrans, pRedoRaw)) != 0) {
521,038✔
3189
    sdbFreeRaw(pRedoRaw);
×
3190
    TAOS_RETURN(code);
×
3191
  }
3192
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_DROPPING));
521,038✔
3193

3194
  TAOS_RETURN(code);
521,038✔
3195
}
3196

3197
static int32_t mndSetDropStbCommitLogs(SMnode *pMnode, STrans *pTrans, SStbObj *pStb) {
521,038✔
3198
  int32_t  code = 0;
521,038✔
3199
  SSdbRaw *pCommitRaw = mndStbActionEncode(pStb);
521,038✔
3200
  if (pCommitRaw == NULL) {
521,038✔
3201
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
3202
    if (terrno != 0) code = terrno;
×
3203
    TAOS_RETURN(code);
×
3204
  }
3205
  if (mndTransAppendCommitlog(pTrans, pCommitRaw) != 0) {
521,038✔
3206
    sdbFreeRaw(pCommitRaw);
×
3207
    TAOS_RETURN(code);
×
3208
  }
3209
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
521,038✔
3210

3211
  TAOS_RETURN(code);
521,038✔
3212
}
3213

3214
static int32_t mndSetDropStbRedoActions(SMnode *pMnode, STrans *pTrans, SDbObj *pDb, SStbObj *pStb) {
521,038✔
3215
  int32_t code = 0;
521,038✔
3216
  SSdb   *pSdb = pMnode->pSdb;
521,038✔
3217
  SVgObj *pVgroup = NULL;
521,038✔
3218
  void   *pIter = NULL;
521,038✔
3219

3220
  while (1) {
1,429,545✔
3221
    pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup);
1,950,583✔
3222
    if (pIter == NULL) break;
1,950,583✔
3223
    if (!mndVgroupInDb(pVgroup, pDb->uid)) {
1,429,545✔
3224
      sdbRelease(pSdb, pVgroup);
388,232✔
3225
      continue;
388,232✔
3226
    }
3227

3228
    int32_t contLen = 0;
1,041,313✔
3229
    void   *pReq = mndBuildVDropStbReq(pMnode, pVgroup, pStb, &contLen);
1,041,313✔
3230
    if (pReq == NULL) {
1,041,313✔
3231
      sdbCancelFetch(pSdb, pIter);
×
3232
      sdbRelease(pSdb, pVgroup);
×
3233
      code = TSDB_CODE_OUT_OF_MEMORY;
×
3234
      TAOS_RETURN(code);
×
3235
    }
3236

3237
    STransAction action = {0};
1,041,313✔
3238
    action.epSet = mndGetVgroupEpset(pMnode, pVgroup);
1,041,313✔
3239
    action.pCont = pReq;
1,041,313✔
3240
    action.contLen = contLen;
1,041,313✔
3241
    action.msgType = TDMT_VND_DROP_STB;
1,041,313✔
3242
    action.acceptableCode = TSDB_CODE_TDB_STB_NOT_EXIST;
1,041,313✔
3243
    if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
1,041,313✔
3244
      taosMemoryFree(pReq);
×
3245
      sdbCancelFetch(pSdb, pIter);
×
3246
      sdbRelease(pSdb, pVgroup);
×
3247
      TAOS_RETURN(code);
×
3248
    }
3249
    sdbRelease(pSdb, pVgroup);
1,041,313✔
3250
  }
3251

3252
  TAOS_RETURN(code);
521,038✔
3253
}
3254

3255
static int32_t mndDropStb(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb) {
521,038✔
3256
  int32_t code = -1;
521,038✔
3257
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "drop-stb");
521,038✔
3258
  if (pTrans == NULL) {
521,038✔
3259
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
3260
    if (terrno != 0) code = terrno;
×
3261
    goto _OVER;
×
3262
  }
3263

3264
  mInfo("trans:%d, used to drop stb:%s", pTrans->id, pStb->name);
521,038✔
3265
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
521,038✔
3266
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
521,038✔
3267

3268
  TAOS_CHECK_GOTO(mndSetDropStbPrepareLogs(pMnode, pTrans, pStb), NULL, _OVER);
521,038✔
3269
  TAOS_CHECK_GOTO(mndSetDropStbCommitLogs(pMnode, pTrans, pStb), NULL, _OVER);
521,038✔
3270
  TAOS_CHECK_GOTO(mndSetDropStbRedoActions(pMnode, pTrans, pDb, pStb), NULL, _OVER);
521,038✔
3271
  TAOS_CHECK_GOTO(mndDropIdxsByStb(pMnode, pTrans, pDb, pStb), NULL, _OVER);
521,038✔
3272
  TAOS_CHECK_GOTO(mndDropRsmaByStb(pMnode, pTrans, pDb, pStb), NULL, _OVER);
521,038✔
3273
  TAOS_CHECK_GOTO(mndUserRemoveStb(pMnode, pTrans, pStb->name), NULL, _OVER);
521,038✔
3274
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
521,038✔
3275
  code = 0;
521,038✔
3276

3277
_OVER:
521,038✔
3278
  mndTransDrop(pTrans);
521,038✔
3279
  TAOS_RETURN(code);
521,038✔
3280
}
3281

3282
static int32_t mndCheckDropStbForStream(SMnode *pMnode, const char *stbFullName, int64_t suid) {
×
3283
  int32_t code = 0;
×
3284
  SSdb   *pSdb = pMnode->pSdb;
×
3285
  void   *pIter = NULL;
×
3286
  while (1) {
×
3287
    SStreamObj *pStream = NULL;
×
3288
    pIter = sdbFetch(pSdb, SDB_STREAM, pIter, (void **)&pStream);
×
3289
    if (pIter == NULL) break;
×
3290

3291
    if (pStream->pCreate->outStbUid == suid) {
×
3292
      sdbCancelFetch(pSdb, pIter);
×
3293
      sdbRelease(pSdb, pStream);
×
3294
      TAOS_RETURN(-1);
×
3295
    }
3296

3297
    sdbRelease(pSdb, pStream);
×
3298
  }
3299
  TAOS_RETURN(code);
×
3300
}
3301

3302
static int32_t mndProcessDropTtltbRsp(SRpcMsg *pRsp) { return 0; }
×
3303
static int32_t mndProcessTrimDbRsp(SRpcMsg *pRsp) { return 0; }
×
3304
static int32_t mndProcessTrimDbWalRsp(SRpcMsg *pRsp) { return 0; }
2,480✔
3305
static int32_t mndProcessS3MigrateDbRsp(SRpcMsg *pRsp) { return 0; }
×
3306

3307
static int32_t mndProcessDropStbReq(SRpcMsg *pReq) {
1,028,268✔
3308
  SMnode      *pMnode = pReq->info.node;
1,028,268✔
3309
  int32_t      code = -1;
1,028,268✔
3310
  SDbObj      *pDb = NULL;
1,028,268✔
3311
  SStbObj     *pStb = NULL;
1,028,268✔
3312
  SUserObj    *pOperUser = NULL;
1,028,268✔
3313
  SMDropStbReq dropReq = {0};
1,028,268✔
3314
  int64_t      tss = taosGetTimestampMs();
1,028,268✔
3315

3316
  TAOS_CHECK_GOTO(tDeserializeSMDropStbReq(pReq->pCont, pReq->contLen, &dropReq), NULL, _OVER);
1,028,268✔
3317

3318
  mInfo("stb:%s, start to drop", dropReq.name);
1,028,268✔
3319

3320
  pStb = mndAcquireStb(pMnode, dropReq.name);
1,028,268✔
3321
  if (pStb == NULL) {
1,028,268✔
3322
    if (dropReq.igNotExists) {
506,879✔
3323
      mInfo("stb:%s, not exist, ignore not exist is set", dropReq.name);
505,751✔
3324
      code = 0;
505,751✔
3325
      goto _OVER;
505,751✔
3326
    } else {
3327
      code = TSDB_CODE_MND_STB_NOT_EXIST;
1,128✔
3328
      goto _OVER;
1,128✔
3329
    }
3330
  }
3331

3332
  if ((dropReq.source == TD_REQ_FROM_TAOX_OLD || dropReq.source == TD_REQ_FROM_TAOX) && pStb->uid != dropReq.suid) {
521,389✔
3333
    code = 0;
×
3334
    goto _OVER;
×
3335
  }
3336

3337
  pDb = mndAcquireDbByStb(pMnode, dropReq.name);
521,389✔
3338
  if (pDb == NULL) {
521,389✔
3339
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
3340
    goto _OVER;
×
3341
  }
3342

3343
  SName   name = {0};
521,389✔
3344
  int32_t ret = 0;
521,389✔
3345
  if ((ret = tNameFromString(&name, dropReq.name, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE)) != 0)
521,389✔
3346
    mError("stb:%s, failed to tNameFromString since %s", dropReq.name, tstrerror(ret));
×
3347

3348
  // if ((code = mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), MND_OPER_WRITE_DB, pDb)) != 0) {
3349
  //   goto _OVER;
3350
  // }
3351
  TAOS_CHECK_GOTO(mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser), NULL, _OVER);
521,389✔
3352
  TAOS_CHECK_GOTO(mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB, pDb), NULL,
521,389✔
3353
                  _OVER);
3354
  TAOS_CHECK_GOTO(
521,389✔
3355
      mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_DROP, PRIV_OBJ_TBL, pStb->ownerId, pDb->name, name.tname),
3356
      NULL, _OVER);
3357

3358
  // MAC clearance check: user.maxSecLevel must be >= stb.securityLevel to DROP
3359
  if (!pOperUser->superUser && pStb->securityLevel > 0 && pOperUser->maxSecLevel < pStb->securityLevel) {
521,389✔
3360
    mError("stb:%s, MAC access denied since user %s maxSecLevel(%d) < stb.securityLevel(%d) for DROP",
×
3361
           dropReq.name, pOperUser->user, pOperUser->maxSecLevel, pStb->securityLevel);
3362
    code = TSDB_CODE_MAC_INSUFFICIENT_LEVEL;
×
3363
    goto _OVER;
×
3364
  }
3365

3366
  if (pDb->cfg.isMount) {
521,389✔
3367
    code = TSDB_CODE_MND_MOUNT_OBJ_NOT_SUPPORT;
351✔
3368
    goto _OVER;
351✔
3369
  }
3370

3371
  code = mndDropStb(pMnode, pReq, pDb, pStb);
521,038✔
3372
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
521,038✔
3373

3374
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
521,038✔
3375
    int64_t tse = taosGetTimestampMs();
521,038✔
3376
    double  duration = (double)(tse - tss);
521,038✔
3377
    duration = duration / 1000;
521,038✔
3378
    auditRecord(pReq, pMnode->clusterId, "dropStb", name.dbname, name.tname, dropReq.sql, dropReq.sqlLen, duration, 0);
521,038✔
3379
  }
3380
_OVER:
1,027,848✔
3381
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
1,028,268✔
3382
    mError("stb:%s, failed to drop since %s", dropReq.name, tstrerror(code));
1,479✔
3383
  }
3384

3385
  mndReleaseDb(pMnode, pDb);
1,028,268✔
3386
  mndReleaseStb(pMnode, pStb);
1,028,268✔
3387
  mndReleaseUser(pMnode, pOperUser);
1,028,268✔
3388
  tFreeSMDropStbReq(&dropReq);
1,028,268✔
3389
  TAOS_RETURN(code);
1,028,268✔
3390
}
3391

3392
static int32_t mndProcessTableMetaReq(SRpcMsg *pReq) {
20,468,970✔
3393
  SMnode       *pMnode = pReq->info.node;
20,468,970✔
3394
  int32_t       code = -1;
20,468,970✔
3395
  STableInfoReq infoReq = {0};
20,468,970✔
3396
  STableMetaRsp metaRsp = {0};
20,468,970✔
3397
  SUserObj     *pUser = NULL;
20,468,970✔
3398

3399
  code = mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pUser);
20,468,970✔
3400
  if (pUser == NULL) return 0;
20,468,970✔
3401
  bool sysinfo = pUser->sysInfo;
20,468,970✔
3402

3403
  TAOS_CHECK_GOTO(tDeserializeSTableInfoReq(pReq->pCont, pReq->contLen, &infoReq), NULL, _OVER);
20,468,970✔
3404

3405
  if (0 == strcmp(infoReq.dbFName, TSDB_INFORMATION_SCHEMA_DB)) {
20,468,970✔
3406
    mInfo("information_schema table:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
2,234,610✔
3407
    TAOS_CHECK_GOTO(mndBuildInsTableSchema(pMnode, infoReq.dbFName, infoReq.tbName, sysinfo, &metaRsp), NULL, _OVER);
2,234,610✔
3408
  } else if (0 == strcmp(infoReq.dbFName, TSDB_PERFORMANCE_SCHEMA_DB)) {
18,234,360✔
3409
    mInfo("performance_schema table:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
163,724✔
3410
    TAOS_CHECK_GOTO(mndBuildPerfsTableSchema(pMnode, infoReq.dbFName, infoReq.tbName, &metaRsp), NULL, _OVER);
163,724✔
3411
  } else {
3412
    mInfo("stb:%s.%s, start to retrieve meta", infoReq.dbFName, infoReq.tbName);
18,070,636✔
3413
    TAOS_CHECK_GOTO(mndBuildStbSchema(pMnode, infoReq.dbFName, infoReq.tbName, &metaRsp, true), NULL, _OVER);
18,070,636✔
3414
  }
3415

3416
  int32_t rspLen = tSerializeSTableMetaRsp(NULL, 0, &metaRsp);
19,460,512✔
3417
  if (rspLen < 0) {
19,460,512✔
3418
    code = TSDB_CODE_INVALID_MSG;
×
3419
    goto _OVER;
×
3420
  }
3421

3422
  void *pRsp = rpcMallocCont(rspLen);
19,460,512✔
3423
  if (pRsp == NULL) {
19,460,512✔
3424
    code = terrno;
×
3425
    goto _OVER;
×
3426
  }
3427

3428
  if ((rspLen = tSerializeSTableMetaRsp(pRsp, rspLen, &metaRsp)) < 0) {
19,460,512✔
3429
    code = rspLen;
×
3430
    goto _OVER;
×
3431
  }
3432
  pReq->info.rsp = pRsp;
19,460,512✔
3433
  pReq->info.rspLen = rspLen;
19,460,512✔
3434
  code = 0;
19,460,512✔
3435

3436
  mTrace("%s.%s, meta is retrieved", infoReq.dbFName, infoReq.tbName);
19,460,512✔
3437

3438
_OVER:
20,468,870✔
3439
  if (code != 0) {
20,468,970✔
3440
    mError("stb:%s.%s, failed to retrieve meta since %s", infoReq.dbFName, infoReq.tbName, tstrerror(code));
1,008,458✔
3441
  }
3442

3443
  mndReleaseUser(pMnode, pUser);
20,468,970✔
3444
  tFreeSTableMetaRsp(&metaRsp);
20,468,970✔
3445
  // TODO change to TAOS_RETURN
3446
  return code;
20,468,541✔
3447
}
3448

3449
static int32_t mndProcessTableCfgReq(SRpcMsg *pReq) {
46,683✔
3450
  SMnode      *pMnode = pReq->info.node;
46,683✔
3451
  int32_t      code = -1;
46,683✔
3452
  STableCfgReq cfgReq = {0};
46,683✔
3453
  STableCfgRsp cfgRsp = {0};
46,683✔
3454

3455
  TAOS_CHECK_GOTO(tDeserializeSTableCfgReq(pReq->pCont, pReq->contLen, &cfgReq), NULL, _OVER);
46,683✔
3456

3457
  char dbName[TSDB_DB_NAME_LEN] = {0};
46,683✔
3458
  TAOS_CHECK_GOTO(mndExtractShortDbNameFromDbFullName(cfgReq.dbFName, dbName), NULL, _OVER);
46,683✔
3459
  if (0 == strcmp(dbName, TSDB_INFORMATION_SCHEMA_DB)) {
46,683✔
3460
    mInfo("information_schema table:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
4,400✔
3461
    TAOS_CHECK_GOTO(mndBuildInsTableCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
4,400✔
3462
  } else if (0 == strcmp(dbName, TSDB_PERFORMANCE_SCHEMA_DB)) {
42,283✔
3463
    mInfo("performance_schema table:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
2,200✔
3464
    TAOS_CHECK_GOTO(mndBuildPerfsTableCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
2,200✔
3465
  } else {
3466
    mInfo("stb:%s.%s, start to retrieve cfg", cfgReq.dbFName, cfgReq.tbName);
40,083✔
3467
    TAOS_CHECK_GOTO(mndBuildStbCfg(pMnode, cfgReq.dbFName, cfgReq.tbName, &cfgRsp), NULL, _OVER);
40,083✔
3468
  }
3469

3470
  int32_t rspLen = tSerializeSTableCfgRsp(NULL, 0, &cfgRsp);
46,683✔
3471
  if (rspLen < 0) {
46,683✔
3472
    code = TSDB_CODE_INVALID_MSG;
×
3473
    goto _OVER;
×
3474
  }
3475

3476
  void *pRsp = rpcMallocCont(rspLen);
46,683✔
3477
  if (pRsp == NULL) {
46,683✔
3478
    code = terrno;
×
3479
    goto _OVER;
×
3480
  }
3481

3482
  if ((rspLen = tSerializeSTableCfgRsp(pRsp, rspLen, &cfgRsp)) < 0) {
46,683✔
3483
    code = rspLen;
×
3484
    goto _OVER;
×
3485
  }
3486
  pReq->info.rsp = pRsp;
46,683✔
3487
  pReq->info.rspLen = rspLen;
46,683✔
3488
  code = 0;
46,683✔
3489

3490
  mTrace("%s.%s, cfg is retrieved", cfgReq.dbFName, cfgReq.tbName);
46,683✔
3491

3492
_OVER:
46,683✔
3493
  if (code != 0) {
46,683✔
3494
    mError("stb:%s.%s, failed to retrieve cfg since %s", cfgReq.dbFName, cfgReq.tbName, tstrerror(code));
×
3495
  }
3496

3497
  tFreeSTableCfgRsp(&cfgRsp);
46,683✔
3498
  TAOS_RETURN(code);
46,683✔
3499
}
3500

3501
int32_t mndValidateStbInfo(SMnode *pMnode, SSTableVersion *pStbVersions, int32_t numOfStbs, void **ppRsp,
6,802,338✔
3502
                           int32_t *pRspLen) {
3503
  int32_t   code = 0;
6,802,338✔
3504
  SSTbHbRsp hbRsp = {0};
6,802,338✔
3505
  hbRsp.pMetaRsp = taosArrayInit(numOfStbs, sizeof(STableMetaRsp));
6,802,338✔
3506
  if (hbRsp.pMetaRsp == NULL) {
6,802,338✔
3507
    code = terrno;
×
3508
    TAOS_RETURN(code);
×
3509
  }
3510

3511
  hbRsp.pIndexRsp = taosArrayInit(numOfStbs, sizeof(STableIndexRsp));
6,802,338✔
3512
  if (NULL == hbRsp.pIndexRsp) {
6,802,338✔
3513
    taosArrayDestroy(hbRsp.pMetaRsp);
×
3514
    code = terrno;
×
3515
    TAOS_RETURN(code);
×
3516
  }
3517

3518
  for (int32_t i = 0; i < numOfStbs; ++i) {
16,626,490✔
3519
    SSTableVersion *pStbVersion = &pStbVersions[i];
9,824,152✔
3520
    pStbVersion->suid = be64toh(pStbVersion->suid);
9,824,152✔
3521
    pStbVersion->sversion = ntohl(pStbVersion->sversion);
9,824,152✔
3522
    pStbVersion->tversion = ntohl(pStbVersion->tversion);
9,824,152✔
3523
    pStbVersion->smaVer = ntohl(pStbVersion->smaVer);
9,824,152✔
3524

3525
    bool    schema = false;
9,824,152✔
3526
    bool    sma = false;
9,824,152✔
3527
    int32_t code = mndValidateStbVersion(pMnode, pStbVersion, &schema, &sma);
9,824,152✔
3528
    if (TSDB_CODE_SUCCESS != code) {
9,824,152✔
3529
      STableMetaRsp metaRsp = {0};
53,470✔
3530
      metaRsp.numOfColumns = -1;
53,470✔
3531
      metaRsp.suid = pStbVersion->suid;
53,470✔
3532
      tstrncpy(metaRsp.dbFName, pStbVersion->dbFName, sizeof(metaRsp.dbFName));
53,470✔
3533
      tstrncpy(metaRsp.tbName, pStbVersion->stbName, sizeof(metaRsp.tbName));
53,470✔
3534
      tstrncpy(metaRsp.stbName, pStbVersion->stbName, sizeof(metaRsp.stbName));
53,470✔
3535
      if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
106,940✔
3536
        code = terrno;
×
3537
        return code;
×
3538
      }
3539
      continue;
53,470✔
3540
    }
3541

3542
    if (schema) {
9,770,682✔
3543
      STableMetaRsp metaRsp = {0};
21,290✔
3544
      mInfo("stb:%s.%s, start to retrieve meta", pStbVersion->dbFName, pStbVersion->stbName);
21,290✔
3545
      if (mndBuildStbSchema(pMnode, pStbVersion->dbFName, pStbVersion->stbName, &metaRsp, false) != 0) {
21,290✔
3546
        metaRsp.numOfColumns = -1;
×
3547
        metaRsp.suid = pStbVersion->suid;
×
3548
        tstrncpy(metaRsp.dbFName, pStbVersion->dbFName, sizeof(metaRsp.dbFName));
×
3549
        tstrncpy(metaRsp.tbName, pStbVersion->stbName, sizeof(metaRsp.tbName));
×
3550
        tstrncpy(metaRsp.stbName, pStbVersion->stbName, sizeof(metaRsp.stbName));
×
3551
        if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
×
3552
          code = terrno;
×
3553
          return code;
×
3554
        }
3555
        continue;
×
3556
      }
3557

3558
      if (taosArrayPush(hbRsp.pMetaRsp, &metaRsp) == NULL) {
42,580✔
3559
        code = terrno;
×
3560
        return code;
×
3561
      }
3562
    }
3563

3564
    if (sma) {
9,770,682✔
3565
      bool           exist = false;
×
3566
      char           tbFName[TSDB_TABLE_FNAME_LEN];
×
3567
      STableIndexRsp indexRsp = {0};
×
3568
      indexRsp.pIndex = taosArrayInit(10, sizeof(STableIndexInfo));
×
3569
      if (NULL == indexRsp.pIndex) {
×
3570
        code = terrno;
×
3571
        TAOS_RETURN(code);
×
3572
      }
3573

3574
      (void)snprintf(tbFName, sizeof(tbFName), "%s.%s", pStbVersion->dbFName, pStbVersion->stbName);
×
3575
      tstrncpy(indexRsp.dbFName, pStbVersion->dbFName, sizeof(indexRsp.dbFName));
×
3576
      tstrncpy(indexRsp.tbName, pStbVersion->stbName, sizeof(indexRsp.tbName));
×
3577

3578
      if (taosArrayPush(hbRsp.pIndexRsp, &indexRsp) == NULL) {
×
3579
        code = terrno;
×
3580
        return code;
×
3581
      }
3582
    }
3583
  }
3584

3585
  int32_t rspLen = tSerializeSSTbHbRsp(NULL, 0, &hbRsp);
6,802,338✔
3586
  if (rspLen < 0) {
6,802,338✔
3587
    tFreeSSTbHbRsp(&hbRsp);
×
3588
    code = TSDB_CODE_INVALID_MSG;
×
3589
    TAOS_RETURN(code);
×
3590
  }
3591

3592
  void *pRsp = taosMemoryMalloc(rspLen);
6,802,338✔
3593
  if (pRsp == NULL) {
6,802,338✔
3594
    tFreeSSTbHbRsp(&hbRsp);
×
3595
    code = terrno;
×
3596
    TAOS_RETURN(code);
×
3597
  }
3598

3599
  rspLen = tSerializeSSTbHbRsp(pRsp, rspLen, &hbRsp);
6,802,338✔
3600
  tFreeSSTbHbRsp(&hbRsp);
6,802,338✔
3601
  if (rspLen < 0) return rspLen;
6,802,338✔
3602
  *ppRsp = pRsp;
6,802,338✔
3603
  *pRspLen = rspLen;
6,802,338✔
3604
  TAOS_RETURN(code);
6,802,338✔
3605
}
3606

3607
int32_t mndGetNumOfStbs(SMnode *pMnode, char *dbName, int32_t *pNumOfStbs) {
2,326,915✔
3608
  int32_t code = 0;
2,326,915✔
3609
  SSdb   *pSdb = pMnode->pSdb;
2,326,915✔
3610
  SDbObj *pDb = mndAcquireDb(pMnode, dbName);
2,326,915✔
3611
  if (pDb == NULL) {
2,326,915✔
3612
    code = TSDB_CODE_MND_DB_NOT_SELECTED;
×
3613
    TAOS_RETURN(code);
×
3614
  }
3615

3616
  int32_t numOfStbs = 0;
2,326,915✔
3617
  void   *pIter = NULL;
2,326,915✔
3618
  while (1) {
38,681,661✔
3619
    SStbObj *pStb = NULL;
41,008,576✔
3620
    pIter = sdbFetch(pSdb, SDB_STB, pIter, (void **)&pStb);
41,008,576✔
3621
    if (pIter == NULL) break;
41,008,576✔
3622

3623
    if (pStb->dbUid == pDb->uid) {
38,681,661✔
3624
      numOfStbs++;
25,708,860✔
3625
    }
3626

3627
    sdbRelease(pSdb, pStb);
38,681,661✔
3628
  }
3629

3630
  *pNumOfStbs = numOfStbs;
2,326,915✔
3631
  mndReleaseDb(pMnode, pDb);
2,326,915✔
3632
  TAOS_RETURN(code);
2,326,915✔
3633
}
3634

3635
int32_t mndExtractDbNameFromStbFullName(const char *stbFullName, char *dst) {
×
3636
  SName name = {0};
×
3637
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
×
3638

3639
  TAOS_CHECK_RETURN(tNameGetFullDbName(&name, dst));
×
3640

3641
  return 0;
×
3642
}
3643

3644
int32_t mndExtractShortDbNameFromStbFullName(const char *stbFullName, char *dst) {
×
3645
  SName name = {0};
×
3646
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB | T_NAME_TABLE));
×
3647

3648
  TAOS_CHECK_RETURN(tNameGetDbName(&name, dst));
×
3649

3650
  return 0;
×
3651
}
3652

3653
int32_t mndExtractShortDbNameFromDbFullName(const char *stbFullName, char *dst) {
46,683✔
3654
  SName name = {0};
46,683✔
3655
  TAOS_CHECK_RETURN(tNameFromString(&name, stbFullName, T_NAME_ACCT | T_NAME_DB));
46,683✔
3656

3657
  TAOS_CHECK_RETURN(tNameGetDbName(&name, dst));
46,683✔
3658

3659
  return 0;
46,683✔
3660
}
3661

3662
void mndExtractTbNameFromStbFullName(const char *stbFullName, char *dst, int32_t dstSize) {
3,427,511✔
3663
  int32_t pos = -1;
3,427,511✔
3664
  int32_t num = 0;
3,427,511✔
3665
  for (pos = 0; stbFullName[pos] != 0; ++pos) {
31,804,060✔
3666
    if (stbFullName[pos] == TS_PATH_DELIMITER[0]) num++;
31,803,479✔
3667
    if (num == 2) break;
31,804,060✔
3668
  }
3669

3670
  if (num == 2) {
3,428,092✔
3671
    tstrncpy(dst, stbFullName + pos + 1, dstSize);
3,427,511✔
3672
  }
3673
}
3,428,092✔
3674

3675
static int32_t mndRetrieveStb(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
320,281✔
3676
  SMnode    *pMnode = pReq->info.node;
320,281✔
3677
  SSdb      *pSdb = pMnode->pSdb;
320,281✔
3678
  int32_t    numOfRows = 0;
320,281✔
3679
  SStbObj   *pStb = NULL;
320,281✔
3680
  SUserObj  *pOperUser = NULL;
320,281✔
3681
  SSHashObj *pUidNames = NULL;
320,281✔
3682
  int32_t    cols = 0;
320,281✔
3683
  int32_t    lino = 0;
320,281✔
3684
  int32_t    code = 0;
320,281✔
3685
  char       objFName[TSDB_OBJ_FNAME_LEN + 1] = {0};
320,281✔
3686
  bool       showAll = false;
320,281✔
3687

3688
  SDbObj *pDb = NULL;
320,281✔
3689
  if (strlen(pShow->db) > 0) {
320,281✔
3690
    pDb = mndAcquireDb(pMnode, pShow->db);
259,375✔
3691
    if (pDb == NULL) return terrno;
259,375✔
3692
  }
3693

3694
  if ((code = mndAcquireUser(pMnode, RPC_MSG_USER(pReq), &pOperUser)) != 0) {
318,901✔
3695
    goto _ERROR;
×
3696
  }
3697

3698
  (void)snprintf(objFName, sizeof(objFName), "%d.*", pOperUser->acctId);
318,901✔
3699
  showAll = (0 == mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_TBL, pDb ? pDb->ownerId : 0,
318,901✔
3700
                                           pDb ? pDb->name : objFName, "*"));
3701
  showAll = showAll && (0 == mndCheckDbPrivilegeByName(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB,
318,901✔
3702
                                                       pDb ? pDb->name : objFName, false));
3703

3704
  while (numOfRows < rows) {
2,456,944✔
3705
    pShow->pIter = sdbFetch(pSdb, SDB_STB, pShow->pIter, (void **)&pStb);
2,455,628✔
3706
    if (pShow->pIter == NULL) break;
2,455,628✔
3707

3708
    if (pDb != NULL && pStb->dbUid != pDb->uid) {
2,138,043✔
3709
      sdbRelease(pSdb, pStb);
1,039,164✔
3710
      continue;
1,039,164✔
3711
    }
3712

3713
    if (isTsmaResSTb(pStb->name)) {
1,098,879✔
3714
      sdbRelease(pSdb, pStb);
×
3715
      continue;
×
3716
    }
3717

3718
    if (pOperUser->superUser == 0 && pMnode->macActive == MAC_MODE_MANDATORY && pStb->securityLevel > 0 &&
1,098,879✔
3719
        pOperUser->maxSecLevel < pStb->securityLevel) {
2,960✔
3720
      sdbRelease(pSdb, pStb);
370✔
3721
      continue;
370✔
3722
    }
3723

3724
#if 0
3725
    if ((0 == pUser->superUser) && mndCheckStbPrivilege(pMnode, pUser, RPC_MSG_TOKEN(pReq), MND_OPER_SHOW_STB, pStb) != 0) {
3726
      sdbRelease(pSdb, pStb);
3727
      terrno = 0;
3728
      continue;
3729
    }
3730
#endif
3731
    cols = 0;
1,098,509✔
3732

3733
    SName name = {0};
1,098,509✔
3734

3735
    char stbName[TSDB_TABLE_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,098,509✔
3736
    mndExtractTbNameFromStbFullName(pStb->name, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN);
1,098,509✔
3737

3738
    if (!showAll && (mndCheckObjPrivilegeRecF(pMnode, pOperUser, PRIV_CM_SHOW, PRIV_OBJ_TBL, pStb->ownerId, pStb->db,
1,098,509✔
3739
                                              &stbName[VARSTR_HEADER_SIZE]) ||
3,899✔
3740
                     mndCheckDbPrivilegeByName(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_USE_DB,
3,899✔
3741
                                               pStb->db, false))) {
3,899✔
3742
      sdbRelease(pSdb, pStb);
2,471✔
3743
      terrno = 0;
2,471✔
3744
      continue;
2,471✔
3745
    }
3746

3747
    varDataSetLen(stbName, strlen(&stbName[VARSTR_HEADER_SIZE]));
1,096,038✔
3748
    SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3749
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)stbName, false), pStb, &lino, _ERROR);
1,096,038✔
3750

3751
    char db[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,096,038✔
3752
    RETRIEVE_CHECK_GOTO(tNameFromString(&name, pStb->db, T_NAME_ACCT | T_NAME_DB), pStb, &lino, _ERROR);
1,096,038✔
3753
    RETRIEVE_CHECK_GOTO(tNameGetDbName(&name, varDataVal(db)), pStb, &lino, _ERROR);
1,096,038✔
3754
    varDataSetLen(db, strlen(varDataVal(db)));
1,096,038✔
3755
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3756
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)db, false), pStb, &lino, _ERROR);
1,096,038✔
3757

3758
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3759
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->createdTime, false), pStb, &lino,
1,096,038✔
3760
                        _ERROR);
3761

3762
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3763
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->numOfColumns, false), pStb, &lino,
1,096,038✔
3764
                        _ERROR);
3765

3766
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3767
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->numOfTags, false), pStb, &lino, _ERROR);
1,096,038✔
3768

3769
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3770
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->updateTime, false), pStb, &lino,
1,096,038✔
3771
                        _ERROR);  // number of tables
3772

3773
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3774
    if (pStb->commentLen > 0) {
1,096,038✔
3775
      char comment[TSDB_TB_COMMENT_LEN + VARSTR_HEADER_SIZE] = {0};
20,841✔
3776
      STR_TO_VARSTR(comment, pStb->comment);
20,841✔
3777
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, comment, false), pStb, &lino, _ERROR);
20,841✔
3778
    } else if (pStb->commentLen == 0) {
1,075,197✔
3779
      char comment[VARSTR_HEADER_SIZE + VARSTR_HEADER_SIZE] = {0};
149,266✔
3780
      STR_TO_VARSTR(comment, "");
149,266✔
3781
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, comment, false), pStb, &lino, _ERROR);
149,266✔
3782
    } else {
3783
      colDataSetNULL(pColInfo, numOfRows);
925,931✔
3784
    }
3785

3786
    char watermark[64 + VARSTR_HEADER_SIZE] = {0};
1,096,038✔
3787
    (void)snprintf(varDataVal(watermark), sizeof(watermark) - VARSTR_HEADER_SIZE, "%" PRId64 "a,%" PRId64 "a",
2,190,976✔
3788
                   pStb->watermark[0], pStb->watermark[1]);
2,190,976✔
3789
    varDataSetLen(watermark, strlen(varDataVal(watermark)));
1,096,038✔
3790

3791
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3792
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)watermark, false), pStb, &lino, _ERROR);
1,096,038✔
3793

3794
    char maxDelay[64 + VARSTR_HEADER_SIZE] = {0};
1,096,038✔
3795
    (void)snprintf(varDataVal(maxDelay), sizeof(maxDelay) - VARSTR_HEADER_SIZE, "%" PRId64 "a,%" PRId64 "a",
2,190,976✔
3796
                   pStb->maxdelay[0], pStb->maxdelay[1]);
2,190,976✔
3797
    varDataSetLen(maxDelay, strlen(varDataVal(maxDelay)));
1,096,038✔
3798

3799
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3800
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)maxDelay, false), pStb, &lino, _ERROR);
1,096,038✔
3801

3802
    char    rollup[160 + VARSTR_HEADER_SIZE] = {0};
1,096,038✔
3803
    int32_t rollupNum = (int32_t)taosArrayGetSize(pStb->pFuncs);
1,096,038✔
3804
    char   *sep = ", ";
1,096,038✔
3805
    int32_t sepLen = strlen(sep);
1,096,038✔
3806
    int32_t rollupLen = sizeof(rollup) - VARSTR_HEADER_SIZE - 2;
1,096,038✔
3807
    for (int32_t i = 0; i < rollupNum; ++i) {
1,096,038✔
3808
      char *funcName = taosArrayGet(pStb->pFuncs, i);
×
3809
      if (i) {
×
3810
        (void)strncat(varDataVal(rollup), sep, rollupLen);
×
3811
        rollupLen -= sepLen;
×
3812
      }
3813
      (void)strncat(varDataVal(rollup), funcName, rollupLen);
×
3814
      rollupLen -= strlen(funcName);
×
3815
    }
3816
    varDataSetLen(rollup, strlen(varDataVal(rollup)));
1,096,038✔
3817

3818
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3819
    RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)rollup, false), pStb, &lino, _ERROR);
1,096,038✔
3820

3821
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3822
    if (pColInfo) {
1,096,038✔
3823
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->uid), false), pStb, &lino, _ERROR);
1,096,038✔
3824
    }
3825

3826
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3827
    if (pColInfo) {
1,096,038✔
3828
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->virtualStb), false), pStb, &lino, _ERROR);
1,096,038✔
3829
    }
3830

3831
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3832
    if (pColInfo) {
1,096,038✔
3833
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&pStb->keep), false), pStb, &lino, _ERROR);
1,096,038✔
3834
    }
3835

3836
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3837
    if (pColInfo) {
1,096,038✔
3838
      if (!pUidNames) {
1,096,038✔
3839
        TAOS_CHECK_GOTO(mndBuildUidNamesHash(pMnode, &pUidNames), &lino, _OVER);
247,051✔
3840
      }
3841
      const char *ownerName = tSimpleHashGet(pUidNames, (const char *)&pStb->ownerId, sizeof(pStb->ownerId));
1,096,038✔
3842
      char        owner[TSDB_USER_LEN + VARSTR_HEADER_SIZE] = {0};
1,096,038✔
3843
      STR_WITH_MAXSIZE_TO_VARSTR(owner, ownerName ? ownerName : "[unknown]", sizeof(owner));
1,096,038✔
3844
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)owner, false), pStb, &lino, _ERROR);
1,096,038✔
3845
    }
3846

3847
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
1,096,038✔
3848
    if (pColInfo) {
1,096,038✔
3849
      uint8_t securityLevel = pStb->securityLevel;
1,096,038✔
3850
      RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)(&securityLevel), false), pStb, &lino,
1,096,038✔
3851
                          _ERROR);
3852
    }
3853

3854
    numOfRows++;
1,096,038✔
3855
    sdbRelease(pSdb, pStb);
1,096,038✔
3856
  }
3857

3858
  if (pDb != NULL) {
318,901✔
3859
    mndReleaseDb(pMnode, pDb);
257,995✔
3860
  }
3861
  if (pOperUser != NULL) {
318,901✔
3862
    mndReleaseUser(pMnode, pOperUser);
318,901✔
3863
  }
3864

3865
  goto _OVER;
318,901✔
3866

3867
_ERROR:
×
3868
  if (pDb != NULL) {
×
3869
    mndReleaseDb(pMnode, pDb);
×
3870
  }
3871
  if (pOperUser != NULL) {
×
3872
    mndReleaseUser(pMnode, pOperUser);
×
3873
  }
3874
  mError("show:0x%" PRIx64 ", failed to retrieve data at %s:%d since %s", pShow->id, __FUNCTION__, lino,
×
3875
         tstrerror(code));
3876

3877
_OVER:
317,601✔
3878
  pShow->numOfRows += numOfRows;
318,901✔
3879
  tSimpleHashCleanup(pUidNames);
318,901✔
3880
  return numOfRows;
318,901✔
3881
}
3882

3883
static int32_t buildDbColsInfoBlock(const SSDataBlock *p, const SSysTableMeta *pSysDbTableMeta, size_t size,
2,051,113✔
3884
                                    const char *dbName, const char *tbName) {
3885
  char    tName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
2,051,113✔
3886
  char    dName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
2,051,694✔
3887
  char    typeName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
2,051,694✔
3888
  int32_t numOfRows = p->info.rows;
2,051,113✔
3889
  int32_t lino = 0;
2,051,113✔
3890
  int32_t code = 0;
2,051,694✔
3891

3892
  STR_TO_VARSTR(dName, dbName);
2,051,694✔
3893
  STR_TO_VARSTR(typeName, "SYSTEM_TABLE");
2,051,694✔
3894

3895
  for (int32_t i = 0; i < size; ++i) {
71,807,547✔
3896
    const SSysTableMeta *pm = &pSysDbTableMeta[i];
69,754,110✔
3897
    //    if (pm->sysInfo) {
3898
    //      continue;
3899
    //    }
3900
    if (tbName[0] && strncmp(tbName, pm->name, TSDB_TABLE_NAME_LEN) != 0) {
69,754,691✔
3901
      continue;
×
3902
    }
3903

3904
    STR_TO_VARSTR(tName, pm->name);
69,754,691✔
3905

3906
    for (int32_t j = 0; j < pm->colNum; j++) {
693,304,663✔
3907
      // table name
3908
      SColumnInfoData *pColInfoData = taosArrayGet(p->pDataBlock, 0);
623,538,352✔
3909
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, tName, false), &lino, _OVER);
623,547,648✔
3910

3911
      // database name
3912
      pColInfoData = taosArrayGet(p->pDataBlock, 1);
623,534,285✔
3913
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, dName, false), &lino, _OVER);
622,891,699✔
3914

3915
      pColInfoData = taosArrayGet(p->pDataBlock, 2);
623,572,050✔
3916
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, typeName, false), &lino, _OVER);
623,553,458✔
3917

3918
      // col name
3919
      char colName[TSDB_COL_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
623,520,341✔
3920
      STR_TO_VARSTR(colName, pm->schema[j].name);
623,497,101✔
3921
      pColInfoData = taosArrayGet(p->pDataBlock, 3);
623,529,056✔
3922
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, colName, false), &lino, _OVER);
623,520,341✔
3923

3924
      // col type
3925
      int8_t colType = pm->schema[j].type;
623,535,447✔
3926
      pColInfoData = taosArrayGet(p->pDataBlock, 4);
623,551,134✔
3927
      char colTypeStr[VARSTR_HEADER_SIZE + 32];
623,517,436✔
3928
      int  colTypeLen =
3929
          snprintf(varDataVal(colTypeStr), sizeof(colTypeStr) - VARSTR_HEADER_SIZE, "%s", tDataTypes[colType].name);
623,523,827✔
3930
      if (colType == TSDB_DATA_TYPE_VARCHAR) {
623,527,313✔
3931
        colTypeLen +=
315,912,653✔
3932
            snprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE, "(%d)",
315,912,653✔
3933
                     (int32_t)(pm->schema[j].bytes - VARSTR_HEADER_SIZE));
315,909,748✔
3934
      } else if (colType == TSDB_DATA_TYPE_NCHAR) {
307,617,565✔
3935
        colTypeLen +=
×
3936
            snprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE, "(%d)",
×
3937
                     (int32_t)((pm->schema[j].bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE));
×
3938
      }
3939
      varDataSetLen(colTypeStr, colTypeLen);
623,530,218✔
3940
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, (char *)colTypeStr, false), &lino, _OVER);
623,443,649✔
3941

3942
      // col length
3943
      pColInfoData = taosArrayGet(p->pDataBlock, 5);
623,570,307✔
3944
      TAOS_CHECK_GOTO(colDataSetVal(pColInfoData, numOfRows, (const char *)&pm->schema[j].bytes, false), &lino, _OVER);
623,552,296✔
3945

3946
      // col precision, col scale, col nullable, col source
3947
      for (int32_t k = 6; k <= 10; ++k) {
2,147,483,647✔
3948
        pColInfoData = taosArrayGet(p->pDataBlock, k);
2,147,483,647✔
3949
        colDataSetNULL(pColInfoData, numOfRows);
2,147,483,647✔
3950
      }
3951

3952
      numOfRows += 1;
624,068,805✔
3953
    }
3954
  }
3955
  return numOfRows;
2,053,437✔
3956
_OVER:
×
3957
  mError("failed at %s:%d since %s", __FUNCTION__, lino, tstrerror(code));
×
3958
  return numOfRows;
×
3959
}
3960
#define BUILD_COL_FOR_INFO_DB 1
3961
#define BUILD_COL_FOR_PERF_DB 1 << 1
3962
#define BUILD_COL_FOR_USER_DB 1 << 2
3963
#define BUILD_COL_FOR_ALL_DB  (BUILD_COL_FOR_INFO_DB | BUILD_COL_FOR_PERF_DB | BUILD_COL_FOR_USER_DB)
3964

3965
static int32_t buildSysDbColsInfo(SSDataBlock *p, int8_t buildWhichDBs, char *tb) {
1,080,725✔
3966
  size_t               size = 0;
1,080,725✔
3967
  const SSysTableMeta *pSysDbTableMeta = NULL;
1,081,306✔
3968

3969
  if (buildWhichDBs & BUILD_COL_FOR_INFO_DB) {
1,081,306✔
3970
    getInfosDbMeta(&pSysDbTableMeta, &size);
1,025,266✔
3971
    p->info.rows = buildDbColsInfoBlock(p, pSysDbTableMeta, size, TSDB_INFORMATION_SCHEMA_DB, tb);
1,025,266✔
3972
  }
3973

3974
  if (buildWhichDBs & BUILD_COL_FOR_PERF_DB) {
1,081,887✔
3975
    getPerfDbMeta(&pSysDbTableMeta, &size);
1,025,847✔
3976
    p->info.rows = buildDbColsInfoBlock(p, pSysDbTableMeta, size, TSDB_PERFORMANCE_SCHEMA_DB, tb);
1,025,847✔
3977
  }
3978

3979
  return p->info.rows;
1,081,887✔
3980
}
3981

3982
static int8_t determineBuildColForWhichDBs(const char *db) {
1,085,381✔
3983
  int8_t buildWhichDBs;
3984
  if (!db[0])
1,085,381✔
3985
    buildWhichDBs = BUILD_COL_FOR_ALL_DB;
1,025,653✔
3986
  else {
3987
    char *p = strchr(db, '.');
60,309✔
3988
    if (p && strcmp(p + 1, TSDB_INFORMATION_SCHEMA_DB) == 0) {
60,309✔
3989
      buildWhichDBs = BUILD_COL_FOR_INFO_DB;
194✔
3990
    } else if (p && strcmp(p + 1, TSDB_PERFORMANCE_SCHEMA_DB) == 0) {
60,115✔
3991
      buildWhichDBs = BUILD_COL_FOR_PERF_DB;
194✔
3992
    } else {
3993
      buildWhichDBs = BUILD_COL_FOR_USER_DB;
59,921✔
3994
    }
3995
  }
3996
  return buildWhichDBs;
1,085,962✔
3997
}
3998

3999
static int32_t mndRetrieveStbCol(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
1,085,381✔
4000
  uint8_t  buildWhichDBs;
4001
  SMnode  *pMnode = pReq->info.node;
1,085,381✔
4002
  SSdb    *pSdb = pMnode->pSdb;
1,085,962✔
4003
  SStbObj *pStb = NULL;
1,085,381✔
4004
  int32_t  numOfRows = 0;
1,085,962✔
4005
  int32_t  lino = 0;
1,085,962✔
4006
  int32_t  code = 0;
1,085,381✔
4007

4008
  buildWhichDBs = determineBuildColForWhichDBs(pShow->db);
1,085,381✔
4009

4010
  if (!pShow->sysDbRsp) {
1,085,962✔
4011
    numOfRows = buildSysDbColsInfo(pBlock, buildWhichDBs, pShow->filterTb);
1,081,306✔
4012
    mDebug("mndRetrieveStbCol get system table cols, rows:%d, db:%s", numOfRows, pShow->db);
1,081,306✔
4013
    pShow->sysDbRsp = true;
1,081,306✔
4014
  }
4015

4016
  if (buildWhichDBs & BUILD_COL_FOR_USER_DB) {
1,085,962✔
4017
    SDbObj *pDb = NULL;
1,085,574✔
4018
    if (strlen(pShow->db) > 0) {
1,085,574✔
4019
      pDb = mndAcquireDb(pMnode, pShow->db);
59,921✔
4020
      if (pDb == NULL && TSDB_CODE_MND_DB_NOT_EXIST != terrno && pBlock->info.rows == 0) return terrno;
59,921✔
4021
    }
4022

4023
    char typeName[TSDB_TABLE_FNAME_LEN + VARSTR_HEADER_SIZE] = {0};
1,085,574✔
4024
    STR_TO_VARSTR(typeName, "SUPER_TABLE");
1,085,574✔
4025
    bool fetch = pShow->restore ? false : true;
1,085,574✔
4026
    pShow->restore = false;
1,085,574✔
4027
    while (numOfRows < rows) {
3,296,102✔
4028
      if (fetch) {
3,296,102✔
4029
        pShow->pIter = sdbFetch(pSdb, SDB_STB, pShow->pIter, (void **)&pStb);
3,291,446✔
4030
        if (pShow->pIter == NULL) break;
3,291,446✔
4031
      } else {
4032
        fetch = true;
4,656✔
4033
        void *pKey = taosHashGetKey(pShow->pIter, NULL);
4,656✔
4034
        pStb = sdbAcquire(pSdb, SDB_STB, pKey);
4,656✔
4035
        if (!pStb) continue;
4,656✔
4036
      }
4037

4038
      if (pDb != NULL && pStb->dbUid != pDb->uid) {
2,215,184✔
4039
        sdbRelease(pSdb, pStb);
3,212✔
4040
        continue;
3,212✔
4041
      }
4042

4043
      SName name = {0};
2,211,972✔
4044
      char  stbName[TSDB_TABLE_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
2,211,972✔
4045
      mndExtractTbNameFromStbFullName(pStb->name, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN);
2,211,972✔
4046
      if (pShow->filterTb[0] && strncmp(pShow->filterTb, &stbName[VARSTR_HEADER_SIZE], TSDB_TABLE_NAME_LEN) != 0) {
2,211,972✔
4047
        sdbRelease(pSdb, pStb);
×
4048
        continue;
×
4049
      }
4050

4051
      if ((numOfRows + pStb->numOfColumns) > rows) {
2,211,972✔
4052
        pShow->restore = true;
4,656✔
4053
        if (numOfRows == 0) {
4,656✔
4054
          mError("mndRetrieveStbCol failed to get stable cols since buf:%d less than result:%d, stable name:%s, db:%s",
×
4055
                 rows, pStb->numOfColumns, pStb->name, pStb->db);
4056
        }
4057
        sdbRelease(pSdb, pStb);
4,656✔
4058
        break;
4,656✔
4059
      }
4060

4061
      varDataSetLen(stbName, strlen(&stbName[VARSTR_HEADER_SIZE]));
2,207,316✔
4062

4063
      mDebug("mndRetrieveStbCol get stable cols, stable name:%s, db:%s", pStb->name, pStb->db);
2,207,316✔
4064

4065
      char db[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
2,207,316✔
4066
      RETRIEVE_CHECK_GOTO(tNameFromString(&name, pStb->db, T_NAME_ACCT | T_NAME_DB), pStb, &lino, _OVER);
2,207,316✔
4067
      RETRIEVE_CHECK_GOTO(tNameGetDbName(&name, varDataVal(db)), pStb, &lino, _OVER);
2,207,316✔
4068
      varDataSetLen(db, strlen(varDataVal(db)));
2,207,316✔
4069

4070
      for (int i = 0; i < pStb->numOfColumns; i++) {
40,771,712✔
4071
        int32_t          cols = 0;
38,564,396✔
4072
        SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
38,564,396✔
4073
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)stbName, false), pStb, &lino, _OVER);
38,564,396✔
4074

4075
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
38,564,396✔
4076
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)db, false), pStb, &lino, _OVER);
38,563,815✔
4077

4078
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
38,563,815✔
4079
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, typeName, false), pStb, &lino, _OVER);
38,563,815✔
4080

4081
        // col name
4082
        char colName[TSDB_COL_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
38,564,396✔
4083
        STR_TO_VARSTR(colName, pStb->pColumns[i].name);
38,564,396✔
4084
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
38,564,396✔
4085
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, colName, false), pStb, &lino, _OVER);
38,564,396✔
4086

4087
        // col type
4088
        int8_t colType = pStb->pColumns[i].type;
38,564,396✔
4089
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
38,564,396✔
4090
        char colTypeStr[VARSTR_HEADER_SIZE + 32];
38,564,396✔
4091
        int  colTypeLen =
4092
            snprintf(varDataVal(colTypeStr), sizeof(colTypeStr) - VARSTR_HEADER_SIZE, "%s", tDataTypes[colType].name);
38,564,396✔
4093
        if (colType == TSDB_DATA_TYPE_VARCHAR) {
38,564,396✔
4094
          colTypeLen +=
1,128,258✔
4095
              snprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE,
1,128,258✔
4096
                       "(%d)", (int32_t)(pStb->pColumns[i].bytes - VARSTR_HEADER_SIZE));
1,128,258✔
4097
        } else if (colType == TSDB_DATA_TYPE_NCHAR) {
37,436,138✔
4098
          colTypeLen +=
1,127,820✔
4099
              snprintf(varDataVal(colTypeStr) + colTypeLen, sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE,
1,127,820✔
4100
                       "(%d)", (int32_t)((pStb->pColumns[i].bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE));
1,127,820✔
4101
        } else if (IS_DECIMAL_TYPE(colType)) {
36,308,318✔
4102
          STypeMod typeMod = pStb->pExtSchemas[i].typeMod;
199,663✔
4103
          uint8_t prec = 0, scale = 0;
199,663✔
4104
          decimalFromTypeMod(typeMod, &prec, &scale);
199,663✔
4105
          colTypeLen += snprintf(varDataVal(colTypeStr) + colTypeLen,
199,663✔
4106
                                 sizeof(colTypeStr) - colTypeLen - VARSTR_HEADER_SIZE, "(%d,%d)", prec, scale);
4107
        }
4108
        varDataSetLen(colTypeStr, colTypeLen);
38,564,396✔
4109
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (char *)colTypeStr, false), pStb, &lino, _OVER);
38,564,396✔
4110

4111
        // col length
4112
        pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
38,563,815✔
4113
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->pColumns[i].bytes, false), pStb,
38,563,815✔
4114
                            &lino, _OVER);
4115
        
4116
        // col precision, col scale, col nullable, col source
4117
        for (int32_t j = 6; j <= 9; ++j) {
192,821,980✔
4118
          pColInfo = taosArrayGet(pBlock->pDataBlock, j);
154,257,584✔
4119
          colDataSetNULL(pColInfo, numOfRows);
154,257,584✔
4120
        }
4121

4122
        // col id
4123
        pColInfo = taosArrayGet(pBlock->pDataBlock, 10);
38,564,396✔
4124
        RETRIEVE_CHECK_GOTO(colDataSetVal(pColInfo, numOfRows, (const char *)&pStb->pColumns[i].colId, false), pStb,
38,564,396✔
4125
                            &lino, _OVER);
4126
        numOfRows++;
38,564,396✔
4127
      }
4128

4129
      sdbRelease(pSdb, pStb);
2,207,316✔
4130
    }
4131

4132
    if (pDb != NULL) {
1,085,574✔
4133
      mndReleaseDb(pMnode, pDb);
59,701✔
4134
    }
4135
  }
4136

4137
  mDebug("mndRetrieveStbCol success, rows:%d, pShow->numOfRows:%d", numOfRows, pShow->numOfRows);
1,085,962✔
4138
  goto _OVER;
1,085,962✔
4139

4140
_ERROR:
4141
  mError("failed to mndRetrieveStbCol, rows:%d, pShow->numOfRows:%d, at %s:%d since %s", numOfRows, pShow->numOfRows,
4142
         __FUNCTION__, lino, tstrerror(code));
4143

4144
_OVER:
1,085,962✔
4145
  pShow->numOfRows += numOfRows;
1,085,962✔
4146
  return numOfRows;
1,085,962✔
4147
}
4148

4149
static void mndCancelGetNextStb(SMnode *pMnode, void *pIter) {
194✔
4150
  SSdb *pSdb = pMnode->pSdb;
194✔
4151
  sdbCancelFetchByType(pSdb, pIter, SDB_STB);
194✔
4152
}
194✔
4153

4154
const char *mndGetStbStr(const char *src) {
×
4155
  char *posDb = strstr(src, TS_PATH_DELIMITER);
×
4156
  if (posDb != NULL) ++posDb;
×
4157
  if (posDb == NULL) return src;
×
4158

4159
  char *posStb = strstr(posDb, TS_PATH_DELIMITER);
×
4160
  if (posStb != NULL) ++posStb;
×
4161
  if (posStb == NULL) return posDb;
×
4162
  return posStb;
×
4163
}
4164

4165
static int32_t mndCheckIndexReq(SCreateTagIndexReq *pReq) {
×
4166
  // impl
4167
  return TSDB_CODE_SUCCESS;
×
4168
}
4169

4170
/*int32_t mndAddIndexImpl(SMnode *pMnode, SRpcMsg *pReq, SDbObj *pDb, SStbObj *pStb, bool needRsp, void *sql,
4171
                        int32_t len) {
4172
  // impl later
4173
  int32_t code = 0;
4174
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB_INSIDE, pReq, "create-stb-index");
4175
  if (pTrans == NULL) goto _OVER;
4176

4177
  mInfo("trans:%d, used to add index to stb:%s", pTrans->id, pStb->name);
4178
  mndTransSetDbName(pTrans, pDb->name, pStb->name);
4179
  if (mndTransCheckConflict(pMnode, pTrans) != 0) goto _OVER;
4180

4181
  if (mndSetAlterStbPrepareLogs(pMnode, pTrans, pDb, pStb) != 0) goto _OVER;
4182
  if (mndSetAlterStbCommitLogs(pMnode, pTrans, pDb, pStb) != 0) goto _OVER;
4183
  if (mndSetAlterStbRedoActions2(pMnode, pTrans, pDb, pStb, sql, len) != 0) goto _OVER;
4184
  if (mndTransPrepare(pMnode, pTrans) != 0) goto _OVER;
4185

4186
  return code;
4187

4188
_OVER:
4189
  mndTransDrop(pTrans);
4190
  return code;
4191
}
4192
static int32_t mndAddIndex(SMnode *pMnode, SRpcMsg *pReq, SCreateTagIndexReq *tagIdxReq, SDbObj *pDb, SStbObj *pOld) {
4193
  bool    needRsp = true;
4194
  int32_t code = -1;
4195
  SField *pField0 = NULL;
4196

4197
  SStbObj  stbObj = {0};
4198
  SStbObj *pNew = &stbObj;
4199

4200
  taosRLockLatch(&pOld->lock);
4201
  memcpy(&stbObj, pOld, sizeof(SStbObj));
4202
  taosRUnLockLatch(&pOld->lock);
4203

4204
  stbObj.pColumns = NULL;
4205
  stbObj.pTags = NULL;
4206
  stbObj.updateTime = taosGetTimestampMs();
4207
  stbObj.lock = 0;
4208

4209
  int32_t tag = mndFindSuperTableTagIndex(pOld, tagIdxReq->colName);
4210
  if (tag < 0) {
4211
    terrno = TSDB_CODE_MND_TAG_NOT_EXIST;
4212
    return -1;
4213
  }
4214
  if (mndAllocStbSchemas(pOld, pNew) != 0) {
4215
    return -1;
4216
  }
4217

4218
  SSchema *pTag = pNew->pTags + tag;
4219
  if (IS_IDX_ON(pTag)) {
4220
    terrno = TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST;
4221
    return -1;
4222
  } else {
4223
    pTag->flags |= COL_IDX_ON;
4224
  }
4225
  pNew->tagVer++;
4226

4227
  code = mndAddIndexImpl(pMnode, pReq, pDb, pNew, needRsp, pReq->pCont, pReq->contLen);
4228

4229
  return code;
4230
}
4231
static int32_t mndProcessCreateIndexReq(SRpcMsg *pReq) {
4232
  SMnode            *pMnode = pReq->info.node;
4233
  int32_t            code = -1;
4234
  SDbObj            *pDb = NULL;
4235
  SStbObj           *pStb = NULL;
4236
  SCreateTagIndexReq tagIdxReq = {0};
4237

4238
  if (tDeserializeSCreateTagIdxReq(pReq->pCont, pReq->contLen, &tagIdxReq) != 0) {
4239
    terrno = TSDB_CODE_INVALID_MSG;
4240
    goto _OVER;
4241
  }
4242

4243
  mInfo("stb:%s, start to alter", tagIdxReq.stbName);
4244

4245
  if (mndCheckIndexReq(&tagIdxReq) != TSDB_CODE_SUCCESS) {
4246
    goto _OVER;
4247
  }
4248

4249
  pDb = mndAcquireDbByStb(pMnode, tagIdxReq.dbFName);
4250
  if (pDb == NULL) {
4251
    terrno = TSDB_CODE_MND_DB_NOT_EXIST;
4252
    goto _OVER;
4253
  }
4254

4255
  pStb = mndAcquireStb(pMnode, tagIdxReq.stbName);
4256
  if (pStb == NULL) {
4257
    terrno = TSDB_CODE_MND_STB_NOT_EXIST;
4258
    goto _OVER;
4259
  }
4260
  if (mndCheckDbPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_WRITE_DB, pDb) != 0) {
4261
    goto _OVER;
4262
  }
4263

4264
  code = mndAddIndex(pMnode, pReq, &tagIdxReq, pDb, pStb);
4265
  if (terrno == TSDB_CODE_MND_TAG_INDEX_ALREADY_EXIST || terrno == TSDB_CODE_MND_TAG_NOT_EXIST) {
4266
    return terrno;
4267
  } else {
4268
    if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
4269
  }
4270
_OVER:
4271
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
4272
    mError("stb:%s, failed to create index since %s", tagIdxReq.stbName, terrstr());
4273
  }
4274
  mndReleaseStb(pMnode, pStb);
4275
  mndReleaseDb(pMnode, pDb);
4276
  return code;
4277
}
4278
static int32_t mndProcessDropIndexReq(SRpcMsg *pReq) {
4279
  SMnode          *pMnode = pReq->info.node;
4280
  int32_t          code = -1;
4281
  SDbObj          *pDb = NULL;
4282
  SStbObj         *pStb = NULL;
4283
  SDropTagIndexReq dropReq = {0};
4284
  if (tDeserializeSDropTagIdxReq(pReq->pCont, pReq->contLen, &dropReq) != 0) {
4285
    terrno = TSDB_CODE_INVALID_MSG;
4286
    goto _OVER;
4287
  }
4288
  //
4289
  return TSDB_CODE_SUCCESS;
4290
_OVER:
4291
  return code;
4292
}*/
4293

4294
static int32_t mndProcessDropStbReqFromMNode(SRpcMsg *pReq) {
3,067✔
4295
  int32_t code = mndProcessDropStbReq(pReq);
3,067✔
4296
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
3,067✔
4297
    pReq->info.rsp = rpcMallocCont(1);
×
4298
    pReq->info.rspLen = 1;
×
4299
    pReq->info.noResp = false;
×
4300
    pReq->code = code;
×
4301
  }
4302
  return code;
3,067✔
4303
}
4304

4305
typedef struct SVDropTbVgReqs {
4306
  SArray     *pBatchReqs;
4307
  SVgroupInfo info;
4308
} SVDropTbVgReqs;
4309

4310
typedef struct SMDropTbDbInfo {
4311
  SArray *dbVgInfos;
4312
  int32_t hashPrefix;
4313
  int32_t hashSuffix;
4314
  int32_t hashMethod;
4315
} SMDropTbDbInfo;
4316

4317
typedef struct SMDropTbTsmaInfo {
4318
  char           tsmaResTbDbFName[TSDB_DB_FNAME_LEN];
4319
  char           tsmaResTbNamePrefix[TSDB_TABLE_FNAME_LEN];
4320
  int32_t        suid;
4321
  SMDropTbDbInfo dbInfo;  // reference to DbInfo in pDbMap
4322
} SMDropTbTsmaInfo;
4323

4324
typedef struct SMDropTbTsmaInfos {
4325
  SArray *pTsmaInfos;  // SMDropTbTsmaInfo
4326
} SMDropTbTsmaInfos;
4327

4328
typedef struct SMndDropTbsWithTsmaCtx {
4329
  SHashObj *pVgMap;  // <vgId, SVDropTbVgReqs>
4330
} SMndDropTbsWithTsmaCtx;
4331

4332
static int32_t mndDropTbForSingleVg(SMnode *pMnode, SMndDropTbsWithTsmaCtx *pCtx, SArray *pTbs, int32_t vgId);
4333

4334
static void destroySVDropTbBatchReqs(void *p);
4335
static void mndDestroyDropTbsWithTsmaCtx(SMndDropTbsWithTsmaCtx *p) {
13,284✔
4336
  if (!p) return;
13,284✔
4337

4338
  if (p->pVgMap) {
13,284✔
4339
    void *pIter = taosHashIterate(p->pVgMap, NULL);
13,284✔
4340
    while (pIter) {
26,568✔
4341
      SVDropTbVgReqs *pReqs = pIter;
13,284✔
4342
      taosArrayDestroyEx(pReqs->pBatchReqs, destroySVDropTbBatchReqs);
13,284✔
4343
      pIter = taosHashIterate(p->pVgMap, pIter);
13,284✔
4344
    }
4345
    taosHashCleanup(p->pVgMap);
13,284✔
4346
  }
4347
  taosMemoryFree(p);
13,284✔
4348
}
4349

4350
static int32_t mndInitDropTbsWithTsmaCtx(SMndDropTbsWithTsmaCtx **ppCtx) {
13,284✔
4351
  int32_t                 code = 0;
13,284✔
4352
  SMndDropTbsWithTsmaCtx *pCtx = taosMemoryCalloc(1, sizeof(SMndDropTbsWithTsmaCtx));
13,284✔
4353
  if (!pCtx) return terrno;
13,284✔
4354

4355
  pCtx->pVgMap = taosHashInit(4, taosGetDefaultHashFunction(TSDB_DATA_TYPE_INT), false, HASH_NO_LOCK);
13,284✔
4356
  if (!pCtx->pVgMap) {
13,284✔
4357
    code = terrno;
×
4358
    goto _end;
×
4359
  }
4360

4361
  *ppCtx = pCtx;
13,284✔
4362
_end:
13,284✔
4363
  if (code) mndDestroyDropTbsWithTsmaCtx(pCtx);
13,284✔
4364
  return code;
13,284✔
4365
}
4366

4367
static void *mndBuildVDropTbsReq(SMnode *pMnode, const SVgroupInfo *pVgInfo, const SVDropTbBatchReq *pReq,
38,436✔
4368
                                 int32_t *len) {
4369
  int32_t   contLen = 0;
38,436✔
4370
  int32_t   ret = 0;
38,436✔
4371
  SMsgHead *pHead = NULL;
38,436✔
4372
  SEncoder  encoder = {0};
38,436✔
4373

4374
  tEncodeSize(tEncodeSVDropTbBatchReq, pReq, contLen, ret);
38,436✔
4375
  if (ret < 0) return NULL;
38,436✔
4376

4377
  contLen += sizeof(SMsgHead);
38,436✔
4378
  pHead = taosMemoryMalloc(contLen);
38,436✔
4379
  if (pHead == NULL) {
38,436✔
4380
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
4381
    return NULL;
×
4382
  }
4383

4384
  pHead->contLen = htonl(contLen);
38,436✔
4385
  pHead->vgId = htonl(pVgInfo->vgId);
38,436✔
4386

4387
  void *pBuf = POINTER_SHIFT(pHead, sizeof(SMsgHead));
38,436✔
4388

4389
  tEncoderInit(&encoder, pBuf, contLen - sizeof(SMsgHead));
38,436✔
4390
  int32_t code = tEncodeSVDropTbBatchReq(&encoder, pReq);
38,436✔
4391
  tEncoderClear(&encoder);
38,436✔
4392
  if (code != 0) return NULL;
38,436✔
4393

4394
  *len = contLen;
38,436✔
4395
  return pHead;
38,436✔
4396
}
4397

4398
static int32_t mndSetDropTbsRedoActions(SMnode *pMnode, STrans *pTrans, const SVDropTbVgReqs *pVgReqs, void *pCont,
38,436✔
4399
                                        int32_t contLen, tmsg_t msgType) {
4400
  STransAction action = {0};
38,436✔
4401
  action.epSet = pVgReqs->info.epSet;
38,436✔
4402
  action.pCont = pCont;
38,436✔
4403
  action.contLen = contLen;
38,436✔
4404
  action.msgType = msgType;
38,436✔
4405
  action.acceptableCode = TSDB_CODE_TDB_TABLE_NOT_EXIST;
38,436✔
4406
  return mndTransAppendRedoAction(pTrans, &action);
38,436✔
4407
}
4408

4409
static int32_t mndBuildDropTbRedoActions(SMnode *pMnode, STrans *pTrans, SHashObj *pVgMap, tmsg_t msgType) {
9,609✔
4410
  int32_t code = 0;
9,609✔
4411
  void   *pIter = taosHashIterate(pVgMap, NULL);
9,609✔
4412
  while (pIter) {
19,218✔
4413
    const SVDropTbVgReqs *pVgReqs = pIter;
9,609✔
4414
    int32_t               len = 0;
9,609✔
4415
    for (int32_t i = 0; i < taosArrayGetSize(pVgReqs->pBatchReqs) && code == TSDB_CODE_SUCCESS; ++i) {
48,045✔
4416
      SVDropTbBatchReq *pBatchReq = taosArrayGet(pVgReqs->pBatchReqs, i);
38,436✔
4417
      void             *p = mndBuildVDropTbsReq(pMnode, &pVgReqs->info, pBatchReq, &len);
38,436✔
4418
      if (!p) {
38,436✔
4419
        code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
4420
        if (terrno != 0) code = terrno;
×
4421
        break;
×
4422
      }
4423
      if ((code = mndSetDropTbsRedoActions(pMnode, pTrans, pVgReqs, p, len, msgType)) != 0) {
38,436✔
4424
        break;
×
4425
      }
4426
    }
4427
    if (TSDB_CODE_SUCCESS != code) {
9,609✔
4428
      taosHashCancelIterate(pVgMap, pIter);
×
4429
      break;
×
4430
    }
4431
    pIter = taosHashIterate(pVgMap, pIter);
9,609✔
4432
  }
4433
  return code;
9,609✔
4434
}
4435

4436
static int32_t mndCreateDropTbsTxnPrepare(SRpcMsg *pRsp, SMndDropTbsWithTsmaCtx *pCtx) {
13,284✔
4437
  int32_t code = 0;
13,284✔
4438
  SMnode *pMnode = pRsp->info.node;
13,284✔
4439
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_GLOBAL, pRsp, "drop-tbs");
13,284✔
4440
  mndTransSetChangeless(pTrans);
13,284✔
4441
  mndTransSetSerial(pTrans);
13,284✔
4442
  if (pTrans == NULL) {
13,284✔
4443
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
4444
    if (terrno != 0) code = terrno;
×
4445
    goto _OVER;
×
4446
  }
4447

4448
  TAOS_CHECK_GOTO(mndTransCheckConflict(pMnode, pTrans), NULL, _OVER);
13,284✔
4449

4450
  if ((code = mndBuildDropTbRedoActions(pMnode, pTrans, pCtx->pVgMap, TDMT_VND_DROP_TABLE)) != 0) goto _OVER;
9,609✔
4451
  if ((code = mndTransPrepare(pMnode, pTrans)) != 0) goto _OVER;
9,609✔
4452

4453
_OVER:
9,609✔
4454
  mndTransDrop(pTrans);
13,284✔
4455
  TAOS_RETURN(code);
13,284✔
4456
}
4457

4458
static int32_t mndProcessDropTbWithTsma(SRpcMsg *pReq) {
×
4459
  int32_t      code = -1;
×
4460
  SMnode      *pMnode = pReq->info.node;
×
4461
  SDbObj      *pDb = NULL;
×
4462
  SStbObj     *pStb = NULL;
×
4463
  SMDropTbsReq dropReq = {0};
×
4464
  bool         locked = false;
×
4465
  if (tDeserializeSMDropTbsReq(pReq->pCont, pReq->contLen, &dropReq) != 0) {
×
4466
    code = TSDB_CODE_INVALID_MSG;
×
4467
    goto _OVER;
×
4468
  }
4469

4470
  SMndDropTbsWithTsmaCtx *pCtx = NULL;
×
4471
  code = mndInitDropTbsWithTsmaCtx(&pCtx);
×
4472
  if (code) goto _OVER;
×
4473
  for (int32_t i = 0; i < dropReq.pVgReqs->size; ++i) {
×
4474
    SMDropTbReqsOnSingleVg *pReq = taosArrayGet(dropReq.pVgReqs, i);
×
4475
    code = mndDropTbForSingleVg(pMnode, pCtx, pReq->pTbs, pReq->vgInfo.vgId);
×
4476
    if (code) goto _OVER;
×
4477
  }
4478
  code = mndCreateDropTbsTxnPrepare(pReq, pCtx);
×
4479
  if (code == 0) {
×
4480
    code = TSDB_CODE_ACTION_IN_PROGRESS;
×
4481
  }
4482
_OVER:
×
4483
  tFreeSMDropTbsReq(&dropReq);
×
4484
  if (pCtx) mndDestroyDropTbsWithTsmaCtx(pCtx);
×
4485
  TAOS_RETURN(code);
×
4486
}
4487

4488
static int32_t createDropTbBatchReq(const SVDropTbReq *pReq, SVDropTbBatchReq *pBatchReq) {
54,606✔
4489
  pBatchReq->nReqs = 1;
54,606✔
4490
  pBatchReq->pArray = taosArrayInit(TARRAY_MIN_SIZE, sizeof(SVDropTbReq));
54,606✔
4491
  if (!pBatchReq->pArray) return terrno;
54,606✔
4492
  if (taosArrayPush(pBatchReq->pArray, pReq) == NULL) {
109,212✔
4493
    taosArrayDestroy(pBatchReq->pArray);
×
4494
    pBatchReq->pArray = NULL;
×
4495
    return terrno;
×
4496
  }
4497
  return TSDB_CODE_SUCCESS;
54,606✔
4498
}
4499

4500
static void destroySVDropTbBatchReqs(void *p) {
54,606✔
4501
  SVDropTbBatchReq *pReq = p;
54,606✔
4502
  taosArrayDestroy(pReq->pArray);
54,606✔
4503
  pReq->pArray = NULL;
54,606✔
4504
}
54,606✔
4505

4506
static int32_t mndDropTbAdd(SMnode *pMnode, SHashObj *pVgHashMap, const SVgroupInfo *pVgInfo, char *name, tb_uid_t suid,
54,606✔
4507
                            bool ignoreNotExists) {
4508
  SVDropTbReq req = {.name = name, .suid = suid, .igNotExists = ignoreNotExists, .uid = 0};
54,606✔
4509

4510
  SVDropTbVgReqs *pVgReqs = taosHashGet(pVgHashMap, &pVgInfo->vgId, sizeof(pVgInfo->vgId));
54,606✔
4511
  SVDropTbVgReqs  vgReqs = {0};
54,606✔
4512
  if (pVgReqs == NULL) {
54,606✔
4513
    vgReqs.info = *pVgInfo;
13,284✔
4514
    vgReqs.pBatchReqs = taosArrayInit(TARRAY_MIN_SIZE, sizeof(SVDropTbBatchReq));
13,284✔
4515
    if (!vgReqs.pBatchReqs) return terrno;
13,284✔
4516
    SVDropTbBatchReq batchReq = {0};
13,284✔
4517
    int32_t          code = createDropTbBatchReq(&req, &batchReq);
13,284✔
4518
    if (TSDB_CODE_SUCCESS != code) return code;
13,284✔
4519
    if (taosArrayPush(vgReqs.pBatchReqs, &batchReq) == NULL) {
26,568✔
4520
      taosArrayDestroy(batchReq.pArray);
×
4521
      return terrno;
×
4522
    }
4523
    if (taosHashPut(pVgHashMap, &pVgInfo->vgId, sizeof(pVgInfo->vgId), &vgReqs, sizeof(vgReqs)) != 0) {
13,284✔
4524
      taosArrayDestroyEx(vgReqs.pBatchReqs, destroySVDropTbBatchReqs);
×
4525
      return terrno;
×
4526
    }
4527
  } else {
4528
    SVDropTbBatchReq batchReq = {0};
41,322✔
4529
    int32_t          code = createDropTbBatchReq(&req, &batchReq);
41,322✔
4530
    if (TSDB_CODE_SUCCESS != code) return code;
41,322✔
4531
    if (taosArrayPush(pVgReqs->pBatchReqs, &batchReq) == NULL) {
82,644✔
4532
      taosArrayDestroy(batchReq.pArray);
×
4533
      return terrno;
×
4534
    }
4535
  }
4536
  return 0;
54,606✔
4537
}
4538

4539
static int32_t mndDropTbForSingleVg(SMnode *pMnode, SMndDropTbsWithTsmaCtx *pCtx, SArray *pTbs, int32_t vgId) {
13,284✔
4540
  int32_t code = 0;
13,284✔
4541

4542
  SVgObj *pVgObj = mndAcquireVgroup(pMnode, vgId);
13,284✔
4543
  if (!pVgObj) {
13,284✔
4544
    code = 0;
×
4545
    goto _end;
×
4546
  }
4547
  SVgroupInfo vgInfo = {.hashBegin = pVgObj->hashBegin,
26,568✔
4548
                        .hashEnd = pVgObj->hashEnd,
13,284✔
4549
                        .numOfTable = pVgObj->numOfTables,
13,284✔
4550
                        .vgId = pVgObj->vgId};
13,284✔
4551
  vgInfo.epSet = mndGetVgroupEpset(pMnode, pVgObj);
13,284✔
4552
  mndReleaseVgroup(pMnode, pVgObj);
13,284✔
4553

4554
  for (int32_t i = 0; i < pTbs->size; ++i) {
67,890✔
4555
    SVDropTbReq *pTb = taosArrayGet(pTbs, i);
54,606✔
4556
    TAOS_CHECK_GOTO(mndDropTbAdd(pMnode, pCtx->pVgMap, &vgInfo, pTb->name, pTb->suid, pTb->igNotExists), NULL, _end);
54,606✔
4557
  }
4558
_end:
13,284✔
4559
  return code;
13,284✔
4560
}
4561

4562
static int32_t mndProcessFetchTtlExpiredTbs(SRpcMsg *pRsp) {
14,767,776✔
4563
  int32_t                 code = -1;
14,767,776✔
4564
  SDecoder                decoder = {0};
14,767,776✔
4565
  SMnode                 *pMnode = pRsp->info.node;
14,767,776✔
4566
  SVFetchTtlExpiredTbsRsp rsp = {0};
14,767,776✔
4567
  SMndDropTbsWithTsmaCtx *pCtx = NULL;
14,767,776✔
4568
  if (pRsp->code != TSDB_CODE_SUCCESS) {
14,767,776✔
4569
    code = pRsp->code;
142,823✔
4570
    goto _end;
142,823✔
4571
  }
4572
  if (pRsp->contLen == 0) {
14,624,953✔
4573
    code = 0;
14,611,669✔
4574
    goto _end;
14,611,669✔
4575
  }
4576

4577
  tDecoderInit(&decoder, pRsp->pCont, pRsp->contLen);
13,284✔
4578
  code = tDecodeVFetchTtlExpiredTbsRsp(&decoder, &rsp);
13,284✔
4579
  if (code) goto _end;
13,284✔
4580

4581
  code = mndInitDropTbsWithTsmaCtx(&pCtx);
13,284✔
4582
  if (code) goto _end;
13,284✔
4583

4584
  code = mndDropTbForSingleVg(pMnode, pCtx, rsp.pExpiredTbs, rsp.vgId);
13,284✔
4585
  if (code) goto _end;
13,284✔
4586
  code = mndCreateDropTbsTxnPrepare(pRsp, pCtx);
13,284✔
4587
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
13,284✔
4588
_end:
14,766,805✔
4589
  if (pCtx) mndDestroyDropTbsWithTsmaCtx(pCtx);
14,767,776✔
4590
  tDecoderClear(&decoder);
14,767,776✔
4591
  tFreeFetchTtlExpiredTbsRsp(&rsp);
14,767,776✔
4592
  TAOS_RETURN(code);
14,767,776✔
4593
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc