aelassas / servy / 25984133313

push

github

fix(service): Service.cs - dead health check timer disposal in Cleanup() finally block (already disposed in ExecuteTeardown)
fix(core): Helper.WriteFileAtomic / WriteFileAtomicCore — duplicated 'retries = 3' and '100ms backoff' magic numbers across sync and async
fix(service): ConsoleAppDetector.cs - generic 'catch { return false }' silently swallows IO/Access errors with no telemetry
fix(core): AppConfig.ResolveExe — XML doc claims it throws FileNotFoundException but the implementation never throws
fix(core): AppConfig.AllowLegacyV1Decryption — documented as a runtime migration toggle but is a static-readonly hard-coded false (no runtime override)
fix(service): Service.cs HandleStopResult — XML doc and 'canceled' wording mismatch the underlying TryStopGracefullyOrKill semantics
fix(core): ProtectedKeyProvider.GetOrGenerate - inconsistent retry backoff between IOException (exponential) and UnauthorizedAccessException (fixed 100ms)
fix(service): Service.cs OnCustomCommand fallback - logs 'Pre-Shutdown handling complete' BEFORE ExecuteTeardown actually runs
fix(desktop,manager): AppBootstrapper.OnExit - 'TryDispose' helper is misused for a Cancel() call (misleading name)

1186 of 2143 branches covered (55.34%)

Branch coverage included in aggregate %.

13 of 31 new or added lines in 6 files covered. (41.94%)

8447 of 16726 relevant lines covered (50.5%)

385.52 hits per line