aelassas / servy / 25958446827

push

github

fix(core): ValidationResult.IsValid - contradicts its own XML doc: returns false on any Warning even though docs state warnings 'may not block the operation' (#1664)
fix(core): ServiceDtoHelper.ApplyDefaults - name and XML doc hide that RunAsLocalSystem/UserAccount/Password are unconditionally overwritten (hidden side-effect) (#1663)
fix(core): HandleHelper.GetProcessesUsingFile - inline magic 2000ms drain timeout inconsistent with AppConfig.HandleExeTimeoutMs/HandleExeRegexTimeout used in the same method (#1662)
fix(infra): SQLiteDbInitializer.ReconcileSchema - XML doc summary and <param> blocks duplicated verbatim (two identical doc blocks above one method) (#1661)
fix(core): ResourceHelper.CopyEmbeddedResource - currentResourceName / currentTargetPath locals assigned but never read (dead variables) (#1660)
fix(core): ProcessKiller.KillParentProcesses - hardcoded '2' for PID-reuse tolerance instead of AppConfig.PidReuseToleranceSeconds (inconsistent with line 122 in same file) (#1659)

1172 of 2142 branches covered (54.72%)

Branch coverage included in aggregate %.

4 of 6 new or added lines in 6 files covered. (66.67%)

8293 of 16506 relevant lines covered (50.24%)

442.74 hits per line