• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #5050

12 May 2026 05:36AM UTC coverage: 73.398% (+0.09%) from 73.313%
#5050

push

travis-ci

web-flow
merge: from main to 3.0 branch #35319

90 of 101 new or added lines in 2 files covered. (89.11%)

489 existing lines in 125 files now uncovered.

281602 of 383662 relevant lines covered (73.4%)

138099127.08 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

82.83
/source/libs/executor/src/filloperator.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "filter.h"
17
#include "os.h"
18
#include "query.h"
19
#include "taosdef.h"
20
#include "taoserror.h"
21
#include "tmsg.h"
22
#include "ttypes.h"
23

24
#include "executorInt.h"
25
#include "tcommon.h"
26
#include "thash.h"
27
#include "ttime.h"
28

29
#include "function.h"
30
#include "operator.h"
31
#include "querynodes.h"
32
#include "querytask.h"
33
#include "tdatablock.h"
34
#include "tfill.h"
35

36
typedef struct STimeRange {
37
  TSKEY    skey;
38
  TSKEY    ekey;
39
  uint64_t groupId;
40
} STimeRange;
41

42
typedef struct SFillOperatorInfo {
43
  struct SFillInfo* pFillInfo;
44
  SSDataBlock*      pRes;
45
  SSDataBlock*      pFinalRes;
46
  int64_t           totalInputRows;
47
  void**            p;
48
  SSDataBlock*      existNewGroupBlock;
49
  STimeWindow       win;
50
  SColMatchInfo     matchInfo;
51
  int32_t           primaryTsCol;
52
  int32_t           primarySrcSlotId;
53
  uint64_t          curGroupId;  // current handled group id
54
  SExprInfo*        pExprInfo;
55
  int32_t           numOfExpr;
56
  SExprSupp         noFillExprSupp;
57
  SExprSupp         fillNullExprSupp;
58
  SList*            pFillSavedBlockList;
59
  SNode*            pTimeRange;  // STimeRangeNode for stream fill
60
} SFillOperatorInfo;
61

62
static void destroyFillOperatorInfo(void* param);
63
static void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag);
64
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo);
65
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order);
66

67
static void doHandleRemainBlockForNewGroupImpl(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
449,473✔
68
                                               SResultInfo* pResultInfo, int32_t order) {
69
  pInfo->totalInputRows = pInfo->existNewGroupBlock->info.rows;
449,473✔
70
  SSDataBlock*   pResBlock = pInfo->pFinalRes;
449,473✔
71
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
449,473✔
72

73
  //  int32_t order = TSDB_ORDER_ASC;
74
  int32_t scanFlag = MAIN_SCAN;
449,473✔
75
  //  getTableScanInfo(pOperator, &order, &scanFlag, false);
76
  taosResetFillInfo(pInfo->pFillInfo, getFillInfoStart(pInfo->pFillInfo));
449,473✔
77

78
  blockDataCleanup(pInfo->pRes);
449,473✔
79
  doApplyScalarCalculation(pOperator, pInfo->existNewGroupBlock, order, scanFlag);
449,473✔
80

81
  reviseFillStartAndEndKey(pOperator->info, order);
449,473✔
82

83
  int64_t ts = (order == TSDB_ORDER_ASC) ? pInfo->existNewGroupBlock->info.window.ekey
449,473✔
84
                                         : pInfo->existNewGroupBlock->info.window.skey;
898,946✔
85
  taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
449,473✔
86

87
  taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
449,473✔
88
  if (pInfo->pFillInfo->type == TSDB_FILL_PREV || pInfo->pFillInfo->type == TSDB_FILL_LINEAR) {
449,473✔
89
    int32_t code = fillResetPrevForNewGroup(pInfo->pFillInfo);
129,911✔
90
    if (code != TSDB_CODE_SUCCESS) {
129,911✔
91
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
92
      T_LONG_JMP(pTaskInfo->env, code);
×
93
    }
94
  }
95

96
  int32_t numOfResultRows = pResultInfo->capacity - pResBlock->info.rows;
449,473✔
97
  int32_t code = taosFillResultDataBlock(pInfo->pFillInfo, pResBlock, numOfResultRows, NULL);
449,473✔
98
  if (code != TSDB_CODE_SUCCESS) {
449,473✔
99
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
100
    T_LONG_JMP(pTaskInfo->env, code);
×
101
  }
102

103
  pInfo->curGroupId = pInfo->existNewGroupBlock->info.id.groupId;
449,473✔
104
  pInfo->existNewGroupBlock = NULL;
449,473✔
105
}
449,473✔
106

107
static void doHandleRemainBlockFromNewGroup(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
2,347,239✔
108
                                            SResultInfo* pResultInfo, int32_t order) {
109
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
2,347,239✔
110
  if (taosFillHasMoreResults(pInfo->pFillInfo)) {
2,347,239✔
111
    int32_t numOfResultRows = pResultInfo->capacity - pInfo->pFinalRes->info.rows;
807,596✔
112
    int32_t code = taosFillResultDataBlock(pInfo->pFillInfo, pInfo->pFinalRes, numOfResultRows, NULL);
807,596✔
113
    if (code != TSDB_CODE_SUCCESS) {
807,596✔
114
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
115
      T_LONG_JMP(pTaskInfo->env, code);
×
116
    }
117
    pInfo->pRes->info.id.groupId = pInfo->curGroupId;
807,596✔
118
    return;
807,596✔
119
  }
120

121
  // handle the cached new group data block
122
  if (pInfo->existNewGroupBlock) {
1,538,737✔
123
    doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
449,473✔
124
  }
125
}
126

127
void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag) {
2,108,937✔
128
  int32_t            code = TSDB_CODE_SUCCESS;
2,108,937✔
129
  int32_t            lino = 0;
2,108,937✔
130
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
2,108,937✔
131
  SFillOperatorInfo* pInfo = pOperator->info;
2,108,937✔
132
  SExprSupp*         pSup = &pOperator->exprSupp;
2,108,937✔
133
  code = setInputDataBlock(pSup, pBlock, order, scanFlag, false);
2,108,937✔
134
  QUERY_CHECK_CODE(code, lino, _end);
2,108,937✔
135
  code = projectApplyFunctions(pSup->pExprInfo, pInfo->pRes, pBlock, pSup->pCtx, pSup->numOfExprs, NULL, GET_STM_RTINFO(pOperator->pTaskInfo), pOperator->pTaskInfo);
2,108,937✔
136
  QUERY_CHECK_CODE(code, lino, _end);
2,108,937✔
137

138
  // reset the row value before applying the no-fill functions to the input data block, which is "pBlock" in this case.
139
  pInfo->pRes->info.rows = 0;
2,108,937✔
140
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
2,108,937✔
141
  code = setInputDataBlock(pNoFillSupp, pBlock, order, scanFlag, false);
2,108,937✔
142
  QUERY_CHECK_CODE(code, lino, _end);
2,108,937✔
143

144
  code = projectApplyFunctions(pNoFillSupp->pExprInfo, pInfo->pRes, pBlock, pNoFillSupp->pCtx, pNoFillSupp->numOfExprs,
4,217,874✔
145
                               NULL, GET_STM_RTINFO(pOperator->pTaskInfo), pOperator->pTaskInfo);
2,108,937✔
146
  QUERY_CHECK_CODE(code, lino, _end);
2,108,937✔
147

148
  if (pInfo->fillNullExprSupp.pExprInfo) {
2,108,937✔
149
    pInfo->pRes->info.rows = 0;
122,941✔
150
    code = setInputDataBlock(&pInfo->fillNullExprSupp, pBlock, order, scanFlag, false);
122,941✔
151
    QUERY_CHECK_CODE(code, lino, _end);
122,941✔
152
    code = projectApplyFunctions(pInfo->fillNullExprSupp.pExprInfo, pInfo->pRes, pBlock, pInfo->fillNullExprSupp.pCtx,
245,882✔
153
        pInfo->fillNullExprSupp.numOfExprs, NULL, GET_STM_RTINFO(pOperator->pTaskInfo), pOperator->pTaskInfo);
122,941✔
154
  }
155

156
  pInfo->pRes->info.id.groupId = pBlock->info.id.groupId;
2,108,937✔
157

158
_end:
2,108,937✔
159
  if (code != TSDB_CODE_SUCCESS) {
2,108,937✔
160
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
161
    T_LONG_JMP(pTaskInfo->env, code);
×
162
  }
163
}
2,108,937✔
164

165
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo) {
129,911✔
166
  int32_t code = TSDB_CODE_SUCCESS;
129,911✔
167
  int32_t lino = 0;
129,911✔
168
  for (int32_t colIdx = 0; colIdx < pFillInfo->numOfCols; ++colIdx) {
1,046,497✔
169
    if (!pFillInfo->pFillCol[colIdx].notFillCol) {
916,586✔
170
      SGroupKeys* key = taosArrayGet(pFillInfo->prev.pRowVal, colIdx);
663,741✔
171
      QUERY_CHECK_NULL(key, code, lino, _end, terrno);
663,741✔
172
      key->isNull = true;
663,741✔
173
    }
174
  }
175

176
_end:
129,911✔
177
  if (code != TSDB_CODE_SUCCESS) {
129,911✔
178
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
179
  }
180
  return code;
129,911✔
181
}
182

183
static SSDataBlock* doFillImpl(SOperatorInfo* pOperator) {
2,347,239✔
184
  int32_t            code = TSDB_CODE_SUCCESS;
2,347,239✔
185
  int32_t            lino = 0;
2,347,239✔
186
  SFillOperatorInfo* pInfo = pOperator->info;
2,347,239✔
187
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
2,347,239✔
188
  if (pInfo == NULL || pTaskInfo == NULL) {
2,347,239✔
189
    qError("%s failed at line %d since pInfo or pTaskInfo is NULL.", __func__, __LINE__);
×
190
    return NULL;
×
191
  }
192

193
  SResultInfo* pResultInfo = &pOperator->resultInfo;
2,347,239✔
194
  SSDataBlock* pResBlock = pInfo->pFinalRes;
2,347,239✔
195
  if (pResBlock == NULL) {
2,346,791✔
196
    qError("%s failed at line %d since pResBlock is NULL.", __func__, __LINE__);
×
197
    return NULL;
×
198
  }
199
  blockDataCleanup(pResBlock);
2,346,791✔
200
  int32_t        order = pInfo->pFillInfo->order;
2,347,239✔
201

202
  doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
2,347,239✔
203
  if (pResBlock->info.rows > 0) {
2,346,791✔
204
    pResBlock->info.id.groupId = pInfo->curGroupId;
530,826✔
205
    return pResBlock;
530,826✔
206
  }
207

208
  while (1) {
912,292✔
209
    SSDataBlock* pBlock = getNextBlockFromDownstream(pOperator, 0);
2,728,257✔
210
    if (pBlock == NULL) {
2,728,223✔
211
      if (pInfo->totalInputRows == 0 &&
1,068,759✔
212
          (pInfo->pFillInfo->type != TSDB_FILL_NULL_F && pInfo->pFillInfo->type != TSDB_FILL_SET_VALUE_F)) {
201,809✔
213
        setOperatorCompleted(pOperator);
142,541✔
214
        return NULL;
142,541✔
215
      } else if (pInfo->totalInputRows == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
926,218✔
216
        reviseFillStartAndEndKey(pInfo, order);
29,634✔
217
      }
218

219
      taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
926,218✔
220
    } else {
221
      pResBlock->info.scanFlag = pBlock->info.scanFlag;
1,659,464✔
222
      pBlock->info.dataLoad = 1;
1,659,464✔
223
      code = blockDataUpdateTsWindow(pBlock, pInfo->primarySrcSlotId);
1,659,464✔
224
      QUERY_CHECK_CODE(code, lino, _end);
1,659,464✔
225

226
      blockDataCleanup(pInfo->pRes);
1,659,464✔
227
      code = blockDataEnsureCapacity(pInfo->pRes, pBlock->info.rows);
1,659,464✔
228
      QUERY_CHECK_CODE(code, lino, _end);
1,659,464✔
229
      code = blockDataEnsureCapacity(pInfo->pFinalRes, pBlock->info.rows);
1,659,464✔
230
      QUERY_CHECK_CODE(code, lino, _end);
1,659,464✔
231
      doApplyScalarCalculation(pOperator, pBlock, order, pBlock->info.scanFlag);
1,659,464✔
232

233
      if (pInfo->curGroupId == 0 || (pInfo->curGroupId == pInfo->pRes->info.id.groupId)) {
2,869,455✔
234
        if (pInfo->curGroupId == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
1,209,991✔
235
          reviseFillStartAndEndKey(pInfo, order);
496,205✔
236
        }
237

238
        pInfo->curGroupId = pInfo->pRes->info.id.groupId;  // the first data block
1,209,555✔
239
        pInfo->totalInputRows += pInfo->pRes->info.rows;
1,209,991✔
240

241
        int64_t ts = (order == TSDB_ORDER_ASC) ? pBlock->info.window.ekey : pBlock->info.window.skey;
1,209,991✔
242
        taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
1,209,991✔
243
        taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
1,209,991✔
244
      } else if (pInfo->curGroupId != pBlock->info.id.groupId) {  // the new group data block
449,473✔
245
        pInfo->existNewGroupBlock = pBlock;
449,473✔
246

247
        // Fill the previous group data block, before handle the data block of new group.
248
        // Close the fill operation for previous group data block
249
        taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
449,473✔
250
      }
251
    }
252

253
    int32_t numOfResultRows = pOperator->resultInfo.capacity - pResBlock->info.rows;
2,585,682✔
254
    bool wantMoreBlock = false;
2,585,682✔
255
    code = taosFillResultDataBlock(pInfo->pFillInfo, pResBlock, numOfResultRows, &wantMoreBlock);
2,585,682✔
256
    QUERY_CHECK_CODE(code, lino, _end);
2,585,682✔
257

258
    // current group has no more result to return
259
    if (pResBlock->info.rows > 0) {
2,585,682✔
260
      // 1. The result in current group not reach the threshold of output result, continue
261
      // 2. If multiple group results existing in one SSDataBlock is not allowed, return immediately
262
      if (pResBlock->info.rows > pResultInfo->threshold || pBlock == NULL || pInfo->existNewGroupBlock != NULL) {
1,214,922✔
263
        pResBlock->info.id.groupId = pInfo->curGroupId;
1,214,922✔
264
        return pResBlock;
1,214,922✔
265
      }
266

267
      doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
×
268
      if (pResBlock->info.rows >= pOperator->resultInfo.threshold || pBlock == NULL) {
×
269
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
270
        return pResBlock;
×
271
      }
272
    } else if (pInfo->existNewGroupBlock) {  // try next group
1,370,760✔
273
      blockDataCleanup(pResBlock);
×
274

275
      doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
×
276
      if (pResBlock->info.rows > pResultInfo->threshold) {
×
277
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
278
        return pResBlock;
×
279
      }
280
    } else {
281
      if (wantMoreBlock) continue;
1,370,760✔
282
      return NULL;
458,468✔
283
    }
284
  }
285

286
_end:
×
287
  if (code != TSDB_CODE_SUCCESS) {
×
288
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
289
    T_LONG_JMP(pTaskInfo->env, code);
×
290
  }
291
  return NULL;
×
292
}
293

294
static int32_t doFillNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) {
2,334,877✔
295
  int32_t            code = TSDB_CODE_SUCCESS;
2,334,877✔
296
  SFillOperatorInfo* pInfo = pOperator->info;
2,334,877✔
297
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
2,334,877✔
298

299
  if (pInfo->pTimeRange != NULL) {
2,334,877✔
300
    STimeWindow pWinRange = {0};
13,080✔
301
    bool        isWinRangeValid = false;
13,080✔
302
    code = streamCalcCurrWinTimeRange((STimeRangeNode*)pInfo->pTimeRange, &pTaskInfo->pStreamRuntimeInfo->funcInfo, &pWinRange,
13,080✔
303
                  &isWinRangeValid, 3);
304
    if (code != TSDB_CODE_SUCCESS || !isWinRangeValid) {
13,080✔
305
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
306
      pTaskInfo->code = code;
×
307
      T_LONG_JMP(pTaskInfo->env, code);
×
308
    }
309

310
    pInfo->win.skey = pWinRange.skey;
13,080✔
311
    /* ekey is inclusive in fill operator, so we need to subtract 1 */
312
    pInfo->win.ekey = pWinRange.ekey - 1;
13,080✔
313
  }
314

315
  if (pOperator->status == OP_EXEC_DONE) {
2,334,877✔
316
    (*ppRes) = NULL;
×
317
    return code;
×
318
  }
319

320
  SSDataBlock* fillResult = NULL;
2,334,877✔
321
  while (true) {
322
    fillResult = doFillImpl(pOperator);
2,347,239✔
323
    if (fillResult == NULL) {
2,346,757✔
324
      setOperatorCompleted(pOperator);
601,009✔
325
      break;
601,009✔
326
    }
327

328
    code = doFilter(fillResult, pOperator->exprSupp.pFilterInfo, &pInfo->matchInfo, NULL);
1,745,748✔
329
    if (code != TSDB_CODE_SUCCESS) {
1,745,300✔
330
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
331
      pTaskInfo->code = code;
×
332
      T_LONG_JMP(pTaskInfo->env, code);
×
333
    }
334

335
    if (fillResult->info.rows > 0) {
1,745,300✔
336
      break;
1,733,386✔
337
    }
338
  }
339

340
  (*ppRes) = fillResult;
2,334,395✔
341
  return code;
2,334,395✔
342
}
343

344
void destroyFillOperatorInfo(void* param) {
627,778✔
345
  SFillOperatorInfo* pInfo = (SFillOperatorInfo*)param;
627,778✔
346
  pInfo->pFillInfo = taosDestroyFillInfo(pInfo->pFillInfo);
627,778✔
347
  blockDataDestroy(pInfo->pRes);
627,778✔
348
  pInfo->pRes = NULL;
627,778✔
349
  blockDataDestroy(pInfo->pFinalRes);
627,778✔
350
  pInfo->pFinalRes = NULL;
627,778✔
351

352
  cleanupExprSupp(&pInfo->noFillExprSupp);
627,778✔
353
  cleanupExprSupp(&pInfo->fillNullExprSupp);
627,778✔
354

355
  taosMemoryFreeClear(pInfo->p);
627,778✔
356
  taosArrayDestroy(pInfo->matchInfo.pList);
627,778✔
357
  taosMemoryFreeClear(param);
627,778✔
358
}
627,778✔
359

360
static int32_t initFillInfo(SFillOperatorInfo* pInfo, SExprInfo* pExpr,
627,330✔
361
                            int32_t numOfCols, SExprInfo* pNotFillExpr,
362
                            int32_t numOfNotFillCols, SExprInfo* pFillNullExpr,
363
                            int32_t numOfFillNullExprs, SNodeListNode* pValNode,
364
                            STimeWindow win, int32_t capacity, const char* id,
365
                            SInterval* pInterval, int32_t fillType,
366
                            int32_t order, SExecTaskInfo* pTaskInfo,
367
                            int64_t surroundingTime, bool indefRowsMode) {
368
  SFillColInfo* pColInfo =
369
      createFillColInfo(pExpr, numOfCols, pNotFillExpr, numOfNotFillCols,
627,330✔
370
                        pFillNullExpr, numOfFillNullExprs, pValNode);
371
  if (!pColInfo) {
627,330✔
372
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno));
×
373
    return terrno;
×
374
  }
375

376
  int64_t startKey = (order == TSDB_ORDER_ASC) ? win.skey : win.ekey;
627,330✔
377

378
  //  STimeWindow w = {0};
379
  //  getInitialStartTimeWindow(pInterval, startKey, &w, order == TSDB_ORDER_ASC);
380
  pInfo->pFillInfo = NULL;
627,330✔
381
  int32_t code = taosCreateFillInfo(startKey, numOfCols, numOfNotFillCols,
627,778✔
382
                                    numOfFillNullExprs, capacity, pInterval,
383
                                    fillType, pColInfo, pInfo->primaryTsCol,
384
                                    order, id, pTaskInfo, surroundingTime,
385
                                    indefRowsMode, &pInfo->pFillInfo);
627,330✔
386
  if (code != TSDB_CODE_SUCCESS) {
626,434✔
387
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
388
    return code;
×
389
  }
390

391
  if (order == TSDB_ORDER_ASC) {
626,434✔
392
    pInfo->win.skey = win.skey;
531,579✔
393
    pInfo->win.ekey = win.ekey;
531,579✔
394
  } else {
395
    pInfo->win.skey = win.ekey;
94,855✔
396
    pInfo->win.ekey = win.skey;
94,855✔
397
  }
398
  pInfo->p = taosMemoryCalloc(numOfCols, POINTER_BYTES);
625,986✔
399
  if (!pInfo->p) {
626,434✔
400
    return terrno;
×
401
  }
402

403
  if (pInfo->pFillInfo == NULL) {
625,986✔
UNCOV
404
    taosMemoryFree(pInfo->pFillInfo);
×
405
    taosMemoryFree(pInfo->p);
×
406
    return TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR;
×
407
  } else {
408
    return TSDB_CODE_SUCCESS;
625,538✔
409
  }
410
}
411

412
static bool isWstartColumnExist(SFillOperatorInfo* pInfo) {
627,778✔
413
  if (pInfo->noFillExprSupp.numOfExprs == 0) {
627,778✔
414
    return false;
82,248✔
415
  }
416

417
  for (int32_t i = 0; i < pInfo->noFillExprSupp.numOfExprs; ++i) {
816,363✔
418
    SExprInfo* exprInfo = pInfo->noFillExprSupp.pExprInfo + i;
787,949✔
419
    if (exprInfo->pExpr->nodeType == QUERY_NODE_COLUMN && exprInfo->base.numOfParams == 1 &&
788,397✔
420
        exprInfo->base.pParam[0].pCol->colType == COLUMN_TYPE_WINDOW_START) {
786,605✔
421
      return true;
515,772✔
422
    }
423
  }
424
  return false;
29,310✔
425
}
426

427
static int32_t createPrimaryTsExprIfNeeded(SFillOperatorInfo* pInfo, SFillPhysiNode* pPhyFillNode, SExprSupp* pExprSupp,
627,778✔
428
                                           const char* idStr) {
429
  bool wstartExist = isWstartColumnExist(pInfo);
627,778✔
430

431
  if (wstartExist == false) {
627,330✔
432
    if (pPhyFillNode->pWStartTs->type != QUERY_NODE_TARGET) {
111,558✔
433
      qError("pWStartTs of fill physical node is not a target node, %s", idStr);
×
434
      return TSDB_CODE_QRY_SYS_ERROR;
×
435
    }
436

437
    SExprInfo* pExpr = taosMemoryRealloc(pExprSupp->pExprInfo, (pExprSupp->numOfExprs + 1) * sizeof(SExprInfo));
110,573✔
438
    if (pExpr == NULL) {
111,558✔
439
      return terrno;
×
440
    }
441

442
    int32_t code = createExprFromTargetNode(&pExpr[pExprSupp->numOfExprs], (STargetNode*)pPhyFillNode->pWStartTs);
111,558✔
443
    if (code != TSDB_CODE_SUCCESS) {
111,558✔
444
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
445
      pExprSupp->numOfExprs += 1;
×
446
      pExprSupp->pExprInfo = pExpr;
×
447
      return code;
×
448
    }
449

450
    pExprSupp->numOfExprs += 1;
111,558✔
451
    pExprSupp->pExprInfo = pExpr;
111,558✔
452
  }
453

454
  return TSDB_CODE_SUCCESS;
627,330✔
455
}
456

457
static int32_t resetFillOperState(SOperatorInfo* pOper) {
6,540✔
458
  SFillOperatorInfo* pFill = pOper->info;
6,540✔
459
  SExecTaskInfo*           pTaskInfo = pOper->pTaskInfo;
6,540✔
460
  pOper->status = OP_NOT_OPENED;
6,540✔
461
  SFillPhysiNode* pPhyNode = (SFillPhysiNode*)pOper->pPhyNode;
6,540✔
462

463
  pFill->curGroupId = 0;
6,540✔
464
  pFill->totalInputRows = 0;
6,540✔
465
  blockDataCleanup(pFill->pRes);
6,540✔
466
  blockDataCleanup(pFill->pFinalRes);
6,540✔
467

468
  int64_t startKey = (pFill->pFillInfo->order == TSDB_ORDER_ASC) ? pPhyNode->timeRange.skey : pPhyNode->timeRange.ekey;
6,540✔
469
  pFill->pFillInfo->start = startKey;
6,540✔
470
  pFill->pFillInfo->currentKey = startKey;
6,540✔
471
  pFill->pFillInfo->end = startKey;
6,540✔
472

473
  pFill->pFillInfo->numOfRows = 0;
6,540✔
474
  pFill->pFillInfo->index = -1;
6,540✔
475
  pFill->pFillInfo->numOfTotal = 0;
6,540✔
476
  pFill->pFillInfo->numOfCurrent = 0;
6,540✔
477
  pFill->pFillInfo->isFilled = false;
6,540✔
478
  int32_t size = taosArrayGetSize(pFill->pFillInfo->prev.pRowVal);
6,540✔
479
  for (int32_t i = 0; i < size; ++i) {
39,240✔
480
    SGroupKeys* pKey = taosArrayGet(pFill->pFillInfo->prev.pRowVal, i);
32,700✔
481
    pKey->isNull = true;
32,700✔
482
  }
483
  size = taosArrayGetSize(pFill->pFillInfo->next.pRowVal);
6,540✔
484
  for (int32_t i = 0; i < size; ++i) {
39,240✔
485
    SGroupKeys* pKey = taosArrayGet(pFill->pFillInfo->next.pRowVal, i);
32,700✔
486
    pKey->isNull = true;
32,700✔
487
  }
488

489
  taosMemoryFreeClear(pFill->pFillInfo->pTags);
6,540✔
490
  taosArrayDestroy(pFill->pFillInfo->pColFillProgress);
6,540✔
491
  pFill->pFillInfo->pColFillProgress = NULL;
6,540✔
492

493
  tdListFreeP(pFill->pFillInfo->pFillSavedBlockList, destroyFillBlock);
6,540✔
494
  pFill->pFillInfo->pFillSavedBlockList = NULL;
6,540✔
495

496
  int32_t order = (pPhyNode->node.inputTsOrder == ORDER_ASC) ? TSDB_ORDER_ASC : TSDB_ORDER_DESC;
6,540✔
497
  if (order == TSDB_ORDER_ASC) {
6,540✔
498
    pFill->win.skey = pPhyNode->timeRange.skey;
6,540✔
499
    pFill->win.ekey = pPhyNode->timeRange.ekey;
6,540✔
500
  } else {
501
    pFill->win.skey = pPhyNode->timeRange.ekey;
×
502
    pFill->win.ekey = pPhyNode->timeRange.skey;
×
503
  }
504

505
  return TSDB_CODE_SUCCESS;
6,540✔
506
}
507

508
int32_t createFillOperatorInfo(SOperatorInfo* downstream, SFillPhysiNode* pPhyFillNode,
626,424✔
509
                                      SExecTaskInfo* pTaskInfo, SOperatorInfo** pOptrInfo) {
510
  QRY_PARAM_CHECK(pOptrInfo);
626,424✔
511
  int32_t code = 0;
626,424✔
512
  int32_t lino = 0;
626,424✔
513

514
  SFillOperatorInfo* pInfo = taosMemoryCalloc(1, sizeof(SFillOperatorInfo));
626,424✔
515
  SOperatorInfo*     pOperator = taosMemoryCalloc(1, sizeof(SOperatorInfo));
624,598✔
516
  if (pInfo == NULL || pOperator == NULL) {
625,494✔
517
    code = terrno;
×
518
    goto _error;
×
519
  }
520
  initOperatorCostInfo(pOperator);
625,494✔
521

522
  pOperator->pPhyNode = pPhyFillNode;
627,778✔
523
  pInfo->pRes = createDataBlockFromDescNode(pPhyFillNode->node.pOutputDataBlockDesc);
627,778✔
524
  QUERY_CHECK_NULL(pInfo->pRes, code, lino, _error, terrno);
627,778✔
525
  SExprInfo* pExprInfo = NULL;
626,434✔
526

527
  code = createExprInfo(pPhyFillNode->pFillExprs, NULL, &pExprInfo, &pInfo->numOfExpr);
626,434✔
528
  QUERY_CHECK_CODE(code, lino, _error);
627,778✔
529

530
  pOperator->exprSupp.pExprInfo = pExprInfo;
627,778✔
531
  pOperator->exprSupp.numOfExprs = pInfo->numOfExpr;
627,778✔
532

533
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
627,778✔
534
  code = createExprInfo(pPhyFillNode->pNotFillExprs, NULL, &pNoFillSupp->pExprInfo, &pNoFillSupp->numOfExprs);
626,848✔
535
  QUERY_CHECK_CODE(code, lino, _error);
627,778✔
536

537
  code = createPrimaryTsExprIfNeeded(pInfo, pPhyFillNode, pNoFillSupp, pTaskInfo->id.str);
627,778✔
538
  QUERY_CHECK_CODE(code, lino, _error);
627,330✔
539

540
  code =
541
      initExprSupp(pNoFillSupp, pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs, &pTaskInfo->storageAPI.functionStore);
627,330✔
542
  QUERY_CHECK_CODE(code, lino, _error);
627,330✔
543

544
  code = createExprInfo(pPhyFillNode->pFillNullExprs, NULL, &pInfo->fillNullExprSupp.pExprInfo,
627,330✔
545
                        &pInfo->fillNullExprSupp.numOfExprs);
546
  QUERY_CHECK_CODE(code, lino, _error);
627,330✔
547
  code = initExprSupp(&pInfo->fillNullExprSupp, pInfo->fillNullExprSupp.pExprInfo, pInfo->fillNullExprSupp.numOfExprs,
627,330✔
548
                      &pTaskInfo->storageAPI.functionStore);
549
  QUERY_CHECK_CODE(code, lino, _error);
626,882✔
550

551
  SInterval* pInterval =
626,882✔
552
      QUERY_NODE_PHYSICAL_PLAN_MERGE_ALIGNED_INTERVAL == downstream->operatorType
626,882✔
553
          ? &((SMergeAlignedIntervalAggOperatorInfo*)downstream->info)->intervalAggOperatorInfo->interval
209,792✔
554
          : &((SIntervalAggOperatorInfo*)downstream->info)->interval;
836,674✔
555

556
  int32_t order = (pPhyFillNode->node.inputTsOrder == ORDER_ASC) ? TSDB_ORDER_ASC : TSDB_ORDER_DESC;
626,882✔
557
  int32_t type = convertFillType(pPhyFillNode->mode);
626,434✔
558

559
  SResultInfo* pResultInfo = &pOperator->resultInfo;
625,528✔
560

561
  initResultSizeInfo(&pOperator->resultInfo, 4096);
625,976✔
562
  code = blockDataEnsureCapacity(pInfo->pRes, pOperator->resultInfo.capacity);
625,986✔
563
  if (code != TSDB_CODE_SUCCESS) {
627,778✔
564
    goto _error;
×
565
  }
566
  code = initExprSupp(&pOperator->exprSupp, pExprInfo, pInfo->numOfExpr, &pTaskInfo->storageAPI.functionStore);
627,778✔
567
  if (code != TSDB_CODE_SUCCESS) {
627,778✔
568
    goto _error;
×
569
  }
570

571
  pInfo->primaryTsCol = ((STargetNode*)pPhyFillNode->pWStartTs)->slotId;
627,778✔
572
  pInfo->primarySrcSlotId = ((SColumnNode*)((STargetNode*)pPhyFillNode->pWStartTs)->pExpr)->slotId;
627,778✔
573

574
  int32_t numOfOutputCols = 0;
627,778✔
575
  code = extractColMatchInfo(pPhyFillNode->pFillExprs, pPhyFillNode->node.pOutputDataBlockDesc, &numOfOutputCols,
627,778✔
576
                             COL_MATCH_FROM_SLOT_ID, &pInfo->matchInfo);
577

578
  QUERY_CHECK_CODE(code, lino, _error);
627,330✔
579

580
  // Extract surroundingTime from pSurroundingTime node
581
  int64_t surroundingTime = 0;
627,330✔
582
  if (pPhyFillNode->pSurroundingTime != NULL &&
627,330✔
583
      nodeType(pPhyFillNode->pSurroundingTime) == QUERY_NODE_VALUE) {
9,156✔
584
    surroundingTime = ((SValueNode*)pPhyFillNode->pSurroundingTime)->datum.i;
9,156✔
585
  }
586

587
  code = initFillInfo(pInfo, pExprInfo, pInfo->numOfExpr,
1,255,556✔
588
                      pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs,
589
                      pInfo->fillNullExprSupp.pExprInfo,
590
                      pInfo->fillNullExprSupp.numOfExprs,
591
                      (SNodeListNode*)pPhyFillNode->pValues,
627,330✔
592
                      pPhyFillNode->timeRange, pResultInfo->capacity,
593
                      pTaskInfo->id.str, pInterval, type, order, pTaskInfo,
627,778✔
594
                      surroundingTime, pPhyFillNode->indefRowsMode);
627,778✔
595
  if (code != TSDB_CODE_SUCCESS) {
625,090✔
596
    goto _error;
×
597
  }
598
  TSWAP(pInfo->pTimeRange, pPhyFillNode->pTimeRange);
625,090✔
599
  pInfo->pFinalRes = NULL;
625,952✔
600

601
  code = createOneDataBlock(pInfo->pRes, false, &pInfo->pFinalRes);
625,538✔
602
  if (code) {
627,330✔
603
    goto _error;
×
604
  }
605

606
  code = blockDataEnsureCapacity(pInfo->pFinalRes, pOperator->resultInfo.capacity);
627,330✔
607
  if (code != TSDB_CODE_SUCCESS) {
627,778✔
608
    goto _error;
×
609
  }
610

611
  code = filterInitFromNode((SNode*)pPhyFillNode->node.pConditions, &pOperator->exprSupp.pFilterInfo, 0,
627,778✔
612
                            pTaskInfo->pStreamRuntimeInfo);
627,778✔
613
  if (code != TSDB_CODE_SUCCESS) {
627,778✔
614
    goto _error;
×
615
  }
616
  filterSetExecContext(pOperator->exprSupp.pFilterInfo, pTaskInfo, isTaskKilled);
627,778✔
617
  setOperatorInfo(pOperator, "FillOperator", QUERY_NODE_PHYSICAL_PLAN_FILL, false, OP_NOT_OPENED, pInfo, pTaskInfo);
627,778✔
618
  pOperator->fpSet = createOperatorFpSet(optrDummyOpenFn, doFillNext, NULL, destroyFillOperatorInfo, optrDefaultBufFn, NULL,
627,778✔
619
                                         optrDefaultGetNextExtFn, NULL);
620
  setOperatorResetStateFn(pOperator, resetFillOperState);
627,778✔
621

622
  code = appendDownstream(pOperator, &downstream, 1);
627,778✔
623
  if (code != TSDB_CODE_SUCCESS) {
627,778✔
624
    goto _error;
×
625
  }
626

627
  *pOptrInfo = pOperator;
627,778✔
628
  return TSDB_CODE_SUCCESS;
627,778✔
629

630
_error:
×
631
  qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
632

633
  if (pInfo != NULL) {
×
634
    destroyFillOperatorInfo(pInfo);
×
635
  }
636
  destroyOperatorAndDownstreams(pOperator, &downstream, 1);
×
637
  pTaskInfo->code = code;
×
638
  return code;
×
639
}
640

641
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order) {
975,312✔
642
  int64_t skey, ekey, next;
643
  if (order == TSDB_ORDER_ASC) {
975,312✔
644
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
912,127✔
645
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
912,563✔
646

647
    ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
912,563✔
648
    next = ekey;
912,563✔
649
    while (next < pInfo->win.ekey) {
1,197,113✔
650
      next = taosTimeAdd(ekey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
284,550✔
651
                         pInfo->pFillInfo->interval.precision, NULL);
284,550✔
652
      if (next == ekey) break;
284,550✔
653
      ekey = next > pInfo->win.ekey ? ekey : next;
284,550✔
654
    }
655
    pInfo->win.ekey = ekey;
912,563✔
656
  } else {
657
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
63,185✔
658
    next = skey;
63,185✔
659
    while (next < pInfo->win.skey) {
118,224✔
660
      next = taosTimeAdd(skey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
55,039✔
661
                         pInfo->pFillInfo->interval.precision, NULL);
55,039✔
662
      if (next == skey) break;
55,039✔
663
      skey = next > pInfo->win.skey ? skey : next;
55,039✔
664
    }
665
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
63,185✔
666
    pInfo->win.ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
63,185✔
667
  }
668
}
975,748✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc