#15908

Committed 12 May 2026 07:29PM UTC coverage: 86.923% (+0.006%) from 86.917%

Build Type

push

Committed by

Commit Message

Merge 39c1aae01 into ce68f5cb7

Coverage Stats

15646 of 19004 branches covered (82.33%)

Branch coverage included in aggregate %.

28 of 28 new or added lines in 8 files covered. (100.0%)

112 existing lines in 4 files now uncovered.

16359 of 17816 relevant lines covered (91.82%)

27323.13 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.06

/src/CrossScopeValidator.ts

import type { UnresolvedSymbol } from './AstValidationSegmenter';
import type { Scope } from './Scope';
import type { BrsFile, ProvidedSymbol } from './files/BrsFile';
import { DiagnosticMessages } from './DiagnosticMessages';
import type { Program } from './Program';
import { util } from './util';
import { SymbolTypeFlag } from './SymbolTypeFlag';
import type { BscSymbol } from './SymbolTable';
import { isCallExpression, isConstStatement, isEnumStatement, isEnumType, isFunctionStatement, isInheritableType, isInterfaceStatement, isNamespaceStatement, isNamespaceType, isReferenceType, isTypedFunctionType, isUnionType } from './astUtils/reflection';
import type { ReferenceType } from './types/ReferenceType';
import { getAllRequiredSymbolNames } from './types/ReferenceType';
import type { TypeChainEntry, TypeChainProcessResult } from './interfaces';
import { BscTypeKind } from './types/BscTypeKind';
import { getAllTypesFromCompoundType } from './types/helpers';
import type { BscType } from './types/BscType';
import type { BscFile } from './files/BscFile';
import type { ClassStatement, ConstStatement, EnumMemberStatement, EnumStatement, InterfaceStatement, NamespaceStatement } from './parser/Statement';
import { ParseMode } from './parser/Parser';
import { globalFile } from './globalCallables';
import type { DottedGetExpression, VariableExpression } from './parser/Expression';
import type { InheritableType } from './types';


interface FileSymbolPair {
    file: BscFile;
    symbol: BscSymbol;
}

interface SymbolLookupKeys {
    potentialTypeKey: string;
    key: string;
    namespacedKey: string;
    namespacedPotentialTypeKey: string;
}

const CrossScopeValidatorDiagnosticTag = 'CrossScopeValidator';

export class ProvidedNode {

    namespaces = new Map<string, ProvidedNode>();
    symbols = new Map<string, FileSymbolPair>();

    constructor(public key: string = '', private componentsMap?: Map<string, FileSymbolPair>) { }


    getSymbolByKey(symbolKeys: SymbolLookupKeys): FileSymbolPair {
        return this.getSymbol(symbolKeys.namespacedKey) ??
            this.getSymbol(symbolKeys.key) ??
            this.getSymbol(symbolKeys.namespacedPotentialTypeKey) ??
            this.getSymbol(symbolKeys.potentialTypeKey);
    }

    getSymbol(symbolName: string): FileSymbolPair {
        if (!symbolName) {
            return;
        }
        const lowerSymbolName = symbolName.toLowerCase();
        if (this.componentsMap?.has(lowerSymbolName)) {
            return this.componentsMap.get(lowerSymbolName);
        }
        let lowerSymbolNameParts = lowerSymbolName.split('.');
        return this.getSymbolByNameParts(lowerSymbolNameParts, this);
    }

    getNamespace(namespaceName: string): ProvidedNode {
        let lowerSymbolNameParts = namespaceName.toLowerCase().split('.');
        return this.getNamespaceByNameParts(lowerSymbolNameParts);
    }

    getSymbolByNameParts(lowerSymbolNameParts: string[], root: ProvidedNode): FileSymbolPair {
        const first = lowerSymbolNameParts?.[0];
        const rest = lowerSymbolNameParts.slice(1);
        if (!first) {
            return;
        }
        if (this.symbols.has(first)) {
            let result = this.symbols.get(first);
            let currentType = result.symbol.type;

            for (const namePart of rest) {
                if (isTypedFunctionType(currentType)) {
                    const returnType = currentType.returnType;
                    if (returnType.isResolvable()) {
                        currentType = returnType;
                    } else if (isReferenceType(returnType)) {
                        const fullName = returnType.fullName;
                        if (fullName.includes('.')) {
                            currentType = root.getSymbol(fullName)?.symbol?.type;
                        } else {
                            currentType = this.getSymbol(fullName)?.symbol?.type ??
                                root.getSymbol(fullName)?.symbol?.type;
                        }
                    }
                }
                let typesToTry = [currentType];
                if (isEnumType(currentType)) {
                    typesToTry.push(currentType.defaultMemberType);
                }
                if (isInheritableType(currentType)) {
                    let inheritableType = currentType;
                    while (inheritableType?.parentType) {
                        let parentType = inheritableType.parentType as BscType;
                        if (isReferenceType(inheritableType.parentType)) {
                            const fullName = inheritableType.parentType.fullName;
                            if (fullName.includes('.')) {
                                parentType = root.getSymbol(fullName)?.symbol?.type;
                            } else {
                                parentType = this.getSymbol(fullName)?.symbol?.type ??
                                    root.getSymbol(fullName)?.symbol?.type;
                            }
                        }
                        typesToTry.push(parentType);
                        inheritableType = parentType as InheritableType;
                    }

                }
                const extraData = {};

                for (const curType of typesToTry) {
                    currentType = curType?.getMemberType(namePart, { flags: SymbolTypeFlag.runtime, data: extraData });
                    if (isReferenceType(currentType)) {
                        const memberLookup = currentType.fullName;
                        currentType = this.getSymbol(memberLookup.toLowerCase())?.symbol?.type ?? root.getSymbol(memberLookup.toLowerCase())?.symbol?.type;
                    }
                    if (currentType) {
                        break;
                    }
                }

                if (!currentType) {
                    return;
                }
                // get specific member
                result = {
                    ...result, symbol: { name: namePart, type: currentType, data: extraData, flags: SymbolTypeFlag.runtime }
                };
            }
            return result;

        } else if (rest && this.namespaces.has(first)) {
            const node = this.namespaces.get(first);
            const parts = node.getSymbolByNameParts(rest, root);

            return parts;
        }
    }

    getNamespaceByNameParts(lowerSymbolNameParts: string[]): ProvidedNode {
        const first = lowerSymbolNameParts?.[0]?.toLowerCase();
        const rest = lowerSymbolNameParts.slice(1);
        if (!first) {
            return;
        }
        if (this.namespaces.has(first)) {
            const node = this.namespaces.get(first);
            const result = rest?.length > 0 ? node.getNamespaceByNameParts(rest) : node;
            return result;
        }
    }

    addSymbol(symbolName: string, symbolPair: FileSymbolPair) {
        let lowerSymbolNameParts = symbolName.toLowerCase().split('.');
        return this.addSymbolByNameParts(lowerSymbolNameParts, symbolPair);
    }

    private addSymbolByNameParts(lowerSymbolNameParts: string[], symbolPair: FileSymbolPair) {
        const first = lowerSymbolNameParts?.[0];
        const rest = lowerSymbolNameParts?.slice(1);
        let isDuplicate = false;
        if (!first) {
            return;
        }
        if (rest?.length > 0) {
            // first must be a namespace
            let namespaceNode = this.namespaces.get(first);
            if (!namespaceNode) {
                namespaceNode = new ProvidedNode(first);
                this.namespaces.set(first, namespaceNode);
            }
            return namespaceNode.addSymbolByNameParts(rest, symbolPair);
        } else {
            if (this.namespaces.get(first)) {
                // trying to add a symbol that already exists as a namespace - this is a duplicate
                return true;
            }

            // just add it to the symbols
            const existingSymbolPair = this.symbols.get(first);
            if (!existingSymbolPair) {
                this.symbols.set(first, symbolPair);
            } else {
                isDuplicate = existingSymbolPair.symbol.data?.definingNode !== symbolPair.symbol.data?.definingNode;
            }
        }
        return isDuplicate;
    }
}


export class CrossScopeValidator {

    constructor(public program: Program) { }

    private symbolMapKeys(symbol: UnresolvedSymbol): SymbolLookupKeys[] {
        let keysArray = new Array<SymbolLookupKeys>();
        let unnamespacedNameLowers: string[] = [];

        function joinTypeChainForKey(typeChain: TypeChainEntry[], firstType?: BscType) {
            firstType ||= typeChain[0].type;
            const unnamespacedNameLower = typeChain.map((tce, i) => {
                if (i === 0) {
                    if (isReferenceType(firstType)) {
                        return firstType.fullName;
                    } else if (isInheritableType(firstType)) {
                        return tce.type.toString();
                    }
                    return tce.name;
                }
                return tce.name;
            }).join('.').toLowerCase();
            return unnamespacedNameLower;
        }

        if (isUnionType(symbol.typeChain[0].type) && symbol.typeChain[0].data.isInstance) {
            const allUnifiedTypes = getAllTypesFromCompoundType(symbol.typeChain[0].type);
            for (const unifiedType of allUnifiedTypes) {
                unnamespacedNameLowers.push(joinTypeChainForKey(symbol.typeChain, unifiedType));
            }

        } else {
            unnamespacedNameLowers.push(joinTypeChainForKey(symbol.typeChain));
        }

        for (const unnamespacedNameLower of unnamespacedNameLowers) {
            const lowerFirst = symbol.typeChain[0]?.name?.toLowerCase() ?? '';
            let namespacedName = '';
            let lowerNamespacePrefix = '';
            let namespacedPotentialTypeKey = '';
            if (symbol.containingNamespaces?.length > 0 && symbol.typeChain[0]?.name.toLowerCase() !== symbol.containingNamespaces[0].toLowerCase()) {
                lowerNamespacePrefix = `${(symbol.containingNamespaces ?? []).join('.')}`.toLowerCase();
            }
            if (lowerNamespacePrefix) {
                namespacedName = `${lowerNamespacePrefix}.${unnamespacedNameLower}`;
                namespacedPotentialTypeKey = `${lowerNamespacePrefix}.${lowerFirst}`;
            }

            keysArray.push({
                potentialTypeKey: lowerFirst, // first entry in type chain (useful for enum types, typecasts, etc.)
                key: unnamespacedNameLower, //full name used in code (useful for namespaced symbols)
                namespacedKey: namespacedName, // full name including namespaces (useful for relative symbols in a namespace)
                namespacedPotentialTypeKey: namespacedPotentialTypeKey //first entry in chain, prefixed with current namespace
            });
        }
        return keysArray;
    }

    resolutionsMap = new Map<UnresolvedSymbol, Set<{ scope: Scope; sourceFile: BscFile; providedSymbol: BscSymbol }>>();
    providedTreeMap = new Map<string, { duplicatesMap: Map<string, Set<FileSymbolPair>>; providedTree: ProvidedNode }>();


    private componentsMap = new Map<string, FileSymbolPair>();

    getRequiredMap(scope: Scope) {
        const map = new Map<SymbolLookupKeys, UnresolvedSymbol>();
        scope.enumerateBrsFiles((file) => {
            for (const symbol of file.requiredSymbols) {
                const symbolKeysArray = this.symbolMapKeys(symbol);
                for (const symbolKeys of symbolKeysArray) {
                    map.set(symbolKeys, symbol);
                }
            }
        });
        return map;
    }

    getProvidedTree(scope: Scope) {
        if (this.providedTreeMap.has(scope.name)) {
            return this.providedTreeMap.get(scope.name);
        }
        const providedTree = new ProvidedNode('', this.componentsMap);
        let duplicatesMap: Map<string, Set<FileSymbolPair>> = null;

        const referenceTypesMap = new Map<{ symbolName: string; file: BscFile; symbolObj: ProvidedSymbol }, Array<{ name: string; namespacedName?: string }>>();


        const addSymbolWithDuplicates = (symbolName: string, file: BscFile, symbolObj: ProvidedSymbol) => {
            // eslint-disable-next-line no-bitwise
            const globalSymbol = this.program.globalScope.symbolTable.getSymbol(symbolName, SymbolTypeFlag.typetime | SymbolTypeFlag.runtime);
            const symbolIsNamespace = providedTree.getNamespace(symbolName);
            const isDupe = providedTree.addSymbol(symbolName, { file: file, symbol: symbolObj.symbol });
            if (symbolIsNamespace || globalSymbol || isDupe || symbolObj.duplicates.length > 0) {
                let dupesSet = duplicatesMap?.get(symbolName) ?? null;
                if (!dupesSet) {
                    dupesSet = new Set<{ file: BrsFile; symbol: BscSymbol }>();
                    if (!duplicatesMap) {
                        duplicatesMap = new Map<string, Set<FileSymbolPair>>();
                    }
                    duplicatesMap.set(symbolName, dupesSet);
                    const existing = providedTree.getSymbol(symbolName);
                    if (existing) {
                        dupesSet.add(existing);
                    }
                }
                if (!dupesSet.has({ file: file, symbol: symbolObj.symbol })) {
                    dupesSet.add({ file: file, symbol: symbolObj.symbol });
                }
                if (symbolIsNamespace) {
                    const namespaceContainer = scope.getNamespace(symbolName);
                    const nsNode = namespaceContainer?.namespaceStatements?.[0];
                    if (nsNode) {
                        const nsFile = namespaceContainer.file;
                        const nsType = nsNode.getType({ flags: SymbolTypeFlag.typetime });
                        let nsSymbol: BscSymbol = {
                            name: nsNode.getName(ParseMode.BrighterScript),
                            type: nsType,
                            data: { definingNode: nsNode },
                            flags: SymbolTypeFlag.typetime
                        };
                        if (nsSymbol && !dupesSet.has({ file: nsFile, symbol: nsSymbol })) {
                            dupesSet.add({ file: nsFile, symbol: nsSymbol });
                        }
                    }
                }
                for (const providedDupeSymbol of symbolObj.duplicates) {
                    if (!dupesSet.has({ file: file, symbol: providedDupeSymbol })) {
                        dupesSet.add({ file: file, symbol: providedDupeSymbol });
                    }
                }
                if (globalSymbol) {
                    dupesSet.add({ file: globalFile, symbol: globalSymbol[0] });
                }
            }
        };

        scope.enumerateBrsFiles((file) => {
            for (const [_, nameMap] of file.providedSymbols.symbolMap.entries()) {

                for (const [symbolName, symbolObj] of nameMap.entries()) {
                    if (isNamespaceType(symbolObj.symbol.type)) {
                        continue;
                    }
                    addSymbolWithDuplicates(symbolName, file, symbolObj);
                }
            }

            // find all "provided symbols" that are reference types
            for (const [_, nameMap] of file.providedSymbols.referenceSymbolMap.entries()) {
                for (const [symbolName, symbolObj] of nameMap.entries()) {
                    const symbolType = symbolObj.symbol.type;
                    const namespaceLower = symbolObj.symbol.data?.definingNode?.findAncestor<NamespaceStatement>(isNamespaceStatement)?.getName(ParseMode.BrighterScript).toLowerCase();
                    const allNames = getAllRequiredSymbolNames(symbolType, namespaceLower);

                    referenceTypesMap.set({ symbolName: symbolName, file: file, symbolObj: symbolObj }, allNames);
                }
            }
        });

        // check provided reference types to see if they exist yet!
        while (referenceTypesMap.size > 0) {
            let addedSymbol = false;
            for (const [refTypeDetails, neededNames] of referenceTypesMap.entries()) {
                let foundNames = 0;
                for (const neededName of neededNames) {
                    // check if name exists or namespaced version exists
                    if (providedTree.getSymbol(neededName.name) ?? providedTree.getSymbol(neededName.namespacedName)) {
                        foundNames++;
                    }
                }
                if (neededNames.length === foundNames) {
                    //found all that were needed
                    addSymbolWithDuplicates(refTypeDetails.symbolName, refTypeDetails.file, refTypeDetails.symbolObj);
                    referenceTypesMap.delete(refTypeDetails);
                    addedSymbol = true;
                }
            }
            if (!addedSymbol) {
                break;
            }
        }

        const result = { duplicatesMap: duplicatesMap, providedTree: providedTree };
        this.providedTreeMap.set(scope.name, result);
        return result;
    }

    getIssuesForScope(scope: Scope) {
        const requiredMap = this.getRequiredMap(scope);
        const { providedTree, duplicatesMap } = this.getProvidedTree(scope);

        const missingSymbols = new Set<UnresolvedSymbol>();

        for (const [symbolKeys, unresolvedSymbol] of requiredMap.entries()) {

            // check global scope for components
            if (unresolvedSymbol.typeChain.length === 1 && this.program.globalScope.symbolTable.getSymbol(unresolvedSymbol.typeChain[0].name, unresolvedSymbol.flags)) {
                //symbol is available in global scope. ignore it
                continue;
            }
            let foundSymbol = providedTree.getSymbolByKey(symbolKeys);

            if (foundSymbol) {
                if (!unresolvedSymbol.typeChain[0].data?.isInstance) {
                    let resolvedListForSymbol = this.resolutionsMap.get(unresolvedSymbol);
                    if (!resolvedListForSymbol) {
                        resolvedListForSymbol = new Set<{ scope: Scope; sourceFile: BrsFile; providedSymbol: BscSymbol }>();
                        this.resolutionsMap.set(unresolvedSymbol, resolvedListForSymbol);
                    }
                    resolvedListForSymbol.add({
                        scope: scope,
                        sourceFile: foundSymbol.file,
                        providedSymbol: foundSymbol.symbol
                    });
                }
            } else {
                let foundNamespace = providedTree.getNamespace(symbolKeys.key);

                if (foundNamespace) {
                    // this symbol turned out to be a namespace. This is allowed for alias statements
                    // TODO: add check to make sure this usage is from an alias statement
                } else {
                    // did not find symbol!
                    const missing = { ...unresolvedSymbol };
                    let namespaceNode = providedTree;
                    let currentKnownType;
                    for (const chainEntry of missing.typeChain) {
                        if (!chainEntry.isResolved) {
                            // for each unresolved part of a chain, see if we can resolve it with stuff from the provided tree
                            // and if so, mark it as resolved
                            const lookupName = (chainEntry.type as ReferenceType)?.fullName ?? chainEntry.name;
                            if (!currentKnownType) {
                                namespaceNode = namespaceNode?.getNamespaceByNameParts([chainEntry.name]);

                            }
                            if (namespaceNode) {
                                chainEntry.isResolved = true;
                            } else {
                                if (currentKnownType) {
                                    currentKnownType = currentKnownType.getMemberType(chainEntry.name, { flags: SymbolTypeFlag.runtime });
                                } else {
                                    currentKnownType = providedTree.getSymbol(lookupName.toLowerCase())?.symbol?.type;
                                }

                                if (currentKnownType?.isResolvable()) {
                                    chainEntry.isResolved = true;
                                } else {
                                    break;
                                }
                            }
                        }
                    }
                    missingSymbols.add(unresolvedSymbol);
                }
            }
        }
        return { missingSymbols: missingSymbols, duplicatesMap: duplicatesMap };
    }

    clearResolutionsForFile(file: BrsFile) {
        for (const symbol of this.resolutionsMap.keys()) {
            if (symbol.file === file) {
                this.resolutionsMap.delete(symbol);
            }
        }
    }

    clearResolutionsForScopes(scopes: Scope[]) {
        const lowerScopeNames = new Set(scopes.map(scope => scope.name.toLowerCase()));
        for (const [symbol, resolutionInfos] of this.resolutionsMap.entries()) {
            for (const info of resolutionInfos.values()) {
                if (lowerScopeNames.has(info.scope.name.toLowerCase())) {
                    resolutionInfos.delete(info);
                }
            }
            if (resolutionInfos.size === 0) {
                this.resolutionsMap.delete(symbol);
            }
        }
    }

    getFilesRequiringChangedSymbol(scopes: Scope[], changedSymbols: Map<SymbolTypeFlag, Set<string>>) {
        const filesThatNeedRevalidation = new Set<BscFile>();
        const filesThatDoNotNeedRevalidation = new Set<BscFile>();

        for (const scope of scopes) {
            scope.enumerateBrsFiles((file) => {
                if (filesThatNeedRevalidation.has(file) || filesThatDoNotNeedRevalidation.has(file)) {
                    return;
                }
                if (util.hasAnyRequiredSymbolChanged(file.requiredSymbols, changedSymbols)) {
                    filesThatNeedRevalidation.add(file);
                    return;
                }
                filesThatDoNotNeedRevalidation.add(file);
            });
        }
        return filesThatNeedRevalidation;
    }

    getScopesRequiringChangedSymbol(scopes: Scope[], changedSymbols: Map<SymbolTypeFlag, Set<string>>) {
        const scopesThatNeedRevalidation = new Set<Scope>();
        const filesAlreadyChecked = new Set<BrsFile>();

        for (const scope of scopes) {
            scope.enumerateBrsFiles((file) => {
                if (filesAlreadyChecked.has(file) || scopesThatNeedRevalidation.has(scope)) {
                    return;
                }
                filesAlreadyChecked.add(file);

                if (util.hasAnyRequiredSymbolChanged(file.requiredSymbols, changedSymbols)) {
                    scopesThatNeedRevalidation.add(scope);
                }
            });
        }
        return scopesThatNeedRevalidation;
    }

    buildComponentsMap() {
        this.componentsMap.clear();
        // Add custom components
        for (let componentName of this.program.getSortedComponentNames()) {
            const typeName = 'rosgnode' + componentName;
            const component = this.program.getComponent(componentName);
            const componentSymbol = this.program.globalScope.symbolTable.getSymbol(typeName, SymbolTypeFlag.typetime)?.[0];
            if (componentSymbol && component) {
                this.componentsMap.set(typeName, { file: component.file, symbol: componentSymbol });
            }
        }
    }

    addDiagnosticsForScopes(scopes: Scope[]) { //, changedFiles: BrsFile[]) {
        const addDuplicateSymbolDiagnostics = true;
        const missingSymbolInScope = new Map<UnresolvedSymbol, Set<Scope>>();
        this.providedTreeMap.clear();
        this.clearResolutionsForScopes(scopes);

        // Check scope for duplicates and missing symbols
        for (const scope of scopes) {
            this.program.diagnostics.clearByFilter({
                scope: scope,
                tag: CrossScopeValidatorDiagnosticTag
            });

            const { missingSymbols, duplicatesMap } = this.getIssuesForScope(scope);
            if (addDuplicateSymbolDiagnostics && duplicatesMap) {
                for (const [_flag, dupeSet] of duplicatesMap.entries()) {
                    if (dupeSet.size > 1) {

                        const dupesArray = [...dupeSet.values()];

                        for (let i = 0; i < dupesArray.length; i++) {
                            const dupe = dupesArray[i];

                            const dupeNode = dupe?.symbol?.data?.definingNode;
                            if (!dupeNode) {
                                continue;
                            }
                            let thisName = dupe.symbol?.name;
                            const wrappingNameSpace = dupeNode?.findAncestor<NamespaceStatement>(isNamespaceStatement);

                            if (wrappingNameSpace) {
                                thisName = `${wrappingNameSpace.getName(ParseMode.BrighterScript)}.` + thisName;
                            }

                            const thisNodeKindName = util.getAstNodeFriendlyName(dupeNode) ?? 'Item';

                            for (let j = 0; j < dupesArray.length; j++) {
                                if (i === j) {
                                    continue;
                                }
                                const otherDupe = dupesArray[j];
                                if (!otherDupe || dupe.symbol === otherDupe.symbol) {
                                    continue;
                                }

                                const otherDupeNode = otherDupe.symbol.data?.definingNode;
                                const otherIsGlobal = otherDupe.file.srcPath === 'global';

                                if (isFunctionStatement(dupeNode) && isFunctionStatement(otherDupeNode)) {
                                    // duplicate functions are handled in ScopeValidator
                                    continue;
                                }
                                if (otherIsGlobal &&
                                    (isInterfaceStatement(dupeNode) ||
                                        isEnumStatement(dupeNode) ||
                                        isConstStatement(dupeNode))) {
                                    // these are allowed to shadow global functions
                                    continue;
                                }
                                let thatName = otherDupe.symbol?.name;

                                if (otherDupeNode) {
                                    const otherWrappingNameSpace = otherDupeNode?.findAncestor<NamespaceStatement>(isNamespaceStatement);
                                    if (otherWrappingNameSpace) {
                                        thatName = `${otherWrappingNameSpace.getName(ParseMode.BrighterScript)}.` + thatName;
                                    }
                                }

                                type AstNodeWithName = VariableExpression | DottedGetExpression | EnumStatement | ClassStatement | ConstStatement | EnumMemberStatement | InterfaceStatement;

                                const thatNodeKindName = otherIsGlobal ? 'Global Function' : util.getAstNodeFriendlyName(otherDupeNode) ?? 'Item';
                                let thisNameRange = (dupeNode as AstNodeWithName)?.tokens?.name?.location?.range ?? dupeNode.location?.range;
                                let thatNameRange = (otherDupeNode as AstNodeWithName)?.tokens?.name?.location?.range ?? otherDupeNode?.location?.range;

                                const relatedInformation = thatNameRange ? [{
                                    message: `${thatNodeKindName} declared here`,
                                    location: util.createLocationFromFileRange(otherDupe.file, thatNameRange)
                                }] : undefined;
                                this.program.diagnostics.register({
                                    ...DiagnosticMessages.nameCollision(thisNodeKindName, thatNodeKindName, thatName),
                                    location: util.createLocationFromFileRange(dupe.file, thisNameRange),
                                    relatedInformation: relatedInformation
                                }, {
                                    scope: scope,
                                    tags: [CrossScopeValidatorDiagnosticTag]
                                });
                            }
                        }
                    }
                }
            }
            // build map of the symbols and scopes where the symbols are missing per file
            for (const missingSymbol of missingSymbols) {

                let scopesWithMissingSymbol = missingSymbolInScope.get(missingSymbol);
                if (!scopesWithMissingSymbol) {
                    scopesWithMissingSymbol = new Set<Scope>();
                    missingSymbolInScope.set(missingSymbol, scopesWithMissingSymbol);
                }
                scopesWithMissingSymbol.add(scope);
            }
        }

        // If symbols are missing in SOME scopes, add diagnostic
        for (const [symbol, scopeList] of missingSymbolInScope.entries()) {
            const typeChainResult = util.processTypeChain(symbol.typeChain);

            //roku built-in type names (rosgnode*, etc.) aren't tracked in any symbol table;
            //skip cannot-find-name when the symbol's name is one of those built-ins.
            if (typeChainResult.itemName && util.isBuiltInType(typeChainResult.itemName)) {
                continue;
            }

            for (const scope of scopeList) {
                this.program.diagnostics.register({
                    ...this.getCannotFindDiagnostic(scope, symbol, typeChainResult),
                    location: typeChainResult.location
                }, {
                    scope: scope,
                    tags: [CrossScopeValidatorDiagnosticTag]
                });
            }
        }

        for (const resolution of this.getIncompatibleSymbolResolutions()) {
            const symbol = resolution.symbol;
            const incompatibleScopes = resolution.incompatibleScopes;
            if (incompatibleScopes.size > 1) {
                const typeChainResult = util.processTypeChain(symbol.typeChain);
                const scopeList = [...incompatibleScopes.values()].map(s => s.name);
                this.program.diagnostics.register({
                    ...DiagnosticMessages.incompatibleSymbolDefinition(typeChainResult.fullChainName, { scopes: scopeList }),
                    location: typeChainResult.location
                }, {
                    tags: [CrossScopeValidatorDiagnosticTag]
                });
            }
        }
    }

    getIncompatibleSymbolResolutions() {
        const incompatibleResolutions = new Array<{ symbol: UnresolvedSymbol; incompatibleScopes: Set<Scope> }>();
        // check all resolutions and check if there are resolutions that are not compatible across scopes
        for (const [symbol, resolutionDetails] of this.resolutionsMap.entries()) {
            if (resolutionDetails.size < 2) {
                // there is only one resolution... no worries
                continue;
            }
            const resolutionsList = [...resolutionDetails];
            const prime = resolutionsList[0];
            let incompatibleScopes = new Set<Scope>();
            let addedPrime = false;
            for (let i = 1; i < resolutionsList.length; i++) {
                let providedSymbolType = prime.providedSymbol.type;
                const symbolInThisScope = resolutionsList[i].providedSymbol;

                //get more general type
                if (providedSymbolType.isEqual(symbolInThisScope.type)) {
                    //type in this scope is the same as one we're already checking
                } else if (providedSymbolType.isTypeCompatible(symbolInThisScope.type)) {
                    //type in this scope is compatible with one we're storing. use most generic
                    providedSymbolType = symbolInThisScope.type;
                } else if (symbolInThisScope.type.isTypeCompatible(providedSymbolType)) {
                    // type we're storing is more generic that the type in this scope
                } else {
                    // type in this scope is not compatible with other types for this symbol
                    if (!addedPrime) {
                        incompatibleScopes.add(prime.scope);
                        addedPrime = true;
                    }
                    incompatibleScopes.add(resolutionsList[i].scope);
                }
            }

            if (incompatibleScopes.size > 1) {
                incompatibleResolutions.push({
                    symbol: symbol,
                    incompatibleScopes: incompatibleScopes
                });
            }
        }
        return incompatibleResolutions;
    }

    private getCannotFindDiagnostic(scope: Scope, unresolvedSymbol: UnresolvedSymbol, typeChainResult: TypeChainProcessResult) {
        const parentDescriptor = this.getParentTypeDescriptor(this.getProvidedTree(scope)?.providedTree, typeChainResult);
        const symbolType = typeChainResult.astNode?.getType({ flags: unresolvedSymbol.flags });
        if (isReferenceType(symbolType)) {
            const circularReferenceInfo = symbolType.getCircularReferenceInfo();
            if (circularReferenceInfo.isCircularReference) {
                let diagnosticDetail = util.getCircularReferenceDiagnosticDetail(circularReferenceInfo, typeChainResult.fullNameOfItem);
                return DiagnosticMessages.circularReferenceDetected(diagnosticDetail);
            }
        }

        if (isCallExpression(typeChainResult.astNode?.parent) && typeChainResult.astNode?.parent.callee === typeChainResult.astNode) {
            return DiagnosticMessages.cannotFindFunction(typeChainResult.itemName, typeChainResult.fullNameOfItem, typeChainResult.itemParentTypeName, parentDescriptor);
        }
        return DiagnosticMessages.cannotFindName(typeChainResult.itemName, typeChainResult.fullNameOfItem, typeChainResult.itemParentTypeName, parentDescriptor);
    }

    private getParentTypeDescriptor(provided: ProvidedNode, typeChainResult: TypeChainProcessResult) {
        if (typeChainResult.itemParentTypeKind === BscTypeKind.NamespaceType || provided?.getNamespace(typeChainResult.itemParentTypeName)) {
            return 'namespace';
        }
        return 'type';
    }

}

rokucommunity / brighterscript / #15908

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous