#1994

Committed 12 May 2026 06:57PM UTC coverage: 70.713% (+0.4%) from 70.334%

Build # #1994

Build Type

Pull #751

github

Committed by

kinow

Commit Message

Parse and validate Git URLs parsing URL, instead of using regexes (CodeQL security and performance warnings)

Pull Request Pull Request #751: Bump org.springframework.boot:spring-boot-starter-parent from 3.1.4 to 4.1.0-RC1

Coverage Stats

93 of 148 new or added lines in 29 files covered. (62.84%)

19 existing lines in 3 files now uncovered.

1695 of 2397 relevant lines covered (70.71%)

0.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.0

/src/main/java/org/commonwl/view/validation/AbstractGitValidator.java

/*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *   http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * software distributed under the License is distributed on an
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied.  See the License for the
 * specific language governing permissions and limitations
 * under the License.
 */

package org.commonwl.view.validation;

import java.net.URI;
import org.commonwl.view.git.GitDetails;
import org.commonwl.view.workflow.WorkflowForm;

/**
 * Abstract implementation of a Git validator.
 *
 * <p>Implementations must provide methods to retrieve the host and the base URL.
 */
public abstract class AbstractGitValidator implements GitUrlValidator {

  /**
   * Git host (e.g., github.com).
   *
   * @return Git host
   */
  protected abstract String host();

  /**
   * Git repository base URL (e.g., <a href="https://github.com/">...</a><owner>/<repo>.git).
   *
   * @param owner owner or organisation
   * @param repo repository name
   * @return a string representation of the Git repository base URL
   */
  protected abstract String repoBaseUrl(String owner, String repo);

  @Override
  public boolean supports(String url) {
    try {
      URI uri = URI.create(url);
      return host().equalsIgnoreCase(uri.getHost());
    } catch (Exception e) {
      return false;
    }
  }

  @Override
  public GitDetails parse(String url, WorkflowForm form) {
    final URI uri = URI.create(url);
    final String[] parts = uri.getPath().split("/");

    if (parts.length < 3) return null;

    final String owner = parts[1];
    final String repo = parts[2];

    final String repoUrl = repoBaseUrl(owner, repo);

    String branch = form.getBranch();
    String path = form.getPath();

    for (int i = 3; i < parts.length; i++) {
      if ("tree".equals(parts[i]) || "blob".equals(parts[i])) {
        if (branch == null && i + 1 < parts.length) {
          branch = parts[i + 1];
        }
        if (path == null && i + 2 < parts.length) {
          path = String.join("/", java.util.Arrays.copyOfRange(parts, i + 2, parts.length));
        }
        break;
      }
    }

    return new GitDetails(repoUrl, branch, path);
  }
}

1	/*
2	* Licensed to the Apache Software Foundation (ASF) under one
3	* or more contributor license agreements. See the NOTICE file
4	* distributed with this work for additional information
5	* regarding copyright ownership. The ASF licenses this file
6	* to you under the Apache License, Version 2.0 (the
7	* "License"); you may not use this file except in compliance
8	* with the License. You may obtain a copy of the License at
9	*
10	* http://www.apache.org/licenses/LICENSE-2.0
11	*
12	* Unless required by applicable law or agreed to in writing,
13	* software distributed under the License is distributed on an
14	* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15	* KIND, either express or implied. See the License for the
16	* specific language governing permissions and limitations
17	* under the License.
18	*/
19
20	package org.commonwl.view.validation;
21
22	import java.net.URI;
23	import org.commonwl.view.git.GitDetails;
24	import org.commonwl.view.workflow.WorkflowForm;
25
26	/**
27	* Abstract implementation of a Git validator.
28	*
29	* <p>Implementations must provide methods to retrieve the host and the base URL.
30	*/
31	public abstract class AbstractGitValidator implements GitUrlValidator {	1✔
32
33	/**
34	* Git host (e.g., github.com).
35	*
36	* @return Git host
37	*/
38	protected abstract String host();
39
40	/**
41	* Git repository base URL (e.g., <a href="https://github.com/">...</a><owner>/<repo>.git).
42	*
43	* @param owner owner or organisation
44	* @param repo repository name
45	* @return a string representation of the Git repository base URL
46	*/
47	protected abstract String repoBaseUrl(String owner, String repo);
48
49	@Override
50	public boolean supports(String url) {
51	try {
52	URI uri = URI.create(url);	1✔
53	return host().equalsIgnoreCase(uri.getHost());	1✔
NEW 54	} catch (Exception e) {	×
NEW 55	return false;	×
56	}
57	}
58
59	@Override
60	public GitDetails parse(String url, WorkflowForm form) {
61	final URI uri = URI.create(url);	1✔
62	final String[] parts = uri.getPath().split("/");	1✔
63
64	if (parts.length < 3) return null;	1✔
65
66	final String owner = parts[1];	1✔
67	final String repo = parts[2];	1✔
68
69	final String repoUrl = repoBaseUrl(owner, repo);	1✔
70
71	String branch = form.getBranch();	1✔
72	String path = form.getPath();	1✔
73
74	for (int i = 3; i < parts.length; i++) {	1✔
75	if ("tree".equals(parts[i]) \|\| "blob".equals(parts[i])) {	1✔
76	if (branch == null && i + 1 < parts.length) {	1✔
77	branch = parts[i + 1];	1✔
78	}
79	if (path == null && i + 2 < parts.length) {	1✔
80	path = String.join("/", java.util.Arrays.copyOfRange(parts, i + 2, parts.length));	1✔
81	}
82	break;
83	}
84	}
85
86	return new GitDetails(repoUrl, branch, path);	1✔
87	}
88	}

common-workflow-language / cwlviewer / #1994

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous