25731185144

Committed 12 May 2026 11:21AM UTC coverage: 74.704%. First build

Build # 25731185144

Build Type

Pull #1284

github

Committed by

web-flow

Commit Message

Merge 65bf3a11e into df7c0d57b

Pull Request Pull Request #1284: [SECURITY] Switch from serialized data to json - Please update ASAP

Coverage Stats

4 of 5 new or added lines in 2 files covered. (80.0%)

1958 of 2621 relevant lines covered (74.7%)

3.71 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

81.48

/Classes/Middleware/CrawlerInitialization.php

<?php

declare(strict_types=1);

namespace AOE\Crawler\Middleware;

/*
 * (c) 2020 AOE GmbH <dev@aoe.com>
 *
 * This file is part of the TYPO3 Crawler Extension.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use TYPO3\CMS\Core\Context\Context;
use TYPO3\CMS\Core\Http\Response;
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
 * Evaluates HTTP headers and checks if Crawler should register itself.
 * Needs to be run after TSFE initialization AND Frontend User Authentication.
 *
 * Once done, the queue is fetched, and then the frontend request runs through.
 *
 * Finally, at the very end, if the crawler is still running, output the data and replace the response.
 */
class CrawlerInitialization implements MiddlewareInterface
{
    /**
     * @var Context
     */
    protected $context;

    public function __construct(?Context $context = null)
    {
        $this->context = $context ?? GeneralUtility::makeInstance(Context::class);
    }

    /**
     * @throws \TYPO3\CMS\Core\Context\Exception\AspectNotFoundException
     * @throws \TYPO3\CMS\Core\Error\Http\ServiceUnavailableException
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $queueParameters = $request->getAttribute('tx_crawler');
        if ($queueParameters === null) {
            return $handler->handle($request);
        }

        $GLOBALS['TSFE']->applicationData['forceIndexing'] = true;
        $GLOBALS['TSFE']->applicationData['tx_crawler']['running'] = true;
        $GLOBALS['TSFE']->applicationData['tx_crawler']['parameters'] = $queueParameters;
        $GLOBALS['TSFE']->applicationData['tx_crawler']['log'] = [
            'User Groups: ' . ($queueParameters['feUserGroupList'] ?? ''),
        ];

        // Execute the frontend request as is
        $response = $handler->handle($request);

        $GLOBALS['TSFE']->applicationData['tx_crawler']['vars'] = [
            'id' => $GLOBALS['TSFE']->id,
            'gr_list' => implode(',', $this->context->getAspect('frontend.user')->getGroupIds()),
            'no_cache' => $GLOBALS['TSFE']->no_cache,
        ];

        $this->runPollSuccessHooks();

        // Send log data for crawler (serialized content)
        $data = json_encode($GLOBALS['TSFE']->applicationData['tx_crawler']);
        if ($data !== false) {
            return $response->withHeader('X-T3Crawler-Meta', $data);
        }
        return $response;
    }

    /**
     * Required because some extensions (staticpub) might never be requested to run due to some Core side effects
     * and since this is considered as error the crawler should handle it properly
     */
    protected function runPollSuccessHooks(): void
    {
        if (! is_array($GLOBALS['TSFE']->applicationData['tx_crawler']['content']['parameters']['procInstructions'] ?? false)) {
            return;
        }
        foreach ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['crawler']['pollSuccess'] ?? [] as $pollable) {
            if (in_array($pollable, $GLOBALS['TSFE']->applicationData['tx_crawler']['content']['parameters']['procInstructions'], true)) {
                if (empty($GLOBALS['TSFE']->applicationData['tx_crawler']['success'][$pollable])) {
                    $GLOBALS['TSFE']->applicationData['tx_crawler']['errorlog'][] = 'Error: Pollable extension (' . $pollable . ') did not complete successfully.';
                }
            }
        }
    }
}

1	<?php
2
3	declare(strict_types=1);
4
5	namespace AOE\Crawler\Middleware;
6
7	/*
8	* (c) 2020 AOE GmbH <dev@aoe.com>
9	*
10	* This file is part of the TYPO3 Crawler Extension.
11	*
12	* It is free software; you can redistribute it and/or modify it under
13	* the terms of the GNU General Public License, either version 2
14	* of the License, or any later version.
15	*
16	* For the full copyright and license information, please read the
17	* LICENSE.txt file that was distributed with this source code.
18	*
19	* The TYPO3 project - inspiring people to share!
20	*/
21
22	use Psr\Http\Message\ResponseInterface;
23	use Psr\Http\Message\ServerRequestInterface;
24	use Psr\Http\Server\MiddlewareInterface;
25	use Psr\Http\Server\RequestHandlerInterface;
26	use TYPO3\CMS\Core\Context\Context;
27	use TYPO3\CMS\Core\Http\Response;
28	use TYPO3\CMS\Core\Utility\GeneralUtility;
29
30	/**
31	* Evaluates HTTP headers and checks if Crawler should register itself.
32	* Needs to be run after TSFE initialization AND Frontend User Authentication.
33	*
34	* Once done, the queue is fetched, and then the frontend request runs through.
35	*
36	* Finally, at the very end, if the crawler is still running, output the data and replace the response.
37	*/
38	class CrawlerInitialization implements MiddlewareInterface
39	{
40	/**
41	* @var Context
42	*/
43	protected $context;
44
45	public function __construct(?Context $context = null)
46	{
47	$this->context = $context ?? GeneralUtility::makeInstance(Context::class);	2✔
48	}
49
50	/**
51	* @throws \TYPO3\CMS\Core\Context\Exception\AspectNotFoundException
52	* @throws \TYPO3\CMS\Core\Error\Http\ServiceUnavailableException
53	*/
54	public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
55	{
56	$queueParameters = $request->getAttribute('tx_crawler');	3✔
57	if ($queueParameters === null) {	3✔
58	return $handler->handle($request);	1✔
59	}
60
61	$GLOBALS['TSFE']->applicationData['forceIndexing'] = true;	2✔
62	$GLOBALS['TSFE']->applicationData['tx_crawler']['running'] = true;	2✔
63	$GLOBALS['TSFE']->applicationData['tx_crawler']['parameters'] = $queueParameters;	2✔
64	$GLOBALS['TSFE']->applicationData['tx_crawler']['log'] = [	2✔
65	'User Groups: ' . ($queueParameters['feUserGroupList'] ?? ''),	2✔
66	];	2✔
67
68	// Execute the frontend request as is
69	$response = $handler->handle($request);	2✔
70
71	$GLOBALS['TSFE']->applicationData['tx_crawler']['vars'] = [	2✔
72	'id' => $GLOBALS['TSFE']->id,	2✔
73	'gr_list' => implode(',', $this->context->getAspect('frontend.user')->getGroupIds()),	2✔
74	'no_cache' => $GLOBALS['TSFE']->no_cache,	2✔
75	];	2✔
76
77	$this->runPollSuccessHooks();	2✔
78
79	// Send log data for crawler (serialized content)
80	$data = json_encode($GLOBALS['TSFE']->applicationData['tx_crawler']);	2✔
81	if ($data !== false) {	2✔
82	return $response->withHeader('X-T3Crawler-Meta', $data);	2✔
83	}
NEW 84	return $response;	×
85	}
86
87	/**
88	* Required because some extensions (staticpub) might never be requested to run due to some Core side effects
89	* and since this is considered as error the crawler should handle it properly
90	*/
91	protected function runPollSuccessHooks(): void
92	{
93	if (! is_array($GLOBALS['TSFE']->applicationData['tx_crawler']['content']['parameters']['procInstructions'] ?? false)) {	2✔
94	return;	2✔
95	}
96	foreach ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['crawler']['pollSuccess'] ?? [] as $pollable) {	×
97	if (in_array($pollable, $GLOBALS['TSFE']->applicationData['tx_crawler']['content']['parameters']['procInstructions'], true)) {	×
98	if (empty($GLOBALS['TSFE']->applicationData['tx_crawler']['success'][$pollable])) {	×
99	$GLOBALS['TSFE']->applicationData['tx_crawler']['errorlog'][] = 'Error: Pollable extension (' . $pollable . ') did not complete successfully.';	×
100	}
101	}
102	}
103	}
104	}

tomasnorre / crawler / 25731185144

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous