#3416

Committed 12 May 2026 03:59AM UTC coverage: 75.525% (-19.9%) from 95.406%

Build # #3416

Build Type

Pull #3493

screwdriver

Committed by

web-flow

Commit Message

Merge branch 'master' into fix_event_meta_update

Pull Request Pull Request #3493: fix: Exclusive control over meta updates

Coverage Stats

1703 of 2430 branches covered (70.08%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

1057 existing lines in 57 files now uncovered.

4376 of 5619 relevant lines covered (77.88%)

106.75 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

20.69

/plugins/pipelines/syncWebhooks.js

'use strict';

const boom = require('@hapi/boom');
const joi = require('joi');
const schema = require('screwdriver-data-schema');
const idSchema = schema.models.pipeline.base.extract('id');
const { getUserPermissions, getScmUri } = require('../helper');

module.exports = () => ({
    method: 'POST',
    path: '/pipelines/{id}/sync/webhooks',
    options: {
        description: 'Add webhooks or update webhooks if already exists',
        notes: 'Add or update Screwdriver API webhooks',
        tags: ['api', 'pipelines'],
        auth: {
            strategies: ['token'],
            scope: ['user', '!guest']
        },

        handler: async (request, h) => {
            const { id } = request.params;
            const { pipelineFactory, userFactory } = request.server.app;
            const { username, scmContext, scope } = request.auth.credentials;

            // Fetch the pipeline and user models
            const [pipeline, user] = await Promise.all([
                pipelineFactory.get(id),
                userFactory.get({ username, scmContext })
            ]);

            if (!pipeline) {
                throw boom.notFound('Pipeline does not exist');
            }
            if (pipeline.state === 'DELETING') {
                throw boom.conflict('This pipeline is being deleted.');
            }
            if (!user) {
                throw boom.notFound(`User ${username} does not exist`);
            }

            if (!scope.includes('admin')) {
                // Use parent's scmUri if pipeline is child pipeline and using read-only SCM
                const scmUri = await getScmUri({ pipeline, pipelineFactory });

                // Check the user's permission
                await getUserPermissions({ user, scmUri, level: 'push' });
            }

            // user has good permissions, add or update webhooks
            await pipeline.addWebhooks(`${request.server.info.uri}/v4/webhooks`);

            return h.response().code(204);
        },
        validate: {
            params: joi.object({
                id: idSchema
            })
        }
    }
});

1	'use strict';
2
3	const boom = require('@hapi/boom');	1✔
4	const joi = require('joi');	1✔
5	const schema = require('screwdriver-data-schema');	1✔
6	const idSchema = schema.models.pipeline.base.extract('id');	1✔
7	const { getUserPermissions, getScmUri } = require('../helper');	1✔
8
9	module.exports = () => ({	393✔
10	method: 'POST',
11	path: '/pipelines/{id}/sync/webhooks',
12	options: {
13	description: 'Add webhooks or update webhooks if already exists',
14	notes: 'Add or update Screwdriver API webhooks',
15	tags: ['api', 'pipelines'],
16	auth: {
17	strategies: ['token'],
18	scope: ['user', '!guest']
19	},
20
21	handler: async (request, h) => {
UNCOV 22	const { id } = request.params;	×
UNCOV 23	const { pipelineFactory, userFactory } = request.server.app;	×
UNCOV 24	const { username, scmContext, scope } = request.auth.credentials;	×
25
26	// Fetch the pipeline and user models
UNCOV 27	const [pipeline, user] = await Promise.all([	×
28	pipelineFactory.get(id),
29	userFactory.get({ username, scmContext })
30	]);
31
UNCOV 32	if (!pipeline) {	×
UNCOV 33	throw boom.notFound('Pipeline does not exist');	×
34	}
UNCOV 35	if (pipeline.state === 'DELETING') {	×
UNCOV 36	throw boom.conflict('This pipeline is being deleted.');	×
37	}
UNCOV 38	if (!user) {	×
UNCOV 39	throw boom.notFound(`User ${username} does not exist`);	×
40	}
41
UNCOV 42	if (!scope.includes('admin')) {	×
43	// Use parent's scmUri if pipeline is child pipeline and using read-only SCM
UNCOV 44	const scmUri = await getScmUri({ pipeline, pipelineFactory });	×
45
46	// Check the user's permission
UNCOV 47	await getUserPermissions({ user, scmUri, level: 'push' });	×
48	}
49
50	// user has good permissions, add or update webhooks
UNCOV 51	await pipeline.addWebhooks(`${request.server.info.uri}/v4/webhooks`);	×
52
UNCOV 53	return h.response().code(204);	×
54	},
55	validate: {
56	params: joi.object({
57	id: idSchema
58	})
59	}
60	}
61	});

screwdriver-cd / screwdriver / #3416

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous