#3412

Committed 12 May 2026 12:11AM UTC coverage: 75.519% (-19.9%) from 95.405%

Build # #3412

Build Type

Pull #3493

screwdriver

Committed by

web-flow

Commit Message

Merge branch 'master' into fix_event_meta_update

Pull Request Pull Request #3493: fix: Exclusive control over meta updates

Coverage Stats

1703 of 2430 branches covered (70.08%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

1057 existing lines in 57 files now uncovered.

4374 of 5617 relevant lines covered (77.87%)

106.76 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

27.27

/plugins/secrets/get.js

'use strict';

const boom = require('@hapi/boom');
const joi = require('joi');
const schema = require('screwdriver-data-schema');
const getSchema = schema.models.secret.get;
const idSchema = schema.models.secret.base.extract('id');

module.exports = () => ({
    method: 'GET',
    path: '/secrets/{id}',
    options: {
        description: 'Get a single secret',
        notes: 'Returns a secret record',
        tags: ['api', 'secrets'],
        auth: {
            strategies: ['token'],
            scope: ['user', 'build', '!guest']
        },

        handler: async (request, h) => {
            const { secretFactory } = request.server.app;
            const { credentials } = request.auth;
            const { canAccess } = request.server.plugins.secrets;

            return secretFactory
                .get(request.params.id)
                .then(secret => {
                    if (!secret) {
                        throw boom.notFound('Secret does not exist');
                    }

                    return canAccess(credentials, secret, 'push', request.server.app).then(showSecret => {
                        const output = secret.toJson();

                        if (!showSecret) {
                            delete output.value;
                        }

                        return h.response(output);
                    });
                })
                .catch(err => {
                    throw err;
                });
        },
        response: {
            schema: getSchema
        },
        validate: {
            params: joi.object({
                id: idSchema
            })
        }
    }
});

1	'use strict';
2
3	const boom = require('@hapi/boom');	1✔
4	const joi = require('joi');	1✔
5	const schema = require('screwdriver-data-schema');	1✔
6	const getSchema = schema.models.secret.get;	1✔
7	const idSchema = schema.models.secret.base.extract('id');	1✔
8
9	module.exports = () => ({	1✔
10	method: 'GET',
11	path: '/secrets/{id}',
12	options: {
13	description: 'Get a single secret',
14	notes: 'Returns a secret record',
15	tags: ['api', 'secrets'],
16	auth: {
17	strategies: ['token'],
18	scope: ['user', 'build', '!guest']
19	},
20
21	handler: async (request, h) => {
UNCOV 22	const { secretFactory } = request.server.app;	×
UNCOV 23	const { credentials } = request.auth;	×
UNCOV 24	const { canAccess } = request.server.plugins.secrets;	×
25
UNCOV 26	return secretFactory	×
27	.get(request.params.id)
28	.then(secret => {
UNCOV 29	if (!secret) {	×
UNCOV 30	throw boom.notFound('Secret does not exist');	×
31	}
32
UNCOV 33	return canAccess(credentials, secret, 'push', request.server.app).then(showSecret => {	×
UNCOV 34	const output = secret.toJson();	×
35
UNCOV 36	if (!showSecret) {	×
UNCOV 37	delete output.value;	×
38	}
39
UNCOV 40	return h.response(output);	×
41	});
42	})
43	.catch(err => {
UNCOV 44	throw err;	×
45	});
46	},
47	response: {
48	schema: getSchema
49	},
50	validate: {
51	params: joi.object({
52	id: idSchema
53	})
54	}
55	}
56	});

screwdriver-cd / screwdriver / #3412

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous