• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

opendefensecloud / artifact-conduit / 25523720375

07 May 2026 09:42PM UTC coverage: 84.483% (+0.1%) from 84.375%
25523720375

Pull #346

github

web-flow
Merge 8c7fe6cda into b1f18c553
Pull Request #346: chore(deps): update dependency go to v1.26.3

784 of 928 relevant lines covered (84.48%)

542.03 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.16
/pkg/controller/order_controller.go
1
// Copyright 2025 BWI GmbH and Artifact Conduit contributors
2
// SPDX-License-Identifier: Apache-2.0
3

4
package controller
5

6
import (
7
        "context"
8
        "crypto/sha256"
9
        "encoding/hex"
10
        "encoding/json"
11
        "fmt"
12
        "slices"
13
        "time"
14

15
        "github.com/go-logr/logr"
16
        corev1 "k8s.io/api/core/v1"
17
        apierrors "k8s.io/apimachinery/pkg/api/errors"
18
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
19
        "k8s.io/apimachinery/pkg/runtime"
20
        "k8s.io/apimachinery/pkg/types"
21
        "k8s.io/client-go/tools/events"
22
        ctrl "sigs.k8s.io/controller-runtime"
23
        "sigs.k8s.io/controller-runtime/pkg/client"
24
        "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
25

26
        arcv1alpha1 "go.opendefense.cloud/arc/api/arc/v1alpha1"
27
)
28

29
const (
30
        orderFinalizer = "arc.opendefense.cloud/order-finalizer"
31
)
32

33
// OrderReconciler reconciles a Order object
34
type OrderReconciler struct {
35
        client.Client
36
        Scheme   *runtime.Scheme
37
        Recorder events.EventRecorder
38
}
39

40
type desiredAW struct {
41
        index       int
42
        objectMeta  metav1.ObjectMeta
43
        artifact    *arcv1alpha1.OrderArtifact
44
        typeSpec    *arcv1alpha1.ArtifactTypeSpec
45
        srcEndpoint *arcv1alpha1.Endpoint
46
        dstEndpoint *arcv1alpha1.Endpoint
47
        srcSecret   *corev1.Secret
48
        dstSecret   *corev1.Secret
49
        sha         string
50
        cron        *arcv1alpha1.Cron
51
}
52

53
//+kubebuilder:rbac:groups=arc.opendefense.cloud,resources=endpoints,verbs=get;list;watch
54
//+kubebuilder:rbac:groups=arc.opendefense.cloud,resources=artifacttypes,verbs=get;list;watch
55
//+kubebuilder:rbac:groups=arc.opendefense.cloud,resources=clusterartifacttypes,verbs=get;list;watch
56
//+kubebuilder:rbac:groups=arc.opendefense.cloud,resources=artifactworkflows,verbs=get;list;watch;create;update;patch;delete
57
//+kubebuilder:rbac:groups=arc.opendefense.cloud,resources=orders,verbs=get;list;watch;create;update;patch;delete
58
//+kubebuilder:rbac:groups=arc.opendefense.cloud,resources=orders/status,verbs=get;update;patch
59
//+kubebuilder:rbac:groups=arc.opendefense.cloud,resources=orders/finalizers,verbs=update
60
//+kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch;create;update;patch;delete
61
// +kubebuilder:rbac:groups=core,resources=events,verbs=create;patch
62

63
// Reconcile moves the current state of the cluster closer to the desired state
64
func (r *OrderReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
1,230✔
65
        log := ctrl.LoggerFrom(ctx)
1,230✔
66
        ctrlResult := ctrl.Result{}
1,230✔
67

1,230✔
68
        // Fetch the Order instance
1,230✔
69
        order := &arcv1alpha1.Order{}
1,230✔
70
        if err := r.Get(ctx, req.NamespacedName, order); err != nil {
1,232✔
71
                if apierrors.IsNotFound(err) {
4✔
72
                        // Object not found, return. Created objects are automatically garbage collected.
2✔
73
                        return ctrlResult, nil
2✔
74
                }
2✔
75

76
                return ctrlResult, errLogAndWrap(log, err, "failed to get object")
×
77
        }
78

79
        // Update last reconcile time
80
        order.Status.LastReconcileAt = metav1.Now()
1,228✔
81

1,228✔
82
        // Handle deletion: cleanup artifact workflows, then remove finalizer
1,228✔
83
        if !order.DeletionTimestamp.IsZero() {
1,230✔
84
                log.V(1).Info("Order is being deleted")
2✔
85
                r.Recorder.Eventf(order, nil, corev1.EventTypeWarning, "Deleting", "Delete", "Order is being deleted, cleaning up artifact workflows")
2✔
86

2✔
87
                // Cleanup all artifact workflows
2✔
88
                if len(order.Status.ArtifactWorkflows) > 0 {
3✔
89
                        for sha := range order.Status.ArtifactWorkflows {
3✔
90
                                // Remove ArtifactWorkflow
2✔
91
                                aw := &arcv1alpha1.ArtifactWorkflow{
2✔
92
                                        ObjectMeta: awObjectMeta(order, sha),
2✔
93
                                }
2✔
94
                                _ = r.Delete(ctx, aw) // Ignore errors
2✔
95
                                delete(order.Status.ArtifactWorkflows, sha)
2✔
96
                        }
2✔
97
                        if err := r.Status().Update(ctx, order); err != nil {
1✔
98
                                return ctrlResult, errLogAndWrap(log, err, "failed to update order status")
×
99
                        }
×
100
                        log.V(1).Info("Order artifact workflows cleaned up")
1✔
101

1✔
102
                        // Requeue until all artifact workflows are gone
1✔
103
                        return ctrlResult, nil
1✔
104
                }
105
                // All artifact workflows are gone, remove finalizer
106
                if slices.Contains(order.Finalizers, orderFinalizer) {
2✔
107
                        log.V(1).Info("No artifact workflows, removing finalizer from Order")
1✔
108
                        order.Finalizers = slices.DeleteFunc(order.Finalizers, func(f string) bool {
2✔
109
                                return f == orderFinalizer
1✔
110
                        })
1✔
111
                        if err := r.Update(ctx, order); err != nil {
1✔
112
                                return ctrlResult, errLogAndWrap(log, err, "failed to remove finalizer")
×
113
                        }
×
114
                }
115

116
                return ctrlResult, nil
1✔
117
        }
118

119
        // Add finalizer if not present and not deleting
120
        if order.DeletionTimestamp.IsZero() {
2,452✔
121
                if !slices.Contains(order.Finalizers, orderFinalizer) {
1,246✔
122
                        log.V(1).Info("Adding finalizer to Order")
20✔
123
                        order.Finalizers = append(order.Finalizers, orderFinalizer)
20✔
124
                        if err := r.Update(ctx, order); err != nil {
20✔
125
                                return ctrlResult, errLogAndWrap(log, err, "failed to add finalizer")
×
126
                        }
×
127
                        // Return without requeue; the Update event will trigger reconciliation again
128
                        return ctrlResult, nil
20✔
129
                }
130
        }
131

132
        // Handle force reconcile annotation
133
        forceAt, err := GetForceAtAnnotationValue(order)
1,206✔
134
        if err != nil {
1,206✔
135
                log.V(1).Error(err, "Invalid force reconcile annotation, ignoring")
×
136
        }
×
137
        if !forceAt.IsZero() && (order.Status.LastForceAt.IsZero() || forceAt.After(order.Status.LastForceAt.Time)) {
1,207✔
138
                log.V(1).Info("Force reconcile requested")
1✔
139
                r.Recorder.Eventf(order, nil, corev1.EventTypeNormal, "ForceReconcile", "Reconcile", "Force reconcile requested via annotation")
1✔
140
                // Delete existing artifact workflows to force re-creation
1✔
141
                for sha := range order.Status.ArtifactWorkflows {
2✔
142
                        // Remove Secret and ArtifactWorkflow
1✔
143
                        aw := &arcv1alpha1.ArtifactWorkflow{
1✔
144
                                ObjectMeta: awObjectMeta(order, sha),
1✔
145
                        }
1✔
146
                        _ = r.Delete(ctx, aw) // Ignore errors
1✔
147
                        delete(order.Status.ArtifactWorkflows, sha)
1✔
148
                        r.Recorder.Eventf(order, aw, corev1.EventTypeNormal, "ForceReconcile", "Reconcile", "Deleted artifact workflow '%s' with sha %s", aw.Name, sha)
1✔
149
                }
1✔
150
                // Update last force time
151
                order.Status.LastForceAt = metav1.Now()
1✔
152
                if err := r.Status().Update(ctx, order); err != nil {
1✔
153
                        return ctrlResult, errLogAndWrap(log, err, "failed to update last force time")
×
154
                }
×
155
                // Return without requeue; the update event will trigger reconciliation again
156
                return ctrlResult, nil
1✔
157
        }
158

159
        // Make sure status is initialized
160
        if order.Status.ArtifactWorkflows == nil {
1,310✔
161
                order.Status.ArtifactWorkflows = map[string]arcv1alpha1.OrderArtifactWorkflowStatus{}
105✔
162
        }
105✔
163

164
        // Before we compare to our status, let's fetch all necessary information
165
        // to compute desired state:
166
        desiredAWs := map[string]desiredAW{}
1,205✔
167
        for i, artifact := range order.Spec.Artifacts {
2,981✔
168
                daw, err := r.computeDesiredAW(ctx, log, order, &artifact, i)
1,776✔
169
                if err != nil {
1,905✔
170
                        r.Recorder.Eventf(order, nil, corev1.EventTypeWarning, "ComputationFailed", "Compute", "Failed to compute desired artifact workflow for artifact index %d: %v", i, err)
129✔
171
                        order.Status.Message = fmt.Sprintf("Failed to compute desired artifact workflow for artifact index %d: %v", i, err)
129✔
172
                        if err := r.Status().Update(ctx, order); err != nil {
129✔
173
                                return ctrlResult, errLogAndWrap(log, err, "failed to update status")
×
174
                        }
×
175

176
                        return ctrlResult, errLogAndWrap(log, err, "failed to compute desired artifact workflow")
129✔
177
                }
178
                desiredAWs[daw.sha] = *daw
1,647✔
179
        }
180
        order.Status.Message = "" // Clear any previous error message
1,076✔
181

1,076✔
182
        // List missing artifact workflows
1,076✔
183
        var createAWs []string
1,076✔
184
        for sha := range desiredAWs {
2,718✔
185
                if _, exists := order.Status.ArtifactWorkflows[sha]; exists {
3,253✔
186
                        continue
1,611✔
187
                }
188

189
                createAWs = append(createAWs, sha)
31✔
190
        }
191

192
        // Find obsolete artifact workflows
193
        var deleteAWs []string
1,076✔
194
        for sha := range order.Status.ArtifactWorkflows {
2,688✔
195
                if _, exists := desiredAWs[sha]; exists {
3,223✔
196
                        continue
1,611✔
197
                }
198

199
                deleteAWs = append(deleteAWs, sha)
1✔
200
        }
201

202
        // Find finished artifact workflows to clean up
203
        var finishedAWs []string
1,076✔
204
        for sha := range order.Status.ArtifactWorkflows {
2,688✔
205
                awStatus := order.Status.ArtifactWorkflows[sha]
1,612✔
206

1,612✔
207
                // Do not clean up ArtifactWorkflows with cron specified
1,612✔
208
                if daw, ok := desiredAWs[sha]; ok && daw.cron != nil {
1,615✔
209
                        continue
3✔
210
                }
211

212
                // Do not clean up workflows that are still running or pending
213
                switch awStatus.Phase {
1,609✔
214
                case arcv1alpha1.WorkflowSucceeded:
41✔
215
                case arcv1alpha1.WorkflowFailed:
×
216
                case arcv1alpha1.WorkflowError:
4✔
217
                default:
1,564✔
218
                        continue
1,564✔
219
                }
220

221
                // Get ArtifactWorkflow object and check TTLs.
222
                artifactWorkflow := &arcv1alpha1.ArtifactWorkflow{}
45✔
223
                if err := r.Get(ctx, types.NamespacedName{Namespace: order.Namespace, Name: awName(order, sha)}, artifactWorkflow); err != nil && !apierrors.IsNotFound(err) {
45✔
224
                        r.Recorder.Eventf(order, nil, corev1.EventTypeWarning, "Invalid", "Fetch", "Failed to fetch ArtifactWorkflow: %v", sha)
×
225
                        return ctrlResult, errLogAndWrap(log, err, "")
×
226
                }
×
227
                if artifactWorkflow.Name != "" {
53✔
228
                        // Cleanup finished workflows if TTLAfterFinished is set.
8✔
229
                        if awStatus.Phase == arcv1alpha1.WorkflowSucceeded {
13✔
230
                                // If TTL is set, check if it has expired
5✔
231
                                if artifactWorkflow.Spec.TTLAfterFinished != nil {
8✔
232
                                        if artifactWorkflow.Spec.TTLAfterFinished.Seconds() == 0 {
3✔
233
                                                // If TTL is zero keep the workflow.
×
234
                                                continue
×
235
                                        }
236
                                        if time.Since(awStatus.CompletionTime.Time) < artifactWorkflow.Spec.TTLAfterFinished.Duration {
4✔
237
                                                // If TTL is set but not expired keep the workflow.
1✔
238
                                                // Requeue when the next TTL expires
1✔
239
                                                ctrlResult.RequeueAfter = artifactWorkflow.Spec.TTLAfterFinished.Duration - time.Since(awStatus.CompletionTime.Time)
1✔
240
                                                continue
1✔
241
                                        }
242
                                }
243
                        }
244

245
                        // Cleanup failed workflows if TTLAfterFailed is set.
246
                        if awStatus.Phase == arcv1alpha1.WorkflowFailed || awStatus.Phase == arcv1alpha1.WorkflowError {
10✔
247
                                // If TTL is set, check if it has expired
3✔
248
                                if artifactWorkflow.Spec.TTLAfterFailed != nil {
6✔
249
                                        if artifactWorkflow.Spec.TTLAfterFailed.Seconds() == 0 {
3✔
250
                                                // If TTL is zero keep the workflow.
×
251
                                                continue
×
252
                                        }
253
                                        if time.Since(awStatus.FailureTime.Time) < artifactWorkflow.Spec.TTLAfterFailed.Duration {
4✔
254
                                                // If TTL is set but not expired keep the workflow.
1✔
255
                                                ctrlResult.RequeueAfter = artifactWorkflow.Spec.TTLAfterFailed.Duration - time.Since(awStatus.FailureTime.Time)
1✔
256
                                                continue
1✔
257
                                        }
258
                                } else {
×
259
                                        // If no TTL is set keep the workflow.
×
260
                                        continue
×
261
                                }
262
                        }
263
                }
264

265
                // Cleanup finished or not existing workflows
266
                finishedAWs = append(finishedAWs, sha)
43✔
267
        }
268

269
        // Create missing artifact workflows
270
        for _, sha := range createAWs {
1,107✔
271
                daw := desiredAWs[sha]
31✔
272
                aw, err := r.hydrateArtifactWorkflow(&daw)
31✔
273
                if err != nil {
31✔
274
                        r.Recorder.Eventf(order, nil, corev1.EventTypeWarning, "HydrationFailed", "Hydrate", "Failed to hydrate artifact workflow for artifact index %d: %v", daw.index, err)
×
275
                        return ctrlResult, errLogAndWrap(log, err, "failed to hydrate artifact workflow")
×
276
                }
×
277

278
                // Set owner references
279
                if err := controllerutil.SetControllerReference(order, aw, r.Scheme); err != nil {
31✔
280
                        r.Recorder.Eventf(order, aw, corev1.EventTypeWarning, "HydrationFailed", "Hydrate", "Failed to set controller reference for artifact workflow: %v", err)
×
281
                        return ctrlResult, errLogAndWrap(log, err, "failed to set controller reference")
×
282
                }
×
283

284
                // Create artifact workflow
285
                if err := r.Create(ctx, aw); err != nil {
39✔
286
                        if apierrors.IsAlreadyExists(err) {
16✔
287
                                // Already created by a previous reconcile — that's fine
8✔
288
                                continue
8✔
289
                        }
290
                        r.Recorder.Eventf(order, nil, corev1.EventTypeWarning, "CreationFailed", "Create", "Failed to create artifact workflow for artifact index %d: %v", daw.index, err)
×
291

×
292
                        return ctrlResult, errLogAndWrap(log, err, "failed to create artifact workflow")
×
293
                } else {
23✔
294
                        r.Recorder.Eventf(order, aw, corev1.EventTypeNormal, "Created", "Create", "Created artifact workflow '%s' for artifact index %d", aw.Name, daw.index)
23✔
295
                        log.V(1).Info("Created artifact workflow", "artifactWorkflow", aw.Name)
23✔
296
                }
23✔
297

298
                // Update status
299
                order.Status.ArtifactWorkflows[sha] = arcv1alpha1.OrderArtifactWorkflowStatus{
23✔
300
                        ArtifactIndex: daw.index,
23✔
301
                        WorkflowStatus: arcv1alpha1.WorkflowStatus{
23✔
302
                                Phase: arcv1alpha1.WorkflowUnknown,
23✔
303
                        },
23✔
304
                }
23✔
305
        }
306

307
        // Delete obsolete artifact workflows
308
        for _, sha := range deleteAWs {
1,077✔
309
                // Does not exist anymore, let's clean up!
1✔
310
                aw := &arcv1alpha1.ArtifactWorkflow{
1✔
311
                        ObjectMeta: awObjectMeta(order, sha),
1✔
312
                }
1✔
313
                if err := r.Delete(ctx, aw); client.IgnoreNotFound(err) != nil {
1✔
314
                        r.Recorder.Eventf(order, aw, corev1.EventTypeWarning, "DeletionFailed", "Delete", "Failed to delete obsolete artifact workflow '%s': %v", sha, err)
×
315
                        return ctrlResult, errLogAndWrap(log, err, "failed to delete artifact workflow")
×
316
                }
×
317

318
                // Update status
319
                delete(order.Status.ArtifactWorkflows, sha)
1✔
320
                log.V(1).Info("Deleted obsolete artifact workflow", "artifactWorkflow", sha)
1✔
321
                r.Recorder.Eventf(order, aw, corev1.EventTypeNormal, "Deleted", "Delete", "Deleted obsolete artifact workflow '%s'", sha)
1✔
322
        }
323

324
        // Delete finished artifact workflows
325
        for _, sha := range finishedAWs {
1,119✔
326
                // Finished, let's clean up!
43✔
327
                aw := &arcv1alpha1.ArtifactWorkflow{
43✔
328
                        ObjectMeta: awObjectMeta(order, sha),
43✔
329
                }
43✔
330
                if err := r.Delete(ctx, aw); client.IgnoreNotFound(err) != nil {
43✔
331
                        r.Recorder.Eventf(order, aw, corev1.EventTypeWarning, "DeletionFailed", "Delete", "Failed to delete finished artifact workflow '%s': %v", sha, err)
×
332
                        return ctrlResult, errLogAndWrap(log, err, "failed to delete artifact workflow")
×
333
                }
×
334

335
                log.V(1).Info("Deleted finished artifact workflow", "artifactWorkflow", sha)
43✔
336
                r.Recorder.Eventf(order, aw, corev1.EventTypeNormal, "Deleted", "Delete", "Deleted finished artifact workflow '%s'", sha)
43✔
337
        }
338

339
        anyPhaseChanged := false
1,076✔
340
        for sha, daw := range desiredAWs {
2,718✔
341
                if slices.Contains(createAWs, sha) {
1,673✔
342
                        // If it was just created we skip the update
31✔
343
                        continue
31✔
344
                }
345
                if daw.cron == nil && order.Status.ArtifactWorkflows[sha].Phase.Completed() {
1,656✔
346
                        // We do not need to check for updates if the workflow is completed and is NOT cron
45✔
347
                        continue
45✔
348
                }
349
                aw := arcv1alpha1.ArtifactWorkflow{}
1,566✔
350
                if err := r.Get(ctx, namespacedName(daw.objectMeta.Namespace, daw.objectMeta.Name), &aw); err != nil {
1,566✔
351
                        delete(order.Status.ArtifactWorkflows, sha)
×
352
                        log.V(1).Info("Artifact workflow not found, deleting from status.", "artifactWorkflow", sha)
×
353
                        if err := r.Status().Update(ctx, order); err != nil {
×
354
                                return ctrlResult, errLogAndWrap(log, err, "failed to update status")
×
355
                        }
×
356

357
                        return ctrlResult, errLogAndWrap(log, err, "failed to get artifact workflow")
×
358
                }
359
                orderAWStatus := order.Status.ArtifactWorkflows[sha]
1,566✔
360
                if orderAWStatus.Phase != aw.Status.Phase ||
1,566✔
361
                        orderAWStatus.Succeeded != aw.Status.Succeeded ||
1,566✔
362
                        orderAWStatus.Failed != aw.Status.Failed ||
1,566✔
363
                        !orderAWStatus.LastScheduled.Equal(aw.Status.LastScheduled) {
2,204✔
364
                        orderAWStatus.WorkflowStatus = aw.Status.WorkflowStatus
638✔
365
                        order.Status.ArtifactWorkflows[sha] = orderAWStatus
638✔
366
                        anyPhaseChanged = true
638✔
367
                }
638✔
368
        }
369

370
        // Update status
371
        if len(createAWs) > 0 || len(deleteAWs) > 0 || anyPhaseChanged {
1,709✔
372
                log.V(1).Info("Updating order status")
633✔
373
                // Make sure ArtifactIndex is up to date
633✔
374
                for sha, daw := range desiredAWs {
1,617✔
375
                        aws := order.Status.ArtifactWorkflows[sha]
984✔
376
                        aws.ArtifactIndex = daw.index
984✔
377
                        order.Status.ArtifactWorkflows[sha] = aws
984✔
378
                }
984✔
379
                if err := r.Status().Update(ctx, order); err != nil {
665✔
380
                        return ctrlResult, errLogAndWrap(log, err, "failed to update status")
32✔
381
                }
32✔
382
        }
383

384
        return ctrlResult, nil
1,044✔
385
}
386

387
func (r *OrderReconciler) hydrateArtifactWorkflow(daw *desiredAW) (*arcv1alpha1.ArtifactWorkflow, error) {
31✔
388
        params, err := dawToParameters(daw)
31✔
389
        if err != nil {
31✔
390
                return nil, err
×
391
        }
×
392

393
        // Next we create the ArtifactWorkflow instance
394
        aw := &arcv1alpha1.ArtifactWorkflow{
31✔
395
                ObjectMeta: daw.objectMeta,
31✔
396
                Spec: arcv1alpha1.ArtifactWorkflowSpec{
31✔
397
                        WorkflowTemplateRef:         daw.typeSpec.WorkflowTemplateRef,
31✔
398
                        Parameters:                  params,
31✔
399
                        SrcSecretRef:                daw.srcEndpoint.Spec.SecretRef,
31✔
400
                        DstSecretRef:                daw.dstEndpoint.Spec.SecretRef,
31✔
401
                        Cron:                        daw.cron,
31✔
402
                        ArtifactWorkflowTTLSettings: daw.typeSpec.ArtifactWorkflowTTLSettings,
31✔
403
                },
31✔
404
        }
31✔
405

31✔
406
        return aw, nil
31✔
407
}
408

409
func (r *OrderReconciler) computeDesiredAW(ctx context.Context, log logr.Logger, order *arcv1alpha1.Order, artifact *arcv1alpha1.OrderArtifact, i int) (*desiredAW, error) {
1,776✔
410
        log = log.WithValues("artifactIndex", i)
1,776✔
411

1,776✔
412
        // We need the referenced src- and dst-endpoints for the artifact
1,776✔
413
        srcRefName := artifact.SrcRef.Name
1,776✔
414
        if srcRefName == "" {
1,991✔
415
                srcRefName = order.Spec.Defaults.SrcRef.Name
215✔
416
        }
215✔
417
        dstRefName := artifact.DstRef.Name
1,776✔
418
        if dstRefName == "" {
2,056✔
419
                dstRefName = order.Spec.Defaults.DstRef.Name
280✔
420
        }
280✔
421

422
        srcEndpoint := &arcv1alpha1.Endpoint{}
1,776✔
423
        if err := r.Get(ctx, namespacedName(order.Namespace, srcRefName), srcEndpoint); err != nil {
1,790✔
424
                r.Recorder.Eventf(order, nil, corev1.EventTypeWarning, "InvalidEndpoint", "FetchEndpoint", "Failed to fetch source endpoint '%s': %v", srcRefName, err)
14✔
425
                return nil, errLogAndWrap(log, err, "failed to fetch endpoint for source")
14✔
426
        }
14✔
427
        dstEndpoint := &arcv1alpha1.Endpoint{}
1,762✔
428
        if err := r.Get(ctx, namespacedName(order.Namespace, dstRefName), dstEndpoint); err != nil {
1,776✔
429
                r.Recorder.Eventf(order, nil, corev1.EventTypeWarning, "InvalidEndpoint", "FetchEndpoint", "Failed to fetch destination endpoint '%s': %v", dstRefName, err)
14✔
430
                return nil, errLogAndWrap(log, err, "failed to fetch endpoint for destination")
14✔
431
        }
14✔
432

433
        // Validate that the endpoint usage is correct
434
        if srcEndpoint.Spec.Usage != arcv1alpha1.EndpointUsagePullOnly && srcEndpoint.Spec.Usage != arcv1alpha1.EndpointUsageAll {
1,762✔
435
                err := fmt.Errorf("endpoint '%s' usage '%s' is not compatible with source usage", srcEndpoint.Name, srcEndpoint.Spec.Usage)
14✔
436
                r.Recorder.Eventf(order, srcEndpoint, corev1.EventTypeWarning, "InvalidEndpoint", "ValidateEndpoint", "Source endpoint '%s' has incompatible usage '%s'", srcEndpoint.Name, srcEndpoint.Spec.Usage)
14✔
437

14✔
438
                return nil, errLogAndWrap(log, err, "artifact validation failed")
14✔
439
        }
14✔
440
        if dstEndpoint.Spec.Usage != arcv1alpha1.EndpointUsagePushOnly && dstEndpoint.Spec.Usage != arcv1alpha1.EndpointUsageAll {
1,748✔
441
                err := fmt.Errorf("endpoint '%s' usage '%s' is not compatible with destination usage", dstEndpoint.Name, dstEndpoint.Spec.Usage)
14✔
442
                r.Recorder.Eventf(order, dstEndpoint, corev1.EventTypeWarning, "InvalidEndpoint", "ValidateEndpoint", "Destination endpoint '%s' has incompatible usage '%s'", dstEndpoint.Name, dstEndpoint.Spec.Usage)
14✔
443

14✔
444
                return nil, errLogAndWrap(log, err, "artifact validation failed")
14✔
445
        }
14✔
446

447
        // Validate against ArtifactType rules
448
        artifactType := &arcv1alpha1.ArtifactType{}
1,720✔
449
        if err := r.Get(ctx, namespacedName(order.Namespace, artifact.Type), artifactType); client.IgnoreNotFound(err) != nil {
1,720✔
450
                r.Recorder.Eventf(order, nil, corev1.EventTypeWarning, "InvalidArtifactType", "FetchArtifactType", "Failed to fetch ArtifactType '%s': %v", artifact.Type, err)
×
451
                return nil, errLogAndWrap(log, err, "failed to fetch referenced ArtifactType")
×
452
        }
×
453
        var (
1,720✔
454
                artifactTypeGen  int64
1,720✔
455
                artifactTypeSpec *arcv1alpha1.ArtifactTypeSpec
1,720✔
456
        )
1,720✔
457
        if artifactType.Name == "" { // was not found, let's check ClusterArtifactType
3,383✔
458
                clusterArtifactType := &arcv1alpha1.ClusterArtifactType{}
1,663✔
459
                if err := r.Get(ctx, namespacedName("", artifact.Type), clusterArtifactType); err != nil {
1,725✔
460
                        return nil, errLogAndWrap(log, err, "failed to fetch ArtifactType or ClusterArtifactType")
62✔
461
                }
62✔
462
                artifactTypeSpec = &clusterArtifactType.Spec
1,601✔
463
                artifactTypeGen = clusterArtifactType.Generation
1,601✔
464
                // NOTE: ClusterArtifactTypes can only reference ClusterWorkflowTemplates, so we enforce this here:
1,601✔
465
                artifactTypeSpec.WorkflowTemplateRef.ClusterScope = true
1,601✔
466
        } else {
57✔
467
                artifactTypeSpec = &artifactType.Spec
57✔
468
                artifactTypeGen = artifactType.Generation
57✔
469
        }
57✔
470

471
        if len(artifactTypeSpec.Rules.SrcTypes) > 0 && !slices.Contains(artifactTypeSpec.Rules.SrcTypes, srcEndpoint.Spec.Type) {
1,669✔
472
                err := fmt.Errorf("source endpoint type '%s' is not allowed by ArtifactType rules", srcEndpoint.Spec.Type)
11✔
473
                r.Recorder.Eventf(order, artifactType, corev1.EventTypeWarning, "InvalidArtifactType", "ValidateArtifactType", "Source endpoint type '%s' is not allowed by ArtifactType '%s' rules", srcEndpoint.Spec.Type, artifact.Type)
11✔
474

11✔
475
                return nil, errLogAndWrap(log, err, "artifact validation failed")
11✔
476
        }
11✔
477
        if len(artifactTypeSpec.Rules.DstTypes) > 0 && !slices.Contains(artifactTypeSpec.Rules.DstTypes, dstEndpoint.Spec.Type) {
1,647✔
478
                err := fmt.Errorf("destination endpoint type '%s' is not allowed by ArtifactType rules", dstEndpoint.Spec.Type)
×
479
                r.Recorder.Eventf(order, artifactType, corev1.EventTypeWarning, "InvalidArtifactType", "ValidateArtifactType", "Destination endpoint type '%s' is not allowed by ArtifactType '%s' rules", dstEndpoint.Spec.Type, artifact.Type)
×
480

×
481
                return nil, errLogAndWrap(log, err, "artifact validation failed")
×
482
        }
×
483

484
        // Next, we need the secret contents
485
        srcSecret := &corev1.Secret{}
1,647✔
486
        if srcEndpoint.Spec.SecretRef.Name != "" {
3,292✔
487
                if err := r.Get(ctx, namespacedName(order.Namespace, srcEndpoint.Spec.SecretRef.Name), srcSecret); err != nil {
1,645✔
488
                        r.Recorder.Eventf(order, nil, corev1.EventTypeWarning, "InvalidSecret", "FetchSecret", "Failed to fetch source secret '%s': %v", srcEndpoint.Spec.SecretRef.Name, err)
×
489
                        return nil, errLogAndWrap(log, err, "failed to fetch secret for source")
×
490
                }
×
491
        }
492

493
        dstSecret := &corev1.Secret{}
1,647✔
494
        if dstEndpoint.Spec.SecretRef.Name != "" {
3,292✔
495
                if err := r.Get(ctx, namespacedName(order.Namespace, dstEndpoint.Spec.SecretRef.Name), dstSecret); err != nil {
1,645✔
496
                        r.Recorder.Eventf(order, nil, corev1.EventTypeWarning, "InvalidSecret", "FetchSecret", "Failed to fetch destination secret '%s': %v", dstEndpoint.Spec.SecretRef.Name, err)
×
497
                        return nil, errLogAndWrap(log, err, "failed to fetch secret for destination")
×
498
                }
×
499
        }
500

501
        // Cron schedule if any
502
        cron := artifact.Cron
1,647✔
503
        if cron == nil {
3,290✔
504
                cron = order.Spec.Defaults.Cron
1,643✔
505
        }
1,643✔
506

507
        // Create a hash based on all related data for idempotency and compute the workflow name
508
        h := sha256.New()
1,647✔
509
        data := []any{
1,647✔
510
                order.Namespace,
1,647✔
511
                artifact.Type,
1,647✔
512
                artifact.Spec.Raw,
1,647✔
513
                artifactTypeGen,
1,647✔
514
                srcEndpoint.Name,
1,647✔
515
                dstEndpoint.Name,
1,647✔
516
                order.Status.LastForceAt,
1,647✔
517
                cron,
1,647✔
518
        }
1,647✔
519

1,647✔
520
        if err := json.NewEncoder(h).Encode(data); err != nil {
1,647✔
521
                return nil, errLogAndWrap(log, err, "failed to marshal artifact workflow data")
×
522
        }
×
523

524
        sha := hex.EncodeToString(h.Sum(nil))[:16]
1,647✔
525

1,647✔
526
        // We gave all the information to further process this artifact workflow.
1,647✔
527
        // Let's store it to compare it to the current status!
1,647✔
528
        return &desiredAW{
1,647✔
529
                index:       i,
1,647✔
530
                objectMeta:  awObjectMeta(order, sha),
1,647✔
531
                artifact:    artifact,
1,647✔
532
                typeSpec:    artifactTypeSpec,
1,647✔
533
                srcEndpoint: srcEndpoint,
1,647✔
534
                dstEndpoint: dstEndpoint,
1,647✔
535
                srcSecret:   srcSecret,
1,647✔
536
                dstSecret:   dstSecret,
1,647✔
537
                sha:         sha,
1,647✔
538
                cron:        cron,
1,647✔
539
        }, nil
1,647✔
540
}
541

542
// SetupWithManager sets up the controller with the Manager.
543
func (r *OrderReconciler) SetupWithManager(mgr ctrl.Manager) error {
1✔
544
        return ctrl.NewControllerManagedBy(mgr).
1✔
545
                For(&arcv1alpha1.Order{}).
1✔
546
                Owns(&arcv1alpha1.ArtifactWorkflow{}).
1✔
547
                Complete(r)
1✔
548
}
1✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc