ForumMagnum / ForumMagnum / 25463845060

Pull #12497

github

Document the ES indexer's index-everything-filter-at-query-time convention

Add a paragraph to the IndexConfig.filters doc comment so the next person
(or AI agent) touching the search code knows that ForumMagnum indexes
every row regardless of visibility flags and does the filtering here at
query time, not in the SQL export methods.

I half-implemented the alternative pattern earlier on this branch (added
WHERE rejected IS NOT TRUE to the bulk-export queries) and reverted it
in fb9c12f because the per-document update path always re-indexes, so
the filter just creates drift between recreateIndex and steady-state
behavior. Captured the rationale here so the same trap doesn't catch
the next contributor.

7921 of 10714 branches covered (73.93%)

Branch coverage included in aggregate %.

29 of 42 new or added lines in 9 files covered. (69.05%)

177816 of 373127 relevant lines covered (47.66%)

36.53 hits per line