ForumMagnum / ForumMagnum / 25463223484

Pull #12497

github

Revert Elasticsearch bulk-indexer rejected filter

Drop the WHERE "rejected" IS NOT TRUE clauses I added to
PostsRepo/CommentsRepo getSearchDocuments and countSearchDocuments.

The prevailing pattern for the ES index is "index every row, filter
at query time": ElasticConfig.ts strips draft, rejected, deleted,
authorIsUnreviewed, retracted, spam, etc. from search results, while
elasticSyncDocument re-indexes every row on update via
getSearchDocumentById, which has no per-row filter. So filtering at
bulk-export time only created an inconsistent state — rejected posts
disappeared after a recreateIndex but came back the next time they
were updated. The query-time filter already handles it.

7932 of 10726 branches covered (73.95%)

Branch coverage included in aggregate %.

19 of 32 new or added lines in 8 files covered. (59.38%)

177800 of 373117 relevant lines covered (47.65%)

36.54 hits per line