ForumMagnum / ForumMagnum / 25461329847

push

github

Address code review on rejected-content fixes

- Extend postIsPublic to include !rejected. Drop the inline rejected
  layering in removeRedraftNotifications. The other two postIsPublic
  call sites (sendNewPostNotifications, taggedPostNewNotifications)
  also benefit: rejected posts no longer trigger publish or tag-
  subscriber notifications.

- Fix getCommentsWithReacts truncation: previously the rejected filter
  ran on the outer query, so the inner LIMIT could allocate slots to
  rejected comments that were then dropped, returning fewer than `limit`
  rows. Move the filter into the inner subquery via a JOIN to Comments
  so LIMIT applies to non-rejected reactions.

- Standardize the ES indexer queries to "rejected" IS NOT TRUE,
  matching the convention used elsewhere in the diff.

- Use Promise.all in removeCommentNotificationsOnHidden instead of
  fire-and-forget forEach, so the comment update mutation doesn't
  return before notification cleanup completes.

7920 of 10711 branches covered (73.94%)

Branch coverage included in aggregate %.

6 of 15 new or added lines in 5 files covered. (40.0%)

177780 of 373119 relevant lines covered (47.65%)

36.55 hits per line