ForumMagnum / ForumMagnum / 25407457020

push

github

Filter rejected comments and clean up notifications on rejection

In preparation for enabling the rejection feature on EA Forum, fix six
queries that returned rejected comments to public-facing surfaces, fix
two queries that included rejected comments in user-visible counts, and
add notification cleanup so rejecting content also marks the related
inbox notifications as deleted.

Public feed leaks (added rejected filter to SQL):
- getCommentsWithReacts: powers the public CommentsWithReacts paginated
  resolver. A rejected comment with a reaction would surface in the feed.
- getPopularComments: powers the public PopularComments resolver, which
  feeds into the homepage popular-comments rail. A rejected comment with
  high baseScore would surface there.
- getRecentCommentsOnPosts: backstop on the SQL itself, since the result
  goes through accessFilterMultiple/commentCheckAccess and we intentionally
  allow direct-by-id access to rejected comments for the moderation log.

User-visible count leaks (added rejected filter to SQL):
- getCommentsPerDay: per-post engagement chart, was inflating daily counts.
- getAuthorshipStats: Wrapped year-in-review, was inflating both the
  user's count and their percentile.
- getUsersMostCommentedPostSince: inactive-user-summary digest email,
  was inflating the count emailed to users.

Defense-in-depth on the search index:
- CommentsRepo.getSearchDocuments / countSearchDocuments: skip rejected
  comments during bulk Elasticsearch reindex, mirroring the previous
  PostsRepo fix. Query-time filtering in ElasticConfig already excludes
  rejected, so this is hygiene, not a leak fix.

Notification cleanup on hide:
- Extend removeRedraftNotifications to also fire when a post transitions
  from public to rejected (previously it only fired on the redraft
  transition, leaving orphan notifications when a published post was
  rejected).
- Add a parallel removeCommentNotificationsOnHidden callback that fires
  on the public→non-pub... (continued)

288 of 452 branches covered (63.72%)

Branch coverage included in aggregate %.

19 of 29 new or added lines in 6 files covered. (65.52%)

16949 of 36925 relevant lines covered (45.9%)

369.43 hits per line