stacklok / toolhive / 25150085827

push

github

test(e2e): add all-client LLM gateway e2e matrix + fix secret provider bugs (#5116)

* test(e2e): add all-client LLM gateway e2e matrix + fix secret provider bugs

Fixes two bugs discovered while building the new test suite:

1. Add "secret" to informationalCommands so thv secret provider environment
   does not require a container runtime to be available.

2. Fix GetSystemSecretsProvider to call GetProviderType() before checking
   SetupCompleted, so the TOOLHIVE_SECRETS_PROVIDER env var is respected
   when interactive secrets setup has not been completed.

Adds test/e2e/cli_llm_all_clients_test.go with 16 e2e tests (label: llm &&
clients) covering all 6 supported LLM gateway clients, proxy DNS-rebinding
protection, port conflict handling, and 4 edge cases. Tests use an in-process
mock OIDC server and fake browser stubs — no Docker or real credentials needed.

Adds test/llm-mock-env/ for manual end-to-end testing with a local mock OIDC
+ LLM gateway.

Closes #5115

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fixes from review

* fixes from review

---------

Co-authored-by: taskbot <taskbot@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

13 of 23 new or added lines in 3 files covered. (56.52%)

61053 of 95002 relevant lines covered (64.26%)

59.66 hits per line