FlexMeasures / flexmeasures / 25106437250

push

github

Feat/clean up old rolling forecasting code (#2082)

* forecasting: drop legacy rolling job helpers

Context:
- Fixed-viewpoint forecasting is the supported execution path
- Rolling job helpers and horizon tables were left behind in shared utilities

Change:
- Remove legacy rolling forecasting service entry points
- Keep worker exception handling but stop re-enqueueing unsupported fallback jobs
- Delete unused rolling horizon utility helpers

* tests: stop using retired forecasting job factory

Context:
- Some tests still created forecasting jobs through the removed rolling job helper
- These tests only need queue metadata, not rolling-forecast behavior

Change:
- Build forecasting jobs with TrainPredictPipeline in cache/schema tests
- Update assertions to match the supported forecasting queue shape

* tests: replace rolling forecasting job coverage

Context:
- The old forecasting job test modules were centered on removed rolling behavior and fallback chaining
- We still need coverage for queue metadata, failure handling, and successful fixed-viewpoint execution

Change:
- Rewrite forecasting job tests around TrainPredictPipeline jobs
- Verify failed jobs stay failed without spawning fallback jobs
- Keep fresh-db coverage for queued fixed-viewpoint forecasting

* tooling: align forecasting helper with pipeline

Context:
- The developer forecasting helper still queued work through the removed rolling entry point
- Pre-commit also refreshed the generated OpenAPI spec in this branch

Change:
- Switch the manual testing helper to TrainPredictPipeline jobs
- Keep the generated OpenAPI spec in sync

* refactor: remove legacy forecasting CLI helper

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* refactor: remove legacy forecast data seeding path

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* refactor: remove legacy timetomodel model specs

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

... (continued)

5 of 7 new or added lines in 3 files covered. (71.43%)

12206 of 15329 relevant lines covered (79.63%)

0.8 hits per line