• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

systemd / systemd / 25026908423

27 Apr 2026 07:14PM UTC coverage: 71.865% (-0.3%) from 72.175%
25026908423

push

github

daandemeyer
udev: don't assert on worker cap after killing a broken idle worker

manager_can_process_event() considers an event processable if either
there is room below children_max to spawn, or an idle worker exists.
When only the latter holds, event_run() picks the idle worker and
tries device_monitor_send(). If that send fails, event_run() SIGKILLs
the worker, marks it WORKER_KILLED and continues the loop. With no
other idle worker available, it falls through to worker_spawn(),
guarded by:

    assert(hashmap_size(manager->workers) < manager->config.children_max);

The just-killed worker is still in manager->workers until its SIGCHLD
is reaped by on_worker_exit(), so at the cap this assertion trips and
udevd aborts:

    Assertion 'hashmap_size(manager->workers) < manager->config.children_max'
    failed at src/udev/udev-manager.c:635, function event_run(). Aborting.

Instead of asserting, bail out when we are already at the worker
limit. The event remains in EVENT_QUEUED; once the killed worker's
SIGCHLD arrives and frees it from the hashmap, on_post() re-runs
event_queue_start() and the event is retried.

1 of 1 new or added line in 1 file covered. (100.0%)

7309 existing lines in 125 files now uncovered.

322519 of 448782 relevant lines covered (71.87%)

1173939.78 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.0
/src/path/path-tool.c
1
/* SPDX-License-Identifier: LGPL-2.1-or-later */
2

3
#include <stdio.h>
4

5
#include "sd-path.h"
6

7
#include "alloc-util.h"
8
#include "build.h"
9
#include "errno-util.h"
10
#include "format-table.h"
11
#include "log.h"
12
#include "main-func.h"
13
#include "options.h"
14
#include "pager.h"
15
#include "pretty-print.h"
16
#include "sort-util.h"
17
#include "string-util.h"
18
#include "strv.h"
19

20
static const char *arg_suffix = NULL;
21
static PagerFlags arg_pager_flags = 0;
22

23
static const char* const path_table[_SD_PATH_MAX] = {
24
        [SD_PATH_TEMPORARY]                                   = "temporary",
25
        [SD_PATH_TEMPORARY_LARGE]                             = "temporary-large",
26

27
        [SD_PATH_SYSTEM_SEARCH_CONFIGURATION]                 = "system-search-configuration",
28

29
        [SD_PATH_SYSTEM_BINARIES]                             = "system-binaries",
30
        [SD_PATH_SYSTEM_INCLUDE]                              = "system-include",
31
        [SD_PATH_SYSTEM_LIBRARY_PRIVATE]                      = "system-library-private",
32
        [SD_PATH_SYSTEM_LIBRARY_ARCH]                         = "system-library-arch",
33
        [SD_PATH_SYSTEM_SHARED]                               = "system-shared",
34
        [SD_PATH_SYSTEM_CONFIGURATION_FACTORY]                = "system-configuration-factory",
35
        [SD_PATH_SYSTEM_STATE_FACTORY]                        = "system-state-factory",
36

37
        [SD_PATH_SYSTEM_CONFIGURATION]                        = "system-configuration",
38
        [SD_PATH_SYSTEM_RUNTIME]                              = "system-runtime",
39
        [SD_PATH_SYSTEM_RUNTIME_LOGS]                         = "system-runtime-logs",
40
        [SD_PATH_SYSTEM_STATE_PRIVATE]                        = "system-state-private",
41
        [SD_PATH_SYSTEM_STATE_LOGS]                           = "system-state-logs",
42
        [SD_PATH_SYSTEM_STATE_CACHE]                          = "system-state-cache",
43
        [SD_PATH_SYSTEM_STATE_SPOOL]                          = "system-state-spool",
44

45
        [SD_PATH_USER_BINARIES]                               = "user-binaries",
46
        [SD_PATH_USER_LIBRARY_PRIVATE]                        = "user-library-private",
47
        [SD_PATH_USER_LIBRARY_ARCH]                           = "user-library-arch",
48
        [SD_PATH_USER_SHARED]                                 = "user-shared",
49

50
        [SD_PATH_USER_CONFIGURATION]                          = "user-configuration",
51
        [SD_PATH_USER_RUNTIME]                                = "user-runtime",
52
        [SD_PATH_USER_STATE_CACHE]                            = "user-state-cache",
53
        [SD_PATH_USER_STATE_PRIVATE]                          = "user-state-private",
54

55
        [SD_PATH_USER]                                        = "user",
56
        [SD_PATH_USER_DOCUMENTS]                              = "user-documents",
57
        [SD_PATH_USER_MUSIC]                                  = "user-music",
58
        [SD_PATH_USER_PICTURES]                               = "user-pictures",
59
        [SD_PATH_USER_VIDEOS]                                 = "user-videos",
60
        [SD_PATH_USER_DOWNLOAD]                               = "user-download",
61
        [SD_PATH_USER_PUBLIC]                                 = "user-public",
62
        [SD_PATH_USER_TEMPLATES]                              = "user-templates",
63
        [SD_PATH_USER_DESKTOP]                                = "user-desktop",
64
        [SD_PATH_USER_PROJECTS]                               = "user-projects",
65

66
        [SD_PATH_SEARCH_BINARIES]                             = "search-binaries",
67
        [SD_PATH_SEARCH_BINARIES_DEFAULT]                     = "search-binaries-default",
68
        [SD_PATH_SEARCH_LIBRARY_PRIVATE]                      = "search-library-private",
69
        [SD_PATH_SEARCH_LIBRARY_ARCH]                         = "search-library-arch",
70
        [SD_PATH_SEARCH_SHARED]                               = "search-shared",
71
        [SD_PATH_SEARCH_CONFIGURATION_FACTORY]                = "search-configuration-factory",
72
        [SD_PATH_SEARCH_STATE_FACTORY]                        = "search-state-factory",
73
        [SD_PATH_SEARCH_CONFIGURATION]                        = "search-configuration",
74

75
        [SD_PATH_SYSTEMD_UTIL]                                = "systemd-util",
76

77
        [SD_PATH_SYSTEMD_SYSTEM_UNIT]                         = "systemd-system-unit",
78
        [SD_PATH_SYSTEMD_SYSTEM_PRESET]                       = "systemd-system-preset",
79
        [SD_PATH_SYSTEMD_SYSTEM_CONF]                         = "systemd-system-conf",
80
        [SD_PATH_SYSTEMD_USER_UNIT]                           = "systemd-user-unit",
81
        [SD_PATH_SYSTEMD_USER_PRESET]                         = "systemd-user-preset",
82
        [SD_PATH_SYSTEMD_USER_CONF]                           = "systemd-user-conf",
83
        [SD_PATH_SYSTEMD_INITRD_PRESET]                       = "systemd-initrd-preset",
84

85
        [SD_PATH_SYSTEMD_SEARCH_SYSTEM_UNIT]                  = "systemd-search-system-unit",
86
        [SD_PATH_SYSTEMD_SEARCH_USER_UNIT]                    = "systemd-search-user-unit",
87

88
        [SD_PATH_SYSTEMD_SYSTEM_GENERATOR]                    = "systemd-system-generator",
89
        [SD_PATH_SYSTEMD_USER_GENERATOR]                      = "systemd-user-generator",
90
        [SD_PATH_SYSTEMD_SEARCH_SYSTEM_GENERATOR]             = "systemd-search-system-generator",
91
        [SD_PATH_SYSTEMD_SEARCH_USER_GENERATOR]               = "systemd-search-user-generator",
92

93
        [SD_PATH_SYSTEMD_SLEEP]                               = "systemd-sleep",
94
        [SD_PATH_SYSTEMD_SHUTDOWN]                            = "systemd-shutdown",
95

96
        [SD_PATH_TMPFILES]                                    = "tmpfiles",
97
        [SD_PATH_SYSUSERS]                                    = "sysusers",
98
        [SD_PATH_SYSCTL]                                      = "sysctl",
99
        [SD_PATH_BINFMT]                                      = "binfmt",
100
        [SD_PATH_MODULES_LOAD]                                = "modules-load",
101
        [SD_PATH_CATALOG]                                     = "catalog",
102

103
        [SD_PATH_SYSTEMD_SEARCH_NETWORK]                      = "systemd-search-network",
104

105
        [SD_PATH_SYSTEMD_SYSTEM_ENVIRONMENT_GENERATOR]        = "systemd-system-environment-generator",
106
        [SD_PATH_SYSTEMD_USER_ENVIRONMENT_GENERATOR]          = "systemd-user-environment-generator",
107
        [SD_PATH_SYSTEMD_SEARCH_SYSTEM_ENVIRONMENT_GENERATOR] = "systemd-search-system-environment-generator",
108
        [SD_PATH_SYSTEMD_SEARCH_USER_ENVIRONMENT_GENERATOR]   = "systemd-search-user-environment-generator",
109

110
        [SD_PATH_SYSTEM_CREDENTIAL_STORE]                     = "system-credential-store",
111
        [SD_PATH_SYSTEM_SEARCH_CREDENTIAL_STORE]              = "system-search-credential-store",
112
        [SD_PATH_SYSTEM_CREDENTIAL_STORE_ENCRYPTED]           = "system-credential-store-encrypted",
113
        [SD_PATH_SYSTEM_SEARCH_CREDENTIAL_STORE_ENCRYPTED]    = "system-search-credential-store-encrypted",
114
        [SD_PATH_USER_CREDENTIAL_STORE]                       = "user-credential-store",
115
        [SD_PATH_USER_SEARCH_CREDENTIAL_STORE]                = "user-search-credential-store",
116
        [SD_PATH_USER_CREDENTIAL_STORE_ENCRYPTED]             = "user-credential-store-encrypted",
117
        [SD_PATH_USER_SEARCH_CREDENTIAL_STORE_ENCRYPTED]      = "user-search-credential-store-encrypted",
118
};
119

120
static int order_cmp(const size_t *a, const size_t *b) {
372✔
121
        assert(*a < ELEMENTSOF(path_table));
372✔
122
        assert(*b < ELEMENTSOF(path_table));
372✔
123
        return strcmp(path_table[*a], path_table[*b]);
372✔
124
}
125

126
static int list_paths(void) {
1✔
127
        int ret = 0, r;
1✔
128

129
        pager_open(arg_pager_flags);
1✔
130

131
        size_t order[ELEMENTSOF(path_table)];
132

133
        for (size_t i = 0; i < ELEMENTSOF(order); i++)
79✔
134
                order[i] = i;
78✔
135

136
        typesafe_qsort(order, ELEMENTSOF(order), order_cmp);
1✔
137

138
        for (size_t i = 0; i < ELEMENTSOF(order); i++) {
79✔
139
                size_t j = order[i];
78✔
140
                const char *t = ASSERT_PTR(path_table[j]);
78✔
141

142
                _cleanup_free_ char *p = NULL;
78✔
143
                r = sd_path_lookup(j, arg_suffix, &p);
78✔
144
                if (r < 0) {
78✔
145
                        log_full_errno(r == -ENXIO ? LOG_DEBUG : LOG_ERR, r, "Failed to query %s, proceeding: %m", t);
1✔
146
                        if (r != -ENXIO)
1✔
147
                                RET_GATHER(ret, r);
×
148
                        continue;
1✔
149
                }
150

151
                printf("%s%s:%s %s\n", ansi_highlight(), t, ansi_normal(), p);
154✔
152
        }
153

154
        return ret;
1✔
155
}
156

157
static int print_path(const char *n) {
41✔
158
        int r;
41✔
159

160
        for (size_t i = 0; i < ELEMENTSOF(path_table); i++)
1,279✔
161
                if (streq(path_table[i], n)) {
1,277✔
162
                        _cleanup_free_ char *p = NULL;
39✔
163

164
                        r = sd_path_lookup(i, arg_suffix, &p);
39✔
165
                        if (r < 0)
39✔
166
                                return log_error_errno(r, "Failed to query %s: %m", n);
×
167

168
                        printf("%s\n", p);
39✔
169
                        return 0;
170
                }
171

172
        return log_error_errno(SYNTHETIC_ERRNO(EOPNOTSUPP),
2✔
173
                               "Path %s not known.", n);
174
}
175

176
static int help(void) {
1✔
177
        _cleanup_free_ char *link = NULL;
1✔
178
        _cleanup_(table_unrefp) Table *options = NULL;
1✔
179
        int r;
1✔
180

181
        r = terminal_urlify_man("systemd-path", "1", &link);
1✔
182
        if (r < 0)
1✔
183
                return log_oom();
×
184

185
        r = option_parser_get_help_table(&options);
1✔
186
        if (r < 0)
1✔
187
                return r;
188

189
        printf("%s [OPTIONS...] [NAME...]\n\n"
2✔
190
               "%sShow system and user paths.%s\n\n",
191
               program_invocation_short_name,
192
               ansi_highlight(),
193
               ansi_normal());
194

195
        r = table_print_or_warn(options);
1✔
196
        if (r < 0)
1✔
197
                return r;
198

199
        printf("\nSee the %s for details.\n", link);
1✔
200
        return 0;
201
}
202

203
static int parse_argv(int argc, char *argv[], char ***ret_args) {
40✔
204
        assert(argc >= 0);
40✔
205
        assert(argv);
40✔
206

207
        OptionParser opts = { argc, argv };
40✔
208

209
        FOREACH_OPTION(c, &opts, /* on_error= */ return c)
88✔
210
                switch (c) {
10✔
211

212
                OPTION_COMMON_HELP:
1✔
213
                        return help();
1✔
214

215
                OPTION_COMMON_VERSION:
1✔
216
                        return version();
1✔
217

218
                OPTION_LONG("suffix", "SUFFIX", "Suffix to append to paths"):
8✔
219
                        arg_suffix = opts.arg;
8✔
220
                        break;
8✔
221

UNCOV
222
                OPTION_COMMON_NO_PAGER:
×
223
                        arg_pager_flags |= PAGER_DISABLE;
×
224
                        break;
×
225
                }
226

227
        *ret_args = option_parser_get_args(&opts);
37✔
228
        return 1;
37✔
229
}
230

231
static int run(int argc, char* argv[]) {
40✔
232
        int r;
40✔
233

234
        log_setup();
40✔
235

236
        char **args = NULL;
40✔
237
        r = parse_argv(argc, argv, &args);
40✔
238
        if (r <= 0)
40✔
239
                return r;
40✔
240

241
        if (strv_isempty(args))
37✔
242
                return list_paths();
1✔
243

244
        STRV_FOREACH(i, args)
77✔
245
                RET_GATHER(r, print_path(*i));
41✔
246
        return r;
247
}
248

249
DEFINE_MAIN_FUNCTION(run);
40✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc