• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #5034

24 Apr 2026 11:25AM UTC coverage: 73.058%. Remained the same
#5034

push

travis-ci

web-flow
merge: from main to 3.0 branch #35224

merge: from main to 3.0 branch[manual-only]

1336 of 1975 new or added lines in 48 files covered. (67.65%)

14149 existing lines in 164 files now uncovered.

275896 of 377640 relevant lines covered (73.06%)

132944440.29 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

91.7
/source/libs/parser/src/parAuthenticator.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "catalog.h"
17
#include "cmdnodes.h"
18
#include "parInt.h"
19
#include "tconfig.h"
20

21
typedef struct SAuthCxt {
22
  SParseContext*   pParseCxt;
23
  SParseMetaCache* pMetaCache;
24
  int32_t          errCode;
25
  bool             macNruGuaranteed;
26
  bool             macNwdGuaranteed;
27
} SAuthCxt;
28

29
typedef struct SSelectAuthCxt {
30
  SAuthCxt*    pAuthCxt;
31
  SSelectStmt* pSelect;
32
} SSelectAuthCxt;
33

34
typedef struct SAuthRewriteCxt {
35
  STableNode* pTarget;
36
} SAuthRewriteCxt;
37

38
extern SConfig* tsCfg;
39

40
static int32_t authQuery(SAuthCxt* pCxt, SNode* pStmt);
41

42
#ifdef TD_ENTERPRISE
43
static int32_t macCheckBySecLvl(SAuthCxt* pCxt, int8_t secLvl, bool checkNWD) {
10,150✔
44
  if (secLvl < 0) {
10,150✔
45
    // Unset security level: not subject to MAC enforcement
NEW
46
    return TSDB_CODE_SUCCESS;
×
47
  }
48

49
  if (!pCxt->macNruGuaranteed && pCxt->pParseCxt->maxSecLevel < secLvl) {
10,150✔
50
    return TSDB_CODE_MAC_INSUFFICIENT_LEVEL;  // NRU violation
2,450✔
51
  }
52

53
  if (checkNWD && !pCxt->macNwdGuaranteed && pCxt->pParseCxt->minSecLevel > secLvl) {
7,700✔
NEW
54
    return TSDB_CODE_MAC_NO_WRITE_DOWN;  // NWD violation
×
55
  }
56

57
  return TSDB_CODE_SUCCESS;
7,700✔
58
}
59

60
/**
61
 * @brief Lightweight MAC check for table-level operations.
62
 *
63
 * Uses a 3-layer fast-path strategy to avoid expensive metadata fetches
64
 * in the common case where MAC is not actively used:
65
 *   Layer 1: User-level — if user's security range covers all levels, skip entirely.
66
 *   Layer 2: (DB-level — handled in checkAuthByOwner for PRIV_DB_USE, zero extra cost.)
67
 *   Layer 3: Table-level — fetch table meta from cache only when needed.
68
 *
69
 * @param pCxt      Auth context
70
 * @param dbName    Database name
71
 * @param tableName Table name
72
 * @param checkNWD  true for INSERT (needs No-Write-Down), false for SELECT/DELETE (NRU only)
73
 * @return TSDB_CODE_SUCCESS or TSDB_CODE_MAC_INSUFFICIENT_LEVEL
74
 */
75
static int32_t macCheckTableAccess(SAuthCxt* pCxt, const char* dbName, const char* tableName, bool checkNWD) {
26,287,033✔
76
  SParseContext* pParseCxt = pCxt->pParseCxt;
26,287,033✔
77

78
  // Fast-path: MAC not yet activated cluster-wide — skip all checks
79
  if (!pParseCxt->macMode) {
26,287,033✔
80
    return TSDB_CODE_SUCCESS;
26,284,058✔
81
  }
82

83
  // Layer 1: User-level fast-path — skip if user's security range guarantees MAC pass
84
  if (pCxt->macNruGuaranteed && (!checkNWD || pCxt->macNwdGuaranteed)) {
2,975✔
NEW
85
    return TSDB_CODE_SUCCESS;
×
86
  }
87

88
  // Layer 3: Table-level — fetch secLvl from metadata cache
89
  SName name = {0};
2,975✔
90
  toName(pParseCxt->acctId, dbName, tableName, &name);
2,975✔
91
  STableMeta* pTableMeta = NULL;
2,975✔
92
  int32_t     code = getTargetMetaImpl(pParseCxt, pCxt->pMetaCache, &name, &pTableMeta, true);
2,975✔
93
  if (TSDB_CODE_SUCCESS == code && pTableMeta != NULL) {
2,975✔
94
    int8_t secLvl = pTableMeta->secLvl;
2,450✔
95
    taosMemoryFree(pTableMeta);
2,450✔
96
    return macCheckBySecLvl(pCxt, secLvl, checkNWD);
2,450✔
97
  }
98
  return TSDB_CODE_SUCCESS;
525✔
99
}
100
#endif
101

102
static int32_t setUserAuthInfo(SParseContext* pCxt, const char* pDbName, const char* pTabName, EPrivType privType,
3,471,613✔
103
                               EPrivObjType objType, bool isView, bool effective, SUserAuthInfo* pAuth) {
104
  if (effective) {
3,471,613✔
105
    snprintf(pAuth->user, sizeof(pAuth->user), "%s", pCxt->pEffectiveUser ? pCxt->pEffectiveUser : "");
17,956✔
106
    pAuth->userId = pCxt->effectiveUserId;  // TODO: assign the effective user id
17,956✔
107
  } else {
108
    snprintf(pAuth->user, sizeof(pAuth->user), "%s", pCxt->pUser);
3,453,657✔
109
    pAuth->userId = pCxt->userId;
3,453,657✔
110
  }
111

112
  if (NULL == pTabName) {
3,471,613✔
113
    if (pDbName) {
2,419,629✔
114
      int32_t code = tNameSetDbName(&pAuth->tbName, pCxt->acctId, pDbName, strlen(pDbName));
2,193,584✔
115
      if (TSDB_CODE_SUCCESS != code) return code;
2,193,584✔
116
    } else {
117
      pAuth->tbName.acctId = pCxt->acctId;
226,045✔
118
      pAuth->tbName.type = TSDB_SYS_NAME_T;
226,045✔
119
    }
120
  } else {
121
    toName(pCxt->acctId, pDbName, pTabName, &pAuth->tbName);
1,051,984✔
122
  }
123
  pAuth->privType = privType;
3,471,613✔
124
  pAuth->objType = objType;
3,471,613✔
125
  pAuth->isView = isView;
3,471,613✔
126
  return TSDB_CODE_SUCCESS;
3,471,613✔
127
}
128

129
static int32_t checkAuthByOwner(SAuthCxt* pCxt, SUserAuthInfo* pAuthInfo, SUserAuthRes* pAuthRes, bool *recheck) {
2,606,328✔
130
  SParseContext*   pParseCxt = pCxt->pParseCxt;
2,606,328✔
131
  const SPrivInfo* pPrivInfo = privInfoGet(pAuthInfo->privType);
2,606,328✔
132
  if (NULL == pPrivInfo) {
2,606,328✔
133
    return TSDB_CODE_PAR_INTERNAL_ERROR;
788✔
134
  }
135
  int32_t code = 0;
2,605,540✔
136
  if (pPrivInfo->category == PRIV_CATEGORY_OBJECT || pAuthInfo->objType == PRIV_OBJ_DB) {
2,605,540✔
137
    SPrivInfo privInfoDup = *pPrivInfo;
1,915,097✔
138
    if (privInfoDup.objType <= 0) privInfoDup.objType = PRIV_OBJ_DB;
1,915,097✔
139
    switch (privInfoDup.objType) {
1,915,097✔
140
      case PRIV_OBJ_DB: {
1,495,122✔
141
        SDbCfgInfo dbCfgInfo = {0};
1,495,122✔
142
        char       dbFName[TSDB_DB_FNAME_LEN] = {0};
1,495,122✔
143
        (void)tNameGetFullDbName(&pAuthInfo->tbName, dbFName);
1,495,122✔
144
        code = getDbCfgFromCache(pCxt->pMetaCache, dbFName, &dbCfgInfo);
1,495,122✔
145
        if (TSDB_CODE_SUCCESS != code) {
1,495,122✔
146
          return code;
310,944✔
147
        }
148
#ifdef TD_ENTERPRISE
149
        // Layer 2 MAC: DB-level NRU check — piggybacked on already-fetched SDbCfgInfo
150
        // Only for DB_USE to avoid blocking admin ops (ALTER/DROP by SYSSEC)
151
        // Skip when MAC is not yet activated cluster-wide
152
        if (pParseCxt->macMode && pAuthInfo->privType == PRIV_DB_USE && dbCfgInfo.securityLevel > 0 &&
1,419,002✔
153
            pParseCxt->maxSecLevel < (int8_t)dbCfgInfo.securityLevel) {
6,300✔
154
          pAuthRes->pass[pAuthInfo->isView ? AUTH_RES_VIEW : AUTH_RES_BASIC] = false;
1,925✔
155
          return TSDB_CODE_MAC_INSUFFICIENT_LEVEL;
1,925✔
156
        }
157
#endif
158
        // rewrite privilege for audit db
159
        if (dbCfgInfo.isAudit && pAuthInfo->objType == PRIV_OBJ_DB) {
1,417,077✔
UNCOV
160
          if (pAuthInfo->privType == PRIV_DB_USE) {
×
UNCOV
161
            pAuthInfo->useDb = AUTH_OWNED_MASK;
×
UNCOV
162
            if (recheck) *recheck = true;  // recheck since the cached key is changed
×
UNCOV
163
          } else if (pAuthInfo->privType == PRIV_CM_ALTER) {
×
UNCOV
164
            pAuthInfo->privType = PRIV_AUDIT_DB_ALTER;
×
UNCOV
165
            pAuthInfo->objType = PRIV_OBJ_CLUSTER;
×
UNCOV
166
            if (recheck) *recheck = true;  // recheck since the cached key is changed
×
UNCOV
167
          } else if (pAuthInfo->privType == PRIV_CM_DROP) {
×
UNCOV
168
            pAuthInfo->privType = PRIV_AUDIT_DB_DROP;
×
UNCOV
169
            pAuthInfo->objType = PRIV_OBJ_CLUSTER;
×
UNCOV
170
            if (recheck) *recheck = true;  // recheck since the cached key is changed
×
UNCOV
171
          } else if (pAuthInfo->privType == PRIV_TBL_CREATE) {
×
UNCOV
172
            pAuthInfo->privType = PRIV_AUDIT_TBL_CREATE;
×
UNCOV
173
            pAuthInfo->objType = PRIV_OBJ_CLUSTER;
×
UNCOV
174
            if (recheck) *recheck = true;  // recheck since the cached key is changed
×
175
          }
UNCOV
176
          return TSDB_CODE_SUCCESS;
×
177
        }
178
        if (dbCfgInfo.ownerId == pAuthInfo->userId) {
1,417,077✔
179
          pAuthRes->pass[pAuthInfo->isView ? AUTH_RES_VIEW : AUTH_RES_BASIC] = true;
282,820✔
180
          return TSDB_CODE_SUCCESS;
282,820✔
181
        }
182
        break;
1,134,257✔
183
      }
184
      default:
419,975✔
185
        return TSDB_CODE_SUCCESS;
419,975✔
186
    }
187
  }
188
_exit:
690,443✔
189
  return TSDB_CODE_SUCCESS;
1,824,700✔
190
}
191

192
static int32_t checkAuthImpl(SAuthCxt* pCxt, const char* pDbName, const char* pTabName, EPrivType privType,
664,147,881✔
193
                             EPrivObjType objType, SNode** pCond, SArray** pPrivCols, bool isView, bool effective) {
194
  SParseContext* pParseCxt = pCxt->pParseCxt;
664,147,881✔
195
  if (pParseCxt->isSuperUser) {
664,150,203✔
196
    return TSDB_CODE_SUCCESS;
660,686,346✔
197
  }
198

199
  AUTH_RES_TYPE auth_res_type = isView ? AUTH_RES_VIEW : AUTH_RES_BASIC;
3,471,412✔
200
  SUserAuthInfo authInfo = {0};
3,471,412✔
201
  int32_t code = setUserAuthInfo(pCxt->pParseCxt, pDbName, pTabName, privType, objType, isView, effective, &authInfo);
3,471,412✔
202
  if (TSDB_CODE_SUCCESS != code) return code;
3,471,613✔
203
  SUserAuthRes authRes = {0};
3,471,613✔
204
  bool         recheck = false;
3,471,613✔
205
  if (NULL != pCxt->pMetaCache && privType != PRIV_VIEW_SELECT && privType != PRIV_AUDIT_TBL_SELECT) {
3,471,613✔
206
    code = checkAuthByOwner(pCxt, &authInfo, &authRes, &recheck);
2,606,328✔
207
#ifdef TD_ENTERPRISE
208
    // MAC enforcement: do NOT let DAC grants override a MAC NRU/NWD block
209
    if (code == TSDB_CODE_MAC_INSUFFICIENT_LEVEL || code == TSDB_CODE_MAC_NO_WRITE_DOWN) {
2,606,328✔
210
      return code;
1,925✔
211
    }
212
#endif
213
    if (code == TSDB_CODE_SUCCESS && authRes.pass[auth_res_type]) {
2,604,403✔
214
      goto _exit;
282,820✔
215
    }
216
    code = getUserAuthFromCache(pCxt->pMetaCache, &authInfo, &authRes);
2,321,583✔
217
#ifdef TD_ENTERPRISE
218
    if (isView && TSDB_CODE_PAR_INTERNAL_ERROR == code) {
2,321,583✔
UNCOV
219
      authInfo.isView = false;
×
UNCOV
220
      code = getUserAuthFromCache(pCxt->pMetaCache, &authInfo, &authRes);
×
221
    }
222
#endif
223
  } else {
224
    recheck = true;  // recheck since the cached key is changed
865,285✔
225
  }
226
  if (recheck) {  // the priv type of view and audit may be rewritten, need to recheck from catalog
3,186,868✔
227
    SRequestConnInfo conn = {.pTrans = pParseCxt->pTransporter,
904,656✔
228
                             .requestId = pParseCxt->requestId,
865,285✔
229
                             .requestObjRefId = pParseCxt->requestRid,
865,285✔
230
                             .mgmtEps = pParseCxt->mgmtEpSet};
231
    code = catalogChkAuth(pParseCxt->pCatalog, &conn, &authInfo, &authRes);
865,285✔
232
  }
233

234
_exit:
2,408,950✔
235
  if (TSDB_CODE_SUCCESS == code) {
3,469,688✔
236
    if (pCond) *pCond = authRes.pCond[auth_res_type];
3,469,688✔
237
    if (pPrivCols) *pPrivCols = authRes.pCols;
3,469,688✔
238
    if (taosArrayGetSize(authRes.pCols) > 0) {
3,469,688✔
239
      pCxt->pParseCxt->hasPrivCols = 1; // used later in translateCheckPrivCols for select *
6,568✔
240
    }
241
  }
242
  return TSDB_CODE_SUCCESS == code ? (authRes.pass[auth_res_type] ? TSDB_CODE_SUCCESS : TSDB_CODE_PAR_PERMISSION_DENIED)
3,469,688✔
243
                                   : code;
5,818,750✔
244
}
245

246
static int32_t checkAuth(SAuthCxt* pCxt, const char* pDbName, const char* pTabName, EPrivType privType,
663,898,883✔
247
                         EPrivObjType objType, SNode** pCond, SArray** pPrivCols) {
248
#ifdef TD_ENTERPRISE
249
  return checkAuthImpl(pCxt, pDbName, pTabName, privType, objType, pCond, pPrivCols, false, false);
663,898,883✔
250
#else
251
  return TSDB_CODE_SUCCESS;
252
#endif
253
}
254

255
static int32_t authSysPrivileges(SAuthCxt* pCxt, SNode* pStmt, EPrivType type) {
5,799,981✔
256
  return checkAuth(pCxt, NULL, NULL, type, 0, NULL, NULL);
5,799,981✔
257
}
258

259
static int32_t authObjPrivileges(SAuthCxt* pCxt, const char* pDbName, const char* pTabName, EPrivType privType,
323,291,406✔
260
                                 EPrivObjType objType) {
261
  if (!pDbName) {
323,291,406✔
UNCOV
262
    return TSDB_CODE_PAR_INTERNAL_ERROR;
×
263
  }
264

265
  return checkAuth(pCxt, pDbName, pTabName, privType, objType, NULL, NULL);
323,291,406✔
266
}
267

268
// Checks DB_USE privilege and maps non-MAC errors to PAR_DB_USE_PERMISSION_DENIED.
269
// Callers use PAR_ERR_RET(checkDbUseAuth(pCxt, dbName)) for the common pattern.
270
static int32_t checkDbUseAuth(SAuthCxt* pCxt, const char* pDbName) {
298,013,190✔
271
  int32_t code = checkAuth(pCxt, pDbName, NULL, PRIV_DB_USE, PRIV_OBJ_DB, NULL, NULL);
298,013,190✔
272
#ifdef TD_ENTERPRISE
273
  if (code == TSDB_CODE_MAC_INSUFFICIENT_LEVEL || code == TSDB_CODE_MAC_NO_WRITE_DOWN) return code;
297,996,833✔
274
#endif
275
  return code == TSDB_CODE_SUCCESS ? TSDB_CODE_SUCCESS : TSDB_CODE_PAR_DB_USE_PERMISSION_DENIED;
297,997,734✔
276
}
277

278
static int32_t checkEffectiveAuth(SAuthCxt* pCxt, const char* pDbName, const char* pTabName, EPrivType privType,
15,216✔
279
                                  EPrivObjType objType, SNode** pCond) {
280
  return checkAuthImpl(pCxt, pDbName, pTabName, privType, objType, NULL, NULL, false, true);
15,216✔
281
}
282

283
static int32_t checkViewAuth(SAuthCxt* pCxt, const char* pDbName, const char* pTabName, EPrivType privType,
241,818✔
284
                             EPrivObjType objType, SNode** pCond) {
285
  return checkAuthImpl(pCxt, pDbName, pTabName, privType, objType, pCond, NULL, true, false);
241,818✔
286
}
287

288
static int32_t checkViewEffectiveAuth(SAuthCxt* pCxt, const char* pDbName, const char* pTabName, EPrivType privType,
2,740✔
289
                                      EPrivObjType objType, SNode** pCond) {
290
  return checkAuthImpl(pCxt, pDbName, pTabName, privType, objType, pCond, NULL, true, true);
2,740✔
291
}
292

293
static EDealRes authSubquery(SAuthCxt* pCxt, SNode* pStmt) {
25,142,993✔
294
  return TSDB_CODE_SUCCESS == authQuery(pCxt, pStmt) ? DEAL_RES_CONTINUE : DEAL_RES_ERROR;
25,142,993✔
295
}
296

297
static int32_t mergeStableTagCond(SNode** pWhere, SNode* pTagCond) {
530✔
298
  SLogicConditionNode* pLogicCond = NULL;
530✔
299
  int32_t              code = nodesMakeNode(QUERY_NODE_LOGIC_CONDITION, (SNode**)&pLogicCond);
530✔
300
  if (NULL == pLogicCond) {
530✔
UNCOV
301
    return code;
×
302
  }
303
  pLogicCond->node.resType.type = TSDB_DATA_TYPE_BOOL;
530✔
304
  pLogicCond->node.resType.bytes = tDataTypes[TSDB_DATA_TYPE_BOOL].bytes;
530✔
305
  pLogicCond->condType = LOGIC_COND_TYPE_AND;
530✔
306
  code = nodesListMakeStrictAppend(&pLogicCond->pParameterList, pTagCond);
530✔
307
  if (TSDB_CODE_SUCCESS == code) {
530✔
308
    code = nodesListMakeAppend(&pLogicCond->pParameterList, *pWhere);
530✔
309
  }
310
  if (TSDB_CODE_SUCCESS == code) {
530✔
311
    *pWhere = (SNode*)pLogicCond;
530✔
312
  } else {
UNCOV
313
    nodesDestroyNode((SNode*)pLogicCond);
×
314
  }
315
  return code;
530✔
316
}
317

318
EDealRes rewriteAuthTable(SNode* pNode, void* pContext) {
57,581✔
319
  if (QUERY_NODE_COLUMN == nodeType(pNode)) {
57,581✔
320
    SColumnNode*     pCol = (SColumnNode*)pNode;
17,515✔
321
    SAuthRewriteCxt* pCxt = (SAuthRewriteCxt*)pContext;
17,515✔
322
    tstrncpy(pCol->tableName, pCxt->pTarget->tableName, TSDB_TABLE_NAME_LEN);
17,515✔
323
    tstrncpy(pCol->tableAlias, pCxt->pTarget->tableAlias, TSDB_TABLE_NAME_LEN);
17,515✔
324
    pCol->appendByPrivCond = 1;
17,515✔
325
  }
326

327
  return DEAL_RES_CONTINUE;
57,581✔
328
}
329

330
static int32_t rewriteAppendStableTagCond(SNode** pWhere, SNode* pTagCond, STableNode* pTable) {
12,479✔
331
  SNode*  pTagCondCopy = NULL;
12,479✔
332
  int32_t code = nodesCloneNode(pTagCond, &pTagCondCopy);
12,479✔
333
  if (NULL == pTagCondCopy) {
12,479✔
UNCOV
334
    return code;
×
335
  }
336

337
  SAuthRewriteCxt cxt = {.pTarget = pTable};
12,479✔
338
  nodesWalkExpr(pTagCondCopy, rewriteAuthTable, &cxt);
12,479✔
339

340
  if (NULL == *pWhere) {
12,479✔
341
    *pWhere = pTagCondCopy;
11,772✔
342
    return TSDB_CODE_SUCCESS;
11,772✔
343
  }
344

345
  if (QUERY_NODE_LOGIC_CONDITION == nodeType(*pWhere) &&
707✔
346
      LOGIC_COND_TYPE_AND == ((SLogicConditionNode*)*pWhere)->condType) {
177✔
347
    return nodesListStrictAppend(((SLogicConditionNode*)*pWhere)->pParameterList, pTagCondCopy);
177✔
348
  }
349

350
  return mergeStableTagCond(pWhere, pTagCondCopy);
530✔
351
}
352
#if 0
353
/**
354
 * @brief Fast fail path if no star(*) specified in select clause
355
 */
356
static int32_t authSelectTblCols(SSelectStmt* pSelect, STableNode* pTable, SArray* pPrivCols) {
357
  int32_t    code = 0;
358
  SNodeList* pRetrievedCols = NULL;
359
  int32_t    nCols = taosArrayGetSize(pPrivCols);
360

361
  if (nCols <= 0) {
362
    goto _return;
363
  }
364

365
  PAR_ERR_JRET(nodesCollectColumns(pSelect, SQL_CLAUSE_FROM, NULL, COLLECT_COL_TYPE_ALL, &pRetrievedCols));
366

367
  int32_t i = 0, j = 0, k = 0;
368
  SNode*  pNode = NULL;
369
  FOREACH(pNode, pRetrievedCols) {
370
    SColumnNode* pColNode = (SColumnNode*)pNode;
371

372
    j = i;
373

374
    // search in the remaining columns first for better performance if ordered
375
    bool found = false;
376
    for (; i < nCols; ++i) {
377
      SColNameFlag* pColNameFlag = (SColNameFlag*)TARRAY_GET_ELEM(pPrivCols, i);
378
      if (strcmp(pColNode->colName, pColNameFlag->colName) == 0) {
379
        found = true;
380
        ++i;
381
        break;
382
      }
383
    }
384
    if (!found) {
385
      for (k = 0; k < j; ++k) {
386
        SColNameFlag* pColNameFlag = (SColNameFlag*)TARRAY_GET_ELEM(pPrivCols, k);
387
        if (strcmp(pColNode->colName, pColNameFlag->colName) == 0) {
388
          found = true;
389
          break;
390
        }
391
      }
392
    }
393
    if (!found) {
394
      code = TSDB_CODE_PAR_COL_PERMISSION_DENIED;
395
      goto _return;
396
    }
397
  }
398
_return:
399
  nodesDestroyList(pRetrievedCols);
400
  return code;
401
}
402
#endif
403

404
static EDealRes authSelectImpl(SNode* pNode, void* pContext) {
2,089,383,812✔
405
  SSelectAuthCxt* pCxt = pContext;
2,089,383,812✔
406
  SAuthCxt*       pAuthCxt = pCxt->pAuthCxt;
2,089,383,812✔
407
  bool            isView = false;
2,089,383,808✔
408
  bool            isAudit = false;
2,089,383,808✔
409
  if (QUERY_NODE_REAL_TABLE == nodeType(pNode)) {
2,089,383,808✔
410
    SNode*      pTagCond = NULL;
209,277,954✔
411
    // SArray*     pPrivCols = NULL;
412
    STableNode* pTable = (STableNode*)pNode;
209,278,479✔
413
    if ((pAuthCxt->pParseCxt->enableSysInfo == 0) && IS_INFORMATION_SCHEMA_DB(pTable->dbName) &&
209,278,479✔
414
        (strcmp(pTable->tableName, TSDB_INS_TABLE_VGROUPS) == 0)) {
23,048✔
415
      pAuthCxt->errCode = TSDB_CODE_PAR_PERMISSION_DENIED;
736✔
416
      return DEAL_RES_ERROR;
736✔
417
    }
418
    int32_t dbUseCode = checkDbUseAuth(pAuthCxt, pTable->dbName);
209,277,680✔
419
    if (dbUseCode != TSDB_CODE_SUCCESS) {
209,275,858✔
420
      pAuthCxt->errCode = dbUseCode;
5,553✔
421
      return DEAL_RES_ERROR;
5,553✔
422
    }
423
#ifdef TD_ENTERPRISE
424
    SName name = {0};
209,270,305✔
425
    toName(pAuthCxt->pParseCxt->acctId, pTable->dbName, pTable->tableName, &name);
209,271,171✔
426
    STableMeta* pTableMeta = NULL;
209,271,677✔
427
    int32_t code = getTargetMetaImpl(pAuthCxt->pParseCxt, pAuthCxt->pMetaCache, &name, &pTableMeta, true);
209,271,746✔
428
    if (TSDB_CODE_SUCCESS == code) {
209,271,973✔
429
      // MAC NRU: user.maxSecLevel must be >= table.securityLevel for SELECT.
430
      // Reuse secLvl from this already-fetched table meta to avoid extra metadata round-trips.
431
      if (pAuthCxt->pParseCxt->macMode && macCheckBySecLvl(pAuthCxt, pTableMeta->secLvl, false) != TSDB_CODE_SUCCESS) {
208,764,102✔
432
        taosMemoryFree(pTableMeta);
1,575✔
433
        pAuthCxt->errCode = TSDB_CODE_MAC_INSUFFICIENT_LEVEL;
1,575✔
434
        return DEAL_RES_ERROR;
1,575✔
435
      }
436
      if (pTableMeta->isAudit) {
208,762,718✔
437
        isAudit = true;
840✔
438
      } else if (!pTableMeta->isAudit && (pTableMeta->ownerId == pAuthCxt->pParseCxt->userId)) {
208,761,900✔
439
        // owner has all privileges on the table he owns except audit table
440
        taosMemoryFree(pTableMeta);
202,263,656✔
441
        return DEAL_RES_CONTINUE;
202,262,509✔
442
      }
443
      if (TSDB_VIEW_TABLE == pTableMeta->tableType) {
6,498,990✔
444
        isView = true;
60,811✔
445
      }
446
    }
447
    taosMemoryFree(pTableMeta);
7,006,843✔
448
#endif
449
    if (!isView) {
7,006,875✔
450
      pAuthCxt->errCode =
6,946,064✔
451
          checkAuth(pAuthCxt, pTable->dbName, pTable->tableName, isAudit ? PRIV_AUDIT_TBL_SELECT : PRIV_TBL_SELECT,
6,946,064✔
452
                    PRIV_OBJ_TBL, &pTagCond, NULL);  //&pPrivCols);
453
      if (TSDB_CODE_SUCCESS != pAuthCxt->errCode && NULL != pAuthCxt->pParseCxt->pEffectiveUser) {
6,946,064✔
454
        pAuthCxt->errCode = checkEffectiveAuth(pAuthCxt, pTable->dbName, pTable->tableName,
15,216✔
455
                                               isAudit ? PRIV_AUDIT_TBL_SELECT : PRIV_TBL_SELECT, PRIV_OBJ_TBL, NULL);
456
      }
457
#if 0
458
      if (TSDB_CODE_SUCCESS == pAuthCxt->errCode && NULL != pPrivCols) {
459
        pAuthCxt->errCode = authSelectTblCols(pCxt->pSelect, pTable, pPrivCols);
460
      }
461
#endif
462
      if (TSDB_CODE_SUCCESS == pAuthCxt->errCode && NULL != pTagCond) {
6,946,064✔
463
        pAuthCxt->errCode = rewriteAppendStableTagCond(&pCxt->pSelect->pWhere, pTagCond, pTable);
12,479✔
464
      }
465
    } else {
466
      pAuthCxt->errCode =
60,811✔
467
          checkViewAuth(pAuthCxt, pTable->dbName, pTable->tableName, PRIV_VIEW_SELECT, PRIV_OBJ_VIEW, NULL);
60,811✔
468
      if (TSDB_CODE_SUCCESS != pAuthCxt->errCode && NULL != pAuthCxt->pParseCxt->pEffectiveUser) {
60,811✔
469
        pAuthCxt->errCode =
2,740✔
470
            checkViewEffectiveAuth(pAuthCxt, pTable->dbName, pTable->tableName, PRIV_VIEW_SELECT, PRIV_OBJ_VIEW, NULL);
2,740✔
471
      }
472
    }
473
    return TSDB_CODE_SUCCESS == pAuthCxt->errCode ? DEAL_RES_CONTINUE : DEAL_RES_ERROR;
7,006,875✔
474
  } else if (QUERY_NODE_TEMP_TABLE == nodeType(pNode)) {
1,880,106,140✔
475
    return authSubquery(pAuthCxt, ((STempTableNode*)pNode)->pSubquery);
25,143,067✔
476
  }
477
  return DEAL_RES_CONTINUE;
1,854,963,026✔
478
}
479

480
static int32_t authSelect(SAuthCxt* pCxt, SSelectStmt* pSelect) {
222,854,368✔
481
  SSelectAuthCxt cxt = {.pAuthCxt = pCxt, .pSelect = pSelect};
222,854,368✔
482
  nodesWalkSelectStmt(pSelect, SQL_CLAUSE_FROM, authSelectImpl, &cxt);
222,854,939✔
483
  return pCxt->errCode;
222,854,911✔
484
}
485

486
static int32_t authSetOperator(SAuthCxt* pCxt, SSetOperator* pSetOper) {
9,853,887✔
487
  int32_t code = authQuery(pCxt, pSetOper->pLeft);
9,853,887✔
488
  if (TSDB_CODE_SUCCESS == code) {
9,853,887✔
489
    code = authQuery(pCxt, pSetOper->pRight);
9,851,469✔
490
  }
491
  return code;
9,853,887✔
492
}
493

494
static int32_t authDropUser(SAuthCxt* pCxt, SDropUserStmt* pStmt) {
59,545✔
495
  // if (!pCxt->pParseCxt->isSuperUser || 0 == strcmp(pStmt->userName, TSDB_DEFAULT_USER)) {
496
  //   return TSDB_CODE_PAR_PERMISSION_DENIED;
497
  // }
498
  if (0 == strcmp(pStmt->userName, TSDB_DEFAULT_USER)) {
59,545✔
499
    return TSDB_CODE_PAR_PERMISSION_DENIED;
190✔
500
  }
501
  return authSysPrivileges(pCxt, (void*)pStmt, PRIV_USER_DROP);  // root has SYSDBA role with USER_DROP privilege
59,355✔
502
}
503

504
static int32_t authDelete(SAuthCxt* pCxt, SDeleteStmt* pDelete) {
1,972,441✔
505
  SNode*      pTagCond = NULL;
1,972,441✔
506
  STableNode* pTable = (STableNode*)pDelete->pFromTable;
1,972,441✔
507
  int32_t     code = checkDbUseAuth(pCxt, pTable->dbName);
1,972,441✔
508
  if (TSDB_CODE_SUCCESS == code) {
1,972,441✔
509
    code = checkAuth(pCxt, pTable->dbName, pTable->tableName, PRIV_TBL_DELETE, PRIV_OBJ_TBL, &pTagCond, NULL);
1,972,266✔
510
  }
511
#ifdef TD_ENTERPRISE
512
  // MAC clearance check: user.maxSecLevel must be >= table.secLvl for DELETE
513
  if (TSDB_CODE_SUCCESS == code) {
1,972,441✔
514
    code = macCheckTableAccess(pCxt, pTable->dbName, pTable->tableName, false);
1,971,751✔
515
  }
516
#endif
517
  if (TSDB_CODE_SUCCESS == code && NULL != pTagCond) {
1,972,441✔
UNCOV
518
    code = rewriteAppendStableTagCond(&pDelete->pWhere, pTagCond, pTable);
×
519
  }
520
  return code;
1,972,441✔
521
}
522

523
static int32_t authInsert(SAuthCxt* pCxt, SInsertStmt* pInsert) {
507,794✔
524
  SNode*      pTagCond = NULL;
507,794✔
525
  SArray*     pPrivCols = NULL;
507,794✔
526
  STableNode* pTable = (STableNode*)pInsert->pTable;
507,794✔
527
  // todo check tag condition for subtable
528
  int32_t code = checkDbUseAuth(pCxt, pTable->dbName);
507,794✔
529
  if (TSDB_CODE_SUCCESS == code) {
507,794✔
530
    code = checkAuth(pCxt, pTable->dbName, pTable->tableName, PRIV_TBL_INSERT, PRIV_OBJ_TBL, &pTagCond, &pPrivCols);
507,794✔
531
  }
532
#ifdef TD_ENTERPRISE
533
  // MAC NWD+NRU: for INSERT, user.minSecLevel <= table.secLvl <= user.maxSecLevel
534
  if (TSDB_CODE_SUCCESS == code) {
507,794✔
535
    code = macCheckTableAccess(pCxt, pTable->dbName, pTable->tableName, true);
507,794✔
536
  }
537
#endif
538
  return code;
507,794✔
539
}
540

541
static int32_t authShowTables(SAuthCxt* pCxt, SShowStmt* pStmt) {
602,769✔
542
  // return checkAuth(pCxt, ((SValueNode*)pStmt->pDbName)->literal, NULL, AUTH_TYPE_READ_OR_WRITE, NULL);
543
  // stb: more check in server, child table(TODO): more check when filter query result
544
  PAR_ERR_RET(checkDbUseAuth(pCxt, ((SValueNode*)pStmt->pDbName)->literal));
602,769✔
545
  return 0;
597,580✔
546
}
547

548
static int32_t authShowVtables(SAuthCxt* pCxt, SShowStmt* pStmt) { return authShowTables(pCxt, pStmt); }
64,455✔
549

550
static int32_t authShowUsage(SAuthCxt* pCxt, SShowStmt* pStmt) {
364✔
551
  PAR_ERR_RET(checkDbUseAuth(pCxt, ((SValueNode*)pStmt->pDbName)->literal));
364✔
552
  return 0;
364✔
553
}
554

555
static int32_t authShowCreateTable(SAuthCxt* pCxt, SShowCreateTableStmt* pStmt) {
104,641✔
556
  // SNode* pTagCond = NULL;
557
  // todo check tag condition for subtable
558
  // return checkAuth(pCxt, pStmt->dbName, pStmt->tableName, AUTH_TYPE_READ, &pTagCond);
559
  PAR_ERR_RET(checkDbUseAuth(pCxt, pStmt->dbName));
104,641✔
560
#ifdef TD_ENTERPRISE
561
  // MAC NRU: table-level check — user.maxSecLevel must be >= table.securityLevel
562
  PAR_ERR_RET(macCheckTableAccess(pCxt, pStmt->dbName, pStmt->tableName, false));
100,602✔
563
#endif
564
  return authObjPrivileges(pCxt, pStmt->dbName, pStmt->tableName, PRIV_CM_SHOW_CREATE, PRIV_OBJ_TBL);
100,602✔
565
}
566

567
static int32_t authShowCreateView(SAuthCxt* pCxt, SShowCreateViewStmt* pStmt) {
8,849✔
568
#ifndef TD_ENTERPRISE
569
  return TSDB_CODE_OPS_NOT_SUPPORT;
570
#else
571
  int32_t code = checkDbUseAuth(pCxt, ((SShowCreateViewStmt*)pStmt)->dbName);
8,849✔
572
  if (TSDB_CODE_SUCCESS == code) {
8,849✔
573
    code = checkViewAuth(pCxt, ((SShowCreateViewStmt*)pStmt)->dbName, ((SShowCreateViewStmt*)pStmt)->viewName,
8,849✔
574
                         PRIV_CM_SHOW_CREATE, PRIV_OBJ_VIEW, NULL);
575
  }
576
  if (code == 0) pStmt->hasPrivilege = true;
8,849✔
577
  return 0;  // return 0 and check owner later in translateShowCreateView
8,849✔
578
#endif
579
}
580

581
static int32_t authCreateTable(SAuthCxt* pCxt, SCreateTableStmt* pStmt) {
9,748,023✔
582
  // SNode* pTagCond = NULL;
583
  // todo check tag condition for subtable
584
  // return checkAuth(pCxt, pStmt->dbName, NULL, AUTH_TYPE_WRITE, &pTagCond);
585
  PAR_ERR_RET(checkDbUseAuth(pCxt, pStmt->dbName));
9,748,023✔
586
  int32_t code = authObjPrivileges(pCxt, pStmt->dbName, NULL, PRIV_TBL_CREATE, PRIV_OBJ_DB);
9,747,494✔
587
#ifdef TD_ENTERPRISE
588
  // Per FS §4.2.1.4: specifying SECURITY_LEVEL > 0 requires PRIV_SECURITY_POLICY_ALTER regardless
589
  // of MAC activation state. SECURITY_LEVEL = 0 is equivalent to the default and always allowed.
590
  if (TSDB_CODE_SUCCESS == code) {
9,747,494✔
591
    if (pStmt->pOptions && pStmt->pOptions->securityLevel > 0) {
9,746,985✔
NEW
592
      if (pCxt->pParseCxt->macMode && pCxt->pParseCxt->maxSecLevel < pStmt->pOptions->securityLevel) {
×
NEW
593
        code = TSDB_CODE_MAC_INSUFFICIENT_LEVEL;
×
594
      } else {
NEW
595
        code = authSysPrivileges(pCxt, (SNode*)pStmt, PRIV_SECURITY_POLICY_ALTER);
×
596
      }
597
    }
598
  }
599
#endif
600
  return code;
9,747,494✔
601
}
602

603
static int32_t authCreateVTable(SAuthCxt* pCxt, SCreateVTableStmt* pStmt) {
234,126✔
604
  PAR_ERR_RET(checkDbUseAuth(pCxt, pStmt->dbName));
234,126✔
605
  PAR_ERR_RET(authObjPrivileges(pCxt, pStmt->dbName, NULL, PRIV_TBL_CREATE, PRIV_OBJ_DB));
234,126✔
606
  SNode* pCol = NULL;
222,990✔
607
  FOREACH(pCol, pStmt->pCols) {
161,304,486✔
608
    SColumnDefNode* pColDef = (SColumnDefNode*)pCol;
161,089,848✔
609
    if (NULL == pColDef) {
161,089,848✔
UNCOV
610
      PAR_ERR_RET(TSDB_CODE_PAR_INVALID_COLUMN);
×
611
    }
612
    SColumnOptions* pOptions = (SColumnOptions*)pColDef->pOptions;
161,089,848✔
613
    if (pOptions && pOptions->hasRef) {
161,089,848✔
614
      if (authObjPrivileges(pCxt, pOptions->refDb, pOptions->refTable, PRIV_TBL_SELECT, PRIV_OBJ_TBL)) {
100,497,851✔
615
        return TSDB_CODE_PAR_TB_SELECT_PERMISSION_DENIED;
8,352✔
616
      }
617
    }
618
  }
619
  return TSDB_CODE_SUCCESS;
214,638✔
620
}
621

622
static int32_t authCreateVSubTable(SAuthCxt* pCxt, SCreateVSubTableStmt* pStmt) {
424,543✔
623
  SNode*     pNode = NULL;
424,543✔
624
  SNodeList* pTmpList = pStmt->pSpecificColRefs ? pStmt->pSpecificColRefs : pStmt->pColRefs;
424,543✔
625
  PAR_ERR_RET(checkDbUseAuth(pCxt, pStmt->dbName));
424,543✔
626
  PAR_ERR_RET(authObjPrivileges(pCxt, pStmt->dbName, NULL, PRIV_TBL_CREATE, PRIV_OBJ_DB));
424,543✔
627
  if (NULL == pTmpList) {
413,407✔
628
    // no column reference
629
    return TSDB_CODE_SUCCESS;
26,085✔
630
  }
631

632
  FOREACH(pNode, pTmpList) {
61,988,720✔
633
    SColumnRefNode* pColRef = (SColumnRefNode*)pNode;
61,609,750✔
634
    if (NULL == pColRef) {
61,609,750✔
UNCOV
635
      PAR_ERR_RET(TSDB_CODE_PAR_INVALID_COLUMN);
×
636
    }
637
    if (authObjPrivileges(pCxt, pColRef->refDbName, pColRef->refTableName, PRIV_TBL_SELECT, PRIV_OBJ_TBL)) {
61,609,750✔
638
      return TSDB_CODE_PAR_TB_SELECT_PERMISSION_DENIED;
8,352✔
639
    }
640
  }
641
  return TSDB_CODE_SUCCESS;
378,970✔
642
}
643

644
static int32_t authCreateStream(SAuthCxt* pCxt, SCreateStreamStmt* pStmt) {
533,183✔
645
  int32_t code = TSDB_CODE_SUCCESS;
533,183✔
646

647
  if (IS_SYS_DBNAME(pStmt->streamDbName)) {
533,183✔
UNCOV
648
    return TSDB_CODE_PAR_PERMISSION_DENIED;
×
649
  }
650
  if (IS_SYS_DBNAME(pStmt->targetDbName)) {
533,183✔
651
    return TSDB_CODE_PAR_PERMISSION_DENIED;
42✔
652
  }
653
  if (pStmt->pTrigger) {
533,141✔
654
    SStreamTriggerNode* pTrigger = (SStreamTriggerNode*)pStmt->pTrigger;
533,141✔
655
    STableNode*         pTriggerTable = (STableNode*)pTrigger->pTrigerTable;
533,141✔
656
    if (pTriggerTable) {
533,141✔
657
      if (IS_SYS_DBNAME(pTriggerTable->dbName)) return TSDB_CODE_PAR_PERMISSION_DENIED;
519,659✔
658
      if (authObjPrivileges(pCxt, pTriggerTable->dbName, pTriggerTable->tableName, PRIV_TBL_SELECT, PRIV_OBJ_TBL)) {
519,617✔
659
        return TSDB_CODE_PAR_TB_SELECT_PERMISSION_DENIED;
940✔
660
      }
661
      PAR_ERR_RET(checkDbUseAuth(pCxt, pTriggerTable->dbName));
518,677✔
662
    }
663
  }
664

665
  PAR_ERR_RET(checkDbUseAuth(pCxt, ((SCreateStreamStmt*)pStmt)->streamDbName));
532,159✔
666
  PAR_ERR_RET(
532,159✔
667
      authObjPrivileges(pCxt, ((SCreateStreamStmt*)pStmt)->streamDbName, NULL, PRIV_STREAM_CREATE, PRIV_OBJ_DB));
668
  if (pStmt->targetDbName[0] != '\0') {
531,454✔
669
    PAR_ERR_RET(checkDbUseAuth(pCxt, ((SCreateStreamStmt*)pStmt)->targetDbName));
524,125✔
670
    if (authObjPrivileges(pCxt, ((SCreateStreamStmt*)pStmt)->targetDbName, NULL, PRIV_TBL_CREATE, PRIV_OBJ_DB)) {
524,125✔
671
      return TSDB_CODE_PAR_TB_CREATE_PERMISSION_DENIED;
235✔
672
    }
673
  }
674
  if (pStmt->pQuery) {
531,219✔
675
    PAR_ERR_RET(authQuery(pCxt, pStmt->pQuery));
524,284✔
676
  }
677
  return code;
530,749✔
678
}
679

680
static int32_t authCreateTopic(SAuthCxt* pCxt, SCreateTopicStmt* pStmt) {
209,780✔
681
  int32_t code = TSDB_CODE_SUCCESS;
209,780✔
682

683
  if (IS_SYS_DBNAME(pStmt->subDbName)) {
209,780✔
UNCOV
684
    return TSDB_CODE_PAR_PERMISSION_DENIED;
×
685
  }
686
  if (NULL != pStmt->pQuery) {
209,780✔
687
    PAR_ERR_RET(authQuery(pCxt, pStmt->pQuery));
160,154✔
688
  }
689
  if (NULL != pStmt->pWhere) {
209,281✔
690
    if (authObjPrivileges(pCxt, ((SCreateTopicStmt*)pStmt)->subDbName, ((SCreateTopicStmt*)pStmt)->subSTbName,
10,721✔
691
                          PRIV_TBL_SELECT, PRIV_OBJ_TBL)) {
692
      return TSDB_CODE_PAR_TB_SELECT_PERMISSION_DENIED;
×
693
    }
694
  }
695
  if (((SCreateTopicStmt*)pStmt)->subDbName[0] != '\0') {
209,281✔
696
    PAR_ERR_RET(checkDbUseAuth(pCxt, ((SCreateTopicStmt*)pStmt)->subDbName));
49,626✔
697
  }
698

699
  return code;
209,281✔
700
}
701

702
static int32_t authCreateMultiTable(SAuthCxt* pCxt, SCreateMultiTablesStmt* pStmt) {
38,142,558✔
703
  int32_t code = TSDB_CODE_SUCCESS;
38,142,558✔
704
  SNode*  pNode = NULL;
38,142,558✔
705
  FOREACH(pNode, pStmt->pSubTables) {
83,695,929✔
706
    if (pNode->type == QUERY_NODE_CREATE_SUBTABLE_CLAUSE) {
45,552,830✔
707
      SCreateSubTableClause* pClause = (SCreateSubTableClause*)pNode;
45,551,260✔
708
      code = checkDbUseAuth(pCxt, pClause->dbName);
45,551,260✔
709
      if (TSDB_CODE_SUCCESS != code) break;
45,553,060✔
710
      code = authObjPrivileges(pCxt, pClause->dbName, NULL, PRIV_TBL_CREATE, PRIV_OBJ_DB);
45,552,876✔
711
      if (TSDB_CODE_SUCCESS != code) {
45,553,357✔
UNCOV
712
        break;
×
713
      }
714
    } else {
UNCOV
715
      SCreateSubTableFromFileClause* pClause = (SCreateSubTableFromFileClause*)pNode;
×
NEW
716
      code = checkDbUseAuth(pCxt, pClause->useDbName);
×
NEW
717
      if (TSDB_CODE_SUCCESS != code) break;
×
UNCOV
718
      code = authObjPrivileges(pCxt, pClause->useDbName, NULL, PRIV_TBL_CREATE, PRIV_OBJ_DB);
×
719
      if (TSDB_CODE_SUCCESS != code) {
14✔
UNCOV
720
        break;
×
721
      }
722
    }
723
  }
724
  return code;
38,142,682✔
725
}
726

727
static int32_t authDropTable(SAuthCxt* pCxt, SDropTableStmt* pStmt) {
2,751,196✔
728
  int32_t code = TSDB_CODE_SUCCESS;
2,751,196✔
729
  if (pStmt->withOpt && !pCxt->pParseCxt->isSuperUser) {
2,751,196✔
730
    return TSDB_CODE_PAR_PERMISSION_DENIED;
266✔
731
  }
732
  SNode* pNode = NULL;
2,750,930✔
733
  FOREACH(pNode, pStmt->pTables) {
5,621,114✔
734
    SDropTableClause* pClause = (SDropTableClause*)pNode;
2,871,919✔
735
    code = checkDbUseAuth(pCxt, pClause->dbName);
2,871,919✔
736
    if (TSDB_CODE_SUCCESS != code) break;
2,871,919✔
737

738
    if (!pStmt->withOpt) {
2,871,213✔
739
      // for child table, check privileges of its super table later
740
      if (checkAuth(pCxt, pClause->dbName, pClause->tableName, PRIV_CM_DROP, PRIV_OBJ_TBL, NULL, NULL)) {
2,718,050✔
741
        code = TSDB_CODE_PAR_PERMISSION_DENIED;
1,029✔
742
        break;
1,029✔
743
      }
744
    }
745
  }
746

747
  return code;
2,750,930✔
748
}
749

750
static int32_t authDropStable(SAuthCxt* pCxt, SDropSuperTableStmt* pStmt) {
102,327✔
751
  if (pStmt->withOpt && !pCxt->pParseCxt->isSuperUser) {
102,327✔
752
    return TSDB_CODE_PAR_PERMISSION_DENIED;
133✔
753
  }
754
  PAR_ERR_RET(checkDbUseAuth(pCxt, pStmt->dbName));
102,194✔
755
  if (!pStmt->withOpt) {
102,194✔
756
    PAR_ERR_RET(checkAuth(pCxt, pStmt->dbName, pStmt->tableName, PRIV_CM_DROP, PRIV_OBJ_TBL, NULL, NULL));
42,378✔
757
  }
758
  return 0;
102,194✔
759
}
760

761
static int32_t authDropVtable(SAuthCxt* pCxt, SDropVirtualTableStmt* pStmt) {
78,732✔
762
  if (pStmt->withOpt && !pCxt->pParseCxt->isSuperUser) {
78,732✔
UNCOV
763
    return TSDB_CODE_PAR_PERMISSION_DENIED;
×
764
  }
765
  PAR_ERR_RET(checkDbUseAuth(pCxt, pStmt->dbName));
78,732✔
766
  if (!pStmt->withOpt) {
78,732✔
767
    PAR_ERR_RET(checkAuth(pCxt, pStmt->dbName, pStmt->tableName, PRIV_CM_DROP, PRIV_OBJ_TBL, NULL, NULL));
78,732✔
768
  }
769
  return 0;
67,580✔
770
}
771

772
static int32_t authAlterTable(SAuthCxt* pCxt, SAlterTableStmt* pStmt) {
23,691,319✔
773
  // TODO: if alterType is TSDB_ALTER_TABLE_UPDATE_CHILD_TABLE_TAG_VAL, the tables to
774
  // change tag value are child tables but we only have the super table name here.
775
  // the auth logic below haven't handled this case, but as this case is only for internal
776
  // use and not exposed to users, we can live with this for now and improve it later if needed.
777

778
  if (pStmt->alterType == TSDB_ALTER_TABLE_UPDATE_MULTI_TABLE_TAG_VAL) {
23,691,319✔
779
    int32_t code = 0;
8,945,614✔
780
    SNode* pTableNode = NULL;
8,945,614✔
781
    FOREACH(pTableNode, pStmt->pList) {
17,910,623✔
782
      SAlterTableUpdateTagValClause* pClause = (SAlterTableUpdateTagValClause*)pTableNode;
8,965,359✔
783
      PAR_ERR_RET(checkDbUseAuth(pCxt, pClause->dbName));
8,965,359✔
784
      code = checkAuth(pCxt, pClause->dbName, pClause->tableName, PRIV_CM_ALTER, PRIV_OBJ_TBL, NULL, NULL);
8,965,359✔
785
#ifdef TD_ENTERPRISE
786
      // MAC clearance check: child table inherits secLvl from STB; user clearance must dominate object level
787
      if (TSDB_CODE_SUCCESS == code) {
8,965,359✔
788
        code = macCheckTableAccess(pCxt, pClause->dbName, pClause->tableName, false);
8,965,359✔
789
      }
790
#endif
791
      if (code != TSDB_CODE_SUCCESS) {
8,965,359✔
792
        break;
350✔
793
      }
794
    }
795
    return code;
8,945,614✔
796
  } else {
797
    // todo check tag condition for subtable
798
#ifdef TD_ENTERPRISE
799
    // MAC domain: security_level changes require only PRIV_SECURITY_POLICY_ALTER (no CM_ALTER needed)
800
    if (pStmt->alterType == TSDB_ALTER_TABLE_UPDATE_OPTIONS && pStmt->pOptions && pStmt->pOptions->securityLevel >= 0) {
14,745,705✔
801
      // Trusted subject: PRIV_SECURITY_POLICY_ALTER holder is exempt from maxSecLevel constraint
802
      return authSysPrivileges(pCxt, (SNode*)pStmt, PRIV_SECURITY_POLICY_ALTER);
2,625✔
803
    }
804
#endif
805
    // DAC domain: non-security ALTER requires DB_USE + CM_ALTER + MAC clearance
806
    PAR_ERR_RET(checkDbUseAuth(pCxt, pStmt->dbName));
14,743,080✔
807
    int32_t code = checkAuth(pCxt, pStmt->dbName, pStmt->tableName, PRIV_CM_ALTER, PRIV_OBJ_TBL, NULL, NULL);
14,741,849✔
808
#ifdef TD_ENTERPRISE
809
    if (TSDB_CODE_SUCCESS == code) {
14,741,849✔
810
      // MAC clearance check: secLvl inherited from STB for child tables
811
      code = macCheckTableAccess(pCxt, pStmt->dbName, pStmt->tableName, false);
14,741,527✔
812
    }
813
#endif
814
    return code;
14,741,849✔
815
  }
816
}
817

818
static int32_t authAlterVTable(SAuthCxt* pCxt, SAlterTableStmt* pStmt) {
450,496✔
819
  // TODO: if alterType is TSDB_ALTER_TABLE_UPDATE_CHILD_TABLE_TAG_VAL, the tables to
820
  // change tag value are child tables but we only have the super table name here.
821
  // the auth logic below haven't handled this case, but as this case is only for internal
822
  // use and not exposed to users, we can live with this for now and improve it later if needed.
823

824
  if (pStmt->alterType == TSDB_ALTER_TABLE_UPDATE_MULTI_TABLE_TAG_VAL) {
450,496✔
825
    int32_t code = 0;
46,389✔
826
    SNode* pTableNode = NULL;
46,389✔
827
    FOREACH(pTableNode, pStmt->pList) {
102,014✔
828
      SAlterTableUpdateTagValClause* pClause = (SAlterTableUpdateTagValClause*)pTableNode;
61,201✔
829
      PAR_ERR_RET(checkDbUseAuth(pCxt, pClause->dbName));
61,201✔
830
      code = checkAuth(pCxt, pClause->dbName, pClause->tableName, PRIV_CM_ALTER, PRIV_OBJ_TBL, NULL, NULL);
61,201✔
831
      if (code != TSDB_CODE_SUCCESS) {
61,201✔
832
        break;
5,576✔
833
      }
834
    }
835
    PAR_RET(code);
46,389✔
836
  }
837

838
  PAR_ERR_RET(checkDbUseAuth(pCxt, pStmt->dbName));
404,107✔
839
  PAR_ERR_RET(checkAuth(pCxt, pStmt->dbName, pStmt->tableName, PRIV_CM_ALTER, PRIV_OBJ_TBL, NULL, NULL));
404,107✔
840
  if (pStmt->alterType == TSDB_ALTER_TABLE_ADD_COLUMN_WITH_COLUMN_REF ||
348,347✔
841
      pStmt->alterType == TSDB_ALTER_TABLE_ALTER_COLUMN_REF) {
313,865✔
842
    PAR_ERR_RET(checkDbUseAuth(pCxt, pStmt->refDbName));
142,003✔
843
    if (checkAuth(pCxt, pStmt->refDbName, pStmt->refTableName, PRIV_TBL_SELECT, PRIV_OBJ_TBL, NULL, NULL)) {
142,003✔
844
      return TSDB_CODE_PAR_TB_SELECT_PERMISSION_DENIED;
22,304✔
845
    }
846
  }
847
  PAR_RET(TSDB_CODE_SUCCESS);
326,043✔
848
}
849

850
static int32_t authCreateView(SAuthCxt* pCxt, SCreateViewStmt* pStmt) {
229,924✔
851
#ifndef TD_ENTERPRISE
852
  return TSDB_CODE_OPS_NOT_SUPPORT;
853
#else
854
  int32_t code = checkDbUseAuth(pCxt, pStmt->dbName);
229,924✔
855
  if (TSDB_CODE_SUCCESS == code) {
229,924✔
856
    code = checkAuth(pCxt, pStmt->dbName, NULL, PRIV_VIEW_CREATE, PRIV_OBJ_DB, NULL, NULL);
229,924✔
857
    if (code != TSDB_CODE_SUCCESS && pStmt->orReplace) {
229,924✔
858
      code = checkAuth(pCxt, pStmt->dbName, pStmt->viewName, PRIV_CM_ALTER, PRIV_OBJ_VIEW, NULL, NULL);
322✔
859
    }
860
  }
861
  if (TSDB_CODE_SUCCESS == code) {
229,924✔
862
    if ((code = authQuery(pCxt, pStmt->pQuery))) {
225,652✔
863
      if (code == TSDB_CODE_PAR_PERMISSION_DENIED) code = TSDB_CODE_PAR_TB_SELECT_PERMISSION_DENIED;
3,950✔
864
    }
865
  }
866
  return code;
229,924✔
867
#endif
868
}
869

870
static int32_t authDropView(SAuthCxt* pCxt, SDropViewStmt* pStmt) {
172,158✔
871
#ifndef TD_ENTERPRISE
872
  return TSDB_CODE_OPS_NOT_SUPPORT;
873
#else
874
  int32_t code = checkDbUseAuth(pCxt, pStmt->dbName);
172,158✔
875
  if (TSDB_CODE_SUCCESS == code) {
172,158✔
876
    code = checkViewAuth(pCxt, pStmt->dbName, pStmt->viewName, PRIV_CM_DROP, PRIV_OBJ_VIEW, NULL);
172,158✔
877
  }
878
  if (code == 0) {
172,158✔
879
    pStmt->hasPrivilege = true;
160,810✔
880
  } else {
881
    code = 0;  // check owner in parTranslater
11,348✔
882
  }
883
  return code;
172,158✔
884
#endif
885
}
886

887
static int32_t authCreateIndex(SAuthCxt* pCxt, SCreateIndexStmt* pStmt) {
23,359✔
888
  int32_t code = checkDbUseAuth(pCxt, ((SCreateIndexStmt*)pStmt)->dbName);
23,359✔
889

890
  if (TSDB_CODE_SUCCESS == code) {
23,359✔
891
    if (authObjPrivileges(pCxt, ((SCreateIndexStmt*)pStmt)->dbName, ((SCreateIndexStmt*)pStmt)->tableName,
23,359✔
892
                          PRIV_TBL_SELECT, PRIV_OBJ_TBL)) {
893
      code = TSDB_CODE_PAR_TB_SELECT_PERMISSION_DENIED;
322✔
894
    }
895
  }
896

897
  if (TSDB_CODE_SUCCESS == code) {
23,359✔
898
    code = authObjPrivileges(pCxt, ((SCreateIndexStmt*)pStmt)->dbName, ((SCreateIndexStmt*)pStmt)->tableName,
23,037✔
899
                             PRIV_IDX_CREATE, PRIV_OBJ_TBL);
900
  }
901

902
  return code;
23,359✔
903
}
904

905
static int32_t authDropIndex(SAuthCxt* pCxt, SDropIndexStmt* pStmt) {
12,128✔
906
  int32_t code = checkDbUseAuth(pCxt, ((SDropIndexStmt*)pStmt)->indexDbName);
12,128✔
907
  if (TSDB_CODE_SUCCESS == code) {
12,128✔
908
    code = authObjPrivileges(pCxt, ((SDropIndexStmt*)pStmt)->indexDbName, ((SDropIndexStmt*)pStmt)->indexName,
12,128✔
909
                             PRIV_CM_DROP, PRIV_OBJ_IDX);
910
  }
911
  return code;
12,128✔
912
}
913

914
static int32_t authShowIndexes(SAuthCxt* pCxt, SShowStmt* pStmt) { return authShowTables(pCxt, pStmt); }
8,199✔
915

916
static int32_t authCreateTsma(SAuthCxt* pCxt, SCreateTSMAStmt* pStmt) {
9,238✔
917
  int32_t code = checkDbUseAuth(pCxt, ((SCreateTSMAStmt*)pStmt)->dbName);
9,238✔
918
  if (TSDB_CODE_SUCCESS == code) {
9,238✔
919
    if (authObjPrivileges(pCxt, ((SCreateTSMAStmt*)pStmt)->dbName, NULL, PRIV_TBL_CREATE, PRIV_OBJ_DB)) {
9,238✔
920
      code = TSDB_CODE_PAR_TB_CREATE_PERMISSION_DENIED;
483✔
921
    }
922
  }
923
  if (!pStmt->pOptions->recursiveTsma) {
9,238✔
924
    if (TSDB_CODE_SUCCESS == code) {
7,834✔
925
      if (authObjPrivileges(pCxt, ((SCreateTSMAStmt*)pStmt)->dbName, ((SCreateTSMAStmt*)pStmt)->tableName,
7,351✔
926
                            PRIV_TBL_SELECT, PRIV_OBJ_TBL)) {
UNCOV
927
        code = TSDB_CODE_PAR_TB_SELECT_PERMISSION_DENIED;
×
928
      }
929
    }
930

931
    if (TSDB_CODE_SUCCESS == code) {
7,834✔
932
      if (authObjPrivileges(pCxt, ((SCreateTSMAStmt*)pStmt)->dbName, NULL, PRIV_STREAM_CREATE, PRIV_OBJ_DB)) {
7,351✔
933
        code = TSDB_CODE_PAR_STREAM_CREATE_PERMISSION_DENIED;
322✔
934
      }
935
    }
936
    if (TSDB_CODE_SUCCESS == code) {
7,834✔
937
      code = authObjPrivileges(pCxt, ((SCreateTSMAStmt*)pStmt)->dbName, ((SCreateTSMAStmt*)pStmt)->tableName,
7,029✔
938
                               PRIV_TSMA_CREATE, PRIV_OBJ_TBL);
939
    }
940
  }
941

942
  return code;
9,238✔
943
}
944

945
static int32_t authDropTsma(SAuthCxt* pCxt, SDropTSMAStmt* pStmt) {
4,383✔
946
  int32_t code = checkDbUseAuth(pCxt, ((SDropTSMAStmt*)pStmt)->dbName);
4,383✔
947
  if (TSDB_CODE_SUCCESS == code) {
4,383✔
948
    code = authObjPrivileges(pCxt, ((SDropTSMAStmt*)pStmt)->dbName, ((SDropTSMAStmt*)pStmt)->tsmaName, PRIV_CM_DROP,
4,383✔
949
                             PRIV_OBJ_TSMA);
950
  }
951
  return code;
4,383✔
952
}
953

954
static int32_t authCreateRsma(SAuthCxt* pCxt, SCreateRsmaStmt* pStmt) {
119,788✔
955
  int32_t code = checkDbUseAuth(pCxt, ((SCreateRsmaStmt*)pStmt)->dbName);
119,788✔
956
  if (TSDB_CODE_SUCCESS == code) {
119,788✔
957
    if (authObjPrivileges(pCxt, ((SCreateRsmaStmt*)pStmt)->dbName, ((SCreateRsmaStmt*)pStmt)->tableName,
119,788✔
958
                          PRIV_TBL_SELECT, PRIV_OBJ_TBL)) {
UNCOV
959
      code = TSDB_CODE_PAR_TB_SELECT_PERMISSION_DENIED;
×
960
    }
961
  }
962
  if (TSDB_CODE_SUCCESS == code) {
119,788✔
963
    if (authObjPrivileges(pCxt, ((SCreateRsmaStmt*)pStmt)->dbName, ((SCreateRsmaStmt*)pStmt)->tableName,
119,788✔
964
                          PRIV_TBL_INSERT, PRIV_OBJ_TBL)) {
965
      code = TSDB_CODE_PAR_TB_INSERT_PERMISSION_DENIED;
161✔
966
    }
967
  }
968
  if (TSDB_CODE_SUCCESS == code) {
119,788✔
969
    code = authObjPrivileges(pCxt, ((SCreateRsmaStmt*)pStmt)->dbName, ((SCreateRsmaStmt*)pStmt)->tableName,
119,627✔
970
                             PRIV_RSMA_CREATE, PRIV_OBJ_TBL);
971
  }
972
  return code;
119,788✔
973
}
974

975
static int32_t authDropRsma(SAuthCxt* pCxt, SDropRsmaStmt* pStmt) {
10,914✔
976
  int32_t code = checkDbUseAuth(pCxt, ((SDropRsmaStmt*)pStmt)->dbName);
10,914✔
977
  if (TSDB_CODE_SUCCESS == code) {
10,914✔
978
    code = authObjPrivileges(pCxt, ((SDropRsmaStmt*)pStmt)->dbName, ((SDropRsmaStmt*)pStmt)->rsmaName, PRIV_CM_DROP,
10,914✔
979
                             PRIV_OBJ_RSMA);
980
  }
981
  return code;
10,914✔
982
}
983

984
static int32_t authShowCreateRsma(SAuthCxt* pCxt, SShowCreateRsmaStmt* pStmt) {
3,497✔
985
#ifndef TD_ENTERPRISE
986
  return TSDB_CODE_OPS_NOT_SUPPORT;
987
#else
988
  int32_t code = checkDbUseAuth(pCxt, ((SShowCreateRsmaStmt*)pStmt)->dbName);
3,497✔
989
  if (TSDB_CODE_SUCCESS == code) {
3,497✔
990
    code = authObjPrivileges(pCxt, ((SShowCreateRsmaStmt*)pStmt)->dbName, ((SShowCreateRsmaStmt*)pStmt)->rsmaName,
3,497✔
991
                             PRIV_CM_SHOW_CREATE, PRIV_OBJ_RSMA);
992
  }
993
  if (code == 0) pStmt->hasPrivilege = true;
3,497✔
994
  return 0;  // return 0 and check owner later in translateShowCreateRsma since rsma ctgCatalog not available yet
3,497✔
995
#endif
996
}
997

998
static int32_t authCreateDatabase(SAuthCxt* pCxt, SCreateDatabaseStmt* pStmt) {
1,688,603✔
999
  int32_t code = authSysPrivileges(pCxt, (SNode*)pStmt, PRIV_DB_CREATE);
1,688,603✔
1000
#ifdef TD_ENTERPRISE
1001
  // Per FS §4.2.1.4: specifying SECURITY_LEVEL > 0 requires PRIV_SECURITY_POLICY_ALTER regardless
1002
  // of MAC activation state. SECURITY_LEVEL = 0 is equivalent to the default and always allowed.
1003
  if (TSDB_CODE_SUCCESS == code) {
1,688,603✔
1004
    if (pStmt->pOptions && pStmt->pOptions->securityLevel > 0) {
1,686,189✔
1005
      // Trusted subject: PRIV_SECURITY_POLICY_ALTER holder is exempt from maxSecLevel constraint
NEW
1006
      code = authSysPrivileges(pCxt, (SNode*)pStmt, PRIV_SECURITY_POLICY_ALTER);
×
1007
    }
1008
  }
1009
#endif
1010
  return code;
1,688,603✔
1011
}
1012

1013
static int32_t authAlterDatabase(SAuthCxt* pCxt, SAlterDatabaseStmt* pStmt) {
238,160✔
1014
#ifdef TD_ENTERPRISE
1015
  // MAC domain: security_level changes require only PRIV_SECURITY_POLICY_ALTER (no CM_ALTER needed)
1016
  if (pStmt->pOptions && pStmt->pOptions->securityLevel >= 0) {
238,160✔
1017
    // Trusted subject: PRIV_SECURITY_POLICY_ALTER holder is exempt from maxSecLevel constraint
1018
    return authSysPrivileges(pCxt, (SNode*)pStmt, PRIV_SECURITY_POLICY_ALTER);
2,452✔
1019
  }
1020
#endif
1021
  // DAC domain: non-security ALTER requires CM_ALTER
1022
  return authObjPrivileges(pCxt, ((SAlterDatabaseStmt*)pStmt)->dbName, NULL, PRIV_CM_ALTER, PRIV_OBJ_DB);
235,708✔
1023
}
1024

1025
static int32_t authAlterLocal(SAuthCxt* pCxt, SAlterLocalStmt* pStmt) {
572,656✔
1026
  int32_t privType = cfgGetPrivType(tsCfg, pStmt->config, 0);
572,656✔
1027
  return authSysPrivileges(pCxt, (void*)pStmt, privType);
572,656✔
1028
}
1029

1030
static int32_t authDropRole(SAuthCxt* pCxt, SDropRoleStmt* pStmt) {
1,771✔
1031
  return authSysPrivileges(pCxt, (SNode*)pStmt, PRIV_ROLE_DROP);
1,771✔
1032
}
1033

1034
static int32_t authDropDatabase(SAuthCxt* pCxt, SDropDatabaseStmt* pStmt) {
1,432,797✔
1035
  return authObjPrivileges(pCxt, ((SDropDatabaseStmt*)pStmt)->dbName, NULL, PRIV_CM_DROP, PRIV_OBJ_DB);
1,432,797✔
1036
}
1037

1038
static int32_t authUseDatabase(SAuthCxt* pCxt, SUseDatabaseStmt* pStmt) {
99,324,275✔
1039
  return authObjPrivileges(pCxt, ((SUseDatabaseStmt*)pStmt)->dbName, NULL, PRIV_DB_USE, PRIV_OBJ_DB);
99,324,275✔
1040
}
1041

1042
static int32_t authGrant(SAuthCxt* pCxt, SGrantStmt* pStmt) {
972,943✔
1043
  bool sodInitial = pCxt->pParseCxt->sodInitial;
972,943✔
1044
  if (pStmt->optrType == TSDB_ALTER_ROLE_ROLE) {
972,943✔
1045
    if (IS_SYS_PREFIX(pStmt->roleName)) {
9,195✔
1046
      if (strcmp(pStmt->roleName, TSDB_ROLE_SYSDBA) == 0) {
8,360✔
1047
        return authSysPrivileges(pCxt, (void*)pStmt, PRIV_GRANT_SYSDBA);
2,473✔
1048
      }
1049
      if (strcmp(pStmt->roleName, TSDB_ROLE_SYSSEC) == 0) {
5,887✔
1050
        return authSysPrivileges(pCxt, (void*)pStmt, PRIV_GRANT_SYSSEC);
2,354✔
1051
      }
1052
      if (strcmp(pStmt->roleName, TSDB_ROLE_SYSAUDIT) == 0) {
3,533✔
1053
        return authSysPrivileges(pCxt, (void*)pStmt, PRIV_GRANT_SYSAUDIT);
1,479✔
1054
      }
1055
    } else if (sodInitial) {
835✔
NEW
1056
      return TSDB_CODE_MND_SOD_RESTRICTED;
×
1057
    }
1058
  } else if (sodInitial) {
963,748✔
NEW
1059
    return TSDB_CODE_MND_SOD_RESTRICTED;
×
1060
  }
1061
  return authSysPrivileges(pCxt, (void*)pStmt, PRIV_GRANT_PRIVILEGE);
966,637✔
1062
}
1063

1064
static int32_t authRevoke(SAuthCxt* pCxt, SRevokeStmt* pStmt) {
513,231✔
1065
  bool sodInitial = pCxt->pParseCxt->sodInitial;
513,231✔
1066
  if (pStmt->optrType == TSDB_ALTER_ROLE_ROLE) {
513,231✔
1067
    if (IS_SYS_PREFIX(pStmt->roleName)) {
8,433✔
1068
      if (strcmp(pStmt->roleName, TSDB_ROLE_SYSDBA) == 0) {
8,272✔
1069
        return authSysPrivileges(pCxt, (void*)pStmt, PRIV_REVOKE_SYSDBA);
686✔
1070
      }
1071
      if (strcmp(pStmt->roleName, TSDB_ROLE_SYSSEC) == 0) {
7,586✔
1072
        return authSysPrivileges(pCxt, (void*)pStmt, PRIV_REVOKE_SYSSEC);
1,211✔
1073
      }
1074
      if (strcmp(pStmt->roleName, TSDB_ROLE_SYSAUDIT) == 0) {
6,375✔
1075
        return authSysPrivileges(pCxt, (void*)pStmt, PRIV_REVOKE_SYSAUDIT);
686✔
1076
      }
1077
    } else if (sodInitial) {
161✔
NEW
1078
      return TSDB_CODE_MND_SOD_RESTRICTED;
×
1079
    }
1080
  } else if (sodInitial) {
504,798✔
NEW
1081
    return TSDB_CODE_MND_SOD_RESTRICTED;
×
1082
  }
1083
  return authSysPrivileges(pCxt, (void*)pStmt, PRIV_REVOKE_PRIVILEGE);
510,648✔
1084
}
1085

1086
static int32_t authQuery(SAuthCxt* pCxt, SNode* pStmt) {
528,854,536✔
1087
  int32_t code = TSDB_CODE_SUCCESS;
528,854,536✔
1088
#ifdef TD_ENTERPRISE
1089
  switch (nodeType(pStmt)) {
528,854,536✔
1090
    case QUERY_NODE_SET_OPERATOR:
9,853,887✔
1091
      return authSetOperator(pCxt, (SSetOperator*)pStmt);
9,853,887✔
1092
    case QUERY_NODE_SELECT_STMT:
222,854,023✔
1093
      return authSelect(pCxt, (SSelectStmt*)pStmt);
222,854,023✔
1094
    case QUERY_NODE_CREATE_ROLE_STMT:
4,907✔
1095
      return authSysPrivileges(pCxt, pStmt, PRIV_ROLE_CREATE);
4,907✔
1096
    case QUERY_NODE_DROP_ROLE_STMT:
1,771✔
1097
      return authDropRole(pCxt, (SDropRoleStmt*)pStmt);
1,771✔
1098
    case QUERY_NODE_CREATE_USER_STMT:
117,336✔
1099
      return authSysPrivileges(pCxt, pStmt, PRIV_USER_CREATE);
117,336✔
1100
    case QUERY_NODE_ALTER_USER_STMT:
61,603✔
1101
      return authSysPrivileges(pCxt, pStmt, PRIV_USER_ALTER);
61,603✔
1102
    case QUERY_NODE_DROP_USER_STMT:
59,545✔
1103
      return authDropUser(pCxt, (SDropUserStmt*)pStmt);
59,545✔
1104
    case QUERY_NODE_DELETE_STMT:
1,972,441✔
1105
      return authDelete(pCxt, (SDeleteStmt*)pStmt);
1,972,441✔
1106
    case QUERY_NODE_INSERT_STMT:
507,794✔
1107
      return authInsert(pCxt, (SInsertStmt*)pStmt);
507,794✔
1108
    case QUERY_NODE_CREATE_TABLE_STMT:
9,748,023✔
1109
      return authCreateTable(pCxt, (SCreateTableStmt*)pStmt);
9,748,023✔
1110
    case QUERY_NODE_CREATE_VIRTUAL_TABLE_STMT:
234,126✔
1111
      return authCreateVTable(pCxt, (SCreateVTableStmt*)pStmt);
234,126✔
1112
    case QUERY_NODE_CREATE_VIRTUAL_SUBTABLE_STMT:
424,543✔
1113
      return authCreateVSubTable(pCxt, (SCreateVSubTableStmt*)pStmt);
424,543✔
1114
    case QUERY_NODE_CREATE_MULTI_TABLES_STMT:
38,143,475✔
1115
      return authCreateMultiTable(pCxt, (SCreateMultiTablesStmt*)pStmt);
38,143,475✔
1116
    case QUERY_NODE_CREATE_STREAM_STMT:
533,183✔
1117
      return authCreateStream(pCxt, (SCreateStreamStmt*)pStmt);
533,183✔
1118
    case QUERY_NODE_CREATE_TOPIC_STMT:
209,780✔
1119
      return authCreateTopic(pCxt, (SCreateTopicStmt*)pStmt);
209,780✔
1120
    case QUERY_NODE_DROP_TABLE_STMT:
2,751,196✔
1121
      return authDropTable(pCxt, (SDropTableStmt*)pStmt);
2,751,196✔
1122
    case QUERY_NODE_DROP_SUPER_TABLE_STMT:
102,327✔
1123
      return authDropStable(pCxt, (SDropSuperTableStmt*)pStmt);
102,327✔
1124
    case QUERY_NODE_DROP_VIRTUAL_TABLE_STMT:
78,732✔
1125
      return authDropVtable(pCxt, (SDropVirtualTableStmt*)pStmt);
78,732✔
1126
    case QUERY_NODE_ALTER_TABLE_STMT:
23,691,319✔
1127
    case QUERY_NODE_ALTER_SUPER_TABLE_STMT:
1128
      return authAlterTable(pCxt, (SAlterTableStmt*)pStmt);
23,691,319✔
1129
    case QUERY_NODE_ALTER_VIRTUAL_TABLE_STMT:
450,496✔
1130
      return authAlterVTable(pCxt, (SAlterTableStmt*)pStmt);
450,496✔
1131
    case QUERY_NODE_SHOW_MODULES_STMT:
124,976✔
1132
    case QUERY_NODE_SHOW_BACKUP_NODES_STMT:
1133
    case QUERY_NODE_SHOW_DB_ALIVE_STMT:
1134
    // case QUERY_NODE_SHOW_CLUSTER_ALIVE_STMT:
1135
    case QUERY_NODE_SHOW_CREATE_DATABASE_STMT:
1136
    case QUERY_NODE_SHOW_TABLE_DISTRIBUTED_STMT:  // TODO: check in mnode
1137
    // case QUERY_NODE_SHOW_LOCAL_VARIABLES_STMT: // not check local variables
1138
    case QUERY_NODE_SHOW_DNODE_VARIABLES_STMT:
1139
    case QUERY_NODE_SHOW_SCORES_STMT:
1140
    case QUERY_NODE_SHOW_ARBGROUPS_STMT:
1141
    case QUERY_NODE_SHOW_ENCRYPTIONS_STMT:
1142
    case QUERY_NODE_SHOW_MOUNTS_STMT:
1143
    case QUERY_NODE_SHOW_ENCRYPT_ALGORITHMS_STMT:
1144
    case QUERY_NODE_SHOW_ENCRYPT_STATUS_STMT:
1145
      return !pCxt->pParseCxt->enableSysInfo ? TSDB_CODE_PAR_PERMISSION_DENIED : TSDB_CODE_SUCCESS;
124,976✔
1146
    case QUERY_NODE_SHOW_USERS_STMT:
126,499✔
1147
    case QUERY_NODE_SHOW_USERS_FULL_STMT:
1148
      return authSysPrivileges(pCxt, pStmt, PRIV_USER_SHOW);
126,499✔
1149
    case QUERY_NODE_SHOW_ROLES_STMT:
1,318✔
1150
      return authSysPrivileges(pCxt, pStmt, PRIV_ROLE_SHOW);
1,318✔
1151
    case QUERY_NODE_SHOW_USER_PRIVILEGES_STMT:
5,629✔
1152
    case QUERY_NODE_SHOW_ROLE_PRIVILEGES_STMT:
1153
    case QUERY_NODE_SHOW_ROLE_COL_PRIVILEGES_STMT:
1154
      return authSysPrivileges(pCxt, pStmt, PRIV_SHOW_PRIVILEGES);
5,629✔
1155
    case QUERY_NODE_SHOW_DNODES_STMT:
510,516✔
1156
    case QUERY_NODE_SHOW_MNODES_STMT:
1157
    case QUERY_NODE_SHOW_QNODES_STMT:
1158
    case QUERY_NODE_SHOW_SNODES_STMT:
1159
    case QUERY_NODE_SHOW_BNODES_STMT:
1160
      return authSysPrivileges(pCxt, pStmt, PRIV_NODES_SHOW);
510,516✔
1161
    case QUERY_NODE_SHOW_ANODES_STMT:
184✔
1162
    case QUERY_NODE_SHOW_ANODES_FULL_STMT:
1163
      return TSDB_CODE_SUCCESS;
184✔
1164
    case QUERY_NODE_SHOW_XNODES_STMT:
6,680✔
1165
    case QUERY_NODE_SHOW_XNODE_AGENTS_STMT:
1166
      return authSysPrivileges(pCxt, pStmt, PRIV_NODES_SHOW);
6,680✔
1167
    case QUERY_NODE_SHOW_XNODE_TASKS_STMT:
12,518✔
1168
    case QUERY_NODE_SHOW_XNODE_JOBS_STMT:
1169
      return TSDB_CODE_SUCCESS;
12,518✔
1170
    case QUERY_NODE_CREATE_XNODE_STMT:
5,421✔
1171
    case QUERY_NODE_DROP_XNODE_STMT:
1172
      return TSDB_CODE_SUCCESS;
5,421✔
1173
    case QUERY_NODE_SHOW_CLUSTER_MACHINES_STMT:
4,059✔
1174
    // case QUERY_NODE_SHOW_LICENCES_STMT: // do not check auth for basic licence info since it's used for taos logon
1175
    case QUERY_NODE_SHOW_GRANTS_FULL_STMT:
1176
    case QUERY_NODE_SHOW_GRANTS_LOGS_STMT:
1177
      return authSysPrivileges(pCxt, pStmt, PRIV_GRANTS_SHOW);
4,059✔
1178
    case QUERY_NODE_SHOW_TABLES_STMT:
530,115✔
1179
    case QUERY_NODE_SHOW_STABLES_STMT:
1180
      return authShowTables(pCxt, (SShowStmt*)pStmt);
530,115✔
1181
    case QUERY_NODE_SHOW_VTABLES_STMT:
64,455✔
1182
      return authShowVtables(pCxt, (SShowStmt*)pStmt);
64,455✔
1183
    case QUERY_NODE_SHOW_CREATE_TABLE_STMT:
104,641✔
1184
    case QUERY_NODE_SHOW_CREATE_VTABLE_STMT:
1185
    case QUERY_NODE_SHOW_CREATE_STABLE_STMT:
1186
      return authShowCreateTable(pCxt, (SShowCreateTableStmt*)pStmt);
104,641✔
1187
    case QUERY_NODE_SHOW_CREATE_VIEW_STMT:
8,849✔
1188
      return authShowCreateView(pCxt, (SShowCreateViewStmt*)pStmt);
8,849✔
1189
    case QUERY_NODE_CREATE_VIEW_STMT:
229,924✔
1190
      return authCreateView(pCxt, (SCreateViewStmt*)pStmt);
229,924✔
1191
    case QUERY_NODE_DROP_VIEW_STMT:
172,158✔
1192
      return authDropView(pCxt, (SDropViewStmt*)pStmt);
172,158✔
1193
    case QUERY_NODE_CREATE_INDEX_STMT:
23,359✔
1194
      return authCreateIndex(pCxt, (SCreateIndexStmt*)pStmt);
23,359✔
1195
    case QUERY_NODE_DROP_INDEX_STMT:
12,128✔
1196
      return authDropIndex(pCxt, (SDropIndexStmt*)pStmt);
12,128✔
1197
    case QUERY_NODE_SHOW_INDEXES_STMT:
8,199✔
1198
      return authShowIndexes(pCxt, (SShowStmt*)pStmt);
8,199✔
1199
    case QUERY_NODE_CREATE_TSMA_STMT:
9,238✔
1200
      return authCreateTsma(pCxt, (SCreateTSMAStmt*)pStmt);
9,238✔
1201
    case QUERY_NODE_DROP_TSMA_STMT:
4,383✔
1202
      return authDropTsma(pCxt, (SDropTSMAStmt*)pStmt);
4,383✔
1203
    case QUERY_NODE_CREATE_RSMA_STMT:
119,788✔
1204
      return authCreateRsma(pCxt, (SCreateRsmaStmt*)pStmt);
119,788✔
1205
    case QUERY_NODE_DROP_RSMA_STMT:
10,914✔
1206
      return authDropRsma(pCxt, (SDropRsmaStmt*)pStmt);
10,914✔
1207
    case QUERY_NODE_ALTER_RSMA_STMT:
22,296✔
1208
      return authObjPrivileges(pCxt, ((SAlterRsmaStmt*)pStmt)->dbName, ((SAlterRsmaStmt*)pStmt)->rsmaName,
22,296✔
1209
                               PRIV_CM_ALTER, PRIV_OBJ_RSMA);
1210
    case QUERY_NODE_SHOW_CREATE_RSMA_STMT:
3,497✔
1211
      return authShowCreateRsma(pCxt, (SShowCreateRsmaStmt*)pStmt);
3,497✔
1212
    case QUERY_NODE_CREATE_DATABASE_STMT:
1,688,603✔
1213
      return authCreateDatabase(pCxt, (SCreateDatabaseStmt*)pStmt);
1,688,603✔
1214
    case QUERY_NODE_BALANCE_VGROUP_STMT:
13,293✔
1215
      return authSysPrivileges(pCxt, pStmt, PRIV_VG_BALANCE);
13,293✔
1216
    case QUERY_NODE_BALANCE_VGROUP_LEADER_DATABASE_STMT:
5,237✔
1217
    case QUERY_NODE_BALANCE_VGROUP_LEADER_STMT:
1218
      return authSysPrivileges(pCxt, pStmt, PRIV_VG_BALANCE_LEADER);
5,237✔
UNCOV
1219
    case QUERY_NODE_MERGE_VGROUP_STMT:
×
UNCOV
1220
      return authSysPrivileges(pCxt, pStmt, PRIV_VG_MERGE);
×
1221
    case QUERY_NODE_SPLIT_VGROUP_STMT:
19,400✔
1222
      return authSysPrivileges(pCxt, pStmt, PRIV_VG_SPLIT);
19,400✔
1223
    case QUERY_NODE_REDISTRIBUTE_VGROUP_STMT:
49,286✔
1224
      return authSysPrivileges(pCxt, pStmt, PRIV_VG_REDISTRIBUTE);
49,286✔
1225
    case QUERY_NODE_CREATE_FUNCTION_STMT:
16,644✔
1226
      return authSysPrivileges(pCxt, pStmt, PRIV_FUNC_CREATE);
16,644✔
1227
    case QUERY_NODE_DROP_FUNCTION_STMT:
9,175✔
1228
      return authSysPrivileges(pCxt, pStmt, PRIV_FUNC_DROP);
9,175✔
1229
    case QUERY_NODE_SHOW_FUNCTIONS_STMT:
12,541✔
1230
      return authSysPrivileges(pCxt, pStmt, PRIV_FUNC_SHOW);
12,541✔
1231
    case QUERY_NODE_GRANT_STMT:
972,943✔
1232
      return authGrant(pCxt, (SGrantStmt*)pStmt);
972,943✔
1233
    case QUERY_NODE_REVOKE_STMT:
513,231✔
1234
      return authRevoke(pCxt, (SRevokeStmt*)pStmt);
513,231✔
1235
    case QUERY_NODE_CREATE_DNODE_STMT:
324,021✔
1236
    case QUERY_NODE_CREATE_MNODE_STMT:
1237
    case QUERY_NODE_CREATE_QNODE_STMT:
1238
    case QUERY_NODE_CREATE_SNODE_STMT:
1239
    case QUERY_NODE_CREATE_BNODE_STMT:
1240
    case QUERY_NODE_CREATE_ANODE_STMT:
1241
      return authSysPrivileges(pCxt, pStmt, PRIV_NODE_CREATE);
324,021✔
1242
    case QUERY_NODE_DROP_DNODE_STMT:
106,395✔
1243
    case QUERY_NODE_DROP_MNODE_STMT:
1244
    case QUERY_NODE_DROP_QNODE_STMT:
1245
    case QUERY_NODE_DROP_SNODE_STMT:
1246
    case QUERY_NODE_DROP_BNODE_STMT:
1247
    case QUERY_NODE_DROP_ANODE_STMT:
1248
      return authSysPrivileges(pCxt, pStmt, PRIV_NODE_DROP);
106,395✔
1249
    case QUERY_NODE_SHOW_TRANSACTIONS_STMT:
579,770✔
1250
    case QUERY_NODE_SHOW_TRANSACTION_DETAILS_STMT:
1251
      return authSysPrivileges(pCxt, pStmt, PRIV_TRANS_SHOW);
579,770✔
1252
    case QUERY_NODE_KILL_TRANSACTION_STMT:
625✔
1253
      return authSysPrivileges(pCxt, pStmt, PRIV_TRANS_KILL);
625✔
1254
    case QUERY_NODE_SHOW_QUERIES_STMT:
3,406✔
1255
      return authSysPrivileges(pCxt, pStmt, PRIV_QUERY_SHOW);
3,406✔
1256
    case QUERY_NODE_KILL_QUERY_STMT:
1,542✔
1257
      return authSysPrivileges(pCxt, pStmt, PRIV_QUERY_KILL);
1,542✔
1258
    case QUERY_NODE_KILL_CONNECTION_STMT:
345✔
1259
      return authSysPrivileges(pCxt, pStmt, PRIV_CONN_KILL);
345✔
1260
    case QUERY_NODE_ALTER_DATABASE_STMT:
238,160✔
1261
      return authAlterDatabase(pCxt, (SAlterDatabaseStmt*)pStmt);
238,160✔
1262
    case QUERY_NODE_ALTER_LOCAL_STMT:
572,656✔
1263
      return authAlterLocal(pCxt, (SAlterLocalStmt*)pStmt);
572,656✔
1264
    case QUERY_NODE_DROP_DATABASE_STMT:
1,432,797✔
1265
      return authDropDatabase(pCxt, (SDropDatabaseStmt*)pStmt);
1,432,797✔
1266
    case QUERY_NODE_USE_DATABASE_STMT:
99,324,460✔
1267
      return authUseDatabase(pCxt, (SUseDatabaseStmt*)pStmt);
99,324,460✔
1268
    case QUERY_NODE_FLUSH_DATABASE_STMT:
1,992,742✔
1269
      return authObjPrivileges(pCxt, ((SFlushDatabaseStmt*)pStmt)->dbName, NULL, PRIV_DB_FLUSH, PRIV_OBJ_DB);
1,992,742✔
1270
    case QUERY_NODE_COMPACT_DATABASE_STMT:
35,695✔
1271
      return authObjPrivileges(pCxt, ((SCompactDatabaseStmt*)pStmt)->dbName, NULL, PRIV_DB_COMPACT, PRIV_OBJ_DB);
35,695✔
1272
    case QUERY_NODE_TRIM_DATABASE_STMT:
11,077✔
1273
      return authObjPrivileges(pCxt, ((STrimDatabaseStmt*)pStmt)->dbName, NULL, PRIV_DB_TRIM, PRIV_OBJ_DB);
11,077✔
1274
    case QUERY_NODE_ROLLUP_DATABASE_STMT:
10,592✔
1275
      return authObjPrivileges(pCxt, ((SRollupDatabaseStmt*)pStmt)->dbName, NULL, PRIV_DB_ROLLUP, PRIV_OBJ_DB);
10,592✔
1276
    case QUERY_NODE_SCAN_DATABASE_STMT:
1,076✔
1277
      return authObjPrivileges(pCxt, ((SScanDatabaseStmt*)pStmt)->dbName, NULL, PRIV_DB_SCAN, PRIV_OBJ_DB);
1,076✔
1278
    case QUERY_NODE_SSMIGRATE_DATABASE_STMT:
3,175✔
1279
      return authObjPrivileges(pCxt, ((SSsMigrateDatabaseStmt*)pStmt)->dbName, NULL, PRIV_DB_SSMIGRATE, PRIV_OBJ_DB);
3,175✔
1280
    case QUERY_NODE_SHOW_USAGE_STMT:  // disk info
364✔
1281
      return authShowUsage(pCxt, (SShowStmt*)pStmt);
364✔
1282
    case QUERY_NODE_SHOW_APPS_STMT:
1,966✔
1283
      return authSysPrivileges(pCxt, pStmt, PRIV_APPS_SHOW);
1,966✔
1284
    case QUERY_NODE_SHOW_CLUSTER_STMT:
3,627✔
1285
      return authSysPrivileges(pCxt, pStmt, PRIV_CLUSTER_SHOW);
3,627✔
1286
    case QUERY_NODE_SHOW_SECURITY_POLICIES_STMT:
1,971✔
1287
      return authSysPrivileges(pCxt, pStmt, PRIV_SECURITY_POLICIES_SHOW); 
1,971✔
1288
      // check in mnode
1289
    case QUERY_NODE_SHOW_VGROUPS_STMT:
1,145,704✔
1290
    case QUERY_NODE_SHOW_VNODES_STMT:
1291
    case QUERY_NODE_SHOW_COMPACTS_STMT:
1292
    case QUERY_NODE_SHOW_RETENTIONS_STMT:
1293
    case QUERY_NODE_SHOW_SCANS_STMT:
1294
    case QUERY_NODE_SHOW_SSMIGRATES_STMT:
1295
      return TSDB_CODE_SUCCESS;
1,145,704✔
1296
    default:
105,840,368✔
1297
      break;
105,840,368✔
1298
  }
1299
#endif
1300
  return code;
105,840,368✔
1301
}
1302

1303
int32_t authenticate(SParseContext* pParseCxt, SQuery* pQuery, SParseMetaCache* pMetaCache) {
483,097,938✔
1304
  SAuthCxt cxt = {
483,097,938✔
1305
      .pParseCxt = pParseCxt,
1306
      .pMetaCache = pMetaCache,
1307
      .errCode = TSDB_CODE_SUCCESS,
1308
      .macNruGuaranteed = (pParseCxt->maxSecLevel >= SECURITY_LEVEL_TOP_SECRET),
483,098,471✔
1309
      .macNwdGuaranteed = (pParseCxt->minSecLevel == 0),
483,096,704✔
1310
  };
1311
#ifdef TD_ENTERPRISE
1312
  if (pParseCxt->sodInitial) {
483,098,376✔
NEW
1313
    int32_t rootNodeType = nodeType(pQuery->pRoot);
×
NEW
1314
    if (rootNodeType == QUERY_NODE_SELECT_STMT) {
×
NEW
1315
      SSelectStmt* pSelect = (SSelectStmt*)pQuery->pRoot;
×
NEW
1316
      STableNode*  pTable = (STableNode*)(pSelect->pFromTable);
×
NEW
1317
      if (NULL == pTable || QUERY_NODE_REAL_TABLE != nodeType(pTable) || !IS_INFORMATION_SCHEMA_DB(pTable->dbName) ||
×
NEW
1318
          (strcmp(pTable->tableName, TSDB_INS_TABLE_USERS) != 0)) {
×
NEW
1319
        return TSDB_CODE_MND_SOD_RESTRICTED;
×
1320
      }
NEW
1321
    } else if (rootNodeType != QUERY_NODE_GRANT_STMT && rootNodeType != QUERY_NODE_REVOKE_STMT &&
×
NEW
1322
               rootNodeType != QUERY_NODE_CREATE_USER_STMT && rootNodeType != QUERY_NODE_DROP_USER_STMT &&
×
NEW
1323
               rootNodeType != QUERY_NODE_ALTER_USER_STMT && rootNodeType != QUERY_NODE_SHOW_USERS_STMT &&
×
1324
               rootNodeType != QUERY_NODE_SHOW_SECURITY_POLICIES_STMT) {
NEW
1325
      return TSDB_CODE_MND_SOD_RESTRICTED;
×
1326
    }
1327
  }
1328
#endif
1329
  return authQuery(&cxt, pQuery->pRoot);
483,093,313✔
1330
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc